Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (271 w, 2 d)

Recent Activity

Wed, Jan 22

davide committed rGf55b033c0280: [TestStdModuleSysroot] Only run locally. (authored by davide).
[TestStdModuleSysroot] Only run locally.
Wed, Jan 22, 1:57 PM

Fri, Jan 17

davide committed rGc1bc094f361b: [TestQuoting] Use the fully qualified path for remote platforms. (authored by davide).
[TestQuoting] Use the fully qualified path for remote platforms.
Fri, Jan 17, 11:02 AM

Thu, Jan 16

davide committed rG30a8865142ab: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly. (authored by davide).
[FastISel] Lower `llvm.dbg.value(undef, ...` correctly.
Thu, Jan 16, 4:23 PM
davide closed D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..
Thu, Jan 16, 4:23 PM · debug-info, Restricted Project
davide accepted D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values..

Looks great! Thanks Adrian. My understanding is that DW_OP_piece is still incomplete, right?

Thu, Jan 16, 3:24 PM · Restricted Project
davide added a comment to D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..

@aprantl should be ready for another pass.

Thu, Jan 16, 3:24 PM · debug-info, Restricted Project
davide updated the diff for D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..
  • [FastIsel] Update comments to reflect reality.
Thu, Jan 16, 3:15 PM · debug-info, Restricted Project
davide updated the diff for D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..

Adrian's comments.

Thu, Jan 16, 3:13 PM · debug-info, Restricted Project
davide added inline comments to D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..
Thu, Jan 16, 3:03 PM · debug-info, Restricted Project
davide created D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..
Thu, Jan 16, 2:15 PM · debug-info, Restricted Project

Tue, Jan 14

davide added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

This is very good, go for it. Should we do the same for Swift? cc: @aprantl
For the future, please CC: me directly on these kind of changes if you want my review, as I might miss them otherwise.

Tue, Jan 14, 11:04 AM · Restricted Project

Mon, Jan 13

davide committed rGfb51ce10d7dc: [LanguageRuntime] Retire an unused member function. NFCI. (authored by davide).
[LanguageRuntime] Retire an unused member function. NFCI.
Mon, Jan 13, 5:46 PM

Fri, Jan 10

davide accepted D72495: [lldb] Make CompleteTagDeclsScope completion order deterministic.

LGTM

Fri, Jan 10, 11:09 AM · Restricted Project
davide added a comment to D72413: Add missing nullptr checks..

The C++ expression parser will probably behave incredibly incorrectly without a persistent state but before this patch it just crashed, so I think this is good to go.

Fri, Jan 10, 10:22 AM · Restricted Project

Thu, Jan 9

davide added a comment to D72413: Add missing nullptr checks..

@teemperor what do you think?

Thu, Jan 9, 2:47 PM · Restricted Project
davide added a comment to D72413: Add missing nullptr checks..

Should we merge this like that, or is there a better way of doing this?

Thu, Jan 9, 2:37 PM · Restricted Project

Wed, Jan 8

davide added a comment to D72413: Add missing nullptr checks..

Raphael and Jim should look at the expression evaluator bits.

Wed, Jan 8, 1:55 PM · Restricted Project
davide added a reviewer for D72413: Add missing nullptr checks.: teemperor.
Wed, Jan 8, 1:55 PM · Restricted Project

Mon, Jan 6

davide committed rG59fadc14eeb1: [NSArray] Remove a very old and deprecated formatter. (authored by davide).
[NSArray] Remove a very old and deprecated formatter.
Mon, Jan 6, 3:04 PM
davide accepted D71985: [NewPM] Fix -lto-debug-pass-manager in LLD..

LGTM.

Mon, Jan 6, 1:20 PM · Restricted Project
davide abandoned D68679: [CMake] Add a cache for iOS..

We don't need this.

Mon, Jan 6, 1:11 PM · Restricted Project
davide accepted D71379: lldbutil: Forward ASan launch info to test inferiors.

This looks good to me.

Mon, Jan 6, 11:22 AM · Restricted Project

Fri, Jan 3

davide committed rG6c87623615b3: [UserExpression] Clean up `return` after `else`. (authored by davide).
[UserExpression] Clean up `return` after `else`.
Fri, Jan 3, 4:58 PM

Dec 13 2019

davide accepted D71311: LanguageRuntime: Simplify NSException::GetSummary() output.

LGTM!

Dec 13 2019, 11:28 AM · Restricted Project

Dec 12 2019

GitHub <noreply@github.com> committed rGcd159dbf2173: Merge pull request #351 from xiaobai/no-more-index-sequence (authored by davide).
Merge pull request #351 from xiaobai/no-more-index-sequence
Dec 12 2019, 2:33 PM
GitHub <noreply@github.com> committed rGae33e4b5e452: Merge pull request #322 from apple/fixbuild (authored by davide).
Merge pull request #322 from apple/fixbuild
Dec 12 2019, 1:46 PM
davide committed rGc237dfab6bd7: [DirectoryWatcher] Fix libclang build for upstream-with-swift. (authored by davide).
[DirectoryWatcher] Fix libclang build for upstream-with-swift.
Dec 12 2019, 1:46 PM

Dec 11 2019

davide requested changes to D71311: LanguageRuntime: Simplify NSException::GetSummary() output.

Did you test on swift?

Dec 11 2019, 10:13 AM · Restricted Project
davide added a comment to D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages()..

This is not a bad idea after all. Let me see if I can cook something reasonable without getting burned.

Dec 11 2019, 9:52 AM · Restricted Project
davide added a comment to D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages()..

Ideally -- if we're able to make this a callback in the language plugins, we don't need this patch at all.

Dec 11 2019, 9:52 AM · Restricted Project

Dec 10 2019

davide created D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages()..
Dec 10 2019, 4:36 PM · Restricted Project
davide added inline comments to D71311: LanguageRuntime: Simplify NSException::GetSummary() output.
Dec 10 2019, 4:27 PM · Restricted Project
davide added a comment to D71310: RFC: Remove "Validators".

Adrian and I talked about this some more. Apparently the idea was that you have some type Foo and you want to look for some error state in instances of that type (Foo::a + Foo::b < 10). So you add a Type Validator for Foo that does this check, and every time lldb prints a variable of type Foo, it will run the Validator on it, and if it fails validation, then the printer will print an ! at the beginning of the printing, and also there's an SB API to get whether the Value passed the validator.

So then you could just debug along, and either look for the ! in the printing, or add a stop hook that checks the Validator result on all locals, and if you ever saw the error state, you would know to investigate further. That's actually a pretty neat idea.

The current state of the code is that there is actually no way to add a Type Validator. To be really useful, there would need to be a way to create a scripted validator, so the Python bindings and some command/SB API to register the validator.

The implementation is a little cut-and-paste too. It shares all the same options with the Synthetic child provider & Summaries (skips pointers, cascade, etc.) but I don't think you would ever want a type validator that would only validate references to a type, but not the type itself. And then the implementation is very cut & paste. So I'm fine with deleting this for now, but maybe adding it as an interesting project idea to the Projects page - with a reference to the hash of this commit as a starting point?

It's a neat idea but it's also been 5 years now and it was never made useful...

Dec 10 2019, 4:08 PM · Restricted Project
davide accepted D71296: Replace redundant code in LanguageCategory with templates (NFC).

LGTM, in the same vein as D71231.

Dec 10 2019, 4:08 PM · Restricted Project
davide accepted D71297: Remove unsound caching in LanguageCategory.

LGTM.

Dec 10 2019, 3:57 PM · Restricted Project
davide added a comment to D71311: LanguageRuntime: Simplify NSException::GetSummary() output.

This one looks fine -- can you please check that this patch applied on swift still produces something reasonable for mixed obj-C/swift formatters?
My guess is that it will, and you probably just need to update some tests.

Dec 10 2019, 3:57 PM · Restricted Project
davide committed rGf387b9974510: [DataFormatters] Change the Get() method to take a LanguageType. (authored by davide).
[DataFormatters] Change the Get() method to take a LanguageType.
Dec 10 2019, 3:23 PM
davide committed rGbbcdcea4bf84: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject. (authored by davide).
[TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.
Dec 10 2019, 2:59 PM
davide closed D71305: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject..
Dec 10 2019, 2:59 PM · Restricted Project
davide created D71305: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject..
Dec 10 2019, 2:46 PM · Restricted Project
davide committed rGe8d955f29de7: [FormatManager] Add a unittest for GetCandidateLanguages() (authored by davide).
[FormatManager] Add a unittest for GetCandidateLanguages()
Dec 10 2019, 1:44 PM
davide closed D71299: [FormatManager] Add a unittest for GetCandidateLanguages().
Dec 10 2019, 1:43 PM · Restricted Project
davide created D71299: [FormatManager] Add a unittest for GetCandidateLanguages().
Dec 10 2019, 1:42 PM · Restricted Project

Dec 9 2019

davide committed rGbc69dd2cfae3: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject. (authored by davide).
[FormatManager] GetCandidateLanguages shouldn't know about ValueObject.
Dec 9 2019, 5:17 PM
davide closed D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject..
Dec 9 2019, 5:17 PM · Restricted Project
davide created D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject..
Dec 9 2019, 5:07 PM · Restricted Project
davide committed rG295db41ce230: [FormatManager] Provide a single entrypoint for GetCandidateLanguages(). (authored by davide).
[FormatManager] Provide a single entrypoint for GetCandidateLanguages().
Dec 9 2019, 2:54 PM

Dec 5 2019

davide added a comment to D71093: [InstCombine] Insert instructions before adding them to worklist.

This looks fine, I wonder whether it's worth testing [how easy it's to test, that is]

Dec 5 2019, 3:17 PM · Restricted Project

Dec 3 2019

davide committed rGcec82634a403: [Process] GetLanguageRuntimes() takes an argument that's always constant. (authored by davide).
[Process] GetLanguageRuntimes() takes an argument that's always constant.
Dec 3 2019, 4:56 PM
davide committed rG11ae9dd6576e: [ClangASTContext] Remove a very old hack. (authored by davide).
[ClangASTContext] Remove a very old hack.
Dec 3 2019, 4:38 PM
davide committed rG2bb19f93f6a8: [TypeCategory] HasLanguage() is now unused. (authored by davide).
[TypeCategory] HasLanguage() is now unused.
Dec 3 2019, 3:51 PM
davide abandoned D70989: [TypeCategory] IsApplicable doesn't seem to apply..

Nevermind, I found a better way.

Dec 3 2019, 3:51 PM · Restricted Project
davide added a comment to D70989: [TypeCategory] IsApplicable doesn't seem to apply..

Please don't merge this yet. I'm mostly trying to understand if this is dead code or not.

Dec 3 2019, 3:33 PM · Restricted Project
davide created D70989: [TypeCategory] IsApplicable doesn't seem to apply..
Dec 3 2019, 3:23 PM · Restricted Project
davide committed rG89618a7ce1c1: [DataVisualization] Simplify. NFCI. (authored by davide).
[DataVisualization] Simplify. NFCI.
Dec 3 2019, 3:05 PM
davide committed rG0cfb4a6b3d95: [FormatManager] Provide only one variant of EnableCategory. (authored by davide).
[FormatManager] Provide only one variant of EnableCategory.
Dec 3 2019, 3:05 PM
davide accepted D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple.

LGTM.

Dec 3 2019, 2:08 PM · Restricted Project
davide committed rG15a172bebbc5: [TypeCategory] Nothing passes down a list of languages. (authored by davide).
[TypeCategory] Nothing passes down a list of languages.
Dec 3 2019, 1:58 PM
davide closed D70983: [TypeCategory] Nothing passes down a list of languages..
Dec 3 2019, 1:58 PM · Restricted Project
davide created D70983: [TypeCategory] Nothing passes down a list of languages..
Dec 3 2019, 1:40 PM · Restricted Project

Dec 2 2019

davide added a comment to D69273: ValueObject: Fix a crash related to children address type computation.

We've been off all the past week. I'll circle back with Jim about this once I get to the office.

Dec 2 2019, 7:37 AM · Restricted Project

Nov 22 2019

davide committed rGc32f0ff92f02: [InstCombine] Fix call guard difference with dbg (authored by davide).
[InstCombine] Fix call guard difference with dbg
Nov 22 2019, 1:39 PM
davide closed D68004: [InstCombine] Fix call guard difference with dbg.
Nov 22 2019, 1:39 PM · Restricted Project
davide added a comment to D68004: [InstCombine] Fix call guard difference with dbg.
commit c32f0ff92f024a8af438fc8d85906e441b5a2682 (HEAD -> master, origin/master, origin/HEAD)
Author: Davide Italiano <ditaliano@apple.com>
Date:   Fri Nov 22 13:02:18 2019 -0800
Nov 22 2019, 1:38 PM · Restricted Project
davide added a comment to D68004: [InstCombine] Fix call guard difference with dbg.

I'm committing this for you.

Nov 22 2019, 11:02 AM · Restricted Project

Nov 21 2019

davide added a comment to D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper..

[This is probably not the right patch, as the last run on that bot still doesn't have this commit.]

My understanding is that all pexpect tests are failing on that bot and are skipped with @skipIfAsan. Probably this one needs to be skipped too. @teemperor was trying to reproduce some of those failures locally and failed... Maybe that bot is cursed...

Nov 21 2019, 1:17 PM · Restricted Project
davide added a comment to D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper..

Hey Jordan, it looks like some of the changes to TestEditLine [or adjacent to it] broke the sanitized build on macOS.
Can I ask you to take a look? Thanks

Nov 21 2019, 11:00 AM · Restricted Project

Nov 20 2019

davide committed rG6f4398d1b995: [lldb] Fix NSURL data formatter truncation issue (authored by davide).
[lldb] Fix NSURL data formatter truncation issue
Nov 20 2019, 12:29 PM
davide added a comment to D70393: [lldb] Fix NSURL data formatter truncation issue in Swift.
commit 6f4398d1b9950d48ead91b2b550792f2bbe4778e (HEAD -> master, origin/master, origin/HEAD)
Author: Davide Italiano <ditaliano@apple.com>
Date:   Wed Nov 20 12:27:26 2019 -0800
Nov 20 2019, 12:29 PM · Restricted Project
davide accepted D70393: [lldb] Fix NSURL data formatter truncation issue in Swift.

LGTM

Nov 20 2019, 12:29 PM · Restricted Project

Nov 18 2019

davide accepted D70409: [Docs] Add reproducer documentation..

Thanks for writing this up!

Nov 18 2019, 1:52 PM · Restricted Project
davide added a comment to D70393: [lldb] Fix NSURL data formatter truncation issue in Swift.

Thanks again for your contribution!

Nov 18 2019, 1:15 PM · Restricted Project
davide accepted D70388: [lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes.
Nov 18 2019, 9:47 AM · Restricted Project
davide added a comment to D70393: [lldb] Fix NSURL data formatter truncation issue in Swift.

While I review this, can you create a corresponding change to swift.org which tests this? [I don't think we have a way of triggering this from pure Obj-C, but I may be wrong].

Nov 18 2019, 9:29 AM · Restricted Project

Nov 14 2019

davide committed rG95c770fbfb14: [Utility] Remove a dead header [PPC64LE_ehframe_Registers.h] (authored by davide).
[Utility] Remove a dead header [PPC64LE_ehframe_Registers.h]
Nov 14 2019, 3:32 PM
davide added a comment to D68179: [lldb] Fix JSON parser to allow empty arrays.

Thanks for looking at this. I will need someone to commit it for me.
However, I've been having issues with the test suite on my MacBook. check-lldb-unit works for me but check-llvm and check-lldb are hitting issues because of something wrong with my environment. So I'll need to sort this out first to verify that I haven't broken anything before it's committed. I'm hoping to spend some time this weekend to debug my setup.

Nov 14 2019, 8:16 AM · Restricted Project, Restricted Project

Nov 13 2019

davide accepted D68179: [lldb] Fix JSON parser to allow empty arrays.

Thanks for adding the tests. I took a look at the patch and it seems fine to me. Do you need somebody to commit this for you?
@jingham or @labath may want to have another look.

Nov 13 2019, 9:23 PM · Restricted Project, Restricted Project
davide committed rG294ef766e8f1: [RegisterContext] Remove now unneded vestiges. (authored by davide).
[RegisterContext] Remove now unneded vestiges.
Nov 13 2019, 2:59 PM

Nov 12 2019

davide committed rG96915495f9fc: [ObjectFileMachO] Fix the build for __arm64__. (authored by davide).
[ObjectFileMachO] Fix the build for __arm64__.
Nov 12 2019, 11:14 AM

Nov 11 2019

davide accepted D70074: [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType.

Nice!

Nov 11 2019, 10:13 AM · Restricted Project
davide added a comment to D70070: [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable.

LGTM.

Nov 11 2019, 10:04 AM · Restricted Project, Restricted Project
davide added a reviewer for D69704: [lldb] Add IsDebugInfoCompatible method to SBModule to allow checking compatibility between language versions: jingham.
Nov 11 2019, 1:47 AM · Restricted Project, Restricted Project

Nov 6 2019

davide added a comment to D69809: Wrong debug info generated at -O2 (-O0 is correct).

Go for it.

Nov 6 2019, 5:59 PM · Restricted Project, debug-info

Nov 5 2019

davide added inline comments to D69809: Wrong debug info generated at -O2 (-O0 is correct).
Nov 5 2019, 7:59 PM · Restricted Project, debug-info
davide added a comment to D69809: Wrong debug info generated at -O2 (-O0 is correct).

If I fix your patch by removing the semicolon, I see three tests failing.

Nov 5 2019, 6:02 PM · Restricted Project, debug-info
davide requested changes to D69809: Wrong debug info generated at -O2 (-O0 is correct).

uh, how can this possibly work?

Nov 5 2019, 6:02 PM · Restricted Project, debug-info
davide added a comment to D69809: Wrong debug info generated at -O2 (-O0 is correct).

I'll commit this for you later tonight.

Nov 5 2019, 4:00 PM · Restricted Project, debug-info
davide added a reviewer for D69809: Wrong debug info generated at -O2 (-O0 is correct): vsk.
Nov 5 2019, 3:42 PM · Restricted Project, debug-info
davide accepted D69809: Wrong debug info generated at -O2 (-O0 is correct).

LGTM. @aprantl / @vsk ? Do you need somebody to commit this for you?

Nov 5 2019, 3:42 PM · Restricted Project, debug-info

Nov 4 2019

davide requested changes to D69809: Wrong debug info generated at -O2 (-O0 is correct).
Nov 4 2019, 10:18 AM · Restricted Project, debug-info

Nov 2 2019

davide accepted D69747: [IPConstantProp][NFCI] Improve and modernize tests.

This patch looks good to me.

Nov 2 2019, 2:18 PM · Restricted Project
davide added a comment to D69747: [IPConstantProp][NFCI] Improve and modernize tests.

[if you probably replace opt -ipconstprop with opt -ipsccp in the tests you'll stumble upon the cases I pointed out.

Nov 2 2019, 2:18 PM · Restricted Project

Nov 1 2019

davide accepted D69714: [lldb] Provide a getter for m_materializer_up in LLVMUserExpression instead of relying on it being accessible..

LGTM.

Nov 1 2019, 11:27 AM · Restricted Project, Restricted Project

Oct 29 2019

davide committed rGd46c65592e3a: [ValueObjectDisplay] Generalize the description of an option. (authored by davide).
[ValueObjectDisplay] Generalize the description of an option.
Oct 29 2019, 5:44 PM
davide committed rG2f75858fffd0: [IndexingAction] Fix build failure due to a mismerge. (authored by davide).
[IndexingAction] Fix build failure due to a mismerge.
Oct 29 2019, 3:31 PM
davide committed rG099c5297c42c: [tools] Add private to link_target_libraries. (authored by davide).
[tools] Add private to link_target_libraries.
Oct 29 2019, 3:30 PM

Oct 28 2019

davide accepted D69523: [debugserver] Detect arch from LLVM_DEFAULT_TARGET_TRIPLE.

LGTM

Oct 28 2019, 3:16 PM

Oct 15 2019

davide added a comment to D69016: [lldb] move more things from python to cmake.

What are you trying to accomplish here?

Oct 15 2019, 8:29 PM · Restricted Project

Oct 8 2019

davide created D68679: [CMake] Add a cache for iOS..
Oct 8 2019, 6:28 PM · Restricted Project
davide accepted D68674: Remove the is_mangled flag from Mangled and Symbol.

LGTM

Oct 8 2019, 6:00 PM · Restricted Project