- User Since
- Nov 12 2014, 1:58 PM (249 w, 2 d)
Wed, Aug 21
I and Jason discussed this offline and he's fine with it, so, I'm going to land this now.
Fri, Aug 16
LGTM. It would be great if we can add a test.
Wed, Aug 14
Mon, Aug 12
More than error handling, this allows us to distinguish with a type with zero alignment (if possible at all?) and an error getting the alignment from ASTContext/
Thu, Aug 8
Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology?
I think this is definitely a good idea but Chandler or DBlaikie might want to take a look at this one too.
Wed, Aug 7
I seem to remember there was a bug where you run the expression twice and the second time it crashes/it's not evaluated correctly [at least this is what I remember talking to Lang ~18 months ago].
If that works, yay for more coverage!
You might want to check with Argyrios, maybe file a rdar against SourceKit.
Otherwise, this is fine to me.
Mon, Aug 5
Wed, Jul 31
[and Raphael for the clang vendor bits]
Really on the lldb side, Jonas is the right person to review this patch.
Tue, Jul 30
Other than that, I have no objections.
I wanted to remove it a while ago, but Jason told me he found this useful, so I would wait for his opinion.
Mon, Jul 29
Wed, Jul 24
Jul 22 2019
Minor otherwise LGTM
Jul 19 2019
See if you can write a pexpect test, as Pavel suggested.
Jul 18 2019
This is good for now. I would add a comment explaining what you explained in the differential at the beginning of the macro section.
Jul 17 2019
I don't think it's worth adding a test for the logs.
This looks good. If it bothers you a lot (given you're probably one of the few users), you can do this only under verbose (although now that's a single line is very concise).
Jul 15 2019
LGTM. Thanks. I fear this might break some bots, but the best way to see if that's the case is trying.
Jul 11 2019
This seems fairly straighforward and I'm in favor of it. We maybe should do the same thing with swift, I haven't checked in a while how we call the file there.
I wouldn't bother adding a test for something so minor.
Yeah, I'd rather have an explicit communication between debugger and debuggee.
We tried to put sleeps in the code [for e.g. lldb-mi tests in the past] and they end up failing anyway sporadically, which makes a pain to track the problem down.
Jul 10 2019
Jul 9 2019
This is adding a fair amount of complexity on something that just works fine on basically every platform but AIX.
If AIX has issue with psutil, maybe the fix should be submitted to psutil upstream instead of having this dance here?
Jul 8 2019
Jul 5 2019
Sorry for the long delay. I'm happy with this going in. @efriedma ?
I thought about this a little more, and we discussed offline, but these are my two comments (we should understand what's the behaviour and add tests). We can address some of them as follow-up but I would like to understand what happens here.
Jul 4 2019
Jun 26 2019
Jun 25 2019
Address feedback from many.
Jun 24 2019
Jun 21 2019