- User Since
- Nov 12 2014, 1:58 PM (271 w, 2 d)
Wed, Jan 22
Fri, Jan 17
Thu, Jan 16
Looks great! Thanks Adrian. My understanding is that DW_OP_piece is still incomplete, right?
@aprantl should be ready for another pass.
- [FastIsel] Update comments to reflect reality.
Tue, Jan 14
This is very good, go for it. Should we do the same for Swift? cc: @aprantl
For the future, please CC: me directly on these kind of changes if you want my review, as I might miss them otherwise.
Mon, Jan 13
Fri, Jan 10
Thu, Jan 9
@teemperor what do you think?
Wed, Jan 8
Raphael and Jim should look at the expression evaluator bits.
Mon, Jan 6
We don't need this.
This looks good to me.
Fri, Jan 3
Dec 13 2019
Dec 12 2019
Dec 11 2019
Did you test on swift?
This is not a bad idea after all. Let me see if I can cook something reasonable without getting burned.
Ideally -- if we're able to make this a callback in the language plugins, we don't need this patch at all.
Dec 10 2019
LGTM, in the same vein as D71231.
This one looks fine -- can you please check that this patch applied on swift still produces something reasonable for mixed obj-C/swift formatters?
My guess is that it will, and you probably just need to update some tests.
Dec 9 2019
Dec 5 2019
This looks fine, I wonder whether it's worth testing [how easy it's to test, that is]
Dec 3 2019
Nevermind, I found a better way.
Please don't merge this yet. I'm mostly trying to understand if this is dead code or not.
Dec 2 2019
We've been off all the past week. I'll circle back with Jim about this once I get to the office.
Nov 22 2019
commit c32f0ff92f024a8af438fc8d85906e441b5a2682 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano <email@example.com> Date: Fri Nov 22 13:02:18 2019 -0800
I'm committing this for you.
Nov 21 2019
Hey Jordan, it looks like some of the changes to TestEditLine [or adjacent to it] broke the sanitized build on macOS.
Can I ask you to take a look? Thanks
Nov 20 2019
commit 6f4398d1b9950d48ead91b2b550792f2bbe4778e (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano <firstname.lastname@example.org> Date: Wed Nov 20 12:27:26 2019 -0800
Nov 18 2019
Thanks for writing this up!
Thanks again for your contribution!
While I review this, can you create a corresponding change to swift.org which tests this? [I don't think we have a way of triggering this from pure Obj-C, but I may be wrong].
Nov 14 2019
Nov 13 2019
Nov 12 2019
Nov 11 2019
Nov 6 2019
Go for it.
Nov 5 2019
If I fix your patch by removing the semicolon, I see three tests failing.
uh, how can this possibly work?
I'll commit this for you later tonight.
Nov 4 2019
Nov 2 2019
This patch looks good to me.
[if you probably replace opt -ipconstprop with opt -ipsccp in the tests you'll stumble upon the cases I pointed out.
Nov 1 2019
Oct 29 2019
Oct 28 2019
Oct 15 2019
What are you trying to accomplish here?
Oct 8 2019