Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (435 w, 5 d)

Recent Activity

Feb 4 2023

davide added a comment to rGc294bdd64768: libLTO.{so,dylib}: remove unused non-LTO symbols.

Steven, Let's discuss this offline and come back with a proposal.

Feb 4 2023, 12:47 PM · Restricted Project, Restricted Project

Jan 25 2023

davide accepted D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert.
Jan 25 2023, 6:12 PM · Unknown Object (Project), Restricted Project
davide added a comment to D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert.

LGTM

Jan 25 2023, 6:12 PM · Unknown Object (Project), Restricted Project

Jan 11 2023

davide added reviewers for D141491: LoopIdiom: avoid patterned memset if constant is not relocatable.: nikic, fhahn.
Jan 11 2023, 12:08 PM · Restricted Project, Restricted Project
davide accepted D141491: LoopIdiom: avoid patterned memset if constant is not relocatable..

LGTM

Jan 11 2023, 12:07 PM · Restricted Project, Restricted Project

Dec 22 2022

davide added a comment to D140224: [Driver] Revert D139717 and add -Xparser instead.

I'll reject [-\Xparser for a while as well. This is a valid amendment to D139717 , so I don't think it needs more approval.

We have projects that are failing because of -Xlinker and I'm not too excited about walking through every project we have to find more examples. Can we please have a reprieve on deprecating this until every project in the world that uses these flags that have existed for a very long time can have a chance to at least get timely notification? Why is this any different than anything else that gets deprecated?

Thank you for your reply! If there are more issues -Xlinker/-Xparser/-Xcctests, ok, I think I'm fine with a Joined -X, but ideally we can figure out a way to apply that only to Apple platforms.

(FWIW I feel sad when I made valid objection to D139717, but that patch landed very soon after your colleague approved it, leaving me no time to object.
My other objection included the insufficient commit message -Xfoo instead of what's actually used, internal builds which seems to hint an internal workaround, where the tests are located)

Dec 22 2022, 3:28 PM · Restricted Project, Restricted Project
davide added a comment to D140224: [Driver] Revert D139717 and add -Xparser instead.

@MaskRay Roy hasn't replied. We found other spellings that break (e.g. -Xcctests or something). Revert this patch until we find an agreement.

D139717 (this patch reverts) was pushed when I made valid comments which were ignored. I did not complain for that.

I don't mind if you work around -Xcctests in a similar way.

Working around 3 cases creates more complexity than it fixes.
We're also not providing a deprecation path for users. This needs to be discussed more thoroughly. I'll go ahead and revert to the previous status.

Thanks.

Have you seen https://reviews.llvm.org/D139717#4001712 I have analyzed that such -X* has -Wunused-command-line-argument warning for many many years.
I'm not sure how is considered insufficient.

"Working around 3 cases creates more complexity than it fixes." the number isn't that high. By enumerating the misuse, we have a valid path to remove all workarounds as misuses are fixed.
This made some forward progress.

Dec 22 2022, 2:59 PM · Restricted Project, Restricted Project
davide added a comment to D140224: [Driver] Revert D139717 and add -Xparser instead.

@MaskRay Roy hasn't replied. We found other spellings that break (e.g. -Xcctests or something). Revert this patch until we find an agreement.

D139717 (this patch reverts) was pushed when I made valid comments which were ignored. I did not complain for that.

I don't mind if you work around -Xcctests in a similar way.

Dec 22 2022, 2:55 PM · Restricted Project, Restricted Project
davide reopened D140224: [Driver] Revert D139717 and add -Xparser instead.

@MaskRay Roy hasn't replied. We found other spellings that break (e.g. -Xcctests or something). Revert this patch until we find an agreement.

Dec 22 2022, 2:35 PM · Restricted Project, Restricted Project

Dec 16 2022

davide added a comment to D140224: [Driver] Revert D139717 and add -Xparser instead.

Fine if Roy is happy. If we find another thing that break, we'll let you know. Please wait for him to comment.

Dec 16 2022, 9:47 AM · Restricted Project, Restricted Project
davide added a comment to D139717: Revert "[Driver] Remove Joined -X".

Xlinker still works. Xcompiler is failing.

A google search will show that Xcompiler is a wide-spread option used by many packages. Whether or not GCC supports it is not relevant. Please do not remove options just because you do not use them.

Can you give an example how they use -Xcompiler?

% gcc -Xcompiler,-fpic -c a.c
gcc: error: unrecognized command-line option ‘-Xcompiler,-fpic’
% gcc -Xcompiler -fpic -c a.c
gcc: error: unrecognized command-line option ‘-Xcompiler’; did you mean ‘--compile’?

My commit message clearly says why the joined form is awkward and should be removed.
It seems that the many occurrences you found are likely for GNU libtool (-Xcompiler foo -Wc,foo), not for Clang Driver.

This is not about the philosophical correctness of the patch, it's about the transition period and allowing consumers to migrate.
If you want remove options, provide a deprecation window, and then remove. Noone is objecting about that.

-Xparser has always been leading to such a warning: warning: argument unused during compilation: '-Xparser' [-Wunused-command-line-argument], perhaps since forever when the option was added in the first place?
The message is different from ... deprecation ... but isn't it sufficient as well?

Dec 16 2022, 9:30 AM · Restricted Project, Restricted Project
davide added a comment to D139717: Revert "[Driver] Remove Joined -X".

Xlinker still works. Xcompiler is failing.

A google search will show that Xcompiler is a wide-spread option used by many packages. Whether or not GCC supports it is not relevant. Please do not remove options just because you do not use them.

Can you give an example how they use -Xcompiler?

% gcc -Xcompiler,-fpic -c a.c
gcc: error: unrecognized command-line option ‘-Xcompiler,-fpic’
% gcc -Xcompiler -fpic -c a.c
gcc: error: unrecognized command-line option ‘-Xcompiler’; did you mean ‘--compile’?

My commit message clearly says why the joined form is awkward and should be removed.
It seems that the many occurrences you found are likely for GNU libtool (-Xcompiler foo -Wc,foo), not for Clang Driver.

Dec 16 2022, 9:15 AM · Restricted Project, Restricted Project

Dec 15 2022

davide accepted D139717: Revert "[Driver] Remove Joined -X".

LGTM

Dec 15 2022, 3:58 PM · Restricted Project, Restricted Project
davide added a comment to D139717: Revert "[Driver] Remove Joined -X".

This change is breaking internal builds. We use the -Xfoo pattern but can now no longer manage whether we allow an unused -Xfoo option to pass as a warning or promote it to an error.

Which -Xfoo is used? Do your internal builds reserve -Xfoo as a placeholder to do other non-upstream work? Then you can consider -Gfoo if your builds don't need the mips semantics.

We use -Xparser

There are two possibilities.

First, your downstream projects incorrectly pass a previously-ignored -Xparser. Then it seems the right call is to remove it.

Dec 15 2022, 9:13 AM · Restricted Project, Restricted Project

Dec 13 2022

davide added a comment to D139717: Revert "[Driver] Remove Joined -X".

This change is breaking internal builds. We use the -Xfoo pattern but can now no longer manage whether we allow an unused -Xfoo option to pass as a warning or promote it to an error.

Which -Xfoo is used? Do your internal builds reserve -Xfoo as a placeholder to do other non-upstream work? Then you can consider -Gfoo if your builds don't need the mips semantics.
Is it possible to clean up the previously-ignored-with-a-warning -Xfoo?

Dec 13 2022, 10:12 AM · Restricted Project, Restricted Project

Dec 9 2022

davide added a comment to D139717: Revert "[Driver] Remove Joined -X".

This is missing a test, like the original commit mentioned.
Why can you not just use the the split variant, -X clang ...?

Dec 9 2022, 9:11 AM · Restricted Project, Restricted Project

Dec 8 2022

davide added a comment to D138602: [WIP] Alwaysinliner time explosion with new pass manager.

@t.p.northover regardless of whether this meets the bar, this is a test case that takes forever reduced from a real project.
We should have a solution upstream and this is the purpose of the patch. Downstream can't live with hacks forever.
Do you have any thoughts?

Dec 8 2022, 10:09 AM · Restricted Project, Restricted Project

Dec 7 2022

davide added a comment to D138602: [WIP] Alwaysinliner time explosion with new pass manager.

An interesting alternative might be limiting this to when we're optimizing for size. Not sure if it sounds good for you, but maybe it's better than a cl::opt.

Dec 7 2022, 12:03 PM · Restricted Project, Restricted Project
davide added a comment to D138602: [WIP] Alwaysinliner time explosion with new pass manager.

sorry, this fell between the cracks

are the alwaysinline attributes added purely for optimization purposes (counterexample, I've seen cases for testing where they are to make sure the number of frames is consistent)? if so I'd try removing literally every alwaysinline attribute and seeing what performance difference that makes

Dec 7 2022, 12:01 PM · Restricted Project, Restricted Project
davide added a comment to D138602: [WIP] Alwaysinliner time explosion with new pass manager.

@aeubanks @davidxl can we get some movement on this one, please?

Dec 7 2022, 10:47 AM · Restricted Project, Restricted Project

Dec 1 2022

davide added a comment to D138947: [Clang] Adjust assert from Sema::BuildCXXTypeConstructExpr.

LGTM, again.

Dec 1 2022, 9:24 AM · Restricted Project, Restricted Project

Nov 30 2022

davide accepted D138947: [Clang] Adjust assert from Sema::BuildCXXTypeConstructExpr.

LGTM with the comment reworded. Thanks.

Nov 30 2022, 9:37 PM · Restricted Project, Restricted Project
davide added a comment to D138947: [Clang] Adjust assert from Sema::BuildCXXTypeConstructExpr.

Exprs.size() == 1 is still valid in every example we've seen, so yes, you might want to keep it (and update the assertion message)

Nov 30 2022, 5:08 PM · Restricted Project, Restricted Project
davide added a comment to D138602: [WIP] Alwaysinliner time explosion with new pass manager.

@aeubanks Gentle ping

Nov 30 2022, 10:14 AM · Restricted Project, Restricted Project

Nov 28 2022

davide added a comment to D138486: X86: relax EFLAGS liveness check when generating stack probes..

@RKSimon / @pengfei ping

Nov 28 2022, 12:01 PM · Restricted Project, Restricted Project

Nov 23 2022

davide added a comment to D138602: [WIP] Alwaysinliner time explosion with new pass manager.

To elaborate further, the testcase in the project issue reported is reduced from a preprocessed file that's approximately 1 million lines.
Even if people would like the remove always_inline -- it's very hard to understand where to start (and, realistically, it's a jenga tower of optimizations + templates).

Nov 23 2022, 2:39 PM · Restricted Project, Restricted Project
davide added a comment to D138602: [WIP] Alwaysinliner time explosion with new pass manager.

Hi @aeubanks -- admittedly I haven't touched the inliner in a very long time so I might be wrong here, but my understanding is that alwaysinline trumps the cost multiplier (that's why the previous patch is not enough).

Nov 23 2022, 2:35 PM · Restricted Project, Restricted Project
davide requested review of D138602: [WIP] Alwaysinliner time explosion with new pass manager.
Nov 23 2022, 1:14 PM · Restricted Project, Restricted Project
davide added a comment to D121084: [NewPM][Inliner] Make inlined calls to functions in same SCC as callee exponentially expensive.

Hey folks, this is still not enough. We're seeing exponential behaviors when linking real-world projects.

Nov 23 2022, 1:04 PM · Restricted Project, Restricted Project

Nov 22 2022

davide committed rG0c011335c9c6: [X86] Don't lower f16->f80 fpext to libcall on darwin. (authored by davide).
[X86] Don't lower f16->f80 fpext to libcall on darwin.
Nov 22 2022, 12:32 PM · Restricted Project, Restricted Project

Nov 16 2022

davide added a reviewer for D137979: parse: process GNU and standard attributes on top-level decls: arphaman.
Nov 16 2022, 3:12 PM · Restricted Project, Restricted Project

Apr 27 2022

davide accepted D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

LGTM

Apr 27 2022, 7:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
davide added a comment to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

Thanks for the feedback!

The binary compatibility issue is non-existent on arm64, but it could be still a thing on x86_64.

Can we enable OmitDwarfIfHaveCompactUnwind by default on arm64 then? And have it be opt-in just for x86_64?

Apr 27 2022, 7:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
davide requested changes to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

Compact unwind was developed as a goal to replace the DWARF unwind. Some apps did not work if the OS was missing DWARF unwind, so we kept both for Intel. The binary compatibility issue is non-existent on arm64, but it could be still a thing on x86_64.
If a function cannot be encoded in CU, we need the compiler to emit both (where the CU is a magic value that points to the dwarf unwind info for that function).

Apr 27 2022, 5:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 7 2022

davide abandoned D121159: llvm-nm should flush and error check output.
Mar 7 2022, 10:56 PM · Restricted Project, Restricted Project
davide added a comment to D121159: llvm-nm should flush and error check output.

The pre-merge check is failing to build this patch.

There are loads of LLVM tools that print to stdout. This "fixes" just one of them. If there is an issue, it's in all the tools, so needs patching somewhere else. I'm also not convinced it should be needed:

I think this is for UNIX03 compliance. Not all the tools have to be compliant.

Perhaps not, but there's presumably a good reason for compliance requirements. Anyway, I'd be surprised if llvm-nm is any more special than e.g. llvm-readelf or llvm-objdump in this area.

  1. stdout is flushed on exit automatically: https://stackoverflow.com/questions/15911517/is-there-a-guarantee-of-stdout-auto-flush-before-exit-how-does-it-work

If stdout is flushed before exit, that's fine. What about stderr ?

stderr is unbuffered. It shouldn't need flushing.

How does explicit flushing help us with output errors. More importantly, why do we care?

We care for POSIX compliance. Apple can keep this patch downstream, but I don't see the harm of having this one here.

Harm comes from having code that is unnecessary, since it does nothing that doesn't automatically happen. Future developers will come along and see it and delete it because it appears to be pointless. You didn't answer the first half of that comment though: how does explicit flushing help us? The patch description talks about error checking a stream, but this modification doesn't seem to do anything of the sort.

Mar 7 2022, 10:56 PM · Restricted Project, Restricted Project
davide added a comment to D121159: llvm-nm should flush and error check output.

The pre-merge check is failing to build this patch.

There are loads of LLVM tools that print to stdout. This "fixes" just one of them. If there is an issue, it's in all the tools, so needs patching somewhere else. I'm also not convinced it should be needed:

Mar 7 2022, 10:03 PM · Restricted Project, Restricted Project
davide added a comment to D121159: llvm-nm should flush and error check output.

I don't run POSIX compliance, somebody just gave me a patch, but yes, good point.

Mar 7 2022, 1:52 PM · Restricted Project, Restricted Project
davide requested review of D121159: llvm-nm should flush and error check output.
Mar 7 2022, 1:50 PM · Restricted Project, Restricted Project
davide abandoned D113456: Allow protocol metadata to be deduplicated within dylibs.

We fixed this in the linker.

Mar 7 2022, 1:48 PM · Restricted Project, Restricted Project

Nov 8 2021

davide requested review of D113456: Allow protocol metadata to be deduplicated within dylibs.
Nov 8 2021, 9:44 PM · Restricted Project, Restricted Project

Oct 22 2021

davide added a comment to D112124: [ThinLTO] Append original object file name to ThinLTO generated object file's name, so that it can be recorded in link map file..

The best solution might still be the linker to map the intermediate file to the original object file since the added file name here is still another level of indirection you need to figure out. @davide for his opinion.

Oct 22 2021, 10:46 AM · Restricted Project

Aug 6 2021

davide committed rG5b9a94414eb9: [MachO] Introduce chained fixups related load commands. (authored by davide).
[MachO] Introduce chained fixups related load commands.
Aug 6 2021, 12:38 PM

May 19 2021

davide removed a reviewer for D93838: [SCCP] Add Function Specialization pass: davide.
May 19 2021, 10:33 AM · Restricted Project

Apr 27 2021

davide edited reviewers for D100322: [ConstantMerge] Don't merge thread_local constants with non-thread_local constants, added: fhahn; removed: davide.
Apr 27 2021, 11:10 PM · Restricted Project

Apr 20 2021

davide removed a reviewer for D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529): davide.
Apr 20 2021, 11:55 AM · Restricted Project

Mar 22 2021

davide added a comment to D99105: [lld-macho] LTO: Unset VisibleToRegularObj where possible.

removing davide
+ steven

Mar 22 2021, 12:50 PM · Restricted Project, Restricted Project
davide edited reviewers for D99105: [lld-macho] LTO: Unset VisibleToRegularObj where possible, added: steven_wu; removed: davide.
Mar 22 2021, 12:50 PM · Restricted Project, Restricted Project

Mar 17 2021

davide accepted D98739: [Object][MachO] Handle end iterator in getSymbolType().

Sure.

Mar 17 2021, 12:37 PM · Restricted Project

Mar 11 2021

davide added a comment to D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue".

+ Lang, who probably has a better understanding of this, for visibility.
I don't think this should be blocked further, but he might have a chance to comment.

Mar 11 2021, 3:40 PM · Restricted Project
davide added a reviewer for D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue": lhames.
Mar 11 2021, 3:40 PM · Restricted Project
davide accepted D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue".

LGTM.

Mar 11 2021, 3:39 PM · Restricted Project
davide added a comment to D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue".

Mach-O doesn't support dso_local and this change broke XNU because of the use of dso_local.

Can you elaborate on the unsupportness? For example, the backend can ignore dso_local if it does not want to support it.

The main purpose is to reduce target differences: currently both COFF and ELF can use dso_local. If Mach-O doesn't like dso_local, there is an additional difference.

Mar 11 2021, 3:39 PM · Restricted Project

Feb 26 2021

davide removed a reviewer for D85770: Build a flat LLDB.framework for embedded Darwin targets: davide.
Feb 26 2021, 5:34 PM · Unknown Object (Project)

Jan 11 2021

davide removed a reviewer for D94448: [NewPM] Run non-trivial loop unswitching under -O2/3/s/z: davide.
Jan 11 2021, 1:59 PM · Restricted Project

Dec 7 2020

davide removed a reviewer for D92488: [LICM] Add a maximum for the number of instructions to be hoisted: davide.
Dec 7 2020, 11:22 AM · Restricted Project

Dec 1 2020

davide added a comment to D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

I apologize, but I don't work on this anymore.

Dec 1 2020, 2:26 PM · Restricted Project
davide removed a reviewer for D92431: [SROA] Remove Dead Instructions while creating speculative instructions: davide.
Dec 1 2020, 2:25 PM · Restricted Project

Oct 23 2020

davide removed a reviewer for D78972: Treat hasWeakODRLinkage symbols as external in REPL computations: davide.
Oct 23 2020, 3:12 PM · Unknown Object (Project)

Oct 12 2020

davide added a comment to D88468: [llvm-readobj] Don't print out section names for STABS symbols.

I'm sorry, I haven't touched this code in a long time and I don't feel qualified to review it.

Oct 12 2020, 2:23 PM · Restricted Project
davide removed a reviewer for D88468: [llvm-readobj] Don't print out section names for STABS symbols: davide.
Oct 12 2020, 2:23 PM · Restricted Project

Sep 21 2020

davide closed D88061: [Testsuite] allow a linker to be specified.
Sep 21 2020, 6:06 PM
davide added a comment to D88061: [Testsuite] allow a linker to be specified.

Committed thusly

Sep 21 2020, 6:06 PM
davide requested review of D88061: [Testsuite] allow a linker to be specified.
Sep 21 2020, 5:57 PM

Sep 14 2020

davide committed rG26c293c23d3b: [BinaryFormat/MachO] Add a missing constant. (authored by davide).
[BinaryFormat/MachO] Add a missing constant.
Sep 14 2020, 10:31 PM

Sep 3 2020

davide abandoned D82495: [Apple Silicon] Support attach by name correctly for Rosetta..

This landed in a different form.

Sep 3 2020, 12:51 PM
davide closed D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files.

Somebody will pick this up, probably in a different form.

Sep 3 2020, 12:51 PM
davide abandoned D80602: [BranchFolding] Drop location when hoisting.

I won't have time to look at this in the future.

Sep 3 2020, 12:51 PM · Restricted Project

Aug 27 2020

davide accepted D86722: [lldb] Make lldb-argdumper a dependency of liblldb.
Aug 27 2020, 9:21 AM · Unknown Object (Project)

Aug 24 2020

davide added inline comments to D86436: [lldb] Fix Type::GetByteSize for pointer types.
Aug 24 2020, 10:26 AM · Unknown Object (Project)
davide updated subscribers of D86436: [lldb] Fix Type::GetByteSize for pointer types.

@labath something I noticed when finding this (and related bugs) is that frame var carries a decent diagnostic

Aug 24 2020, 10:23 AM · Unknown Object (Project)
davide added inline comments to D86436: [lldb] Fix Type::GetByteSize for pointer types.
Aug 24 2020, 10:15 AM · Unknown Object (Project)
davide accepted D86436: [lldb] Fix Type::GetByteSize for pointer types.

I came to the same conclusion when analyzing https://bugs.llvm.org/show_bug.cgi?id=47257 (but you beat me to the punch).

Aug 24 2020, 9:26 AM · Unknown Object (Project)

Aug 21 2020

davide added a comment to D86337: Remove raw_sha1_ostream.

I think this is fine. @mehdi_amini ?

Aug 21 2020, 10:48 AM · Restricted Project
davide accepted D86338: Remove TaskQueue.
Aug 21 2020, 10:47 AM · Restricted Project

Aug 14 2020

davide committed rG0cceb54366b4: [TestPtrRefsObjC] Prefer `command script import`. (authored by davide).
[TestPtrRefsObjC] Prefer `command script import`.
Aug 14 2020, 3:31 PM
davide committed rG8fcfe2862fd4: [TestPtrRefs] Prefer `command script import`. (authored by davide).
[TestPtrRefs] Prefer `command script import`.
Aug 14 2020, 3:31 PM

Aug 11 2020

davide added a reviewer for D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.: vsk.
Aug 11 2020, 11:04 AM · Restricted Project, Unknown Object (Project)

Aug 5 2020

davide added a comment to D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

auto_ptr is deprecated since C++11 and will be removed in C++17.

Aug 5 2020, 10:28 PM · Unknown Object (Project)
davide accepted D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

This is correct to the best of my understanding. Thank you Jason.

Aug 5 2020, 10:04 PM · Unknown Object (Project)
davide accepted D85388: [lldb] Fix bug in skipIfRosetta decorator.

yes, this makes sense. We could refine the check in future.

Aug 5 2020, 8:48 PM · Unknown Object (Project)
davide added inline comments to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 5 2020, 6:00 PM · Unknown Object (Project)
davide requested changes to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 5 2020, 5:58 PM · Unknown Object (Project)
davide added inline comments to D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary.
Aug 5 2020, 4:08 PM · Unknown Object (Project)
davide accepted D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests..

I assume we're still allowing to put the decorator on a test-by-test basis, and that seems the case from what I see.
If so, LG.

Aug 5 2020, 3:19 PM · Unknown Object (Project)

Aug 4 2020

davide accepted D85172: Teach SROA to handle allocas with more than one dbg.declare..

LGTM with Saleem's comment addressed.

Aug 4 2020, 1:52 PM · Restricted Project, debug-info

Aug 3 2020

davide closed D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7

Aug 3 2020, 3:43 PM

Jul 30 2020

davide committed rG57605758b5de: [debugserver/Apple Silicon] Handoff connections when attaching to translated… (authored by davide).
[debugserver/Apple Silicon] Handoff connections when attaching to translated…
Jul 30 2020, 4:21 PM
davide accepted D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

Reviewed by Jason privately.

Jul 30 2020, 4:20 PM
davide updated the diff for D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

Added the check that Jason requested.

Jul 30 2020, 4:07 PM

Jul 28 2020

davide added a comment to D84220: [IPSCCP] Fix a bug that the "returned" attribute is not cleared when function is optimized to return undef.

Florian, can you take a look?

Jul 28 2020, 12:35 PM · Restricted Project, Restricted Project

Jul 22 2020

davide requested changes to D84272: Add checks for ValueObjectSP in Cocoa summary providers.

why? Do you have a testcase?

Jul 22 2020, 4:33 PM · Unknown Object (Project)
davide accepted D84333: build: always add support for assembly targets on Darwin.
Jul 22 2020, 2:57 PM · Restricted Project
davide added a comment to D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

yeah, I think it's reasonable.

Jul 22 2020, 12:45 PM

Jul 21 2020

davide created D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.
Jul 21 2020, 12:16 PM

Jul 20 2020

davide committed rGb1a6d373d5e0: [PlatformMacOSX] Remove unused variable. NFC. (authored by davide).
[PlatformMacOSX] Remove unused variable. NFC.
Jul 20 2020, 9:19 PM
davide committed rGcd05406b1053: [testsuite] Adapt lldb-server base test helper to run on arm64 (authored by davide).
[testsuite] Adapt lldb-server base test helper to run on arm64
Jul 20 2020, 9:18 PM
davide committed rG001c8e1fd9f0: [PlatformDarwin] Add support for Apple Silicon. (authored by davide).
[PlatformDarwin] Add support for Apple Silicon.
Jul 20 2020, 9:18 PM

Jul 14 2020

davide committed rG61cf9f4e723b: [ObjectFilePECOFF] Try to avoid unaligned access. (authored by davide).
[ObjectFilePECOFF] Try to avoid unaligned access.
Jul 14 2020, 6:53 PM
GitHub <noreply@github.com> committed rG6b2ea6155b2a: Merge pull request #1426 from Teemperor/cherry/de0175d04bc3679c7bd8dc64520e790b… (authored by davide).
Merge pull request #1426 from Teemperor/cherry/de0175d04bc3679c7bd8dc64520e790b…
Jul 14 2020, 4:57 PM