Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (240 w, 6 d)

Recent Activity

Today

davide committed rG97017a8ef9c9: [CMake] Check that a certificate for lldb is present at build time. (authored by davide).
[CMake] Check that a certificate for lldb is present at build time.
Tue, Jun 25, 10:14 AM
davide committed rL364334: [CMake] Check that a certificate for lldb is present at build time..
[CMake] Check that a certificate for lldb is present at build time.
Tue, Jun 25, 10:14 AM
davide closed D63745: [CMake] Check that a certificate for lldb is present at build time..
Tue, Jun 25, 10:13 AM · Restricted Project, Restricted Project
davide updated the diff for D63745: [CMake] Check that a certificate for lldb is present at build time..

Address feedback from many.

Tue, Jun 25, 9:57 AM · Restricted Project, Restricted Project
davide added a comment to D63745: [CMake] Check that a certificate for lldb is present at build time..

This code should go to tools/debugserver/source/CMakeLists.txt so that it is next to the code which performs the actual code signing. Doing that will make it easier to keep it in sync with changes to code signing, as well as make it obvious that it is not in sync with them right now (there's a pretty complex interaction of various cmake options (LLDB_CODESIGN_IDENTITY, LLVM_CODESIGNING_IDENTITY, LLDB_USE_SYSTEM_DEBUGSERVER, etc.) which affects code signing, and this code is ignoring all of those)...

Tue, Jun 25, 7:48 AM · Restricted Project, Restricted Project

Yesterday

davide added a comment to D63745: [CMake] Check that a certificate for lldb is present at build time..

rdar://problem/52078735

Mon, Jun 24, 4:49 PM · Restricted Project, Restricted Project
davide created D63745: [CMake] Check that a certificate for lldb is present at build time..
Mon, Jun 24, 4:46 PM · Restricted Project, Restricted Project

Fri, Jun 21

davide accepted D63679: [lit] Make lit-lldb-init configurable by CMake.

LGTM.

Fri, Jun 21, 4:09 PM · Restricted Project, Restricted Project

Thu, Jun 20

davide committed rG0cdae2681a28: Revert "Fix a crash in option parsing." (authored by davide).
Revert "Fix a crash in option parsing."
Thu, Jun 20, 4:44 PM
davide committed rL363999: Revert "Fix a crash in option parsing.".
Revert "Fix a crash in option parsing."
Thu, Jun 20, 4:42 PM

Wed, Jun 19

davide added a comment to D63488: [docs] Phabricator, not the lists is the main entry point for new patches.

I see the point; certainly when someone emails a patch, the first response is almost always "can you put this on Phab."

There was talk at some point about connecting Phab with github authentication, somehow? If people can use an existing account then the you-need-to-register-first objection goes away.

Wed, Jun 19, 11:52 AM · Restricted Project

Fri, Jun 14

davide accepted D62743: Add color to the default thread and frame format..

LGTM!

Fri, Jun 14, 2:55 PM · Restricted Project, Restricted Project
davide added a comment to D62743: Add color to the default thread and frame format..

Can you add a screenshot of the final result for everybody?

Fri, Jun 14, 2:54 PM · Restricted Project, Restricted Project

Thu, Jun 13

davide added a comment to D63311: Python 3: decode string as utf-8 to avoid type mismatch..

yes.

Thu, Jun 13, 8:25 PM · Restricted Project, Restricted Project
davide accepted D63310: Make crashlog.py less noisy.
Thu, Jun 13, 5:38 PM · Restricted Project, Restricted Project

Wed, Jun 5

davide committed rGecf3ae4a7032: [NativeProcessDarwin] Remove dead code. NFCI. (authored by davide).
[NativeProcessDarwin] Remove dead code. NFCI.
Wed, Jun 5, 1:21 PM
davide committed rL362639: [NativeProcessDarwin] Remove dead code. NFCI..
[NativeProcessDarwin] Remove dead code. NFCI.
Wed, Jun 5, 1:21 PM

Wed, May 29

davide committed rG192dd7df2f31: [crashlog] Add a missing call to decode. (authored by davide).
[crashlog] Add a missing call to decode.
Wed, May 29, 5:37 PM
davide committed rL362044: [crashlog] Add a missing call to decode..
[crashlog] Add a missing call to decode.
Wed, May 29, 5:37 PM
davide committed rLLDB362044: [crashlog] Add a missing call to decode..
[crashlog] Add a missing call to decode.
Wed, May 29, 5:37 PM

May 24 2019

davide added a comment to D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName.

To elaborate further, I'm not familiar with this code so I really shouldn't be the person to approve the patch. On the other hand I'm somewhat nervous as refactors in this area of the codebase caused bugs/crashes in lldb, fundamentally due to changes in behavior previously left untested.

May 24 2019, 9:51 AM · Restricted Project
davide resigned from D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName.

I don't think I'm qualified enough to comment further on this patch.

May 24 2019, 9:34 AM · Restricted Project
davide requested changes to D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName.

Do you have a testcase?

May 24 2019, 9:02 AM · Restricted Project

May 23 2019

davide accepted D62284: Replace integer literals which are cast to bool.

LGTM

May 23 2019, 5:30 PM · Restricted Project

May 21 2019

davide added a comment to D62216: [EditLine] Rewrite GetHistoryFilePath.

What if ~ is not writable either? I think we shouldn't fallback.

May 21 2019, 3:19 PM · Restricted Project
davide accepted D62219: [FileSystem] Fix regression in FileSystem::Resolve.

LGTM, also discussed in person.

May 21 2019, 2:41 PM · Restricted Project

May 17 2019

davide committed rG8803124d234e: [crashlog] Use loads() instead of readPlistFromString() for python 3. (authored by davide).
[crashlog] Use loads() instead of readPlistFromString() for python 3.
May 17 2019, 6:56 PM
davide committed rLLDB361087: [crashlog] Use loads() instead of readPlistFromString() for python 3..
[crashlog] Use loads() instead of readPlistFromString() for python 3.
May 17 2019, 6:55 PM
davide committed rL361087: [crashlog] Use loads() instead of readPlistFromString() for python 3..
[crashlog] Use loads() instead of readPlistFromString() for python 3.
May 17 2019, 6:55 PM
davide committed rG53f68c576468: [EditLine] Check string pointers before dereferencing them. (authored by davide).
[EditLine] Check string pointers before dereferencing them.
May 17 2019, 2:48 PM
davide committed rL361078: [EditLine] Check string pointers before dereferencing them..
[EditLine] Check string pointers before dereferencing them.
May 17 2019, 2:48 PM
davide committed rLLDB361078: [EditLine] Check string pointers before dereferencing them..
[EditLine] Check string pointers before dereferencing them.
May 17 2019, 2:48 PM

May 16 2019

davide committed rGd768ee214075: [CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt. (authored by davide).
[CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt.
May 16 2019, 6:03 PM
davide committed rLLDB360966: [CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt..
[CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt.
May 16 2019, 6:03 PM
davide committed rL360966: [CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt..
[CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt.
May 16 2019, 6:03 PM

May 14 2019

davide committed rG092f85a594d0: [lit/Register] Fix matching of the output. (authored by davide).
[lit/Register] Fix matching of the output.
May 14 2019, 4:15 PM
davide committed rL360725: [lit/Register] Fix matching of the output..
[lit/Register] Fix matching of the output.
May 14 2019, 4:15 PM
davide committed rLLDB360725: [lit/Register] Fix matching of the output..
[lit/Register] Fix matching of the output.
May 14 2019, 4:15 PM

May 13 2019

davide accepted D61872: [CMake] Simplify lldb-server handling.

LGTM

May 13 2019, 2:21 PM · Restricted Project
davide added inline comments to D61872: [CMake] Simplify lldb-server handling.
May 13 2019, 2:21 PM · Restricted Project

May 10 2019

davide requested changes to D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo().

What's the scenario that's causing this? Adding a nullptr check is an obviously save thing to do, but it would be excellent if we could add a comment explaining why the symbol could be nullptr.
I also do believe that the logic for checking whether the symbol is nullptr can be hoisted to the beginning of the function, see comment inline.

May 10 2019, 6:32 PM

May 3 2019

davide added inline comments to D61533: Make lldb-mi optional and change how we deal with missing tools in lit.
May 3 2019, 1:29 PM · Restricted Project

May 1 2019

davide accepted D61414: [test] Convert TestWatchpointSetErrorCases.py to lit.

LGTM

May 1 2019, 5:31 PM · Restricted Project
davide accepted D61406: [CommandObjectCommands] Honor stop-command-source-on-error .

LGTM

May 1 2019, 4:55 PM · Restricted Project

Apr 30 2019

davide accepted D61299: Rename Minion to ASTImporterDelegate.

yay :)

Apr 30 2019, 7:54 AM · Restricted Project, Restricted Project

Apr 28 2019

davide added inline comments to D61235: Add more information to the log timer dump.
Apr 28 2019, 7:47 PM · Restricted Project, Restricted Project
davide accepted D61244: Re-enable gmodules tests on Linux.

LGTM

Apr 28 2019, 4:14 PM · Restricted Project

Apr 26 2019

davide accepted D61191: Editline: Fix an msan error.

LGTM but this should really be fixed upstream (in libedit)

Apr 26 2019, 8:17 AM · Restricted Project

Apr 25 2019

davide committed rG2d6e156e403a: [TestTemplateFunction] Add a missing debug info variant. (authored by davide).
[TestTemplateFunction] Add a missing debug info variant.
Apr 25 2019, 3:52 PM
davide committed rL359249: [TestTemplateFunction] Add a missing debug info variant..
[TestTemplateFunction] Add a missing debug info variant.
Apr 25 2019, 3:51 PM
davide committed rLLDB359249: [TestTemplateFunction] Add a missing debug info variant..
[TestTemplateFunction] Add a missing debug info variant.
Apr 25 2019, 3:51 PM

Apr 24 2019

davide committed rG4f88388c0bc7: [utils] Add a lldb data formatter for llvm::SmallString. (authored by davide).
[utils] Add a lldb data formatter for llvm::SmallString.
Apr 24 2019, 5:02 PM
davide committed rL359157: [utils] Add a lldb data formatter for llvm::SmallString..
[utils] Add a lldb data formatter for llvm::SmallString.
Apr 24 2019, 5:02 PM
davide added a comment to D61090: [SBHostOS} Remove getting the python script interpreter path.

While the intentions of exposing this are good, the implementation leaks too many details. In fact, there shouldn't be anything outside of ScriptInterpreter guarded by LLDB_DISABLE_PYTHON.
You might want also to realize that having ePathTypePythonDir goes against the whole notion of a generic pluggable interpreter.
Imagine tomorrow somebody wants to implement support for another language, what would this call return for it?

Apr 24 2019, 2:54 PM · Restricted Project
davide added a comment to D61090: [SBHostOS} Remove getting the python script interpreter path.

@clayborg I would also like to point out that some of us fair amount of time cleaning LLDB_DISABLE_PYTHON leaking all over the codebase, and this is basically the last occurrence, so we're motivated to have this going away/fixed in some way.

Apr 24 2019, 2:54 PM · Restricted Project
davide committed rG6e619075466d: [EditLineTests] Call setenv() before editline is initialized. (authored by davide).
[EditLineTests] Call setenv() before editline is initialized.
Apr 24 2019, 11:40 AM
davide committed rLLDB359124: [EditLineTests] Call setenv() before editline is initialized..
[EditLineTests] Call setenv() before editline is initialized.
Apr 24 2019, 11:37 AM
davide committed rL359124: [EditLineTests] Call setenv() before editline is initialized..
[EditLineTests] Call setenv() before editline is initialized.
Apr 24 2019, 11:37 AM

Apr 23 2019

davide committed rGbdb864a5762e: Revert "[EditLineTest] Not always TERM is available, e.g. on some bots." (authored by davide).
Revert "[EditLineTest] Not always TERM is available, e.g. on some bots."
Apr 23 2019, 9:50 AM
davide committed rL359011: Revert "[EditLineTest] Not always TERM is available, e.g. on some bots.".
Revert "[EditLineTest] Not always TERM is available, e.g. on some bots."
Apr 23 2019, 9:49 AM
davide committed rLLDB359011: Revert "[EditLineTest] Not always TERM is available, e.g. on some bots.".
Revert "[EditLineTest] Not always TERM is available, e.g. on some bots."
Apr 23 2019, 9:49 AM

Apr 22 2019

davide committed rG2a27af82379e: [EditLineTest] Not always TERM is available, e.g. on some bots. (authored by davide).
[EditLineTest] Not always TERM is available, e.g. on some bots.
Apr 22 2019, 1:26 PM
davide committed rL358918: [EditLineTest] Not always TERM is available, e.g. on some bots..
[EditLineTest] Not always TERM is available, e.g. on some bots.
Apr 22 2019, 1:25 PM
davide committed rLLDB358918: [EditLineTest] Not always TERM is available, e.g. on some bots..
[EditLineTest] Not always TERM is available, e.g. on some bots.
Apr 22 2019, 1:25 PM

Apr 18 2019

davide committed rG185de8eeaaae: [Python] Simplify the code. NFCI. (authored by davide).
[Python] Simplify the code. NFCI.
Apr 18 2019, 4:23 PM
davide committed rL358721: [Python] Simplify the code. NFCI..
[Python] Simplify the code. NFCI.
Apr 18 2019, 4:23 PM
davide committed rLLDB358721: [Python] Simplify the code. NFCI..
[Python] Simplify the code. NFCI.
Apr 18 2019, 4:23 PM
davide committed rG085626a873e0: [crashlog] Strip trailing `\n` from check_output return. (authored by davide).
[crashlog] Strip trailing `\n` from check_output return.
Apr 18 2019, 2:34 PM
davide committed rLLDB358717: [crashlog] Strip trailing `\n` from check_output return..
[crashlog] Strip trailing `\n` from check_output return.
Apr 18 2019, 2:34 PM
davide committed rL358717: [crashlog] Strip trailing `\n` from check_output return..
[crashlog] Strip trailing `\n` from check_output return.
Apr 18 2019, 2:34 PM

Apr 17 2019

davide committed rG5f4c6dcc11ac: [Cmake] Add missing dependency for running tests. (authored by davide).
[Cmake] Add missing dependency for running tests.
Apr 17 2019, 4:42 PM
davide committed rLLDB358625: [Cmake] Add missing dependency for running tests..
[Cmake] Add missing dependency for running tests.
Apr 17 2019, 4:42 PM
davide committed rL358625: [Cmake] Add missing dependency for running tests..
[Cmake] Add missing dependency for running tests.
Apr 17 2019, 4:42 PM
davide committed rGe3b5eba1bad1: [crashlog] Use the right path for dsymforUUID and remove an unnecessary import. (authored by davide).
[crashlog] Use the right path for dsymforUUID and remove an unnecessary import.
Apr 17 2019, 2:52 PM
davide committed rLLDB358615: [crashlog] Use the right path for dsymforUUID and remove an unnecessary import..
[crashlog] Use the right path for dsymforUUID and remove an unnecessary import.
Apr 17 2019, 2:52 PM
davide committed rL358615: [crashlog] Use the right path for dsymforUUID and remove an unnecessary import..
[crashlog] Use the right path for dsymforUUID and remove an unnecessary import.
Apr 17 2019, 2:52 PM

Apr 16 2019

davide accepted D60802: Implement sys::fs::copy_file using the macOS copyfile(3) API to support APFS clones.
Apr 16 2019, 6:23 PM · Restricted Project
davide committed rGb2930b86311d: [tools] Only build lldb-test when needed. (authored by davide).
[tools] Only build lldb-test when needed.
Apr 16 2019, 2:55 PM
davide committed rLLDB358533: [tools] Only build lldb-test when needed..
[tools] Only build lldb-test when needed.
Apr 16 2019, 2:54 PM
davide committed rL358533: [tools] Only build lldb-test when needed..
[tools] Only build lldb-test when needed.
Apr 16 2019, 2:54 PM
davide committed rG6df6895d90b5: [tools] Make vscode and lldb-instr optional. (authored by davide).
[tools] Make vscode and lldb-instr optional.
Apr 16 2019, 2:14 PM
davide committed rL358528: [tools] Make vscode and lldb-instr optional..
[tools] Make vscode and lldb-instr optional.
Apr 16 2019, 2:14 PM
davide committed rLLDB358528: [tools] Make vscode and lldb-instr optional..
[tools] Make vscode and lldb-instr optional.
Apr 16 2019, 2:14 PM
davide closed D60780: [tools] Only build lldb-instr and lldb-vscode if asked..
Apr 16 2019, 2:14 PM · Restricted Project
davide updated the diff for D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

Jonas' comments

Apr 16 2019, 2:05 PM · Restricted Project
davide updated the diff for D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

updated.

Apr 16 2019, 1:16 PM · Restricted Project
davide added a comment to D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

OK, on it.

Apr 16 2019, 10:26 AM · Restricted Project
davide created D60780: [tools] Only build lldb-instr and lldb-vscode if asked..
Apr 16 2019, 9:20 AM · Restricted Project

Apr 13 2019

davide accepted D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift.

Add an unittest maybe? otherwise, seems to match the ISA so LGTM

Apr 13 2019, 2:59 PM · Restricted Project, Restricted Project

Apr 11 2019

davide added a comment to D60581: [ValueLattice] Add forceconstant, for SCCP..

I'm not necessarily sure I like this. It's simply spreading in a general framework a concept that shouldn't exist to begin with. I'd rather remove forced constant from SCCP, even though it might result in us losing some optimization power.

Apr 11 2019, 2:00 PM · Restricted Project

Apr 5 2019

davide added a comment to D60300: [testsuite] Split Objective-C data formatter.

I think this is good regardless for readability, but I would really appreciate if we can collect some numbers to see how effective this change actually is.

I see 120 -> 12 seconds on my iMac Pro.

Nice! Might be nice to have some automated info that gets dumped when one file with multiple tests takes a long time and suggest breaking them up in the python test infrastructure modules. Might be other nice gains to be had?

Apr 5 2019, 11:09 AM · Restricted Project, Restricted Project
davide added a comment to D60300: [testsuite] Split Objective-C data formatter.

I think this is good regardless for readability, but I would really appreciate if we can collect some numbers to see how effective this change actually is.

I see 120 -> 12 seconds on my iMac Pro.

Nice! Might be nice to have some automated info that gets dumped when one file with multiple tests takes a long time and suggest breaking them up in the python test infrastructure modules. Might be other nice gains to be had?

lit has this feature. It's called --time-tests. That's how we discovered the problem. There are other tests that we can fix.

--Davide

Apr 5 2019, 11:09 AM · Restricted Project, Restricted Project
davide accepted D60300: [testsuite] Split Objective-C data formatter.

great!

Apr 5 2019, 10:54 AM · Restricted Project, Restricted Project

Apr 4 2019

davide added a comment to D60300: [testsuite] Split Objective-C data formatter.

I think this is good regardless for readability, but I would really appreciate if we can collect some numbers to see how effective this change actually is.

Apr 4 2019, 6:45 PM · Restricted Project, Restricted Project

Apr 2 2019

davide accepted D60113: [ArgPromotion] Set debug location at updated callsites.

Thanks.

Apr 2 2019, 10:26 AM · Restricted Project

Apr 1 2019

davide added a comment to D60092: [Process] Use early returns in Process::WriteMemory (NFC).

LGTM. Med, what do you think?

Apr 1 2019, 1:25 PM · Restricted Project, Restricted Project
davide accepted D60022: [Process] Fix WriteMemory return value.

LGTM

Apr 1 2019, 11:59 AM · Restricted Project, Restricted Project

Mar 29 2019

davide added inline comments to D60022: [Process] Fix WriteMemory return value.
Mar 29 2019, 6:52 PM · Restricted Project, Restricted Project

Mar 28 2019

davide accepted D59911: Don't abort() in lldb_assert and document why..

LGTM

Mar 28 2019, 3:45 PM · Restricted Project, Restricted Project
davide added a comment to D59911: Don't abort() in lldb_assert and document why..

Thanks for summarizing your thoughts, Davide.

I think that what you wrote is a much better explanation of what I was trying to say with

Use these sparingly and only if error handling is not otherwise feasible.

I think that unless we can eliminate all uses of lldb_assert() from the code we should document it, but discourage its use. Do you have any suggestions for a better wording?

Mar 28 2019, 3:05 PM · Restricted Project, Restricted Project