Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (249 w, 2 d)

Recent Activity

Wed, Aug 21

davide committed rG0a8e634b3bb9: [lldb] Replace std::once_flag with llvm::once_flag. (authored by davide).
[lldb] Replace std::once_flag with llvm::once_flag.
Wed, Aug 21, 8:18 PM
davide committed rL369618: [lldb] Replace std::once_flag with llvm::once_flag..
[lldb] Replace std::once_flag with llvm::once_flag.
Wed, Aug 21, 8:18 PM
davide closed D66566: [lldb] Replace std::once_flag with llvm::once_flag..
Wed, Aug 21, 8:17 PM · Restricted Project, Restricted Project
davide added a comment to D66566: [lldb] Replace std::once_flag with llvm::once_flag..

I and Jason discussed this offline and he's fine with it, so, I'm going to land this now.

Wed, Aug 21, 5:53 PM · Restricted Project, Restricted Project
davide created D66566: [lldb] Replace std::once_flag with llvm::once_flag..
Wed, Aug 21, 4:35 PM · Restricted Project, Restricted Project

Fri, Aug 16

davide added a comment to D66354: Add LLDB dataformatters for llvm::StringRef and lldb_private::ConstString.

LGTM. It would be great if we can add a test.

Fri, Aug 16, 10:17 AM · Restricted Project

Wed, Aug 14

davide added inline comments to D66241: stop-hooks don't fire on "step-out".
Wed, Aug 14, 2:31 PM · Restricted Project, Restricted Project
davide added inline comments to D66241: stop-hooks don't fire on "step-out".
Wed, Aug 14, 1:15 PM · Restricted Project, Restricted Project

Mon, Aug 12

davide committed rG7f9bbe059977: [CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign. (authored by davide).
[CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign.
Mon, Aug 12, 2:52 PM
davide committed rL368620: [CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign..
[CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign.
Mon, Aug 12, 2:49 PM
davide accepted D66102: [Symbol] Decouple clang from CompilerType.

LGTM

Mon, Aug 12, 2:23 PM · Restricted Project, Restricted Project
davide committed rG36f13e49127e: [Symbol] GetTypeBitAlign() should return None in case of failure. (authored by davide).
[Symbol] GetTypeBitAlign() should return None in case of failure.
Mon, Aug 12, 1:04 PM
davide committed rL368614: [Symbol] GetTypeBitAlign() should return None in case of failure..
[Symbol] GetTypeBitAlign() should return None in case of failure.
Mon, Aug 12, 1:04 PM
davide closed D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..
Mon, Aug 12, 1:04 PM · Restricted Project, Restricted Project
davide added inline comments to D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..
Mon, Aug 12, 11:20 AM · Restricted Project, Restricted Project
davide added a comment to D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..

More than error handling, this allows us to distinguish with a type with zero alignment (if possible at all?) and an error getting the alignment from ASTContext/

Mon, Aug 12, 11:15 AM · Restricted Project, Restricted Project
davide added a reviewer for D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.: aprantl.
Mon, Aug 12, 9:30 AM · Restricted Project, Restricted Project
davide created D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..
Mon, Aug 12, 9:30 AM · Restricted Project, Restricted Project

Thu, Aug 8

davide added a comment to D65874: [lldb][CMake] Disable modules in Xcode projects.

Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology?

Thu, Aug 8, 9:45 AM · Restricted Project, Restricted Project
davide added a reviewer for D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef: chandlerc.
Thu, Aug 8, 9:44 AM · Restricted Project, Restricted Project
davide added a comment to D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef.

I think this is definitely a good idea but Chandler or DBlaikie might want to take a look at this one too.

Thu, Aug 8, 9:44 AM · Restricted Project, Restricted Project

Wed, Aug 7

davide committed rGe04c62bb2362: [Materializer] Remove wrong SetSizeAndAlignmentFromType(). (authored by davide).
[Materializer] Remove wrong SetSizeAndAlignmentFromType().
Wed, Aug 7, 8:18 PM
davide committed rL368249: [Materializer] Remove wrong SetSizeAndAlignmentFromType()..
[Materializer] Remove wrong SetSizeAndAlignmentFromType().
Wed, Aug 7, 8:18 PM
davide accepted D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references..

I seem to remember there was a bug where you run the expression twice and the second time it crashes/it's not evaluated correctly [at least this is what I remember talking to Lang ~18 months ago].
If that works, yay for more coverage!

Wed, Aug 7, 9:51 AM · Restricted Project
davide accepted D65874: [lldb][CMake] Disable modules in Xcode projects.

You might want to check with Argyrios, maybe file a rdar against SourceKit.
Otherwise, this is fine to me.

Wed, Aug 7, 9:19 AM · Restricted Project, Restricted Project

Mon, Aug 5

davide added a reviewer for D65784: [lldb] delete "--platform-path" option from "target create": jasonmolenda.
Mon, Aug 5, 6:22 PM · Restricted Project
davide committed rG78f05d3599f3: Revert "[CompilerType] Simplify the interface a bit more.." (authored by davide).
Revert "[CompilerType] Simplify the interface a bit more.."
Mon, Aug 5, 5:44 PM
davide committed rL367963: Revert "[CompilerType] Simplify the interface a bit more..".
Revert "[CompilerType] Simplify the interface a bit more.."
Mon, Aug 5, 5:44 PM
davide added a comment to D65782: [CompilerType] Simplify the interface a bit more...

I was marked as a review on this, but I suspect you intended to get some other Alex :-)

Mon, Aug 5, 5:08 PM · Restricted Project, Restricted Project
davide committed rGb31f60b9c2e7: [CompilerType] Simplify the interface a bit more.. (authored by davide).
[CompilerType] Simplify the interface a bit more..
Mon, Aug 5, 5:02 PM
davide committed rL367957: [CompilerType] Simplify the interface a bit more...
[CompilerType] Simplify the interface a bit more..
Mon, Aug 5, 5:02 PM
davide closed D65782: [CompilerType] Simplify the interface a bit more...
Mon, Aug 5, 5:02 PM · Restricted Project, Restricted Project
davide created D65782: [CompilerType] Simplify the interface a bit more...
Mon, Aug 5, 4:31 PM · Restricted Project, Restricted Project
davide committed rGd32d5db4daca: [CompilerType] Remove an unused function. (authored by davide).
[CompilerType] Remove an unused function.
Mon, Aug 5, 4:23 PM
davide committed rL367946: [CompilerType] Remove an unused function..
[CompilerType] Remove an unused function.
Mon, Aug 5, 4:23 PM
davide closed D65781: [CompilerType] Remove an unused function..
Mon, Aug 5, 4:23 PM · Restricted Project, Restricted Project
davide created D65781: [CompilerType] Remove an unused function..
Mon, Aug 5, 4:14 PM · Restricted Project, Restricted Project

Wed, Jul 31

davide accepted D65547: [Reproducers] Force replay in synchronous mode..

Thanks!

Wed, Jul 31, 4:19 PM · Restricted Project, Restricted Project
davide added a comment to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.

[and Raphael for the clang vendor bits]

Wed, Jul 31, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
davide added a reviewer for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure: teemperor.
Wed, Jul 31, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
davide added a comment to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.

Really on the lldb side, Jonas is the right person to review this patch.

Wed, Jul 31, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
davide added a reviewer for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure: JDevlieghere.
Wed, Jul 31, 1:55 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 30

davide added a comment to D65469: Remove `bugreport` command.

Other than that, I have no objections.

Tue, Jul 30, 12:25 PM · Restricted Project
davide added a comment to D65469: Remove `bugreport` command.

I wanted to remove it a while ago, but Jason told me he found this useful, so I would wait for his opinion.

Tue, Jul 30, 12:23 PM · Restricted Project

Mon, Jul 29

davide committed rG9a5fbc816341: [Symbolication] Remove some dead code. Nothing exciting. (authored by davide).
[Symbolication] Remove some dead code. Nothing exciting.
Mon, Jul 29, 2:28 PM
davide committed rGf80c72be20c8: [Symbolication] Remove a duplicate assignment. (authored by davide).
[Symbolication] Remove a duplicate assignment.
Mon, Jul 29, 2:28 PM
davide committed rGacc626bc57c7: [Symbolication] Fix unicode compatibility between 2 and 3. (authored by davide).
[Symbolication] Fix unicode compatibility between 2 and 3.
Mon, Jul 29, 2:28 PM
davide committed rL367262: [Symbolication] Remove some dead code. Nothing exciting..
[Symbolication] Remove some dead code. Nothing exciting.
Mon, Jul 29, 2:28 PM
davide committed rL367261: [Symbolication] Remove a duplicate assignment..
[Symbolication] Remove a duplicate assignment.
Mon, Jul 29, 2:28 PM
davide committed rL367260: [Symbolication] Fix unicode compatibility between 2 and 3..
[Symbolication] Fix unicode compatibility between 2 and 3.
Mon, Jul 29, 2:28 PM

Wed, Jul 24

davide accepted D65222: [IPSCCP] Add assertion to surface cases where we zap returns with overdefined users..

LGTM.

Wed, Jul 24, 5:12 PM · Restricted Project

Jul 22 2019

davide accepted D65116: [Driver] Set the default win32-macho debug format to DWARF.

Minor otherwise LGTM

Jul 22 2019, 2:43 PM · Restricted Project

Jul 19 2019

davide accepted D64936: [Local] Zap blockaddress without users in ConstantFoldTerminator..
Jul 19 2019, 3:51 PM · Restricted Project
davide requested changes to D64995: [lldb] Fix crash when tab-completing in multi-line expr.

See if you can write a pexpect test, as Pavel suggested.

Jul 19 2019, 3:51 PM · Restricted Project, Restricted Project
davide accepted D64989: [lldb] Fix crash when looking up type coming from the ClangModuleDeclVendor.

No brainer.

Jul 19 2019, 3:51 PM · Restricted Project, Restricted Project

Jul 18 2019

davide accepted D64917: Add offsetof support to expression evaluator..

This is good for now. I would add a comment explaining what you explained in the differential at the beginning of the macro section.
Great work!

Jul 18 2019, 8:07 AM · Restricted Project

Jul 17 2019

davide added a comment to D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose.

I don't think it's worth adding a test for the logs.

Jul 17 2019, 9:31 AM · Restricted Project, Restricted Project
davide accepted D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose.

This looks good. If it bothers you a lot (given you're probably one of the few users), you can do this only under verbose (although now that's a single line is very concise).

Jul 17 2019, 8:36 AM · Restricted Project, Restricted Project
davide added a comment to D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule.

That real

Jul 17 2019, 8:27 AM · Restricted Project
davide added inline comments to D64853: Fix CommandInterpreter for _regex-break with options.
Jul 17 2019, 8:15 AM · Restricted Project
davide updated subscribers of D64853: Fix CommandInterpreter for _regex-break with options.
Jul 17 2019, 8:15 AM · Restricted Project
davide added inline comments to D64853: Fix CommandInterpreter for _regex-break with options.
Jul 17 2019, 8:11 AM · Restricted Project

Jul 15 2019

davide accepted D64782: [SWIG] Deprecate SWIG 1.x .

LGTM. Thanks. I fear this might break some bots, but the best way to see if that's the case is trying.

Jul 15 2019, 6:02 PM · Restricted Project, Restricted Project

Jul 11 2019

davide accepted D64546: [lldb] Make TestDeletedExecutable more reliable.
Jul 11 2019, 8:36 AM · Restricted Project, Restricted Project
davide accepted D64545: [lldb] Don't use __FUNCTION__ as a file name.

This seems fairly straighforward and I'm in favor of it. We maybe should do the same thing with swift, I haven't checked in a while how we call the file there.
I wouldn't bother adding a test for something so minor.

Jul 11 2019, 7:40 AM · Restricted Project, Restricted Project
davide added a comment to D64546: [lldb] Make TestDeletedExecutable more reliable.

Yeah, I'd rather have an explicit communication between debugger and debuggee.
We tried to put sleeps in the code [for e.g. lldb-mi tests in the past] and they end up failing anyway sporadically, which makes a pain to track the problem down.

Jul 11 2019, 7:39 AM · Restricted Project, Restricted Project

Jul 10 2019

davide committed rG89ed2e0a0afb: [scripts] Remove the unused 'shush' script. (authored by davide).
[scripts] Remove the unused 'shush' script.
Jul 10 2019, 11:15 AM
davide committed rL365677: [scripts] Remove the unused 'shush' script..
[scripts] Remove the unused 'shush' script.
Jul 10 2019, 11:14 AM

Jul 9 2019

davide requested changes to D64251: Don't depend on psutil on AIX.

This is adding a fair amount of complexity on something that just works fine on basically every platform but AIX.
If AIX has issue with psutil, maybe the fix should be submitted to psutil upstream instead of having this dance here?

Jul 9 2019, 5:11 PM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2019

davide committed rG68946d10ad3b: [crashlog] Fix a mismatch between bytes and strings. (authored by davide).
[crashlog] Fix a mismatch between bytes and strings.
Jul 8 2019, 6:06 PM
davide committed rL365416: [crashlog] Fix a mismatch between bytes and strings..
[crashlog] Fix a mismatch between bytes and strings.
Jul 8 2019, 6:05 PM
davide added inline comments to D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration.
Jul 8 2019, 2:56 PM · Restricted Project, Restricted Project
davide added inline comments to D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration.
Jul 8 2019, 2:47 PM · Restricted Project, Restricted Project

Jul 5 2019

davide added inline comments to D64267: lldb_assert: abort when assertions are enabled..
Jul 5 2019, 2:22 PM · Restricted Project, Restricted Project
davide accepted D64267: lldb_assert: abort when assertions are enabled..
Jul 5 2019, 2:20 PM · Restricted Project, Restricted Project
davide committed rGee7b1ce665eb: [CplusPlus] ISVTableName is unused. NFCI. (authored by davide).
[CplusPlus] ISVTableName is unused. NFCI.
Jul 5 2019, 1:47 PM
davide committed rL365243: [CplusPlus] ISVTableName is unused. NFCI..
[CplusPlus] ISVTableName is unused. NFCI.
Jul 5 2019, 1:46 PM
davide closed D64265: [CplusPlus] ISVTableName is unused. NFCI..
Jul 5 2019, 1:45 PM · Restricted Project, Restricted Project
davide added a comment to D60582: [IPSCCP] Add general integer range support..

Sorry for the long delay. I'm happy with this going in. @efriedma ?

Jul 5 2019, 1:34 PM · Restricted Project
davide created D64265: [CplusPlus] ISVTableName is unused. NFCI..
Jul 5 2019, 1:25 PM · Restricted Project, Restricted Project
davide accepted D64254: Add lldb-mi deprecation to the release notes.

LGTM

Jul 5 2019, 11:23 AM · Restricted Project, Restricted Project
davide added a comment to D64194: [lldb] Fix crash due to unicode characters and dollars in variable names..

I thought about this a little more, and we discussed offline, but these are my two comments (we should understand what's the behaviour and add tests). We can address some of them as follow-up but I would like to understand what happens here.

Jul 5 2019, 10:42 AM · Restricted Project
davide edited reviewers for D64255: Remove lldb-mi, added: davide, labath, teemperor; removed: jfb.
Jul 5 2019, 10:31 AM · Restricted Project

Jul 4 2019

davide added inline comments to D64194: [lldb] Fix crash due to unicode characters and dollars in variable names..
Jul 4 2019, 9:47 AM · Restricted Project
davide requested changes to D64194: [lldb] Fix crash due to unicode characters and dollars in variable names..
Jul 4 2019, 9:43 AM · Restricted Project

Jun 26 2019

davide committed rG4201ed2ea385: [x86-64] Use `//` for integer division in the target definition. (authored by davide).
[x86-64] Use `//` for integer division in the target definition.
Jun 26 2019, 12:54 PM
davide committed rL364465: [x86-64] Use `//` for integer division in the target definition..
[x86-64] Use `//` for integer division in the target definition.
Jun 26 2019, 12:52 PM
davide added inline comments to D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue.
Jun 26 2019, 9:50 AM · Restricted Project
davide accepted D63790: [dotest] Add the ability to set environment variables for the inferior..
Jun 26 2019, 9:10 AM · Restricted Project, Restricted Project

Jun 25 2019

davide committed rG97017a8ef9c9: [CMake] Check that a certificate for lldb is present at build time. (authored by davide).
[CMake] Check that a certificate for lldb is present at build time.
Jun 25 2019, 10:14 AM
davide committed rL364334: [CMake] Check that a certificate for lldb is present at build time..
[CMake] Check that a certificate for lldb is present at build time.
Jun 25 2019, 10:14 AM
davide closed D63745: [CMake] Check that a certificate for lldb is present at build time..
Jun 25 2019, 10:13 AM · Restricted Project, Restricted Project
davide updated the diff for D63745: [CMake] Check that a certificate for lldb is present at build time..

Address feedback from many.

Jun 25 2019, 9:57 AM · Restricted Project, Restricted Project
davide added a comment to D63745: [CMake] Check that a certificate for lldb is present at build time..

This code should go to tools/debugserver/source/CMakeLists.txt so that it is next to the code which performs the actual code signing. Doing that will make it easier to keep it in sync with changes to code signing, as well as make it obvious that it is not in sync with them right now (there's a pretty complex interaction of various cmake options (LLDB_CODESIGN_IDENTITY, LLVM_CODESIGNING_IDENTITY, LLDB_USE_SYSTEM_DEBUGSERVER, etc.) which affects code signing, and this code is ignoring all of those)...

Jun 25 2019, 7:48 AM · Restricted Project, Restricted Project

Jun 24 2019

davide added a comment to D63745: [CMake] Check that a certificate for lldb is present at build time..

rdar://problem/52078735

Jun 24 2019, 4:49 PM · Restricted Project, Restricted Project
davide created D63745: [CMake] Check that a certificate for lldb is present at build time..
Jun 24 2019, 4:46 PM · Restricted Project, Restricted Project

Jun 21 2019

davide accepted D63679: [lit] Make lit-lldb-init configurable by CMake.

LGTM.

Jun 21 2019, 4:09 PM · Restricted Project, Restricted Project

Jun 20 2019

davide committed rG0cdae2681a28: Revert "Fix a crash in option parsing." (authored by davide).
Revert "Fix a crash in option parsing."
Jun 20 2019, 4:44 PM
davide committed rL363999: Revert "Fix a crash in option parsing.".
Revert "Fix a crash in option parsing."
Jun 20 2019, 4:42 PM

Jun 19 2019

davide added a comment to D63488: [docs] Phabricator, not the lists is the main entry point for new patches.

I see the point; certainly when someone emails a patch, the first response is almost always "can you put this on Phab."

There was talk at some point about connecting Phab with github authentication, somehow? If people can use an existing account then the you-need-to-register-first objection goes away.

Jun 19 2019, 11:52 AM · Restricted Project