Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (231 w, 2 d)

Recent Activity

Thu, Apr 18

davide committed rG185de8eeaaae: [Python] Simplify the code. NFCI. (authored by davide).
[Python] Simplify the code. NFCI.
Thu, Apr 18, 4:23 PM
davide committed rL358721: [Python] Simplify the code. NFCI..
[Python] Simplify the code. NFCI.
Thu, Apr 18, 4:23 PM
davide committed rLLDB358721: [Python] Simplify the code. NFCI..
[Python] Simplify the code. NFCI.
Thu, Apr 18, 4:23 PM
davide committed rG085626a873e0: [crashlog] Strip trailing `\n` from check_output return. (authored by davide).
[crashlog] Strip trailing `\n` from check_output return.
Thu, Apr 18, 2:34 PM
davide committed rLLDB358717: [crashlog] Strip trailing `\n` from check_output return..
[crashlog] Strip trailing `\n` from check_output return.
Thu, Apr 18, 2:34 PM
davide committed rL358717: [crashlog] Strip trailing `\n` from check_output return..
[crashlog] Strip trailing `\n` from check_output return.
Thu, Apr 18, 2:34 PM

Wed, Apr 17

davide committed rG5f4c6dcc11ac: [Cmake] Add missing dependency for running tests. (authored by davide).
[Cmake] Add missing dependency for running tests.
Wed, Apr 17, 4:42 PM
davide committed rLLDB358625: [Cmake] Add missing dependency for running tests..
[Cmake] Add missing dependency for running tests.
Wed, Apr 17, 4:42 PM
davide committed rL358625: [Cmake] Add missing dependency for running tests..
[Cmake] Add missing dependency for running tests.
Wed, Apr 17, 4:42 PM
davide committed rGe3b5eba1bad1: [crashlog] Use the right path for dsymforUUID and remove an unnecessary import. (authored by davide).
[crashlog] Use the right path for dsymforUUID and remove an unnecessary import.
Wed, Apr 17, 2:52 PM
davide committed rLLDB358615: [crashlog] Use the right path for dsymforUUID and remove an unnecessary import..
[crashlog] Use the right path for dsymforUUID and remove an unnecessary import.
Wed, Apr 17, 2:52 PM
davide committed rL358615: [crashlog] Use the right path for dsymforUUID and remove an unnecessary import..
[crashlog] Use the right path for dsymforUUID and remove an unnecessary import.
Wed, Apr 17, 2:52 PM

Tue, Apr 16

davide accepted D60802: Implement sys::fs::copy_file using the macOS copyfile(3) API to support APFS clones.
Tue, Apr 16, 6:23 PM · Restricted Project
davide committed rGb2930b86311d: [tools] Only build lldb-test when needed. (authored by davide).
[tools] Only build lldb-test when needed.
Tue, Apr 16, 2:55 PM
davide committed rLLDB358533: [tools] Only build lldb-test when needed..
[tools] Only build lldb-test when needed.
Tue, Apr 16, 2:54 PM
davide committed rL358533: [tools] Only build lldb-test when needed..
[tools] Only build lldb-test when needed.
Tue, Apr 16, 2:54 PM
davide committed rG6df6895d90b5: [tools] Make vscode and lldb-instr optional. (authored by davide).
[tools] Make vscode and lldb-instr optional.
Tue, Apr 16, 2:14 PM
davide committed rL358528: [tools] Make vscode and lldb-instr optional..
[tools] Make vscode and lldb-instr optional.
Tue, Apr 16, 2:14 PM
davide committed rLLDB358528: [tools] Make vscode and lldb-instr optional..
[tools] Make vscode and lldb-instr optional.
Tue, Apr 16, 2:14 PM
davide closed D60780: [tools] Only build lldb-instr and lldb-vscode if asked..
Tue, Apr 16, 2:14 PM · Restricted Project
davide updated the diff for D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

Jonas' comments

Tue, Apr 16, 2:05 PM · Restricted Project
davide updated the diff for D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

updated.

Tue, Apr 16, 1:16 PM · Restricted Project
davide added a comment to D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

OK, on it.

Tue, Apr 16, 10:26 AM · Restricted Project
davide created D60780: [tools] Only build lldb-instr and lldb-vscode if asked..
Tue, Apr 16, 9:20 AM · Restricted Project

Sat, Apr 13

davide accepted D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift.

Add an unittest maybe? otherwise, seems to match the ISA so LGTM

Sat, Apr 13, 2:59 PM · Restricted Project

Thu, Apr 11

davide added a comment to D60581: [ValueLattice] Add forceconstant, for SCCP..

I'm not necessarily sure I like this. It's simply spreading in a general framework a concept that shouldn't exist to begin with. I'd rather remove forced constant from SCCP, even though it might result in us losing some optimization power.

Thu, Apr 11, 2:00 PM · Restricted Project

Fri, Apr 5

davide added a comment to D60300: [testsuite] Split Objective-C data formatter.

I think this is good regardless for readability, but I would really appreciate if we can collect some numbers to see how effective this change actually is.

I see 120 -> 12 seconds on my iMac Pro.

Nice! Might be nice to have some automated info that gets dumped when one file with multiple tests takes a long time and suggest breaking them up in the python test infrastructure modules. Might be other nice gains to be had?

Fri, Apr 5, 11:09 AM · Restricted Project, Restricted Project
davide added a comment to D60300: [testsuite] Split Objective-C data formatter.

I think this is good regardless for readability, but I would really appreciate if we can collect some numbers to see how effective this change actually is.

I see 120 -> 12 seconds on my iMac Pro.

Nice! Might be nice to have some automated info that gets dumped when one file with multiple tests takes a long time and suggest breaking them up in the python test infrastructure modules. Might be other nice gains to be had?

lit has this feature. It's called --time-tests. That's how we discovered the problem. There are other tests that we can fix.

--Davide

Fri, Apr 5, 11:09 AM · Restricted Project, Restricted Project
davide accepted D60300: [testsuite] Split Objective-C data formatter.

great!

Fri, Apr 5, 10:54 AM · Restricted Project, Restricted Project

Thu, Apr 4

davide added a comment to D60300: [testsuite] Split Objective-C data formatter.

I think this is good regardless for readability, but I would really appreciate if we can collect some numbers to see how effective this change actually is.

Thu, Apr 4, 6:45 PM · Restricted Project, Restricted Project

Tue, Apr 2

davide accepted D60113: [ArgPromotion] Set debug location at updated callsites.

Thanks.

Tue, Apr 2, 10:26 AM · Restricted Project

Mon, Apr 1

davide added a comment to D60092: [Process] Use early returns in Process::WriteMemory (NFC).

LGTM. Med, what do you think?

Mon, Apr 1, 1:25 PM · Restricted Project, Restricted Project
davide accepted D60022: [Process] Fix WriteMemory return value.

LGTM

Mon, Apr 1, 11:59 AM · Restricted Project, Restricted Project

Fri, Mar 29

davide added inline comments to D60022: [Process] Fix WriteMemory return value.
Fri, Mar 29, 6:52 PM · Restricted Project, Restricted Project

Thu, Mar 28

davide accepted D59911: Don't abort() in lldb_assert and document why..

LGTM

Thu, Mar 28, 3:45 PM · Restricted Project, Restricted Project
davide added a comment to D59911: Don't abort() in lldb_assert and document why..

Thanks for summarizing your thoughts, Davide.

I think that what you wrote is a much better explanation of what I was trying to say with

Use these sparingly and only if error handling is not otherwise feasible.

I think that unless we can eliminate all uses of lldb_assert() from the code we should document it, but discourage its use. Do you have any suggestions for a better wording?

Thu, Mar 28, 3:05 PM · Restricted Project, Restricted Project
davide added a comment to D59911: Don't abort() in lldb_assert and document why..

My (maybe unpopolar) opinion on the subject is that "soft assertions" are a way to cleanse your conscience of guilt, but they don't work really well in practice.
When I started working on lldb, I was a fairly strong proponent of assertions everywhere. My view changed somewhat radically over the course of the past 18 months, and I would like to summarize some points here.

Thu, Mar 28, 2:37 PM · Restricted Project, Restricted Project
davide updated subscribers of D59957: Convert = operators that take object mutexes to the multi-lock version of std::lock.

This looks correct to me, but I'm not extremely familiar either, so I'd wait for @labath to sign off.

Thu, Mar 28, 1:16 PM · Restricted Project, Restricted Project

Wed, Mar 27

davide committed rG8ff45859c280: [Process] Reorder declarations and document ReadMemoryFromInferior. (authored by davide).
[Process] Reorder declarations and document ReadMemoryFromInferior.
Wed, Mar 27, 5:10 PM
davide committed rG454e9428db20: [ObjectFileMachO] Remove another debugging aid. (authored by davide).
[ObjectFileMachO] Remove another debugging aid.
Wed, Mar 27, 5:06 PM
davide committed rGdfbcadf562f6: [ObjectFileMachO] Disable memory caching for savecore. (authored by davide).
[ObjectFileMachO] Disable memory caching for savecore.
Wed, Mar 27, 5:06 PM
davide added a comment to D59896: [ObjectFileMachO] Disable memory caching for savecore..
$ git llvm push
Pushing 3 commits:
  d3e193e68a7 [ObjectFileMachO] Disable memory caching for savecore.
  10502683510 [ObjectFileMachO] Remove another debugging aid.
  a619d7b69b9 [Process] Reorder declarations and document ReadMemoryFromInferior.
Sending        lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Transmitting file data .done
Committing transaction...
Committed revision 357134.
Committed d3e193e68a7 to svn.
Sending        lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Transmitting file data .done
Committing transaction...
Committed revision 357135.
Committed 10502683510 to svn.
Sending        lldb/trunk/include/lldb/Target/Process.h
Transmitting file data .done
Committing transaction...
Committed revision 357136.
Committed a619d7b69b9 to svn.
Wed, Mar 27, 5:06 PM · Restricted Project, Restricted Project
davide committed rL357136: [Process] Reorder declarations and document ReadMemoryFromInferior..
[Process] Reorder declarations and document ReadMemoryFromInferior.
Wed, Mar 27, 5:06 PM
davide committed rLLDB357136: [Process] Reorder declarations and document ReadMemoryFromInferior..
[Process] Reorder declarations and document ReadMemoryFromInferior.
Wed, Mar 27, 5:06 PM
davide committed rL357135: [ObjectFileMachO] Remove another debugging aid..
[ObjectFileMachO] Remove another debugging aid.
Wed, Mar 27, 5:06 PM
davide committed rLLDB357135: [ObjectFileMachO] Remove another debugging aid..
[ObjectFileMachO] Remove another debugging aid.
Wed, Mar 27, 5:06 PM
davide committed rLLDB357134: [ObjectFileMachO] Disable memory caching for savecore..
[ObjectFileMachO] Disable memory caching for savecore.
Wed, Mar 27, 5:06 PM
davide committed rL357134: [ObjectFileMachO] Disable memory caching for savecore..
[ObjectFileMachO] Disable memory caching for savecore.
Wed, Mar 27, 5:06 PM
davide closed D59896: [ObjectFileMachO] Disable memory caching for savecore..
Wed, Mar 27, 5:05 PM · Restricted Project, Restricted Project
davide added a comment to D59896: [ObjectFileMachO] Disable memory caching for savecore..

Looks good. Removing that printf is good. Could you also remove the printf("mach_header:...") in the same function?

It would be nice if include/lldb/Target/Process.h had the decl for ReadMemoryFromInferior right after ReadMemory(), and a comment that ReadMemoryFromInferior does not go through the memory cache (and most callers should go through ReadMemory()) so people know what the difference is.

Wed, Mar 27, 4:42 PM · Restricted Project, Restricted Project
davide removed rL LLVM as the repository for D59896: [ObjectFileMachO] Disable memory caching for savecore..
Wed, Mar 27, 12:25 PM · Restricted Project, Restricted Project
davide updated the diff for D59896: [ObjectFileMachO] Disable memory caching for savecore..

try

Wed, Mar 27, 12:25 PM · Restricted Project, Restricted Project
davide created D59896: [ObjectFileMachO] Disable memory caching for savecore..
Wed, Mar 27, 11:59 AM · Restricted Project, Restricted Project

Tue, Mar 26

davide accepted D59831: [CMake] macOS: Find DebugSymbols.framework inside the SDK.

LGTM

Tue, Mar 26, 12:06 PM · Restricted Project
davide committed rG5c4fad0c2333: [ScriptInterpreterPython] Try to make the sanitizer bot green again. (authored by davide).
[ScriptInterpreterPython] Try to make the sanitizer bot green again.
Tue, Mar 26, 9:44 AM
davide committed rLLDB357006: [ScriptInterpreterPython] Try to make the sanitizer bot green again..
[ScriptInterpreterPython] Try to make the sanitizer bot green again.
Tue, Mar 26, 9:43 AM
davide committed rL357006: [ScriptInterpreterPython] Try to make the sanitizer bot green again..
[ScriptInterpreterPython] Try to make the sanitizer bot green again.
Tue, Mar 26, 9:42 AM

Mon, Mar 25

davide added a comment to D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..

It sounds to me like you could achieve the same thing by generalizing the LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of centralizing the way we manage python-finding logic (instead of each OS doing it's own thing) and also enable those users, who know what they are doing, to override this logic and point lldb to a different python. (I don't know if there are any such users, but it does not sounds like an impossible scenario).

I think all it would take is to do something like:

  • move LLDB_RELOCATABLE_PYTHON handling outside of if(WINDOWS)
  • have the default value of LLDB_RELOCATABLE_PYTHON be false for darwin
  • possibly tweak the python-finding logic so that it prefers the one in /System/Library/Frameworks/...
Mon, Mar 25, 6:08 PM · Restricted Project, Restricted Project
davide added a comment to D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..

It sounds to me like you could achieve the same thing by generalizing the LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of centralizing the way we manage python-finding logic (instead of each OS doing it's own thing) and also enable those users, who know what they are doing, to override this logic and point lldb to a different python. (I don't know if there are any such users, but it does not sounds like an impossible scenario).

I think all it would take is to do something like:

  • move LLDB_RELOCATABLE_PYTHON handling outside of if(WINDOWS)
  • have the default value of LLDB_RELOCATABLE_PYTHON be false for darwin
  • possibly tweak the python-finding logic so that it prefers the one in /System/Library/Frameworks/...
Mon, Mar 25, 6:07 PM · Restricted Project, Restricted Project
davide added a comment to D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..
In D59719#1442181, @ted wrote:

This doesn't look correct to me - it looks like there are 1 too many #endifs. I think the one at line 179 should be removed - it should have been replaced by the #else that is at line 180.

Mon, Mar 25, 6:06 PM · Restricted Project, Restricted Project
davide accepted D59589: Python 2/3 compat: str vs basestring.

LGTM.

Mon, Mar 25, 8:07 AM · Restricted Project

Fri, Mar 22

davide committed rG4f9cb26063aa: [ScriptInterpreter] Remove a warning and reformat comments. (authored by davide).
[ScriptInterpreter] Remove a warning and reformat comments.
Fri, Mar 22, 3:38 PM
davide committed rL356819: [ScriptInterpreter] Remove a warning and reformat comments..
[ScriptInterpreter] Remove a warning and reformat comments.
Fri, Mar 22, 3:37 PM
davide committed rLLDB356819: [ScriptInterpreter] Remove a warning and reformat comments..
[ScriptInterpreter] Remove a warning and reformat comments.
Fri, Mar 22, 3:37 PM
davide committed rG386f00db75f1: [ScriptInterpreter] Make sure that PYTHONHOME is right. (authored by davide).
[ScriptInterpreter] Make sure that PYTHONHOME is right.
Fri, Mar 22, 3:19 PM
davide committed rL356816: [ScriptInterpreter] Make sure that PYTHONHOME is right..
[ScriptInterpreter] Make sure that PYTHONHOME is right.
Fri, Mar 22, 3:19 PM
davide committed rLLDB356816: [ScriptInterpreter] Make sure that PYTHONHOME is right..
[ScriptInterpreter] Make sure that PYTHONHOME is right.
Fri, Mar 22, 3:19 PM
davide closed D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..
Fri, Mar 22, 3:18 PM · Restricted Project, Restricted Project
davide updated the diff for D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..

Adrian's feedback

Fri, Mar 22, 3:17 PM · Restricted Project, Restricted Project
davide created D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right..
Fri, Mar 22, 2:43 PM · Restricted Project, Restricted Project

Thu, Mar 21

davide accepted D59667: Regression test to ensure that we handling importing of anonymous enums correctly.

LGTM, just clang format main.cpp before committing.

Thu, Mar 21, 2:17 PM · Restricted Project
davide accepted D59580: Use compatible print statements for Python2/3.

This looks good to me as long as it doesn't break check-lldb (and from I quick look at the patch I doubt it does). Thanks for helping with this!

Thu, Mar 21, 8:18 AM · Restricted Project

Mar 20 2019

davide added reviewers for D59580: Use compatible print statements for Python2/3: zturner, aprantl, friss.
Mar 20 2019, 7:40 AM · Restricted Project
davide added a comment to D59580: Use compatible print statements for Python2/3.

Thanks for your interest in the subject of Python! I converted everything I was able to find looking at our test suite, it seems that we lack coverage for these scripts.
Did you end up testing them with both py 2 and py 3 or just applied a tool on them?

Mar 20 2019, 7:40 AM · Restricted Project

Mar 19 2019

davide committed rG60be633a4717: [ScriptInterpreterPython] Remove dead code. (authored by davide).
[ScriptInterpreterPython] Remove dead code.
Mar 19 2019, 10:37 AM
davide committed rGb137c3570a8d: [StackFrameRecognizer] Remove unneeded LLDB_DISABLE_PYTHON. (authored by davide).
[StackFrameRecognizer] Remove unneeded LLDB_DISABLE_PYTHON.
Mar 19 2019, 10:37 AM
davide committed rLLDB356487: [ScriptInterpreterPython] Remove dead code..
[ScriptInterpreterPython] Remove dead code.
Mar 19 2019, 10:37 AM
davide committed rLLDB356486: [StackFrameRecognizer] Remove unneeded LLDB_DISABLE_PYTHON..
[StackFrameRecognizer] Remove unneeded LLDB_DISABLE_PYTHON.
Mar 19 2019, 10:37 AM
davide committed rL356487: [ScriptInterpreterPython] Remove dead code..
[ScriptInterpreterPython] Remove dead code.
Mar 19 2019, 10:36 AM
davide committed rL356486: [StackFrameRecognizer] Remove unneeded LLDB_DISABLE_PYTHON..
[StackFrameRecognizer] Remove unneeded LLDB_DISABLE_PYTHON.
Mar 19 2019, 10:36 AM

Mar 18 2019

davide committed rG65dc65216e9b: [API] Remove unneded LLDB_DISABLE_PYTHON markers. (authored by davide).
[API] Remove unneded LLDB_DISABLE_PYTHON markers.
Mar 18 2019, 1:04 PM
davide committed rL356401: [API] Remove unneded LLDB_DISABLE_PYTHON markers..
[API] Remove unneded LLDB_DISABLE_PYTHON markers.
Mar 18 2019, 1:03 PM
davide committed rLLDB356401: [API] Remove unneded LLDB_DISABLE_PYTHON markers..
[API] Remove unneded LLDB_DISABLE_PYTHON markers.
Mar 18 2019, 1:03 PM

Mar 15 2019

davide committed rGbbcda82e21bd: [DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory. (authored by davide).
[DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory.
Mar 15 2019, 9:56 AM
davide committed rL356271: [DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory..
[DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory.
Mar 15 2019, 9:55 AM
davide committed rLLDB356271: [DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory..
[DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory.
Mar 15 2019, 9:55 AM

Mar 14 2019

davide committed rG71560b5e2bfd: [DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager. (authored by davide).
[DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager.
Mar 14 2019, 5:45 PM
davide committed rLLDB356225: [DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager..
[DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager.
Mar 14 2019, 5:45 PM
davide committed rL356225: [DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager..
[DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager.
Mar 14 2019, 5:45 PM
davide committed rG3772796aaaf3: [ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters. (authored by davide).
[ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters.
Mar 14 2019, 3:12 PM
davide committed rL356210: [ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters..
[ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters.
Mar 14 2019, 3:11 PM
davide committed rLLDB356210: [ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters..
[ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters.
Mar 14 2019, 3:11 PM
davide committed rG1dbbf2de3307: [DataFormatters] Delete unused code. Not even exposed in the API. (authored by davide).
[DataFormatters] Delete unused code. Not even exposed in the API.
Mar 14 2019, 10:41 AM
davide committed rLLDB356176: [DataFormatters] Delete unused code. Not even exposed in the API..
[DataFormatters] Delete unused code. Not even exposed in the API.
Mar 14 2019, 10:41 AM
davide committed rL356176: [DataFormatters] Delete unused code. Not even exposed in the API..
[DataFormatters] Delete unused code. Not even exposed in the API.
Mar 14 2019, 10:40 AM
davide committed rGf6a84ed30b28: [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards. (authored by davide).
[Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.
Mar 14 2019, 10:23 AM
davide committed rLLDB356171: [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards..
[Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.
Mar 14 2019, 10:22 AM
davide committed rL356171: [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards..
[Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.
Mar 14 2019, 10:22 AM

Mar 13 2019

davide committed rG9e75a0840910: [Python] Fix TestDataFormatterSmartArray to work across python versions. (authored by davide).
[Python] Fix TestDataFormatterSmartArray to work across python versions.
Mar 13 2019, 1:08 PM
davide committed rLLDB356096: [Python] Fix TestDataFormatterSmartArray to work across python versions..
[Python] Fix TestDataFormatterSmartArray to work across python versions.
Mar 13 2019, 1:08 PM