davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (205 w, 4 d)

Recent Activity

Fri, Oct 12

davide accepted D53226: [lldbsuite] Disable Test128BitsInteger on Windows.
Fri, Oct 12, 4:36 PM

Thu, Oct 11

davide accepted D52851: Adding support to step into the callable wrapped by libc++ std::function.

LGTM too. Thanks for taking the time to address the comments.

Thu, Oct 11, 11:44 AM

Mon, Oct 8

davide accepted D53010: Add an alias "var" for "frame var" and "vo" for "frame var -O".

LG. If you can add a line to an existing inline test, I think it would be excellent.

Mon, Oct 8, 6:49 PM

Wed, Oct 3

davide added a comment to D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers.

I'll commit this for you, but I might ask if you can try adding a test first?

Wed, Oct 3, 10:35 PM
davide added inline comments to D52678: DWARFExpression: Resolve file addresses in the linked module.
Wed, Oct 3, 4:26 PM
davide added a comment to D52851: Adding support to step into the callable wrapped by libc++ std::function.

Some basic comments. Haven't looked at the implementation very closely, I'll do that probably tomorrow. Thanks for working on this!

Wed, Oct 3, 4:26 PM
davide accepted D51874: Fix buildbot regression by rL339929: NameError: global name 'test_directory' is not defined.

I think this looks fine. Vedant, thoughts?

Wed, Oct 3, 1:57 PM · Unknown Object (Project)

Fri, Sep 28

davide committed rLLDB343368: [SBAPI/Target] Expose SetStatistics(bool enable)/GetStatistics()..
[SBAPI/Target] Expose SetStatistics(bool enable)/GetStatistics().
Fri, Sep 28, 4:29 PM
davide committed rL343368: [SBAPI/Target] Expose SetStatistics(bool enable)/GetStatistics()..
[SBAPI/Target] Expose SetStatistics(bool enable)/GetStatistics().
Fri, Sep 28, 4:29 PM

Tue, Sep 25

davide accepted D52516: [lldbinline] Set directory attribute on test-specific classes.

LGTM.

Tue, Sep 25, 1:13 PM

Sep 19 2018

davide added a comment to D44263: Implement LWG 2221 - No formatted output operator for nullptr.

This broke all the lldb bots as well, FWIW.

Sep 19 2018, 5:29 PM
davide accepted D52247: Refactor FindVariable() core functionality into StackFrame out of SBFrame.

Sure.

Sep 19 2018, 4:04 PM

Sep 18 2018

davide added inline comments to D52247: Refactor FindVariable() core functionality into StackFrame out of SBFrame.
Sep 18 2018, 2:27 PM
davide accepted D52247: Refactor FindVariable() core functionality into StackFrame out of SBFrame.

LGTM modulo minor.

Sep 18 2018, 2:26 PM

Sep 17 2018

davide committed rLLDB342404: Revert "[IRInterpreter] Minor cleanups, add comments. NFCI.".
Revert "[IRInterpreter] Minor cleanups, add comments. NFCI."
Sep 17 2018, 11:18 AM
davide committed rL342404: Revert "[IRInterpreter] Minor cleanups, add comments. NFCI.".
Revert "[IRInterpreter] Minor cleanups, add comments. NFCI."
Sep 17 2018, 11:18 AM
davide accepted D49108: [CVP] Handle instructions with no user. No need to create CVPLattice state. This handles terminator instructions and more..
Sep 17 2018, 8:08 AM

Sep 14 2018

davide committed rL342280: [IRInterpreter] Minor cleanups, add comments. NFCI..
[IRInterpreter] Minor cleanups, add comments. NFCI.
Sep 14 2018, 1:50 PM
davide committed rLLDB342280: [IRInterpreter] Minor cleanups, add comments. NFCI..
[IRInterpreter] Minor cleanups, add comments. NFCI.
Sep 14 2018, 1:50 PM
davide committed rL342262: [IRInterpreter] Fall back to JIT with 128-bit values..
[IRInterpreter] Fall back to JIT with 128-bit values.
Sep 14 2018, 11:57 AM
davide committed rLLDB342262: [IRInterpreter] Fall back to JIT with 128-bit values..
[IRInterpreter] Fall back to JIT with 128-bit values.
Sep 14 2018, 11:56 AM
davide added a comment to D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test.

Also, thanks for taking the time to do this right :)

Sep 14 2018, 8:35 AM
davide accepted D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test.

LGTM. @zturner / @labath might have opinions.

Sep 14 2018, 8:34 AM

Sep 12 2018

davide added a comment to D51999: build: add libedit to include paths.

How exactly are you building (i.e. what triggers this error)?

Sep 12 2018, 12:43 PM

Sep 11 2018

davide accepted D51930: Add a basic test for 'memory region'.

Yeah, sure :)

Sep 11 2018, 1:09 PM
davide added a comment to D51930: Add a basic test for 'memory region'.

Yeah, that's the revision I had in mind. Can't you extend lldb-test to do what you need?

Sep 11 2018, 8:45 AM
davide requested changes to D51930: Add a basic test for 'memory region'.

I thought Vedant added an harness utility to test memory a bit ago. Have you looked into whether that's extensible for your purposes, Raphael?

Sep 11 2018, 7:33 AM

Sep 10 2018

davide committed rLLDB341878: Rollback "Fix raw address breakpoints not resolving"..
Rollback "Fix raw address breakpoints not resolving".
Sep 10 2018, 4:10 PM
davide committed rL341878: Rollback "Fix raw address breakpoints not resolving"..
Rollback "Fix raw address breakpoints not resolving".
Sep 10 2018, 4:10 PM

Sep 7 2018

davide committed rL341732: [XCodeproj] Remove extra whitespace in SBAPI path..
[XCodeproj] Remove extra whitespace in SBAPI path.
Sep 7 2018, 4:51 PM
davide committed rLLDB341732: [XCodeproj] Remove extra whitespace in SBAPI path..
[XCodeproj] Remove extra whitespace in SBAPI path.
Sep 7 2018, 4:51 PM
davide committed rL341714: [Disassembler] Run ARM-specific tests only if the ARM backend is built..
[Disassembler] Run ARM-specific tests only if the ARM backend is built.
Sep 7 2018, 2:40 PM
davide committed rLLDB341714: [Disassembler] Run ARM-specific tests only if the ARM backend is built..
[Disassembler] Run ARM-specific tests only if the ARM backend is built.
Sep 7 2018, 2:40 PM
davide added a comment to D51816: Fix raw address breakpoints not resolving.

Can you add a test for this behavior?

Sep 7 2018, 2:40 PM
davide committed rLLDB341685: [Scalar] Commit the correct patch, forgot `git add`..
[Scalar] Commit the correct patch, forgot `git add`.
Sep 7 2018, 11:27 AM
davide committed rL341685: [Scalar] Commit the correct patch, forgot `git add`..
[Scalar] Commit the correct patch, forgot `git add`.
Sep 7 2018, 11:26 AM
davide committed rLLDB341682: [Scalar] Fix undefined behaviour when converting double to long..
[Scalar] Fix undefined behaviour when converting double to long.
Sep 7 2018, 11:08 AM
davide committed rL341682: [Scalar] Fix undefined behaviour when converting double to long..
[Scalar] Fix undefined behaviour when converting double to long.
Sep 7 2018, 11:08 AM

Sep 6 2018

davide added a comment to D51615: Set Windows console mode to enable support for ansi escape codes.

Cool. The argument about reverting still stands though (you might
consider following up with logs et simila to make debugging easier).

Sep 6 2018, 2:14 PM
davide updated subscribers of D51615: Set Windows console mode to enable support for ansi escape codes.

You can probably revert it. BTW, is the bot public? I would like to
understand whether I broke something after I commit.

Sep 6 2018, 1:42 PM

Sep 5 2018

davide added inline comments to D50031: Add pass to print out DebugCounter info.
Sep 5 2018, 2:03 PM
davide accepted D50092: Introduce DebugCounter into DCE pass.
Sep 5 2018, 2:02 PM
davide added a reviewer for D50094: Introduce DebugCounter into ConstProp pass: fhahn.
Sep 5 2018, 2:02 PM
davide accepted D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

LGTM. @eraman / @davidxl might have opinions on this.

Sep 5 2018, 2:02 PM
davide added a comment to D50210: Introduce DebugCounter into MergedLoadStoreMotion pass.

I'm not familiar enough with MLSM to review this, so @Gerolf should take a look.

Sep 5 2018, 2:02 PM

Sep 4 2018

davide added a comment to D51410: [SLC] Add an alignment to printf->puts global string.

lgtm

Sep 4 2018, 12:48 PM

Aug 31 2018

davide added a comment to D51557: Replace uses of LazyBool with LazyBool template.

I agree.

Aug 31 2018, 2:03 PM
davide added inline comments to D51557: Replace uses of LazyBool with LazyBool template.
Aug 31 2018, 2:02 PM

Aug 28 2018

davide added a comment to D51374: [LLDB] Fix script to work with GNU sed.

LGTM

Aug 28 2018, 4:55 PM
davide accepted D51335: [SROA] Fix alignment for uses of PHI nodes..

LGTM.

Aug 28 2018, 7:21 AM

Aug 27 2018

davide accepted D51319: Use a RAII guard to control access to DisassemblerLLVMC..

LGTM if Vedant is happy with this.

Aug 27 2018, 4:38 PM

Aug 25 2018

davide accepted D51253: Let the CompilerInstance create our clang ASTContext.
Aug 25 2018, 1:04 AM · Restricted Project

Aug 24 2018

davide added a reviewer for D51227: [vscode] Skip some of the vscode tests on Linux and fix one: aprantl.
Aug 24 2018, 11:51 AM

Aug 23 2018

davide added a comment to D47475: [Local] Make DoesKMove required for combineMetadata..

I think this is fine, but I would be happier if Eli can take a look, as I'm not particularly familiar with this.

Aug 23 2018, 9:13 AM

Aug 20 2018

davide added a comment to D50593: ConstantMerge: merge common initial sequences.

Do you have numbers of the size win? (maybe on clang/llvm itself)

Aug 20 2018, 12:36 AM

Aug 19 2018

davide accepted D50677: Remove manual byte counting from Opcode::Dump.

LGTM.

Aug 19 2018, 11:13 PM

Aug 9 2018

davide added a comment to D45162: [EarlyCSE] Add debug counter for debugging mis-optimizations. NFC..

I never managed to review this one, but I saw it was committed anyway. I agree the style is inconsistent, though the patch logic is fine.

Aug 9 2018, 5:46 PM
davide accepted D50533: [MC] Move EH DWARF encodings from MC to CodeGen, NFC.

Yeah, this is much more in line with what I had in mind than the original patch. Thanks for taking care of this!

Aug 9 2018, 2:24 PM
davide accepted D50492: Also display the output and error output of a failed command.
Aug 9 2018, 8:27 AM
davide added a reviewer for D50490: Restore correct x86_64 EH encodings in kernel code model: rnk.
Aug 9 2018, 8:21 AM

Aug 8 2018

davide accepted D50476: [NFC] ConstantMerge: don't insert when find should be used.

LGTM as discussed in person.

Aug 8 2018, 7:39 PM
davide accepted D50271: [IRMemoryMap] Shrink Allocation make it move-only (NFC).

Looks reasonable to me.

Aug 8 2018, 1:55 PM
davide accepted D50453: [DebugInfo] Fine tune emitting flags as part of the producer.

Lgtm.

Aug 8 2018, 9:01 AM

Aug 5 2018

davide accepted D50317: Remove duplicated code in CommandObjectQuit.

Sure.

Aug 5 2018, 4:52 PM

Aug 2 2018

davide added a comment to D50192: Fix: ClangHighlighter.cpp should not be in CopyFiles, but in lldb-core targets.

My understanding is that @t.p.northover just committed the same patch.

Aug 2 2018, 9:17 AM

Aug 1 2018

davide accepted D50150: Require users to opt into DebugCounting.

LGTM, thanks George. I'm not particularly worried if it's too hard to write a test for this.

Aug 1 2018, 10:43 PM
davide accepted D49334: [LLDB} Added syntax highlighting support.
Aug 1 2018, 2:15 PM · Unknown Object (Project)
davide committed rL338638: [DWARFASTParser] Remove special cases for `llvm-gcc`.
[DWARFASTParser] Remove special cases for `llvm-gcc`
Aug 1 2018, 2:14 PM
davide closed D48500: [DWARFASTParser] Remove special cases for `llvm-gcc`.
Aug 1 2018, 2:14 PM

Jul 30 2018

davide accepted D50026: Remove Stream::UnitTest.

LGTM.

Jul 30 2018, 5:37 PM

Jul 27 2018

davide added a comment to D49271: Adding libc++ formattors for std::optional.

Bot logs for completeness:

Jul 27 2018, 1:40 PM
davide committed rL338162: Revert "Recommit [DataFormatters] Add formatter for C++17 std::optional.".
Revert "Recommit [DataFormatters] Add formatter for C++17 std::optional."
Jul 27 2018, 1:39 PM
davide added a comment to D49271: Adding libc++ formattors for std::optional.

I'm afraid I had to revert this again. It broke an ubuntu lldb-cmake bot which builds with clang-3.5 (which has no -std=c++17 support flag, as 17 wasn't there yet).

Jul 27 2018, 1:39 PM
davide committed rL338156: Recommit [DataFormatters] Add formatter for C++17 std::optional..
Recommit [DataFormatters] Add formatter for C++17 std::optional.
Jul 27 2018, 12:58 PM
davide added a comment to D49271: Adding libc++ formattors for std::optional.

a11963323fc Recommit [DataFormatters] Add formatter for C++17 std::optional.
Authentication realm: https://llvm.org:443 LLVM Subversion repository
Password for 'davide': ***

Jul 27 2018, 12:57 PM
davide added a comment to D49271: Adding libc++ formattors for std::optional.

Your latest update doesn't contain CMakeList.txt files and the Xcode project changes. That's why it failed to apply. Please upload a correct version and I'll commit it for you.

Jul 27 2018, 11:58 AM
davide accepted D49322: Narrow the CompletionRequest API to being append-only..

Although I'm not entirely sure whether this is safe (as in, it doesn't break anything), it's probably not worth to block this further. My understanding is that Raphael did a bunch of testing and he's willing to follow-up on eventual regressions. So, given this passes the test suite, I think it's OK for this patch to go in.

Jul 27 2018, 11:26 AM

Jul 26 2018

davide accepted D49866: Fix duplicate suggestions after an ambiguous command.

LG. thanks for improving the interface, I think all these cleanups are really good.

Jul 26 2018, 10:13 AM

Jul 25 2018

davide committed rL337963: Revert "[DataFormatters] Add formatter for C++17 std::optional.".
Revert "[DataFormatters] Add formatter for C++17 std::optional."
Jul 25 2018, 2:18 PM
davide committed rL337959: [DataFormatters] Add formatter for C++17 std::optional..
[DataFormatters] Add formatter for C++17 std::optional.
Jul 25 2018, 1:48 PM
davide closed D49271: Adding libc++ formattors for std::optional.
Jul 25 2018, 1:48 PM
davide added inline comments to D49322: Narrow the CompletionRequest API to being append-only..
Jul 25 2018, 12:58 PM
davide added a reviewer for D49322: Narrow the CompletionRequest API to being append-only.: labath.
Jul 25 2018, 12:58 PM

Jul 23 2018

davide accepted D49708: Added unit test for StreamTee.

lg. You probably don't need pre-commit reviews for adding tests. This is obvious goodness.

Jul 23 2018, 4:58 PM
davide accepted D49271: Adding libc++ formattors for std::optional.

This is good, but please add a comment explaining the type before committing.

Jul 23 2018, 3:37 PM
davide accepted D49695: [cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config.

lg

Jul 23 2018, 2:13 PM

Jul 20 2018

davide added a comment to D49617: Early exit with cheaper checks.

This is probably fine, but does it matter? i.e. you have compile time numbers?

I dont have numbers, maybe you can help with that.

Jul 20 2018, 3:17 PM
davide added a comment to D49612: Use LLVM's new ItaniumPartialDemangler in LLDB.

Thanks for doing this.
We may consider doing some A-B testing between the two demanglers.
A strategy that worked very well for similar purposes was that of running nm on a large executable (e.g. clang or lldb itself) and see whether we demangle in the same exact way and measure the time needed for demangling.

Jul 20 2018, 2:59 PM
davide accepted D49560: Add support to track total counts for DebugCounter.
Jul 20 2018, 2:55 PM
davide added a comment to D49617: Early exit with cheaper checks.

This is probably fine, but does it matter? i.e. you have compile time numbers?

Jul 20 2018, 2:46 PM
davide accepted D49340: Fix IR Printing test.

lgtm.

Jul 20 2018, 8:11 AM

Jul 19 2018

davide added a comment to D49560: Add support to track total counts for DebugCounter.

Can you add a unittest for the new functionality?

Jul 19 2018, 2:40 PM
davide added a comment to D48351: Move dumping code out of RegisterValue class.

I guess this is fine. @jingham?

Jul 19 2018, 8:07 AM

Jul 18 2018

davide added inline comments to D49408: [SCCP] Don't use markForcedConstant on branch conditions..
Jul 18 2018, 6:43 PM
davide accepted D49408: [SCCP] Don't use markForcedConstant on branch conditions..

LGTM modulo minor. Thanks.

Jul 18 2018, 6:29 PM
davide accepted D49490: [docs] Update GoldPlugin documentation.

Thanks Teresa.

Jul 18 2018, 9:53 AM

Jul 17 2018

davide requested changes to D49271: Adding libc++ formattors for std::optional.

Probably last round of comments. Thanks for your patience!

Jul 17 2018, 5:29 PM

Jul 16 2018

davide accepted D49385: [IPSCCP] Run Solve each time we resolved an undef in a function..

LGTM modulo minor.

Jul 16 2018, 6:37 PM
davide added a comment to D49384: [IPSCCP] Do not zap return if the return value is overdefined at any call site..

FWIW, my take is that we should kill ResolvedUndefsIn (as already pointed by Eli, and probably me, and others in the past).
My take is that the benefit of having a forth lattice state is really little compared to the amount of effort we had to put to fix bugs.
If somebody is willing to take the time to do the work I'd rather zap away undef from the lattice and see how many constant we lose (and what's the runtime cost). But I understand this is a fair amount of work. That said, I think I like Eli's proof of concept a little better than this, so I'm happy if you want to pursue that path, Florian.

Jul 16 2018, 6:35 PM

Jul 13 2018

davide added a comment to D49271: Adding libc++ formattors for std::optional.

This is getting really close. Please try the lldbInline test format and revert the unrelated bits and I'll take another look.
Thanks!

Jul 13 2018, 3:29 PM