Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (257 w, 5 h)

Recent Activity

Yesterday

davide added a comment to D69016: [lldb] move more things from python to cmake.

What are you trying to accomplish here?

Tue, Oct 15, 8:29 PM · Restricted Project

Tue, Oct 8

davide created D68679: [CMake] Add a cache for iOS..
Tue, Oct 8, 6:28 PM · Restricted Project
davide accepted D68674: Remove the is_mangled flag from Mangled and Symbol.

LGTM

Tue, Oct 8, 6:00 PM · Restricted Project

Mon, Oct 7

davide committed rG33f054a31667: [CMake] We only want to copy the headers for macOS. (authored by davide).
[CMake] We only want to copy the headers for macOS.
Mon, Oct 7, 10:21 PM
davide committed rL373970: [CMake] We only want to copy the headers for macOS..
[CMake] We only want to copy the headers for macOS.
Mon, Oct 7, 10:21 PM
davide committed rG2b371fbeddc1: [debugserver] Include the correct header. (authored by davide).
[debugserver] Include the correct header.
Mon, Oct 7, 10:19 PM
davide committed rL373957: [debugserver] Include the correct header..
[debugserver] Include the correct header.
Mon, Oct 7, 10:19 PM

Fri, Oct 4

davide committed rG68d01d942901: [debugserver] Don't link against Cocoa, it's not needed. (authored by davide).
[debugserver] Don't link against Cocoa, it's not needed.
Fri, Oct 4, 2:50 PM
davide committed rL373795: [debugserver] Don't link against Cocoa, it's not needed..
[debugserver] Don't link against Cocoa, it's not needed.
Fri, Oct 4, 2:49 PM

Wed, Oct 2

davide committed rG3c1084373d32: [ARM64] XPC services are unsupported on device. (authored by davide).
[ARM64] XPC services are unsupported on device.
Wed, Oct 2, 12:24 PM
davide committed rG293ec1e16a3f: [RegisterContextDarwin_arm64] Include the headers for getsysctlbyname. (authored by davide).
[RegisterContextDarwin_arm64] Include the headers for getsysctlbyname.
Wed, Oct 2, 12:24 PM
davide committed rGef46be6c2acd: [ObjectFileMachO] FileSpec::SetFile() now takes the style as arg. (authored by davide).
[ObjectFileMachO] FileSpec::SetFile() now takes the style as arg.
Wed, Oct 2, 12:23 PM
davide committed rG6fdeb0324f2c: [ObjectFileMachO] Catch up with FileDesc changes. (authored by davide).
[ObjectFileMachO] Catch up with FileDesc changes.
Wed, Oct 2, 12:23 PM
davide committed rL373510: [ARM64] XPC services are unsupported on device..
[ARM64] XPC services are unsupported on device.
Wed, Oct 2, 12:23 PM
davide committed rL373509: [RegisterContextDarwin_arm64] Include the headers for getsysctlbyname..
[RegisterContextDarwin_arm64] Include the headers for getsysctlbyname.
Wed, Oct 2, 12:23 PM
davide committed rL373508: [ObjectFileMachO] FileSpec::SetFile() now takes the style as arg..
[ObjectFileMachO] FileSpec::SetFile() now takes the style as arg.
Wed, Oct 2, 12:23 PM
davide committed rL373507: [ObjectFileMachO] Catch up with FileDesc changes..
[ObjectFileMachO] Catch up with FileDesc changes.
Wed, Oct 2, 12:23 PM

Tue, Oct 1

davide accepted D68298: [GlobalOpt] Pass DTU to removeUnreachableBlocks instead of recomputing..

I think I wrote some of this code and it predates Kuba's incremental dominator updater. I'm fine, but I'll wait if he has opinions cc: @kuhar

Tue, Oct 1, 2:17 PM · Restricted Project
davide accepted D68297: [Local] Remove unused LazyValueInfo pointer from removeUnreachableBlock..

LGTM

Tue, Oct 1, 2:08 PM · Restricted Project

Fri, Sep 27

davide requested changes to D68179: [lldb] Fix JSON parser to allow empty arrays.

This needs a test. You can either write a python one as the ones in test/testcases or a lit-style based as the ones in lit/.

Fri, Sep 27, 10:08 PM · Restricted Project, Restricted Project

Wed, Sep 25

davide requested changes to D68004: [InstCombine] Fix call guard difference with dbg.

yes, this needs a test.

Wed, Sep 25, 4:18 PM · Restricted Project

Fri, Sep 20

davide accepted D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment.
Fri, Sep 20, 2:13 PM · Restricted Project, Restricted Project
davide added a comment to D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member.

Just keep an eye on the bots as they might start whining
http://green.lab.llvm.org/green/

Fri, Sep 20, 1:33 PM · Restricted Project, Restricted Project
davide accepted D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member.

If this doesn't break clang and gcc, fine.

Fri, Sep 20, 1:18 PM · Restricted Project, Restricted Project

Sep 16 2019

davide accepted D67644: [ScriptInterpreter] Initialize globals when loading a scripting module..

LGTM

Sep 16 2019, 6:42 PM · Restricted Project, Restricted Project
davide accepted D67636: [Reproducer] Implement dumping packets..
Sep 16 2019, 4:15 PM · Restricted Project, Restricted Project

Sep 13 2019

davide accepted D67540: [lldb] Remove SetCount/ClearCount from Flags.

Sure. If anything something like this should live in llvm/Support, but given it's not used, it should live nowhere.

Sep 13 2019, 9:46 AM · Restricted Project, Restricted Project

Sep 12 2019

davide accepted D67523: [Reproducer] Move GDB Remote Packet into Utility. (NFC).

Easy peasy.

Sep 12 2019, 2:53 PM · Restricted Project, Restricted Project

Sep 4 2019

davide accepted D67183: [Python] Implement truth testing for lldb.value.

LGTM

Sep 4 2019, 11:11 AM · Restricted Project, Restricted Project
davide accepted D67184: [Python] Implement __next__ for value_iter.

LGTM

Sep 4 2019, 11:11 AM · Restricted Project, Restricted Project

Sep 3 2019

davide accepted D67116: [lldb][NFC] Remove unused overload of File::Read.

You can just go ahead with patches like this one.

Sep 3 2019, 10:53 AM · Restricted Project, Restricted Project

Aug 30 2019

davide committed rL370519: Access for davide..
Access for davide.
Aug 30 2019, 1:14 PM

Aug 29 2019

davide committed rG6347aa5d1643: Revert "[TSanRuntime] Upstream thread swift race detector." (authored by davide).
Revert "[TSanRuntime] Upstream thread swift race detector."
Aug 29 2019, 10:17 AM
davide committed rL370385: Revert "[TSanRuntime] Upstream thread swift race detector.".
Revert "[TSanRuntime] Upstream thread swift race detector."
Aug 29 2019, 10:13 AM

Aug 28 2019

davide accepted D66917: [dotest] Remove the curses result formatter..
Aug 28 2019, 6:56 PM · Restricted Project, Restricted Project
davide accepted D66920: [dotest] Remove deprecated loggin through env variables..
Aug 28 2019, 6:54 PM · Restricted Project, Restricted Project
davide committed rG54b3aa91d0ad: [python] remove testsuite vestiges. (authored by davide).
[python] remove testsuite vestiges.
Aug 28 2019, 6:45 PM
davide committed rL370287: [python] remove testsuite vestiges..
[python] remove testsuite vestiges.
Aug 28 2019, 6:45 PM
davide committed rGa633d29ba18b: [TSanRuntime] Upstream thread swift race detector. (authored by davide).
[TSanRuntime] Upstream thread swift race detector.
Aug 28 2019, 6:41 PM
davide committed rL370286: [TSanRuntime] Upstream thread swift race detector..
[TSanRuntime] Upstream thread swift race detector.
Aug 28 2019, 6:41 PM
davide closed D66915: [TSanRuntime] Upstream thread swift race detector..
Aug 28 2019, 6:41 PM · Restricted Project, Restricted Project
davide accepted D66912: [dotest] Make dotest.py invocation repeatable.
Aug 28 2019, 4:51 PM · Restricted Project, Restricted Project
davide created D66915: [TSanRuntime] Upstream thread swift race detector..
Aug 28 2019, 4:48 PM · Restricted Project, Restricted Project
davide accepted D66896: [dotest] Don't try to guess the lldb binary & python dir..
Aug 28 2019, 10:37 AM · Restricted Project, Restricted Project
davide accepted D66893: [dotest] Don't try to guess the llvm binary dir..

LGTM

Aug 28 2019, 9:54 AM · Restricted Project, Restricted Project
davide accepted D66858: POSIX DYLD: add workaround for android L loader.

LGTM. Thanks. I'm going to clean the diff downstream.

Aug 28 2019, 7:39 AM · Restricted Project

Aug 27 2019

davide added a comment to D66837: [dotest] Remove -q (quiet) flag..

LGTM

Aug 27 2019, 3:55 PM · Restricted Project, Restricted Project

Aug 26 2019

davide added a comment to D66774: [dotest] Remove long running test "decorator" and re-enable tests..

LGTM

Aug 26 2019, 5:00 PM · Restricted Project, Restricted Project

Aug 21 2019

davide committed rG0a8e634b3bb9: [lldb] Replace std::once_flag with llvm::once_flag. (authored by davide).
[lldb] Replace std::once_flag with llvm::once_flag.
Aug 21 2019, 8:18 PM
davide committed rL369618: [lldb] Replace std::once_flag with llvm::once_flag..
[lldb] Replace std::once_flag with llvm::once_flag.
Aug 21 2019, 8:18 PM
davide closed D66566: [lldb] Replace std::once_flag with llvm::once_flag..
Aug 21 2019, 8:17 PM · Restricted Project, Restricted Project
davide added a comment to D66566: [lldb] Replace std::once_flag with llvm::once_flag..

I and Jason discussed this offline and he's fine with it, so, I'm going to land this now.

Aug 21 2019, 5:53 PM · Restricted Project, Restricted Project
davide created D66566: [lldb] Replace std::once_flag with llvm::once_flag..
Aug 21 2019, 4:35 PM · Restricted Project, Restricted Project

Aug 16 2019

davide added a comment to D66354: Add LLDB dataformatters for llvm::StringRef and lldb_private::ConstString.

LGTM. It would be great if we can add a test.

Aug 16 2019, 10:17 AM · Restricted Project

Aug 14 2019

davide added inline comments to D66241: stop-hooks don't fire on "step-out".
Aug 14 2019, 2:31 PM · Restricted Project, Restricted Project
davide added inline comments to D66241: stop-hooks don't fire on "step-out".
Aug 14 2019, 1:15 PM · Restricted Project, Restricted Project

Aug 12 2019

davide committed rG7f9bbe059977: [CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign. (authored by davide).
[CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign.
Aug 12 2019, 2:52 PM
davide committed rL368620: [CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign..
[CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign.
Aug 12 2019, 2:49 PM
davide accepted D66102: [Symbol] Decouple clang from CompilerType.

LGTM

Aug 12 2019, 2:23 PM · Restricted Project, Restricted Project
davide committed rG36f13e49127e: [Symbol] GetTypeBitAlign() should return None in case of failure. (authored by davide).
[Symbol] GetTypeBitAlign() should return None in case of failure.
Aug 12 2019, 1:04 PM
davide committed rL368614: [Symbol] GetTypeBitAlign() should return None in case of failure..
[Symbol] GetTypeBitAlign() should return None in case of failure.
Aug 12 2019, 1:04 PM
davide closed D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..
Aug 12 2019, 1:04 PM · Restricted Project, Restricted Project
davide added inline comments to D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..
Aug 12 2019, 11:20 AM · Restricted Project, Restricted Project
davide added a comment to D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..

More than error handling, this allows us to distinguish with a type with zero alignment (if possible at all?) and an error getting the alignment from ASTContext/

Aug 12 2019, 11:15 AM · Restricted Project, Restricted Project
davide added a reviewer for D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.: aprantl.
Aug 12 2019, 9:30 AM · Restricted Project, Restricted Project
davide created D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..
Aug 12 2019, 9:30 AM · Restricted Project, Restricted Project

Aug 8 2019

davide added a comment to D65874: [lldb][CMake] Disable modules in Xcode projects.

Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology?

Aug 8 2019, 9:45 AM · Restricted Project, Restricted Project
davide added a reviewer for D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef: chandlerc.
Aug 8 2019, 9:44 AM · Restricted Project, Restricted Project
davide added a comment to D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef.

I think this is definitely a good idea but Chandler or DBlaikie might want to take a look at this one too.

Aug 8 2019, 9:44 AM · Restricted Project, Restricted Project

Aug 7 2019

davide committed rGe04c62bb2362: [Materializer] Remove wrong SetSizeAndAlignmentFromType(). (authored by davide).
[Materializer] Remove wrong SetSizeAndAlignmentFromType().
Aug 7 2019, 8:18 PM
davide committed rL368249: [Materializer] Remove wrong SetSizeAndAlignmentFromType()..
[Materializer] Remove wrong SetSizeAndAlignmentFromType().
Aug 7 2019, 8:18 PM
davide accepted D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references..

I seem to remember there was a bug where you run the expression twice and the second time it crashes/it's not evaluated correctly [at least this is what I remember talking to Lang ~18 months ago].
If that works, yay for more coverage!

Aug 7 2019, 9:51 AM · Restricted Project
davide accepted D65874: [lldb][CMake] Disable modules in Xcode projects.

You might want to check with Argyrios, maybe file a rdar against SourceKit.
Otherwise, this is fine to me.

Aug 7 2019, 9:19 AM · Restricted Project, Restricted Project

Aug 5 2019

davide added a reviewer for D65784: [lldb] delete "--platform-path" option from "target create": jasonmolenda.
Aug 5 2019, 6:22 PM · Restricted Project
davide committed rG78f05d3599f3: Revert "[CompilerType] Simplify the interface a bit more.." (authored by davide).
Revert "[CompilerType] Simplify the interface a bit more.."
Aug 5 2019, 5:44 PM
davide committed rL367963: Revert "[CompilerType] Simplify the interface a bit more..".
Revert "[CompilerType] Simplify the interface a bit more.."
Aug 5 2019, 5:44 PM
davide added a comment to D65782: [CompilerType] Simplify the interface a bit more...

I was marked as a review on this, but I suspect you intended to get some other Alex :-)

Aug 5 2019, 5:08 PM · Restricted Project, Restricted Project
davide committed rGb31f60b9c2e7: [CompilerType] Simplify the interface a bit more.. (authored by davide).
[CompilerType] Simplify the interface a bit more..
Aug 5 2019, 5:02 PM
davide committed rL367957: [CompilerType] Simplify the interface a bit more...
[CompilerType] Simplify the interface a bit more..
Aug 5 2019, 5:02 PM
davide closed D65782: [CompilerType] Simplify the interface a bit more...
Aug 5 2019, 5:02 PM · Restricted Project, Restricted Project
davide created D65782: [CompilerType] Simplify the interface a bit more...
Aug 5 2019, 4:31 PM · Restricted Project, Restricted Project
davide committed rGd32d5db4daca: [CompilerType] Remove an unused function. (authored by davide).
[CompilerType] Remove an unused function.
Aug 5 2019, 4:23 PM
davide committed rL367946: [CompilerType] Remove an unused function..
[CompilerType] Remove an unused function.
Aug 5 2019, 4:23 PM
davide closed D65781: [CompilerType] Remove an unused function..
Aug 5 2019, 4:23 PM · Restricted Project, Restricted Project
davide created D65781: [CompilerType] Remove an unused function..
Aug 5 2019, 4:14 PM · Restricted Project, Restricted Project

Jul 31 2019

davide accepted D65547: [Reproducers] Force replay in synchronous mode..

Thanks!

Jul 31 2019, 4:19 PM · Restricted Project, Restricted Project
davide added a comment to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.

[and Raphael for the clang vendor bits]

Jul 31 2019, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
davide added a reviewer for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure: teemperor.
Jul 31 2019, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
davide added a comment to D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure.

Really on the lldb side, Jonas is the right person to review this patch.

Jul 31 2019, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
davide added a reviewer for D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure: JDevlieghere.
Jul 31 2019, 1:55 PM · Restricted Project, Restricted Project, Restricted Project

Jul 30 2019

davide added a comment to D65469: Remove `bugreport` command.

Other than that, I have no objections.

Jul 30 2019, 12:25 PM · Restricted Project
davide added a comment to D65469: Remove `bugreport` command.

I wanted to remove it a while ago, but Jason told me he found this useful, so I would wait for his opinion.

Jul 30 2019, 12:23 PM · Restricted Project

Jul 29 2019

davide committed rG9a5fbc816341: [Symbolication] Remove some dead code. Nothing exciting. (authored by davide).
[Symbolication] Remove some dead code. Nothing exciting.
Jul 29 2019, 2:28 PM
davide committed rGf80c72be20c8: [Symbolication] Remove a duplicate assignment. (authored by davide).
[Symbolication] Remove a duplicate assignment.
Jul 29 2019, 2:28 PM
davide committed rGacc626bc57c7: [Symbolication] Fix unicode compatibility between 2 and 3. (authored by davide).
[Symbolication] Fix unicode compatibility between 2 and 3.
Jul 29 2019, 2:28 PM
davide committed rL367262: [Symbolication] Remove some dead code. Nothing exciting..
[Symbolication] Remove some dead code. Nothing exciting.
Jul 29 2019, 2:28 PM
davide committed rL367261: [Symbolication] Remove a duplicate assignment..
[Symbolication] Remove a duplicate assignment.
Jul 29 2019, 2:28 PM
davide committed rL367260: [Symbolication] Fix unicode compatibility between 2 and 3..
[Symbolication] Fix unicode compatibility between 2 and 3.
Jul 29 2019, 2:28 PM

Jul 24 2019

davide accepted D65222: [IPSCCP] Add assertion to surface cases where we zap returns with overdefined users..

LGTM.

Jul 24 2019, 5:12 PM · Restricted Project

Jul 22 2019

davide accepted D65116: [Driver] Set the default win32-macho debug format to DWARF.

Minor otherwise LGTM

Jul 22 2019, 2:43 PM · Restricted Project