Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (222 w, 6 d)

Recent Activity

Today

davide committed rG656b6698bee2: [lldb-mi] Move TestMIPrompt away from pexpect(). (authored by davide).
[lldb-mi] Move TestMIPrompt away from pexpect().
Wed, Feb 20, 11:25 AM
davide committed rL354506: [lldb-mi] Move TestMIPrompt away from pexpect()..
[lldb-mi] Move TestMIPrompt away from pexpect().
Wed, Feb 20, 11:24 AM
davide committed rLLDB354506: [lldb-mi] Move TestMIPrompt away from pexpect()..
[lldb-mi] Move TestMIPrompt away from pexpect().
Wed, Feb 20, 11:24 AM
davide committed rGd8af34f92788: [lldb-mi] Remove a test that uses pexpect(). (authored by davide).
[lldb-mi] Remove a test that uses pexpect().
Wed, Feb 20, 10:27 AM
davide committed rL354494: [lldb-mi] Remove a test that uses pexpect()..
[lldb-mi] Remove a test that uses pexpect().
Wed, Feb 20, 10:27 AM
davide committed rLLDB354494: [lldb-mi] Remove a test that uses pexpect()..
[lldb-mi] Remove a test that uses pexpect().
Wed, Feb 20, 10:27 AM
davide closed D58459: [lldb-mi] Remove a test that uses pexpect()..
Wed, Feb 20, 10:27 AM · Restricted Project, Restricted Project
davide added reviewers for D58459: [lldb-mi] Remove a test that uses pexpect().: aprantl, zturner, labath.
Wed, Feb 20, 9:57 AM · Restricted Project, Restricted Project
davide created D58459: [lldb-mi] Remove a test that uses pexpect()..
Wed, Feb 20, 9:56 AM · Restricted Project, Restricted Project
davide abandoned D58458: [lldb-mi] Remove TestMiFile, its functionality is covered by a lit test..
Wed, Feb 20, 9:53 AM · Restricted Project
davide created D58458: [lldb-mi] Remove TestMiFile, its functionality is covered by a lit test..
Wed, Feb 20, 9:53 AM · Restricted Project

Yesterday

davide committed rGa875b9b32bd1: [lldbtest] Remove some accidentally commented out code. (authored by davide).
[lldbtest] Remove some accidentally commented out code.
Tue, Feb 19, 4:54 PM
davide committed rG89c77054a245: [testsuite] Fix TestUnicodeString to work with Py2 and Py3. (authored by davide).
[testsuite] Fix TestUnicodeString to work with Py2 and Py3.
Tue, Feb 19, 4:54 PM
davide committed rLLDB354415: [lldbtest] Remove some accidentally commented out code..
[lldbtest] Remove some accidentally commented out code.
Tue, Feb 19, 4:54 PM
davide committed rLLDB354414: [testsuite] Fix TestUnicodeString to work with Py2 and Py3..
[testsuite] Fix TestUnicodeString to work with Py2 and Py3.
Tue, Feb 19, 4:54 PM
davide committed rL354415: [lldbtest] Remove some accidentally commented out code..
[lldbtest] Remove some accidentally commented out code.
Tue, Feb 19, 4:54 PM
davide committed rL354414: [testsuite] Fix TestUnicodeString to work with Py2 and Py3..
[testsuite] Fix TestUnicodeString to work with Py2 and Py3.
Tue, Feb 19, 4:54 PM

Mon, Feb 18

davide committed rG05709acba49a: [lldbtest] Fix some code to be compatible between py2 and py3. (authored by davide).
[lldbtest] Fix some code to be compatible between py2 and py3.
Mon, Feb 18, 3:18 PM
davide committed rL354297: [lldbtest] Fix some code to be compatible between py2 and py3..
[lldbtest] Fix some code to be compatible between py2 and py3.
Mon, Feb 18, 3:18 PM
davide committed rLLDB354297: [lldbtest] Fix some code to be compatible between py2 and py3..
[lldbtest] Fix some code to be compatible between py2 and py3.
Mon, Feb 18, 3:18 PM
davide committed rG9144aa38edee: [Python3] Fix TestObjCMethods.py to work with py2 and 3. (authored by davide).
[Python3] Fix TestObjCMethods.py to work with py2 and 3.
Mon, Feb 18, 1:53 PM
davide committed rL354286: [Python3] Fix TestObjCMethods.py to work with py2 and 3..
[Python3] Fix TestObjCMethods.py to work with py2 and 3.
Mon, Feb 18, 1:52 PM
davide committed rLLDB354286: [Python3] Fix TestObjCMethods.py to work with py2 and 3..
[Python3] Fix TestObjCMethods.py to work with py2 and 3.
Mon, Feb 18, 1:52 PM

Sat, Feb 16

davide committed rG40046bc8430f: [testsuite] Skip this test correctly also on macOS. (authored by davide).
[testsuite] Skip this test correctly also on macOS.
Sat, Feb 16, 9:18 AM
davide committed rL354204: [testsuite] Skip this test correctly also on macOS..
[testsuite] Skip this test correctly also on macOS.
Sat, Feb 16, 9:17 AM
davide committed rLLDB354204: [testsuite] Skip this test correctly also on macOS..
[testsuite] Skip this test correctly also on macOS.
Sat, Feb 16, 9:17 AM

Fri, Feb 15

davide accepted D58308: [EarlyCSE] Cleanup deadcode. [NFCI].

LGTM

Fri, Feb 15, 2:54 PM · Restricted Project
davide committed rG1c2980161542: Revert "Don't include UnixSignals.h from Host." (authored by davide).
Revert "Don't include UnixSignals.h from Host."
Fri, Feb 15, 1:58 PM
davide committed rL354177: Revert "Don't include UnixSignals.h from Host.".
Revert "Don't include UnixSignals.h from Host."
Fri, Feb 15, 1:58 PM
davide committed rLLDB354177: Revert "Don't include UnixSignals.h from Host.".
Revert "Don't include UnixSignals.h from Host."
Fri, Feb 15, 1:58 PM

Wed, Feb 13

davide accepted D58177: Fix lldb-server test suite for python3.

LGTM

Wed, Feb 13, 10:09 AM · Restricted Project

Tue, Feb 12

davide accepted D58076: [Reproducers] Integrate FileProvider with clang.

LGTM with one comment.

Tue, Feb 12, 4:44 PM · Restricted Project
davide committed rG3eac27789d92: [testsuite] Add a comment explaining what this test does. (authored by davide).
[testsuite] Add a comment explaining what this test does.
Tue, Feb 12, 3:03 PM
davide committed rLLDB353896: [testsuite] Add a comment explaining what this test does..
[testsuite] Add a comment explaining what this test does.
Tue, Feb 12, 3:02 PM
davide committed rL353896: [testsuite] Add a comment explaining what this test does..
[testsuite] Add a comment explaining what this test does.
Tue, Feb 12, 3:02 PM
davide committed rGcaade2836285: [testsuite] Convert TestSingleQuote to lit. (authored by davide).
[testsuite] Convert TestSingleQuote to lit.
Tue, Feb 12, 2:58 PM
davide committed rLLDB353894: [testsuite] Convert TestSingleQuote to lit..
[testsuite] Convert TestSingleQuote to lit.
Tue, Feb 12, 2:58 PM
davide committed rL353894: [testsuite] Convert TestSingleQuote to lit..
[testsuite] Convert TestSingleQuote to lit.
Tue, Feb 12, 2:58 PM

Mon, Feb 11

davide accepted D57990: Use std::make_shared in LLDB (NFC).
Mon, Feb 11, 2:34 PM · Restricted Project

Wed, Feb 6

davide committed rG6c27a06302c2: [testsuite] Convert a pexpect test to lit. (authored by davide).
[testsuite] Convert a pexpect test to lit.
Wed, Feb 6, 1:49 PM
davide committed rL353345: [testsuite] Convert a pexpect test to lit..
[testsuite] Convert a pexpect test to lit.
Wed, Feb 6, 1:48 PM
davide committed rLLDB353345: [testsuite] Convert a pexpect test to lit..
[testsuite] Convert a pexpect test to lit.
Wed, Feb 6, 1:48 PM
davide closed D57840: Convert TestCommandRegex to lit (from expect).
Wed, Feb 6, 1:48 PM · Restricted Project
davide updated the diff for D57840: Convert TestCommandRegex to lit (from expect).

jonas was right

Wed, Feb 6, 1:47 PM · Restricted Project
davide updated the diff for D57840: Convert TestCommandRegex to lit (from expect).

zturner's update.

Wed, Feb 6, 1:46 PM · Restricted Project
davide retitled D57840: Convert TestCommandRegex to lit (from expect) from [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue. to Convert TestCommandRegex to lit (from expect).
Wed, Feb 6, 12:55 PM · Restricted Project
davide updated the diff for D57840: Convert TestCommandRegex to lit (from expect).

update with the correct patch.

Wed, Feb 6, 12:55 PM · Restricted Project
davide added inline comments to D57840: Convert TestCommandRegex to lit (from expect).
Wed, Feb 6, 12:54 PM · Restricted Project
davide created D57840: Convert TestCommandRegex to lit (from expect).
Wed, Feb 6, 12:53 PM · Restricted Project

Tue, Feb 5

davide committed rG76046abbfa47: [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue. (authored by davide).
[Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.
Tue, Feb 5, 2:25 PM
davide committed rLLDB353226: [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue..
[Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.
Tue, Feb 5, 2:24 PM
davide committed rL353226: [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue..
[Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.
Tue, Feb 5, 2:24 PM
davide committed rG0d98b771b0e9: [Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter. (authored by davide).
[Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter.
Tue, Feb 5, 9:31 AM
davide committed rLLDB353191: [Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter..
[Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter.
Tue, Feb 5, 9:30 AM
davide committed rL353191: [Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter..
[Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter.
Tue, Feb 5, 9:30 AM

Mon, Feb 4

davide committed rG60731071dedd: [Python2 to Python 3] Fix print -> print(). (authored by davide).
[Python2 to Python 3] Fix print -> print().
Mon, Feb 4, 5:00 PM
davide committed rLLDB353130: [Python2 to Python 3] Fix print -> print()..
[Python2 to Python 3] Fix print -> print().
Mon, Feb 4, 5:00 PM
davide committed rL353130: [Python2 to Python 3] Fix print -> print()..
[Python2 to Python 3] Fix print -> print().
Mon, Feb 4, 5:00 PM
davide removed a reviewer for D41608: [InstCombine] Missed optimization in math expression: pow multiplications: davide.
Mon, Feb 4, 7:18 AM · Restricted Project

Sun, Feb 3

davide committed rG1002ab3d1cd9: [docs] Recommend assertions when testing. (authored by davide).
[docs] Recommend assertions when testing.
Sun, Feb 3, 12:38 PM
davide committed rL353008: [docs] Recommend assertions when testing..
[docs] Recommend assertions when testing.
Sun, Feb 3, 12:38 PM
davide committed rG73929c4d240f: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation. (authored by davide).
[LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation.
Sun, Feb 3, 12:33 PM
davide committed rL353007: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation..
[LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation.
Sun, Feb 3, 12:33 PM
davide closed D57629: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation..
Sun, Feb 3, 12:33 PM · Restricted Project
davide updated the diff for D57629: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation..

adrian's comments

Sun, Feb 3, 12:32 PM · Restricted Project
davide added a comment to D57629: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation..

diff stat says I cleaned the test case a bit.

Sun, Feb 3, 12:28 PM · Restricted Project
davide added a comment to D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper..

I need to read the paper again because I forgot how the algorithm works. Please ping me in a week if I forget to review this.

Sun, Feb 3, 12:10 PM

Fri, Feb 1

davide added inline comments to D57629: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation..
Fri, Feb 1, 4:20 PM · Restricted Project
davide created D57629: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation..
Fri, Feb 1, 4:15 PM · Restricted Project

Thu, Jan 31

davide accepted D57550: [DWARF v5] A location description's length is a uleb not a short (Fixing PR40525)..

LGTM

Thu, Jan 31, 3:23 PM · Restricted Project
davide accepted D56921: [LCSSA] Add expensive verification of LCSSA form for sub-loops..

LGTM.

Thu, Jan 31, 11:21 AM · Restricted Project

Wed, Jan 30

davide committed rL352710: [testsuite] Fix TestAppleSimulator so that it works with Python 3..
[testsuite] Fix TestAppleSimulator so that it works with Python 3.
Wed, Jan 30, 5:17 PM
davide committed rLLDB352710: [testsuite] Fix TestAppleSimulator so that it works with Python 3..
[testsuite] Fix TestAppleSimulator so that it works with Python 3.
Wed, Jan 30, 5:17 PM
davide committed rLLDB352709: [Python] Fix gdb-remote and lldb-server utilities to work with Py3..
[Python] Fix gdb-remote and lldb-server utilities to work with Py3.
Wed, Jan 30, 5:01 PM
davide committed rL352709: [Python] Fix gdb-remote and lldb-server utilities to work with Py3..
[Python] Fix gdb-remote and lldb-server utilities to work with Py3.
Wed, Jan 30, 5:01 PM
davide committed rLLDB352706: [Python] Python 2 and Python 3 disagree on `/`..
[Python] Python 2 and Python 3 disagree on `/`.
Wed, Jan 30, 4:43 PM
davide committed rL352706: [Python] Python 2 and Python 3 disagree on `/`..
[Python] Python 2 and Python 3 disagree on `/`.
Wed, Jan 30, 4:43 PM
davide committed rLLDB352701: [Python] String(s) and bytes are two different entities in 3.7..
[Python] String(s) and bytes are two different entities in 3.7.
Wed, Jan 30, 4:11 PM
davide committed rL352701: [Python] String(s) and bytes are two different entities in 3.7..
[Python] String(s) and bytes are two different entities in 3.7.
Wed, Jan 30, 4:11 PM
davide accepted D57466: [lldb] Relax libc++ ABI version checking.

As long as this doesn't break macOS, it's fine. (just run the tests and watch the bots).

Wed, Jan 30, 1:06 PM · Restricted Project
davide accepted D57467: Fix use of non-existing variable in crashlog.py.

LGTM

Wed, Jan 30, 1:04 PM
davide added inline comments to D57213: [Scalar] Add support for 512-bits values..
Wed, Jan 30, 10:50 AM
davide committed rLLDB352643: [Scalar] Remove partially wrong and unused functions..
[Scalar] Remove partially wrong and unused functions.
Wed, Jan 30, 10:40 AM
davide committed rL352643: [Scalar] Remove partially wrong and unused functions..
[Scalar] Remove partially wrong and unused functions.
Wed, Jan 30, 10:40 AM
davide committed rLLDB352641: [Scalar] Hoist a duplicated (and sometimes wrong) comment..
[Scalar] Hoist a duplicated (and sometimes wrong) comment.
Wed, Jan 30, 10:24 AM
davide committed rL352641: [Scalar] Hoist a duplicated (and sometimes wrong) comment..
[Scalar] Hoist a duplicated (and sometimes wrong) comment.
Wed, Jan 30, 10:24 AM
davide added inline comments to D57213: [Scalar] Add support for 512-bits values..
Wed, Jan 30, 10:23 AM
davide committed rLLDB352639: [Scalar] Implement support for 512-bit values..
[Scalar] Implement support for 512-bit values.
Wed, Jan 30, 10:05 AM
davide committed rL352639: [Scalar] Implement support for 512-bit values..
[Scalar] Implement support for 512-bit values.
Wed, Jan 30, 10:05 AM
davide closed D57213: [Scalar] Add support for 512-bits values..
Wed, Jan 30, 10:05 AM

Tue, Jan 29

davide added a comment to D57413: Fix some warnings with gcc on Linux.

To clarify, I think we ought to fix the UB regardless, but Zachary's change can go in anyway as it doesn't make the situation worse than it was before.

Tue, Jan 29, 2:52 PM
davide added inline comments to D57413: Fix some warnings with gcc on Linux.
Tue, Jan 29, 2:45 PM
davide added a comment to D57413: Fix some warnings with gcc on Linux.

the changes that touch code I wrote lgtm.

Tue, Jan 29, 2:22 PM
davide accepted D55376: Generate LLDB website/documentation from rst with Sphinx.

LGTM

Tue, Jan 29, 12:54 PM

Mon, Jan 28

davide added inline comments to D57363: Fix handling of CreateTemplateParameterList when there is an empty pack.
Mon, Jan 28, 6:56 PM
davide added inline comments to D57213: [Scalar] Add support for 512-bits values..
Mon, Jan 28, 10:30 AM
davide added a comment to D57213: [Scalar] Add support for 512-bits values..

Thanks for the review, Greg!

Mon, Jan 28, 8:38 AM

Sat, Jan 26

davide accepted D57272: Remove unimplemented function.

LGTM

Sat, Jan 26, 1:14 PM

Fri, Jan 25

davide accepted D54617: [Reproducers] Add file provider.

I don't have other comments, this is good to go for me. Pavel?

Fri, Jan 25, 4:33 PM · Restricted Project
davide added a comment to D54617: [Reproducers] Add file provider.

Some comments. Thanks!

Fri, Jan 25, 3:26 PM · Restricted Project