Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (213 w, 5 d)

Recent Activity

Today

davide accepted D55821: [llvm-objdump] - Demangle the symbols when printing symbol table and relocations..
Tue, Dec 18, 7:48 AM

Yesterday

davide committed rLLDB349372: Fix lldb's macosx/heap.py cstr command..
Fix lldb's macosx/heap.py cstr command.
Mon, Dec 17, 10:25 AM
davide committed rL349372: Fix lldb's macosx/heap.py cstr command..
Fix lldb's macosx/heap.py cstr command.
Mon, Dec 17, 10:25 AM
davide closed D55776: Fix lldb's macosx/heap.py cstr command.
Mon, Dec 17, 10:25 AM
davide accepted D55776: Fix lldb's macosx/heap.py cstr command.

commit 44b5014ce138fa293238afeaa53cfd4c2f5b12d2 (HEAD -> master)
Author: Davide Italiano <ditaliano@apple.com>
Date: Mon Dec 17 10:23:44 2018 -0800

Mon, Dec 17, 10:25 AM
davide updated subscribers of D55776: Fix lldb's macosx/heap.py cstr command.
Mon, Dec 17, 10:18 AM
davide created D55776: Fix lldb's macosx/heap.py cstr command.
Mon, Dec 17, 10:18 AM

Sun, Dec 16

davide committed rL349323: [EarlyCSE] If DI can't be salvaged, mark it as unavailable..
[EarlyCSE] If DI can't be salvaged, mark it as unavailable.
Sun, Dec 16, 5:46 PM

Fri, Dec 14

davide accepted D51595: [NewGVN] Update use counts for SSA copies when replacing them by their operands..

LGTM

Fri, Dec 14, 3:58 PM

Thu, Dec 13

davide accepted D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

LGTM.

Thu, Dec 13, 3:30 PM · debug-info
davide added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

OK, I'll try to review it later today. Will you have time to commit this or you want any of us to do it on your behalf?

Thu, Dec 13, 10:42 AM · debug-info
davide committed rL349069: [LoopUtils] Use i32 instead of `void`..
[LoopUtils] Use i32 instead of `void`.
Thu, Dec 13, 10:40 AM
davide added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

So, is there anything remaining before we can merge this patch?

Thu, Dec 13, 10:23 AM · debug-info

Wed, Dec 12

davide committed rL348999: [LoopUtils] Prefer a set over a map. NFCI..
[LoopUtils] Prefer a set over a map. NFCI.
Wed, Dec 12, 5:15 PM
davide committed rL348988: [LoopDeletion] Update debug values after loop deletion..
[LoopDeletion] Update debug values after loop deletion.
Wed, Dec 12, 3:38 PM
davide closed D55299: [LoopDeletion] Update debug values after loop deletion..
Wed, Dec 12, 3:38 PM

Mon, Dec 10

davide committed rL348804: [Local] Promote an utility that could be used elsewhere. NFCI..
[Local] Promote an utility that could be used elsewhere. NFCI.
Mon, Dec 10, 2:21 PM

Thu, Dec 6

davide added a comment to D55302: Implement WindowsDYLD::DidAttach for querying the load address with a gdb-remote.

@davide The review was here, not sure why this didn't get attached to the commit:

Landed in revision: https://llvm.org/svn/llvm-project/lldb/trunk@348526

Thu, Dec 6, 3:23 PM
davide updated subscribers of D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2.

You would recommend getting a post-commit review from @labath or @zturner

Thu, Dec 6, 1:32 PM

Wed, Dec 5

davide added a comment to D55299: [LoopDeletion] Update debug values after loop deletion..

I'll switch this to be a DenseMap.

Wed, Dec 5, 5:52 PM

Tue, Dec 4

davide updated the diff for D55299: [LoopDeletion] Update debug values after loop deletion..

Updated to address Adrian's comments.

Tue, Dec 4, 3:38 PM
davide added inline comments to D55299: [LoopDeletion] Update debug values after loop deletion..
Tue, Dec 4, 3:34 PM
davide updated the diff for D55299: [LoopDeletion] Update debug values after loop deletion..

patch with context.

Tue, Dec 4, 2:59 PM
davide created D55299: [LoopDeletion] Update debug values after loop deletion..
Tue, Dec 4, 2:58 PM

Mon, Dec 3

davide added a comment to D55240: [FileSystem] Migrate CommandCompletions.

No objections from me, but I would appreciate if @labath can take a look.

Mon, Dec 3, 3:44 PM · Restricted Project
davide accepted D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries.

LGTM, sorry. for the delay.

Mon, Dec 3, 9:15 AM · debug-info

Sat, Dec 1

davide accepted D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

LGTM conditional to lack of objections from people on llvm-dev.

Sat, Dec 1, 12:42 PM

Wed, Nov 28

davide added a comment to D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter..

I reverted this change because it breaks a bunch of lldb tests (on MacOS, and probably on other platforms too). To be clear, part of the reason I'm reacting strongly here is that this is not the first patch this has come up on. I'm worried about the broader trend of landing patches to ASTImporter without proper reviews and testing as I am of this very instance. I really think you should consider asking reviews to somebody who's familiar with clang and test lldb as it's the main client of this functionality we have in tree.

@davide I am terribly sorry about this issue. I just applied this patch on my Linux box, and it did not failed those tests which failed on the green lab buildbots. Could you please refer to the Linux buildbots which failed? Seems like there is a significant difference between the testsuites on Linux and MacOS. Our primary target is Linux and we do run the LLDB tests before we accept any commit into our fork and only then we continue with upstreaming to Phabricator.

Wed, Nov 28, 3:37 PM
davide added a comment to D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter..

I reverted this change because it breaks a bunch of lldb tests (on MacOS, and probably on other platforms too).
To be clear, part of the reason I'm reacting strongly here is that this is not the first patch this has come up on.
I'm worried about the broader trend of landing patches to ASTImporter without proper reviews and testing as I am of this very instance.
I really think you should consider asking reviews to somebody who's familiar with clang and test lldb as it's the main client of this functionality we have in tree.

Wed, Nov 28, 11:22 AM
davide updated subscribers of D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter..
Wed, Nov 28, 11:18 AM
davide committed rL347794: Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter.".
Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter."
Wed, Nov 28, 11:18 AM
davide committed rC347794: Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter.".
Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter."
Wed, Nov 28, 11:18 AM
davide added a comment to D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.

This doesn't break anything, and I'm fairly confident Raphael (@teemperor) ran the tests.

Wed, Nov 28, 11:02 AM · Restricted Project
davide added a comment to D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

As somebody who used bugpoint fairly extensively over the course of the years, I have to say I always considered a little error prone the fact that bugpoint looks up in the PATH to find opt.
So, I tend to be in favor of this patch, but I'm wondering whether it's worth to look in the $PATH instead of just looking in the current directory.
Realistically bugpoint is a tool for developers, so chances are you're going to run it directly from bin using the compiler/interpreter/assembler you just built.

Wed, Nov 28, 8:30 AM

Tue, Nov 27

Herald updated subscribers of D37820: [BinaryFormat] Teach identify_magic about Tapi files..
Tue, Nov 27, 3:07 PM
davide accepted D54616: [Reproducers] Improve reproducer API and add unit tests..

LGTM

Tue, Nov 27, 12:31 PM · Restricted Project
davide committed rL347673: Catch up with EvaluateAsInt() clang API change..
Catch up with EvaluateAsInt() clang API change.
Tue, Nov 27, 8:43 AM
davide committed rLLDB347673: Catch up with EvaluateAsInt() clang API change..
Catch up with EvaluateAsInt() clang API change.
Tue, Nov 27, 8:43 AM

Mon, Nov 26

davide committed rL347619: Revert "[CMake] Streamline code signing for debugserver and pass entitlements….
Revert "[CMake] Streamline code signing for debugserver and pass entitlements…
Mon, Nov 26, 4:29 PM
davide committed rLLDB347619: Revert "[CMake] Streamline code signing for debugserver and pass entitlements….
Revert "[CMake] Streamline code signing for debugserver and pass entitlements…
Mon, Nov 26, 4:29 PM
davide committed rLLDB347579: [lit] Fully qualify lit_config to avoid runtime crashes..
[lit] Fully qualify lit_config to avoid runtime crashes.
Mon, Nov 26, 9:42 AM
davide committed rL347579: [lit] Fully qualify lit_config to avoid runtime crashes..
[lit] Fully qualify lit_config to avoid runtime crashes.
Mon, Nov 26, 9:42 AM
davide committed rL347578: [Cmake] Add missing dependency to `count`..
[Cmake] Add missing dependency to `count`.
Mon, Nov 26, 9:34 AM
davide committed rLLDB347578: [Cmake] Add missing dependency to `count`..
[Cmake] Add missing dependency to `count`.
Mon, Nov 26, 9:34 AM
davide added a comment to D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext.

Can you write an lldb test for this?

There is already an existing test for that:

2: test_expr_dwarf (TestSharedLib.SharedLibTestCase)
   Test that types work when defined in a shared library and forward-declared in the main executable ... python: ../../git/llvm/tools/clang/include/clang/AST/DeclBase.h:2298: void clang::DeclContext::setMustBuildLookupTable(): Assertion `this == getPrimaryContext() && "should only be called on primary context"' failed.
Mon, Nov 26, 8:59 AM
davide added a comment to D54692: [Driver] Use libOption with tablegen..

Would be great to see old and new output like Zach suggested. Is there a reason we need to use TableGen? Other command line tools just use llvm:🆑:opt stuff. Seems a bit obtuse to use TableGen?

Mon, Nov 26, 8:57 AM · Restricted Project
davide added a comment to D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext.

We have a change in Clang/ASTImporter which causes an LLDB assertion, unless this patch is applied.
The related change is https://reviews.llvm.org/D53655

In that patch we change the importer to properly import the redecl chains of RecordDecls. Consequently the to_tag_decl here in LLDB may not always be the PrimaryContext anymore, thus we have to explicitly use the primary context.

Mon, Nov 26, 6:40 AM

Mon, Nov 19

davide accepted D54732: [LoopUnroll] Don't verify domtree by default with +Asserts..

LGTM. Given this is under EXPENSIVE_CHECK, we might consider a more thorough verification?

Mon, Nov 19, 3:41 PM
davide accepted D54686: [IR] Add hasNPredecessors, hasNPredecessorsOrMore to BasicBlock.

LGTM

Mon, Nov 19, 11:19 AM

Sun, Nov 18

davide accepted D54680: Don't use lldb -O in lit tests.

I don't have any other great ideas either and I'd say the proposed alternative is not worth the complexity.

Sun, Nov 18, 7:57 PM
davide added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

Alexsei, I'm afraid I'm not qualified to review this patch. I would really recommend you to find somebody who's familiar with clang to review it, as it already seems to have broken lldb in the past.

Sun, Nov 18, 4:42 PM
davide requested changes to D54680: Don't use lldb -O in lit tests.

Is there a way of fixing this that doesn't require scattering the test between two files?

Sun, Nov 18, 4:40 PM

Nov 16 2018

davide committed rL347087: [Cocoa] Prefer llvm::SignExtend64. Pointed out by zturner..
[Cocoa] Prefer llvm::SignExtend64. Pointed out by zturner.
Nov 16 2018, 11:57 AM
davide committed rLLDB347087: [Cocoa] Prefer llvm::SignExtend64. Pointed out by zturner..
[Cocoa] Prefer llvm::SignExtend64. Pointed out by zturner.
Nov 16 2018, 11:57 AM
davide committed rL347084: [SymbolFile] Remove unused function. NFCI..
[SymbolFile] Remove unused function. NFCI.
Nov 16 2018, 11:51 AM
davide committed rLLDB347084: [SymbolFile] Remove unused function. NFCI..
[SymbolFile] Remove unused function. NFCI.
Nov 16 2018, 11:50 AM

Nov 15 2018

davide accepted D54602: Use a shared module cache directory for LLDB..

lgtm

Nov 15 2018, 10:55 PM

Nov 13 2018

davide committed rLLDB346783: [Cocoa] Implement formatter for the new NSDate representation..
[Cocoa] Implement formatter for the new NSDate representation.
Nov 13 2018, 11:46 AM
davide committed rL346783: [Cocoa] Implement formatter for the new NSDate representation..
[Cocoa] Implement formatter for the new NSDate representation.
Nov 13 2018, 11:46 AM

Nov 12 2018

davide committed rL346694: Revert "Extract construction of DataBufferLLVM into FileSystem".
Revert "Extract construction of DataBufferLLVM into FileSystem"
Nov 12 2018, 11:11 AM
davide committed rLLDB346694: Revert "Extract construction of DataBufferLLVM into FileSystem".
Revert "Extract construction of DataBufferLLVM into FileSystem"
Nov 12 2018, 11:10 AM
davide accepted D54432: [lldb] Fix the typo (replace underscore with dash) in svn:ignore on test/ and add "lldb-test-build.noindex" to ignored files.
Nov 12 2018, 10:55 AM
davide accepted D54431: [lldb] Add "ninja" to svn:ignore.

This is trivial. I don't know why we didn't do this before.

Nov 12 2018, 10:55 AM
davide accepted D44081: [lldb] Add synthetic frontend for _NSCallStackArray.

Thanks for addressing my comments.

Nov 12 2018, 10:54 AM
davide accepted D43884: [lldb] Extract more fields from NSException values.

LGTM. Thanks.

Nov 12 2018, 10:54 AM
davide requested changes to D43884: [lldb] Extract more fields from NSException values.
Nov 12 2018, 7:50 AM
davide requested changes to D44081: [lldb] Add synthetic frontend for _NSCallStackArray.
Nov 12 2018, 7:48 AM
davide accepted D44073: [lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC..

Sounds good.

Nov 12 2018, 7:47 AM
davide accepted D44060: [lldb] Fix "code requires global destructor" warning in g_architecture_mutex.

LGTM.

Nov 12 2018, 7:46 AM

Nov 8 2018

davide committed rL346444: Revert "Fix bug in PE/COFF plugin and ValueObjectVariable.".
Revert "Fix bug in PE/COFF plugin and ValueObjectVariable."
Nov 8 2018, 2:50 PM
davide committed rLLDB346444: Revert "Fix bug in PE/COFF plugin and ValueObjectVariable.".
Revert "Fix bug in PE/COFF plugin and ValueObjectVariable."
Nov 8 2018, 2:50 PM
davide committed rL346410: Revert "[MSP430] Add MC layer".
Revert "[MSP430] Add MC layer"
Nov 8 2018, 8:25 AM

Nov 7 2018

davide accepted D54135: Add convenience method in FileSystem to check if a path/filespec is a directory..
Nov 7 2018, 3:30 PM · Restricted Project
davide accepted D51168: [NewGVN] Make sure we do not add a user to itself..

LGTM.

Nov 7 2018, 6:55 AM

Nov 6 2018

davide committed rLLDB346247: [ObjectFile] Prefer reinterpret_cast<>.
[ObjectFile] Prefer reinterpret_cast<>
Nov 6 2018, 9:44 AM
davide committed rL346247: [ObjectFile] Prefer reinterpret_cast<>.
[ObjectFile] Prefer reinterpret_cast<>
Nov 6 2018, 9:44 AM
davide added a comment to D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test.

@lanza Hey Nathan, it looks like your test exposed an UB in ELFObjectFileReader. May I ask you to take a look?

  • TEST 'lldb-Unit :: ObjectFile/ELF/./ObjectFileELFTests/ObjectFileELFTest.TestAARCH64Relocations' FAILED **** Note: Google Test filter = ObjectFileELFTest.TestAARCH64Relocations [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from ObjectFileELFTest [ RUN ] ObjectFileELFTest.TestAARCH64Relocations /Users/buildslave/jenkins/workspace/lldb-sanitized/llvm/tools/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2741:11: runtime error: store to misaligned address 0x61f000001526 for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment 0x61f000001526: note: pointer points here 00 00 04 00 00 00 00 00 08 01 00 00 00 00 0c 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/buildslave/jenkins/workspace/lldb-sanitized/llvm/tools/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2741:11 in
Nov 6 2018, 9:16 AM
davide committed rL346244: [ObjectFileELF] Fix misaligned read/writes caught by UBSan..
[ObjectFileELF] Fix misaligned read/writes caught by UBSan.
Nov 6 2018, 9:14 AM
davide committed rLLDB346244: [ObjectFileELF] Fix misaligned read/writes caught by UBSan..
[ObjectFileELF] Fix misaligned read/writes caught by UBSan.
Nov 6 2018, 9:14 AM
davide added a comment to D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test.

@lanza Hey Nathan, it looks like your test exposed an UB in ELFObjectFileReader. May I ask you to take a look?

Nov 6 2018, 8:09 AM

Nov 5 2018

davide committed rL346186: [TestVLA] Fix a python decorator..
[TestVLA] Fix a python decorator.
Nov 5 2018, 4:20 PM
davide committed rLLDB346186: [TestVLA] Fix a python decorator..
[TestVLA] Fix a python decorator.
Nov 5 2018, 4:20 PM
davide accepted D54060: Remove OCaml debugger plugin.
Nov 5 2018, 11:35 AM · Restricted Project
davide added inline comments to D54059: Remove Java debugger plugin.
Nov 5 2018, 8:12 AM · Restricted Project
davide accepted D54057: Remove Go debugger plugin.

LGTM. Thanks for picking up the slack.

Nov 5 2018, 8:11 AM

Nov 3 2018

davide added a comment to D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit").

It broke the testsuite for me:

$ time PYTHONPATH=$PWD/lib64/python2.7/site-packages:$PWD/lib64/python2.7/site-packages/lldb ../llvm-git/tools/lldb/test/dotest.py --executable $PWD/bin/lldb -C $PWD/bin/clang -t ../llvm-git/tools/lldb/packages/Python/lldbsuite/test/ 
WARNING:root:No valid FileCheck executable; some tests may fail...
WARNING:root:(Double-check the --filecheck argument to dotest.py)
LLDB library dir: /home/jkratoch/redhat/llvm-git-build-release-clang/bin
LLDB import library dir: /home/jkratoch/redhat/llvm-git-build-release-clang/bin
lldb version 8.0.0
  clang revision 6974b990e13dfb4190a6dffdcc8bac9edbd1cde5
  llvm revision 7fad5fb0d0d32beea4e95e239cc065a850733358
Libc++ tests will not be run because: Unable to find libc++ installation
Skipping following debug info categories: ['dsym', 'gmodules']
Traceback (most recent call last):
  File "../llvm-git/tools/lldb/test/dotest.py", line 7, in <module>
    lldbsuite.test.run_suite()
  File "/home/jkratoch/redhat/llvm-git/tools/lldb/packages/Python/lldbsuite/test/dotest.py", line 1323, in run_suite
    visit('Test', dirpath, filenames)
  File "/home/jkratoch/redhat/llvm-git/tools/lldb/packages/Python/lldbsuite/test/dotest.py", line 965, in visit
    raise Exception("Found multiple tests with the name %s" % name)
Exception: Found multiple tests with the name TestSampleTest.py

As really there are now:

$ find -name TestSampleTest.py
./packages/Python/lldbsuite/test/expression_command/dont_allow_jit/TestSampleTest.py
./packages/Python/lldbsuite/test/sample_test/TestSampleTest.py
Nov 3 2018, 3:37 PM

Nov 2 2018

davide added a comment to D53368: [Symbol] Search symbols with name and type in a symbol file.

Thanks for catching that! Unfortunately, I have no access to MacOS, can you provide some more info about failure, please?

Nov 2 2018, 10:23 PM · Restricted Project
davide committed rL346045: Revert "[Symbol] Search symbols with name and type in a symbol file".
Revert "[Symbol] Search symbols with name and type in a symbol file"
Nov 2 2018, 3:01 PM
davide committed rLLDB346045: Revert "[Symbol] Search symbols with name and type in a symbol file".
Revert "[Symbol] Search symbols with name and type in a symbol file"
Nov 2 2018, 3:01 PM
davide added a comment to D53368: [Symbol] Search symbols with name and type in a symbol file.

This broke MacOS. I'm going to revert this. To reproduce, just run ninja check-lldb with your patches.
Please let me know if you need other informations.

Nov 2 2018, 3:00 PM · Restricted Project

Nov 1 2018

davide added inline comments to D54003: Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove redundant parameter which can be calculated from other parameter.
Nov 1 2018, 3:14 PM
davide accepted D53834: [FileSystem] Remove ResolveExecutableLocation() from FileSpec.

LGTM, thanks.

Nov 1 2018, 9:39 AM · Restricted Project

Oct 31 2018

davide added a comment to D51168: [NewGVN] Make sure we do not add a user to itself..

I'll take a look early next week. Sorry, I don't work on scalar optimizations anymore on llvm these days, so I need to page this code in again.

Oct 31 2018, 4:46 PM
davide added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

Hello everyone.
@martong : this version of patch reorders only fields and friends. No method reordering is done (I can check if it works, though, and add the feature).
@davide: Unfortunately, I was not able to reproduce the problem on Linux. Could you please provide a link to a buildbot failure or some environment description so I can reproduce the issue or, at least, take a look?

Oct 31 2018, 8:17 AM
davide added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

No worries :) l

Oct 31 2018, 8:16 AM

Oct 30 2018

davide committed rLLDB345668: [testsuite] Skip an already failing test on MacOS..
[testsuite] Skip an already failing test on MacOS.
Oct 30 2018, 3:51 PM
davide committed rL345668: [testsuite] Skip an already failing test on MacOS..
[testsuite] Skip an already failing test on MacOS.
Oct 30 2018, 3:51 PM
davide committed rL345643: Revert "[ASTImporter] Reorder fields after structure import is finished".
Revert "[ASTImporter] Reorder fields after structure import is finished"
Oct 30 2018, 1:48 PM
davide committed rC345643: Revert "[ASTImporter] Reorder fields after structure import is finished".
Revert "[ASTImporter] Reorder fields after structure import is finished"
Oct 30 2018, 1:48 PM
davide updated subscribers of D44100: [ASTImporter] Reorder fields after structure import is finished.

This patch broke lldb, at least on MacOS.
You can reproduce the issue building lldb, applying your patch and then running

Oct 30 2018, 1:47 PM