- User Since
- Nov 12 2014, 1:58 PM (257 w, 5 h)
What are you trying to accomplish here?
Tue, Oct 8
Mon, Oct 7
Fri, Oct 4
Wed, Oct 2
Tue, Oct 1
I think I wrote some of this code and it predates Kuba's incremental dominator updater. I'm fine, but I'll wait if he has opinions cc: @kuhar
Fri, Sep 27
This needs a test. You can either write a python one as the ones in test/testcases or a lit-style based as the ones in lit/.
Wed, Sep 25
yes, this needs a test.
Fri, Sep 20
Just keep an eye on the bots as they might start whining
If this doesn't break clang and gcc, fine.
Sep 16 2019
Sep 13 2019
Sure. If anything something like this should live in llvm/Support, but given it's not used, it should live nowhere.
Sep 12 2019
Sep 4 2019
Sep 3 2019
You can just go ahead with patches like this one.
Aug 30 2019
Aug 29 2019
Aug 28 2019
LGTM. Thanks. I'm going to clean the diff downstream.
Aug 27 2019
Aug 26 2019
Aug 21 2019
I and Jason discussed this offline and he's fine with it, so, I'm going to land this now.
Aug 16 2019
LGTM. It would be great if we can add a test.
Aug 14 2019
Aug 12 2019
More than error handling, this allows us to distinguish with a type with zero alignment (if possible at all?) and an error getting the alignment from ASTContext/
Aug 8 2019
Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology?
I think this is definitely a good idea but Chandler or DBlaikie might want to take a look at this one too.
Aug 7 2019
I seem to remember there was a bug where you run the expression twice and the second time it crashes/it's not evaluated correctly [at least this is what I remember talking to Lang ~18 months ago].
If that works, yay for more coverage!
You might want to check with Argyrios, maybe file a rdar against SourceKit.
Otherwise, this is fine to me.
Aug 5 2019
Jul 31 2019
[and Raphael for the clang vendor bits]
Really on the lldb side, Jonas is the right person to review this patch.
Jul 30 2019
Other than that, I have no objections.
I wanted to remove it a while ago, but Jason told me he found this useful, so I would wait for his opinion.
Jul 29 2019
Jul 24 2019
Jul 22 2019
Minor otherwise LGTM