Oh I still saw that one running a few days back! @stella.stamenova in the review you mention a second windows lldb bot, is it x86 as well? I don't see it in https://lab.llvm.org/buildbot/#/console

In D145242#4173592, @Michael137 wrote:

In D145242#4173577, @stella.stamenova wrote:

Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and revert the changes to bring it back to green.

Ah thanks for pointing it out. Thought I had fixed it with https://reviews.llvm.org/rG96e39fdbb90b26191fc79b6226f299e3c10e559b

Will check on my Windows machine. But feel free to revert, since I'm only going to be able to look at it tomorrow

Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and revert the changes to bring it back to green.

Looks like this change broke the windows lldb build: https://lab.llvm.org/buildbot/#/builders/83/builds/29801

Looks like the new test is failing on the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29680. The buildbot was already red because of TestCommandScript.py, so you might have missed this.

Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/32020

One thing that we could do is disable werror on the buildbot for the moment and then re-enable it. It's not terribly difficult, but it relies on buildbot master being re-started to take effect, so it might not even take effect before the warnings are fixed.

In D143800#4124624, @wrengr wrote:

@stella.stamenova This patch introduces some deprecation warnings, which are intended for other folks on our team to help track down the offending use-sites so they can fix them. Is there anything I need to do to ensure the LLVM buildbot doesn't reject this patch because of the new warnings?

LGTM

Looks like this caused a failure in the mlir buildbot due to an unused variable: https://lab.llvm.org/buildbot/#/builders/13/builds/31682

In D135128#4107816, @jansvoboda11 wrote:

@stella.stamenova ping

Thanks for fixing this long-standing bug!

Looks like this added a failure to the already red mlir windows buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/30167

Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/30140

@rahmanl would it be possible to address the windows failures or revert this commit while someone investigates?

In D139447#3983091, @Mogball wrote:

It should be fixed at HEAD now. The fix was sent out shortly after this patch.

It looks like this change broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/29443

Looks like this broke the windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/26822

@Peiming : I reverted your change because it broke multiple buildbots - windows and gcc included. I see that you've re-committed it. Did you make sure to address all three build breaks that were reported including the one @vzakhari pointed out? In cases like this, please make sure NOT to recommit your changes without making sure that all build breaks are addressed as it is disruptive to have buildbots that are broken especially when a change is identified as the source.

In D138627#3972495, @vzakhari wrote:

In D138627#3972470, @PeteSteinfeld wrote:

@Peiming, this patch breaks the flang build.

It is not flang specific issue, though. The following gcc buildbot fails: https://lab.llvm.org/buildbot/#/builders/160/builds/13724

Looks like the windows lldb bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/26083

In D137998#3932524, @wrengr wrote:

@stella.stamenova I just posted D138167. Can you check to see if that resolves things on your side?

Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/26042

In D137998#3932416, @wrengr wrote:

@stella.stamenova As a heads-up, I'm going to land this now. If you encounter any other issues from LLVM's buildbot, just let me know and I'm more than happy to address them promptly.

In D135128#3921902, @jansvoboda11 wrote:

@stella.stamenova Any updates?

This appears to have broken the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/28298

In D133366#3923291, @kastiglione wrote:

Ugh, the test that is failing uses windows paths but runs on both windows and non-windows machines. I will revert this and the two fix commits.

This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854

In rG99171078bb9bea3f31be948e124ec945a50e1fe1#1141721, @Peiming wrote:

I don't think the revert is correct, the warning should be introduced by D137442 ( and it should have been fixed)

In D135128#3902772, @jansvoboda11 wrote:

In D135128#3902698, @stella.stamenova wrote:

This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829

Thanks for the heads-up. Who would be the best person to look into this? Seems like this patch exposes an UB in Windows Kits (https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c5105).

This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829

The newly added test is failing on the windows buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/25446

Looks like in addition to the Linux failure, this also broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio

This change has caused intermittent failures in reorder.py on Windows. I wonder why the changes to the test were necessary and if we can update it so it works consistently on Windows as well as with bazel:

I think this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24905

In D135613#3853454, @wrengr wrote:

In D135613#3853446, @stella.stamenova wrote:

To be clear, Nate identified this change as the reason for the windows mlir buildbot failures.

How did D135613 cause the failure when that function wasn't introduced until D135480?

In D135613#3852960, @NathanielMcVicar wrote:

This appears to have broken the C interface. I suppose the corresponding rename will be required there. https://lab.llvm.org/buildbot/#/builders/13/builds/26975/steps/6/logs/stdio

C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/ExecutionEngine/SparseTensorRuntime.h(245): error C2220: the following warning is treated as an error
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/ExecutionEngine/SparseTensorRuntime.h(245): warning C4190: '_mlir_ciface_getSparseTensorReaderNextF16' has C-linkage specified, but returns UDT 'f16' which is incompatible with C
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/ExecutionEngine/Float16bits.h(35): note: see declaration of 'f16'

In D135612#3847814, @raikonenfnu wrote:

Hey Stella, FYI, the windows fix is up here. :)

LGTM. A couple of minor comments inline.

Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/26882

Looks like this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24631

Both debug and release windows builds are green with this. Thanks!

There's, unfortunately, no public facing mlir windows bot that builds debug. We have some internal testing which builds debug which is how we ran into this.

This change broke the mlir build on Windows in Debug. I'm actually not entirely sure why it only broke in Debug and not in Release as well because I would expect the issue to be the same in both.

In D135126#3840989, @wrengr wrote:

Hmm, git-blame is showing that this differential has landed in github yet phabricator indicates it's still merely "accepted". I'm not too familiar with how phabricator interacts with github, but should this differential be closed?

We ended up with https://reviews.llvm.org/D135304 as the currently committed change. I believe this worked correctly everywhere, but if anyone knows of a break, we should address that as well.

D135126 was needed to fix the Windows mlir bot which was red for several days because of https://github.com/llvm/llvm-project/commit/e898be2f6edbb886af2f6b23e2f5db5210535620 which landed after D134925 and undid it.

As Nate said, https://github.com/llvm/llvm-project/commit/e898be2f6edbb886af2f6b23e2f5db5210535620 broke the windows mlir bot which then stayed red for a couple of days. We wanted to make sure to get it back to green and this change seemed the most appropriate. We are not particularly tied to this change or another change but simply reverting this will get us back to a red state. @wrengr @aartbik if you have a better way to address the issue, that would be great, but we do not want the bot to be red again.

LGTM, thanks for fixing the build breaks!