Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (176 w, 1 d)

Recent Activity

Tue, Jun 22

stella.stamenova added a comment to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.

The newly added test is flaky and it fails on the Windows bot every few runs. I also saw it fail on Ubuntu in our private buildbots.
Failing build:
https://lab.llvm.org/buildbot/#/builders/13/builds/8922

Tue, Jun 22, 3:22 PM · Restricted Project

Mon, Jun 21

stella.stamenova added a comment to D101128: [lldb-vscode] only report long running progress events.

I'm reverting it asap

Mon, Jun 21, 11:14 AM · Restricted Project
stella.stamenova added a comment to D101128: [lldb-vscode] only report long running progress events.

@wallace : Your most recent change to comment out ProgressEventThreadFunction is causing warnings to be generated when building with clang. Please have a look:

Mon, Jun 21, 10:47 AM · Restricted Project

Fri, Jun 18

stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

We also see check-all timeout recently (fairly consistently), see https://bugs.chromium.org/p/chromium/issues/detail?id=1221702

Since Stella reported problems with this too, I speculatively reverted it (and follow-ups) in fb32de9e97af0921242a021e30020ffacf7aa6e2 for now.

Fri, Jun 18, 3:57 PM · Restricted Project
stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

I wasn't able to reproduce this locally by running *just* the DirectoryWatcher tests. I'm not running all of the clang tests repeatedly to see if I can get a repro that way.

Fri, Jun 18, 9:26 AM · Restricted Project

Thu, Jun 17

stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

This is the best I can do from the online builds. I'll try and repro locally as well:

Thu, Jun 17, 1:22 PM · Restricted Project
stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

Interesting, are the logs from the runs available? I have run the test ~10000 times locally and its been stable. Perhaps the logs can show what is going on.

Thu, Jun 17, 11:31 AM · Restricted Project
stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

We still occasionally (every couple of runs) see these tests hang on Windows in both Debug and Release. Unfortunately, I don't have access to the machines running the tests to debug the tests while they are hanging and I haven't had a chance to try to reproduce locally.

Thu, Jun 17, 11:24 AM · Restricted Project
stella.stamenova added a comment to D103821: [lld/mac] Add reexports after reexporter to inputFiles.

In the last week or so I've seen one of these tests fail occasionally with ACCESS_VIOLATION in our testing. Unfortunately, I can't get a local repro. Here's the (best) log I can get from our online testing:

Thu, Jun 17, 11:14 AM · Restricted Project, Restricted Project
stella.stamenova committed rG734d688fbce8: [clang] Fix a race condition in the build of clangInterpreter (authored by stella.stamenova).
[clang] Fix a race condition in the build of clangInterpreter
Thu, Jun 17, 10:04 AM
stella.stamenova closed D104311: [clang] Fix a race condition in the build of clangInterpreter.
Thu, Jun 17, 10:03 AM · Restricted Project

Tue, Jun 15

stella.stamenova requested review of D104311: [clang] Fix a race condition in the build of clangInterpreter.
Tue, Jun 15, 10:08 AM · Restricted Project

Mon, Jun 14

stella.stamenova added a comment to D103575: Allow signposts to take advantage of deferred string substitution.

The Windows buildbot does not like signposts:

Mon, Jun 14, 6:20 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+.

This change is generating warnings when building with clang:

Mon, Jun 14, 9:56 AM · Restricted Project

Thu, Jun 10

stella.stamenova added a comment to D99696: [clang] NRVO: Improvements and handling of more cases..

It looks like this caused a couple of failures on the Windows LLDB bot due to crashes in clang:

Thu, Jun 10, 6:29 PM · Restricted Project
stella.stamenova committed rGca10add5dbe4: [lldb, win] Remove obsolete workaround for MSVC and python libs (authored by stella.stamenova).
[lldb, win] Remove obsolete workaround for MSVC and python libs
Thu, Jun 10, 11:14 AM
stella.stamenova closed D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs.
Thu, Jun 10, 11:14 AM · Restricted Project
stella.stamenova requested review of D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs.
Thu, Jun 10, 10:22 AM · Restricted Project

Tue, Jun 8

stella.stamenova added a comment to D103869: Add a static assertions for custom Op<> to not defined data members (NFC).

It looks like this is causing a build failure on the windows mlir buildbot which may be the goal since the assert is firing, but it would be nice to keep the buildbot green.

https://lab.llvm.org/buildbot/#/builders/13/builds/8726

FAILED: tools/mlir/lib/IR/CMakeFiles/obj.MLIRIR.dir/BuiltinDialect.cpp.obj 
C:\PROGRA~2\MICROS~3\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1 -DMLIR_ROCM_CONVERSIONS_ENABLED=1 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\mlir\lib\IR -IC:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\IR -Iinclude -IC:\buildbot\mlir-x64-windows-ninja\llvm-project\llvm\include -IC:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include -Itools\mlir\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Fotools\mlir\lib\IR\CMakeFiles\obj.MLIRIR.dir\BuiltinDialect.cpp.obj /Fdtools\mlir\lib\IR\CMakeFiles\obj.MLIRIR.dir\ /FS -c C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\IR\BuiltinDialect.cpp
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/IR/OpDefinition.h(1783): error C2338: Op class aren't allowed to have data members
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/IR/OpDefinition.h(1782): note: while compiling class template member function 'mlir::LogicalResult mlir::Op<mlir::UnrealizedConversionCastOp,mlir::OpTrait::ZeroRegion,mlir::OpTrait::VariadicResults,mlir::OpTrait::ZeroSuccessor,mlir::OpTrait::VariadicOperands,mlir::CastOpInterface::Trait,mlir::MemoryEffectOpInterface::Trait>::verifyInvariants(mlir::Operation *)'
Tue, Jun 8, 6:51 PM · Restricted Project
stella.stamenova added a comment to D103869: Add a static assertions for custom Op<> to not defined data members (NFC).

It looks like this is causing a build failure on the windows mlir buildbot which may be the goal since the assert is firing, but it would be nice to keep the buildbot green.

Tue, Jun 8, 6:48 PM · Restricted Project

Wed, Jun 2

stella.stamenova added a comment to D103394: [mlir][linalg] Update Structured Op Interface (NFC)..

(fixed the warning in 8c948b18e9d8 by the way)

Wed, Jun 2, 10:39 AM · Restricted Project
stella.stamenova added a comment to D103394: [mlir][linalg] Update Structured Op Interface (NFC)..

Changing the return type of a function is not generally considered a NFC.

It is from the point of view of the compiler: it won't affect its behavior in any way.
A good litmus test is: "do we need a test for this patch?" ; if not then it is likely NFC.

Wed, Jun 2, 10:39 AM · Restricted Project
stella.stamenova added inline comments to D103450: [mlir][linalg] Cleanup LinalgOp usage in promotion..
Wed, Jun 2, 10:17 AM · Restricted Project
stella.stamenova added inline comments to D103450: [mlir][linalg] Cleanup LinalgOp usage in promotion..
Wed, Jun 2, 9:58 AM · Restricted Project
stella.stamenova added a comment to D103450: [mlir][linalg] Cleanup LinalgOp usage in promotion..

I would not consider this an NFC and I think the title should be updated to not include the NFC designation. It might not be changing the intended functionality, but it is changing the logic (and functions called) to achieve the result.

Wed, Jun 2, 9:57 AM · Restricted Project
stella.stamenova added inline comments to D103450: [mlir][linalg] Cleanup LinalgOp usage in promotion..
Wed, Jun 2, 9:48 AM · Restricted Project
stella.stamenova added a comment to D103394: [mlir][linalg] Update Structured Op Interface (NFC)..

This change is causing the following warning when building with clang:

Wed, Jun 2, 9:31 AM · Restricted Project

May 19 2021

stella.stamenova added a comment to D100672: [ADT] Add new type traits for type pack indexes.

I'm not sure what to make of it now, and I'm not particularly familiar with Windows or MSVC. I'm still amenable to changing the code, but I also fear the changes I made won't actually fix the issue as I am only testing on godbolt. Is there any shortcut to testing with the Windows buildbots? Or do I have to install Windows somewhere and try to reproduce it?

May 19 2021, 2:40 PM · Restricted Project
stella.stamenova added a comment to D100672: [ADT] Add new type traits for type pack indexes.

@dblaikie @scott.linder I updated VS on both the mlir and lldb windows buildbots (from 15.9.30 to 15.9.36), but this update does not have an update to the compiler and indeed the compiler version was already `Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27045```. You can see from the logs of the broken builds as well:

May 19 2021, 9:19 AM · Restricted Project
stella.stamenova added a comment to D100672: [ADT] Add new type traits for type pack indexes.

This seems like a bug in parameter pack expansion in older versions of MSVC, compare 19.10 https://godbolt.org/z/TMd3K8WoK with 19.14 https://godbolt.org/z/9c9TT8bnb

@stella.stamenova is there any possibility the build bots could be updated to the latest MSVC 2017 update? https://llvm.org/docs/GettingStartedVS.html#software says "Visual Studio 2017 or higher, with the latest Update installed", but I could also see us wanting to support any VS 2017 release if possible.

If we want to support all updates of VS 2017 I can just substitute in the old definition of llvm::TypeIndex in place of the new llvm::FirstIndexOfType, but I might have to think more about how to work around this in llvm::TypesAreDistinct

I'd generally be happy to stick with the original requirement. @stella.stamenova - any chance you could update the bot(s) here?

May 19 2021, 8:44 AM · Restricted Project

May 17 2021

stella.stamenova added a reverting change for rGa6d3987b8ef3: [ADT] Add new type traits for type pack indexes: rG2d1f2ba7d516: Revert "[ADT] Add new type traits for type pack indexes".
May 17 2021, 8:27 PM
stella.stamenova committed rG2d1f2ba7d516: Revert "[ADT] Add new type traits for type pack indexes" (authored by stella.stamenova).
Revert "[ADT] Add new type traits for type pack indexes"
May 17 2021, 8:27 PM
stella.stamenova added a reverting change for D100672: [ADT] Add new type traits for type pack indexes: rG2d1f2ba7d516: Revert "[ADT] Add new type traits for type pack indexes".
May 17 2021, 8:27 PM · Restricted Project
stella.stamenova added a comment to D100672: [ADT] Add new type traits for type pack indexes.

This broke some windows bots:

May 17 2021, 4:15 PM · Restricted Project

May 14 2021

stella.stamenova committed rG0816b96a10b8: Allow same memory space for SRC and DST of dma_start operations (authored by manbearian).
Allow same memory space for SRC and DST of dma_start operations
May 14 2021, 10:41 AM
stella.stamenova closed D102274: Allow same memory space for SRC and DST of dma_start operations.
May 14 2021, 10:41 AM · Restricted Project

May 11 2021

stella.stamenova added a comment to D102208: Remove Windows editline from LLDB.

I don't have context into this either. Does this cause any test failures or is everything still green after the change?

May 11 2021, 11:13 AM · Restricted Project, Restricted Project

May 10 2021

stella.stamenova accepted D102189: [mlir] Fix windows build bot break due to use of `alloca` in a test..

LGTM.

May 10 2021, 1:37 PM · Restricted Project

May 7 2021

stella.stamenova added inline comments to D102034: [mlir][vector] add pattern to cast away leading unit dim for elementwise op.
May 7 2021, 4:53 PM · Restricted Project

Apr 30 2021

stella.stamenova added inline comments to D101304: AMDGPU/llvm-readobj: Add missing tests for note parsing/displaying.
Apr 30 2021, 9:56 AM · Restricted Project

Apr 27 2021

stella.stamenova added a comment to D101333: Also display the underlying error message when displaying a fixit.

It looks like this broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6085

Apr 27 2021, 1:54 PM · Restricted Project

Apr 26 2021

stella.stamenova added a comment to D100977: [lldb] Use forward type in pointer-to-member.

Looks like this is failing on the Windows LLDB bot:

Apr 26 2021, 9:13 AM · Restricted Project

Apr 16 2021

stella.stamenova added a reverting change for rG6580d8a2b14d: [Support] Don't include <algorithm> in MathExtras.h: rGaf2a93fd6e9f: Revert "[Support] Don't include <algorithm> in MathExtras.h".
Apr 16 2021, 10:23 AM
stella.stamenova committed rGaf2a93fd6e9f: Revert "[Support] Don't include <algorithm> in MathExtras.h" (authored by stella.stamenova).
Revert "[Support] Don't include <algorithm> in MathExtras.h"
Apr 16 2021, 10:22 AM
stella.stamenova added a reverting change for D100656: [Support] Don't include <algorithm> in MathExtras.h: rGaf2a93fd6e9f: Revert "[Support] Don't include <algorithm> in MathExtras.h".
Apr 16 2021, 10:22 AM · Restricted Project
stella.stamenova added a comment to D100656: [Support] Don't include <algorithm> in MathExtras.h.

This broke several windows bots, for example the MLIR one:

Apr 16 2021, 9:23 AM · Restricted Project

Apr 15 2021

stella.stamenova added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

This broke the windows LLDB bot. Please fix it soon or revert.

Apr 15 2021, 5:12 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2021

stella.stamenova committed rGbcef28621a87: Fix resolution-err.ll (authored by stella.stamenova).
Fix resolution-err.ll
Apr 13 2021, 4:13 PM
stella.stamenova closed D100417: Fix resolution-err.ll.
Apr 13 2021, 4:13 PM · Restricted Project
stella.stamenova requested review of D100417: Fix resolution-err.ll.
Apr 13 2021, 3:27 PM · Restricted Project
stella.stamenova added a comment to D99822: [lld-macho] Add support for arm64_32.

It looks like this broke the Windows LLDB bot (which also builds lld):

Apr 13 2021, 9:26 AM · Restricted Project, Restricted Project

Apr 6 2021

stella.stamenova updated subscribers of D99694: Add support for getting signed ObjC tagged pointer values.

It looks like @teemperor fixed it already!

Apr 6 2021, 9:46 AM · Restricted Project
stella.stamenova added a comment to D99694: Add support for getting signed ObjC tagged pointer values.

The latest change (commit be0ced03) issues the following warning:

Apr 6 2021, 9:42 AM · Restricted Project

Apr 1 2021

stella.stamenova committed rG802c5ce364a2: [lldb] Un-XFAIL TestAutoInstallMainExecutable on Windows (authored by stella.stamenova).
[lldb] Un-XFAIL TestAutoInstallMainExecutable on Windows
Apr 1 2021, 8:47 AM

Mar 30 2021

stella.stamenova added a comment to D98482: [lldb] [server] Support for multiprocess extension.

Looks like this broke the Windows lldb buildbot:

Mar 30 2021, 9:28 AM · Restricted Project

Mar 29 2021

stella.stamenova added a reverting change for rGbd56e91fdbc6: Add missing dependency to fix building the jit tests: rG54ab62e8ea0b: Revert "Add missing dependency to fix building the jit tests".
Mar 29 2021, 8:08 PM
stella.stamenova committed rG54ab62e8ea0b: Revert "Add missing dependency to fix building the jit tests" (authored by stella.stamenova).
Revert "Add missing dependency to fix building the jit tests"
Mar 29 2021, 8:08 PM

Mar 26 2021

stella.stamenova added inline comments to D99166: [mlir] Support MemRefType with multiple AffineMaps in getStridesAndOffset.
Mar 26 2021, 8:56 AM · Restricted Project

Mar 25 2021

stella.stamenova added inline comments to D98468: Define a `NoTerminator` traits that allows operations with a single block region to not provide a terminator.
Mar 25 2021, 10:48 AM · Restricted Project
stella.stamenova accepted D99329: Revert "[Canonicalizer] Process regions top-down instead of bottom up & reuse existing constants.".

Sounds like a plan. I'm not looking forward to having to undo and then redo all the necessary changes on our end, but we will have the opportunity to do them better with a little more heads up next time.

Mar 25 2021, 8:44 AM · Restricted Project

Mar 24 2021

stella.stamenova added inline comments to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.
Mar 24 2021, 6:58 PM · Restricted Project
stella.stamenova added a comment to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.

The tests are failing because Dave's bot is running without enabled Python. The same is true for the Windows bot. Putting the plugin behind #ifdef LLDB_ENABLE_PYTHON should fix this.

Mar 24 2021, 1:45 PM · Restricted Project
stella.stamenova committed rGf6e0fc2ddd8e: [mlir] Fix tile-and-distribute.mlir (authored by stella.stamenova).
[mlir] Fix tile-and-distribute.mlir
Mar 24 2021, 1:42 PM
stella.stamenova added inline comments to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.
Mar 24 2021, 1:31 PM · Restricted Project

Mar 23 2021

stella.stamenova added a comment to D99059: [mlir] Add an option to still use bottom-up traversal.

This switch to top down traversal also impacts onnx-mlir which has passes that do not currently work correctly with top down traversal (but do work with bottom up). I realize it's hard to keep track of all possible users, but I think it makes a lot of sense to make such changes optional for a time until the downstream components can adjust without breaking.

Mar 23 2021, 2:28 PM · Restricted Project

Mar 19 2021

stella.stamenova added a comment to D98842: [lldb] Make the api, shell and unit tests independent lit test suites.

This did end up breaking the windows build bot...

Mar 19 2021, 5:02 PM · Restricted Project

Mar 18 2021

stella.stamenova added a comment to D98842: [lldb] Make the api, shell and unit tests independent lit test suites.

Just gonna post a comment to point out that this apparently adds all tests twice to check-all which makes the tests go kaputt (but I only messaged Jonas directly about that, hence the lack of detailed errors here).

Mar 18 2021, 9:53 AM · Restricted Project
stella.stamenova accepted D98842: [lldb] Make the api, shell and unit tests independent lit test suites.

Looks good as long as it doesn't break windows :O

Mar 18 2021, 9:46 AM · Restricted Project

Mar 17 2021

stella.stamenova added a comment to D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic.

This broke the windows bot:

Mar 17 2021, 11:03 AM · Restricted Project

Mar 16 2021

stella.stamenova updated subscribers of D95722: [mlir][PDL] Add support for variadic operands and results in the PDL Interpreter.

It looks like this is failing on Windows MLIR bot:

Mar 16 2021, 2:41 PM · Restricted Project

Mar 3 2021

stella.stamenova accepted D97851: [mlir][linalg] Delete unused vars if there are shaped-only operands..
Mar 3 2021, 9:03 AM · Restricted Project

Mar 1 2021

stella.stamenova added a comment to D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess.
In D95711#2595566, @mib wrote:

This does not build on the Windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/4214

Should be fixed with 5a9c34918bb1526b7e8c29aa5e4fb8d8e27e27b4 ... I'm also investigating some test failures that are happening on Linux, that will also probably happen on Windows. I should have a fix for that soon.

Mar 1 2021, 2:42 PM · Restricted Project
stella.stamenova abandoned D97584: [llvm] Mark Transforms/Attributor/ArgumentPromotion/crash.ll as unsupported on Windows.
Mar 1 2021, 2:12 PM · Restricted Project
stella.stamenova added a comment to D97584: [llvm] Mark Transforms/Attributor/ArgumentPromotion/crash.ll as unsupported on Windows.

LG, could you check if this is necessary after D97238 ?

Mar 1 2021, 2:12 PM · Restricted Project
stella.stamenova committed rG801067f4c09b: [mlir][lldb] Fix several gcc warnings in mlir and lldb (authored by stella.stamenova).
[mlir][lldb] Fix several gcc warnings in mlir and lldb
Mar 1 2021, 1:50 PM
stella.stamenova closed D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb.
Mar 1 2021, 1:50 PM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb.
Mar 1 2021, 1:43 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess.

This does not build on the Windows bot:

Mar 1 2021, 1:21 PM · Restricted Project
stella.stamenova added a comment to D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.

What is the actual test requirement?

It requires x86_64 (it is incompatible with x86_32) and hopefully it is OS-agnostic (after fixing the %clang_host).

Mar 1 2021, 12:32 PM · Restricted Project
stella.stamenova added a comment to D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.

Considering this broke two bots, you might want to commit a fix or revert soon.

Mar 1 2021, 11:43 AM · Restricted Project
stella.stamenova added a comment to D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014.

@stella.stamenova It failed on a Windows box:
https://lab.llvm.org/buildbot/#/builders/83/builds/4202

$ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" "--target=specify-a-target-or-use-a-_host-substitution" "-o" "C:\buildbot\lldb-x64-windows-ninja\build\tools\lldb\test\SymbolFile\DWARF\Output\DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s.tmp" "--target=x86_64-pc-linux" "C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s" "C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\test\Shell\SymbolFile\DWARF/Inputs/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu2.s"
# command stderr:
clang: error: unable to execute command: program not executable

Do you think the following change would fix it?

-// RUN: %clang -o %t --target=x86_64-pc-linux %s \
+// RUN: %clang_host -o %t %s \
Mar 1 2021, 11:33 AM · Restricted Project

Feb 26 2021

stella.stamenova requested review of D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb.
Feb 26 2021, 2:58 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D97584: [llvm] Mark Transforms/Attributor/ArgumentPromotion/crash.ll as unsupported on Windows.
Feb 26 2021, 2:53 PM · Restricted Project

Feb 19 2021

stella.stamenova added a reverting change for rGae15b1e7ad71: Fix MLIR Toy tutorial JIT example and add a test to cover it: rGf36060417ad3: Revert "Fix MLIR Toy tutorial JIT example and add a test to cover it".
Feb 19 2021, 1:39 PM
stella.stamenova committed rGf36060417ad3: Revert "Fix MLIR Toy tutorial JIT example and add a test to cover it" (authored by stella.stamenova).
Revert "Fix MLIR Toy tutorial JIT example and add a test to cover it"
Feb 19 2021, 1:39 PM

Feb 17 2021

stella.stamenova accepted D96779: [lldb] Fix shared library directory computation on windows.

LGTM.

Feb 17 2021, 8:47 AM · Restricted Project

Feb 11 2021

stella.stamenova added inline comments to D93951: [vscode] Improve runInTerminal and support linux.
Feb 11 2021, 12:22 PM · Restricted Project
stella.stamenova committed rGed98676fa483: Support multi-configuration generators correctly in several config files (authored by stella.stamenova).
Support multi-configuration generators correctly in several config files
Feb 11 2021, 9:32 AM
stella.stamenova closed D96427: Support multi-configuration generators correctly in several config files.
Feb 11 2021, 9:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stella.stamenova updated the diff for D96427: Support multi-configuration generators correctly in several config files.
Feb 11 2021, 9:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stella.stamenova added a comment to D96202: [lldb/test] Automatically find debug servers to test.

It looks like this change resulted in a failing test on the Windows LLDB bot:

Feb 11 2021, 9:23 AM · Restricted Project

Feb 10 2021

stella.stamenova requested review of D96427: Support multi-configuration generators correctly in several config files.
Feb 10 2021, 9:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 9 2021

stella.stamenova added a comment to D96326: [mlir] add support for verification in integration tests.

To be clear, the windows mlir buildbot is broken because of this change:

Feb 9 2021, 10:12 AM · Restricted Project

Feb 8 2021

stella.stamenova accepted D96260: [lldb/test] Test lldb-server named pipe functionality on windows.
Feb 8 2021, 8:56 AM · Restricted Project

Feb 4 2021

stella.stamenova accepted D95261: [lldb/test] Reduce API test tools configuration boilerplate.
Feb 4 2021, 9:02 AM · Restricted Project
stella.stamenova accepted D96034: [lldb/cmake] Reduce duplication in generation lldb-dotest.
Feb 4 2021, 9:01 AM · Restricted Project

Feb 2 2021

stella.stamenova added a comment to D95386: Fix namespace for MLIR Async Runtime.

It looks like this broke the windows mlir bot. Please revert it or fix it ASAP:

Feb 2 2021, 12:43 PM · Restricted Project

Jan 27 2021

stella.stamenova added a comment to rGab5591e1d8f5: Fix runInTerminal failures on Windows.

This worked almost, but not quite. It seems you did not fully update RunInTerminal.cpp.

Jan 27 2021, 3:08 PM
stella.stamenova added inline comments to rGab5591e1d8f5: Fix runInTerminal failures on Windows.
Jan 27 2021, 1:22 PM
stella.stamenova added inline comments to D93951: [vscode] Improve runInTerminal and support linux.
Jan 27 2021, 11:41 AM · Restricted Project