Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (88 w, 4 d)

Recent Activity

Fri, Oct 18

stella.stamenova added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Oh, and TestCallOverridenMethod still has some failures on Windows:

Fri, Oct 18, 12:12 PM · Restricted Project
stella.stamenova added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Yeah, seems like constructing objects in expressions isn't implemented on Windows. I'm not sure if there is a reliable way to test that constructors aren't shadowed by these global functions if constructors themselves don't work on Windows, but I filed llvm.org/pr43707 for the underlying bug and x-failed the tests. Will push in a few minutes.

Fri, Oct 18, 10:21 AM · Restricted Project

Thu, Oct 17

stella.stamenova added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Unfortunately, this is failing on the windows bot:

Thu, Oct 17, 1:13 PM · Restricted Project
stella.stamenova requested changes to D69114: Disable TestProcessList on windows.

Please also file a bug and reference it in the skip statement.

Thu, Oct 17, 9:46 AM · Restricted Project
stella.stamenova accepted D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests.

The tests passed in my setup. After you commit this, please monitor the windows Buildbot (it currently has a couple of failures, so you will have to check it and not rely on an email).

Thu, Oct 17, 9:37 AM · Restricted Project
stella.stamenova added a comment to D68293: [android/process list] support showing process arguments.

This is causing a failure on the Windows Bot:

Thu, Oct 17, 9:18 AM · Restricted Project

Wed, Oct 16

stella.stamenova added inline comments to D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests.
Wed, Oct 16, 11:05 AM · Restricted Project

Tue, Oct 15

stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

The two things that come to mind are the path to clang-cl (which is sometimes a clang build and sometimes installed on the system as part of a VS installation or an LLVM installation) as well as the path to the linker when it is needed. This is most often an issue in the case of a VS install - I don't remember all the details any more, but I believe that before Zach added the script, we were often picking up the wrong clang-cl and ending up not being able to compile the tests at all.

Thanks.

Was this during a standalone lldb build? In a non-standalone build, lit should definitely prefer the just-built clang/lld (and if it doesn't, it should be fixed to do that). The situation is more complicated for a standalone build because the clang binary is sort of out of our control. But, in this case, I don't see how having build.py around can help, because the information about which clang to use has to come externally anyway...

How do tests like test/Shell/Register/x86*.test work in such standalone builds then? They use lines like these:

# XFAIL: system-windows
# REQUIRES: native && target-x86_64
# RUN: %clangxx -fomit-frame-pointer %p/Inputs/x86-64-gp-read.cpp -o %t
# RUN: %lldb -b -s %s %t | FileCheck %s

(The XFAIL for system-windows, at least in this test, when I tried it out, seemed to relate to the fact that register read --all on windows didn't include all the 32 bit subregisters.)

If tests already can use such constrcuts, I don't see why we couldn't use # RUN: %clang_cl .., as lit sets up %clang_cl in the same way as %clangxx.

Tue, Oct 15, 1:00 PM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

Both. Again, it's been a long time, but when we use VS for building, the environment already contains a path to clang-cl so regardless of whether the build is standalone or not, the build gets confused about which clang-cl to use. @mstorsjo might want to update the tests to use clang-cl but then make sure that the update works on the Windows Buildbot (or similar environment) before committing.

Is there any way of checking whether it works on this buildbot, other than committing (after doing best effort testing of it in whatever comparable windows environments I have available)?

Tue, Oct 15, 1:00 PM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

The two things that come to mind are the path to clang-cl (which is sometimes a clang build and sometimes installed on the system as part of a VS installation or an LLVM installation) as well as the path to the linker when it is needed. This is most often an issue in the case of a VS install - I don't remember all the details any more, but I believe that before Zach added the script, we were often picking up the wrong clang-cl and ending up not being able to compile the tests at all.

Thanks.

Was this during a standalone lldb build? In a non-standalone build, lit should definitely prefer the just-built clang/lld (and if it doesn't, it should be fixed to do that). The situation is more complicated for a standalone build because the clang binary is sort of out of our control. But, in this case, I don't see how having build.py around can help, because the information about which clang to use has to come externally anyway...

Tue, Oct 15, 11:45 AM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

I suspect that using clang-cl directly will not work though - the script does a lot of the setup needed to run clang-cl correctly today (previously the environment for clang-cl was not setup correctly and the tests either didn't pass or passed for the wrong reasons, so using build.py has been a huge improvement).

Can you elaborate on what kind of setup do you have in mind here? Bear in mind that here we are only talking about tests that do not use any system libraries or headers, and which already run fine on a linux system which does not have any windows-specific stuff installed. With those restrictions, I don't see what can be possibly gained from using build.py. The only thing I can see it possibly doing is to clear some environment variables which might otherwise be present and confuse clang-cl. However, that's something that can be easily done in lit.

Tue, Oct 15, 11:08 AM · Restricted Project
stella.stamenova added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

I haven't fully debugged this, but it looks like this change caused a failure on the Windows LLDB bot. There was already another failure, so you probably didn't get an email:

Tue, Oct 15, 10:58 AM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

This change looks fine assuming all the tests continue to pass.

Tue, Oct 15, 10:48 AM · Restricted Project

Mon, Oct 14

stella.stamenova accepted D68951: Fix test breakage caused by r374424.
Mon, Oct 14, 11:49 AM · Restricted Project
stella.stamenova added a comment to D68738: update TestRunCommandInterpreterAPI to use SBFile.

This is still failing on the Windows bot. Please fix it ASAP or revert it.

Mon, Oct 14, 9:20 AM · Restricted Project
stella.stamenova added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

It looks like this changed fixed at least one of the XFAILed tests on Windows:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9751

So now the test results would be red because of the unexpectedly passing test (if there wasn't another failure). Could you have a look at whether any of the other tests that were XFAILed for the same bug are also now passing and remove the expected failure tags as appropriate?

Mon, Oct 14, 9:20 AM · Restricted Project, Restricted Project

Fri, Oct 11

stella.stamenova added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

It looks like this changed fixed at least one of the XFAILed tests on Windows:

Fri, Oct 11, 12:51 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D68738: update TestRunCommandInterpreterAPI to use SBFile.

This is failing on the windows bot. There was already another failure, so you probably didn't get an email:

Fri, Oct 11, 9:37 AM · Restricted Project

Tue, Oct 8

stella.stamenova added a comment to D67520: Add pretty printing of Clang "bitfield" enums.

It looks like this broke one of the tests on the Windows LLDB bot:

Tue, Oct 8, 9:47 AM · Restricted Project
stella.stamenova accepted D68613: [CMake] Fix building without python on Windows.
Tue, Oct 8, 9:13 AM · Restricted Project

Mon, Oct 7

stella.stamenova added a comment to D68354: [platform process list] add a flag for showing the processes of all users.

The windows LLDB bot also has the same failure: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9600

Mon, Oct 7, 4:12 PM · Restricted Project

Wed, Oct 2

stella.stamenova added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

Thanks for taking care of this!

Wed, Oct 2, 6:12 PM · Restricted Project
stella.stamenova added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

This broke the windows build: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot. There was already a test broken from earlier today, so you might not have gotten an email.

Wed, Oct 2, 3:05 PM · Restricted Project

Mon, Sep 30

stella.stamenova added a comment to D68171: Remove unused "append" parameter from FindTypes API.

This broke the windows bot. A couple of other issues have shown up and been fixed since, but this change is still causing a break:

Mon, Sep 30, 8:04 PM · Restricted Project

Mon, Sep 23

stella.stamenova committed rG1962122c4d55: [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows (authored by stella.stamenova).
[lldb-suite] TestCallOverriddenMethod.py is now passing on Windows
Mon, Sep 23, 10:56 AM
stella.stamenova committed rL372634: [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows.
[lldb-suite] TestCallOverriddenMethod.py is now passing on Windows
Mon, Sep 23, 10:50 AM

Sep 11 2019

stella.stamenova added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

This broke the windows bot:

Sep 11 2019, 5:48 AM · Restricted Project, Restricted Project
stella.stamenova accepted D66574: [lit] Make internal diff work in pipelines.

LGTM as long as all the tests still pass

Sep 11 2019, 5:36 AM · Restricted Project

Aug 30 2019

stella.stamenova added a comment to D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.

Is there a way to reduce some of the code duplication? The more duplication there is, the harder it is to maintain.

Aug 30 2019, 11:27 AM · Restricted Project, Restricted Project

Aug 22 2019

stella.stamenova added a comment to D66546: Extend FindTypes w/ CompilerContext to allow filtering by language.

It looks like this broke the windows build bot:

Aug 22 2019, 1:26 PM · Restricted Project

Aug 20 2019

stella.stamenova accepted D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC).

LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though.

Aug 20 2019, 2:51 PM · Restricted Project, Restricted Project
stella.stamenova accepted D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.

I think this is actually fine. The change that was needed for multi-configuration generators is how the two default paths for the compilers are set. The USE variables were to make it explicit when we will or we won't override the user-set compiler. As long as we are OK overriding it if they set it to an empty string (which is probably an error, anyway), this change is good.

Aug 20 2019, 10:40 AM · Restricted Project, Restricted Project
stella.stamenova accepted D66482: [lit] Diagnose insufficient args to internal env.

LGTM

Aug 20 2019, 10:27 AM · Restricted Project

Aug 15 2019

stella.stamenova added a comment to D66224: MemoryBuffer: Add a missing error-check to getOpenFileImpl.

It looks like this changed caused 30 or so of the tests to fail on the Windows bot. It was already broken, so you wouldn't have gotten an email:

Aug 15 2019, 8:23 AM · Restricted Project

Aug 12 2019

stella.stamenova committed rG532e72499239: Revert "[lldb] Refactor guard variable checks in IRForTarget" (authored by stella.stamenova).
Revert "[lldb] Refactor guard variable checks in IRForTarget"
Aug 12 2019, 1:11 PM
stella.stamenova added a reverting change for rG94fbbf712e90: [lldb] Refactor guard variable checks in IRForTarget: rG532e72499239: Revert "[lldb] Refactor guard variable checks in IRForTarget".
Aug 12 2019, 1:11 PM
stella.stamenova committed rGe7daf78e05d2: Revert "[lldb] Fix dynamic_cast by no longer failing on variable without… (authored by stella.stamenova).
Revert "[lldb] Fix dynamic_cast by no longer failing on variable without…
Aug 12 2019, 1:11 PM
stella.stamenova added a reverting change for rGb448d1bf2122: [lldb] Fix dynamic_cast by no longer failing on variable without metadata: rGe7daf78e05d2: Revert "[lldb] Fix dynamic_cast by no longer failing on variable without….
Aug 12 2019, 1:11 PM
stella.stamenova committed rL368616: Revert "[lldb] Refactor guard variable checks in IRForTarget".
Revert "[lldb] Refactor guard variable checks in IRForTarget"
Aug 12 2019, 1:10 PM
stella.stamenova committed rL368615: Revert "[lldb] Fix dynamic_cast by no longer failing on variable without….
Revert "[lldb] Fix dynamic_cast by no longer failing on variable without…
Aug 12 2019, 1:10 PM
stella.stamenova added a comment to D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.

This change caused failures on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7681 compounding on the existing failures from [lldb] Refactor guard variable checks in IRForTarget

Aug 12 2019, 11:20 AM · Restricted Project, Restricted Project

Aug 8 2019

stella.stamenova added inline comments to D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option.
Aug 8 2019, 10:13 AM · Restricted Project

Aug 5 2019

stella.stamenova added a comment to D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC.

The windows bot for LLDB is still broken after the partial fix for the breakage:

Aug 5 2019, 2:25 PM · Restricted Project

Aug 2 2019

stella.stamenova committed rGdf1b00a7cb16: [lit] Fix 42812: lit test suite can no longer be run stand-alone (authored by stella.stamenova).
[lit] Fix 42812: lit test suite can no longer be run stand-alone
Aug 2 2019, 3:04 PM
stella.stamenova committed rL367730: [lit] Fix 42812: lit test suite can no longer be run stand-alone.
[lit] Fix 42812: lit test suite can no longer be run stand-alone
Aug 2 2019, 3:02 PM
stella.stamenova closed D65674: [lit] Fix 42812: lit test suite can no longer be run stand-alone.
Aug 2 2019, 3:02 PM · Restricted Project
stella.stamenova added a comment to D65674: [lit] Fix 42812: lit test suite can no longer be run stand-alone.

@mgorny Could you download the patch and see if it fixes your scenario? I tested it on both Ubuntu and Linux, but neither installation of LLVM I have actually contains FileCheck or not, so my setup is not entirely the same as yours.

Aug 2 2019, 1:30 PM · Restricted Project
stella.stamenova created D65674: [lit] Fix 42812: lit test suite can no longer be run stand-alone.
Aug 2 2019, 1:29 PM · Restricted Project
stella.stamenova accepted D65624: [lit] Print internal env commands.
Aug 2 2019, 9:49 AM · Restricted Project
stella.stamenova accepted D65623: [lit] Actually run tests for internal env command.
Aug 2 2019, 9:49 AM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

Yes, it was! Thanks for catching that :)

Aug 2 2019, 9:46 AM · Restricted Project

Aug 1 2019

Herald added a project to D55571: [ast] CreateParameterDeclaration should use an appropriate DeclContext.: Restricted Project.

Test passes now. Thanks!

Aug 1 2019, 3:25 PM · Restricted Project

Jul 31 2019

stella.stamenova accepted D65546: Fix TestThreadSpecificBreakpoint on Windows.

LGTM. Please keep an eye on the bot after you commit though

Jul 31 2019, 3:56 PM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

I am able to do some testing as well.

Jul 31 2019, 10:07 AM · Restricted Project
stella.stamenova added a comment to D65156: [lit] Protect full test suite from FILECHECK_OPTS.

HERE: useExternalSh: False

Jul 31 2019, 10:03 AM · Restricted Project

Jul 30 2019

stella.stamenova added a comment to D65156: [lit] Protect full test suite from FILECHECK_OPTS.

This actually breaks the lit tests on Windows when the path to Python has spaces. For example:

Jul 30 2019, 11:22 AM · Restricted Project
stella.stamenova added a comment to D65335: [llvm] [lit/tests] Replace 'env -u' with more portable construct.

It is indeed https://reviews.llvm.org/D65156 which introduced the failure

Jul 30 2019, 11:22 AM · Restricted Project
stella.stamenova added a comment to D65335: [llvm] [lit/tests] Replace 'env -u' with more portable construct.

It could be either actually. I'll run the tests with just the first one and see if it reproduces. I *think* it's this one.

Jul 30 2019, 9:29 AM · Restricted Project

Jul 29 2019

stella.stamenova added a comment to D65335: [llvm] [lit/tests] Replace 'env -u' with more portable construct.

This actually breaks the lit tests on Windows when the path to Python has spaces. For example:

Jul 29 2019, 6:13 PM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

One failure:

Jul 29 2019, 6:12 PM · Restricted Project
stella.stamenova added a comment to D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl.

I'll run some tests and let you know the result.

Jul 29 2019, 4:01 PM · Restricted Project
stella.stamenova accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

I think you need one small change for lld still - to make it clear that it is required on Windows in the Windows section, but it looks good otherwise. Please fix that before committing.

Jul 29 2019, 10:23 AM · Restricted Project, Restricted Project

Jul 26 2019

stella.stamenova added inline comments to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 10:29 AM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 10:03 AM · Restricted Project, Restricted Project

Jul 17 2019

stella.stamenova added a comment to D64881: [Cmake] Use the modern way to find Python when possible.

Re: Windows CMake: I am not sure, I'd have to do look into it further.

Jul 17 2019, 2:31 PM · Restricted Project

Jul 16 2019

stella.stamenova accepted D64660: add a workaround in GetLine to account for ReadFile not reporintg error.

LGTM!

Jul 16 2019, 9:05 AM · Restricted Project

Jul 15 2019

stella.stamenova committed rG032e3c468fab: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build (authored by stella.stamenova).
[llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build
Jul 15 2019, 11:16 AM
stella.stamenova committed rL366097: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build.
[llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build
Jul 15 2019, 11:15 AM
stella.stamenova closed D64357: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build.
Jul 15 2019, 11:15 AM · Restricted Project
stella.stamenova accepted D64719: [zorg] [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout.
Jul 15 2019, 9:04 AM · Restricted Project, Restricted Project

Jul 9 2019

stella.stamenova added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

This broke the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/6493/steps/build/logs/stdio

Jul 9 2019, 1:11 PM · Restricted Project
stella.stamenova committed rG20ecec6116b3: [lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher (authored by stella.stamenova).
[lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher
Jul 9 2019, 11:43 AM
stella.stamenova committed rL365533: [lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher.
[lldb, windows] Include WindowsError instead of ErrorHandling in ThreadLauncher
Jul 9 2019, 11:41 AM
stella.stamenova committed rG2ea514c5662f: [lldb-suite] Skip TestMachCore on Windows (authored by stella.stamenova).
[lldb-suite] Skip TestMachCore on Windows
Jul 9 2019, 11:19 AM
stella.stamenova committed rL365527: [lldb-suite] Skip TestMachCore on Windows.
[lldb-suite] Skip TestMachCore on Windows
Jul 9 2019, 11:18 AM
stella.stamenova committed rG631b5f7dc0e9: [lldb, windows] Update two more locations that use LaunchThread to the new… (authored by stella.stamenova).
[lldb, windows] Update two more locations that use LaunchThread to the new…
Jul 9 2019, 11:12 AM
stella.stamenova committed rL365526: [lldb, windows] Update two more locations that use LaunchThread to the new….
[lldb, windows] Update two more locations that use LaunchThread to the new…
Jul 9 2019, 11:11 AM
stella.stamenova added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().

I am not sure if you've seen this yet, but this broke the Windows LLDB bot:

Jul 9 2019, 9:07 AM · Restricted Project

Jul 8 2019

stella.stamenova committed rG7f843e22bae2: [lldb, windows] When StartMonitoring fails, return a proper error (authored by stella.stamenova).
[lldb, windows] When StartMonitoring fails, return a proper error
Jul 8 2019, 3:10 PM
stella.stamenova committed rL365400: [lldb, windows] When StartMonitoring fails, return a proper error.
[lldb, windows] When StartMonitoring fails, return a proper error
Jul 8 2019, 3:10 PM
stella.stamenova committed rG05590baa071b: [lldb] Fix two more issues in Windows following rL365226: Change LaunchThread… (authored by stella.stamenova).
[lldb] Fix two more issues in Windows following rL365226: Change LaunchThread…
Jul 8 2019, 2:19 PM
stella.stamenova committed rL365388: [lldb] Fix two more issues in Windows following rL365226: Change LaunchThread….
[lldb] Fix two more issues in Windows following rL365226: Change LaunchThread…
Jul 8 2019, 2:18 PM
stella.stamenova committed rGed499a36b67c: Revert "Move common functionality from processwindows into processdebugger" (authored by stella.stamenova).
Revert "Move common functionality from processwindows into processdebugger"
Jul 8 2019, 11:56 AM
stella.stamenova added a reverting change for rG9c01eaff6aa3: Move common functionality from processwindows into processdebugger: rGed499a36b67c: Revert "Move common functionality from processwindows into processdebugger".
Jul 8 2019, 11:56 AM
stella.stamenova committed rL365371: Revert "Move common functionality from processwindows into processdebugger".
Revert "Move common functionality from processwindows into processdebugger"
Jul 8 2019, 11:53 AM
stella.stamenova created D64357: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build.
Jul 8 2019, 11:34 AM · Restricted Project

Jul 3 2019

stella.stamenova accepted D64154: [Docs] Unify build instructions .
Jul 3 2019, 1:34 PM · Restricted Project
stella.stamenova added inline comments to D64154: [Docs] Unify build instructions .
Jul 3 2019, 1:23 PM · Restricted Project

Jul 2 2019

stella.stamenova accepted D64046: [windows] re-call signal in sigint_handler for Windows.

LGTM. Have you run the tests to make sure they behave correctly after this change?

Jul 2 2019, 9:30 AM · Restricted Project

Jul 1 2019

stella.stamenova committed rG86e4d7ea35ee: [lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate (authored by stella.stamenova).
[lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate
Jul 1 2019, 3:15 PM
stella.stamenova committed rL364860: [lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate.
[lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate
Jul 1 2019, 3:13 PM
stella.stamenova committed rG55d2e6f1c26c: [lldb] [lldbsuite] Use a unique class name for TestBacktraceAll (authored by stella.stamenova).
[lldb] [lldbsuite] Use a unique class name for TestBacktraceAll
Jul 1 2019, 11:14 AM
stella.stamenova committed rL364826: [lldb] [lldbsuite] Use a unique class name for TestBacktraceAll.
[lldb] [lldbsuite] Use a unique class name for TestBacktraceAll
Jul 1 2019, 11:14 AM

Jun 21 2019

stella.stamenova accepted D63679: [lit] Make lit-lldb-init configurable by CMake.

LGTM.

Jun 21 2019, 4:04 PM · Restricted Project, Restricted Project

Jun 20 2019

stella.stamenova added a comment to D63110: Fix a crash in option parsing..

@stella.stamenova could you try running the lldb invocation manually like I did? I'm wondering if you're getting the same issue.

Jun 20 2019, 11:27 AM · Restricted Project, Restricted Project

Jun 18 2019

stella.stamenova added a comment to D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups.

Thanks!

Jun 18 2019, 8:45 AM · Restricted Project
stella.stamenova added a comment to D63110: Fix a crash in option parsing..

This test is extremely flaky on Windows - it looks like it passes on the bot less than 10% of the time: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot.

Jun 18 2019, 8:45 AM · Restricted Project, Restricted Project

Jun 17 2019

stella.stamenova added a comment to D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups.

It looks like this broke the Windows bot. I am no longer receiving emails when the bot fails (as bot owner I used to always get the failure emails), so I am assuming for some reason notifications aren't working correctly.

Jun 17 2019, 1:45 PM · Restricted Project

Jun 11 2019

stella.stamenova accepted D63102: Fix some lit test ResourceWarnings on Windows.

LGTM

Jun 11 2019, 9:18 AM · Restricted Project

Jun 4 2019

stella.stamenova accepted D62759: Fix lit tests on Windows related to CR.
Jun 4 2019, 3:46 PM · Restricted Project