Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (154 w, 6 d)

Recent Activity

Today

stella.stamenova added a comment to D93951: [vscode] Improve runInTerminal and support linux.

@stella.stamenova , is that build a Debug or Release build? I think that will help me determine why it's failing

Tue, Jan 26, 2:40 PM · Restricted Project
stella.stamenova added a comment to D93951: [vscode] Improve runInTerminal and support linux.

I am seeing this consistently fail on our internal Ubuntu bot:

Tue, Jan 26, 2:34 PM · Restricted Project
stella.stamenova added inline comments to D95008: Revert "Revert "Ignores functions that have a range starting outside of a code section"".
Tue, Jan 26, 9:44 AM · Restricted Project

Yesterday

stella.stamenova added a comment to D93951: [vscode] Improve runInTerminal and support linux.

It looks like this broke the windows lldb bot:

Mon, Jan 25, 2:18 PM · Restricted Project
stella.stamenova added inline comments to D95261: [lldb/test] Reduce API test tools configuration boilerplate.
Mon, Jan 25, 8:33 AM · Restricted Project

Fri, Jan 22

stella.stamenova added inline comments to D95261: [lldb/test] Reduce API test tools configuration boilerplate.
Fri, Jan 22, 1:04 PM · Restricted Project

Tue, Jan 19

stella.stamenova committed rG347145538443: [lldb/test] Skip TestProcessAttach: test_attach_to_process_from_different_dir_b… (authored by stella.stamenova).
[lldb/test] Skip TestProcessAttach: test_attach_to_process_from_different_dir_b…
Tue, Jan 19, 2:09 PM
stella.stamenova added a comment to D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load.

It looks like this broke the windows LLDB buildbot: http://lab.llvm.org:8011/#/builders/83/builds/2795

Tue, Jan 19, 10:34 AM · Restricted Project

Wed, Dec 30

stella.stamenova added a comment to D93924: [mlir] Add option to read reproducer options from file.

This broke the windows mlir bot. Please fix it or revert it:

Wed, Dec 30, 1:41 PM · Restricted Project

Dec 3 2020

stella.stamenova committed rG1410b72be321: [compiler-rt] Fix a bug in the cmakelists file when CMAKE_CXX_FLAGS are empty (authored by stella.stamenova).
[compiler-rt] Fix a bug in the cmakelists file when CMAKE_CXX_FLAGS are empty
Dec 3 2020, 10:27 AM
stella.stamenova closed D92586: [compiler-rt] Fix a bug in the cmakelists file when CMAKE_CXX_FLAGS are empty.
Dec 3 2020, 10:27 AM · Restricted Project
stella.stamenova added a reviewer for D92586: [compiler-rt] Fix a bug in the cmakelists file when CMAKE_CXX_FLAGS are empty: phosek.
Dec 3 2020, 10:18 AM · Restricted Project
stella.stamenova requested review of D92586: [compiler-rt] Fix a bug in the cmakelists file when CMAKE_CXX_FLAGS are empty.
Dec 3 2020, 10:17 AM · Restricted Project
stella.stamenova committed rG636db7f87c77: [MLIR] Fix vector::TransferWriteOp builder losing permutation map (authored by max-kudr).
[MLIR] Fix vector::TransferWriteOp builder losing permutation map
Dec 3 2020, 9:56 AM
stella.stamenova closed D92145: [MLIR] Fix vector::TransferWriteOp builder losing permutation map.
Dec 3 2020, 9:56 AM · Restricted Project, Restricted Project

Dec 2 2020

stella.stamenova added a comment to D92425: [lldb] Don't reject empty or unnamed template parameter packs.

This caused failures on the Windows lldb buildbot:

http://lab.llvm.org:8011/#/builders/83/builds/1294

Tests have to have unique names, so the two new added tests that use TestCase as the class name are both trying to write to the same log file and failing to do so.

Thanks, fixed.

FWIW, this (frankly silly) requirement is actually supposed to be fixed by D83767.

Dec 2 2020, 2:53 PM · Restricted Project
stella.stamenova added a comment to D92425: [lldb] Don't reject empty or unnamed template parameter packs.

This caused failures on the Windows lldb buildbot:

Dec 2 2020, 9:41 AM · Restricted Project

Dec 1 2020

stella.stamenova added inline comments to D88922: [CMake] Avoid accidental C++ standard library dependency in sanitizers.
Dec 1 2020, 3:35 PM · Restricted Project

Nov 20 2020

stella.stamenova committed rG370d0bac902d: [mlir] Expose parseDimAndSymbolList from affineops.h (authored by stella.stamenova).
[mlir] Expose parseDimAndSymbolList from affineops.h
Nov 20 2020, 9:27 AM
stella.stamenova closed D91830: [mlir] Expose parseDimAndSymbolList from affineops.h.
Nov 20 2020, 9:27 AM · Restricted Project

Nov 19 2020

stella.stamenova requested review of D91830: [mlir] Expose parseDimAndSymbolList from affineops.h.
Nov 19 2020, 4:23 PM · Restricted Project
stella.stamenova committed rG332710e70428: [mlir] Add a missing dependency to LinalgToLLVM (authored by stella.stamenova).
[mlir] Add a missing dependency to LinalgToLLVM
Nov 19 2020, 10:33 AM
stella.stamenova closed D91750: [mlir] Add a missing dependency to LinalgToLLVM.
Nov 19 2020, 10:33 AM · Restricted Project

Nov 18 2020

stella.stamenova requested review of D91750: [mlir] Add a missing dependency to LinalgToLLVM.
Nov 18 2020, 4:07 PM · Restricted Project

Nov 13 2020

stella.stamenova added a comment to D90589: [mlir] Use assemblyFormat in AllocLikeOp..

onnx-mlir (https://github.com/onnx/onnx-mlir) is currently using parseDimAndSymbolList. Is the intention for this function to not be available outside of mlir any more? I notice it no longer has any uses inside mlir either.

It's now private to AffineOps.cpp. Maybe the easiest would be to export it again from there. Would that work for onnx?

Nov 13 2020, 9:39 AM · Restricted Project

Nov 12 2020

stella.stamenova added a comment to D90589: [mlir] Use assemblyFormat in AllocLikeOp..

onnx-mlir (https://github.com/onnx/onnx-mlir) is currently using parseDimAndSymbolList. Is the intention for this function to not be available outside of mlir any more? I notice it no longer has any uses inside mlir either.

Nov 12 2020, 10:03 AM · Restricted Project

Nov 11 2020

stella.stamenova added a comment to D90490: [intel-pt][trace] Implement a "get supported trace type" packet.

It looks like this broke the windows lldb buildbot:

Nov 11 2020, 11:40 AM · Restricted Project
stella.stamenova added a reverting change for rGae3640e386cc: [ThreadPlan] Add a test for `thread step-in -r`, NFC: rGd9624f444807: Revert "[ThreadPlan] Add a test for `thread step-in -r`, NFC".
Nov 11 2020, 9:11 AM
stella.stamenova committed rGd9624f444807: Revert "[ThreadPlan] Add a test for `thread step-in -r`, NFC" (authored by stella.stamenova).
Revert "[ThreadPlan] Add a test for `thread step-in -r`, NFC"
Nov 11 2020, 9:11 AM
stella.stamenova added a reverting change for D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC: rGd9624f444807: Revert "[ThreadPlan] Add a test for `thread step-in -r`, NFC".
Nov 11 2020, 9:11 AM · Restricted Project

Nov 10 2020

stella.stamenova added a comment to D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC.

This test is failing on the Windows bot:

Nov 10 2020, 8:41 PM · Restricted Project

Nov 5 2020

stella.stamenova added a reverting change for rG71e108cd86e7: Allow searching for prebuilt implicit modules.: rGc67656b994c8: Revert "Allow searching for prebuilt implicit modules.".
Nov 5 2020, 5:18 PM
stella.stamenova committed rGc67656b994c8: Revert "Allow searching for prebuilt implicit modules." (authored by stella.stamenova).
Revert "Allow searching for prebuilt implicit modules."
Nov 5 2020, 5:18 PM
stella.stamenova added a reverting change for D68997: Allow searching for prebuilt implicit modules.: rGc67656b994c8: Revert "Allow searching for prebuilt implicit modules.".
Nov 5 2020, 5:18 PM · Restricted Project
stella.stamenova added a comment to D68997: Allow searching for prebuilt implicit modules..

This change broke the windows lldb bot:

Nov 5 2020, 3:36 PM · Restricted Project

Nov 2 2020

stella.stamenova added a comment to D90379: [MLIR] Support walks over regions and blocks.

@frgossen , Thanks! Let me know if you need any help investigating.

Nov 2 2020, 9:51 AM · Restricted Project
stella.stamenova added a comment to D89354: [mlir][ASM] Refactor how attribute/type aliases are specified..

I haven't had a chance to debug this yet, but we are seeing failures in the mlir tests on Windows Debug that appear to be caused by this change. The failures are:

Sorry about that. Should be fixed by 235dfcf70abca65dba5d80f1a42d1485bab8980c.

Nov 2 2020, 7:14 AM · Restricted Project
stella.stamenova added a comment to D90379: [MLIR] Support walks over regions and blocks.

Unfortunately, I could not reproduce this failure,
I tried with gcc/g++ (Debian 10.2.0-9) 10.2.0.

Nov 2 2020, 7:13 AM · Restricted Project

Oct 31 2020

stella.stamenova updated subscribers of D89354: [mlir][ASM] Refactor how attribute/type aliases are specified..
Oct 31 2020, 10:30 AM · Restricted Project
stella.stamenova added a comment to D89354: [mlir][ASM] Refactor how attribute/type aliases are specified..

I haven't had a chance to debug this yet, but we are seeing failures in the mlir tests on Windows Debug that appear to be caused by this change. The failures are:

Oct 31 2020, 10:29 AM · Restricted Project

Oct 30 2020

stella.stamenova updated subscribers of D90379: [MLIR] Support walks over regions and blocks.
Oct 30 2020, 1:54 PM · Restricted Project
stella.stamenova added a comment to D90379: [MLIR] Support walks over regions and blocks.

We are seeing a failure in the mlir build on Ubuntu with gcc/g++ since these two changes went in:

Oct 30 2020, 1:53 PM · Restricted Project

Oct 27 2020

stella.stamenova added a comment to D88977: Reapply [ADT] function_ref's constructor is unavailable if the argument is not callable..

Oh wow, I think those are different pointers to the same string, and MSVC+Debug is the only configuration that doesn't fold them together.

So this is just a dumb bug in the test. I just pushed 1a1aad9156407bc891e2738e9877c03bd594e67f which should fix it, please let me know if it doesn't!

Oct 27 2020, 6:39 PM · Restricted Project
stella.stamenova added a comment to D88977: Reapply [ADT] function_ref's constructor is unavailable if the argument is not callable..

No, not expected... can you provide more details?
Is this on a public LLVM buildbot I missed somehow?

Oct 27 2020, 9:58 AM · Restricted Project

Oct 26 2020

stella.stamenova added a comment to D89170: [AMDGPU] Use flat scratch instructions where available.

It looks like this broke the windows lldb bot:

Oct 26 2020, 3:43 PM · Restricted Project
stella.stamenova added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change?

Oct 26 2020, 2:49 PM · Restricted Project
stella.stamenova added a comment to D88977: Reapply [ADT] function_ref's constructor is unavailable if the argument is not callable..

The new test fails on Windows when we compile Debug (instead of Release). Is that expected?

Oct 26 2020, 1:18 PM · Restricted Project

Oct 14 2020

stella.stamenova added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

I ask because I'm still trying to figure out why 899 LLDB tests started failing for me on Friday. (Actually, it was 936 tests, but I fixed 37 of them with a fix to a line that was introduced almost a year ago. I have not idea why the problems just started appearing on the 9th.)

Oct 14 2020, 11:58 AM · Restricted Project
stella.stamenova abandoned D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.
Oct 14 2020, 11:18 AM · Restricted Project
stella.stamenova added a comment to D89124: [lldb-server][linux] Add ability to allocate memory.

It looks like this changed caused a failure on the windows bot and your follow up change to fix the test left it still broken. Can you have a look?

Oct 14 2020, 10:31 AM · Restricted Project

Oct 13 2020

stella.stamenova committed rG0c15a1b4bcef: [mlir] Fix sporadic build failures due to missing dependency (authored by stella.stamenova).
[mlir] Fix sporadic build failures due to missing dependency
Oct 13 2020, 9:55 AM
stella.stamenova closed D89275: [mlir] Fix sporadic build failures due to missing dependency.
Oct 13 2020, 9:55 AM · Restricted Project

Oct 12 2020

stella.stamenova updated the summary of D89275: [mlir] Fix sporadic build failures due to missing dependency.
Oct 12 2020, 2:58 PM · Restricted Project
stella.stamenova requested review of D89275: [mlir] Fix sporadic build failures due to missing dependency.
Oct 12 2020, 2:58 PM · Restricted Project

Oct 9 2020

stella.stamenova committed rG09dbdcf15fa3: [mlir, win] Mark several MLRI tests as unsupported on system-windows (authored by stella.stamenova).
[mlir, win] Mark several MLRI tests as unsupported on system-windows
Oct 9 2020, 4:29 PM
stella.stamenova closed D89169: [mlir, win] Mark several MLRI tests as unsupported on system-windows.
Oct 9 2020, 4:29 PM · Restricted Project
stella.stamenova requested review of D89169: [mlir, win] Mark several MLRI tests as unsupported on system-windows.
Oct 9 2020, 4:13 PM · Restricted Project
stella.stamenova added a comment to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.

@stella.stamenova Strangely, your initial bug description sounds like a deadlock initiated by tar_version.communicate() in https://github.com/llvm/llvm-project/blob/f7941d98091827b8d0b6fdabb731e38c99f44b13/lld/test/lit.cfg.py#L110
Are the lit tests using python 3.6 and not the 2.7 that you seem to have installed as well? In any case, I wonder if setting stderr=open(os.devnull) at lld/test/lit.cfg.py#L108, would fix the issue? Or perhaps just check the 'Threads' tab in Process Explorer on tar.exe, see why it is blocked.

It does, doesn't it! But it's not. If I manually kill tar.exe, then any of the tests that use the git tools time out and fail as well, because all of the tools hang similarly. I attached a debugger to tar.exe after it hung and it is getting an access violation when trying to call GetCommandLineA, so I ran the tests as a different user and they passed. It looks like the tools that come with git can't run successfully under an account that has restricted permissions while the tools that come with GnuWin32 can (also, any other tools we are using in the tests run just fine under the same restricted account, the git tools are the exception). This makes me question whether using the git tools by default is the right choice - the failure was not obvious and not easy to track down. Granted, it is not one that will likely happen on a developer machine, but anyone who is trying to set up automated testing on Windows might (and likely should) be using a restricted account. If we do decide to proceed with using the git tools by default, this should at least be documented and gnuwin32 should be an alternative. Thoughts?

Thanks for investigating! Isn't that related to access rights to the binaries, rather than an issue with the Git tools?

Oct 9 2020, 10:51 AM · Restricted Project

Oct 6 2020

stella.stamenova added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

It seems confusing to me to automagically use tools that are not on PATH (or passed in explicitly as cmake flags or similar).

Can't folks who want to use the git tools put them on their PATH?

After this patch I think it's surprising to users why the git tools are used when e.g. the gnuwin tools are the only ones available on PATH.

Oct 6 2020, 11:52 AM · Restricted Project
stella.stamenova added a comment to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.

@stella.stamenova Strangely, your initial bug description sounds like a deadlock initiated by tar_version.communicate() in https://github.com/llvm/llvm-project/blob/f7941d98091827b8d0b6fdabb731e38c99f44b13/lld/test/lit.cfg.py#L110
Are the lit tests using python 3.6 and not the 2.7 that you seem to have installed as well? In any case, I wonder if setting stderr=open(os.devnull) at lld/test/lit.cfg.py#L108, would fix the issue? Or perhaps just check the 'Threads' tab in Process Explorer on tar.exe, see why it is blocked.

Oct 6 2020, 11:48 AM · Restricted Project

Oct 5 2020

stella.stamenova added a comment to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.

I don't know whether Python and our config tools use the terms consistent, but Win32 is the name of the Windows API used on both 32- and 64-bit processors, Win16 was the API used on 16-bit machines, and Win64 is a made-up term that confuses the issues.

Oct 5 2020, 4:21 PM · Restricted Project
stella.stamenova added inline comments to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.
Oct 5 2020, 3:02 PM · Restricted Project
stella.stamenova added inline comments to D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.
Oct 5 2020, 2:17 PM · Restricted Project
stella.stamenova requested review of D88850: [lit, windows] Fix the search for git tools on Windows to check the path first.
Oct 5 2020, 1:27 PM · Restricted Project
stella.stamenova added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..
In D84380#2309853, @aganea wrote: Maybe if L28 wasn't there, things would work correctly if you already had the required tools in %PATH%? Would you possibly try that please?

I will try it. I'll let you know if it makes a difference.

Yes, that works. We don't end up prepending the lit path and the tests work as before.

For some context, L28 was added because the previous code made the underlying assumption that this variable was defined. Specifically, this:

path = self.lit_config.getToolsPath(lit_tools_dir, config.environment['PATH'], required_tools)

will raise an exception in the case that lit_tools_dir==None. It sounds like you're saying lit_tools_dir = [] in your case. If so, instead of removing this line, can it be changed to if lit_tools_dir != None:?

Oct 5 2020, 12:34 PM · Restricted Project

Oct 3 2020

stella.stamenova added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..
In D84380#2309853, @aganea wrote: Maybe if L28 wasn't there, things would work correctly if you already had the required tools in %PATH%? Would you possibly try that please?

I will try it. I'll let you know if it makes a difference.

Oct 3 2020, 8:37 PM · Restricted Project

Oct 2 2020

stella.stamenova added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..
In D84380#2309853, @aganea wrote: Maybe if L28 wasn't there, things would work correctly if you already had the required tools in %PATH%? Would you possibly try that please?

I will try it. I'll let you know if it makes a difference.

Oct 2 2020, 8:34 PM · Restricted Project
stella.stamenova added a comment to D84380: [lit] Support running tests on Windows without GnuWin32..

Since this was committed, all of our internal bots (but not the external windows bot!) are hanging when the tests run. I've looked into it some and I noticed a couple of things:

Oct 2 2020, 4:18 PM · Restricted Project
stella.stamenova added a reverting change for rG542523a61a21: [WebAssembly] Emulate v128.const efficiently: rG432e4e56d3d2: Revert "[WebAssembly] Emulate v128.const efficiently".
Oct 2 2020, 9:27 AM
stella.stamenova committed rG432e4e56d3d2: Revert "[WebAssembly] Emulate v128.const efficiently" (authored by stella.stamenova).
Revert "[WebAssembly] Emulate v128.const efficiently"
Oct 2 2020, 9:27 AM
stella.stamenova added a reverting change for D88591: [WebAssembly] Emulate v128.const efficiently: rG432e4e56d3d2: Revert "[WebAssembly] Emulate v128.const efficiently".
Oct 2 2020, 9:26 AM · Restricted Project

Sep 25 2020

stella.stamenova accepted D88229: Reland "[lldb] Don't send invalid region addresses to lldb server".

LGTM

Sep 25 2020, 9:31 AM · Restricted Project

Sep 24 2020

stella.stamenova added inline comments to D88229: Reland "[lldb] Don't send invalid region addresses to lldb server".
Sep 24 2020, 9:54 AM · Restricted Project

Sep 16 2020

stella.stamenova added a comment to D86968: [IRSim] Adding IR Instruction Mapper.

This broke some bots:

Sep 16 2020, 8:06 PM · Restricted Project
stella.stamenova added a reverting change for rGb04c1a9d3127: [IRSim] Adding IR Instruction Mapper: rGa895040eb022: Revert "[IRSim] Adding IR Instruction Mapper".
Sep 16 2020, 8:01 PM
stella.stamenova committed rGa895040eb022: Revert "[IRSim] Adding IR Instruction Mapper" (authored by stella.stamenova).
Revert "[IRSim] Adding IR Instruction Mapper"
Sep 16 2020, 8:01 PM
stella.stamenova added a reverting change for D86968: [IRSim] Adding IR Instruction Mapper: rGa895040eb022: Revert "[IRSim] Adding IR Instruction Mapper".
Sep 16 2020, 8:01 PM · Restricted Project

Sep 10 2020

stella.stamenova committed rGc464f1d8f9a0: [lldb, tests] Correctly configure the yaml2obj paths (authored by stella.stamenova).
[lldb, tests] Correctly configure the yaml2obj paths
Sep 10 2020, 10:13 AM
stella.stamenova closed D87466: [lldb, tests] Correctly configure the yaml2obj paths.
Sep 10 2020, 10:12 AM · Restricted Project
stella.stamenova requested review of D87466: [lldb, tests] Correctly configure the yaml2obj paths.
Sep 10 2020, 10:04 AM · Restricted Project

Apr 9 2020

stella.stamenova added a comment to D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff..

It looks like this broke the windows lldb buildbot:

Apr 9 2020, 7:03 PM · Restricted Project, Restricted Project

Mar 11 2020

stella.stamenova added a reviewer for D76031: [mlir][CRunnerUtils] Enable compilation with C++11 toolchain on microcontroller platforms.: NathanielMcVicar.

Adding Nate who is going to own the Windows MLIR Buildbot during my maternity :).

Mar 11 2020, 4:06 PM · Restricted Project

Mar 5 2020

stella.stamenova committed rZORG7eeee2a196c0: [buildbot] Switch MLIR buildbot quotes around (authored by stella.stamenova).
[buildbot] Switch MLIR buildbot quotes around
Mar 5 2020, 4:27 PM

Mar 4 2020

stella.stamenova committed rZORG127adafa5158: [buildbot] Add an MLIR buildbot on Windows (authored by stella.stamenova).
[buildbot] Add an MLIR buildbot on Windows
Mar 4 2020, 1:31 PM
stella.stamenova closed D75495: [buildbot] Add an MLIR buildbot on Windows.
Mar 4 2020, 1:31 PM
stella.stamenova updated the diff for D75495: [buildbot] Add an MLIR buildbot on Windows.

Make check-mlir be the only checks that run

Mar 4 2020, 1:29 PM
stella.stamenova updated the diff for D75495: [buildbot] Add an MLIR buildbot on Windows.

Add AMDGPU and NVPTX to the targets

Mar 4 2020, 12:59 PM

Mar 3 2020

stella.stamenova added a comment to D75459: [mlir] Add padding to 1-D Vector in CRunnerUtils.h.
Mar 3 2020, 1:13 PM · Restricted Project
stella.stamenova added a comment to D75459: [mlir] Add padding to 1-D Vector in CRunnerUtils.h.

I'm seeing an error on Windows with this:

Mar 3 2020, 11:57 AM · Restricted Project
stella.stamenova accepted rGbcee8982a293: [mlir] Hotfix - Fix Windows build.

Thanks! This works.

Mar 3 2020, 10:56 AM

Mar 2 2020

stella.stamenova committed rZORGf2b445456044: [buildbot] Add an MLIR buildbot on Windows (authored by stella.stamenova).
[buildbot] Add an MLIR buildbot on Windows
Mar 2 2020, 5:48 PM
stella.stamenova created D75495: [buildbot] Add an MLIR buildbot on Windows.
Mar 2 2020, 5:25 PM
stella.stamenova added a comment to D75495: [buildbot] Add an MLIR buildbot on Windows.

@gkistanova: We have the machine setup to connect to silent master (buildmaster_host = 'lab.llvm.org', port = 9994) as we expect some failures. Let me know if we need to do anything else other than commit the patch and wait for a reboot. Thanks!

Mar 2 2020, 5:25 PM
stella.stamenova added a comment to D75257: [mlir] NFC - Split out RunnerUtils that don't require a C++ runtime.

This change broke the MLIR build on Windows.

Mar 2 2020, 5:14 PM · Restricted Project

Feb 27 2020

stella.stamenova accepted D75275: [lldb/CMake] Use PYTHON_HOME as a hint to find Python 3..
Feb 27 2020, 11:46 AM · Restricted Project

Feb 24 2020

stella.stamenova added a comment to D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..

It looks like this broke the Windows LLDB Buildbot:

Feb 24 2020, 1:25 PM · Restricted Project

Feb 21 2020

stella.stamenova added a comment to D73999: [MC][ELF] Error for sh_type, sh_flags or sh_entsize change.

The tests used wrong sh_flags caught by this assembler change.

Hopefully fixed by ebee131259719fa9c06cd346e21ace3fa8ac0888. I made a typo in my description. sh_flags was incorrect, not sh_type.

Feb 21 2020, 6:44 PM · Restricted Project
stella.stamenova added a comment to D73999: [MC][ELF] Error for sh_type, sh_flags or sh_entsize change.

Looks like this broke the Windows LLDB bot:

Feb 21 2020, 5:24 PM · Restricted Project
stella.stamenova committed rG215a31115f89: Revert "Allow customized relative PYTHONHOME" (authored by stella.stamenova).
Revert "Allow customized relative PYTHONHOME"
Feb 21 2020, 3:07 PM
stella.stamenova added a reverting change for rG0bb90628b5f7: Allow customized relative PYTHONHOME: rG215a31115f89: Revert "Allow customized relative PYTHONHOME".
Feb 21 2020, 3:07 PM