- User Since
- Feb 7 2018, 7:04 PM (176 w, 1 d)
Tue, Jun 22
The newly added test is flaky and it fails on the Windows bot every few runs. I also saw it fail on Ubuntu in our private buildbots.
Mon, Jun 21
@wallace : Your most recent change to comment out ProgressEventThreadFunction is causing warnings to be generated when building with clang. Please have a look:
Fri, Jun 18
I wasn't able to reproduce this locally by running *just* the DirectoryWatcher tests. I'm not running all of the clang tests repeatedly to see if I can get a repro that way.
Thu, Jun 17
This is the best I can do from the online builds. I'll try and repro locally as well:
We still occasionally (every couple of runs) see these tests hang on Windows in both Debug and Release. Unfortunately, I don't have access to the machines running the tests to debug the tests while they are hanging and I haven't had a chance to try to reproduce locally.
In the last week or so I've seen one of these tests fail occasionally with ACCESS_VIOLATION in our testing. Unfortunately, I can't get a local repro. Here's the (best) log I can get from our online testing:
Tue, Jun 15
Mon, Jun 14
The Windows buildbot does not like signposts:
This change is generating warnings when building with clang:
Thu, Jun 10
It looks like this caused a couple of failures on the Windows LLDB bot due to crashes in clang:
Tue, Jun 8
It looks like this is causing a build failure on the windows mlir buildbot which may be the goal since the assert is firing, but it would be nice to keep the buildbot green.
Wed, Jun 2
I would not consider this an NFC and I think the title should be updated to not include the NFC designation. It might not be changing the intended functionality, but it is changing the logic (and functions called) to achieve the result.
This change is causing the following warning when building with clang:
May 19 2021
I'm not sure what to make of it now, and I'm not particularly familiar with Windows or MSVC. I'm still amenable to changing the code, but I also fear the changes I made won't actually fix the issue as I am only testing on godbolt. Is there any shortcut to testing with the Windows buildbots? Or do I have to install Windows somewhere and try to reproduce it?
@dblaikie @scott.linder I updated VS on both the mlir and lldb windows buildbots (from 15.9.30 to 15.9.36), but this update does not have an update to the compiler and indeed the compiler version was already `Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27045```. You can see from the logs of the broken builds as well:
May 17 2021
This broke some windows bots:
May 14 2021
May 11 2021
I don't have context into this either. Does this cause any test failures or is everything still green after the change?
May 10 2021
May 7 2021
Apr 30 2021
Apr 27 2021
It looks like this broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6085
Apr 26 2021
Looks like this is failing on the Windows LLDB bot:
Apr 16 2021
This broke several windows bots, for example the MLIR one:
Apr 15 2021
This broke the windows LLDB bot. Please fix it soon or revert.
Apr 13 2021
It looks like this broke the Windows LLDB bot (which also builds lld):
Apr 6 2021
It looks like @teemperor fixed it already!
The latest change (commit be0ced03) issues the following warning:
Apr 1 2021
Mar 30 2021
Looks like this broke the Windows lldb buildbot:
Mar 29 2021
Mar 26 2021
Mar 25 2021
Sounds like a plan. I'm not looking forward to having to undo and then redo all the necessary changes on our end, but we will have the opportunity to do them better with a little more heads up next time.
Mar 24 2021
Mar 23 2021
This switch to top down traversal also impacts onnx-mlir which has passes that do not currently work correctly with top down traversal (but do work with bottom up). I realize it's hard to keep track of all possible users, but I think it makes a lot of sense to make such changes optional for a time until the downstream components can adjust without breaking.
Mar 19 2021
This did end up breaking the windows build bot...
Mar 18 2021
Looks good as long as it doesn't break windows :O
Mar 17 2021
This broke the windows bot:
Mar 16 2021
It looks like this is failing on Windows MLIR bot:
Mar 3 2021
Mar 1 2021
This does not build on the Windows bot:
Considering this broke two bots, you might want to commit a fix or revert soon.
Feb 26 2021
Feb 19 2021
Feb 17 2021
Feb 11 2021
It looks like this change resulted in a failing test on the Windows LLDB bot:
Feb 10 2021
Feb 9 2021
To be clear, the windows mlir buildbot is broken because of this change:
Feb 8 2021
Feb 4 2021
Feb 2 2021
It looks like this broke the windows mlir bot. Please revert it or fix it ASAP:
Jan 27 2021
This worked almost, but not quite. It seems you did not fully update RunInTerminal.cpp.