Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (70 w, 6 d)

Recent Activity

Yesterday

stella.stamenova added a comment to D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups.

Thanks!

Tue, Jun 18, 8:45 AM · Restricted Project
stella.stamenova added a comment to D63110: Fix a crash in option parsing..

This test is extremely flaky on Windows - it looks like it passes on the bot less than 10% of the time: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot.

Tue, Jun 18, 8:45 AM · Restricted Project, Restricted Project

Mon, Jun 17

stella.stamenova added a comment to D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups.

It looks like this broke the Windows bot. I am no longer receiving emails when the bot fails (as bot owner I used to always get the failure emails), so I am assuming for some reason notifications aren't working correctly.

Mon, Jun 17, 1:45 PM · Restricted Project

Tue, Jun 11

stella.stamenova accepted D63102: Fix some lit test ResourceWarnings on Windows.

LGTM

Tue, Jun 11, 9:18 AM · Restricted Project

Tue, Jun 4

stella.stamenova accepted D62759: Fix lit tests on Windows related to CR.
Tue, Jun 4, 3:46 PM · Restricted Project
stella.stamenova added inline comments to D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.
Tue, Jun 4, 2:23 PM · Restricted Project, Restricted Project
stella.stamenova accepted D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Tue, Jun 4, 2:14 PM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Tue, Jun 4, 1:59 PM · Restricted Project, Restricted Project
stella.stamenova accepted D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.

LGTM

Tue, Jun 4, 1:52 PM · Restricted Project, Restricted Project
stella.stamenova requested changes to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

I don't think that this would apply very well to Visual Studio with the current change because it is likely that if you are using VS to build LLDB, you also used VS to build the dependencies. Even for xcode, I am sure that there are people who build the dependencies standalone with xcode and then are building LLDB standalone with xcode, so any change that absolutely treats the scenario as one or the other is going to break someone.

Tue, Jun 4, 9:54 AM · Restricted Project, Restricted Project

Wed, May 29

stella.stamenova committed rG83c28abdb252: lit: modernize the lit configuration for the lit tests (authored by stella.stamenova).
lit: modernize the lit configuration for the lit tests
Wed, May 29, 11:06 AM
stella.stamenova committed rL361998: lit: modernize the lit configuration for the lit tests.
lit: modernize the lit configuration for the lit tests
Wed, May 29, 11:05 AM
stella.stamenova closed D61798: lit: modernize the lit configuration for the lit tests.
Wed, May 29, 11:05 AM · Restricted Project

Tue, May 28

stella.stamenova added a comment to D60095: [LLD][COFF] Early load PDB type server files.

I am not very familiar with the lldb-mi tests specifically, but it looks like they require python to run (and are marked as unsupported otherwise):

Tue, May 28, 2:04 PM · Restricted Project
stella.stamenova added a comment to D60095: [LLD][COFF] Early load PDB type server files.

This change broke one of the tests on the Windows LLDB bot:

Tue, May 28, 12:33 PM · Restricted Project
stella.stamenova added a comment to D55056: [CMake] Default options for faster executables on MSVC.

This caused failures on the windows bot again:

Tue, May 28, 8:05 AM · Restricted Project

Thu, May 23

stella.stamenova added a comment to D62337: [lldb] followup fix for https://reviews.llvm.org/D62305.

This looks good - it is still not all though. Even after Jonas' change the build failed with the same error elsewhere.

Thu, May 23, 11:53 AM · Restricted Project
stella.stamenova added a comment to D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.

It looks like this was not enough and the build is still broken. Please revert your change or fix it and then keep an eye on the Buildbot to make sure it turns to green again. Once it's broken, it won't continue sending failure emails, so you have to monitor it to make sure your change fixed it.

Thu, May 23, 9:48 AM · Restricted Project
stella.stamenova added inline comments to D55056: [CMake] Default options for faster executables on MSVC.
Thu, May 23, 8:57 AM · Restricted Project

May 17 2019

stella.stamenova committed rG5bac70634326: [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt (authored by stella.stamenova).
[CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt
May 17 2019, 11:51 AM
stella.stamenova committed rL361064: [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt.
[CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt
May 17 2019, 11:50 AM
stella.stamenova committed rLLDB361064: [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt.
[CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt
May 17 2019, 11:50 AM

May 10 2019

stella.stamenova added a comment to rC360463: Improve interface of APValuePathEntry..

Either this change or your other APValue change broke the windows bot:

May 10 2019, 3:17 PM
stella.stamenova created D61798: lit: modernize the lit configuration for the lit tests.
May 10 2019, 12:27 PM · Restricted Project

May 9 2019

stella.stamenova committed rG46b9d19cc09a: Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does… (authored by stella.stamenova).
Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does…
May 9 2019, 1:21 PM
stella.stamenova committed rL360373: Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does….
Use UNSUPPORTED: windows in shtest-timeout.py. Apparently system-windows does…
May 9 2019, 1:20 PM
stella.stamenova committed rGdde1d9a6b775: Fix TestVSCode_attach on Linux (authored by stella.stamenova).
Fix TestVSCode_attach on Linux
May 9 2019, 12:49 PM
stella.stamenova added a comment to D60153: Re-enable most lldb-vscode tests on Linux..

Thanks, Pavel! I tested out the proposed change and all of our Ubuntu bots now work. I've committed it as well.

May 9 2019, 12:49 PM · Restricted Project, Restricted Project
stella.stamenova committed rL360371: Fix TestVSCode_attach on Linux.
Fix TestVSCode_attach on Linux
May 9 2019, 12:47 PM
stella.stamenova committed rLLDB360371: Fix TestVSCode_attach on Linux.
Fix TestVSCode_attach on Linux
May 9 2019, 12:47 PM
stella.stamenova committed rGbc9e0866933c: Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED… (authored by stella.stamenova).
Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED…
May 9 2019, 12:44 PM
stella.stamenova committed rLLDB360368: Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED….
Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED…
May 9 2019, 12:38 PM
stella.stamenova committed rL360368: Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED….
Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED…
May 9 2019, 12:38 PM
stella.stamenova requested changes to D61752: Re-enable a test for non-Windows.
May 9 2019, 12:30 PM · Restricted Project
stella.stamenova added a comment to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

@stella.stamenova I'm not familiar with any lit feature that gives a special meaning to the prefix "no". The opposite of "REQUIRES: windows" is not "REQUIRES: nowindows" but "UNSUPPORTED: windows" AFAIK.
This part of the discussion should probably be taken to llvm-dev, though.

FTR I don't see that lldb's lit.cfg.py sets any features based on host OS, so even "UNSUPPORTED: windows" probably does not work currently.

May 9 2019, 9:55 AM · Restricted Project, Restricted Project
stella.stamenova added a comment to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

Sorry for the drive-by... what is this REQUIRES: nowindows? I don't see where lit generates this property. I grepped all of llvm-project.git and I see it used in two tests, but not where it's produced. Which suggests that those tests don't actually run *anywhere*.

Thanks for the heads-up. I also just grepped. The history says that Stella will know more about it. I went with XFAIL for now.

May 9 2019, 9:09 AM · Restricted Project, Restricted Project

May 8 2019

stella.stamenova added a comment to D60153: Re-enable most lldb-vscode tests on Linux..

A couple of the tests from TestVSCode_attach.py (test_by_pid and test_by_name) are failing for us on Ubuntu because they are failing to attach: AssertionError: False is not True : attach failed (Operation not permitted). It looks like attaching by pid or by name requires elevation - if I rerun the same tests with sudo, they pass reliably. How did you run the tests when they passed for you?

May 8 2019, 2:17 PM · Restricted Project, Restricted Project

Apr 30 2019

stella.stamenova committed rGbe323ef5718b: Un-xfail the TestMiniDump tests on Windows (authored by stella.stamenova).
Un-xfail the TestMiniDump tests on Windows
Apr 30 2019, 9:42 AM
stella.stamenova committed rL359573: Un-xfail the TestMiniDump tests on Windows.
Un-xfail the TestMiniDump tests on Windows
Apr 30 2019, 9:42 AM
stella.stamenova committed rLLDB359573: Un-xfail the TestMiniDump tests on Windows.
Un-xfail the TestMiniDump tests on Windows
Apr 30 2019, 9:42 AM

Apr 25 2019

stella.stamenova accepted D60519: [Windows] Dump more information about access violation exception.

Yes, sorry. I hadn't gotten around to testing it to make sure the failures were gone. Do you still need someone to commit for you?

Apr 25 2019, 11:04 AM · Restricted Project, Restricted Project

Apr 23 2019

stella.stamenova accepted D60962: [NativePDB] Extend .pdb files search folders.
Apr 23 2019, 10:00 AM · Restricted Project

Apr 22 2019

stella.stamenova added inline comments to D60962: [NativePDB] Extend .pdb files search folders.
Apr 22 2019, 1:39 PM · Restricted Project

Apr 16 2019

stella.stamenova requested changes to D60519: [Windows] Dump more information about access violation exception.
Apr 16 2019, 11:30 AM · Restricted Project, Restricted Project
stella.stamenova added a comment to D60519: [Windows] Dump more information about access violation exception.

I ran local tests with this and a couple of the tests from the lldb suite failed:

Apr 16 2019, 11:30 AM · Restricted Project, Restricted Project

Apr 10 2019

stella.stamenova accepted D60519: [Windows] Dump more information about access violation exception.
Apr 10 2019, 9:35 AM · Restricted Project, Restricted Project

Apr 9 2019

stella.stamenova accepted D60458: [zorg] Add lldb-x86_64-debian builder.

yay!

Apr 9 2019, 9:11 AM · Restricted Project

Apr 5 2019

stella.stamenova committed rL357785: Add lld to the list of dependencies for the lldb_scheduler.
Add lld to the list of dependencies for the lldb_scheduler
Apr 5 2019, 10:30 AM
stella.stamenova closed D60230: Add lld to the list of dependencies for the lldb_scheduler.
Apr 5 2019, 10:30 AM · Restricted Project

Apr 3 2019

stella.stamenova added a comment to D60230: Add lld to the list of dependencies for the lldb_scheduler.

Does this mean a commit to lld could potentially break lldb?

Apr 3 2019, 6:22 PM · Restricted Project
stella.stamenova accepted D57911: [LLDB] Remove all abandoned LLDB bots.

Thanks!

Apr 3 2019, 3:50 PM · Restricted Project
stella.stamenova committed rGe51c12430ffe: Un-xfail one of the TestMiniDumpUUID tests on Windows (authored by stella.stamenova).
Un-xfail one of the TestMiniDumpUUID tests on Windows
Apr 3 2019, 2:57 PM
stella.stamenova committed rLLDB357641: Un-xfail one of the TestMiniDumpUUID tests on Windows.
Un-xfail one of the TestMiniDumpUUID tests on Windows
Apr 3 2019, 2:56 PM
stella.stamenova committed rL357641: Un-xfail one of the TestMiniDumpUUID tests on Windows.
Un-xfail one of the TestMiniDumpUUID tests on Windows
Apr 3 2019, 2:56 PM
stella.stamenova requested changes to D57911: [LLDB] Remove all abandoned LLDB bots.
Apr 3 2019, 1:38 PM · Restricted Project
stella.stamenova created D60230: Add lld to the list of dependencies for the lldb_scheduler.
Apr 3 2019, 1:10 PM · Restricted Project
stella.stamenova added a comment to D60122: [yaml2obj][obj2yaml] - Change how symbol's binding is descibed when parsing/dumping..

This broke the LLDB tests on the Windows Bot:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/3237

Apr 3 2019, 9:37 AM · Restricted Project
stella.stamenova added a comment to D60122: [yaml2obj][obj2yaml] - Change how symbol's binding is descibed when parsing/dumping..

This broke the LLDB tests on the Windows Bot:

Apr 3 2019, 9:37 AM · Restricted Project

Mar 28 2019

stella.stamenova accepted D59968: [Cmake] Unify python variables.

LGTM

Mar 28 2019, 4:39 PM · Restricted Project
stella.stamenova added a comment to D59847: Regression test to ensure that we handling importing of std::vector of enums correctly.

@stella.stamenova I committed a fix, please let me know if this does not address the regression:

http://llvm.org/viewvc/llvm-project?view=revision&revision=357210

Mar 28 2019, 1:34 PM · Restricted Project
stella.stamenova added a comment to D59847: Regression test to ensure that we handling importing of std::vector of enums correctly.

This is causing failures on the windows bot. Please fix it or revert it.

Mar 28 2019, 12:08 PM · Restricted Project

Mar 13 2019

stella.stamenova committed rG823d9f3cdf16: [lldbsuite] Un-xfail TestPyObjSynthProvider on Windows (authored by stella.stamenova).
[lldbsuite] Un-xfail TestPyObjSynthProvider on Windows
Mar 13 2019, 9:54 AM
stella.stamenova committed rLLDB356065: [lldbsuite] Un-xfail TestPyObjSynthProvider on Windows.
[lldbsuite] Un-xfail TestPyObjSynthProvider on Windows
Mar 13 2019, 9:54 AM
stella.stamenova committed rL356065: [lldbsuite] Un-xfail TestPyObjSynthProvider on Windows.
[lldbsuite] Un-xfail TestPyObjSynthProvider on Windows
Mar 13 2019, 9:54 AM

Mar 7 2019

stella.stamenova added a comment to D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows.

This broke the Windows bot because now one of the TestPaths tests passes on Windows:

Mar 7 2019, 1:22 PM · Restricted Project, Restricted Project

Mar 6 2019

stella.stamenova added a comment to D58962: Sanity check --max-gdbserver-port.

This caused a failure on the Windows bot:

Mar 6 2019, 2:40 PM · Restricted Project

Mar 5 2019

stella.stamenova added a comment to D58748: [ExpressionParser] Test GetClangResourceDir.

This introduced a build break on Windows (which happened to coincide with another build break).

Mar 5 2019, 5:47 PM · Restricted Project
stella.stamenova committed rG2717b76c1a4a: [lit, windows] Disable stop-hook-threads on Windows (authored by stella.stamenova).
[lit, windows] Disable stop-hook-threads on Windows
Mar 5 2019, 1:42 PM
stella.stamenova committed rLLDB355448: [lit, windows] Disable stop-hook-threads on Windows.
[lit, windows] Disable stop-hook-threads on Windows
Mar 5 2019, 1:42 PM
stella.stamenova committed rL355448: [lit, windows] Disable stop-hook-threads on Windows.
[lit, windows] Disable stop-hook-threads on Windows
Mar 5 2019, 1:42 PM
stella.stamenova committed rGd15f3b188bf7: [lldbsuite, windows] Skip the TestEvents tests on Windows (authored by stella.stamenova).
[lldbsuite, windows] Skip the TestEvents tests on Windows
Mar 5 2019, 1:03 PM
stella.stamenova committed rL355443: [lldbsuite, windows] Skip the TestEvents tests on Windows.
[lldbsuite, windows] Skip the TestEvents tests on Windows
Mar 5 2019, 1:03 PM
stella.stamenova committed rLLDB355443: [lldbsuite, windows] Skip the TestEvents tests on Windows.
[lldbsuite, windows] Skip the TestEvents tests on Windows
Mar 5 2019, 1:03 PM
stella.stamenova added a comment to D57689: Adds property to force enabling of GDB JIT loader for MacOS.

This is causing a failure on the Windows Bot:

Mar 5 2019, 8:44 AM · Restricted Project, Restricted Project

Feb 28 2019

stella.stamenova added a comment to D57463: Add a module pass for order file instrumentation.

This broke the windows LLDB bot:

Feb 28 2019, 12:56 PM · Restricted Project

Feb 20 2019

stella.stamenova added a comment to D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images.

This broke the windows bot:

Feb 20 2019, 9:24 AM · Restricted Project, Restricted Project

Feb 15 2019

stella.stamenova committed rGa2d9fdf5b65a: [win] Resolve the module only if there isn't one already (authored by stella.stamenova).
[win] Resolve the module only if there isn't one already
Feb 15 2019, 1:42 PM
stella.stamenova committed rL354172: [win] Resolve the module only if there isn't one already.
[win] Resolve the module only if there isn't one already
Feb 15 2019, 1:42 PM
stella.stamenova committed rLLDB354172: [win] Resolve the module only if there isn't one already.
[win] Resolve the module only if there isn't one already
Feb 15 2019, 1:42 PM
stella.stamenova closed D58303: [win] Resolve the module only if there isn't one already.
Feb 15 2019, 1:41 PM · Restricted Project
stella.stamenova created D58303: [win] Resolve the module only if there isn't one already.
Feb 15 2019, 1:38 PM · Restricted Project
stella.stamenova accepted D58050: PECOFF: Implement GetBaseAddress.

LGTM. Now might not be the best time to commit it though because the LLDB build is broken on Windows.

Feb 15 2019, 10:08 AM · Restricted Project

Feb 14 2019

stella.stamenova accepted D58177: Fix lldb-server test suite for python3.

Thanks for the review Stella. I was hoping someone would step in and tell me that there is a better way to do that. However :), I see two problems with your proposal:

  • build.py is a standalone file, and so it is not easy for it to share code with other stuff. This can be solved with some use_lldb_suite magic or moving the script some place else, but then comes the second problem:
  • I am not sure these two use cases are actually compatible. Here I specifically want to "reinterpret_cast" binary bytes without doing any sort of encoding. The only place where to_string is used in build.py currently is on a value retrieved from the windows registry. I'm not 100% sure, but it seems to me that using utf8 encoding (which is what to_string is doing) is precisely the right thing to do there.

    With that in mind, I propose to do the following:
  • leave build.py alone for now
  • rename the new functions I'm introducing here to something less generic. Maybe bitcast_to_string and bitcast_to_bytes?

    WDYT?
Feb 14 2019, 9:59 AM · Restricted Project

Feb 13 2019

stella.stamenova added a comment to D58090: Deserialize Clang module search path from DWARF.

This looks to have broken the windows build:

Feb 13 2019, 11:07 AM · Restricted Project
stella.stamenova requested changes to D58177: Fix lldb-server test suite for python3.
Feb 13 2019, 10:26 AM · Restricted Project

Feb 7 2019

stella.stamenova accepted D57911: [LLDB] Remove all abandoned LLDB bots.

There's another patch (https://reviews.llvm.org/D54386/) which is fixing the fedora bot. You might want to leave that one.

Feb 7 2019, 10:36 AM · Restricted Project
stella.stamenova accepted D54386: Disable for new Linux OS runs: upload test traces.

This looks good. After it's checked in, it won't take effect until the master buildbot is updated though. You'd need @gkistanova to update it. She should also sign off on this.

Feb 7 2019, 10:33 AM · Restricted Project, Restricted Project

Feb 5 2019

stella.stamenova added a comment to D57552: Handle "." in target.source-map in PathMapListing::FindFiles.

This is failing on the windows bot:

Feb 5 2019, 4:30 PM · Restricted Project, Restricted Project

Jan 29 2019

stella.stamenova added a comment to D54617: [Reproducers] Add file provider.

This change broke one of the tests on Windows:

Jan 29 2019, 2:59 PM · Restricted Project
stella.stamenova accepted D56781: Use response file when generating LLVM-C.dll.

Build passes with VS now.

Jan 29 2019, 2:38 PM · Restricted Project
stella.stamenova added a comment to D57273: Make Type::GetByteSize optional.

I am not sure if you saw this, but it looks like it broke one of the tests on the Windows bot:

Jan 29 2019, 10:46 AM
stella.stamenova requested changes to D56781: Use response file when generating LLVM-C.dll.
Jan 29 2019, 10:18 AM · Restricted Project

Jan 28 2019

stella.stamenova added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@thakis Thanks for the information, I had actually missed that.

Jan 28 2019, 4:55 PM · Restricted Project
stella.stamenova added a comment to D56781: Use response file when generating LLVM-C.dll.

This change is causing build failures on Windows when using Visual Studio as the generator. It would also cause the same failure on for any other generator that supports multiple configurations.

Jan 28 2019, 4:43 PM · Restricted Project
stella.stamenova accepted D57275: [seven] Remove trailing characters from command output..
Jan 28 2019, 9:50 AM · Restricted Project

Jan 26 2019

stella.stamenova added a comment to D57275: [seven] Remove trailing characters from command output..

I don't have a strong preference between using a separate module for interopability between python versions and implementing the functions as part of dotest if there are few of them, but I have to agree with @zturner that if we have more than a couple of functions, it makes sense to add them to an explicit module.

Jan 26 2019, 7:22 AM · Restricted Project
stella.stamenova added a comment to D56931: lld-link: Store comdat selection in SectionChunk, reject more invalid associated comdats.

It looks like this change broke the windows bot:

Jan 26 2019, 7:10 AM
stella.stamenova added a comment to D57186: [SelectionDAG][X86] Don't use SEXTLOAD for promoting masked loads in the type legalizer.

@stella.stamenova I don't think reverting mine fixed it. I notice this commit was also around the same time, but isn't logged. http://llvm.org/viewvc/llvm-project?revision=352254&view=revision Does the bot also build lld and use it?

Jan 26 2019, 7:08 AM

Jan 25 2019

stella.stamenova added a comment to D57186: [SelectionDAG][X86] Don't use SEXTLOAD for promoting masked loads in the type legalizer.

I haven't had time to look into it in details but it looks like either this change or https://reviews.llvm.org/D57259 broke the windows LLDB bot.

Jan 25 2019, 5:51 PM
stella.stamenova added a comment to D57259: [NVPTX] Some nvvm.read.ptx.sreg intrinsics should have IntrInaccessibleMemOnly attribute..

I haven't had time to look into it in details but it looks like either this change or https://reviews.llvm.org/D57186 broke the windows bot.

Jan 25 2019, 5:50 PM