- User Since
- Feb 7 2018, 7:04 PM (294 w, 4 d)
Mar 14 2023
Mar 10 2023
Mar 9 2023
Mar 6 2023
Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and revert the changes to bring it back to green.
Looks like this change broke the windows lldb build: https://lab.llvm.org/buildbot/#/builders/83/builds/29801
Mar 1 2023
Looks like the new test is failing on the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29680. The buildbot was already red because of TestCommandScript.py, so you might have missed this.
Feb 14 2023
Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/32020
Feb 13 2023
One thing that we could do is disable werror on the buildbot for the moment and then re-enable it. It's not terribly difficult, but it relies on buildbot master being re-started to take effect, so it might not even take effect before the warnings are fixed.
Feb 7 2023
Feb 6 2023
Looks like this caused a failure in the mlir buildbot due to an unused variable: https://lab.llvm.org/buildbot/#/builders/13/builds/31682
Feb 1 2023
Jan 25 2023
Jan 17 2023
Jan 12 2023
Thanks for fixing this long-standing bug!
Dec 23 2022
Looks like this added a failure to the already red mlir windows buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/30167
Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/30140
Dec 12 2022
@rahmanl would it be possible to address the windows failures or revert this commit while someone investigates?
Dec 8 2022
It looks like this change broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/29443
Dec 5 2022
Looks like this broke the windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/26822
@Peiming : I reverted your change because it broke multiple buildbots - windows and gcc included. I see that you've re-committed it. Did you make sure to address all three build breaks that were reported including the one @vzakhari pointed out? In cases like this, please make sure NOT to recommit your changes without making sure that all build breaks are addressed as it is disruptive to have buildbots that are broken especially when a change is identified as the source.
Nov 17 2022
Looks like the windows lldb bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/26083
Nov 16 2022
Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/26042
Nov 14 2022
This appears to have broken the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/28298
Nov 12 2022
This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854
Nov 7 2022
Nov 2 2022
This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829
Nov 1 2022
The newly added test is failing on the windows buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/25446
Oct 31 2022
Looks like in addition to the Linux failure, this also broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio
Oct 20 2022
This change has caused intermittent failures in reorder.py on Windows. I wonder why the changes to the test were necessary and if we can update it so it works consistently on Windows as well as with bazel:
Oct 17 2022
I think this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24905
Oct 12 2022
Oct 10 2022
LGTM. A couple of minor comments inline.
Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/26882
Looks like this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24631
Oct 8 2022
Both debug and release windows builds are green with this. Thanks!
Oct 7 2022
There's, unfortunately, no public facing mlir windows bot that builds debug. We have some internal testing which builds debug which is how we ran into this.
This change broke the mlir build on Windows in Debug. I'm actually not entirely sure why it only broke in Debug and not in Release as well because I would expect the issue to be the same in both.
Oct 6 2022
We ended up with https://reviews.llvm.org/D135304 as the currently committed change. I believe this worked correctly everywhere, but if anyone knows of a break, we should address that as well.
Oct 5 2022
Oct 4 2022
D135126 was needed to fix the Windows mlir bot which was red for several days because of https://github.com/llvm/llvm-project/commit/e898be2f6edbb886af2f6b23e2f5db5210535620 which landed after D134925 and undid it.
As Nate said, https://github.com/llvm/llvm-project/commit/e898be2f6edbb886af2f6b23e2f5db5210535620 broke the windows mlir bot which then stayed red for a couple of days. We wanted to make sure to get it back to green and this change seemed the most appropriate. We are not particularly tied to this change or another change but simply reverting this will get us back to a red state. @wrengr @aartbik if you have a better way to address the issue, that would be great, but we do not want the bot to be red again.
LGTM, thanks for fixing the build breaks!