It looks like this broke the windows build bot:

LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though.

I think this is actually fine. The change that was needed for multi-configuration generators is how the two default paths for the compilers are set. The USE variables were to make it explicit when we will or we won't override the user-set compiler. As long as we are OK overriding it if they set it to an empty string (which is probably an error, anyway), this change is good.

LGTM

It looks like this changed caused 30 or so of the tests to fail on the Windows bot. It was already broken, so you wouldn't have gotten an email:

This change caused failures on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7681 compounding on the existing failures from [lldb] Refactor guard variable checks in IRForTarget

The windows bot for LLDB is still broken after the partial fix for the breakage:

@mgorny Could you download the patch and see if it fixes your scenario? I tested it on both Ubuntu and Linux, but neither installation of LLVM I have actually contains FileCheck or not, so my setup is not entirely the same as yours.

Yes, it was! Thanks for catching that :)

Test passes now. Thanks!

LGTM. Please keep an eye on the bot after you commit though

I am able to do some testing as well.

HERE: useExternalSh: False

This actually breaks the lit tests on Windows when the path to Python has spaces. For example:

It is indeed https://reviews.llvm.org/D65156 which introduced the failure

It could be either actually. I'll run the tests with just the first one and see if it reproduces. I *think* it's this one.

This actually breaks the lit tests on Windows when the path to Python has spaces. For example:

One failure:

I'll run some tests and let you know the result.

I think you need one small change for lld still - to make it clear that it is required on Windows in the Windows section, but it looks good otherwise. Please fix that before committing.

Re: Windows CMake: I am not sure, I'd have to do look into it further.

LGTM!

This broke the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/6493/steps/build/logs/stdio

I am not sure if you've seen this yet, but this broke the Windows LLDB bot:

LGTM. Have you run the tests to make sure they behave correctly after this change?

LGTM.

In D63110#1551572, @mgorny wrote:

@stella.stamenova could you try running the lldb invocation manually like I did? I'm wondering if you're getting the same issue.

Thanks!

This test is extremely flaky on Windows - it looks like it passes on the bot less than 10% of the time: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot.

It looks like this broke the Windows bot. I am no longer receiving emails when the bot fails (as bot owner I used to always get the failure emails), so I am assuming for some reason notifications aren't working correctly.

LGTM

LGTM

I don't think that this would apply very well to Visual Studio with the current change because it is likely that if you are using VS to build LLDB, you also used VS to build the dependencies. Even for xcode, I am sure that there are people who build the dependencies standalone with xcode and then are building LLDB standalone with xcode, so any change that absolutely treats the scenario as one or the other is going to break someone.

I am not very familiar with the lldb-mi tests specifically, but it looks like they require python to run (and are marked as unsupported otherwise):

This change broke one of the tests on the Windows LLDB bot:

This caused failures on the windows bot again:

This looks good - it is still not all though. Even after Jonas' change the build failed with the same error elsewhere.

It looks like this was not enough and the build is still broken. Please revert your change or fix it and then keep an eye on the Buildbot to make sure it turns to green again. Once it's broken, it won't continue sending failure emails, so you have to monitor it to make sure your change fixed it.

Either this change or your other APValue change broke the windows bot:

Thanks, Pavel! I tested out the proposed change and all of our Ubuntu bots now work. I've committed it as well.