Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (53 w, 6 d)

Recent Activity

Today

stella.stamenova added a comment to D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images.

This broke the windows bot:

Wed, Feb 20, 9:24 AM · Restricted Project, Restricted Project

Fri, Feb 15

stella.stamenova committed rGa2d9fdf5b65a: [win] Resolve the module only if there isn't one already (authored by stella.stamenova).
[win] Resolve the module only if there isn't one already
Fri, Feb 15, 1:42 PM
stella.stamenova committed rL354172: [win] Resolve the module only if there isn't one already.
[win] Resolve the module only if there isn't one already
Fri, Feb 15, 1:42 PM
stella.stamenova committed rLLDB354172: [win] Resolve the module only if there isn't one already.
[win] Resolve the module only if there isn't one already
Fri, Feb 15, 1:42 PM
stella.stamenova closed D58303: [win] Resolve the module only if there isn't one already.
Fri, Feb 15, 1:41 PM · Restricted Project
stella.stamenova created D58303: [win] Resolve the module only if there isn't one already.
Fri, Feb 15, 1:38 PM · Restricted Project
stella.stamenova accepted D58050: PECOFF: Implement GetBaseAddress.

LGTM. Now might not be the best time to commit it though because the LLDB build is broken on Windows.

Fri, Feb 15, 10:08 AM · Restricted Project

Thu, Feb 14

stella.stamenova accepted D58177: Fix lldb-server test suite for python3.

Thanks for the review Stella. I was hoping someone would step in and tell me that there is a better way to do that. However :), I see two problems with your proposal:

  • build.py is a standalone file, and so it is not easy for it to share code with other stuff. This can be solved with some use_lldb_suite magic or moving the script some place else, but then comes the second problem:
  • I am not sure these two use cases are actually compatible. Here I specifically want to "reinterpret_cast" binary bytes without doing any sort of encoding. The only place where to_string is used in build.py currently is on a value retrieved from the windows registry. I'm not 100% sure, but it seems to me that using utf8 encoding (which is what to_string is doing) is precisely the right thing to do there.

    With that in mind, I propose to do the following:
  • leave build.py alone for now
  • rename the new functions I'm introducing here to something less generic. Maybe bitcast_to_string and bitcast_to_bytes?

    WDYT?
Thu, Feb 14, 9:59 AM · Restricted Project

Wed, Feb 13

stella.stamenova added a comment to D58090: Deserialize Clang module search path from DWARF.

This looks to have broken the windows build:

Wed, Feb 13, 11:07 AM · Restricted Project
stella.stamenova requested changes to D58177: Fix lldb-server test suite for python3.
Wed, Feb 13, 10:26 AM · Restricted Project

Thu, Feb 7

stella.stamenova accepted D57911: [LLDB] Remove all abandoned LLDB bots.

There's another patch (https://reviews.llvm.org/D54386/) which is fixing the fedora bot. You might want to leave that one.

Thu, Feb 7, 10:36 AM
stella.stamenova accepted D54386: Disable for new Linux OS runs: upload test traces.

This looks good. After it's checked in, it won't take effect until the master buildbot is updated though. You'd need @gkistanova to update it. She should also sign off on this.

Thu, Feb 7, 10:33 AM · Restricted Project, Restricted Project

Tue, Feb 5

stella.stamenova added a comment to D57552: Handle "." in target.source-map in PathMapListing::FindFiles.

This is failing on the windows bot:

Tue, Feb 5, 4:30 PM · Restricted Project, Restricted Project

Tue, Jan 29

stella.stamenova added a comment to D54617: [Reproducers] Add file provider.

This change broke one of the tests on Windows:

Tue, Jan 29, 2:59 PM · Restricted Project
stella.stamenova accepted D56781: Use response file when generating LLVM-C.dll.

Build passes with VS now.

Tue, Jan 29, 2:38 PM
stella.stamenova added a comment to D57273: Make Type::GetByteSize optional.

I am not sure if you saw this, but it looks like it broke one of the tests on the Windows bot:

Tue, Jan 29, 10:46 AM
stella.stamenova requested changes to D56781: Use response file when generating LLVM-C.dll.
Tue, Jan 29, 10:18 AM

Mon, Jan 28

stella.stamenova added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@thakis Thanks for the information, I had actually missed that.

Mon, Jan 28, 4:55 PM · Restricted Project
stella.stamenova added a comment to D56781: Use response file when generating LLVM-C.dll.

This change is causing build failures on Windows when using Visual Studio as the generator. It would also cause the same failure on for any other generator that supports multiple configurations.

Mon, Jan 28, 4:43 PM
stella.stamenova accepted D57275: [seven] Remove trailing characters from command output..
Mon, Jan 28, 9:50 AM · Restricted Project

Sat, Jan 26

stella.stamenova added a comment to D57275: [seven] Remove trailing characters from command output..

I don't have a strong preference between using a separate module for interopability between python versions and implementing the functions as part of dotest if there are few of them, but I have to agree with @zturner that if we have more than a couple of functions, it makes sense to add them to an explicit module.

Sat, Jan 26, 7:22 AM · Restricted Project
stella.stamenova added a comment to D56931: lld-link: Store comdat selection in SectionChunk, reject more invalid associated comdats.

It looks like this change broke the windows bot:

Sat, Jan 26, 7:10 AM
stella.stamenova added a comment to D57186: [SelectionDAG][X86] Don't use SEXTLOAD for promoting masked loads in the type legalizer.

@stella.stamenova I don't think reverting mine fixed it. I notice this commit was also around the same time, but isn't logged. http://llvm.org/viewvc/llvm-project?revision=352254&view=revision Does the bot also build lld and use it?

Sat, Jan 26, 7:08 AM

Fri, Jan 25

stella.stamenova added a comment to D57186: [SelectionDAG][X86] Don't use SEXTLOAD for promoting masked loads in the type legalizer.

I haven't had time to look into it in details but it looks like either this change or https://reviews.llvm.org/D57259 broke the windows LLDB bot.

Fri, Jan 25, 5:51 PM
stella.stamenova added a comment to D57259: [NVPTX] Some nvvm.read.ptx.sreg intrinsics should have IntrInaccessibleMemOnly attribute..

I haven't had time to look into it in details but it looks like either this change or https://reviews.llvm.org/D57186 broke the windows bot.

Fri, Jan 25, 5:50 PM
stella.stamenova committed rL352252: Fixed frontend clang tests in windows read-only container.
Fixed frontend clang tests in windows read-only container
Fri, Jan 25, 3:03 PM
stella.stamenova committed rC352252: Fixed frontend clang tests in windows read-only container.
Fixed frontend clang tests in windows read-only container
Fri, Jan 25, 3:03 PM
stella.stamenova closed D50563: Fixed frontend clang tests in windows read-only container.
Fri, Jan 25, 3:03 PM · Restricted Project
stella.stamenova added a comment to D56548: Fix emission of _fltused for MSVC..

One of the LLDB bots is still failing because of this change: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/978/steps/test/logs/stdio

Committed r352159 to fix this.

Fri, Jan 25, 9:56 AM

Thu, Jan 24

stella.stamenova added a comment to D56548: Fix emission of _fltused for MSVC..

One of the LLDB bots is still failing because of this change: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/978/steps/test/logs/stdio

Thu, Jan 24, 3:27 PM
stella.stamenova accepted rL352058: [CMake] Get back some variables used in AddLLVM.cmake.
Thu, Jan 24, 9:00 AM
stella.stamenova accepted D50563: Fixed frontend clang tests in windows read-only container.
Thu, Jan 24, 8:59 AM · Restricted Project

Wed, Jan 23

stella.stamenova requested changes to D50563: Fixed frontend clang tests in windows read-only container.

Thanks. You have to change a couple of the locations to '%T' though - '%t' is a file and '%T' is a directory - and you're using '%t' as a directory in a couple of the places.

Wed, Jan 23, 1:51 PM · Restricted Project

Jan 20 2019

stella.stamenova added a comment to D56829: Move decl context dumping to TextNodeDumper.

It looks like this change broke a number of the LLDB tests:

Jan 20 2019, 8:57 AM

Jan 16 2019

stella.stamenova added a comment to D56798: Change TypeSystem::GetBitSize() to return an optional result..

TestFunctionRefs is failing on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/677

Jan 16 2019, 2:06 PM
stella.stamenova added a comment to D56543: DWARF: Add some support for non-native directory separators.

The Windows Buildbot is failing because of one of the tests (SymbolFile/DWARF/dir-separator-no-comp-dir-relative-name.s) added in this change. You can see the failure here: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/666. It looks like it is checking for the wrong path on Windows:

Jan 16 2019, 9:16 AM

Jan 14 2019

stella.stamenova committed rL351080: [lldbsuite] Skip two more flaky tests on Windows.
[lldbsuite] Skip two more flaky tests on Windows
Jan 14 2019, 9:59 AM
stella.stamenova committed rLLDB351080: [lldbsuite] Skip two more flaky tests on Windows.
[lldbsuite] Skip two more flaky tests on Windows
Jan 14 2019, 9:59 AM

Jan 11 2019

stella.stamenova committed rL350978: [lldbsuite] Skip TestExitDuringStep on Windows.
[lldbsuite] Skip TestExitDuringStep on Windows
Jan 11 2019, 3:12 PM
stella.stamenova committed rLLDB350978: [lldbsuite] Skip TestExitDuringStep on Windows.
[lldbsuite] Skip TestExitDuringStep on Windows
Jan 11 2019, 3:12 PM
stella.stamenova accepted D56609: [CMake] Remove dead code and outdated comments.
Jan 11 2019, 9:45 AM

Jan 10 2019

stella.stamenova requested changes to D56400: [CMake] Some cleanup around test preparations.
Jan 10 2019, 9:15 AM

Jan 9 2019

stella.stamenova added inline comments to D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER.
Jan 9 2019, 11:35 AM
stella.stamenova requested changes to D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER.
Jan 9 2019, 9:42 AM

Dec 21 2018

stella.stamenova committed rL349977: [cmake] Suppress 'warning C4201: nonstandard extension used: nameless….
[cmake] Suppress 'warning C4201: nonstandard extension used: nameless…
Dec 21 2018, 4:03 PM
stella.stamenova committed rLLDB349977: [cmake] Suppress 'warning C4201: nonstandard extension used: nameless….
[cmake] Suppress 'warning C4201: nonstandard extension used: nameless…
Dec 21 2018, 4:03 PM
stella.stamenova committed rL349946: [lldbsuite] Skip flakey Windows tests.
[lldbsuite] Skip flakey Windows tests
Dec 21 2018, 12:14 PM
stella.stamenova committed rLLDB349946: [lldbsuite] Skip flakey Windows tests.
[lldbsuite] Skip flakey Windows tests
Dec 21 2018, 12:14 PM

Dec 20 2018

stella.stamenova committed rLLDB349813: [lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows.
[lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows
Dec 20 2018, 12:29 PM
stella.stamenova committed rL349813: [lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows.
[lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows
Dec 20 2018, 12:29 PM
stella.stamenova committed rLLDB349784: [lit] Skip stop-hook test on Windows.
[lit] Skip stop-hook test on Windows
Dec 20 2018, 10:28 AM
stella.stamenova committed rL349784: [lit] Skip stop-hook test on Windows.
[lit] Skip stop-hook test on Windows
Dec 20 2018, 10:28 AM
stella.stamenova committed rLLDB349783: [lldbsuite] Un-xfail TestMiniDump and TestThreadJump.
[lldbsuite] Un-xfail TestMiniDump and TestThreadJump
Dec 20 2018, 10:24 AM
stella.stamenova committed rL349783: [lldbsuite] Un-xfail TestMiniDump and TestThreadJump.
[lldbsuite] Un-xfail TestMiniDump and TestThreadJump
Dec 20 2018, 10:24 AM
stella.stamenova committed rL349781: [lldbsuite] Un-xfail TestEvents on Windows.
[lldbsuite] Un-xfail TestEvents on Windows
Dec 20 2018, 10:03 AM
stella.stamenova committed rLLDB349781: [lldbsuite] Un-xfail TestEvents on Windows.
[lldbsuite] Un-xfail TestEvents on Windows
Dec 20 2018, 10:03 AM
stella.stamenova committed rL349775: [lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows.
[lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows
Dec 20 2018, 9:23 AM
stella.stamenova committed rLLDB349775: [lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows.
[lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows
Dec 20 2018, 9:23 AM

Dec 19 2018

stella.stamenova committed rL349722: [lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows.
[lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows
Dec 19 2018, 7:07 PM
stella.stamenova committed rLLDB349722: [lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows.
[lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows
Dec 19 2018, 7:07 PM
stella.stamenova committed rLLDB349721: [lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows.
[lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows
Dec 19 2018, 6:25 PM
stella.stamenova committed rL349721: [lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows.
[lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows
Dec 19 2018, 6:25 PM
stella.stamenova committed rL349719: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.5).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.5)
Dec 19 2018, 6:07 PM
stella.stamenova committed rLLDB349719: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.5).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.5)
Dec 19 2018, 6:07 PM
stella.stamenova committed rL349713: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.4).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.4)
Dec 19 2018, 5:29 PM
stella.stamenova committed rLLDB349713: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.4).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.4)
Dec 19 2018, 5:28 PM
stella.stamenova committed rL349711: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.3).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.3)
Dec 19 2018, 5:02 PM
stella.stamenova committed rLLDB349711: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.3).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.3)
Dec 19 2018, 5:02 PM
stella.stamenova committed rL349668: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.2).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.2)
Dec 19 2018, 11:13 AM
stella.stamenova committed rLLDB349668: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.2).
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.2)
Dec 19 2018, 11:13 AM
stella.stamenova committed rLLDB349665: [lldbsuite] Un-xfail tests on Windows that are now passing.
[lldbsuite] Un-xfail tests on Windows that are now passing
Dec 19 2018, 11:07 AM
stella.stamenova committed rL349665: [lldbsuite] Un-xfail tests on Windows that are now passing.
[lldbsuite] Un-xfail tests on Windows that are now passing
Dec 19 2018, 11:07 AM
stella.stamenova added a comment to D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info.

I tracked this down - the failures are not due to this change (or any LLDB change). It's this change to the common CMake files in LLVM: https://reviews.llvm.org/D55056

Dec 19 2018, 9:57 AM
stella.stamenova added a comment to D55056: [CMake] Default options for faster executables on MSVC.

This change caused a number of failures in the LLDB tests (as in 40+ failures) on Windows:

Dec 19 2018, 9:56 AM

Dec 18 2018

stella.stamenova committed rL349573: [lit] Rather than including stdio.h, forward-declare printf in….
[lit] Rather than including stdio.h, forward-declare printf in…
Dec 18 2018, 3:39 PM
stella.stamenova committed rLLDB349573: [lit] Rather than including stdio.h, forward-declare printf in….
[lit] Rather than including stdio.h, forward-declare printf in…
Dec 18 2018, 3:39 PM
stella.stamenova committed rL349562: [lit] Use the new build.py script in the lldb-mi tests.
[lit] Use the new build.py script in the lldb-mi tests
Dec 18 2018, 2:58 PM
stella.stamenova committed rLLDB349562: [lit] Use the new build.py script in the lldb-mi tests.
[lit] Use the new build.py script in the lldb-mi tests
Dec 18 2018, 2:58 PM
stella.stamenova added a comment to D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info.

It looks like this might not be specific to your change as a few other tests are failing with a similar error. I'm looking into it.

Dec 18 2018, 1:23 PM
stella.stamenova added a comment to D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info.

A bunch of the NativePDB tests are failing on Windows now.

Dec 18 2018, 1:05 PM
stella.stamenova added a comment to D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing.

Can you confirm that reverting this path actually fixes the issue? I'm asking because the only test that is executing this script has a REQUIRES: system-darwin line in it.

Dec 18 2018, 10:53 AM

Dec 17 2018

stella.stamenova added a comment to D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing.

This change made the Windows test get stuck: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2340

Dec 17 2018, 5:39 PM
stella.stamenova accepted D55736: build.py: inherit environment in the gcc builder.

This does fix the issues. Thanks!

Dec 17 2018, 9:54 AM

Dec 14 2018

stella.stamenova added a comment to D55430: build.py: Implement "gcc" builder.

I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing:

Dec 14 2018, 11:32 AM
stella.stamenova requested changes to D50563: Fixed frontend clang tests in windows read-only container.
Dec 14 2018, 10:57 AM · Restricted Project
stella.stamenova added a comment to D55575: [NativePDB] Support local variables.
$ ":" "RUN: at line 5"
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe" "-s" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit"
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp"
# command stderr:
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16: error: CHECK-NEXT: expected string not found in input
Dec 14 2018, 10:38 AM
stella.stamenova added a comment to D55575: [NativePDB] Support local variables.

local-variables.cpp is failing on the Buildbot:

Dec 14 2018, 10:31 AM

Dec 11 2018

stella.stamenova abandoned D55569: [lit] Add a basic implementation of build for GccBuilder.

Let's use @labath's change instead.

Dec 11 2018, 2:07 PM
stella.stamenova accepted D55430: build.py: Implement "gcc" builder.

A couple of small comments, but it looks good otherwise. Thanks!

Dec 11 2018, 2:04 PM
stella.stamenova created D55569: [lit] Add a basic implementation of build for GccBuilder.
Dec 11 2018, 12:29 PM

Dec 10 2018

stella.stamenova committed rL348775: Do not use PATH_MAX with SmallString.
Do not use PATH_MAX with SmallString
Dec 10 2018, 9:29 AM
stella.stamenova committed rLLDB348775: Do not use PATH_MAX with SmallString.
Do not use PATH_MAX with SmallString
Dec 10 2018, 9:29 AM
stella.stamenova closed D55457: Do not use PATH_MAX with SmallString.
Dec 10 2018, 9:29 AM

Dec 7 2018

stella.stamenova committed rL348665: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
[tests] Fix the FileManagerTest getVirtualFile test on Windows
Dec 7 2018, 3:53 PM
stella.stamenova committed rC348665: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
[tests] Fix the FileManagerTest getVirtualFile test on Windows
Dec 7 2018, 3:53 PM
stella.stamenova closed D55451: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
Dec 7 2018, 3:53 PM
stella.stamenova committed rLLDB348664: [lit] Fix case-insensitive test.
[lit] Fix case-insensitive test
Dec 7 2018, 3:33 PM
stella.stamenova committed rL348664: [lit] Fix case-insensitive test.
[lit] Fix case-insensitive test
Dec 7 2018, 3:33 PM
stella.stamenova created D55457: Do not use PATH_MAX with SmallString.
Dec 7 2018, 1:15 PM
stella.stamenova created D55451: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
Dec 7 2018, 12:33 PM