Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (229 w, 3 h)

Recent Activity

Yesterday

stella.stamenova committed rGa9bef0707db1: [clang-format] Fix incorrect isspace input (NFC) (authored by kevcadieux).
[clang-format] Fix incorrect isspace input (NFC)
Wed, Jun 29, 10:21 AM · Restricted Project, Restricted Project
stella.stamenova closed D128786: [clang-format] Fix incorrect isspace input (NFC).
Wed, Jun 29, 10:21 AM · Restricted Project, Restricted Project
stella.stamenova added a comment to D127999: [lldb] fix stepping through POSIX trampolines.

Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20566

Wed, Jun 29, 9:44 AM · Restricted Project, Restricted Project

Tue, Jun 28

stella.stamenova committed rGac521d9ecde7: [mlir] Leverage CMake interface libraries for mlir python (authored by stella.stamenova).
[mlir] Leverage CMake interface libraries for mlir python
Tue, Jun 28, 10:44 AM · Restricted Project, Restricted Project
stella.stamenova closed D128230: [mlir] Leverage CMake interface libraries for mlir python.
Tue, Jun 28, 10:43 AM · Restricted Project, Restricted Project

Fri, Jun 24

stella.stamenova added a comment to D128230: [mlir] Leverage CMake interface libraries for mlir python.

Thank you for this. As we discussed on Discord, I didn't know about the inheritable sources on interface libraries, and that simplifies things. A couple of comments for my own education, but otherwise looks good.

Have you happened to have tested this with a downstream yet?

Fri, Jun 24, 9:42 AM · Restricted Project, Restricted Project
stella.stamenova updated the summary of D128230: [mlir] Leverage CMake interface libraries for mlir python.
Fri, Jun 24, 9:42 AM · Restricted Project, Restricted Project

Wed, Jun 22

stella.stamenova added a comment to D127436: [lldb] Resolve exe location for `target create`.

This broke the Windows LLDB bot:

Wed, Jun 22, 10:04 AM · Restricted Project, Restricted Project

Mon, Jun 20

stella.stamenova requested review of D128230: [mlir] Leverage CMake interface libraries for mlir python.
Mon, Jun 20, 3:21 PM · Restricted Project, Restricted Project

Thu, Jun 16

stella.stamenova added a comment to D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.

@stella.stamenova, I've just tried that compile command with several versions of gcc, including g++ (GCC) 8.5.0 on CentOS and got no error Sadly I couldn't install 7.3.1. Could you try again in top of tree?

Thu, Jun 16, 8:28 AM · Restricted Project, Restricted Project

Wed, Jun 15

stella.stamenova added a comment to D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.

yes, i'm trying to fix it now. Thanks!

Wed, Jun 15, 4:43 PM · Restricted Project, Restricted Project
stella.stamenova committed rG36e7c9a450db: Revert "[lld-macho] Group undefined symbol diagnostics by symbol" (authored by stella.stamenova).
Revert "[lld-macho] Group undefined symbol diagnostics by symbol"
Wed, Jun 15, 3:44 PM · Restricted Project
stella.stamenova added a reverting change for rGd61341768cf0: [lld-macho] Group undefined symbol diagnostics by symbol: rG36e7c9a450db: Revert "[lld-macho] Group undefined symbol diagnostics by symbol".
Wed, Jun 15, 3:44 PM · Restricted Project
stella.stamenova added a reverting change for D127753: [lld-macho] Group undefined symbol diagnostics by symbol: rG36e7c9a450db: Revert "[lld-macho] Group undefined symbol diagnostics by symbol".
Wed, Jun 15, 3:44 PM · Restricted Project, Restricted Project, Restricted Project
stella.stamenova added a comment to D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.

These changes (the set of [trace][intelpt] changes) broke the windows lldb bot. It's most likely this particular change, but it could be one of the others. Unfortunately, the bot had just been broken by https://reviews.llvm.org/D127882, so it didn't show the failure until that was reverted:

Wed, Jun 15, 1:24 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rGf3250da1b94f: [lldb/Fuzzer] Create ninja target for target fuzzer: rGb10579d0b519: Revert "[lldb/Fuzzer] Create ninja target for target fuzzer".
Wed, Jun 15, 12:41 PM · Restricted Project
stella.stamenova committed rGb10579d0b519: Revert "[lldb/Fuzzer] Create ninja target for target fuzzer" (authored by stella.stamenova).
Revert "[lldb/Fuzzer] Create ninja target for target fuzzer"
Wed, Jun 15, 12:41 PM · Restricted Project
stella.stamenova added a reverting change for D127882: [lldb/Fuzzer] Create ninja target for target fuzzer : rGb10579d0b519: Revert "[lldb/Fuzzer] Create ninja target for target fuzzer".
Wed, Jun 15, 12:41 PM · Restricted Project, Restricted Project

Wed, Jun 1

stella.stamenova committed rGa4425cc91460: [ccache] Add Windows support (authored by NathanielMcVicar).
[ccache] Add Windows support
Wed, Jun 1, 11:36 AM · Restricted Project, Restricted Project
stella.stamenova closed D126575: [ccache] Add Windows support.
Wed, Jun 1, 11:35 AM · Restricted Project, Restricted Project

Tue, May 31

stella.stamenova accepted D126575: [ccache] Add Windows support.

LGTM

Tue, May 31, 4:13 PM · Restricted Project, Restricted Project
stella.stamenova committed rG8fb1bef60f0b: [windows] Remove unused pybind exception params (authored by NathanielMcVicar).
[windows] Remove unused pybind exception params
Tue, May 31, 12:37 PM · Restricted Project, Restricted Project
stella.stamenova closed D126683: [windows] Remove unused pybind exception params.
Tue, May 31, 12:37 PM · Restricted Project, Restricted Project

May 26 2022

stella.stamenova committed rG75acec818e3a: [lldb] Fix enums-layout test on Windows (authored by stella.stamenova).
[lldb] Fix enums-layout test on Windows
May 26 2022, 12:18 PM · Restricted Project

May 23 2022

stella.stamenova committed rG12bae5f3e2d2: Remove duplicate fields in RAGreedy (authored by qunyanm).
Remove duplicate fields in RAGreedy
May 23 2022, 1:09 PM · Restricted Project, Restricted Project
stella.stamenova closed D125926: Remove duplicate fields in RAGreedy.
May 23 2022, 1:08 PM · Restricted Project, Restricted Project
stella.stamenova committed rGe7afa23366f5: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests (authored by stella.stamenova).
[mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests
May 23 2022, 12:39 PM · Restricted Project, Restricted Project
stella.stamenova closed D126011: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests.
May 23 2022, 12:38 PM · Restricted Project, Restricted Project

May 19 2022

stella.stamenova updated the diff for D126011: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests.

Make clang-format happy

May 19 2022, 2:55 PM · Restricted Project, Restricted Project
stella.stamenova added a reviewer for D126011: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests: stellaraccident.
May 19 2022, 1:08 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D126011: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests.
May 19 2022, 1:07 PM · Restricted Project, Restricted Project
stella.stamenova committed rG33b7df8c1fb6: [mlir] Remove unused properties from the standalone example's lit configuration (authored by stella.stamenova).
[mlir] Remove unused properties from the standalone example's lit configuration
May 19 2022, 12:55 PM · Restricted Project, Restricted Project
stella.stamenova closed D125132: [mlir] Remove unused properties from the standalone example's lit configuration.
May 19 2022, 12:55 PM · Restricted Project, Restricted Project

May 9 2022

stella.stamenova committed rG784a5bccfd2b: [mlir] Fix python bindings build on Windows in Debug (authored by stella.stamenova).
[mlir] Fix python bindings build on Windows in Debug
May 9 2022, 7:48 PM · Restricted Project, Restricted Project
stella.stamenova closed D125284: [mlir] Fix python bindings build on Windows in Debug.
May 9 2022, 7:48 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D125284: [mlir] Fix python bindings build on Windows in Debug.

I am glad that an actual Windows dev (versus someone who just occasionally plays one on TV) is looking at this. I've never understood the windows debug/release/runtime version dichotomies when not just working on a stock VS based project that automatically does the right thing.

I'm fine with landing if we special case the header like I suggest. Otherwise, open to discuss more.

May 9 2022, 7:37 PM · Restricted Project, Restricted Project
stella.stamenova updated the diff for D125284: [mlir] Fix python bindings build on Windows in Debug.
May 9 2022, 7:33 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D125284: [mlir] Fix python bindings build on Windows in Debug.
May 9 2022, 6:07 PM · Restricted Project, Restricted Project
stella.stamenova committed rZORG024b5581d445: [mlir,win] Enable python bindings on the Windows mlir bot (authored by stella.stamenova).
[mlir,win] Enable python bindings on the Windows mlir bot
May 9 2022, 11:24 AM · Restricted Project
stella.stamenova closed D125134: [mlir,win] Enable python bindings on the Windows mlir bot.
May 9 2022, 11:24 AM · Restricted Project
stella.stamenova added a reviewer for D125132: [mlir] Remove unused properties from the standalone example's lit configuration: stellaraccident.
May 9 2022, 11:19 AM · Restricted Project, Restricted Project
stella.stamenova committed rG057863a9bc31: [mlir] Fix build & test of mlir python bindings on Windows (authored by stella.stamenova).
[mlir] Fix build & test of mlir python bindings on Windows
May 9 2022, 11:11 AM · Restricted Project, Restricted Project
stella.stamenova closed D125122: [mlir] Fix build & test of mlir python bindings on Windows.
May 9 2022, 11:11 AM · Restricted Project, Restricted Project

May 7 2022

stella.stamenova added inline comments to D125122: [mlir] Fix build & test of mlir python bindings on Windows.
May 7 2022, 12:28 PM · Restricted Project, Restricted Project
stella.stamenova updated the diff for D125122: [mlir] Fix build & test of mlir python bindings on Windows.
May 7 2022, 10:59 AM · Restricted Project, Restricted Project

May 6 2022

stella.stamenova added a comment to D125122: [mlir] Fix build & test of mlir python bindings on Windows.

I'll need to check when I'm back online, but I could have sworn we had this enabled on a bot somewhere (I've broken it before). But in any case, +1 on more coverage.

May 6 2022, 3:17 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D125134: [mlir,win] Enable python bindings on the Windows mlir bot.
May 6 2022, 2:52 PM · Restricted Project
stella.stamenova added a comment to D125122: [mlir] Fix build & test of mlir python bindings on Windows.

Thanks for the fixes. I'm out today but will have a detailed look this weekend. Over time, I've tried to keep these things working for Windows but we must be building with a Windows setup that doesn't tickle the weird bits.

One request: can we special case the copy_if_different thing for Windows only. Symlinks are pretty convenient for dev because you can just edit/run, and I'd prefer to not regress that too account for this weird Windows-ism.

May 6 2022, 2:48 PM · Restricted Project, Restricted Project
stella.stamenova updated the diff for D125122: [mlir] Fix build & test of mlir python bindings on Windows.
May 6 2022, 2:47 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D125132: [mlir] Remove unused properties from the standalone example's lit configuration.
May 6 2022, 2:13 PM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D125122: [mlir] Fix build & test of mlir python bindings on Windows.
May 6 2022, 1:24 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D125122: [mlir] Fix build & test of mlir python bindings on Windows.
May 6 2022, 12:52 PM · Restricted Project, Restricted Project

May 5 2022

stella.stamenova committed rGd4555698f89a: [mlir] Fix the names of exported functions (authored by stella.stamenova).
[mlir] Fix the names of exported functions
May 5 2022, 1:47 PM · Restricted Project, Restricted Project
stella.stamenova closed D124891: [mlir] Fix the names of exported functions.
May 5 2022, 1:46 PM · Restricted Project, Restricted Project
stella.stamenova updated the diff for D124891: [mlir] Fix the names of exported functions.
May 5 2022, 12:01 PM · Restricted Project, Restricted Project

May 3 2022

stella.stamenova added a comment to D124891: [mlir] Fix the names of exported functions.

@mehdi_amini : This patch does not quite work because of the built-in calling convention (https://github.com/llvm/llvm-project-staging/blob/cc926dc3a87af7023aa9b6c392347a0a8ed6949b/mlir/docs/LLVMDialectMemRefConvention.md). Was the goal with the clang-tidy change to also change the convention? I could fix it the other way and undo the clang-tidy to these specific functions instead. This would be a smaller change.

May 3 2022, 4:49 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D124891: [mlir] Fix the names of exported functions.
May 3 2022, 4:24 PM · Restricted Project, Restricted Project
stella.stamenova committed rZORGe692d26539b1: [mlir, win] Set LLVM_ENABLE_WERROR=ON on the mlir-windows bot (authored by stella.stamenova).
[mlir, win] Set LLVM_ENABLE_WERROR=ON on the mlir-windows bot
May 3 2022, 2:19 PM · Restricted Project
stella.stamenova closed D124864: [mlir, win] Set LLVM_ENABLE_WERROR=ON on the mlir-windows bot.
May 3 2022, 2:19 PM · Restricted Project
stella.stamenova committed rG5f14aee3bb53: [mlir] Fix Visual Studio warnings (authored by stella.stamenova).
[mlir] Fix Visual Studio warnings
May 3 2022, 2:14 PM · Restricted Project, Restricted Project
stella.stamenova closed D124862: [mlir] Fix Visual Studio warnings.
May 3 2022, 2:13 PM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D124862: [mlir] Fix Visual Studio warnings.
May 3 2022, 10:28 AM · Restricted Project, Restricted Project
stella.stamenova requested review of D124864: [mlir, win] Set LLVM_ENABLE_WERROR=ON on the mlir-windows bot.
May 3 2022, 10:26 AM · Restricted Project
stella.stamenova requested review of D124862: [mlir] Fix Visual Studio warnings.
May 3 2022, 10:19 AM · Restricted Project, Restricted Project

May 2 2022

stella.stamenova added a comment to D124075: [mlir][PDLL] Add support for generating PDL patterns from PDLL at build time.

This change introduced a race condition in the mlir build. We're now occasionally seeing:

May 2 2022, 12:20 PM · Restricted Project, Restricted Project

Apr 26 2022

stella.stamenova accepted D124479: Fix missing import for test.
Apr 26 2022, 3:06 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D121631: Introduce new symbol on-demand for debug info.

Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/18228

Apr 26 2022, 12:27 PM · Restricted Project, Restricted Project

Apr 25 2022

stella.stamenova added a comment to D124007: [mlir] Connect Transform dialect to PDL.

We are seeing an error when building on Ubuntu with warnings treated as errors after this change:

Apr 25 2022, 10:56 AM · Restricted Project, Restricted Project

Apr 15 2022

stella.stamenova added a reverting change for rG3131f808243a: [mlir] Refactor LICM into a utility: rG353f0a8e43f7: Revert "[mlir] Refactor LICM into a utility".
Apr 15 2022, 5:10 PM · Restricted Project, Restricted Project
stella.stamenova committed rG353f0a8e43f7: Revert "[mlir] Refactor LICM into a utility" (authored by stella.stamenova).
Revert "[mlir] Refactor LICM into a utility"
Apr 15 2022, 5:10 PM · Restricted Project, Restricted Project

Mar 23 2022

stella.stamenova committed rG4907cfe2cb67: [mlir][MemRef] Fix warning on unsigned comparison (authored by NathanielMcVicar).
[mlir][MemRef] Fix warning on unsigned comparison
Mar 23 2022, 12:55 PM · Restricted Project
stella.stamenova closed D122333: [mlir][MemRef] Fix warning on unsigned comparison.
Mar 23 2022, 12:55 PM · Restricted Project, Restricted Project

Mar 15 2022

stella.stamenova committed rG7ecb7efc8989: [MLIR] UnknownLoc on Inlinable Calls in LLVMIR Translation (authored by manbearian).
[MLIR] UnknownLoc on Inlinable Calls in LLVMIR Translation
Mar 15 2022, 2:51 PM · Restricted Project
stella.stamenova closed D121633: [MLIR] UnknownLoc on Inlinable Calls in LLVMIR Translation.
Mar 15 2022, 2:51 PM · Restricted Project, Restricted Project

Mar 14 2022

stella.stamenova committed rG8bd1988e74f2: [lldb] Skip Test11588 on Windows (authored by stella.stamenova).
[lldb] Skip Test11588 on Windows
Mar 14 2022, 9:27 AM · Restricted Project

Mar 4 2022

stella.stamenova added a comment to D120852: [mlir] Fix gcc -std=c++17 compilation..

I think this broke the windows mlir bot: https://lab.llvm.org/buildbot/#/builders/13/builds/17954/steps/6/logs/stdio

Mar 4 2022, 1:11 PM · Restricted Project, Restricted Project

Mar 2 2022

stella.stamenova added a comment to D119146: [lldb/Platform] Prepare decouple instance and plugin names.

It looks like this broke the windows lldb bot:

Mar 2 2022, 11:26 AM · Restricted Project, Restricted Project

Mar 1 2022

stella.stamenova committed rGc26fcd1ab8af: [MLIR] [Arith] [NFC] Remove switch statement default label due to warning (authored by max-kudr).
[MLIR] [Arith] [NFC] Remove switch statement default label due to warning
Mar 1 2022, 3:25 PM · Restricted Project
stella.stamenova closed D120730: [MLIR] [Arith] [NFC] Remove switch statement default label due to warning.
Mar 1 2022, 3:25 PM · Restricted Project, Restricted Project
stella.stamenova accepted D120730: [MLIR] [Arith] [NFC] Remove switch statement default label due to warning.

LGTM

Mar 1 2022, 2:08 PM · Restricted Project, Restricted Project

Feb 9 2022

stella.stamenova added a comment to D113498: [lldb] Constant-resolve operands to `getelementptr`.

It looks like the new test is failing on the Windows bot:

Feb 9 2022, 11:00 AM · Restricted Project

Feb 3 2022

stella.stamenova added a comment to D118866: [LLDB] Fix window bot failure.

It looks like there's a failure that was previously hidden by the unexpected passes:

Feb 3 2022, 12:21 PM · Restricted Project
stella.stamenova added inline comments to D118866: [LLDB] Fix window bot failure.
Feb 3 2022, 11:21 AM · Restricted Project
stella.stamenova accepted D118866: [LLDB] Fix window bot failure.

LGTM, I think there might be a couple more places to remove the xfail, but otherwise ship it!

Feb 3 2022, 11:08 AM · Restricted Project

Feb 2 2022

stella.stamenova added a comment to D118866: [LLDB] Fix window bot failure.

They should correspond to these files:

Feb 2 2022, 5:23 PM · Restricted Project
stella.stamenova added a comment to D118750: [LLDB] add sub register enums on x64 Windows.

This broke the windows bot in the best way possible - by making some tests pass now that didn't use to. Could you un-xfail those too?

Feb 2 2022, 4:03 PM · Restricted Project

Jan 31 2022

stella.stamenova abandoned D117267: [lldb] Add support for choosing which checks to run on lldb builders.

Disabling the watchpoint tests was sufficient to get the buildbot happy, so we no longer have need of this.

Jan 31 2022, 4:26 PM
stella.stamenova abandoned D118568: [lldb, win] Don't put quotes around the skipped category argument.
Jan 31 2022, 12:35 PM

Jan 30 2022

stella.stamenova requested review of D118568: [lldb, win] Don't put quotes around the skipped category argument.
Jan 30 2022, 8:48 AM

Jan 28 2022

stella.stamenova committed rG738d73fbf4ed: [lldb] Update the lldb build instructions on Windows (authored by stella.stamenova).
[lldb] Update the lldb build instructions on Windows
Jan 28 2022, 10:19 AM
stella.stamenova closed D118425: [lldb] Update the lldb build instructions on Windows.
Jan 28 2022, 10:19 AM · Restricted Project
stella.stamenova accepted D114639: Raise the minimum Visual Studio version to VS2019.
Jan 28 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
stella.stamenova committed rGc0861fcbb901: [mlir] Only build mlir-cpu-runner when the native arch is targeted (authored by stella.stamenova).
[mlir] Only build mlir-cpu-runner when the native arch is targeted
Jan 28 2022, 10:10 AM
stella.stamenova closed D118422: [mlir] Only build mlir-cpu-runner when the native arch is targeted.
Jan 28 2022, 10:10 AM · Restricted Project
stella.stamenova added inline comments to D114639: Raise the minimum Visual Studio version to VS2019.
Jan 28 2022, 9:54 AM · Restricted Project, Restricted Project, Restricted Project
stella.stamenova updated the diff for D118425: [lldb] Update the lldb build instructions on Windows.

Add more details for developer command prompt

Jan 28 2022, 9:51 AM · Restricted Project

Jan 27 2022

stella.stamenova requested review of D118425: [lldb] Update the lldb build instructions on Windows.
Jan 27 2022, 7:20 PM · Restricted Project
stella.stamenova added inline comments to D114639: Raise the minimum Visual Studio version to VS2019.
Jan 27 2022, 7:16 PM · Restricted Project, Restricted Project, Restricted Project
stella.stamenova added inline comments to D118422: [mlir] Only build mlir-cpu-runner when the native arch is targeted.
Jan 27 2022, 6:49 PM · Restricted Project
stella.stamenova added a reviewer for D118422: [mlir] Only build mlir-cpu-runner when the native arch is targeted: mehdi_amini.
Jan 27 2022, 5:29 PM · Restricted Project