Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (294 w, 4 d)

Recent Activity

Mar 14 2023

stella.stamenova committed rZORG335c2f1822f6: [mlir] Change the notification list for the windows mlir bot (authored by stella.stamenova).
[mlir] Change the notification list for the windows mlir bot
Mar 14 2023, 2:49 PM · Restricted Project
stella.stamenova added a comment to D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime.

Oh I still saw that one running a few days back! @stella.stamenova in the review you mention a second windows lldb bot, is it x86 as well? I don't see it in https://lab.llvm.org/buildbot/#/console

Mar 14 2023, 10:48 AM · Restricted Project, Restricted Project

Mar 10 2023

stella.stamenova committed rZORGacb6223670a4: Remove lldb-x64-windows-ninja bot (authored by stella.stamenova).
Remove lldb-x64-windows-ninja bot
Mar 10 2023, 3:31 PM · Restricted Project
stella.stamenova closed D145830: Remove lldb-x64-windows-ninja bot.
Mar 10 2023, 3:31 PM · Restricted Project
stella.stamenova requested review of D145830: Remove lldb-x64-windows-ninja bot.
Mar 10 2023, 2:25 PM · Restricted Project
stella.stamenova committed rZORG3a8f8431d368: [mlir] Add a new mlir buildbot on s390x with werror enabled (authored by stella.stamenova).
[mlir] Add a new mlir buildbot on s390x with werror enabled
Mar 10 2023, 9:19 AM · Restricted Project
stella.stamenova closed D145713: [mlir] Add a new mlir buildbot on s390x with werror enabled.
Mar 10 2023, 9:19 AM · Restricted Project
stella.stamenova committed rG85fe8e01a000: [mlir] Add mlir::LLVM::FastmathFlags to LLVM instrinsic vector reductions (authored by bmyerz).
[mlir] Add mlir::LLVM::FastmathFlags to LLVM instrinsic vector reductions
Mar 10 2023, 9:15 AM · Restricted Project, Restricted Project
stella.stamenova closed D145692: [mlir] Add mlir::LLVM::FastmathFlags to LLVM instrinsic vector reductions.
Mar 10 2023, 9:14 AM · Restricted Project, Restricted Project

Mar 9 2023

stella.stamenova updated the diff for D145713: [mlir] Add a new mlir buildbot on s390x with werror enabled.
Mar 9 2023, 4:50 PM · Restricted Project
stella.stamenova added inline comments to D145713: [mlir] Add a new mlir buildbot on s390x with werror enabled.
Mar 9 2023, 4:50 PM · Restricted Project
stella.stamenova requested review of D145713: [mlir] Add a new mlir buildbot on s390x with werror enabled.
Mar 9 2023, 11:22 AM · Restricted Project

Mar 6 2023

stella.stamenova added a comment to D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers.

Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and revert the changes to bring it back to green.

Ah thanks for pointing it out. Thought I had fixed it with https://reviews.llvm.org/rG96e39fdbb90b26191fc79b6226f299e3c10e559b

Will check on my Windows machine. But feel free to revert, since I'm only going to be able to look at it tomorrow

Mar 6 2023, 5:12 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers.

Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and revert the changes to bring it back to green.

Mar 6 2023, 4:57 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess.

Looks like this change broke the windows lldb build: https://lab.llvm.org/buildbot/#/builders/83/builds/29801

Mar 6 2023, 4:54 PM · Restricted Project, Restricted Project

Mar 1 2023

stella.stamenova added a comment to D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop.

Looks like the new test is failing on the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29680. The buildbot was already red because of TestCommandScript.py, so you might have missed this.

Mar 1 2023, 9:04 AM · Restricted Project, Restricted Project

Feb 14 2023

stella.stamenova added a comment to D143738: [mlir][Vector] Significantly improve VectorToGPU.cpp.

Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/32020

Feb 14 2023, 5:39 PM · Restricted Project, Restricted Project

Feb 13 2023

stella.stamenova added a comment to D143800: [mlir][sparse] Factoring out SparseTensorType class.

One thing that we could do is disable werror on the buildbot for the moment and then re-enable it. It's not terribly difficult, but it relies on buildbot master being re-started to take effect, so it might not even take effect before the warnings are fixed.

Feb 13 2023, 5:12 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D143800: [mlir][sparse] Factoring out SparseTensorType class.

@stella.stamenova This patch introduces some deprecation warnings, which are intended for other folks on our team to help track down the offending use-sites so they can fix them. Is there anything I need to do to ensure the LLVM buildbot doesn't reject this patch because of the new warnings?

Feb 13 2023, 4:39 PM · Restricted Project, Restricted Project

Feb 7 2023

stella.stamenova committed rG97fbbd657f9a: [mlir] Relax version requirement for PyYAML in mlir (authored by stella.stamenova).
[mlir] Relax version requirement for PyYAML in mlir
Feb 7 2023, 2:25 PM · Restricted Project, Restricted Project
stella.stamenova closed D143523: [mlir] Relax version requirement for PyYAML in mlir.
Feb 7 2023, 2:25 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D143523: [mlir] Relax version requirement for PyYAML in mlir.
Feb 7 2023, 12:59 PM · Restricted Project, Restricted Project
stella.stamenova committed rGdc3d0b266bd9: [lit] don't skip test times when executions are instantaneous (authored by ashay).
[lit] don't skip test times when executions are instantaneous
Feb 7 2023, 11:28 AM · Restricted Project, Restricted Project
stella.stamenova closed D143504: [lit] don't skip test times when executions are instantaneous.
Feb 7 2023, 11:28 AM · Restricted Project, Restricted Project
stella.stamenova accepted D143504: [lit] don't skip test times when executions are instantaneous.

LGTM

Feb 7 2023, 11:24 AM · Restricted Project, Restricted Project

Feb 6 2023

stella.stamenova added a comment to D143240: [mlir][py] Fix infer return type invocation for variadics.

Looks like this caused a failure in the mlir buildbot due to an unused variable: https://lab.llvm.org/buildbot/#/builders/13/builds/31682

Feb 6 2023, 5:38 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D135128: [clang][cli] Simplify repetitive macro invocations.
Feb 6 2023, 5:11 PM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2023

stella.stamenova committed rGca174f12c45b: [mlir] Pin for the PyPi requirements for mlir (authored by stella.stamenova).
[mlir] Pin for the PyPi requirements for mlir
Feb 1 2023, 10:26 AM · Restricted Project, Restricted Project
stella.stamenova closed D142563: [mlir] Pin for the PyPi requirements for mlir.
Feb 1 2023, 10:26 AM · Restricted Project, Restricted Project

Jan 25 2023

stella.stamenova requested review of D142563: [mlir] Pin for the PyPi requirements for mlir.
Jan 25 2023, 9:16 AM · Restricted Project, Restricted Project

Jan 17 2023

stella.stamenova committed rGd23516e9ad47: [mlir] fix dereferencing of optional sym_name attribute (authored by ashay).
[mlir] fix dereferencing of optional sym_name attribute
Jan 17 2023, 10:57 AM · Restricted Project, Restricted Project
stella.stamenova closed D141941: [mlir] fix dereferencing of optional sym_name attribute.
Jan 17 2023, 10:56 AM · Restricted Project, Restricted Project
stella.stamenova accepted D141941: [mlir] fix dereferencing of optional sym_name attribute.
Jan 17 2023, 10:51 AM · Restricted Project, Restricted Project

Jan 12 2023

stella.stamenova accepted D141622: [lit] don't skip test times when executions are instantaneous.

Thanks for fixing this long-standing bug!

Jan 12 2023, 11:11 AM · Restricted Project, Restricted Project

Dec 23 2022

stella.stamenova committed rG5759d9467cbe: Revert "Apply shortened printing/parsing form to linalg.reduce." (authored by stella.stamenova).
Revert "Apply shortened printing/parsing form to linalg.reduce."
Dec 23 2022, 5:32 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG281c2d49c929: Apply shortened printing/parsing form to linalg.reduce.: rG5759d9467cbe: Revert "Apply shortened printing/parsing form to linalg.reduce.".
Dec 23 2022, 5:32 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D140622: Apply shortened printing/parsing form to linalg.reduce.: rG5759d9467cbe: Revert "Apply shortened printing/parsing form to linalg.reduce.".
Dec 23 2022, 5:31 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG85e38d7cd670: [mlir][GPU] Add known_block_size and known_grid_size to gpu.func: rG828b4762caf4: Revert "[mlir][GPU] Add known_block_size and known_grid_size to gpu.func".
Dec 23 2022, 5:30 PM · Restricted Project, Restricted Project
stella.stamenova committed rG828b4762caf4: Revert "[mlir][GPU] Add known_block_size and known_grid_size to gpu.func" (authored by stella.stamenova).
Revert "[mlir][GPU] Add known_block_size and known_grid_size to gpu.func"
Dec 23 2022, 5:30 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D139865: [mlir][GPU] Add known_block_size and known_grid_size to gpu.func: rG828b4762caf4: Revert "[mlir][GPU] Add known_block_size and known_grid_size to gpu.func".
Dec 23 2022, 5:30 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D140622: Apply shortened printing/parsing form to linalg.reduce..

Looks like this added a failure to the already red mlir windows buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/30167

Dec 23 2022, 3:33 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D139865: [mlir][GPU] Add known_block_size and known_grid_size to gpu.func.

Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/30140

Dec 23 2022, 3:29 PM · Restricted Project, Restricted Project

Dec 12 2022

stella.stamenova added a comment to D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number..

@rahmanl would it be possible to address the windows failures or revert this commit while someone investigates?

Dec 12 2022, 4:56 PM · Restricted Project, Restricted Project

Dec 8 2022

stella.stamenova added a comment to D139447: [mlir] FunctionOpInterface: make get/setFunctionType interface methods.

It should be fixed at HEAD now. The fix was sent out shortly after this patch.

Dec 8 2022, 4:41 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D139447: [mlir] FunctionOpInterface: make get/setFunctionType interface methods.

It looks like this change broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/29443

Dec 8 2022, 3:42 PM · Restricted Project, Restricted Project

Dec 5 2022

stella.stamenova added a comment to D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted.

Looks like this broke the windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/26822

Dec 5 2022, 5:37 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D138627: [mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a SparseTensorDescriptor class..

@Peiming : I reverted your change because it broke multiple buildbots - windows and gcc included. I see that you've re-committed it. Did you make sure to address all three build breaks that were reported including the one @vzakhari pointed out? In cases like this, please make sure NOT to recommit your changes without making sure that all build breaks are addressed as it is disruptive to have buildbots that are broken especially when a change is identified as the source.

Dec 5 2022, 5:32 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG8a7e69d145ff: [mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a…: rG10033a179f0c: Revert "[mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a….
Dec 5 2022, 5:21 PM · Restricted Project, Restricted Project
stella.stamenova committed rG10033a179f0c: Revert "[mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a… (authored by stella.stamenova).
Revert "[mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a…
Dec 5 2022, 5:21 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D138627: [mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a SparseTensorDescriptor class.: rG10033a179f0c: Revert "[mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a….
Dec 5 2022, 5:21 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D138627: [mlir][sparse] Refactoring: abstract sparse tensor memory scheme into a SparseTensorDescriptor class..

@Peiming, this patch breaks the flang build.

It is not flang specific issue, though. The following gcc buildbot fails: https://lab.llvm.org/buildbot/#/builders/160/builds/13724

Dec 5 2022, 3:51 PM · Restricted Project, Restricted Project

Nov 17 2022

stella.stamenova added a comment to D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems].

Looks like the windows lldb bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/26083

Nov 17 2022, 10:51 AM · Restricted Project, Restricted Project

Nov 16 2022

stella.stamenova added a comment to D137998: [mlir][sparse] Macros to clean up StridedMemRefType in the SparseTensorRuntime.

@stella.stamenova I just posted D138167. Can you check to see if that resolves things on your side?

Nov 16 2022, 5:39 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems].

Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/26042

Nov 16 2022, 5:05 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D137998: [mlir][sparse] Macros to clean up StridedMemRefType in the SparseTensorRuntime.

@stella.stamenova As a heads-up, I'm going to land this now. If you encounter any other issues from LLVM's buildbot, just let me know and I'm more than happy to address them promptly.

Nov 16 2022, 4:58 PM · Restricted Project, Restricted Project

Nov 14 2022

stella.stamenova added a comment to D135128: [clang][cli] Simplify repetitive macro invocations.

@stella.stamenova Any updates?

Nov 14 2022, 4:59 PM · Restricted Project, Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG6c22dad9c2b7: [mlir][sparse] Macros to clean up StridedMemRefType in the SparseTensorRuntime: rGaf5c307945f8: Revert "[mlir][sparse] Macros to clean up StridedMemRefType in the….
Nov 14 2022, 4:19 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG92bc3fb5b1f2: [mlir][sparse] move SparseTensorReader functions into the _mlir_ciface_ section: rGaf5c307945f8: Revert "[mlir][sparse] Macros to clean up StridedMemRefType in the….
Nov 14 2022, 4:19 PM · Restricted Project, Restricted Project
stella.stamenova committed rGaf5c307945f8: Revert "[mlir][sparse] Macros to clean up StridedMemRefType in the… (authored by stella.stamenova).
Revert "[mlir][sparse] Macros to clean up StridedMemRefType in the…
Nov 14 2022, 4:19 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D137737: [mlir][sparse] move SparseTensorReader functions into the _mlir_ciface_ section: rGaf5c307945f8: Revert "[mlir][sparse] Macros to clean up StridedMemRefType in the….
Nov 14 2022, 4:19 PM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D137735: [mlir][sparse] Macros to clean up StridedMemRefType in the SparseTensorRuntime: rGaf5c307945f8: Revert "[mlir][sparse] Macros to clean up StridedMemRefType in the….
Nov 14 2022, 4:19 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D137735: [mlir][sparse] Macros to clean up StridedMemRefType in the SparseTensorRuntime.

This appears to have broken the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/28298

Nov 14 2022, 2:52 PM · Restricted Project, Restricted Project

Nov 12 2022

stella.stamenova added a comment to D133366: [lldb] Fix SBFileSpec.fullpath for Windows.

Ugh, the test that is failing uses windows paths but runs on both windows and non-windows machines. I will revert this and the two fix commits.

Nov 12 2022, 2:20 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D133366: [lldb] Fix SBFileSpec.fullpath for Windows.

This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854

Nov 12 2022, 12:43 PM · Restricted Project, Restricted Project

Nov 7 2022

stella.stamenova added a comment to rG99171078bb9b: Revert "[mlir][sparse] extend foreach operation to accept reduction arguments.".

I don't think the revert is correct, the warning should be introduced by D137442 ( and it should have been fixed)

Nov 7 2022, 11:07 AM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG53d5d3401120: [mlir][sparse] extend foreach operation to accept reduction arguments.: rG99171078bb9b: Revert "[mlir][sparse] extend foreach operation to accept reduction arguments.".
Nov 7 2022, 9:35 AM · Restricted Project, Restricted Project
stella.stamenova committed rG99171078bb9b: Revert "[mlir][sparse] extend foreach operation to accept reduction arguments." (authored by stella.stamenova).
Revert "[mlir][sparse] extend foreach operation to accept reduction arguments."
Nov 7 2022, 9:35 AM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D137463: [mlir][sparse] extend foreach operation to accept reduction arguments.: rG99171078bb9b: Revert "[mlir][sparse] extend foreach operation to accept reduction arguments.".
Nov 7 2022, 9:35 AM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG70508b614e64: [mlir][sparse] fix sparse tensor rewriting patterns that do not propagate…: rGec224e3b6804: Revert "[mlir][sparse] fix sparse tensor rewriting patterns that do not….
Nov 7 2022, 9:01 AM · Restricted Project, Restricted Project
stella.stamenova committed rGec224e3b6804: Revert "[mlir][sparse] fix sparse tensor rewriting patterns that do not… (authored by stella.stamenova).
Revert "[mlir][sparse] fix sparse tensor rewriting patterns that do not…
Nov 7 2022, 9:01 AM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D137468: [mlir][sparse] fix sparse tensor rewriting patterns that do not propagate sparse tensor SSA properly.: rGec224e3b6804: Revert "[mlir][sparse] fix sparse tensor rewriting patterns that do not….
Nov 7 2022, 9:01 AM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for rG838389780e56: [mlir][sparse] support Parallel for/reduction.: rGa2c4ca50caf4: Revert "[mlir][sparse] support Parallel for/reduction.".
Nov 7 2022, 8:51 AM · Restricted Project, Restricted Project
stella.stamenova committed rGa2c4ca50caf4: Revert "[mlir][sparse] support Parallel for/reduction." (authored by stella.stamenova).
Revert "[mlir][sparse] support Parallel for/reduction."
Nov 7 2022, 8:51 AM · Restricted Project, Restricted Project
stella.stamenova added a reverting change for D135927: [mlir][sparse] support Parallel for/reduction.: rGa2c4ca50caf4: Revert "[mlir][sparse] support Parallel for/reduction.".
Nov 7 2022, 8:50 AM · Restricted Project, Restricted Project

Nov 2 2022

stella.stamenova added a comment to D135128: [clang][cli] Simplify repetitive macro invocations.

This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829

Thanks for the heads-up. Who would be the best person to look into this? Seems like this patch exposes an UB in Windows Kits (https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c5105).

Nov 2 2022, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
stella.stamenova added a comment to D135128: [clang][cli] Simplify repetitive macro invocations.

This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829

Nov 2 2022, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Nov 1 2022

stella.stamenova added a comment to D135622: [lldb] Add a "diagnostics dump" command.

The newly added test is failing on the windows buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/25446

Nov 1 2022, 9:19 AM · Restricted Project, Restricted Project

Oct 31 2022

stella.stamenova added a comment to D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName.

Looks like in addition to the Linux failure, this also broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio

Oct 31 2022, 11:08 AM · Restricted Project, Restricted Project

Oct 20 2022

stella.stamenova added a comment to D133416: [lit] Test changes to make it work with bazel.

This change has caused intermittent failures in reorder.py on Windows. I wonder why the changes to the test were necessary and if we can update it so it works consistently on Windows as well as with bazel:

Oct 20 2022, 12:20 PM · Restricted Project, Restricted Project, Restricted Project

Oct 17 2022

stella.stamenova added a comment to D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it..

I think this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24905

Oct 17 2022, 5:22 PM · Restricted Project, Restricted Project

Oct 12 2022

stella.stamenova added a comment to D135613: [mlir][sparse] Renaming mlir_sparse_tensor_utils library to SparseTensorRuntime.

To be clear, Nate identified this change as the reason for the windows mlir buildbot failures.

How did D135613 cause the failure when that function wasn't introduced until D135480?

Oct 12 2022, 11:49 AM · Restricted Project, Restricted Project
stella.stamenova added a comment to D135613: [mlir][sparse] Renaming mlir_sparse_tensor_utils library to SparseTensorRuntime.

This appears to have broken the C interface. I suppose the corresponding rename will be required there. https://lab.llvm.org/buildbot/#/builders/13/builds/26975/steps/6/logs/stdio

C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/ExecutionEngine/SparseTensorRuntime.h(245): error C2220: the following warning is treated as an error
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/ExecutionEngine/SparseTensorRuntime.h(245): warning C4190: '_mlir_ciface_getSparseTensorReaderNextF16' has C-linkage specified, but returns UDT 'f16' which is incompatible with C
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/ExecutionEngine/Float16bits.h(35): note: see declaration of 'f16'
Oct 12 2022, 11:45 AM · Restricted Project, Restricted Project

Oct 10 2022

stella.stamenova added a comment to D135612: [mlir][linalg] Remove redundant check on linalgOps to fix windows builder.

Hey Stella, FYI, the windows fix is up here. :)

Oct 10 2022, 1:56 PM · Restricted Project, Restricted Project
stella.stamenova accepted D135613: [mlir][sparse] Renaming mlir_sparse_tensor_utils library to SparseTensorRuntime.

LGTM. A couple of minor comments inline.

Oct 10 2022, 12:44 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D135388: [mlir][linalg] Remove unused payload related OutOpOperand.

Looks like this broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/26882

Oct 10 2022, 12:42 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types.

Looks like this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24631

Oct 10 2022, 8:42 AM · Restricted Project, Restricted Project

Oct 8 2022

stella.stamenova accepted D135502: [mlir][sparse] Removing DLL attributes from ExecutionEngine/SparseTensor/Enums.h.

Both debug and release windows builds are green with this. Thanks!

Oct 8 2022, 12:43 PM · Restricted Project, Restricted Project

Oct 7 2022

stella.stamenova added a comment to D135502: [mlir][sparse] Removing DLL attributes from ExecutionEngine/SparseTensor/Enums.h.

There's, unfortunately, no public facing mlir windows bot that builds debug. We have some internal testing which builds debug which is how we ran into this.

Oct 7 2022, 6:09 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D134933: [mlir][sparse] further implement singleton dimension level type.

This change broke the mlir build on Windows in Debug. I'm actually not entirely sure why it only broke in Debug and not in Release as well because I would expect the issue to be the same in both.

Oct 7 2022, 10:59 AM · Restricted Project, Restricted Project

Oct 6 2022

stella.stamenova closed D135126: [mlir][sparse] Restore case coverage warning fix.

Hmm, git-blame is showing that this differential has landed in github yet phabricator indicates it's still merely "accepted". I'm not too familiar with how phabricator interacts with github, but should this differential be closed?

Oct 6 2022, 1:15 PM · Restricted Project, Restricted Project
stella.stamenova updated subscribers of D135126: [mlir][sparse] Restore case coverage warning fix.

We ended up with https://reviews.llvm.org/D135304 as the currently committed change. I believe this worked correctly everywhere, but if anyone knows of a break, we should address that as well.

Oct 6 2022, 12:59 PM · Restricted Project, Restricted Project

Oct 5 2022

stella.stamenova added inline comments to D135304: [mlir][sparse] Case coverage fix no errorhandling.
Oct 5 2022, 6:26 PM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D135304: [mlir][sparse] Case coverage fix no errorhandling.
Oct 5 2022, 3:48 PM · Restricted Project, Restricted Project
stella.stamenova committed rGff7a2b60555a: [mlir][sparse] Case coverage fix no errorhandling (authored by NathanielMcVicar).
[mlir][sparse] Case coverage fix no errorhandling
Oct 5 2022, 3:35 PM · Restricted Project, Restricted Project
stella.stamenova closed D135304: [mlir][sparse] Case coverage fix no errorhandling.
Oct 5 2022, 3:35 PM · Restricted Project, Restricted Project

Oct 4 2022

stella.stamenova added a comment to D135186: [mlir][sparse] Reverting invalid D135126.

D135126 was needed to fix the Windows mlir bot which was red for several days because of https://github.com/llvm/llvm-project/commit/e898be2f6edbb886af2f6b23e2f5db5210535620 which landed after D134925 and undid it.

Oct 4 2022, 12:43 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D135126: [mlir][sparse] Restore case coverage warning fix.

As Nate said, https://github.com/llvm/llvm-project/commit/e898be2f6edbb886af2f6b23e2f5db5210535620 broke the windows mlir bot which then stayed red for a couple of days. We wanted to make sure to get it back to green and this change seemed the most appropriate. We are not particularly tied to this change or another change but simply reverting this will get us back to a red state. @wrengr @aartbik if you have a better way to address the issue, that would be great, but we do not want the bot to be red again.

Oct 4 2022, 12:41 PM · Restricted Project, Restricted Project
stella.stamenova committed rG83839700c329: [mlir][sparse] Restore case coverage warning fix (authored by NathanielMcVicar).
[mlir][sparse] Restore case coverage warning fix
Oct 4 2022, 9:59 AM · Restricted Project, Restricted Project
stella.stamenova closed D135126: [mlir][sparse] Restore case coverage warning fix.
Oct 4 2022, 9:59 AM · Restricted Project, Restricted Project
stella.stamenova accepted D135126: [mlir][sparse] Restore case coverage warning fix.

LGTM, thanks for fixing the build breaks!

Oct 4 2022, 9:41 AM · Restricted Project, Restricted Project