Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (44 w, 6 d)

Recent Activity

Today

stella.stamenova committed rL349573: [lit] Rather than including stdio.h, forward-declare printf in….
[lit] Rather than including stdio.h, forward-declare printf in…
Tue, Dec 18, 3:39 PM
stella.stamenova committed rLLDB349573: [lit] Rather than including stdio.h, forward-declare printf in….
[lit] Rather than including stdio.h, forward-declare printf in…
Tue, Dec 18, 3:39 PM
stella.stamenova committed rL349562: [lit] Use the new build.py script in the lldb-mi tests.
[lit] Use the new build.py script in the lldb-mi tests
Tue, Dec 18, 2:58 PM
stella.stamenova committed rLLDB349562: [lit] Use the new build.py script in the lldb-mi tests.
[lit] Use the new build.py script in the lldb-mi tests
Tue, Dec 18, 2:58 PM
stella.stamenova added a comment to D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info.

It looks like this might not be specific to your change as a few other tests are failing with a similar error. I'm looking into it.

Tue, Dec 18, 1:23 PM
stella.stamenova added a comment to D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info.

A bunch of the NativePDB tests are failing on Windows now.

Tue, Dec 18, 1:05 PM
stella.stamenova added a comment to D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing.

Can you confirm that reverting this path actually fixes the issue? I'm asking because the only test that is executing this script has a REQUIRES: system-darwin line in it.

Tue, Dec 18, 10:53 AM

Yesterday

stella.stamenova added a comment to D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing.

This change made the Windows test get stuck: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2340

Mon, Dec 17, 5:39 PM
stella.stamenova accepted D55736: build.py: inherit environment in the gcc builder.

This does fix the issues. Thanks!

Mon, Dec 17, 9:54 AM

Fri, Dec 14

stella.stamenova added a comment to D55430: build.py: Implement "gcc" builder.

I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing:

Fri, Dec 14, 11:32 AM
stella.stamenova requested changes to D50563: Fixed frontend clang tests in windows read-only container.
Fri, Dec 14, 10:57 AM · Restricted Project
stella.stamenova added a comment to D55575: [NativePDB] Support local variables.
$ ":" "RUN: at line 5"
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe" "-s" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit"
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp"
# command stderr:
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16: error: CHECK-NEXT: expected string not found in input
Fri, Dec 14, 10:38 AM
stella.stamenova added a comment to D55575: [NativePDB] Support local variables.

local-variables.cpp is failing on the Buildbot:

Fri, Dec 14, 10:31 AM

Tue, Dec 11

stella.stamenova abandoned D55569: [lit] Add a basic implementation of build for GccBuilder.

Let's use @labath's change instead.

Tue, Dec 11, 2:07 PM
stella.stamenova accepted D55430: build.py: Implement "gcc" builder.

A couple of small comments, but it looks good otherwise. Thanks!

Tue, Dec 11, 2:04 PM
stella.stamenova created D55569: [lit] Add a basic implementation of build for GccBuilder.
Tue, Dec 11, 12:29 PM

Mon, Dec 10

stella.stamenova committed rL348775: Do not use PATH_MAX with SmallString.
Do not use PATH_MAX with SmallString
Mon, Dec 10, 9:29 AM
stella.stamenova committed rLLDB348775: Do not use PATH_MAX with SmallString.
Do not use PATH_MAX with SmallString
Mon, Dec 10, 9:29 AM
stella.stamenova closed D55457: Do not use PATH_MAX with SmallString.
Mon, Dec 10, 9:29 AM

Fri, Dec 7

stella.stamenova committed rL348665: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
[tests] Fix the FileManagerTest getVirtualFile test on Windows
Fri, Dec 7, 3:53 PM
stella.stamenova committed rC348665: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
[tests] Fix the FileManagerTest getVirtualFile test on Windows
Fri, Dec 7, 3:53 PM
stella.stamenova closed D55451: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
Fri, Dec 7, 3:53 PM
stella.stamenova committed rLLDB348664: [lit] Fix case-insensitive test.
[lit] Fix case-insensitive test
Fri, Dec 7, 3:33 PM
stella.stamenova committed rL348664: [lit] Fix case-insensitive test.
[lit] Fix case-insensitive test
Fri, Dec 7, 3:33 PM
stella.stamenova created D55457: Do not use PATH_MAX with SmallString.
Fri, Dec 7, 1:15 PM
stella.stamenova created D55451: [tests] Fix the FileManagerTest getVirtualFile test on Windows.
Fri, Dec 7, 12:33 PM

Thu, Dec 6

stella.stamenova committed rL348544: [lit] Use the build.py script in the case-insensitive test.
[lit] Use the build.py script in the case-insensitive test
Thu, Dec 6, 3:28 PM
stella.stamenova committed rLLDB348544: [lit] Use the build.py script in the case-insensitive test.
[lit] Use the build.py script in the case-insensitive test
Thu, Dec 6, 3:28 PM
stella.stamenova committed rL348542: [pecoff] Use PATH_MAX instead of MAX_PATH.
[pecoff] Use PATH_MAX instead of MAX_PATH
Thu, Dec 6, 3:25 PM
stella.stamenova committed rLLDB348542: [pecoff] Use PATH_MAX instead of MAX_PATH.
[pecoff] Use PATH_MAX instead of MAX_PATH
Thu, Dec 6, 3:25 PM
stella.stamenova added inline comments to D55332: [CMake] Python bindings generation polishing.
Thu, Dec 6, 9:26 AM

Wed, Dec 5

stella.stamenova committed rL348435: [lldbsuite] Disable TestStopPCs when there's no XML support.
[lldbsuite] Disable TestStopPCs when there's no XML support
Wed, Dec 5, 4:14 PM
stella.stamenova committed rLLDB348435: [lldbsuite] Disable TestStopPCs when there's no XML support.
[lldbsuite] Disable TestStopPCs when there's no XML support
Wed, Dec 5, 4:14 PM
stella.stamenova added a comment to D54942: [PDB] Make PDB lit tests use the new builder.

enums-layout.test is now failing on Windows:

Wed, Dec 5, 10:45 AM · Restricted Project
stella.stamenova added a comment to D55230: [lit] Multiple build outputs and default target bitness.

LLDB :: BuildScript/toolchain-clang-cl.test is failing on Linux.

Wed, Dec 5, 10:42 AM

Mon, Dec 3

stella.stamenova added inline comments to D55230: [lit] Multiple build outputs and default target bitness.
Mon, Dec 3, 2:48 PM
stella.stamenova added a comment to D55038: [Reproducers] Change how reproducers are initialized..

One of these tests fail on Windows:

Mon, Dec 3, 10:57 AM · Restricted Project

Fri, Nov 30

stella.stamenova committed rLLDB348055: [windows] Fix two minor bugs on Windows.
[windows] Fix two minor bugs on Windows
Fri, Nov 30, 4:21 PM
stella.stamenova committed rL348055: [windows] Fix two minor bugs on Windows.
[windows] Fix two minor bugs on Windows
Fri, Nov 30, 4:21 PM
stella.stamenova committed rLLDB348009: Revert "[PDB] Support PDB-backed expressions evaluation".
Revert "[PDB] Support PDB-backed expressions evaluation"
Fri, Nov 30, 9:33 AM
stella.stamenova committed rL348009: Revert "[PDB] Support PDB-backed expressions evaluation".
Revert "[PDB] Support PDB-backed expressions evaluation"
Fri, Nov 30, 9:33 AM
stella.stamenova added a comment to D53759: [PDB] Support PDB-backed expressions evaluation.

It looks like after this change went in, the tests on Windows starting timing out instead of completing. The last run before the change took about 2 minutes and starting with the first run with this change, they're running for 40 minutes before being killed:

Fri, Nov 30, 9:14 AM · Restricted Project

Thu, Nov 29

stella.stamenova committed rLLDB347924: [lldbsuite] Build with -gdwarf on Windows.
[lldbsuite] Build with -gdwarf on Windows
Thu, Nov 29, 2:18 PM
stella.stamenova committed rL347924: [lldbsuite] Build with -gdwarf on Windows.
[lldbsuite] Build with -gdwarf on Windows
Thu, Nov 29, 2:18 PM

Wed, Nov 28

stella.stamenova accepted D55024: [lit] Fix tool substitution when paths or arguments contain spaces.

I tested this with your other change and the tests ran successfully. Some of the test code does use single quotes on Windows and double quotes on Linux, though, so it may be worth checking for both regardless of platform.

Wed, Nov 28, 1:48 PM
stella.stamenova added a comment to D54914: Add a generic build script for building test inferiors.

It works for me when you make the command:

Wed, Nov 28, 12:59 PM
stella.stamenova added a comment to D54914: Add a generic build script for building test inferiors.

I ran the tests with this change and there are about a dozen new failures:

Wed, Nov 28, 12:37 PM
stella.stamenova committed rLLDB347796: [unittests] Fix the File System Test on Windows.
[unittests] Fix the File System Test on Windows
Wed, Nov 28, 11:37 AM
stella.stamenova committed rL347796: [unittests] Fix the File System Test on Windows.
[unittests] Fix the File System Test on Windows
Wed, Nov 28, 11:37 AM
stella.stamenova added a comment to D49379: lldbsuite: ignore decoding errors in _encoded_write.

What is the status? Thank you!

Wed, Nov 28, 9:45 AM · Restricted Project

Tue, Nov 27

stella.stamenova committed rLLDB347717: [lldbsuite] Each lldb suite test must have a unique class name.
[lldbsuite] Each lldb suite test must have a unique class name
Tue, Nov 27, 2:21 PM
stella.stamenova committed rL347717: [lldbsuite] Each lldb suite test must have a unique class name.
[lldbsuite] Each lldb suite test must have a unique class name
Tue, Nov 27, 2:21 PM
stella.stamenova added a comment to D54942: [PDB] Make PDB lit tests use the new builder.

This looks fine, but let's see if Zachary's change lands first and how it looks like after it lands :).

Tue, Nov 27, 8:34 AM · Restricted Project

Wed, Nov 21

stella.stamenova committed rLLDB347412: [lit] Add pthread to the compilation of the tests on Linux.
[lit] Add pthread to the compilation of the tests on Linux
Wed, Nov 21, 12:19 PM
stella.stamenova committed rL347412: [lit] Add pthread to the compilation of the tests on Linux.
[lit] Add pthread to the compilation of the tests on Linux
Wed, Nov 21, 12:18 PM
stella.stamenova closed D54808: [lit] Add pthread to the compilation of the tests on Linux.
Wed, Nov 21, 12:18 PM
stella.stamenova created D54808: [lit] Add pthread to the compilation of the tests on Linux.
Wed, Nov 21, 12:09 PM

Tue, Nov 20

stella.stamenova committed rLLDB347323: [lit] Build and link TestIRMemoryMapWindows explicitly.
[lit] Build and link TestIRMemoryMapWindows explicitly
Tue, Nov 20, 8:46 AM
stella.stamenova committed rL347323: [lit] Build and link TestIRMemoryMapWindows explicitly.
[lit] Build and link TestIRMemoryMapWindows explicitly
Tue, Nov 20, 8:46 AM
stella.stamenova committed rL347321: [lit] Disable the stop hook tests on Windows.
[lit] Disable the stop hook tests on Windows
Tue, Nov 20, 8:26 AM
stella.stamenova committed rLLDB347321: [lit] Disable the stop hook tests on Windows.
[lit] Disable the stop hook tests on Windows
Tue, Nov 20, 8:26 AM

Mon, Nov 19

stella.stamenova accepted D54731: [lit] Enable the use of custom user-defined lit commands.

LGTM as long as the tests are all still passing :)

Mon, Nov 19, 3:43 PM
stella.stamenova abandoned D53158: [buildbot, windows] Update the way the visual studio environment is set.
Mon, Nov 19, 2:01 PM
stella.stamenova committed rLLDB347243: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang.
[lldbsuite] Invoke sed on Windows to determine the cache dir for clang
Mon, Nov 19, 10:44 AM
stella.stamenova committed rL347243: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang.
[lldbsuite] Invoke sed on Windows to determine the cache dir for clang
Mon, Nov 19, 10:44 AM
stella.stamenova closed D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang.
Mon, Nov 19, 10:44 AM
stella.stamenova created D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang.
Mon, Nov 19, 9:24 AM

Nov 16 2018

stella.stamenova accepted D54567: Fix LLDB's lit files.

Feel free to check this in. At this point this will only improve the results on Windows and it works correctly on Linux.

Nov 16 2018, 7:37 PM
stella.stamenova accepted D54636: [lit] Add test directory to sys.path before invoking it..
Nov 16 2018, 11:05 AM
stella.stamenova added inline comments to D54636: [lit] Add test directory to sys.path before invoking it..
Nov 16 2018, 10:27 AM

Nov 15 2018

stella.stamenova added a comment to D54567: Fix LLDB's lit files.

That said, in the interest of not changing too much all at once, it still seems like something that's perhaps better done in a future patch. WDYT?

Nov 15 2018, 12:58 PM
stella.stamenova added a comment to D54567: Fix LLDB's lit files.

We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work.

That would not be a good idea. There are several bots that are using these flags.

The change that Zachary is making is removing their usage, so after his change they would not do anything. If he ends up committing this change, these two properties (along with LLDB_DEFAULT_TEST_C_COMPILER and LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go.

The flags are still needed for (and used by) the dotest suite, I didn't change that part. Normally you run that suite by doing ninja check-lldb, in which case it never goes through these lit files to begin with. But they will also run as part of ninja check-lldb-lit, but that lit configuration file totally overrides everything in the parent one, so nothing in this patch should have any effect on that.

I think this is actually confusing - there are two ways to specify compilers for the lldb test suite at cmake time:

  1. Via LLDB_TEST_USE_CUSTOM_C_COMPILER and friends
  2. Via LLDB_TEST_USER_ARGS

    As far as I can tell, the ubuntu 14 bot that @aprantl pointed to uses the LLDB_TEST_USER_ARGS path. I *think* the green dragon bots also use the LLDB_TEST_USER_ARGS and AFAIK it's the only way gcc is ever specified for the tests. If the LLDB_TEST_USE_CUSTOM_C_COMPILER and friends are not used for the lit tests, I don't think we need them for the suite tests.

You're right that it's confusing, but I don't have any good ideas here. Some ideas (which are not necessarily good):

  • We could change the names of LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER to LLDB_DOTEST_C_COMPILER and LLDB_DOTEST_CXX_COMPILER.
  • We could restructure the directories under lldb/lit so that it looks like this:

    ` lldb \- lit |- tests |- unittests \- dotest `
  • We could get rid of the lit folder entirely, and put everythign in the tests folder, like this: ` lldb \- test |- lit |- unittests \- dotest `

    Maybe some combinatino of these (or other ideas that others have) can make things clearer. But I don't want to change too much all at once.
Nov 15 2018, 9:55 AM
stella.stamenova added a comment to D54567: Fix LLDB's lit files.

Click on a recent build and then on "Console Output". Here is one from yesterday (we are upgrading the machines right now and temporarily broke the build):
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.0.2/1356/consoleFull

Nov 15 2018, 9:18 AM
stella.stamenova added a comment to D54567: Fix LLDB's lit files.

We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work.

That would not be a good idea. There are several bots that are using these flags.

The change that Zachary is making is removing their usage, so after his change they would not do anything. If he ends up committing this change, these two properties (along with LLDB_DEFAULT_TEST_C_COMPILER and LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go.

The flags are still needed for (and used by) the dotest suite, I didn't change that part. Normally you run that suite by doing ninja check-lldb, in which case it never goes through these lit files to begin with. But they will also run as part of ninja check-lldb-lit, but that lit configuration file totally overrides everything in the parent one, so nothing in this patch should have any effect on that.

Nov 15 2018, 9:15 AM
stella.stamenova added a comment to D54567: Fix LLDB's lit files.

We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work.

That would not be a good idea. There are several bots that are using these flags.

Nov 15 2018, 8:59 AM
stella.stamenova added a comment to D54567: Fix LLDB's lit files.

We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work.

Nov 15 2018, 8:48 AM

Nov 13 2018

stella.stamenova updated subscribers of D54009: Refactor LLDB lit configuration files.

I took a brief look and I have a question about the usage of clang (rather than clang-cl).

Nov 13 2018, 3:16 PM

Nov 7 2018

stella.stamenova added a comment to D54009: Refactor LLDB lit configuration files.

The builds don't specify the two options for LLDB_TEST_C/CXX_COMPILER, so they should be picking up the freshly build compilers. We don't have an option for clang-cl though - so it's never been explicitly specified.

Nov 7 2018, 2:24 PM
stella.stamenova added a comment to D54009: Refactor LLDB lit configuration files.

I haven't verified this yet - but I suspect it is now picking up the clang-cl that comes with VS rather than the one that was just built.

Nov 7 2018, 2:07 PM
stella.stamenova added a comment to D53530: Fix (and improve) the support for C99 variable length array types.

TestVla fails on Windows: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio

AssertionError: False is not True : 'frame var vla' returns expected result, got '(int []) vla = {}'

I will have time to look in more detail later this week, but if you have any ideas in the mean time, that would be great.

Is your bot using DWARF or CodeView as a debug info format? Because this test definitely requires DWARF.

Nov 7 2018, 2:00 PM · Restricted Project
stella.stamenova added a comment to D53530: Fix (and improve) the support for C99 variable length array types.

TestVla fails on Windows: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio

Nov 7 2018, 1:52 PM · Restricted Project
stella.stamenova added a comment to D54009: Refactor LLDB lit configuration files.

I have not run the dotest suite recently, is that where you’re seeing the
failures? I successfully ran the lit suite and unit tests though

Nov 7 2018, 1:44 PM
stella.stamenova added a comment to D54009: Refactor LLDB lit configuration files.

Several of the windows tests that invoke clang-cl have started failing recently (I am not sure exactly when) and I suspect this change is the culprit. Were you able to run the tests successfully with this change?

Nov 7 2018, 1:32 PM
stella.stamenova added a comment to D53915: [FileSystem] Move resolve logic out of FileSpec.

Some of the file spec changes caused a bunch of failures on Windows. We know have a silent Buildbot that you can see the failures on as well:

Nov 7 2018, 1:24 PM · Restricted Project

Nov 6 2018

stella.stamenova added a comment to D54009: Refactor LLDB lit configuration files.

Looks good. The formatting in lit.cfg.py is a bit messy (indentations, especially), but as long as the tests pass, this is an improvement :). Thanks!

Is there something like clang-format for Python? Happy to fix it if so. (I don't do a lot of Python so it's hard for me to eyeball it and figure out what's wrong, so I have to say it looks fine to me :))

Nov 6 2018, 9:36 AM

Nov 1 2018

stella.stamenova accepted D54009: Refactor LLDB lit configuration files.

Looks good. The formatting in lit.cfg.py is a bit messy (indentations, especially), but as long as the tests pass, this is an improvement :). Thanks!

Nov 1 2018, 4:49 PM

Oct 26 2018

stella.stamenova added a comment to D53158: [buildbot, windows] Update the way the visual studio environment is set.

Hi Stella,

Please see my notes inline.

Unless you want to do this by yourself, I can prepare this change. I think I have developed a good understanding of what you are after.

Oct 26 2018, 3:26 PM
stella.stamenova accepted D53775: [git/svn] Ignore Visual Studio's CMakeSettings.json..
Oct 26 2018, 1:20 PM
stella.stamenova added inline comments to D53158: [buildbot, windows] Update the way the visual studio environment is set.
Oct 26 2018, 11:56 AM
stella.stamenova committed rL345415: Revert "[buildbot, windows] Update the way the visual studio environment is set".
Revert "[buildbot, windows] Update the way the visual studio environment is set"
Oct 26 2018, 11:21 AM
stella.stamenova accepted D53759: [PDB] Support PDB-backed expressions evaluation.

A couple of comments, but looks good otherwise. I'd wait for someone else to have a look as well.

Oct 26 2018, 10:21 AM · Restricted Project

Oct 25 2018

stella.stamenova committed rL345310: [buildbot] Add a missing tag for the FileCheck parameter.
[buildbot] Add a missing tag for the FileCheck parameter
Oct 25 2018, 1:35 PM
stella.stamenova committed rL345309: [buildbot, windows] Update the way the visual studio environment is set.
[buildbot, windows] Update the way the visual studio environment is set
Oct 25 2018, 1:32 PM
stella.stamenova closed D53158: [buildbot, windows] Update the way the visual studio environment is set.
Oct 25 2018, 1:32 PM

Oct 24 2018

stella.stamenova added a comment to D53158: [buildbot, windows] Update the way the visual studio environment is set.

@gkistanova do you have a concern with the current changes or any additional testing you want me to do before I check this in?

Oct 24 2018, 11:23 AM

Oct 22 2018

stella.stamenova accepted D53469: [DWARF] Use a function-local offset for AT_call_return_pc.

This change fixes the problem on Linux. Thanks!

Oct 22 2018, 1:40 PM

Oct 19 2018

stella.stamenova committed rLLDB344788: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows.
[lldbsuite, windows] Disable two tail call frames tests that fail on Windows
Oct 19 2018, 9:04 AM
stella.stamenova committed rL344788: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows.
[lldbsuite, windows] Disable two tail call frames tests that fail on Windows
Oct 19 2018, 9:03 AM
stella.stamenova closed D53415: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows.
Oct 19 2018, 9:03 AM

Oct 18 2018

stella.stamenova updated the diff for D53158: [buildbot, windows] Update the way the visual studio environment is set.

I updated the patch, so that it will not auto detect the VS installation unless explicitly requested. I also propagated the flag to all the builders that currently work with VS, so that it is available immediately if anyone chooses to create a buildbot with a newer VS installation.

Oct 18 2018, 5:47 PM