- User Since
- Feb 7 2018, 7:04 PM (44 w, 6 d)
It looks like this might not be specific to your change as a few other tests are failing with a similar error. I'm looking into it.
A bunch of the NativePDB tests are failing on Windows now.
This change made the Windows test get stuck: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2340
This does fix the issues. Thanks!
Fri, Dec 14
I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing:
$ ":" "RUN: at line 5" $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe" "-s" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit" $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp" # command stderr: E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16: error: CHECK-NEXT: expected string not found in input
local-variables.cpp is failing on the Buildbot:
Tue, Dec 11
Let's use @labath's change instead.
A couple of small comments, but it looks good otherwise. Thanks!
Mon, Dec 10
Fri, Dec 7
Thu, Dec 6
Wed, Dec 5
enums-layout.test is now failing on Windows:
LLDB :: BuildScript/toolchain-clang-cl.test is failing on Linux.
Mon, Dec 3
One of these tests fail on Windows:
Fri, Nov 30
It looks like after this change went in, the tests on Windows starting timing out instead of completing. The last run before the change took about 2 minutes and starting with the first run with this change, they're running for 40 minutes before being killed:
Thu, Nov 29
Wed, Nov 28
I tested this with your other change and the tests ran successfully. Some of the test code does use single quotes on Windows and double quotes on Linux, though, so it may be worth checking for both regardless of platform.
It works for me when you make the command:
I ran the tests with this change and there are about a dozen new failures:
Tue, Nov 27
This looks fine, but let's see if Zachary's change lands first and how it looks like after it lands :).
Wed, Nov 21
Tue, Nov 20
Mon, Nov 19
LGTM as long as the tests are all still passing :)
Nov 16 2018
Feel free to check this in. At this point this will only improve the results on Windows and it works correctly on Linux.
Nov 15 2018
That said, in the interest of not changing too much all at once, it still seems like something that's perhaps better done in a future patch. WDYT?
We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work.
Nov 13 2018
I took a brief look and I have a question about the usage of clang (rather than clang-cl).
Nov 7 2018
The builds don't specify the two options for LLDB_TEST_C/CXX_COMPILER, so they should be picking up the freshly build compilers. We don't have an option for clang-cl though - so it's never been explicitly specified.
I haven't verified this yet - but I suspect it is now picking up the clang-cl that comes with VS rather than the one that was just built.
TestVla fails on Windows: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio
Several of the windows tests that invoke clang-cl have started failing recently (I am not sure exactly when) and I suspect this change is the culprit. Were you able to run the tests successfully with this change?
Some of the file spec changes caused a bunch of failures on Windows. We know have a silent Buildbot that you can see the failures on as well:
Nov 6 2018
Nov 1 2018
Looks good. The formatting in lit.cfg.py is a bit messy (indentations, especially), but as long as the tests pass, this is an improvement :). Thanks!
Oct 26 2018
A couple of comments, but looks good otherwise. I'd wait for someone else to have a look as well.
Oct 25 2018
Oct 24 2018
@gkistanova do you have a concern with the current changes or any additional testing you want me to do before I check this in?
Oct 22 2018
This change fixes the problem on Linux. Thanks!
Oct 19 2018
Oct 18 2018
I updated the patch, so that it will not auto detect the VS installation unless explicitly requested. I also propagated the flag to all the builders that currently work with VS, so that it is available immediately if anyone chooses to create a buildbot with a newer VS installation.