[MachineVerifier] Try harder to verify LiveIntervals

[foad]

Summary

Verify the LiveIntervals analysis after a pass that claims to preserve
it, even if there are no further passes (apart from the verifier itself)
that would use the analysis.

Fixes https://github.com/llvm/llvm-project/issues/46217

[foad]

llvm/test/CodeGen/AMDGPU/si-lower-control-flow.mir

33 ↗

(On Diff #442581)

This is a side effect of LiveIntervals being available when SILowerControlFlow runs.

SILowerControlFlow says:

// This doesn't actually need LiveIntervals, but we can preserve them.
LIS = getAnalysisIfAvailable<LiveIntervals>();

but in fact the presence of LiveIntervals does affect the output as shown by these diffs, so the perhaps the pass should call AU.addUsedIfAvailable<LiveIntervals>() in its getAnalysisUsage?

[foad]

FIXME: Hexagon tests fail with:
*** Bad machine code: Multiple connected components in live interval ***
after Hexagon Expand Condsets.

This is https://github.com/llvm/llvm-project/issues/56050

[foad]

FIXME: Other AMDGPU tests fail with
*** Bad machine code: Multiple connected components in live interval ***
after SI optimize exec mask operations pre-RA.

This is https://github.com/llvm/llvm-project/issues/56051

[foad]

Rebase on D129555.

[foad]

llvm/test/CodeGen/AMDGPU/si-lower-control-flow.mir

33 ↗

(On Diff #442581)

Done in D129555.

[foad]

Rebase.

[foad]

Rebase

[foad]

Update checks in statepoint-cmp-sunk-past-statepoint.ll

[foad]

This comment was removed by foad.

[foad]

Remove a failing test as suggested in D151227. Remove some workarounds.

[foad]

Rebase

[fhahn]

LGTM, thanks!

llvm/lib/CodeGen/MachineVerifier.cpp

MachineVerifierPass(std::string banner = std::string())
       : MachineFunctionPass(ID), Banner(std::move(banner)) {
         initializeMachineVerifierPassPass(*PassRegistry::getPassRegistry());
       }
 
     void getAnalysisUsage(AnalysisUsage &AU) const override {
       AU.addUsedIfAvailable<LiveStacks>();
       AU.addUsedIfAvailable<LiveVariables>();
       AU.addUsedIfAvailable<SlotIndexes>();
+      AU.addUsedIfAvailable<LiveIntervals>();
       AU.setPreservesAll();
       MachineFunctionPass::getAnalysisUsage(AU);
     }
 
     bool runOnMachineFunction(MachineFunction &MF) override {
       // Skip functions that have known verification problems.
       // FIXME: Remove this mechanism when all problematic passes have been
       // fixed.

llvm/test/CodeGen/AArch64/regcoal-physreg.mir

-# RUN: llc -mtriple=aarch64-apple-ios -run-pass=simple-register-coalescing,simple-register-coalescing -verify-machineinstrs %s -o - | FileCheck %s
-
-# FIXME: Second run of the pass is a workaround for a bug in
-# -run-pass. The verifier doesn't detect broken LiveIntervals, see bug
-# 46873
+# RUN: llc -mtriple=aarch64-apple-ios -run-pass=simple-register-coalescing -verify-machineinstrs %s -o - | FileCheck %s
 --- |
   declare void @f2()
 
   define void @func0() { ret void }
   define void @func1() { ret void }
   define void @func2() { ret void }
 ...
 ---

llvm/test/CodeGen/AMDGPU/optimize-exec-mask-pre-ra-def-after-use.mir

 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-# RUN: llc -mtriple amdgcn-amd-amdhsa -mcpu=gfx1030 -verify-machineinstrs -run-pass=si-optimize-exec-masking-pre-ra,si-optimize-exec-masking-pre-ra %s -o - | FileCheck --check-prefix=GCN %s
-
-# FIXME: Second run of the pass is a workaround for a bug in
-# -run-pass. The verifier doesn't detect broken LiveIntervals, see bug
-# 46873
+# RUN: llc -mtriple amdgcn-amd-amdhsa -mcpu=gfx1030 -verify-machineinstrs -run-pass=si-optimize-exec-masking-pre-ra %s -o - | FileCheck --check-prefix=GCN %s
 
 # %8 is defined at the end, but it will be used in bb.2.
 # Make sure we properly extend its liverange to the beginning of the bb.2.
 # and to the end of the bb.6
 
 ---
 name: def_later_than_use
 tracksRegLiveness: true

llvm/test/CodeGen/AMDGPU/optimize-exec-mask-pre-ra-loop-phi.mir

 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx906 -verify-machineinstrs -run-pass=si-optimize-exec-masking-pre-ra,si-optimize-exec-masking-pre-ra -o - %s | FileCheck %s
-
-# FIXME: Second run of the pass is a workaround for a bug in
-# -run-pass. The verifier doesn't detect broken LiveIntervals, see bug
-# 46873
+# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx906 -verify-machineinstrs -run-pass=si-optimize-exec-masking-pre-ra -o - %s | FileCheck %s
 
 
 # Cannot fold this without moving the def of %7 after the and.
 ---
 name:            no_fold_andn2_select_condition_live_out_phi
 tracksRegLiveness: true
 body:             |
   ; CHECK-LABEL: name: no_fold_andn2_select_condition_live_out_phi

llvm/test/CodeGen/AMDGPU/subreg-intervals.mir

 # RUN: llc -march=amdgcn -run-pass liveintervals -debug-only=regalloc -verify-machineinstrs -o /dev/null %s 2>&1 | FileCheck %s
 # REQUIRES: asserts
 
 # CHECK: INTERVALS
 # CHECK: %0
-# CHECK-LABEL: Machine code for function test0:
-
-# CHECK: INTERVALS
-# CHECK: %0
 # CHECK-LABEL: Machine code for function test1:
 
 --- |
-  define amdgpu_kernel void @test0() { ret void }
   define amdgpu_kernel void @test1() { ret void }
 ...
 ---
-name: test0
-registers:
-  - { id: 0, class: sreg_64 }
-body: |
-  bb.0:
-    S_NOP 0, implicit-def %0
-    S_NOP 0, implicit %0
-
-    S_NOP 0, implicit-def undef %0.sub0
-    S_NOP 0, implicit %0
-...
----
 name: test1
 registers:
   - { id: 0, class: sreg_64 }
 body: |
   bb.0:
     S_CBRANCH_VCCNZ %bb.1, implicit undef $vcc
     S_BRANCH %bb.2
 

llvm/test/CodeGen/X86/statepoint-cmp-sunk-past-statepoint.ll

 ; CHECK-LV:     TEST8rr killed %18, %18, implicit-def $eflags
 ; CHECK-LIS:    TEST8rr %18, %18, implicit-def $eflags
 ; CHECK:        JCC_1 %bb.5, 5, implicit killed $eflags
 ; CHECK:        JMP_1 %bb.4
 ; CHECK:      bb.4
 ; CHECK:      bb.5
 ; CHECK:        %3:gr64 = COPY %10
 ; CHECK-LV:     %4:gr64 = COPY killed %10
-; CHECK-LV:     %4:gr64 = nuw ADD64ri32 %4, 8, implicit-def dead $eflags
-; CHECK-LIS:    %4:gr64 = LEA64r %10, 1, $noreg, 8, $noreg
+; CHECK-LIS:    %4:gr64 = COPY %10
+; CHECK:        %4:gr64 = nuw ADD64ri32 %4, 8, implicit-def dead $eflags
 ; CHECK:        TEST64rr killed %1, %1, implicit-def $eflags
 ; CHECK:        JCC_1 %bb.1, 5, implicit killed $eflags
 ; CHECK:        JMP_1 %bb.6
 define void @test2(i8 addrspace(1)* %this, i32 %0, i32 addrspace(1)* %p0, i8 addrspace(1)* %p1) gc "statepoint-example" personality i32* ()* @fake_personality_function {
 preheader:
   br label %loop.head
 
 loop.head: