Page MenuHomePhabricator

dfukalov (Daniil Fukalov)
Compiler Engineer at AMD

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2014, 8:40 AM (348 w, 15 h)

Recent Activity

Thu, Oct 29

dfukalov committed rGb3cdaef518ad: [MIR] Fix out of bounds access in MIRPrinter. (authored by dfukalov).
[MIR] Fix out of bounds access in MIRPrinter.
Thu, Oct 29, 4:35 AM
dfukalov closed D90239: [MIR] Fix out of bounds access in MIRPrinter..
Thu, Oct 29, 4:35 AM · Restricted Project
dfukalov updated the diff for D90239: [MIR] Fix out of bounds access in MIRPrinter..

Addressed comments.

Thu, Oct 29, 4:34 AM · Restricted Project

Wed, Oct 28

dfukalov added inline comments to D90239: [MIR] Fix out of bounds access in MIRPrinter..
Wed, Oct 28, 11:29 AM · Restricted Project
dfukalov updated the diff for D90239: [MIR] Fix out of bounds access in MIRPrinter..

Addressed comments.

Wed, Oct 28, 11:22 AM · Restricted Project

Oct 27 2020

dfukalov requested review of D90239: [MIR] Fix out of bounds access in MIRPrinter..
Oct 27 2020, 8:23 AM · Restricted Project

Oct 24 2020

dfukalov committed rG9068c209655e: [AMDGPU][CostModel] Refine cost model for half- and quarter-rate instructions. (authored by dfukalov).
[AMDGPU][CostModel] Refine cost model for half- and quarter-rate instructions.
Oct 24 2020, 9:53 AM
dfukalov closed D89973: [AMDGPU][CostModel] Refine cost model for half- and quarter-rate instructions..
Oct 24 2020, 9:53 AM · Restricted Project

Oct 22 2020

dfukalov requested review of D89973: [AMDGPU][CostModel] Refine cost model for half- and quarter-rate instructions..
Oct 22 2020, 10:24 AM · Restricted Project

Sep 9 2020

dfukalov committed rGc259d3a061c8: [AMDGPU] Fix for folding v2.16 literals. (authored by dfukalov).
[AMDGPU] Fix for folding v2.16 literals.
Sep 9 2020, 3:40 PM
dfukalov closed D87158: [AMDGPU] Fix for folding v2.16 literals..
Sep 9 2020, 3:39 PM · Restricted Project
dfukalov added inline comments to D87158: [AMDGPU] Fix for folding v2.16 literals..
Sep 9 2020, 7:29 AM · Restricted Project

Sep 8 2020

dfukalov added inline comments to D87158: [AMDGPU] Fix for folding v2.16 literals..
Sep 8 2020, 11:45 AM · Restricted Project

Sep 5 2020

dfukalov added inline comments to D87158: [AMDGPU] Fix for folding v2.16 literals..
Sep 5 2020, 3:29 PM · Restricted Project

Sep 4 2020

dfukalov requested review of D87158: [AMDGPU] Fix for folding v2.16 literals..
Sep 4 2020, 12:55 PM · Restricted Project

Aug 20 2020

dfukalov added a comment to D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass.

Why is this the correct course of action?
For example, if the IR already had memcpy/memset, the DA will also be pessimized,
so it really seems like a workaround, not a fix.
Why not just enhance DA?

Aug 20 2020, 1:00 AM · Restricted Project
dfukalov committed rG33e2f69a24b4: [AMDGPU][LoopUnroll] Increase BB size to analyze for complete unroll. (authored by dfukalov).
[AMDGPU][LoopUnroll] Increase BB size to analyze for complete unroll.
Aug 20 2020, 12:42 AM
dfukalov closed D86248: [AMDGPU][LoopUnroll] Increase BB size to analyze for complete unroll..
Aug 20 2020, 12:42 AM · Restricted Project

Aug 19 2020

dfukalov requested review of D86248: [AMDGPU][LoopUnroll] Increase BB size to analyze for complete unroll..
Aug 19 2020, 2:15 PM · Restricted Project

Aug 13 2020

dfukalov abandoned D37438: Fix segfault in FlattenCFG.
Aug 13 2020, 9:12 AM
dfukalov accepted D85829: [NFCI][SimpleLoopUnswitch] Adjust CostKind query.

Please clang-format it.

Aug 13 2020, 7:11 AM · Restricted Project

Aug 6 2020

dfukalov committed rG4ccc38813eb7: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation. (authored by dfukalov).
[AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation.
Aug 6 2020, 11:44 AM
dfukalov closed D84995: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation..
Aug 6 2020, 11:43 AM · Restricted Project
dfukalov added inline comments to D84995: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation..
Aug 6 2020, 9:20 AM · Restricted Project
dfukalov updated the diff for D84995: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation..

Check for hasMadMacF32Insts() added.

Aug 6 2020, 2:35 AM · Restricted Project

Aug 5 2020

dfukalov updated the diff for D84995: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation..

Change updated with addressed comments.

Aug 5 2020, 3:09 PM · Restricted Project

Jul 31 2020

dfukalov added inline comments to D84995: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation..
Jul 31 2020, 9:02 AM · Restricted Project

Jul 30 2020

dfukalov committed rGaa77232a63e3: [NFC][AMDGPU] Improve fused fmul+fadd tests. (authored by dfukalov).
[NFC][AMDGPU] Improve fused fmul+fadd tests.
Jul 30 2020, 6:00 PM
dfukalov closed D84903: [NFC][AMDGPU] Improve fused fmul+fadd tests..
Jul 30 2020, 6:00 PM · Restricted Project
dfukalov requested review of D84995: [AMDGPU][CostModel] Add f16, f64 and contract cases to fused costs estimation..
Jul 30 2020, 5:57 PM · Restricted Project
dfukalov added inline comments to D84903: [NFC][AMDGPU] Improve fused fmul+fadd tests..
Jul 30 2020, 3:53 AM · Restricted Project

Jul 29 2020

dfukalov requested review of D84903: [NFC][AMDGPU] Improve fused fmul+fadd tests..
Jul 29 2020, 6:13 PM · Restricted Project
dfukalov added a comment to D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.

Hi @cebowleratibm, it seems test is located in wrong place: test/CodeGen/PowerPC instead of llvm/test/CodeGen/PowerPC.

Jul 29 2020, 3:38 PM · Restricted Project

Jul 15 2020

dfukalov committed rG76a0c0ee6ffa: [AMDGPU][CostModel] Improve cost estimation for fused {fadd|fsub}(a,fmul(b,c)) (authored by dfukalov).
[AMDGPU][CostModel] Improve cost estimation for fused {fadd|fsub}(a,fmul(b,c))
Jul 15 2020, 5:07 PM
dfukalov closed D83919: [AMDGPU][CostModel] Improve cost estimation for fused {fadd|fsub}(a,fmul(b,c)).
Jul 15 2020, 5:07 PM · Restricted Project
dfukalov updated the diff for D83919: [AMDGPU][CostModel] Improve cost estimation for fused {fadd|fsub}(a,fmul(b,c)).

removed extra new lines

Jul 15 2020, 5:05 PM · Restricted Project
Herald added a project to D83919: [AMDGPU][CostModel] Improve cost estimation for fused {fadd|fsub}(a,fmul(b,c)): Restricted Project.
Jul 15 2020, 4:25 PM · Restricted Project
dfukalov committed rG7520393842ea: [NFC] Fixed typo in tests parameters (authored by dfukalov).
[NFC] Fixed typo in tests parameters
Jul 15 2020, 12:09 PM
dfukalov closed D83883: [NFC] Fixed typo in tests parameters.
Jul 15 2020, 12:09 PM · Restricted Project
Herald added a project to D83883: [NFC] Fixed typo in tests parameters: Restricted Project.
Jul 15 2020, 8:56 AM · Restricted Project

Jul 9 2020

dfukalov committed rG167767a775f3: SpeculativeExecution: Fix for logic change introduced in D81730. (authored by dfukalov).
SpeculativeExecution: Fix for logic change introduced in D81730.
Jul 9 2020, 5:45 AM
dfukalov closed D82761: SpeculativeExecution: Fix for logic change introduced in D81730..
Jul 9 2020, 5:45 AM · Restricted Project

Jul 7 2020

dfukalov added a comment to D82761: SpeculativeExecution: Fix for logic change introduced in D81730..

Ping.

Jul 7 2020, 10:25 AM · Restricted Project

Jul 2 2020

dfukalov accepted D82453: [CostModel] Fix for cast crash.
Jul 2 2020, 6:57 AM · Restricted Project
dfukalov added inline comments to D82453: [CostModel] Fix for cast crash.
Jul 2 2020, 3:10 AM · Restricted Project

Jun 30 2020

dfukalov added inline comments to D82761: SpeculativeExecution: Fix for logic change introduced in D81730..
Jun 30 2020, 7:00 AM · Restricted Project
dfukalov updated the diff for D82761: SpeculativeExecution: Fix for logic change introduced in D81730..

Test updated

Jun 30 2020, 7:00 AM · Restricted Project
dfukalov committed rG1a6cebb4d12c: [PM] Fix new PM to perform SpeculativeExecution as in old PM (authored by dfukalov).
[PM] Fix new PM to perform SpeculativeExecution as in old PM
Jun 30 2020, 5:23 AM
dfukalov closed D82735: [PM] Fix new PM to perform SpeculativeExecution as in old PM.
Jun 30 2020, 5:23 AM · Restricted Project

Jun 29 2020

dfukalov committed rG8cc722ffc749: [NFC] Fixed ignored .hip test. (authored by dfukalov).
[NFC] Fixed ignored .hip test.
Jun 29 2020, 9:11 AM
dfukalov closed D82764: [NFC] Fixed ignored .hip test..
Jun 29 2020, 9:10 AM · Restricted Project
dfukalov added a reviewer for D82735: [PM] Fix new PM to perform SpeculativeExecution as in old PM: arsenm.
Jun 29 2020, 6:58 AM · Restricted Project
dfukalov created D82764: [NFC] Fixed ignored .hip test..
Jun 29 2020, 6:58 AM · Restricted Project
dfukalov created D82761: SpeculativeExecution: Fix for logic change introduced in D81730..
Jun 29 2020, 5:54 AM · Restricted Project

Jun 28 2020

dfukalov created D82735: [PM] Fix new PM to perform SpeculativeExecution as in old PM.
Jun 28 2020, 6:13 PM · Restricted Project
dfukalov committed rGc7bcd431d9c4: SpeculativeExecution: fix incorrect debug info move (authored by dfukalov).
SpeculativeExecution: fix incorrect debug info move
Jun 28 2020, 4:57 AM
dfukalov closed D81730: SpeculativeExecution: fix incorrect debug info move.
Jun 28 2020, 4:57 AM · debug-info, Restricted Project
dfukalov abandoned D82650: [HIP] Set default FP_CONTRACT to ON.

I was completely wrong

Jun 28 2020, 3:21 AM · Restricted Project

Jun 26 2020

dfukalov planned changes to D82650: [HIP] Set default FP_CONTRACT to ON.

I think the point of -ffp-contract=fast is that it allows emitting fma across statements if there are such opportunities whereas -ffp-contract=on only allows fma in one statement

https://llvm.org/docs/CompileCudaWithLLVM.html#flags-that-control-numerical-code

Yes, you're right. I was confused by current FE behavior and a number of different commits, reverts and re-commits.

Jun 26 2020, 7:37 AM · Restricted Project
dfukalov created D82650: [HIP] Set default FP_CONTRACT to ON.
Jun 26 2020, 5:56 AM · Restricted Project

Jun 24 2020

dfukalov added inline comments to D82453: [CostModel] Fix for cast crash.
Jun 24 2020, 2:40 PM · Restricted Project
dfukalov committed rG7ddee0922fc2: [NFCI][CostModel] Add const to Value*. (authored by dfukalov).
[NFCI][CostModel] Add const to Value*.
Jun 24 2020, 1:35 PM
dfukalov closed D82383: [NFCI][CostModel] Add const to Value*..
Jun 24 2020, 1:35 PM · Restricted Project

Jun 23 2020

dfukalov created D82383: [NFCI][CostModel] Add const to Value*..
Jun 23 2020, 7:26 AM · Restricted Project

Jun 19 2020

dfukalov added a comment to D81730: SpeculativeExecution: fix incorrect debug info move.

ping...

Jun 19 2020, 4:52 PM · debug-info, Restricted Project
dfukalov committed rG129388ddc4df: [AMDGPU][CostModel] Add fneg cost estimation (authored by dfukalov).
[AMDGPU][CostModel] Add fneg cost estimation
Jun 19 2020, 7:33 AM
dfukalov closed D82065: [AMDGPU][CostModel] Add fneg cost estimation.
Jun 19 2020, 7:33 AM · Restricted Project

Jun 18 2020

dfukalov added inline comments to D82065: [AMDGPU][CostModel] Add fneg cost estimation.
Jun 18 2020, 5:57 AM · Restricted Project
dfukalov updated the diff for D82065: [AMDGPU][CostModel] Add fneg cost estimation.

Added comment, fixed typo

Jun 18 2020, 5:57 AM · Restricted Project

Jun 17 2020

dfukalov created D82065: [AMDGPU][CostModel] Add fneg cost estimation.
Jun 17 2020, 5:51 PM · Restricted Project

Jun 14 2020

dfukalov accepted D81635: [NFCI][CostModel] Unify FNeg cost.
Jun 14 2020, 6:39 PM · Restricted Project

Jun 13 2020

dfukalov accepted D81643: [NFCI][CostModel] Unify ExtractElement cost..
Jun 13 2020, 4:18 AM · Restricted Project

Jun 12 2020

dfukalov updated the diff for D81730: SpeculativeExecution: fix incorrect debug info move.

updated comments

Jun 12 2020, 4:34 PM · debug-info, Restricted Project
dfukalov added a comment to D79164: [CostModel] getCFInstrCost.

Actually it seems all of these dozens of "CHECK-NEXT: Cost Model: Found an estimated cost of 1 for instruction: ret i32" may be removed from most of tests not related to getCFInstrCost

Jun 12 2020, 8:37 AM · Restricted Project
dfukalov accepted D79164: [CostModel] getCFInstrCost.

LGTM, although minor change in test' comment

Jun 12 2020, 8:37 AM · Restricted Project
dfukalov created D81730: SpeculativeExecution: fix incorrect debug info move.
Jun 12 2020, 4:49 AM · debug-info, Restricted Project

Jun 10 2020

dfukalov added a comment to D74825: SpeculativeExecution: fixed ingoring free execution.

I've just got the bug, will take a look

Jun 10 2020, 8:12 AM · Restricted Project
dfukalov added inline comments to D81448: [CostModel] Unify Shuffle and InsertElement Costs.
Jun 10 2020, 4:20 AM · Restricted Project

Jun 9 2020

dfukalov accepted D81448: [CostModel] Unify Shuffle and InsertElement Costs.
Jun 9 2020, 6:15 PM · Restricted Project
dfukalov added inline comments to D79164: [CostModel] getCFInstrCost.
Jun 9 2020, 5:42 PM · Restricted Project
dfukalov accepted D80992: [CostModel] Unify getArithmeticInstrCost .
Jun 9 2020, 5:09 PM · Restricted Project

Jun 8 2020

dfukalov committed rG6a31a9a5431f: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions (authored by dfukalov).
[AMDGPU][NFC] Skip processing intrinsics that do not become real instructions
Jun 8 2020, 6:17 PM
dfukalov closed D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.
Jun 8 2020, 6:17 PM · Restricted Project

Jun 6 2020

dfukalov committed rGc94d32a6b302: [AMDGPU] Increase max iterations count to analyze complete unroll (authored by dfukalov).
[AMDGPU] Increase max iterations count to analyze complete unroll
Jun 6 2020, 6:55 AM
dfukalov closed D81204: [AMDGPU] Increase max iterations count to analyze complete unroll.
Jun 6 2020, 6:54 AM · Restricted Project
dfukalov updated the diff for D81204: [AMDGPU] Increase max iterations count to analyze complete unroll.

fixed spelling

Jun 6 2020, 4:14 AM · Restricted Project
dfukalov added a comment to D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.

There are the tests in llvm/test/CodeGen/AMDGPU/simplify-libcalls.ll

Jun 6 2020, 1:02 AM · Restricted Project

Jun 5 2020

dfukalov updated the diff for D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.

diff reuploaded

Jun 5 2020, 6:27 PM · Restricted Project
dfukalov added a comment to D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.
Jun 5 2020, 5:55 PM · Restricted Project
dfukalov updated the diff for D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.

added test

Jun 5 2020, 5:54 PM · Restricted Project
dfukalov updated the diff for D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.

test added

Jun 5 2020, 5:54 PM · Restricted Project
dfukalov updated the diff for D81204: [AMDGPU] Increase max iterations count to analyze complete unroll.

test updated as requested

Jun 5 2020, 3:10 PM · Restricted Project
dfukalov added a comment to D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.

But how did it work?! It should have skipped any call which is not a lifetime intrinsic.

Jun 5 2020, 3:10 PM · Restricted Project
dfukalov added a comment to D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.

Phabricator somehow shows wrong diff after patch update. Correct diff is

-       if (!CI) continue;
+       if (!CI || isa<DbgInfoIntrinsic>(CI) || CI->isLifetimeStartOrEnd())
+         continue;
Jun 5 2020, 12:54 PM · Restricted Project
dfukalov retitled D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions from [AMDGPU] Skip processing intrinsics that do not become real instructions to [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.
Jun 5 2020, 12:54 PM · Restricted Project
dfukalov added a comment to D80992: [CostModel] Unify getArithmeticInstrCost .

AMDGPU part LGTM,
let's wait a couple of days to allow others to take a look

Jun 5 2020, 10:35 AM · Restricted Project
dfukalov updated the diff for D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.

fixed typo

Jun 5 2020, 10:01 AM · Restricted Project
dfukalov created D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions.
Jun 5 2020, 7:11 AM · Restricted Project

Jun 4 2020

dfukalov updated the diff for D81204: [AMDGPU] Increase max iterations count to analyze complete unroll.

fixing lint message

Jun 4 2020, 5:09 PM · Restricted Project
dfukalov created D81204: [AMDGPU] Increase max iterations count to analyze complete unroll.
Jun 4 2020, 5:09 PM · Restricted Project