User Details
- User Since
- Mar 27 2014, 8:40 AM (495 w, 5 d)
Sep 5 2022
Removed redundant parenses.
Addressed comment.
Sep 2 2022
Sep 1 2022
Ping...
Aug 26 2022
Aug 25 2022
Addressed comment, removed few more getValue() calls.
Ping...
Aug 22 2022
Aug 17 2022
Ping...
Rebased...
Aug 15 2022
Added comment/description for getTypeConversion()
Addressed comment.
Aug 12 2022
Rebased.
I thought we should wait for additional opinions on the patch...
Aug 11 2022
Ping...
Addresses comments.
Aug 2 2022
Moved warning skipping into checkLivenessAtDef() to get back some checks.
Aug 1 2022
Ping - the patch with D127136 are fixing https://github.com/RadeonOpenCompute/ROCm/issues/1486...
Using pipeliner instead of RC as dummy pass.
Jul 26 2022
Failed Tests (3): LLVM :: CodeGen/AMDGPU/optimize-negated-cond-exec-masking-wave32.mir LLVM :: CodeGen/AMDGPU/optimize-negated-cond-exec-masking.mir LLVM :: CodeGen/Hexagon/expand-condsets-def-undef.mir
Yes, I was too optimistic: the patch fixes "Multiple connected components in live interval" issues in AMDGPU/* tests but reveals next issue related to incorrect updates of ranges.
Regarding Hexagon/expand-condsets-def-undef.mir test issue - it is steel about multiple connected components.
Jul 25 2022
Jul 8 2022
Gentle ping...
Jul 7 2022
Jun 27 2022
@MatzeB, @qcolombet, would you please have a look?
Jun 24 2022
LiveIntervals dumps for the test, before the patch:
Before first move:
%1 [16r,32r:0) 0@16r L0000000000000003 [16r,32r:0) 0@16r L000000000000000C [16r,32r:0) 0@16r weight:0.000000e+00 %2 [32r,32d:0) 0@32r weight:0.000000e+00 %3 [48r,64r:0)[64r,80r:1) 0@48r 1@64r L0000000000000003 [48r,80r:0) 0@48r L000000000000000C [64r,80r:0) 0@64r weight:0.000000e+00 %4 [80r,80d:0) 0@80r weight:0.000000e+00 RegMasks: ********** MACHINEINSTRS ********** # Machine code for function func: NoPHIs
Jun 17 2022
Jun 10 2022
Jay, you are completely correct. Sorry I didn't mention the same info as in dependent review. Updated the description.
Jun 9 2022
Beautified test.
Beautified test.
Jun 8 2022
Addressed comments.
Jun 7 2022
ping...
Jun 6 2022
May 30 2022
Apr 8 2022
Apr 5 2022
It seems to me Cost::RateFormula() form LSR is the only user that can be affected by the change. Would you please double-look the use case?
Jan 19 2022
Dec 22 2021
Dec 17 2021
Dec 13 2021
Dec 10 2021
Fixed SLOW/FAST misplacement in test
Updated test as requested.
Dec 9 2021
Dec 8 2021
Dec 7 2021
Needs a test.
Dec 2 2021
Dec 1 2021
Oct 1 2021
Sep 30 2021
Ping...
Sep 29 2021
Sep 27 2021
Sep 23 2021
Sep 22 2021
Thanks!
Sep 20 2021
Sep 16 2021
Fixed all clang-tidy warnings except "invalid case style".
Sep 8 2021
Addressed comment.