User Details
- User Since
- Mar 27 2014, 8:40 AM (426 w, 1 d)
Apr 8 2022
Apr 5 2022
It seems to me Cost::RateFormula() form LSR is the only user that can be affected by the change. Would you please double-look the use case?
Jan 19 2022
Dec 22 2021
Dec 17 2021
Dec 13 2021
Dec 10 2021
Fixed SLOW/FAST misplacement in test
Updated test as requested.
Dec 9 2021
Dec 8 2021
Dec 7 2021
Needs a test.
Dec 2 2021
Dec 1 2021
Oct 1 2021
Sep 30 2021
Ping...
Sep 29 2021
Sep 27 2021
Sep 23 2021
Sep 22 2021
Thanks!
Sep 20 2021
Sep 16 2021
Fixed all clang-tidy warnings except "invalid case style".
Sep 8 2021
Addressed comment.
Sep 7 2021
Aug 30 2021
Aug 25 2021
Fixed clang-tidy errors.
Aug 24 2021
Yes, I'm going to try additional NFC split out of parts like R600DAGToDAGISel, R600MCInstLower etc.
Removed no new line messages.
Aug 23 2021
Aug 20 2021
Thanks!
Can you please provide cmake config parameters (and possible toolchain description) to reproduce the issue?
Aug 18 2021
Did you mean the stack based on D108158?
Aug 17 2021
Fix typo.
Aug 16 2021
Using introduced LLVM_HOST_EXECUTABLE_SUFFIX variable to add the extension for native binary.
Aug 13 2021
Aug 12 2021
Using CMAKE_EXECUTABLE_SUFFIX, removed condition.
Aug 11 2021
Jun 29 2021
Jun 23 2021
AMDGPU tests LGTM, thanks!
Jun 15 2021
Changes in AMDGPU tests LGTM, thanks!
Jun 11 2021
Jun 10 2021
Jun 4 2021
Jun 3 2021
Jun 2 2021
Yes, using InstructionCost as number of parts may be confusing, but
- The function is also used in line 7245 of LoopVectorize.cpp so "Transforms/LoopVectorize/AArch64/scalable-vf-hint.ll" test starts to assert in @test_no_sve just after getTypeLegalizationCost() returns invalid cost.
- The same logic was used for getRegUsageForType() in D102541 for number of registers so I decided to repeat it here.
Do not call expectedCost(VF) second time just for assert.
Jun 1 2021
May 31 2021
Ooops, sorry for pinging.
Rebased, ping.
May 21 2021
May 20 2021
May 19 2021
Gentle ping...
May 14 2021
@sdesmalen this is needed to return from getTypeLegalizationCost() invalid costs, so at some point invalid legalization should be processed to a reg usage value, instead of asserting in Optional<>::getValue().
What do you think, should it be processed explicitly in LV or yet in BasicTTIImplBase<>::getRegUsageForType?
In latter case, what reg usage value should it return for invalid (e.g. scalable vectors) legalization cost?
Yes, I thought about packing offset to MemDepResult, but it is already a packed pointer with other info and it seems to be overkill to double its size for a quite rare offset value.
May 13 2021
getDependency() call is just a start of processing in GVN, and MemoryDependenceResults contains a number of a load' dependencies. One of them was NonLocal clobbering dependency between %tmp4.1 = load i8... and %tmp6.1 = load atomic i8... since latter is atomic (e.g. MemoryDependenceAnalysis.cpp$494-500). And GVN got this clobbering dependency not from getDependency().