Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

dfukalov (Daniil Fukalov)
Compiler Engineer at AMD

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2014, 8:40 AM (495 w, 5 d)

Recent Activity

Sep 5 2022

dfukalov committed rG51d33afcbe0a: [RegisterCoalescer] Fix crash on early clobbered subreg operands. (authored by dfukalov).
[RegisterCoalescer] Fix crash on early clobbered subreg operands.
Sep 5 2022, 10:43 PM · Restricted Project, Restricted Project
dfukalov closed D127136: [RegisterCoalescer] Fix crash on early clobbered subreg operands..
Sep 5 2022, 10:42 PM · Restricted Project, Restricted Project
dfukalov committed rG99d364d1f430: [MachineVerifier] Fix crash on early clobbered subreg operands. (authored by dfukalov).
[MachineVerifier] Fix crash on early clobbered subreg operands.
Sep 5 2022, 7:09 AM · Restricted Project, Restricted Project
dfukalov closed D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..
Sep 5 2022, 7:08 AM · Restricted Project, Restricted Project
dfukalov updated the diff for D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Removed redundant parenses.

Sep 5 2022, 6:28 AM · Restricted Project, Restricted Project
dfukalov added inline comments to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..
Sep 5 2022, 5:20 AM · Restricted Project, Restricted Project
dfukalov updated the diff for D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Addressed comment.

Sep 5 2022, 5:19 AM · Restricted Project, Restricted Project

Sep 2 2022

dfukalov committed rGb4e1b0e00d5d: [LiveIntervals] Split live intervals on any dead def (authored by dfukalov).
[LiveIntervals] Split live intervals on any dead def
Sep 2 2022, 10:00 AM · Restricted Project, Restricted Project
dfukalov closed D130477: [LiveIntervals] Split live intervals on any dead def.
Sep 2 2022, 10:00 AM · Restricted Project, Restricted Project

Sep 1 2022

dfukalov added inline comments to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..
Sep 1 2022, 6:39 AM · Restricted Project, Restricted Project
dfukalov added a comment to D130477: [LiveIntervals] Split live intervals on any dead def.

Ping...

Sep 1 2022, 6:37 AM · Restricted Project, Restricted Project

Aug 26 2022

dfukalov committed rG9c710ebbdb60: [TTI] NFC: Reduce InstructionCost::getValue() usage... (authored by dfukalov).
[TTI] NFC: Reduce InstructionCost::getValue() usage...
Aug 26 2022, 6:38 AM · Restricted Project, Restricted Project
dfukalov closed D103406: [TTI] NFC: Reduce InstructionCost::getValue() usage....
Aug 26 2022, 6:38 AM · Restricted Project, Restricted Project

Aug 25 2022

dfukalov updated the diff for D103406: [TTI] NFC: Reduce InstructionCost::getValue() usage....

Addressed comment, removed few more getValue() calls.

Aug 25 2022, 12:52 PM · Restricted Project, Restricted Project
dfukalov added a reviewer for D103406: [TTI] NFC: Reduce InstructionCost::getValue() usage...: RKSimon.
Aug 25 2022, 9:03 AM · Restricted Project, Restricted Project
dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Ping...

Aug 25 2022, 9:03 AM · Restricted Project, Restricted Project

Aug 22 2022

dfukalov added inline comments to D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo..
Aug 22 2022, 3:09 AM · Restricted Project, Restricted Project

Aug 17 2022

dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Ping...

Aug 17 2022, 4:36 PM · Restricted Project, Restricted Project
dfukalov updated the diff for D103406: [TTI] NFC: Reduce InstructionCost::getValue() usage....

Rebased...

Aug 17 2022, 4:35 PM · Restricted Project, Restricted Project
dfukalov updated the summary of D130477: [LiveIntervals] Split live intervals on any dead def.
Aug 17 2022, 2:43 PM · Restricted Project, Restricted Project
dfukalov committed rG7ed3d81333b7: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo. (authored by dfukalov).
[NFCI] Move cost estimation from TargetLowering to TargetTransformInfo.
Aug 17 2022, 2:39 PM · Restricted Project, Restricted Project
dfukalov closed D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo..
Aug 17 2022, 2:39 PM · Restricted Project, Restricted Project

Aug 15 2022

dfukalov updated the diff for D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo..

Added comment/description for getTypeConversion()

Aug 15 2022, 1:56 PM · Restricted Project, Restricted Project
dfukalov added inline comments to D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo..
Aug 15 2022, 7:23 AM · Restricted Project, Restricted Project
dfukalov updated the diff for D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo..

Addressed comment.

Aug 15 2022, 3:56 AM · Restricted Project, Restricted Project

Aug 12 2022

dfukalov added inline comments to D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo..
Aug 12 2022, 1:13 AM · Restricted Project, Restricted Project
dfukalov committed rG5eeef48ed10c: [NFC] Split test to reduce time to run. (authored by dfukalov).
[NFC] Split test to reduce time to run.
Aug 12 2022, 12:44 AM · Restricted Project, Restricted Project
dfukalov closed D130920: [NFC] Split test to reduce time to run..
Aug 12 2022, 12:44 AM · Restricted Project, Restricted Project
dfukalov updated the diff for D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo..

Rebased.
I thought we should wait for additional opinions on the patch...

Aug 12 2022, 12:38 AM · Restricted Project, Restricted Project

Aug 11 2022

dfukalov added a comment to D130920: [NFC] Split test to reduce time to run..

Ping...

Aug 11 2022, 2:48 PM · Restricted Project, Restricted Project
dfukalov updated the diff for D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Addresses comments.

Aug 11 2022, 7:16 AM · Restricted Project, Restricted Project

Aug 2 2022

dfukalov updated the diff for D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Moved warning skipping into checkLivenessAtDef() to get back some checks.

Aug 2 2022, 5:28 AM · Restricted Project, Restricted Project

Aug 1 2022

dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

I guess Jay already posted the liveness info. It seems this is related to CalcLiveRangeUtilBase::createDeadDef moving definitions to the early clobber slot when there's an early-clobber and a normal def. Judging by the longer explanation in that function this is probably deliberate and we have to blame the MachineVerifier here. But that means you should fix the machine verifier and not just disable a whole subset of tests!

Aug 1 2022, 2:41 PM · Restricted Project, Restricted Project
dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Ping - the patch with D127136 are fixing https://github.com/RadeonOpenCompute/ROCm/issues/1486...

Aug 1 2022, 12:41 PM · Restricted Project, Restricted Project
dfukalov updated the diff for D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Using pipeliner instead of RC as dummy pass.

Aug 1 2022, 12:38 PM · Restricted Project, Restricted Project
dfukalov requested review of D130920: [NFC] Split test to reduce time to run..
Aug 1 2022, 11:02 AM · Restricted Project, Restricted Project

Jul 26 2022

dfukalov added a comment to D130477: [LiveIntervals] Split live intervals on any dead def.

With D129208 + D130477 I get:

Failed Tests (3):
  LLVM :: CodeGen/AMDGPU/optimize-negated-cond-exec-masking-wave32.mir
  LLVM :: CodeGen/AMDGPU/optimize-negated-cond-exec-masking.mir
  LLVM :: CodeGen/Hexagon/expand-condsets-def-undef.mir

Yes, I was too optimistic: the patch fixes "Multiple connected components in live interval" issues in AMDGPU/* tests but reveals next issue related to incorrect updates of ranges.
Regarding Hexagon/expand-condsets-def-undef.mir test issue - it is steel about multiple connected components.

Jul 26 2022, 3:08 PM · Restricted Project, Restricted Project

Jul 25 2022

dfukalov requested review of D130477: [LiveIntervals] Split live intervals on any dead def.
Jul 25 2022, 5:36 AM · Restricted Project, Restricted Project

Jul 8 2022

dfukalov committed rG77d97be0aa0f: [NFC] Fix cvt_f32_ubyte.ll test. (authored by dfukalov).
[NFC] Fix cvt_f32_ubyte.ll test.
Jul 8 2022, 11:19 AM · Restricted Project, Restricted Project
dfukalov closed D129328: [NFC] Fix cvt_f32_ubyte.ll test..
Jul 8 2022, 11:19 AM · Restricted Project, Restricted Project
dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Gentle ping...

Jul 8 2022, 6:09 AM · Restricted Project, Restricted Project
dfukalov committed rG6858a17f66f6: [LiveIntervals] Fix incorrect range (re)construction from subranges. (authored by dfukalov).
[LiveIntervals] Fix incorrect range (re)construction from subranges.
Jul 8 2022, 6:07 AM · Restricted Project, Restricted Project
dfukalov closed D128553: [LiveIntervals] Fix incorrect range (re)construction from subranges..
Jul 8 2022, 6:07 AM · Restricted Project, Restricted Project

Jul 7 2022

dfukalov requested review of D129328: [NFC] Fix cvt_f32_ubyte.ll test..
Jul 7 2022, 1:46 PM · Restricted Project, Restricted Project

Jun 27 2022

dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

@MatzeB, @qcolombet, would you please have a look?

Jun 27 2022, 6:34 AM · Restricted Project, Restricted Project

Jun 24 2022

dfukalov added a comment to D128553: [LiveIntervals] Fix incorrect range (re)construction from subranges..

LiveIntervals dumps for the test, before the patch:
Before first move:

%1 [16r,32r:0) 0@16r  L0000000000000003 [16r,32r:0) 0@16r  L000000000000000C [16r,32r:0) 0@16r  weight:0.000000e+00
%2 [32r,32d:0) 0@32r  weight:0.000000e+00
%3 [48r,64r:0)[64r,80r:1) 0@48r 1@64r  L0000000000000003 [48r,80r:0) 0@48r  L000000000000000C [64r,80r:0) 0@64r  weight:0.000000e+00
%4 [80r,80d:0) 0@80r  weight:0.000000e+00
RegMasks:
********** MACHINEINSTRS **********
# Machine code for function func: NoPHIs
Jun 24 2022, 12:44 PM · Restricted Project, Restricted Project
dfukalov requested review of D128553: [LiveIntervals] Fix incorrect range (re)construction from subranges..
Jun 24 2022, 12:43 PM · Restricted Project, Restricted Project

Jun 17 2022

dfukalov added inline comments to D127731: WIP: [MachineVerifier] Try harder to verify analyses.
Jun 17 2022, 11:27 PM · Restricted Project, Restricted Project

Jun 10 2022

dfukalov added inline comments to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..
Jun 10 2022, 1:21 PM · Restricted Project, Restricted Project
dfukalov updated the summary of D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..
Jun 10 2022, 3:24 AM · Restricted Project, Restricted Project
dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Jay, you are completely correct. Sorry I didn't mention the same info as in dependent review. Updated the description.

Jun 10 2022, 3:24 AM · Restricted Project, Restricted Project

Jun 9 2022

dfukalov updated the diff for D127136: [RegisterCoalescer] Fix crash on early clobbered subreg operands..

Beautified test.

Jun 9 2022, 7:30 AM · Restricted Project, Restricted Project
dfukalov added inline comments to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..
Jun 9 2022, 7:10 AM · Restricted Project, Restricted Project
dfukalov updated the diff for D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

Beautified test.

Jun 9 2022, 7:09 AM · Restricted Project, Restricted Project

Jun 8 2022

dfukalov added a reviewer for D126661: [MachineVerifier] Fix crash on early clobbered subreg operands.: arsenm.
Jun 8 2022, 5:56 AM · Restricted Project, Restricted Project
dfukalov updated the diff for D127136: [RegisterCoalescer] Fix crash on early clobbered subreg operands..

Addressed comments.

Jun 8 2022, 5:55 AM · Restricted Project, Restricted Project

Jun 7 2022

dfukalov added a comment to D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..

ping...

Jun 7 2022, 2:10 AM · Restricted Project, Restricted Project

Jun 6 2022

dfukalov requested review of D127136: [RegisterCoalescer] Fix crash on early clobbered subreg operands..
Jun 6 2022, 11:07 AM · Restricted Project, Restricted Project

May 30 2022

dfukalov requested review of D126661: [MachineVerifier] Fix crash on early clobbered subreg operands..
May 30 2022, 8:41 AM · Restricted Project, Restricted Project

Apr 8 2022

dfukalov accepted D122850: [AMDGPU] Fix regression with vectorization limiting.
Apr 8 2022, 5:00 PM · Restricted Project, Restricted Project

Apr 5 2022

dfukalov added a comment to D122850: [AMDGPU] Fix regression with vectorization limiting.

It seems to me Cost::RateFormula() form LSR is the only user that can be affected by the change. Would you please double-look the use case?

Apr 5 2022, 10:12 AM · Restricted Project, Restricted Project

Jan 19 2022

dfukalov published D117723: [NFCI] Move cost estimation from TargetLowering to TargetTransformInfo. for review.
Jan 19 2022, 2:10 PM · Restricted Project, Restricted Project

Dec 22 2021

dfukalov committed rGa2120f6b4491: [NFC][AMDGPU][CostModel] Add tests for AMDGPU cost model, part 2. (authored by dfukalov).
[NFC][AMDGPU][CostModel] Add tests for AMDGPU cost model, part 2.
Dec 22 2021, 11:35 AM
dfukalov committed rGdeaedab14a2f: [NFC][AMDGPU][CostModel] Add tests for AMDGPU cost model. (authored by dfukalov).
[NFC][AMDGPU][CostModel] Add tests for AMDGPU cost model.
Dec 22 2021, 11:33 AM

Dec 17 2021

dfukalov added inline comments to D115927: [AA] Correctly maintain the sign of PartiaAlias offset.
Dec 17 2021, 6:59 AM · Restricted Project
dfukalov added inline comments to D115927: [AA] Correctly maintain the sign of PartiaAlias offset.
Dec 17 2021, 6:49 AM · Restricted Project

Dec 13 2021

dfukalov committed rGe5c64b45be39: [CostModel][AMDGPU] Fix intrinsics costs estimations. (authored by dfukalov).
[CostModel][AMDGPU] Fix intrinsics costs estimations.
Dec 13 2021, 6:18 AM
dfukalov closed D115385: [CostModel][AMDGPU] Fix intrinsics costs estimations..
Dec 13 2021, 6:17 AM · Restricted Project

Dec 10 2021

dfukalov updated the diff for D115385: [CostModel][AMDGPU] Fix intrinsics costs estimations..

Fixed SLOW/FAST misplacement in test

Dec 10 2021, 1:17 PM · Restricted Project
dfukalov updated the diff for D115385: [CostModel][AMDGPU] Fix intrinsics costs estimations..

Updated test as requested.

Dec 10 2021, 2:27 AM · Restricted Project

Dec 9 2021

dfukalov added inline comments to D115385: [CostModel][AMDGPU] Fix intrinsics costs estimations..
Dec 9 2021, 12:01 PM · Restricted Project
dfukalov added inline comments to D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls..
Dec 9 2021, 11:56 AM · Restricted Project, Restricted Project

Dec 8 2021

dfukalov added inline comments to D115385: [CostModel][AMDGPU] Fix intrinsics costs estimations..
Dec 8 2021, 2:15 PM · Restricted Project
dfukalov requested review of D115385: [CostModel][AMDGPU] Fix intrinsics costs estimations..
Dec 8 2021, 12:57 PM · Restricted Project
dfukalov added inline comments to D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls..
Dec 8 2021, 1:37 AM · Restricted Project, Restricted Project

Dec 7 2021

dfukalov added a comment to D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls..

Needs a test.

Dec 7 2021, 1:56 PM · Restricted Project, Restricted Project

Dec 2 2021

dfukalov committed rGab05ab59a7bd: [CostModel][AMDGPU] Fix instructions costs estimation for vector types. (authored by dfukalov).
[CostModel][AMDGPU] Fix instructions costs estimation for vector types.
Dec 2 2021, 4:08 PM
dfukalov closed D114893: [CostModel][AMDGPU] Fix instructions costs estimation for vector types..
Dec 2 2021, 4:08 PM · Restricted Project

Dec 1 2021

dfukalov added inline comments to D114893: [CostModel][AMDGPU] Fix instructions costs estimation for vector types..
Dec 1 2021, 4:11 PM · Restricted Project
dfukalov requested review of D114893: [CostModel][AMDGPU] Fix instructions costs estimation for vector types..
Dec 1 2021, 11:06 AM · Restricted Project

Oct 1 2021

dfukalov committed rG47d6274d4c31: [NFC][AMDGPU] Reduce includes dependencies, part 2 (authored by dfukalov).
[NFC][AMDGPU] Reduce includes dependencies, part 2
Oct 1 2021, 7:50 AM
dfukalov closed D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2.
Oct 1 2021, 7:50 AM · Restricted Project

Sep 30 2021

dfukalov added a reviewer for D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2: rampitec.

Ping...

Sep 30 2021, 10:47 AM · Restricted Project
dfukalov committed rGcf362ff4cab3: [NFC][AMDGPU] Improve cost model tests coverage. (authored by dfukalov).
[NFC][AMDGPU] Improve cost model tests coverage.
Sep 30 2021, 8:15 AM

Sep 29 2021

dfukalov committed rG6a187f9a5755: [NFC][AMDGPU] Add missing gfx90a test cases to fsub.ll. (authored by dfukalov).
[NFC][AMDGPU] Add missing gfx90a test cases to fsub.ll.
Sep 29 2021, 11:57 AM

Sep 27 2021

dfukalov committed rG1f73f0c19d87: [NFC][AMDGPU] Update cost model tests: (authored by dfukalov).
[NFC][AMDGPU] Update cost model tests:
Sep 27 2021, 9:26 AM

Sep 23 2021

dfukalov committed rG4f28a2eb037d: [NFC] Refactor tests to improve readability. (authored by dfukalov).
[NFC] Refactor tests to improve readability.
Sep 23 2021, 3:58 PM

Sep 22 2021

dfukalov added inline comments to D110100: [NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types..
Sep 22 2021, 10:17 AM · Restricted Project
dfukalov committed rG1a7b7d7ba232: [NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types. (authored by dfukalov).
[NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types.
Sep 22 2021, 10:17 AM
dfukalov closed D110100: [NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types..
Sep 22 2021, 10:16 AM · Restricted Project
dfukalov added a comment to D110242: [Target][CodeGen] Remove default CostKind arguments on inner/impl TTI overrides.

Thanks!

Sep 22 2021, 7:50 AM · Restricted Project
dfukalov added a comment to D110100: [NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types..

Do you think we should stop using default cost kinds entirely?

I think this would be for the best, and I thought I already changed most of the calls to be explicit.

@dfukalov Is this something you'd be willing to do in this patch? At least for getInstructionCost + getInterleavedMemoryOpCost (TTI + Impl)?

Sep 22 2021, 4:11 AM · Restricted Project

Sep 20 2021

dfukalov requested review of D110100: [NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types..
Sep 20 2021, 12:47 PM · Restricted Project

Sep 16 2021

dfukalov added inline comments to D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2.
Sep 16 2021, 3:42 PM · Restricted Project
dfukalov updated the diff for D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2.

Fixed all clang-tidy warnings except "invalid case style".

Sep 16 2021, 3:41 PM · Restricted Project

Sep 8 2021

dfukalov updated the diff for D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2.

Addressed comment.

Sep 8 2021, 1:18 AM · Restricted Project

Sep 7 2021

dfukalov requested review of D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2.
Sep 7 2021, 3:26 AM · Restricted Project

Aug 30 2021

dfukalov committed rG5b3fad496615: [AMDGPU][CostModel] Update shuffle instruction tests. NFC. (authored by dfukalov).
[AMDGPU][CostModel] Update shuffle instruction tests. NFC.
Aug 30 2021, 9:19 AM

Aug 25 2021

dfukalov planned changes to D108285: [NFC][AMDGPU] Cleanup attributor' util functions and table..
Aug 25 2021, 3:02 AM · Restricted Project
dfukalov committed rG48958d02d294: [NFC][AMDGPU] Reduce includes dependencies. (authored by dfukalov).
[NFC][AMDGPU] Reduce includes dependencies.
Aug 25 2021, 2:02 AM