This aligns the SCF dialect file layout with the majority of the dialects.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
More consistency is good and update for downstream users mechanical, so LGTM
mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h | ||
---|---|---|
13–14 | Transforms transforms feels a bit strange, for many others I believe this would have been passes file (which is also not that accurate, patterns and passes would be more, but most others it is just passes and convenient shorthand). Keeping the move mostly mechanical is good though |
mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h | ||
---|---|---|
13–14 | There's already Transforms/Passes.h and Transforms/Patterns.h, these things are more like standalone transform functions. Maybe Transforms/Utils.h? |
Transforms transforms feels a bit strange, for many others I believe this would have been passes file (which is also not that accurate, patterns and passes would be more, but most others it is just passes and convenient shorthand). Keeping the move mostly mechanical is good though