This is an archive of the discontinued LLVM Phabricator instance.

[mlir] move SCF headers to SCF/{IR,Transforms} respectively
ClosedPublic

Authored by ftynse on Jun 17 2022, 6:21 AM.

Details

Diff Detail

Event Timeline

ftynse created this revision.Jun 17 2022, 6:21 AM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: sjarus. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
ftynse requested review of this revision.Jun 17 2022, 6:21 AM
ftynse planned changes to this revision.Jun 17 2022, 6:25 AM
ftynse updated this revision to Diff 437878.Jun 17 2022, 6:48 AM

Fix moves

jpienaar accepted this revision.Jun 17 2022, 6:56 AM

More consistency is good and update for downstream users mechanical, so LGTM

mlir/include/mlir/Dialect/SCF/Transforms.h
0

Transforms transforms feels a bit strange, for many others I believe this would have been passes file (which is also not that accurate, patterns and passes would be more, but most others it is just passes and convenient shorthand). Keeping the move mostly mechanical is good though

This revision is now accepted and ready to land.Jun 17 2022, 6:56 AM
ftynse marked an inline comment as done.Jun 17 2022, 7:01 AM
ftynse added inline comments.
mlir/include/mlir/Dialect/SCF/Transforms.h
0

There's already Transforms/Passes.h and Transforms/Patterns.h, these things are more like standalone transform functions. Maybe Transforms/Utils.h?

ftynse updated this revision to Diff 437907.Jun 17 2022, 8:09 AM
ftynse marked an inline comment as done.

Rebase

ftynse updated this revision to Diff 437936.Jun 17 2022, 9:20 AM

Fix after rebase

ftynse updated this revision to Diff 437955.Jun 17 2022, 10:00 AM

More rebase

This revision was landed with ongoing or failed builds.Jun 20 2022, 1:18 AM
This revision was automatically updated to reflect the committed changes.
mlir/include/mlir/Dialect/SCF/Patterns.h