This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Update clang & llvm release notes for HLSL
ClosedPublic

Authored by beanz on Jun 15 2022, 11:38 AM.

Details

Summary

Adding release note entries for LLVM & Clang to introduce the HLSL &
DirectX support that is being added.

Diff Detail

Event Timeline

beanz created this revision.Jun 15 2022, 11:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 11:38 AM
beanz requested review of this revision.Jun 15 2022, 11:38 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 15 2022, 11:38 AM
aaron.ballman accepted this revision.Jun 15 2022, 12:27 PM

Thanks for adding the release notes! LGTM aside from some minor nits (take em or leave em).

clang/docs/ReleaseNotes.rst
72
75
This revision is now accepted and ready to land.Jun 15 2022, 12:27 PM
MaskRay accepted this revision.Jun 15 2022, 12:41 PM
MaskRay added inline comments.
clang/docs/ReleaseNotes.rst
72

The sentences may be simplified as:

Experimental support for HLSL has been added. <if needed, add more information how experimental it is>

The doc is about Clang, so many occurrences of Clang are redundant.

llvm/docs/ReleaseNotes.rst
119

DirectX has been added as an experimental target.
Specify `-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=DirectX` in your CMake configuration to enable it. The target is not packaged in pre-built binaries.

"LLVM tree" does not convey more information.

beanz updated this revision to Diff 437672.Jun 16 2022, 12:38 PM

Updates based on review feedback. Thank you!

MaskRay added inline comments.Jun 16 2022, 12:44 PM
llvm/docs/ReleaseNotes.rst
120

Fix indentation and use two backsticks.

beanz updated this revision to Diff 438419.Jun 20 2022, 8:40 AM

Updates based on feeback from @MaskRay. Thank you!

This revision was landed with ongoing or failed builds.Jun 27 2022, 10:41 AM
This revision was automatically updated to reflect the committed changes.