This patch is needed because developers expect "GCCBuiltin" items to be the GCC intrinsics equivalent and not the Clang internals.
LGTM for libc++abi once my comment is addressed, which should make the libc++ CI pass. Please don't submit this until you have a green check-mark from the libc++ CI.
Comment applies to test_demangle.pass.cpp (it's a binary file so I can't comment on it). The test is currently failing because you need to change _ZN4llvm9Intrinsic25getIntrinsicForClangBuiltinEPKcS2_ to _ZN4llvm9Intrinsic27getIntrinsicForClangBuiltinEPKcS2_.
I finally took time to fix the failing test.
For some reason, I can't seem to push without marking libcxxabi/test/test_demangle.pass.cpp as a binary file with arc diff HEAD~2 --update D127460. I hope this is fine...
Why are you messing with test_demangle.pass.cpp? The demangler doesn't care what symbols we actually define in LLVM... it's just a bunch of hardcoded testcases. So it doesn't matter if it continues to refer to GCCBuiltin.
Other changes look fine.
I think it should for coherency. I'll send an update.
When replacing with CLANG, it cannot build. After some investigations, it's because of this:
llvm/utils/TableGen/IntrinsicEmitter.cpp:908: OS << "#ifdef GET_LLVM_INTRINSIC_FOR_" << CompilerName << "_BUILTIN\n";
So I'll let it as is for the time.
This is my first LLVM contribution so I don't think I do? If I do have a commit access anyway, do you have a link to the documentation where it explains what I'm supposed to do by any chance?
I updated the description to explain why it is needed. I'm not sure how big it's supposed to be so I didn't enter into the details though.
Thanks! Once this is approved, I'll do it then.
So from the documentation:
Prior to obtaining commit access, it is common practice to request that someone with commit access commits on your behalf. When doing so, please provide the name and email address you would like to use in the Author property of the commit.
So as git commit author I use:
"Guillaume Gomez <firstname.lastname@example.org>"
Can someone commit on my behalf please?
Thanks in advance!