Page MenuHomePhabricator

GuillaumeGomez (Guillaume Gomez)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2022, 3:59 AM (8 w, 3 d)

Recent Activity

Jun 22 2022

GuillaumeGomez updated the diff for D127460: Rename GCCBuiltin into ClangBuiltin.
  • Rename GCCBuiltin into ClangBuiltin
  • Update #define name as well
  • Rename IsGCC function parameter into IsClang
Jun 22 2022, 11:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

So from the documentation:

Jun 22 2022, 5:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

Patch description needs to be added, especially answer the question why we should rename it, why we want it..

Jun 22 2022, 5:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated the diff for D127460: Rename GCCBuiltin into ClangBuiltin.

Rename GCCBuiltin into ClangBuiltin.

Jun 22 2022, 5:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

This is my first LLVM contribution so I don't think I do? If I do have a commit access anyway, do you have a link to the documentation where it explains what I'm supposed to do by any chance?

Jun 22 2022, 2:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

Is there anything else for me to do in here so it gets merged? (Sorry if I missed it but I couldn't find out the exact merge process in the documentation)

Jun 22 2022, 2:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 14 2022

GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

Fixed @spatel's comment.

Jun 14 2022, 12:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated the diff for D127460: Rename GCCBuiltin into ClangBuiltin.
  • Update #define name as well
  • Rename IsGCC function parameter into IsClang
Jun 14 2022, 12:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

Applied @RKSimon's suggestion.

Jun 14 2022, 7:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated the diff for D127460: Rename GCCBuiltin into ClangBuiltin.

Rename IsGCC function parameter into IsClang

Jun 14 2022, 7:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

I applied the changes suggested by @RKSimon and @efriedma.

Jun 14 2022, 7:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated the diff for D127460: Rename GCCBuiltin into ClangBuiltin.

Update #define as well

Jun 14 2022, 7:22 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added inline comments to D127460: Rename GCCBuiltin into ClangBuiltin.
Jun 14 2022, 4:20 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

@efriedma It was falling the tests because of that, which is why I updated it.

Jun 14 2022, 1:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 13 2022

GuillaumeGomez added 1 blocking reviewer(s) for D127460: Rename GCCBuiltin into ClangBuiltin: Restricted Project.

I finally took time to fix the failing test.

Jun 13 2022, 12:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated the diff for D127460: Rename GCCBuiltin into ClangBuiltin.

Fix libcxxabi mangling test

Jun 13 2022, 12:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated the diff for D127460: Rename GCCBuiltin into ClangBuiltin.

Fix libcxxabi mangling test

Jun 13 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 9 2022

GuillaumeGomez added a comment to D127409: Fix GCC intrinsics "round_mask" names.

As you suggested, I opened https://reviews.llvm.org/D127460 to rename GCCBuiltin into ClangBuiltin to clarify the confusion.

Jun 9 2022, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated subscribers of D127460: Rename GCCBuiltin into ClangBuiltin.

As mentioned in https://reviews.llvm.org/D127409, it would avoid confusions to name it ClangBuiltin instead of keeping GCCBuiltin.

Jun 9 2022, 4:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez requested review of D127460: Rename GCCBuiltin into ClangBuiltin.
Jun 9 2022, 4:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127409: Fix GCC intrinsics "round_mask" names.

Just to have a vague idea of what this change would look like, I pushed it. It would make our lives much simpler if we could rely on GCCBuiltin (aka ClangBuiltin) though.

Jun 9 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez updated the diff for D127409: Fix GCC intrinsics "round_mask" names.

Fix GCC intrinsics "round_mask" names

Jun 9 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127409: Fix GCC intrinsics "round_mask" names.

Oh I see. Then should I close this patch and open another one for just renaming GCCBuiltin into ClangBuiltin?

Jun 9 2022, 2:15 PM · Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127409: Fix GCC intrinsics "round_mask" names.

It doesn't pass the check-clang (putting the output just below). I'll fix it. Also, the files are still maintained and got very recent updates, hence why I think it was worth it to send this patch.

Jun 9 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a reviewer for D127409: Fix GCC intrinsics "round_mask" names: ftynse.
Jun 9 2022, 12:19 PM · Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez added a comment to D127409: Fix GCC intrinsics "round_mask" names.

We encountered this issue while working on https://github.com/rust-lang/rustc_codegen_gcc (the GCC backend of the Rust compiler).

Jun 9 2022, 8:55 AM · Restricted Project, Restricted Project, Restricted Project
GuillaumeGomez requested review of D127409: Fix GCC intrinsics "round_mask" names.
Jun 9 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project