Added a new target ompt mode that depends on libomptarget OMPT support.
Added tests that verify callbacks for target regions, kernel launch,
and data transfer operations. All of them should pass on amdgpu using
make check-libomptarget.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
@mhalk Can this be landed on top of trunk today? I would be interested in landing this one on top of what we have today so that we get some test coverage as part of "make check". You will need to update the tests to match the current code and update the tests as patches 4-7 land.
I see this patch still depends on D127367. Can you remove this dependency, update the CHECK lines if not done already, and verify?
Thanks.
Removed dependency on previous patches.
Note: Tests will now check for failed callback registrations.
@jhuber6 Is this patch ok to land? This will provide some test coverage to the existing OMPT target functionality, the device-independent part. As plugin-specific changes land, these tests will have to be updated.
Just to reiterate what I think this does is: It adds tests which currently ensure that the call backs can not be registered (as it should).
The tests would then be updated for the other patches, when these call backs can be registered, right?
clang-format not found in user’s local PATH; not linting file.