Page MenuHomePhabricator

protze.joachim (Joachim Protze)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 4:45 AM (277 w, 4 d)

Recent Activity

Today

protze.joachim added a comment to D91944: OpenMP 5.0 metadirective.

I found two issues with this patch regarding the default clause:

  • The spec does not require a default clause. I get error: expected expression if I omit a default clause. The error is gone if I add default().
  • The spec does not allow an empty default() clause, but rather expects default(nothing)or omission of the default clause. This patch accepts the empty default clause.
Mon, Jan 18, 8:21 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jan 7

protze.joachim added a comment to D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM.

LGTM, and should work for the runtime tests.

Thu, Jan 7, 6:36 AM · Restricted Project, Restricted Project

Mon, Jan 4

protze.joachim added a comment to D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM.

Building runtimes is not part of building LLVM. It is different from building OpenMP using CMake argument LLVM_ENABLE_PROJECTS .

Mon, Jan 4, 1:17 AM · Restricted Project, Restricted Project

Sun, Jan 3

protze.joachim added a comment to D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM.

If I build llvm-project using an old compiler, the dependencies are necessary in order to have clang built before running the OpenMP tests. Dropping the dependencies might cause issues in parallel builds, but will make the check-openmp targets incomplete.
What is the problem in having the dependency there?

Sun, Jan 3, 5:33 AM · Restricted Project, Restricted Project

Dec 17 2020

protze.joachim added a comment to D71989: [OpenMP][IRBuilder][WIP] Prototype `omp task` support.

Please consider the special cases of task_if0, which preferably should use __kmpc_omp_task_with_deps:

Dec 17 2020, 6:00 AM · Restricted Project, Restricted Project

Dec 10 2020

protze.joachim added inline comments to D93055: [OpenMP] Add time profiling for libomptarget.
Dec 10 2020, 3:16 PM · Restricted Project
protze.joachim added a comment to D81054: [OpenMP] Introduce target memory manager.

I'm surprised to find no dlclose matching the dlopen. Instead of calling some function for init/destroy, can't we just use library constructor/destructors in the plugin? All MemoryManagers for a plugin should then be destroyed before the plugin is explicitly dlclosed.
I'm also surprised that LoadRTLs does not dlclose the library in case of missing symbols.

Dec 10 2020, 1:50 PM · Restricted Project
protze.joachim added inline comments to D81054: [OpenMP] Introduce target memory manager.
Dec 10 2020, 8:53 AM · Restricted Project
protze.joachim added inline comments to D81054: [OpenMP] Introduce target memory manager.
Dec 10 2020, 8:44 AM · Restricted Project
protze.joachim requested review of D93034: [OpenMP][OMPT] Fix OMPT address handling after D92197.
Dec 10 2020, 7:48 AM · Restricted Project
protze.joachim updated the diff for D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc).

As discussed in yesterdays call, I marked the use of all __kmpc_ functions as deprecated and moved the declaration of those __kmpc functions into a new header file.
I also removed most OMPT-related changes from this patch and will open a separate differential for those. Therefore several OMPT tests fail after this patch.

Dec 10 2020, 4:47 AM · Restricted Project

Dec 5 2020

protze.joachim committed rGa148216b3129: [OpenMP][OMPT] Fix OMPT return address guard for gomp interface (authored by protze.joachim).
[OpenMP][OMPT] Fix OMPT return address guard for gomp interface
Dec 5 2020, 10:07 AM
protze.joachim closed D92121: [OpenMP][OMPT] Fix OMPT return address guard for gomp interface.
Dec 5 2020, 10:06 AM · Restricted Project

Dec 4 2020

protze.joachim committed rGd3ec512b1d69: [OpenMP][OMPT] Make sure that 0 is never used as ID in tests (NFC) (authored by protze.joachim).
[OpenMP][OMPT] Make sure that 0 is never used as ID in tests (NFC)
Dec 4 2020, 9:43 AM

Dec 1 2020

protze.joachim added a comment to D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc).

I'm not convinced. I didn't go over everything but I think we should discuss the goal and choices here first.

I checked the OmptReturnAddressGuard and it looks like it is a noop to store a return address if one is set already, right? (assuming same thread)
Could we unconditionally execute OMPT_STORE_RETURN_ADDRESS(gtid); instead to avoid the _aux stuff?

Dec 1 2020, 12:54 PM · Restricted Project

Nov 30 2020

protze.joachim requested review of D92351: [OpenMP][OMPT] Introduce guards to handle OMPT frame pointers.
Nov 30 2020, 3:19 PM · Restricted Project
protze.joachim updated the diff for D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc).

Replace the KMP_ASSERT by KMP_DEBUG_ASSERT.
Fixing several corner cases

Nov 30 2020, 2:57 PM · Restricted Project
protze.joachim committed rGfd3d1b09c12f: [OpenMP][Tests][NFC] Use FileCheck from cmake config (authored by protze.joachim).
[OpenMP][Tests][NFC] Use FileCheck from cmake config
Nov 30 2020, 2:17 PM

Nov 29 2020

protze.joachim committed rG723be4042a3a: [OpenMP][OMPT][NFC] Fix failing test (authored by protze.joachim).
[OpenMP][OMPT][NFC] Fix failing test
Nov 29 2020, 10:13 AM
protze.joachim committed rGcdf9401df84e: [OpenMP][OMPT][NFC] Fix flaky test (authored by protze.joachim).
[OpenMP][OMPT][NFC] Fix flaky test
Nov 29 2020, 10:13 AM

Nov 26 2020

protze.joachim added inline comments to D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc).
Nov 26 2020, 3:46 PM · Restricted Project
protze.joachim requested review of D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc).
Nov 26 2020, 3:33 PM · Restricted Project
protze.joachim added a comment to D91692: [OpenMP][OMPT] Introduce a guard to handle OMPT return address.

This broke building with OMPT disabled, but I went ahead and pushed a fix for that in 6b429668ded1aa7de4d586fc6dc8a469799b4d9c, by moving OmptReturnAddressGuard to inside the OMPT_SUPPORT ifdef.

Nov 26 2020, 2:52 AM · Restricted Project

Nov 25 2020

protze.joachim requested review of D92121: [OpenMP][OMPT] Fix OMPT return address guard for gomp interface.
Nov 25 2020, 12:02 PM · Restricted Project
protze.joachim committed rG6d3b81664a4b: [OpenMP][OMPT] Introduce a guard to handle OMPT return address (authored by protze.joachim).
[OpenMP][OMPT] Introduce a guard to handle OMPT return address
Nov 25 2020, 9:23 AM
protze.joachim committed rGb281a05dacb4: [OpenMP][OMPT] Implement verbose tool loading (authored by Isabel Thärigen <thaerigen@itc.rwth-aachen.de>).
[OpenMP][OMPT] Implement verbose tool loading
Nov 25 2020, 9:23 AM
protze.joachim closed D91692: [OpenMP][OMPT] Introduce a guard to handle OMPT return address.
Nov 25 2020, 9:23 AM · Restricted Project
protze.joachim closed D91464: [OpenMP][OMPT] Implement verbose tool loading.
Nov 25 2020, 9:23 AM · Restricted Project

Nov 22 2020

protze.joachim updated the diff for D91464: [OpenMP][OMPT] Implement verbose tool loading.

Also include OMP_TOOL_VERBOSE_INIT in the output for OMP_DISPLAY_ENV as requested.

Nov 22 2020, 1:01 PM · Restricted Project
protze.joachim updated the diff for D91464: [OpenMP][OMPT] Implement verbose tool loading.

Use macros for the conditional verbose output.
We also added a test for the archer-specific output.

Nov 22 2020, 12:16 PM · Restricted Project

Nov 18 2020

protze.joachim requested review of D91692: [OpenMP][OMPT] Introduce a guard to handle OMPT return address.
Nov 18 2020, 2:34 AM · Restricted Project

Nov 17 2020

protze.joachim added a comment to D90971: [OpenMP] Add OpenMP 5.1 omp_realloc function implementation.

The tests have the same format type issue as in D90967. Feel free to include the fixes for the calloc tests in this review.

Nov 17 2020, 3:53 AM · Restricted Project
protze.joachim added a comment to D90967: [OpenMP] Add OpenMP 5.1 omp_calloc function implementation.

Testing with cmake . -DOPENMP_TEST_FLAGS="-Werror -Wno-#warnings" && ninja check-libomp breaks for the newly added tests.

Nov 17 2020, 3:48 AM · Restricted Project

Nov 16 2020

protze.joachim committed rGfdc9dfc8e477: [OpenMP][Tool] Add Archer option to disable data race analysis for sequential… (authored by protze.joachim).
[OpenMP][Tool] Add Archer option to disable data race analysis for sequential…
Nov 16 2020, 1:49 AM
protze.joachim closed D90473: [OpenMP][Tool] Add Archer option to disable data race analysis for sequential part.
Nov 16 2020, 1:49 AM · Restricted Project

Nov 13 2020

protze.joachim requested review of D91464: [OpenMP][OMPT] Implement verbose tool loading.
Nov 13 2020, 2:58 PM · Restricted Project
protze.joachim committed rG96eaacc917a2: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values (authored by protze.joachim).
[OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values
Nov 13 2020, 7:10 AM
protze.joachim closed D90758: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values.
Nov 13 2020, 7:10 AM · Restricted Project
protze.joachim updated the diff for D90473: [OpenMP][Tool] Add Archer option to disable data race analysis for sequential part.

I added run lines to the tests with race, to verify that the races are still detected, if ignore_serial=1 .

Nov 13 2020, 3:54 AM · Restricted Project

Nov 12 2020

protze.joachim updated the diff for D90758: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values.

I acknowledge the advantage of switch statements, in that they will warn on missing cases in the future. So, I went back to the switch statements.

Nov 12 2020, 3:31 AM · Restricted Project

Nov 11 2020

protze.joachim added a comment to D90752: [OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes.

Are all uses of on_ompt_callback_master expected to be replaced?
I see this is still using it:
https://github.com/llvm/llvm-project/blob/master/openmp/tools/multiplex/tests/custom_data_storage/first-tool.h#L126

Nov 11 2020, 4:45 PM · Restricted Project
protze.joachim committed rG25b3164bfbe6: [OpenMP][Tools][Tests] Fix ompt multiplex test (authored by protze.joachim).
[OpenMP][Tools][Tests] Fix ompt multiplex test
Nov 11 2020, 4:44 PM
protze.joachim added inline comments to D81314: [OpenMP][Tool] Handle detached tasks in Archer.
Nov 11 2020, 11:21 AM · Restricted Project
protze.joachim committed rG3fa2e1933840: [OpenMP][Tool] Fix possible NULL-pointer dereference in test (authored by protze.joachim).
[OpenMP][Tool] Fix possible NULL-pointer dereference in test
Nov 11 2020, 11:16 AM
protze.joachim committed rGce0911b3e919: [OpenMP][Tests] Fix compiler warnings in OpenMP runtime tests (authored by protze.joachim).
[OpenMP][Tests] Fix compiler warnings in OpenMP runtime tests
Nov 11 2020, 11:16 AM
protze.joachim committed rG6213ed062b6e: [OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes (authored by protze.joachim).
[OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes
Nov 11 2020, 11:16 AM
protze.joachim closed D91280: [OpenMP][Tests] Fix compiler warnings in OpenMP tests.
Nov 11 2020, 11:16 AM · Restricted Project
protze.joachim closed D90752: [OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes.
Nov 11 2020, 11:15 AM · Restricted Project
protze.joachim added a reviewer for D91280: [OpenMP][Tests] Fix compiler warnings in OpenMP tests: AndreyChurbanov.
Nov 11 2020, 9:51 AM · Restricted Project
protze.joachim requested review of D91280: [OpenMP][Tests] Fix compiler warnings in OpenMP tests.
Nov 11 2020, 9:50 AM · Restricted Project
protze.joachim updated the diff for D90752: [OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes.

The ompt_callback_master_t type is deprecated, but not removed. So, omp-tools.h still needs to define the type.
I moved the existing master.c test to masked.c and added a new master.c test, which just tries to register the deprecated callback.

Nov 11 2020, 8:12 AM · Restricted Project

Nov 10 2020

protze.joachim added inline comments to D90758: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values.
Nov 10 2020, 6:37 AM · Restricted Project
protze.joachim added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

Please revert your commit while you work on a fix, as it breaks building the runtime code.

Nov 10 2020, 5:31 AM · Restricted Project, Restricted Project
protze.joachim added inline comments to D90752: [OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes.
Nov 10 2020, 4:50 AM · Restricted Project

Nov 9 2020

protze.joachim added a comment to D90971: [OpenMP] Add OpenMP 5.1 omp_realloc function implementation.

Can we have tests for ptr = NULL, size=0? Probably just replace alloc and free by these cases and check returned address after each call?

Nov 9 2020, 1:19 AM · Restricted Project

Nov 5 2020

protze.joachim committed rG7b0ca32b6228: [OpenMP] avoid warning: equality comparison with extraneous parentheses (authored by protze.joachim).
[OpenMP] avoid warning: equality comparison with extraneous parentheses
Nov 5 2020, 3:22 AM
protze.joachim closed D90756: [OpenMP] avoid warning: equality comparison with extraneous parentheses.
Nov 5 2020, 3:22 AM · Restricted Project
protze.joachim added a comment to D81314: [OpenMP][Tool] Handle detached tasks in Archer.

Original intention was to have if(0) on the first task. Unfortunately, clang drops the out dependency for detached tasks in that case: https://bugs.llvm.org/show_bug.cgi?id=46185
Once the clang bug is fixed, we can add the if(0) and make the test more robust.

Nov 5 2020, 1:46 AM · Restricted Project

Nov 4 2020

protze.joachim requested review of D90758: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values.
Nov 4 2020, 3:48 AM · Restricted Project
protze.joachim requested review of D90756: [OpenMP] avoid warning: equality comparison with extraneous parentheses.
Nov 4 2020, 3:33 AM · Restricted Project
protze.joachim updated the diff for D90752: [OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes.

This implies also some changes to the OMPT tests

Nov 4 2020, 3:17 AM · Restricted Project
protze.joachim requested review of D90752: [OpenMP][OMPT] Update the omp-tools header file to reflect 5.1 changes.
Nov 4 2020, 2:35 AM · Restricted Project
protze.joachim closed D81314: [OpenMP][Tool] Handle detached tasks in Archer.

Pushed as e99207feb4b901e8f7bb6d3e70388d31fafc4330, missed to include the Revision line.

Nov 4 2020, 2:23 AM · Restricted Project

Nov 3 2020

protze.joachim added a comment to D81054: [OpenMP] Introduce target memory manager.

I tested this with older clang releases (at least back to clang 9.0) and could reproduce the assertion. The error doesn't seem to be related to this patch, but the test just reveals the issue.

Nov 3 2020, 11:29 AM · Restricted Project
protze.joachim committed rGeaed9e6b56b2: [OpenMP][Tools] clang-format Archer (NFC) (authored by protze.joachim).
[OpenMP][Tools] clang-format Archer (NFC)
Nov 3 2020, 7:54 AM
protze.joachim committed rG71041a8b6bc4: [OpenMP][libomptarget][Tests] fix failing test (authored by protze.joachim).
[OpenMP][libomptarget][Tests] fix failing test
Nov 3 2020, 4:33 AM
protze.joachim committed rGb0eb19bf8af4: [OpenMP][OMPT][NFC] Fix flaky test (authored by protze.joachim).
[OpenMP][OMPT][NFC] Fix flaky test
Nov 3 2020, 4:33 AM
protze.joachim committed rGe99207feb4b9: [OpenMP][Tool] Handle detached tasks in Archer (authored by protze.joachim).
[OpenMP][Tool] Handle detached tasks in Archer
Nov 3 2020, 4:33 AM

Nov 2 2020

protze.joachim added a comment to D81054: [OpenMP] Introduce target memory manager.

The test asserts for x86 offloading:

Nov 2 2020, 2:32 PM · Restricted Project
protze.joachim accepted D90642: [OpenMP] Fixed an issue in the test case parallel_offloading_map.

lgtm

Nov 2 2020, 1:53 PM · Restricted Project
protze.joachim added a comment to D74145: [OpenMP][Offloading] Added support for multiple streams so that multiple kernels can be executed concurrently.

The test started to fail recently

Nov 2 2020, 1:14 PM · Restricted Project

Oct 30 2020

protze.joachim requested review of D90473: [OpenMP][Tool] Add Archer option to disable data race analysis for sequential part.
Oct 30 2020, 8:58 AM · Restricted Project

Oct 29 2020

protze.joachim updated the diff for D81314: [OpenMP][Tool] Handle detached tasks in Archer.

Fixed handling of ompt_task_cancel.

Oct 29 2020, 10:19 AM · Restricted Project

Oct 27 2020

protze.joachim requested changes to D90078: [OpenMP] Fix potentially inconsistent OMPT return address.
Oct 27 2020, 4:07 PM · Restricted Project
protze.joachim added a comment to D90078: [OpenMP] Fix potentially inconsistent OMPT return address.

This will break many cases, where GOMP or even kmp functions call external kmpc functions rather than only internal kmp functions. In such case, the return address will point to the runtime function.
The idea of the macro is to ensure that only the first entry to the runtime will set the address.
Before we can make this change (and I would be more than happy about this change ;), we need to make sure, that no runtime code calls the external __kmpc interface (at least, if the external function tries to store the return address).

Oct 27 2020, 4:06 PM · Restricted Project

Oct 21 2020

protze.joachim accepted D89426: [libomptarget] Require LLVM source tree to build libomptarget.

lgtm

Oct 21 2020, 8:33 AM · Restricted Project

Oct 16 2020

protze.joachim added a comment to D89426: [libomptarget] Require LLVM source tree to build libomptarget.

ENABLE_LIBOMPTARGET determines the initial default value for OPENMP_ENABLE_LIBOMPTARGET. Therefore the variable is only relevant in the first cmake run, but has no effect in successive cmake or ccmake configures. It will never overwrite the value of OPENMP_ENABLE_LIBOMPTARGET.

Oct 16 2020, 8:49 AM · Restricted Project
protze.joachim added a comment to D89426: [libomptarget] Require LLVM source tree to build libomptarget.

In openmp/CMakeLists.txt there is ENABLE_LIBOMPTARGET to decide about the default value for the CMake option OPENMP_ENABLE_LIBOMPTARGET. This way libomptarget gets disabled on apple and win32 by default.

Oct 16 2020, 7:19 AM · Restricted Project
protze.joachim added a comment to D89426: [libomptarget] Require LLVM source tree to build libomptarget.

Will it still be possible to build the OpenMP runtime without LLVM headers/sources? Can we disable libomptarget if LLVM headers are not available?

Oct 16 2020, 5:27 AM · Restricted Project

Oct 5 2020

protze.joachim committed rG69f87400a85e: [OpenMP][Archer][Tests] NFC: fix spurious test failure (authored by protze.joachim).
[OpenMP][Archer][Tests] NFC: fix spurious test failure
Oct 5 2020, 3:28 PM
protze.joachim committed rG34b34e90fc32: [OpenMP][Tests] NFC: fix flaky test failure caused by rare scheduling (authored by protze.joachim).
[OpenMP][Tests] NFC: fix flaky test failure caused by rare scheduling
Oct 5 2020, 7:59 AM

Sep 30 2020

protze.joachim committed rG23419bfd1c8f: [OpenMP][libarcher] Allow all possible argument separators in TSAN_OPTIONS (authored by protze.joachim).
[OpenMP][libarcher] Allow all possible argument separators in TSAN_OPTIONS
Sep 30 2020, 4:19 PM
protze.joachim closed D87144: [openmp] Allow all possible argument separators in TSAN_OPTIONS.
Sep 30 2020, 4:19 PM · Restricted Project, Restricted Project
protze.joachim committed rG6104b30446aa: [OpenMP][OMPT] Update OMPT tests for newly added GOMP interface patches (authored by protze.joachim).
[OpenMP][OMPT] Update OMPT tests for newly added GOMP interface patches
Sep 30 2020, 3:59 PM
protze.joachim committed rG55cff5b28865: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant (authored by protze.joachim).
[OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant
Sep 30 2020, 3:58 PM
protze.joachim closed D87680: [OpenMP][OMPT] Update OMPT tests for newly added GOMP interface patches.
Sep 30 2020, 3:58 PM · Restricted Project
protze.joachim closed D88149: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant.
Sep 30 2020, 3:58 PM · Restricted Project

Sep 25 2020

protze.joachim added a comment to D65880: [Driver] Move LIBRARY_PATH before user inputs.

I still see some clang-specific and system link directories listed in the linker line before the directories from LIBRARY_PATH:

Sep 25 2020, 6:51 AM · Restricted Project, Restricted Project

Sep 24 2020

protze.joachim updated the diff for D88149: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant.

Removed HOST_DEVICE definition from the header as suggested in the reviews.

Sep 24 2020, 4:31 AM · Restricted Project
protze.joachim accepted D87267: [OpenMP] Introduce GOMP mutexinoutset in the runtime.

With the OMPT tests succeeding, this patch looks good to me.

Sep 24 2020, 4:24 AM · Restricted Project
protze.joachim accepted D87144: [openmp] Allow all possible argument separators in TSAN_OPTIONS.

Can you push the patch or should I?

Sep 24 2020, 4:19 AM · Restricted Project, Restricted Project

Sep 23 2020

protze.joachim updated the diff for D88149: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant.

Removed accidently added printf from a test.

Sep 23 2020, 6:06 AM · Restricted Project
protze.joachim requested review of D88149: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant.
Sep 23 2020, 6:03 AM · Restricted Project

Sep 21 2020

protze.joachim accepted D87271: [OpenMP] Fix if0 task with dependencies.

LGTM, the relevant OMPT tests pass with this patch

Sep 21 2020, 7:20 AM · Restricted Project
protze.joachim requested changes to D87144: [openmp] Allow all possible argument separators in TSAN_OPTIONS.

Can you add a test?

Sep 21 2020, 7:18 AM · Restricted Project, Restricted Project

Sep 20 2020

protze.joachim accepted D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.

LGTM as well.

Sep 20 2020, 3:35 PM · Restricted Project

Sep 15 2020

protze.joachim added inline comments to D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.
Sep 15 2020, 5:10 AM · Restricted Project
protze.joachim updated the summary of D87680: [OpenMP][OMPT] Update OMPT tests for newly added GOMP interface patches.
Sep 15 2020, 3:30 AM · Restricted Project
protze.joachim added a comment to D87267: [OpenMP] Introduce GOMP mutexinoutset in the runtime.

With this patch, I would expect runtime/test/ompt/tasks/dependences_mutexinoutset.c to succeed. Running the test with gcc-9/10, this test reports the dependency as ompt_dependence_type_inout and not ompt_dependence_type_mutexinoutset. Since the OMPT interface just translates the internal values, I assume something is wrong with the flags of the dependency.

Sep 15 2020, 3:29 AM · Restricted Project
protze.joachim requested review of D87680: [OpenMP][OMPT] Update OMPT tests for newly added GOMP interface patches.
Sep 15 2020, 3:27 AM · Restricted Project