Page MenuHomePhabricator

protze.joachim (Joachim Protze)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 4:45 AM (177 w, 4 d)

Recent Activity

Mon, Feb 11

protze.joachim added a comment to D56804: Fix thread_limits to work properly for teams construct.

Since there is only one other ICV which might be handled similary (bind-var), I will not further argue for making a special case for thread-limit-var. So leave it as it is.

Mon, Feb 11, 1:16 AM · Restricted Project, Restricted Project
protze.joachim accepted D58002: [OMPT] Remove test output from source tree.

LGTM, thanks for catching this!
The output is written to the build dir anyways:

Mon, Feb 11, 1:02 AM · Restricted Project, Restricted Project

Thu, Feb 7

protze.joachim added inline comments to D56804: Fix thread_limits to work properly for teams construct.
Thu, Feb 7, 6:04 AM · Restricted Project, Restricted Project
protze.joachim requested changes to D57469: Set exit_frame in master task before calling a user's outlined function for a parallel loop construct.

Please provide test cases, so that we can understand the impact of this change.

Thu, Feb 7, 4:03 AM · Restricted Project
protze.joachim added a comment to D56804: Fix thread_limits to work properly for teams construct.

I'm a bit confused about the explicit copy per task.

Thu, Feb 7, 3:47 AM · Restricted Project, Restricted Project

Mon, Feb 4

protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

The code is updated to be compatible with OMPT as in OpenMP 5.0.

Mon, Feb 4, 8:38 AM
protze.joachim committed rG0c599c388dbb: [OMPT] Make sure that OMPT is enabled when accessing internals of the runtime (authored by protze.joachim).
[OMPT] Make sure that OMPT is enabled when accessing internals of the runtime
Mon, Feb 4, 8:00 AM

Fri, Jan 25

protze.joachim added a comment to D55725: [OpenMP] Add libs to clang-dedicated directories.
  • libgomp.so, libiomp5.so: My understanding is that these symlinks exist solely for backward compatibility. This patch currently doesn't affect them (doesn't bother to install them to Clang-dedicated directories). Any reason to change that?
Fri, Jan 25, 7:47 AM · Restricted Project

Jan 16 2019

protze.joachim added reviewers for D56775: [OpenMP] Remove compiler warning about unused value: hbae, AndreyChurbanov.
Jan 16 2019, 1:57 AM
protze.joachim created D56775: [OpenMP] Remove compiler warning about unused value.
Jan 16 2019, 1:56 AM
protze.joachim added a comment to D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

The patch in general looks good to me.

Jan 16 2019, 1:05 AM
protze.joachim updated the diff for D56397: [OpenMP] Silence warning about fallthrough.

Updated as requested

Jan 16 2019, 12:46 AM · Restricted Project

Jan 15 2019

protze.joachim updated the diff for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.

Fix the last mentioning of ompt.h

Jan 15 2019, 7:25 AM
protze.joachim added a comment to D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.

Is this good to go for 8.0?

Jan 15 2019, 1:36 AM

Jan 10 2019

protze.joachim updated the diff for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.

Implemented changes by Hansang.

Jan 10 2019, 1:12 AM

Jan 9 2019

protze.joachim added a comment to rL317115: [OpenMP] Fix race condition in omp_init_lock.

Does the observation in https://bugs.llvm.org/show_bug.cgi?id=36772 match your expectation regarding the remaining race?

Jan 9 2019, 3:43 AM

Jan 8 2019

protze.joachim updated the diff for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
  • I activated the omp_get_initial_device() call to get the number at runtime.
  • I also changed the name of ompt.h to omp-tools.h as defined in the SPEC
Jan 8 2019, 8:39 AM

Jan 7 2019

protze.joachim closed D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.

Implemented in r349458.
Missed to include the review number in the commit message

Jan 7 2019, 9:38 AM
protze.joachim created D56397: [OpenMP] Silence warning about fallthrough.
Jan 7 2019, 9:30 AM · Restricted Project

Jan 2 2019

protze.joachim accepted D55788: Fix performance regression in SPEC kdtree test.

LGTM

Jan 2 2019, 8:27 AM · Restricted Project
protze.joachim added a comment to D55578: Add omp_get_device_num() and update several other device API functions (FIXED).

Is the intention to have this ready for the 8.0 release?

Jan 2 2019, 3:36 AM · Restricted Project

Dec 18 2018

protze.joachim added inline comments to D55788: Fix performance regression in SPEC kdtree test.
Dec 18 2018, 3:21 AM · Restricted Project

Dec 17 2018

protze.joachim added inline comments to D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.
Dec 17 2018, 8:39 AM
protze.joachim updated the diff for D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.

Implemented most changes requested by Hansang

Dec 17 2018, 8:38 AM

Dec 12 2018

protze.joachim added inline comments to D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
Dec 12 2018, 12:51 AM
protze.joachim added a child revision for D55578: Add omp_get_device_num() and update several other device API functions (FIXED): D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
Dec 12 2018, 12:46 AM · Restricted Project
protze.joachim added a parent revision for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates: D55578: Add omp_get_device_num() and update several other device API functions (FIXED).
Dec 12 2018, 12:46 AM

Dec 11 2018

protze.joachim added a child revision for D55577: [OMPT] First chunk of final OMPT 5.0 interface updates: D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
Dec 11 2018, 2:19 PM
protze.joachim added a parent revision for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates: D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.
Dec 11 2018, 2:19 PM
protze.joachim created D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
Dec 11 2018, 2:19 PM
protze.joachim created D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.
Dec 11 2018, 2:03 PM
protze.joachim planned changes to D45890: [OMPT] Add implementation and tests of Archer tool.

This will not compile with the current version of the OMPT interface, needs updates first

Dec 11 2018, 9:16 AM

Nov 14 2018

protze.joachim accepted D54347: Rename ompt_mutex_impl_unknown to ompt_mutex_impl_none.

LGTM

Nov 14 2018, 6:14 AM · Restricted Project

Oct 19 2018

protze.joachim created D53442: Initialize variables before assignment in asm.
Oct 19 2018, 10:11 AM

Sep 14 2018

protze.joachim accepted D52046: [OMPT] Fix unsafe initialization of ompt_data_t objects..

LGTM

Sep 14 2018, 6:15 AM · Restricted Project

Sep 11 2018

protze.joachim added a comment to D51687: [libomptarget-nvptx] Add testing infrastructure.

Considering your comment in the description about requiring latest Clang perhaps you should revisit this patch: D46842

Sep 11 2018, 8:57 AM

Sep 10 2018

protze.joachim accepted D50774: [OMPT] Update types according to TR7.

LGTM

Sep 10 2018, 7:34 AM

Aug 24 2018

protze.joachim added inline comments to D50774: [OMPT] Update types according to TR7.
Aug 24 2018, 1:06 AM

Aug 15 2018

protze.joachim accepted D48362: [OMPT] Remove OMPT idle callback.

Was hold back from 7.0, to keep the implementation according to TR6.

Aug 15 2018, 6:54 AM

Aug 13 2018

protze.joachim added a comment to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

@Hahnfeld and I discussed the behavior and found a very inconsistent behavior. Let's consider something like the following code, under the constraint, that device(1) is busy (will fail to offload) and device(0) is free:

Aug 13 2018, 4:03 AM

Aug 10 2018

protze.joachim accepted D50565: [OMPT] Make omp_control_tool() compliant when called from Fortran programs.

Thanks for catching this. It seems like we need some Fortran tests for OMPT.
LGTM

Aug 10 2018, 9:38 AM · Restricted Project
protze.joachim added a comment to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

So you like deciding available on first use? This is what your comment seems to imply, but I am not 100% sure.

Aug 10 2018, 4:08 AM

Aug 1 2018

protze.joachim accepted D50140: [OMPT] Fix taskloop testcase scheduling effects.

LGTM

Aug 1 2018, 9:15 AM

Jul 31 2018

protze.joachim accepted D50086: [OMPT] Disable by default on Windows.

I second this change, since this should hopefully allow to include OpenMP in the release build, until someone can fix the build of OMPT on Windows.

Jul 31 2018, 1:23 PM

Jul 27 2018

protze.joachim added a comment to D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

I would like to commit this patch before the 7.0 branch.
Changing the name of the bit can be done in a later patch.
@jmellorcrummey do you agree, can you remove your request for changes?

Jul 27 2018, 11:17 AM
protze.joachim accepted D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.

I apply changes requested by hbae on commit.

Jul 27 2018, 10:41 AM
protze.joachim accepted D49373: [OMPT] Print two more addresses in print_fuzzy_address_block().

LGTM

Jul 27 2018, 10:40 AM
protze.joachim accepted D49181: [OMPT] Adapt OMPT callback structure for tasks to handle untied tasks correctly (+ adapt testcase).

I apply suggested changes by hbae on commit.

Jul 27 2018, 10:36 AM

Jul 17 2018

protze.joachim accepted D49418: Also support several images for elf.

The change is symetric with what is implemented for cuda.
LGTM

Jul 17 2018, 8:38 AM
protze.joachim updated the summary of D49418: Also support several images for elf.
Jul 17 2018, 4:06 AM

Jul 5 2018

protze.joachim accepted D48984: [OpenMP] Define __STDC_FORMAT_MACROS in callback.h.

Lgtm

Jul 5 2018, 11:57 AM
protze.joachim accepted D48932: [OMPT] Add synchronization to threads_nested.c testcase.

LGTM

Jul 5 2018, 2:13 AM
protze.joachim accepted D48888: Dropped non-supoorted "--no-as-needed" flag from OMPT tests for macOS.

LGTM

Jul 5 2018, 2:11 AM

Jul 3 2018

protze.joachim added inline comments to D47824: [OMPT] Add testcases for thread_begin and thread_end callbacks.
Jul 3 2018, 12:54 PM
protze.joachim requested changes to D48888: Dropped non-supoorted "--no-as-needed" flag from OMPT tests for macOS.

As discussed on the mailing list, the flag should only be dropped on Mac OS. My pragmatic solution would be:

Jul 3 2018, 12:47 PM

Jun 20 2018

protze.joachim added a comment to D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

I think we should change the name of the bit ompt_enabled.enabled to ompt_enabled.activated. That would make joachim’s distinction clear. I was commenting on the setting of OMP_TOOL=enabled. There is a difference between enabled and activated.

Jun 20 2018, 8:40 AM

Jun 18 2018

protze.joachim added a comment to D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

The OMPT tool can decide at multiple points to be inactive, here we look at:

Jun 18 2018, 7:54 AM
protze.joachim added a comment to D48282: [OMPT] Use alloca() to force availability of frame pointer .

The problem, which gets visible in this test case is the use of __builtin_frame_address(1), which is documented to be not safe.
Is there a better way to get the canonical frame address of the calling function? Also the address returned by __builtin_frame_address seems to be different from the canonical frame address. How can we get the requested address?

Jun 18 2018, 7:28 AM

Jun 7 2018

protze.joachim added inline comments to D47903: [OpenMP] Use C++11 Atomics - barrier, tasking, and lock code.
Jun 7 2018, 2:19 PM · Restricted Project
protze.joachim added a comment to D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.

taskloop is actually a tasking construct and explicitly no worksharing construct. So, please move the test in the task directory.

Jun 7 2018, 8:54 AM

Jun 4 2018

protze.joachim added inline comments to D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.
Jun 4 2018, 1:40 PM

May 27 2018

protze.joachim accepted D47119: [OMPT] Fix test parallel/not_enough_threads.c.

LGTM

May 27 2018, 3:11 AM

May 10 2018

protze.joachim added a comment to D44881: [sanitizer_common] Ignore unloading of suppressed library.

@dvyukov thanks for the detailed reasoning.

May 10 2018, 11:27 AM

May 7 2018

protze.joachim created D46533: [OMPT] Provide the right thread_num for ancestor levels.
May 7 2018, 9:42 AM
protze.joachim accepted D43568: [OMPT] Rename ompt_frame_t to omp_frame_t.

Result of discussion in Tools WG was that the spec will keep omp_frame_t. I will submit this patch together with D43568

May 7 2018, 9:31 AM
protze.joachim created D46530: [OMPT] Rename ompt_wait_id to omp_wait_id.
May 7 2018, 9:28 AM
protze.joachim accepted D46260: [OMPT] Fix thread_num for implicit_task_end callbacks in nested parallel regions.

LGTM

May 7 2018, 5:46 AM

Apr 23 2018

protze.joachim added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.

Reasons to keep the name archer (or archer-rt):

  • We already have that name, we don't need to come up with a new name :)
  • You can easily find related publications under that name, which explain the reasoning behind the library
  • The programmer should never see the name, once the tool is integrated into the runtime workflow
Apr 23 2018, 2:12 AM

Apr 20 2018

protze.joachim created D45890: [OMPT] Add implementation and tests of Archer tool.
Apr 20 2018, 10:01 AM

Apr 17 2018

protze.joachim updated the diff for D44881: [sanitizer_common] Ignore unloading of suppressed library.

I added a testcase. I added it just for Linux, because I have no machine ready to test dl-loading on other OS.

Apr 17 2018, 8:52 AM

Apr 11 2018

protze.joachim added a reviewer for D44881: [sanitizer_common] Ignore unloading of suppressed library: vitalybuka.
Apr 11 2018, 1:55 AM

Mar 25 2018

protze.joachim updated the diff for D15154: [sanitizer_common] Enable external tool to register PrintfAndReportCallback.

I updated this differential to only export the function.

Mar 25 2018, 2:27 PM
protze.joachim created D44881: [sanitizer_common] Ignore unloading of suppressed library.
Mar 25 2018, 2:15 PM

Feb 28 2018

protze.joachim accepted D43882: [OMPT] Fix interoperability test with GCC.

LGTM.

Feb 28 2018, 1:24 PM
protze.joachim added reviewers for D43897: [OMPT] Fix task-type test with GCC: hbae, Hahnfeld.
Feb 28 2018, 1:14 PM
protze.joachim created D43897: [OMPT] Fix task-type test with GCC.
Feb 28 2018, 1:13 PM
protze.joachim added inline comments to D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase.
Feb 28 2018, 9:25 AM

Feb 23 2018

protze.joachim added a comment to D41942: [OMPT] Add interoperability testcase.

The idea was that the WAIT in line 11 should ensure that both initial threads arrived.
But actually the runtime is not initialized before line 11. To fix the race, we need to call into the runtime in a way, that makes both threads initial threads before the SIGNAL in line 9.

Feb 23 2018, 12:19 PM
protze.joachim accepted D43308: [OMPT] Fix parallel_data in implicit barrier-end.

LGTM

Feb 23 2018, 8:46 AM
protze.joachim accepted D43191: [OMPT] Fix test tasks/serialized.c with optimization.

LGTM

Feb 23 2018, 8:03 AM

Feb 22 2018

protze.joachim added a comment to D43568: [OMPT] Rename ompt_frame_t to omp_frame_t.

As far as I know, the current implementation is very close to the specification in TR6.
Here we have a tiny diff between the spec and the implementation. I agree that we should not apply this patch if we will roll back the change in the spec.

Feb 22 2018, 12:58 AM

Feb 19 2018

protze.joachim updated the diff for D43115: [OMPT] Fix inconsistent testcases.

Use the captured pattern as pointed out by Olga

Feb 19 2018, 3:24 AM

Feb 17 2018

protze.joachim added inline comments to D43308: [OMPT] Fix parallel_data in implicit barrier-end.
Feb 17 2018, 8:41 AM
protze.joachim requested changes to D43308: [OMPT] Fix parallel_data in implicit barrier-end.
Feb 17 2018, 6:46 AM
protze.joachim updated the diff for D43115: [OMPT] Fix inconsistent testcases.

The initial issue in this patch is resolved by D43195. So removed the additionally printed address for AARCH64, but still allow the testcases to match any printed address.

Feb 17 2018, 5:57 AM
protze.joachim added a comment to D41942: [OMPT] Add interoperability testcase.

I applied clang-format on commit.

Feb 17 2018, 1:45 AM

Feb 14 2018

protze.joachim added inline comments to D43191: [OMPT] Fix test tasks/serialized.c with optimization.
Feb 14 2018, 10:10 AM
protze.joachim added a comment to D43191: [OMPT] Fix test tasks/serialized.c with optimization.

This behavior is right (p.417,l.5):

Feb 14 2018, 10:10 AM

Feb 9 2018

protze.joachim created D43115: [OMPT] Fix inconsistent testcases.
Feb 9 2018, 3:26 AM

Feb 6 2018

protze.joachim added reviewers for D42472: [OMPT] Fix ompt_get_task_info() and add tests for it: hbae, omalyshe.
Feb 6 2018, 6:20 AM
protze.joachim added reviewers for D41904: [OMPT] Add tool_not_available testcase: hbae, omalyshe.
Feb 6 2018, 6:13 AM
protze.joachim added reviewers for D41942: [OMPT] Add interoperability testcase: hbae, omalyshe.
Feb 6 2018, 6:13 AM
protze.joachim added reviewers for D42166: [OMPT] Add tool_available_search testcase: hbae, omalyshe.
Feb 6 2018, 6:13 AM
protze.joachim added reviewers for D42162: [OMPT] Update api_calls testcase: omalyshe, hbae.
Feb 6 2018, 6:13 AM
protze.joachim added reviewers for D42169: [OMPT] Formatting: omalyshe, hbae.
Feb 6 2018, 4:54 AM
protze.joachim added reviewers for D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase: hbae, omalyshe.
Feb 6 2018, 4:54 AM

Jan 30 2018

protze.joachim added a reviewer for D42709: [OMPT] Fix tool initialization returning 0: omalyshe.
Jan 30 2018, 2:33 PM
protze.joachim created D42709: [OMPT] Fix tool initialization returning 0.
Jan 30 2018, 2:18 PM

Jan 25 2018

protze.joachim abandoned D42432: [OMPT] Limit omp_control_tool testcase to 5.0.

ok

Jan 25 2018, 10:17 AM
protze.joachim updated the diff for D42432: [OMPT] Limit omp_control_tool testcase to 5.0.

NEEDS must be REQUIRES

Jan 25 2018, 6:49 AM