Page MenuHomePhabricator

protze.joachim (Joachim Protze)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 4:45 AM (226 w, 5 d)

Recent Activity

Thu, Jan 23

protze.joachim added a comment to D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off.

I'm not sure LIBOMP_OMPT_SUPPORT is guaranteed to be there yet when defined in runtime/. Maybe it would be better to move the option to the top-level openmp/CMakeList.txt and rename it to OPENMP_OMPT_SUPPORT (with compatibility support for LIBOMP_OMPT_SUPPORT)

Thu, Jan 23, 9:25 AM · Restricted Project
protze.joachim accepted D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off.

LGTM

Thu, Jan 23, 9:25 AM · Restricted Project

Mon, Jan 20

protze.joachim added a comment to D72132: [OpenMP] affinity little fix for FreeBSD.

Code LGTM, if possible apply clang-format.

Mon, Jan 20, 9:30 AM · Restricted Project
protze.joachim added a comment to D72058: [OpenMP] Enabling CPU affinity on Darwin platform proposal.

As Johannes, I cannot test this. The code seems reasonable.
Please apply clang-format on the changes.

Mon, Jan 20, 2:07 AM · Restricted Project

Thu, Jan 16

protze.joachim updated subscribers of D72779: [OpenMP][Tool] Fix memory leak and double-allocation.

@hans please include to the 10.0 branch

Thu, Jan 16, 12:18 PM · Restricted Project
protze.joachim committed rG39f746d8def6: [OpenMP][Tool] Fix memory leak and double-allocation (authored by protze.joachim).
[OpenMP][Tool] Fix memory leak and double-allocation
Thu, Jan 16, 12:09 PM
protze.joachim closed D72779: [OpenMP][Tool] Fix memory leak and double-allocation.
Thu, Jan 16, 12:09 PM · Restricted Project
protze.joachim updated the diff for D72779: [OpenMP][Tool] Fix memory leak and double-allocation.

Agreed

Thu, Jan 16, 11:20 AM · Restricted Project

Wed, Jan 15

protze.joachim updated the diff for D72779: [OpenMP][Tool] Fix memory leak and double-allocation.

You are right, with the current usage a local variable works.

Wed, Jan 15, 5:56 PM · Restricted Project
protze.joachim resigned from D72576: [OpenMP][Offloading] Fix the issue that omp_get_num_devices returns wrong number of devices.

From OpenMP spec perspective I see no issue in returning 0 for the provided code even if there would be devices available, as long as this is consistent with the remaining execution of the application.

As I understand the modification, the function would not return 0 if afterwards a target region will be offloaded to a device?

Actually, no because of empty PendingCtorsDtors and empty target entries.

Ok.

Wed, Jan 15, 10:03 AM · Restricted Project
protze.joachim created D72779: [OpenMP][Tool] Fix memory leak and double-allocation.
Wed, Jan 15, 9:25 AM · Restricted Project

Tue, Jan 14

protze.joachim added a comment to D70412: [OpenMP][Tool] Runtime warning for missing TSan-option.

This revision was not accepted before being committed!

Tue, Jan 14, 8:47 PM · Restricted Project
protze.joachim committed rG2d4571bf3060: [OpenMP][Tool] Runtime warning for missing TSan-option (authored by protze.joachim).
[OpenMP][Tool] Runtime warning for missing TSan-option
Tue, Jan 14, 12:02 PM
protze.joachim closed D70412: [OpenMP][Tool] Runtime warning for missing TSan-option.
Tue, Jan 14, 12:02 PM · Restricted Project
protze.joachim added inline comments to D71987: [OpenMP][NFC] Add a couple of TODOs to the runtime.
Tue, Jan 14, 12:02 PM · Restricted Project
protze.joachim added a comment to D71987: [OpenMP][NFC] Add a couple of TODOs to the runtime.

The value merged_if0 is initialized in __kmp_task_alloc from the flags argument:
https://github.com/llvm/llvm-project/blob/master/openmp/runtime/src/kmp_tasking.cpp#L1287

Tue, Jan 14, 11:23 AM · Restricted Project
protze.joachim committed rGed810da73270: [OpenMP][Tool] Improving stack trace for Archer (authored by protze.joachim).
[OpenMP][Tool] Improving stack trace for Archer
Tue, Jan 14, 12:17 AM
protze.joachim closed D70408: [OpenMP][Tool] Improving stack trace for Archer.
Tue, Jan 14, 12:17 AM · Restricted Project
protze.joachim added inline comments to D71987: [OpenMP][NFC] Add a couple of TODOs to the runtime.
Tue, Jan 14, 12:07 AM · Restricted Project

Mon, Jan 13

protze.joachim committed rG84637408f2e6: [OpenMP][Tool] Make tests for archer dependent on TSan (authored by protze.joachim).
[OpenMP][Tool] Make tests for archer dependent on TSan
Mon, Jan 13, 11:49 PM
protze.joachim closed D71914: [OpenMP][Tool] Make tests for archer dependent on TSan.
Mon, Jan 13, 11:48 PM · Restricted Project
protze.joachim requested changes to D72576: [OpenMP][Offloading] Fix the issue that omp_get_num_devices returns wrong number of devices.

From OpenMP spec perspective I see no issue in returning 0 for the provided code even if there would be devices available, as long as this is consistent with the remaining execution of the application.

Mon, Jan 13, 9:35 PM · Restricted Project

Fri, Jan 10

protze.joachim set the repository for D70408: [OpenMP][Tool] Improving stack trace for Archer to rG LLVM Github Monorepo.
Fri, Jan 10, 4:10 AM · Restricted Project
protze.joachim added a comment to D71914: [OpenMP][Tool] Make tests for archer dependent on TSan.

This patch re-enables the testing of Archer for all builds where TSan is available.
I'd prefer to have this patch in the release for testing :)

Fri, Jan 10, 3:22 AM · Restricted Project
protze.joachim closed D70395: [OpenMP] Implementation of OMPT reduction callbacks.

Pushed as 3356e268.

Fri, Jan 10, 3:10 AM · Restricted Project

Dec 26 2019

protze.joachim added a reviewer for D71914: [OpenMP][Tool] Make tests for archer dependent on TSan: Hahnfeld.
Dec 26 2019, 1:38 PM · Restricted Project
protze.joachim updated subscribers of D71914: [OpenMP][Tool] Make tests for archer dependent on TSan.
Dec 26 2019, 1:37 PM · Restricted Project
protze.joachim created D71914: [OpenMP][Tool] Make tests for archer dependent on TSan.
Dec 26 2019, 1:37 PM · Restricted Project

Dec 10 2019

protze.joachim added a comment to D70395: [OpenMP] Implementation of OMPT reduction callbacks.

Yes. I was expecting functions but macros seems to be the solution used in this code so far.

Dec 10 2019, 2:59 AM · Restricted Project
protze.joachim updated the diff for D70395: [OpenMP] Implementation of OMPT reduction callbacks.

Macro outsourced to ompt_specific, which is included by both kmp source files.
Tested for LIBOMP_OMPT_SUPPORT on/off builds.

Dec 10 2019, 2:50 AM · Restricted Project

Nov 29 2019

protze.joachim updated the diff for D70395: [OpenMP] Implementation of OMPT reduction callbacks.

Implement requested changes.

Nov 29 2019, 8:53 AM · Restricted Project
protze.joachim added a comment to D70412: [OpenMP][Tool] Runtime warning for missing TSan-option.

The conclusion of the discussion in the intel forum thread was, that the call from __kmp_resume to __kmp_suspend_initialize_thread is superflous, because the thread will call __kmp_suspend_initialize_thread always during the own initialization before changing a variable to signal readiness.

Nov 29 2019, 7:25 AM · Restricted Project

Nov 22 2019

protze.joachim added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.
  • the tests rely on the availability of thread-sanitizer

The tests should be annotated as REQUIRES: tsan or whatever the appropriate tag is.

Nov 22 2019, 8:17 AM · Restricted Project
protze.joachim added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.

The newly added tests fail on buildbots: http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/236

Could you take a look? And please consider reverting in the meanwhile.

Nov 22 2019, 6:32 AM · Restricted Project

Nov 18 2019

protze.joachim updated the diff for D70412: [OpenMP][Tool] Runtime warning for missing TSan-option.

Attached the right diff.

Nov 18 2019, 3:40 PM · Restricted Project
protze.joachim created D70412: [OpenMP][Tool] Runtime warning for missing TSan-option.
Nov 18 2019, 3:40 PM · Restricted Project
protze.joachim created D70408: [OpenMP][Tool] Improving stack trace for Archer.
Nov 18 2019, 11:35 AM · Restricted Project
protze.joachim created D70395: [OpenMP] Implementation of OMPT reduction callbacks.
Nov 18 2019, 6:58 AM · Restricted Project
protze.joachim updated the diff for D70395: [OpenMP] Implementation of OMPT reduction callbacks.

Apply clang-format

Nov 18 2019, 6:58 AM · Restricted Project

Sep 24 2019

protze.joachim committed rG886a4ff977c1: [TSAN] Add read/write range interface functions with PC (authored by protze.joachim).
[TSAN] Add read/write range interface functions with PC
Sep 24 2019, 4:20 AM
protze.joachim added a comment to D67447: Enable tasks dependencies hashmaps resizing.

@viroulep do you have commit access or should we land that for you?

Sep 24 2019, 4:19 AM · Restricted Project, Restricted Project
protze.joachim added a comment to D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile..

You're wrong. My output:

omp_in_parallel=0
omp_get_level=1
omp_get_active_level=0

So, omp_in_parallel works correctly on GPU.

Sep 24 2019, 12:46 AM · Restricted Project

Sep 23 2019

protze.joachim added a comment to D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile..

It is probably not directly related to this patch, but I think the logic of omp_in_parallel() is not valid. It only works, because the level counting is also broken. This code

int main(){
#pragma omp target 
  #pragma omp parallel if(0)
    if(omp_get_thread_num()==0) {
      printf("omp_in_parallel=%i\n", omp_in_parallel()); 
      printf("omp_get_level=%i\n", omp_get_level()); 
      printf("omp_get_active_level=%i\n", omp_get_active_level()); 
    }
  return 0;
}

should print (and does so with env OMP_TARGET_OFFLOAD=disabled):

omp_in_parallel=0
omp_get_level=1
omp_get_active_level=0

As I understand the code for omp_in_parallel(), the example code would print omp_in_parallel=1 if the level would correctly be increased.

Sep 23 2019, 8:29 AM · Restricted Project

Sep 9 2019

protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

Removed the counters as requested

Sep 9 2019, 7:54 PM · Restricted Project

Sep 4 2019

protze.joachim added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Sep 4 2019, 9:07 AM · Restricted Project, Restricted Project

Aug 30 2019

protze.joachim added a comment to D66885: [TSan] Add read/write range interface functions with PC.

In this new test, I see the same issue related to race on stack variables as reported here:
https://github.com/google/sanitizers/issues/1134

Does it make the test fail? Or just produces a warning? We could switch to a heap-allocated block or a global.

Aug 30 2019, 12:43 AM · Restricted Project, Restricted Project

Aug 29 2019

protze.joachim updated the diff for D66885: [TSan] Add read/write range interface functions with PC.

I derived a test from java_race_pc.cc.

Aug 29 2019, 1:07 AM · Restricted Project, Restricted Project

Aug 28 2019

protze.joachim added a comment to D66885: [TSan] Add read/write range interface functions with PC.

Who are "we"? And you would prefer to call them where? ;)

Aug 28 2019, 10:06 AM · Restricted Project, Restricted Project
protze.joachim updated the summary of D66885: [TSan] Add read/write range interface functions with PC.
Aug 28 2019, 9:35 AM · Restricted Project, Restricted Project
protze.joachim created D66885: [TSan] Add read/write range interface functions with PC.
Aug 28 2019, 8:05 AM · Restricted Project, Restricted Project
protze.joachim abandoned D44881: [sanitizer_common] Ignore unloading of suppressed library.

TSAN_OPTIONS="ignore_noninstrumented_module=1" works for us

Aug 28 2019, 8:05 AM

Jul 29 2019

protze.joachim accepted D64025: Add OMPT support for teams construct.

The reported events look good to me.

Jul 29 2019, 2:57 PM · Restricted Project, Restricted Project

Jul 18 2019

protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

Removed the Fortran annotation functions :/
Fixed also the other comments

Jul 18 2019, 1:56 PM · Restricted Project
protze.joachim added inline comments to D45890: [OMPT] Add implementation and tests of Archer tool.
Jul 18 2019, 1:56 PM · Restricted Project

Jul 17 2019

protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

Addressed comments by Jonas.
The tests also support gcc now.

Jul 17 2019, 9:43 AM · Restricted Project
protze.joachim added inline comments to D45890: [OMPT] Add implementation and tests of Archer tool.
Jul 17 2019, 9:41 AM · Restricted Project

Jul 16 2019

protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

Removed a file which was mistakenly added

Jul 16 2019, 1:28 AM · Restricted Project
protze.joachim added inline comments to D45890: [OMPT] Add implementation and tests of Archer tool.
Jul 16 2019, 1:10 AM · Restricted Project
protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

Addressing Jonas' comments

Jul 16 2019, 1:08 AM · Restricted Project

Jun 21 2019

protze.joachim added a comment to D63599: Fixed memory use-after-free problem..

This patch fixes the bug for our usecase.
Thanks!

Jun 21 2019, 7:18 AM · Restricted Project, Restricted Project

Jun 19 2019

protze.joachim added inline comments to D62485: New implementation of OpenMP 5.0 detached tasks..
Jun 19 2019, 1:17 AM · Restricted Project, Restricted Project
protze.joachim added a comment to D62485: New implementation of OpenMP 5.0 detached tasks..

Are there any plans to add the code for the appropriate OMPT callbacks?

Jun 19 2019, 1:09 AM · Restricted Project, Restricted Project

May 20 2019

protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

Relicensed Archer under Apache license, updated the files.

May 20 2019, 8:43 AM · Restricted Project
protze.joachim committed rG4109d5606e23: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures (authored by protze.joachim).
[OpenMP][OMPT] Fix locking testcases for 32 bit architectures
May 20 2019, 7:20 AM
protze.joachim committed rG48b8a4b5190d: [OMPT] Handling of the events of initial-task-begin and initial-task-end (authored by protze.joachim).
[OMPT] Handling of the events of initial-task-begin and initial-task-end
May 20 2019, 7:20 AM

May 9 2019

protze.joachim accepted D61657: Add implementation to two OMPT API routines.

Great, thanks!
I like the approach with USE_PRIVATE_TOOL.

May 9 2019, 9:27 AM · Restricted Project

May 8 2019

protze.joachim added a comment to D61657: Add implementation to two OMPT API routines.

I think, a test for ompt_finalize_tool could be something along:

May 8 2019, 12:57 AM · Restricted Project
protze.joachim added a comment to D61657: Add implementation to two OMPT API routines.

The code looks good to me, thanks for fixing the implementation.

May 8 2019, 12:44 AM · Restricted Project

Mar 16 2019

protze.joachim added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

This code does not directly use pthreads, but uses C++11 threads.
Why does the compiler not link the necessary threading library, when using C++11 threads? I suggest to define a lit macro like %cxx11_thread which sets the necessary flags. I guess, that on Linux -fopenmp already implies linking the pthread library.

Mar 16 2019, 11:56 AM · Restricted Project, Restricted Project

Mar 1 2019

protze.joachim added inline comments to D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end.
Mar 1 2019, 1:08 AM · Restricted Project, Restricted Project

Feb 21 2019

protze.joachim added inline comments to D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.
Feb 21 2019, 6:45 AM · Restricted Project, Restricted Project
protze.joachim created D58506: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures (2).
Feb 21 2019, 6:42 AM · Restricted Project, Restricted Project
protze.joachim added inline comments to D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.
Feb 21 2019, 4:02 AM · Restricted Project, Restricted Project
protze.joachim committed rG8b96fad85cba: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures (authored by protze.joachim).
[OpenMP][OMPT] Fix locking testcases for 32 bit architectures
Feb 21 2019, 12:50 AM

Feb 20 2019

protze.joachim created D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.
Feb 20 2019, 8:31 AM · Restricted Project, Restricted Project

Feb 11 2019

protze.joachim added a comment to D56804: Fix thread_limits to work properly for teams construct.

Since there is only one other ICV which might be handled similary (bind-var), I will not further argue for making a special case for thread-limit-var. So leave it as it is.

Feb 11 2019, 1:16 AM · Restricted Project, Restricted Project
protze.joachim accepted D58002: [OMPT] Remove test output from source tree.

LGTM, thanks for catching this!
The output is written to the build dir anyways:

Feb 11 2019, 1:02 AM · Restricted Project, Restricted Project

Feb 7 2019

protze.joachim added inline comments to D56804: Fix thread_limits to work properly for teams construct.
Feb 7 2019, 6:04 AM · Restricted Project, Restricted Project
protze.joachim requested changes to D57469: Set exit_frame in master task before calling a user's outlined function for a parallel loop construct.

Please provide test cases, so that we can understand the impact of this change.

Feb 7 2019, 4:03 AM · Restricted Project
protze.joachim added a comment to D56804: Fix thread_limits to work properly for teams construct.

I'm a bit confused about the explicit copy per task.

Feb 7 2019, 3:47 AM · Restricted Project, Restricted Project

Feb 4 2019

protze.joachim updated the diff for D45890: [OMPT] Add implementation and tests of Archer tool.

The code is updated to be compatible with OMPT as in OpenMP 5.0.

Feb 4 2019, 8:38 AM · Restricted Project
protze.joachim committed rG0c599c388dbb: [OMPT] Make sure that OMPT is enabled when accessing internals of the runtime (authored by protze.joachim).
[OMPT] Make sure that OMPT is enabled when accessing internals of the runtime
Feb 4 2019, 8:00 AM

Jan 25 2019

protze.joachim added a comment to D55725: [OpenMP] Add libs to clang-dedicated directories.
  • libgomp.so, libiomp5.so: My understanding is that these symlinks exist solely for backward compatibility. This patch currently doesn't affect them (doesn't bother to install them to Clang-dedicated directories). Any reason to change that?
Jan 25 2019, 7:47 AM · Restricted Project

Jan 16 2019

protze.joachim added reviewers for D56775: [OpenMP] Remove compiler warning about unused value: hbae, AndreyChurbanov.
Jan 16 2019, 1:57 AM
protze.joachim created D56775: [OpenMP] Remove compiler warning about unused value.
Jan 16 2019, 1:56 AM
protze.joachim added a comment to D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

The patch in general looks good to me.

Jan 16 2019, 1:05 AM
protze.joachim updated the diff for D56397: [OpenMP] Silence warning about fallthrough.

Updated as requested

Jan 16 2019, 12:46 AM · Restricted Project

Jan 15 2019

protze.joachim updated the diff for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.

Fix the last mentioning of ompt.h

Jan 15 2019, 7:25 AM
protze.joachim added a comment to D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.

Is this good to go for 8.0?

Jan 15 2019, 1:36 AM

Jan 10 2019

protze.joachim updated the diff for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.

Implemented changes by Hansang.

Jan 10 2019, 1:12 AM

Jan 9 2019

protze.joachim added a comment to rL317115: [OpenMP] Fix race condition in omp_init_lock.

Does the observation in https://bugs.llvm.org/show_bug.cgi?id=36772 match your expectation regarding the remaining race?

Jan 9 2019, 3:43 AM

Jan 8 2019

protze.joachim updated the diff for D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
  • I activated the omp_get_initial_device() call to get the number at runtime.
  • I also changed the name of ompt.h to omp-tools.h as defined in the SPEC
Jan 8 2019, 8:39 AM

Jan 7 2019

protze.joachim closed D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.

Implemented in r349458.
Missed to include the review number in the commit message

Jan 7 2019, 9:38 AM
protze.joachim created D56397: [OpenMP] Silence warning about fallthrough.
Jan 7 2019, 9:30 AM · Restricted Project

Jan 2 2019

protze.joachim accepted D55788: Fix performance regression in SPEC kdtree test.

LGTM

Jan 2 2019, 8:27 AM · Restricted Project
protze.joachim added a comment to D55578: Add omp_get_device_num() and update several other device API functions (FIXED).

Is the intention to have this ready for the 8.0 release?

Jan 2 2019, 3:36 AM · Restricted Project

Dec 18 2018

protze.joachim added inline comments to D55788: Fix performance regression in SPEC kdtree test.
Dec 18 2018, 3:21 AM · Restricted Project

Dec 17 2018

protze.joachim added inline comments to D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.
Dec 17 2018, 8:39 AM
protze.joachim updated the diff for D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.

Implemented most changes requested by Hansang

Dec 17 2018, 8:38 AM

Dec 12 2018

protze.joachim added inline comments to D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
Dec 12 2018, 12:51 AM