protze.joachim (Joachim Protze)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 4:45 AM (120 w, 5 d)

Recent Activity

Thu, Jan 11

protze.joachim added a comment to D41817: [OMPT] Enable OMPT on 32-bit ARM machines.

Ah, I think I understand your plan now.

Thu, Jan 11, 4:30 AM · Restricted Project
protze.joachim added inline comments to D41942: [OMPT] Add interoperability testcase.
Thu, Jan 11, 4:18 AM
protze.joachim accepted D41167: [OMPT] Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread.

LGTM

Thu, Jan 11, 2:51 AM
protze.joachim accepted D41182: [OMPT] Add Workaround for Intel Compiler Bug.

LGTM

Thu, Jan 11, 1:37 AM
protze.joachim added a comment to D41817: [OMPT] Enable OMPT on 32-bit ARM machines.
Library built with: Clang  | GCC
Testing with:              |
Clang               works  | fails
GCC                 fails  | fails
Thu, Jan 11, 1:08 AM · Restricted Project

Wed, Jan 10

protze.joachim accepted D41831: Minor code cleanup.

Ok, I think, I now understood the change.

Wed, Jan 10, 4:37 AM

Tue, Jan 9

protze.joachim added a comment to D41182: [OMPT] Add Workaround for Intel Compiler Bug.

@omalyshe AFAIK this issue is Case#: 03138964

Tue, Jan 9, 9:32 AM
protze.joachim accepted D41853: [OMPT] Fix cast and printf of wait_id in lock test.

I would have expected, that

printf("%" PRIu64 ": &lock: %lu\n", ompt_get_thread_data()->value, (unsigned long) &lock);

would also fix the issue.

Tue, Jan 9, 9:30 AM
protze.joachim added a comment to D41817: [OMPT] Enable OMPT on 32-bit ARM machines.

As I understand the issue, this is not a fault in the test code, but the value provided by parallel-begin is wrong? In that case, I suggest to pass NULL for this architecture/compiler.

Tue, Jan 9, 9:02 AM · Restricted Project
protze.joachim added inline comments to D41831: Minor code cleanup.
Tue, Jan 9, 6:56 AM
protze.joachim added inline comments to D41831: Minor code cleanup.
Tue, Jan 9, 5:38 AM
protze.joachim added inline comments to D41831: Minor code cleanup.
Tue, Jan 9, 5:28 AM

Mon, Jan 8

protze.joachim added a comment to D41817: [OMPT] Enable OMPT on 32-bit ARM machines.

I didn't even know these tests are allowed to be compiled with anything else than clang 6.0+...

Mon, Jan 8, 8:30 AM · Restricted Project

Tue, Jan 2

protze.joachim updated the diff for D41508: [OMPT] Build runtime with OMPT support by default.

Updated the README

Tue, Jan 2, 3:46 AM
protze.joachim updated the diff for D41508: [OMPT] Build runtime with OMPT support by default.

Updated the README

Tue, Jan 2, 3:25 AM

Sun, Dec 24

protze.joachim updated the diff for D41508: [OMPT] Build runtime with OMPT support by default.

Removed 32 bit ARM from the list of supported architectures until it is tested.

Sun, Dec 24, 7:00 AM

Sat, Dec 23

protze.joachim accepted D41165: [OMPT] Set frame address when creating a task with dependences.
Sat, Dec 23, 6:50 AM
protze.joachim added a comment to D41165: [OMPT] Set frame address when creating a task with dependences.

Does the latest change assume current_task == new_taskdata->td_parent (which would make sense to me)? If not this change has more implications than the frame address.

Sat, Dec 23, 6:50 AM
protze.joachim updated the diff for D41508: [OMPT] Build runtime with OMPT support by default.

I added the requirement for hardware architecture support to LIBOMP_HAVE_OMPT_SUPPORT.
This way one would also get an error when manually turing LIBOMP_OMPT_SUPPORT=on on an unsupported architecture.

Sat, Dec 23, 1:58 AM

Fri, Dec 22

protze.joachim added a comment to D41182: [OMPT] Add Workaround for Intel Compiler Bug.
icc bug

What bug it is and which version of ICC is affected?

Fri, Dec 22, 8:49 AM

Thu, Dec 21

protze.joachim created D41508: [OMPT] Build runtime with OMPT support by default.
Thu, Dec 21, 11:33 AM
protze.joachim updated the summary of D41504: Remove unused positional argument for printf.
Thu, Dec 21, 10:53 AM
protze.joachim created D41504: Remove unused positional argument for printf.
Thu, Dec 21, 10:52 AM
protze.joachim created D41499: [OMPT] Fix failing test cases for gcc on Ubuntu.
Thu, Dec 21, 10:01 AM
protze.joachim added inline comments to D41171: [OMPT] Handle null pointer in set_callback to improve performance.
Thu, Dec 21, 6:24 AM
protze.joachim added a comment to D41165: [OMPT] Set frame address when creating a task with dependences.

This fixes the test with GCC which already had the enter address, right?

Thu, Dec 21, 5:04 AM
protze.joachim requested changes to D41165: [OMPT] Set frame address when creating a task with dependences.

I think, the address needs to be reset on return. Please include commit 45a3a39 to this patch.

Thu, Dec 21, 5:02 AM

Dec 13 2017

protze.joachim added a comment to D41171: [OMPT] Handle null pointer in set_callback to improve performance.

This change is more a performace optimization. (reset the bit in the bitmap to 0)
The callback was set to NULL before and all callback invocation checks for the NULL-pointer.

Dec 13 2017, 7:54 AM

Dec 8 2017

protze.joachim added inline comments to D40949: [OMPT] Add missing ompt_get_num_procs function.
Dec 8 2017, 4:03 AM

Dec 7 2017

protze.joachim updated the diff for D40949: [OMPT] Add missing ompt_get_num_procs function.

Thanks

Dec 7 2017, 7:03 AM
protze.joachim created D40949: [OMPT] Add missing ompt_get_num_procs function.
Dec 7 2017, 4:10 AM

Dec 5 2017

protze.joachim added a comment to D40386: [OpenMP] Add entry for Intel Compiler 18.

For released versions (at least for the current way of defining the macros) the following should be possible (not tested):

#define KMP_COMPILER "Intel C++ Compiler " stringer(__INTEL_COMPILER / 100) "." stringer(__INTEL_COMPILER % 100) "." stringer(__INTEL_COMPILER_UPDATE)

Maybe you need to assign the temporary values to other defines for the macro magic to work, I'm not too familiar with how it works...

Dec 5 2017, 5:33 AM

Nov 29 2017

protze.joachim added inline comments to D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.
Nov 29 2017, 9:54 AM
protze.joachim added inline comments to D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.
Nov 29 2017, 7:40 AM
protze.joachim added a reviewer for D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers: omalyshe.

@omalyshe Which version of icc introduced the ident information for workshare constructs?

Nov 29 2017, 12:54 AM

Nov 24 2017

protze.joachim added a comment to D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.

LGTM

Nov 24 2017, 12:53 AM

Nov 22 2017

protze.joachim added a comment to D15154: [sanitizer_common] Suspend output to stdout/file if callback is set.

@kcc I would still be interested in this change :)

Nov 22 2017, 6:09 AM

Nov 10 2017

protze.joachim accepted D39801: [OMPT] Provide initialization for Mac OS X.
Nov 10 2017, 10:33 AM
protze.joachim added a comment to D39853: [OMPT] Fix inaccuracies in worksharing tests.

LGTM

Nov 10 2017, 10:33 AM
protze.joachim added a comment to D39801: [OMPT] Provide initialization for Mac OS X.

We might want to add another RUN-line for 3, where the first tool returns NULL for ompt_start_tool and only the second tool in the list is initialized.
We can add this test in a later patch

Nov 10 2017, 8:46 AM
protze.joachim added inline comments to D39853: [OMPT] Fix inaccuracies in worksharing tests.
Nov 10 2017, 8:45 AM
protze.joachim updated the diff for D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.

clang-format

Nov 10 2017, 8:30 AM
protze.joachim updated the diff for D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.

Fix potentially uninitialized value. Thanks, Jonas!

Nov 10 2017, 8:23 AM
protze.joachim updated the diff for D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.

Using Olga's code to only trigger a single warning. Tested and works for me.

Nov 10 2017, 7:41 AM
protze.joachim updated the diff for D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.

Remove warning for fini

Nov 10 2017, 6:44 AM
protze.joachim added inline comments to D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.
Nov 10 2017, 5:31 AM
protze.joachim updated the diff for D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.

Addressing Olgas suggestions

Nov 10 2017, 5:31 AM
protze.joachim created D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.
Nov 10 2017, 1:50 AM

Nov 9 2017

protze.joachim added a comment to D39853: [OMPT] Fix inaccuracies in worksharing tests.

Sections seems reasonable, for the single I would suggest to use the conditional.

Nov 9 2017, 11:47 AM
protze.joachim accepted D39699: [OMPT] Add support for testing return addresses on POWER.

LGTM

Nov 9 2017, 5:27 AM
protze.joachim accepted D39708: [OMPT] Fix test cancel_parallel.c.

LGTM

Nov 9 2017, 5:26 AM

Nov 8 2017

protze.joachim added a comment to D39708: [OMPT] Fix test cancel_parallel.c.

Instead of saving the address and printing it in a new team afterwards, you could also use CHECK-DAG and print the address, where you store it.
In that case, you should add another, unrelated match in between (e.g., the thread_begin event)

Nov 8 2017, 9:19 AM

Nov 5 2017

protze.joachim abandoned D14544: [OMPT] Fix the lock id provided for ordered events.

Subsumed by D38185

Nov 5 2017, 6:15 AM

Nov 2 2017

protze.joachim updated the diff for D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.

Updated diff after merging in master with TR4 patch.

Nov 2 2017, 6:22 AM
protze.joachim added a comment to D39326: Rename field of ompt_frame_t.

LGTM

Nov 2 2017, 4:56 AM

Oct 27 2017

protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Remove the forward declaration in ompt-internal.h.
Remove unnecessary includes of ompt-internal.h.
Replace all _builtin_expect by the UNLIKELY macro.

Oct 27 2017, 8:13 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 27 2017, 7:53 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 27 2017, 7:43 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 27 2017, 7:37 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Addressing Jonas latest comments.

Oct 27 2017, 7:37 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Addressing the last remaining comments.

Oct 27 2017, 7:14 AM
protze.joachim added inline comments to D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.
Oct 27 2017, 6:44 AM
protze.joachim accepted D39326: Rename field of ompt_frame_t.
Oct 27 2017, 6:14 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Avoid inlining for the ompt_enabled case as Hansang pointed out

Oct 27 2017, 1:25 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Fixed the return of void. Run clang-format again.

Oct 27 2017, 1:17 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Since prerequisites are already in master, now the diff against master. (As Jonas pointed out, the last diff missed the clang-format in the base)

Oct 27 2017, 1:12 AM

Oct 26 2017

protze.joachim requested changes to D39326: Rename field of ompt_frame_t.

Please update the diff with the clang-format changes I pushed to the branch.

Oct 26 2017, 6:55 AM
protze.joachim updated the diff for D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.

Now with proper clang-format

Oct 26 2017, 6:49 AM
protze.joachim updated the diff for D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.

Renaming of ompt_frame_t split out as suggested by Jonas

Oct 26 2017, 6:40 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

The latest update replaces things like "REQUIRES taskgroup" by explicit "XFAIL gcc" for testcases that are expected to fail because either gcc or the gomp interface of libomp don't support the construct or the construct has no runtime call. (see D38880)

Oct 26 2017, 1:01 AM

Oct 23 2017

protze.joachim added a dependent revision for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1: D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.
Oct 23 2017, 6:51 AM
protze.joachim added a dependency for D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2: D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 23 2017, 6:51 AM
protze.joachim created D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.
Oct 23 2017, 6:51 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 23 2017, 5:20 AM

Oct 19 2017

protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 19 2017, 2:08 AM

Oct 18 2017

protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 18 2017, 8:03 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Addressing Jonas' comments

Oct 18 2017, 7:49 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 18 2017, 7:31 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 18 2017, 7:15 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 18 2017, 6:47 AM

Oct 17 2017

protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 17 2017, 11:53 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Addressed latest comments by jlpeyton

Oct 17 2017, 11:49 AM

Oct 16 2017

protze.joachim added a comment to D38837: Add explicit values to .clang-format.

Ok, I've done some more research on this and here is what I've found and suggest as the solution:

  1. It appears we didn't clang-format our codebase to completion or somehow these changes in https://reviews.llvm.org/D38920 slipped through the cracks. I don't know. Whatever the case, it is a good idea to commit these remaining format changes.
Oct 16 2017, 10:59 PM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Applied old clang-format file.

Oct 16 2017, 10:43 PM
protze.joachim updated the diff for D38920: Updated .clang-format file and applied reformating.

Removed all changes in .clang-format, removed all comments from this file.
applied

runtime/src/ $ clang-format -style=file -i *.cpp *.h
Oct 16 2017, 10:23 PM

Oct 14 2017

protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Implemented more requested changes

Oct 14 2017, 11:03 AM
protze.joachim added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Marked comments that are solved by latest diff as done.

Oct 14 2017, 9:06 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

This diff fixes many of the comments. (I will walk over the comments and mark them as done)
This diff is against master + parent dependent differentals

Oct 14 2017, 4:47 AM
protze.joachim added a comment to D38837: Add explicit values to .clang-format.

I tried to update the attached diff, but accidently created a new differential: https://reviews.llvm.org/D38920
I built a clang-format using the source suggested by AndreyChurbanov. I still get a diff for the source of master.

Oct 14 2017, 4:02 AM
protze.joachim created D38920: Updated .clang-format file and applied reformating.
Oct 14 2017, 3:54 AM

Oct 12 2017

protze.joachim added a comment to D38837: Add explicit values to .clang-format.

For current HEAD of master I get a different result for any combination of the added values (unless I add the DisableFormat=true).
The smallest diff I get if I only add

MaxEmptyLinesToKeep: 2
Oct 12 2017, 10:27 AM
protze.joachim added inline comments to D38837: Add explicit values to .clang-format.
Oct 12 2017, 9:51 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Changes to clang-format factored out into D38837

Oct 12 2017, 1:13 AM

Sep 22 2017

protze.joachim updated subscribers of D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Sep 22 2017, 12:37 PM
protze.joachim created D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Sep 22 2017, 12:36 PM

Sep 14 2016

protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.

Remove regression of already removed if 0 block.

Sep 14 2016, 5:47 AM
protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.

Fix issue pointed out by Jonas

Sep 14 2016, 5:44 AM
protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.
Sep 14 2016, 5:39 AM

Sep 13 2016

protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.

removed single line, that was commented out

Sep 13 2016, 5:56 AM
protze.joachim added a dependency for D24502: [OMPT] fix task frame information for gomp interface: D23310: [OMPT] save exit address to lwt if available.
Sep 13 2016, 5:51 AM