protze.joachim (Joachim Protze)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 4:45 AM (108 w, 3 d)

Recent Activity

Thu, Oct 19

protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Thu, Oct 19, 2:08 AM

Wed, Oct 18

protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Wed, Oct 18, 8:03 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Addressing Jonas' comments

Wed, Oct 18, 7:49 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Wed, Oct 18, 7:31 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Wed, Oct 18, 7:15 AM
protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Wed, Oct 18, 6:47 AM

Tue, Oct 17

protze.joachim added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Tue, Oct 17, 11:53 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Addressed latest comments by jlpeyton

Tue, Oct 17, 11:49 AM

Mon, Oct 16

protze.joachim added a comment to D38837: Add explicit values to .clang-format.

Ok, I've done some more research on this and here is what I've found and suggest as the solution:

  1. It appears we didn't clang-format our codebase to completion or somehow these changes in https://reviews.llvm.org/D38920 slipped through the cracks. I don't know. Whatever the case, it is a good idea to commit these remaining format changes.
Mon, Oct 16, 10:59 PM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Applied old clang-format file.

Mon, Oct 16, 10:43 PM
protze.joachim updated the diff for D38920: Updated .clang-format file and applied reformating.

Removed all changes in .clang-format, removed all comments from this file.
applied

runtime/src/ $ clang-format -style=file -i *.cpp *.h
Mon, Oct 16, 10:23 PM

Sat, Oct 14

protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Implemented more requested changes

Sat, Oct 14, 11:03 AM
protze.joachim added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Marked comments that are solved by latest diff as done.

Sat, Oct 14, 9:06 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

This diff fixes many of the comments. (I will walk over the comments and mark them as done)
This diff is against master + parent dependent differentals

Sat, Oct 14, 4:47 AM
protze.joachim added a comment to D38837: Add explicit values to .clang-format.

I tried to update the attached diff, but accidently created a new differential: https://reviews.llvm.org/D38920
I built a clang-format using the source suggested by AndreyChurbanov. I still get a diff for the source of master.

Sat, Oct 14, 4:02 AM
protze.joachim created D38920: Updated .clang-format file and applied reformating.
Sat, Oct 14, 3:54 AM

Thu, Oct 12

protze.joachim added a comment to D38837: Add explicit values to .clang-format.

For current HEAD of master I get a different result for any combination of the added values (unless I add the DisableFormat=true).
The smallest diff I get if I only add

MaxEmptyLinesToKeep: 2
Thu, Oct 12, 10:27 AM
protze.joachim added inline comments to D38837: Add explicit values to .clang-format.
Thu, Oct 12, 9:51 AM
protze.joachim updated the diff for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Changes to clang-format factored out into D38837

Thu, Oct 12, 1:13 AM

Sep 22 2017

protze.joachim updated subscribers of D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Sep 22 2017, 12:37 PM
protze.joachim created D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Sep 22 2017, 12:36 PM

Sep 14 2016

protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.

Remove regression of already removed if 0 block.

Sep 14 2016, 5:47 AM
protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.

Fix issue pointed out by Jonas

Sep 14 2016, 5:44 AM
protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.
Sep 14 2016, 5:39 AM

Sep 13 2016

protze.joachim updated the diff for D24502: [OMPT] fix task frame information for gomp interface.

removed single line, that was commented out

Sep 13 2016, 5:56 AM
protze.joachim added a dependency for D24502: [OMPT] fix task frame information for gomp interface: D23310: [OMPT] save exit address to lwt if available.
Sep 13 2016, 5:51 AM
protze.joachim added a dependent revision for D23310: [OMPT] save exit address to lwt if available: D24502: [OMPT] fix task frame information for gomp interface.
Sep 13 2016, 5:51 AM
protze.joachim retitled D24502: [OMPT] fix task frame information for gomp interface from to [OMPT] fix task frame information for gomp interface.
Sep 13 2016, 5:51 AM

Aug 18 2016

protze.joachim updated the diff for D23310: [OMPT] save exit address to lwt if available.

Fix issue commented by Jonas

Aug 18 2016, 7:05 AM
protze.joachim added reviewers for D23310: [OMPT] save exit address to lwt if available: Hahnfeld, jmellorcrummey.
Aug 18 2016, 4:57 AM
protze.joachim updated the diff for D23307: [OMPT] Reset task exit frame when execution is finished.

Merged OMPT - blocks where appropriate, replaced =0 by =NULL.

Aug 18 2016, 4:55 AM
protze.joachim updated the diff for D23305: [OMPT] Align implementation of reenter frame address to latest (frozen) version of OMPT spec.

Replaced all
_frame = 0;
by
_frame = NULL;
for consistency.

Aug 18 2016, 4:52 AM
protze.joachim added reviewers for D23309: [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams: jmellorcrummey, Hahnfeld.
Aug 18 2016, 4:46 AM

Aug 9 2016

protze.joachim added a dependent revision for D23309: [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams: D23310: [OMPT] save exit address to lwt if available.
Aug 9 2016, 12:09 PM
protze.joachim added a dependency for D23310: [OMPT] save exit address to lwt if available: D23309: [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams.
Aug 9 2016, 12:09 PM
protze.joachim added reviewers for D23310: [OMPT] save exit address to lwt if available: jlpeyton, AndreyChurbanov.
Aug 9 2016, 12:08 PM
protze.joachim retitled D23310: [OMPT] save exit address to lwt if available from to [OMPT] save exit address to lwt if available.
Aug 9 2016, 4:31 AM
protze.joachim added a dependency for D23309: [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams: D23307: [OMPT] Reset task exit frame when execution is finished.
Aug 9 2016, 4:03 AM
protze.joachim added a dependent revision for D23307: [OMPT] Reset task exit frame when execution is finished: D23309: [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams.
Aug 9 2016, 4:03 AM
protze.joachim retitled D23309: [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams from to [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams.
Aug 9 2016, 4:03 AM
protze.joachim added a dependent revision for D23305: [OMPT] Align implementation of reenter frame address to latest (frozen) version of OMPT spec: D23307: [OMPT] Reset task exit frame when execution is finished.
Aug 9 2016, 3:55 AM
protze.joachim added a dependency for D23307: [OMPT] Reset task exit frame when execution is finished: D23305: [OMPT] Align implementation of reenter frame address to latest (frozen) version of OMPT spec.
Aug 9 2016, 3:55 AM
protze.joachim retitled D23307: [OMPT] Reset task exit frame when execution is finished from to [OMPT] Reset task exit frame when execution is finished.
Aug 9 2016, 3:55 AM
protze.joachim added a dependency for D23305: [OMPT] Align implementation of reenter frame address to latest (frozen) version of OMPT spec: D23304: [OMPT] extend ompt tests by checks for frame pointers.
Aug 9 2016, 3:45 AM
protze.joachim added a dependent revision for D23304: [OMPT] extend ompt tests by checks for frame pointers: D23305: [OMPT] Align implementation of reenter frame address to latest (frozen) version of OMPT spec.
Aug 9 2016, 3:45 AM
protze.joachim retitled D23305: [OMPT] Align implementation of reenter frame address to latest (frozen) version of OMPT spec from to [OMPT] Align implementation of reenter frame address to latest (frozen) version of OMPT spec.
Aug 9 2016, 3:45 AM
protze.joachim retitled D23304: [OMPT] extend ompt tests by checks for frame pointers from to [OMPT] extend ompt tests by checks for frame pointers.
Aug 9 2016, 3:37 AM

Feb 11 2016

protze.joachim retitled D17145: [OMPT] Frame information for openmp taskwait from to [OMPT] Frame information for openmp taskwait.
Feb 11 2016, 9:04 AM

Dec 3 2015

protze.joachim updated the diff for D15154: [sanitizer_common] Suspend output to stdout/file if callback is set.

With some compiler versions, SetPrintfAndReportCallback gets the .hidden flag. I need to access the symbol from a 3rd party library.
So I added SANITIZER_INTERFACE_ATTRIBUTE to have the symbol visible.

Dec 3 2015, 9:24 AM
protze.joachim updated the diff for D15154: [sanitizer_common] Suspend output to stdout/file if callback is set.

I cannot find a log_file option, only a log_path option. And this option is not compatible with /dev/null, since it adds ".$PID" to the path prefix.

Dec 3 2015, 8:07 AM

Dec 2 2015

protze.joachim retitled D15154: [sanitizer_common] Suspend output to stdout/file if callback is set from to [sanitizer_common] Suspend output to stdout/file if callback is set.
Dec 2 2015, 8:19 AM

Nov 10 2015

protze.joachim retitled D14544: [OMPT] Fix the lock id provided for ordered events from to [OMPT] Fix the lock id provided for ordered events.
Nov 10 2015, 9:32 AM

Nov 9 2015

protze.joachim added a comment to D14383: Add OMPT events for the OpenMP taskwait construct..

The callbacks are intended to monitor the beginning and end of an episode of waiting. There is no evidence of the waiting in the diffs provided without context.

Nov 9 2015, 6:44 AM
protze.joachim updated the diff for D14383: Add OMPT events for the OpenMP taskwait construct..

Replaced the diff by a full differential.

Nov 9 2015, 6:39 AM

Nov 5 2015

protze.joachim retitled D14383: Add OMPT events for the OpenMP taskwait construct. from to Add OMPT events for the OpenMP taskwait construct..
Nov 5 2015, 8:11 AM

Oct 21 2015

protze.joachim added a comment to D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

I'll start a thread about this.

Oct 21 2015, 10:37 AM

Sep 25 2015

protze.joachim added a comment to D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

The building will generate a library called libomp_tsan.so.
I guess this is not something that we want, so probably it should be removed, but I will leave it for the first review.

Why would this not be desirable? What's the alternative?

Sep 25 2015, 6:35 AM