Page MenuHomePhabricator

hbae (Hansang Bae)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2015, 12:00 PM (278 w, 5 d)

Recent Activity

Today

hbae committed rG77dc7b465313: [OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT (authored by hbae).
[OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT
Wed, Apr 14, 5:56 AM
hbae closed D100414: [OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT.
Wed, Apr 14, 5:56 AM · Restricted Project

Yesterday

hbae requested review of D100420: [OpenMP] Add omp_target_is_accessible() to header files.
Tue, Apr 13, 4:09 PM · Restricted Project
hbae requested review of D100414: [OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT.
Tue, Apr 13, 3:20 PM · Restricted Project

Tue, Apr 6

hbae committed rG3da61ddae7fe: [OpenMP] Define omp_is_initial_device() variants in omp.h (authored by hbae).
[OpenMP] Define omp_is_initial_device() variants in omp.h
Tue, Apr 6, 2:58 PM
hbae closed D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.
Tue, Apr 6, 2:58 PM · Restricted Project, Restricted Project

Mon, Apr 5

hbae updated the diff for D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.

Added inline after static to avoid unused function warning.
Added a RUN line to the test to catch unused function warning.

Mon, Apr 5, 3:43 PM · Restricted Project, Restricted Project

Fri, Apr 2

hbae added inline comments to D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.
Fri, Apr 2, 3:13 PM · Restricted Project, Restricted Project
hbae updated the diff for D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.

Removed omp_is_initial_device() from clang built-ins.
Added a new test under openmp/libomptarget.

Fri, Apr 2, 3:11 PM · Restricted Project, Restricted Project

Fri, Mar 26

hbae requested review of D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.
Fri, Mar 26, 3:34 PM · Restricted Project, Restricted Project

Tue, Mar 23

hbae committed rG467f39249dbb: [OpenMP] Misc. changes that add or remove pointer/bound checks (authored by hbae).
[OpenMP] Misc. changes that add or remove pointer/bound checks
Tue, Mar 23, 4:56 PM
hbae closed D98584: [OpenMP] Misc. changes that add or remove pointer/bound checks.
Tue, Mar 23, 4:55 PM · Restricted Project

Tue, Mar 16

hbae committed rGa6f9cb6adc59: [OpenMP] Add runtime interface for OpenMP 5.1 error directive (authored by hbae).
[OpenMP] Add runtime interface for OpenMP 5.1 error directive
Tue, Mar 16, 6:56 AM
hbae closed D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.
Tue, Mar 16, 6:56 AM · Restricted Project

Mon, Mar 15

hbae updated the diff for D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.

Applied suggested changes and added a test.

Mon, Mar 15, 5:58 PM · Restricted Project

Mar 15 2021

hbae updated the diff for D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.

Added ident_t * parameter.

Mar 15 2021, 9:37 AM · Restricted Project
hbae added a comment to D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.

It is unclear what we should do with ident_t at the moment.
Is it going to be useful if we include the location info in the warning/error message?

Mar 15 2021, 8:13 AM · Restricted Project

Mar 13 2021

hbae requested review of D98584: [OpenMP] Misc. changes that add or remove pointer/bound checks.
Mar 13 2021, 9:20 AM · Restricted Project

Mar 11 2021

hbae requested review of D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.
Mar 11 2021, 12:39 PM · Restricted Project

Mar 2 2021

hbae committed rGb6c2f538b22b: [OpenMP] Add allocator support for target memory (authored by hbae).
[OpenMP] Add allocator support for target memory
Mar 2 2021, 2:46 PM
hbae closed D96669: [OpenMP] Add allocator support for target memory.
Mar 2 2021, 2:46 PM · Restricted Project

Feb 24 2021

hbae added a comment to D96669: [OpenMP] Add allocator support for target memory.

There will be a separate patch for libomptarget.

Feb 24 2021, 5:13 PM · Restricted Project
hbae updated the summary of D96669: [OpenMP] Add allocator support for target memory.
Feb 24 2021, 3:18 PM · Restricted Project
hbae updated the diff for D96669: [OpenMP] Add allocator support for target memory.

Changed prefix from preomp to llvm_omp.

Feb 24 2021, 3:16 PM · Restricted Project

Feb 22 2021

hbae accepted D96893: [OpenMP] libomp minor cleanup.

LGTM

Feb 22 2021, 11:06 AM · Restricted Project
hbae accepted D96749: [OpenMP] Limit number of dispatch buffers.

LGTM

Feb 22 2021, 8:21 AM · Restricted Project

Feb 21 2021

hbae accepted D96750: [OpenMP] Remove shutdown attempt on Windows process detach.

LGTM

Feb 21 2021, 11:45 AM · Restricted Project
hbae accepted D96748: [OpenMP] Update HWLOC topology detection for die level.

LGTM

Feb 21 2021, 11:35 AM · Restricted Project
hbae accepted D96562: [OpenMP] libomp: fix ittnotify stack stitching for teams construct.

LGTM

Feb 21 2021, 11:27 AM · Restricted Project

Feb 14 2021

hbae requested review of D96669: [OpenMP] Add allocator support for target memory.
Feb 14 2021, 1:41 PM · Restricted Project

Feb 11 2021

hbae committed rGffb21e7f0593: [OpenMP] Enable omp_get_num_devices() on Windows (authored by hbae).
[OpenMP] Enable omp_get_num_devices() on Windows
Feb 11 2021, 1:08 PM
hbae closed D96182: [OpenMP] Enable omp_get_num_devices() on Windows.
Feb 11 2021, 1:08 PM · Restricted Project
hbae updated the diff for D96182: [OpenMP] Enable omp_get_num_devices() on Windows.

Addressed issues reported by reviewers.

Feb 11 2021, 7:46 AM · Restricted Project

Feb 6 2021

hbae updated the diff for D96182: [OpenMP] Enable omp_get_num_devices() on Windows.

Applied similar change to omp_get_initial_device().

Feb 6 2021, 8:59 AM · Restricted Project

Feb 5 2021

hbae requested review of D96182: [OpenMP] Enable omp_get_num_devices() on Windows.
Feb 5 2021, 2:26 PM · Restricted Project

Feb 1 2021

hbae accepted D95003: [OpenMP] libomp: implement OpenMP 5.1 nteams-var and teams-thread-limit-var ICVs.

Looks good to me.

Feb 1 2021, 7:42 AM · Restricted Project

Jan 28 2021

hbae accepted D95627: [OpenMP] libomp: fix Windows build by vs2019.

Looks good to me.

Jan 28 2021, 5:11 PM · Restricted Project

Jan 25 2021

hbae accepted D94985: [OpenMP] Add OMP_ALLOCATOR env variable for OpenMP 5.1 .

LGTM

Jan 25 2021, 5:19 PM · Restricted Project

Jan 22 2021

hbae added a comment to D95003: [OpenMP] libomp: implement OpenMP 5.1 nteams-var and teams-thread-limit-var ICVs.

The scope of nteams-var and teams-thread-limit-var is device, so I believe proper handling in plugin should be using extended variable name such as OMP_NUM_TEAMS_DEV[_<device>] as described in OpenMP 5.1 page 75.
I think it is best to leave this up to contributors to each plugins.

Jan 22 2021, 7:16 PM · Restricted Project
hbae committed rG480cbed31e74: [OpenMP] Remove unnecessary pointer checks in a few locations (authored by hbae).
[OpenMP] Remove unnecessary pointer checks in a few locations
Jan 22 2021, 5:21 PM
hbae closed D95277: [OpenMP] Return NULL from unsuccessful OMPT function lookup.
Jan 22 2021, 5:21 PM · Restricted Project
hbae requested review of D95277: [OpenMP] Return NULL from unsuccessful OMPT function lookup.
Jan 22 2021, 4:44 PM · Restricted Project

Jan 19 2021

hbae committed rG2d911f7c72f9: [OpenMP] Fix atomic entries for captured logical operation (authored by hbae).
[OpenMP] Fix atomic entries for captured logical operation
Jan 19 2021, 8:15 AM
hbae closed D94848: [OpenMP] Fix atomic entries for captured logical operation.
Jan 19 2021, 8:15 AM · Restricted Project

Jan 15 2021

hbae requested review of D94848: [OpenMP] Fix atomic entries for captured logical operation.
Jan 15 2021, 4:57 PM · Restricted Project

Jan 12 2021

hbae committed rGbba3a82b56c0: [OpenMP] Use persistent memory for omp_large_cap_mem (authored by hbae).
[OpenMP] Use persistent memory for omp_large_cap_mem
Jan 12 2021, 6:38 PM
hbae closed D94353: [OpenMP] Use persistent memory for omp_large_cap_mem.
Jan 12 2021, 6:37 PM · Restricted Project
hbae committed rG6f0f0220380f: [OpenMP] Update allocator trait key/value definitions (authored by hbae).
[OpenMP] Update allocator trait key/value definitions
Jan 12 2021, 6:22 PM
hbae closed D94277: [OpenMP] Update allocator trait key/value definitions.
Jan 12 2021, 6:21 PM · Restricted Project

Jan 8 2021

hbae requested review of D94353: [OpenMP] Use persistent memory for omp_large_cap_mem.
Jan 8 2021, 4:46 PM · Restricted Project

Jan 7 2021

hbae requested review of D94277: [OpenMP] Update allocator trait key/value definitions.
Jan 7 2021, 5:06 PM · Restricted Project

Jan 6 2021

hbae committed rGfb1c52852690: [OpenMP] Use c_int/c_size_t in Fortran target memory routine interface (authored by hbae).
[OpenMP] Use c_int/c_size_t in Fortran target memory routine interface
Jan 6 2021, 2:29 PM
hbae closed D94042: [OpenMP] Use c_int/c_size_t in Fortran target memory routine interface.
Jan 6 2021, 2:29 PM · Restricted Project

Jan 4 2021

hbae requested review of D94042: [OpenMP] Use c_int/c_size_t in Fortran target memory routine interface.
Jan 4 2021, 3:45 PM · Restricted Project
hbae added inline comments to D93505: [OpenMP] Add definition/interface for target memory routines.
Jan 4 2021, 3:36 PM · Restricted Project
hbae committed rG82a29a62aba5: [OpenMP] Add definition/interface for target memory routines (authored by hbae).
[OpenMP] Add definition/interface for target memory routines
Jan 4 2021, 6:14 AM
hbae closed D93505: [OpenMP] Add definition/interface for target memory routines.
Jan 4 2021, 6:13 AM · Restricted Project

Dec 17 2020

hbae requested review of D93505: [OpenMP] Add definition/interface for target memory routines.
Dec 17 2020, 5:55 PM · Restricted Project
hbae committed rGe1fd202489e1: [OpenMP] Add definitions for 5.1 interop to omp.h (authored by hbae).
[OpenMP] Add definitions for 5.1 interop to omp.h
Dec 17 2020, 11:05 AM
hbae added inline comments to D93429: [OpenMP] Add definitions for 5.1 interop to omp.h.
Dec 17 2020, 8:31 AM · Restricted Project
hbae updated the diff for D93429: [OpenMP] Add definitions for 5.1 interop to omp.h.

Copied summary of the interop routines from the spec.

Dec 17 2020, 8:26 AM · Restricted Project

Dec 16 2020

hbae requested review of D93429: [OpenMP] Add definitions for 5.1 interop to omp.h.
Dec 16 2020, 4:41 PM · Restricted Project
hbae added inline comments to D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc).
Dec 16 2020, 3:14 PM · Restricted Project

Dec 15 2020

hbae committed rG171ca93c5430: [OpenMP] Initialize runtime in the forked child process (authored by hbae).
[OpenMP] Initialize runtime in the forked child process
Dec 15 2020, 5:33 AM
hbae closed D93230: [OpenMP] Initialize runtime in the forked child process.
Dec 15 2020, 5:33 AM · Restricted Project

Dec 14 2020

hbae requested review of D93230: [OpenMP] Initialize runtime in the forked child process.
Dec 14 2020, 9:06 AM · Restricted Project

Dec 9 2020

hbae committed rGc3b5009aa7f4: [OpenMP] Use RTM lock for OMP lock with synchronization hint (authored by hbae).
[OpenMP] Use RTM lock for OMP lock with synchronization hint
Dec 9 2020, 5:16 PM
hbae closed D92615: [OpenMP] Use RTM lock for OMP lock with synchronization hint.
Dec 9 2020, 5:15 PM · Restricted Project

Dec 4 2020

hbae committed rGc4a22224d971: [OpenMP] Add __kmpc_omp_target_task_alloc to dllexport (authored by hbae).
[OpenMP] Add __kmpc_omp_target_task_alloc to dllexport
Dec 4 2020, 6:12 AM
hbae closed D92618: [OpenMP] Add __kmpc_omp_target_task_alloc to dllexport.
Dec 4 2020, 6:12 AM · Restricted Project

Dec 3 2020

hbae requested review of D92618: [OpenMP] Add __kmpc_omp_target_task_alloc to dllexport.
Dec 3 2020, 4:10 PM · Restricted Project
hbae requested review of D92615: [OpenMP] Use RTM lock for OMP lock with synchronization hint.
Dec 3 2020, 3:44 PM · Restricted Project

Dec 2 2020

hbae accepted D92121: [OpenMP][OMPT] Fix OMPT return address guard for gomp interface.

LGTM.

Dec 2 2020, 3:51 PM · Restricted Project

Nov 25 2020

hbae abandoned D90078: [OpenMP] Fix potentially inconsistent OMPT return address.

Addressed by D91692.

Nov 25 2020, 9:31 AM · Restricted Project

Nov 24 2020

hbae accepted D92027: [OpenMP] libomp: fix non-X86 non-AARCH64 builds.

LGTM.

Nov 24 2020, 4:01 PM · Restricted Project
hbae accepted D91464: [OpenMP][OMPT] Implement verbose tool loading.

Looks good to me.

Nov 24 2020, 2:31 PM · Restricted Project

Nov 20 2020

hbae accepted D91692: [OpenMP][OMPT] Introduce a guard to handle OMPT return address.

Looks good to me for the issue I am concerning about. Here is a test that passes with this patch.

Nov 20 2020, 7:57 AM · Restricted Project

Nov 17 2020

hbae committed rG44a11c342caa: [OpenMP] Use explicit type casting in kmp_atomic.cpp (authored by hbae).
[OpenMP] Use explicit type casting in kmp_atomic.cpp
Nov 17 2020, 12:31 PM
hbae closed D91105: [OpenMP] Use explicit type casting in kmp_atomic.cpp.
Nov 17 2020, 12:31 PM · Restricted Project

Nov 16 2020

hbae added a comment to D91464: [OpenMP][OMPT] Implement verbose tool loading.

Can we also add print routine for OMP_TOOL_VERBOSE_INIT in kmp_settings.cpp (for OMP_DISPLAY_ENV) ?

Nov 16 2020, 9:45 AM · Restricted Project

Nov 9 2020

hbae requested review of D91105: [OpenMP] Use explicit type casting in kmp_atomic.cpp.
Nov 9 2020, 3:00 PM · Restricted Project
hbae committed rGef7738240cf7: [OpenMP] Remove obsolete Fortran module file (authored by hbae).
[OpenMP] Remove obsolete Fortran module file
Nov 9 2020, 1:28 PM
hbae closed D90077: [OpenMP] Remove obsolete Fortran module file.
Nov 9 2020, 1:27 PM · Restricted Project

Oct 28 2020

hbae added a comment to D90078: [OpenMP] Fix potentially inconsistent OMPT return address.

@protze.joachim, you are right.
I will come back to this with a test case and a correct fix.

Oct 28 2020, 8:04 AM · Restricted Project

Oct 23 2020

hbae requested review of D90078: [OpenMP] Fix potentially inconsistent OMPT return address.
Oct 23 2020, 2:56 PM · Restricted Project
hbae requested review of D90077: [OpenMP] Remove obsolete Fortran module file.
Oct 23 2020, 2:53 PM · Restricted Project

Sep 21 2020

hbae accepted D87680: [OpenMP][OMPT] Update OMPT tests for newly added GOMP interface patches.

LGTM.

Sep 21 2020, 7:03 AM · Restricted Project

Jul 17 2020

hbae accepted D84065: [OpenMP] libomp cleanup: check presence of hwloc objects CORE, PACKAGE.

LGTM.

Jul 17 2020, 2:26 PM · Restricted Project
hbae accepted D84024: [OpenMP] libomp: add itt notifications for teams construct on host.

LGTM.

Jul 17 2020, 9:36 AM · Restricted Project

Jul 15 2020

hbae accepted D83804: [OpenMP] libomp: added itt notifications for task, taskwait, taskgroup..

LGTM.

Jul 15 2020, 1:11 PM · Restricted Project

Jul 1 2020

hbae accepted D81891: [OpenMP][OMPT] Add event callbacks for taskwait with depend.

LGTM.

Jul 1 2020, 8:06 AM · Restricted Project

Jun 24 2020

hbae added a comment to D81891: [OpenMP][OMPT] Add event callbacks for taskwait with depend.

The change looks good to me.
Can you check why the test fails? It passes on my test system.

Jun 24 2020, 11:55 AM · Restricted Project

Jun 17 2020

hbae accepted D81890: [OpenMP][OMPT] Pass mutexinoutset to the tool.

LGTM.

Jun 17 2020, 6:58 AM · Restricted Project

Jun 16 2020

hbae added inline comments to D81890: [OpenMP][OMPT] Pass mutexinoutset to the tool.
Jun 16 2020, 2:18 PM · Restricted Project
hbae accepted D81807: [OpenMP][OMPT] Add callbacks for doacross loops.

LGTM.

Jun 16 2020, 7:42 AM · Restricted Project

Jun 3 2020

hbae accepted D80942: [openmp] Fixed nonmonotonic schedule implementation..

LGTM.

Jun 3 2020, 8:44 AM · Restricted Project

Jun 1 2020

hbae accepted D80843: [OpenMP][OMPT] Fix and add event callbacks for detached tasks.

LGTM.

Jun 1 2020, 2:39 PM · Restricted Project

Mar 23 2020

hbae accepted D75673: [runtime] Fixed hang when explicit task created inside a taskloop..

LGTM.

Mar 23 2020, 6:31 AM · Restricted Project

Mar 4 2020

hbae added a comment to D74956: OpenMP 5.1 omp_display_env function implementation..

Looks good to me.

Mar 4 2020, 6:45 AM · Restricted Project

Mar 2 2020

hbae added a comment to D74956: OpenMP 5.1 omp_display_env function implementation..

We can have filechek tests, right? We should verify a bit more than the existence of a function that will return.

I am not sure how to pipe error output (stderr) to filecheck. I saw some examples of the "2>&1 |", this works in bash, but does not work in c shell. Maybe "|2" can be used?

Could somebody please advise how to better pipe stderr to filecheck? Is the "2>&1 |" appropriate? I personally work in bash usually, but some systems may have other shell by default.

Mar 2 2020, 12:03 PM · Restricted Project