Page MenuHomePhabricator

hbae (Hansang Bae)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2015, 12:00 PM (197 w, 2 d)

Recent Activity

Fri, Sep 13

hbae added inline comments to D67190: Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD.
Fri, Sep 13, 7:44 AM · Restricted Project

Aug 19 2019

hbae accepted D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..

LGTM.

Aug 19 2019, 9:37 AM · Restricted Project, Restricted Project

Aug 5 2019

hbae committed rGdcdbe6515b21: [OpenMP] Fix broken build due to new OMPT tests (authored by hbae).
[OpenMP] Fix broken build due to new OMPT tests
Aug 5 2019, 2:53 PM
hbae committed rL367939: [OpenMP] Fix broken build due to new OMPT tests.
[OpenMP] Fix broken build due to new OMPT tests
Aug 5 2019, 2:45 PM
hbae closed D65757: Fix broken build due to new OMPT tests.
Aug 5 2019, 2:45 PM · Restricted Project, Restricted Project
hbae added a comment to D65757: Fix broken build due to new OMPT tests.

GCC emits code with a GOMP* entry that is not supported in the LLVM runtime.

Aug 5 2019, 1:48 PM · Restricted Project, Restricted Project
hbae created D65757: Fix broken build due to new OMPT tests.
Aug 5 2019, 10:01 AM · Restricted Project, Restricted Project

Aug 2 2019

hbae committed rG67e93a1ae00f: Add OMPT support for teams construct (authored by hbae).
Add OMPT support for teams construct
Aug 2 2019, 7:42 PM
hbae committed rL367746: Add OMPT support for teams construct.
Add OMPT support for teams construct
Aug 2 2019, 7:42 PM
hbae closed D64025: Add OMPT support for teams construct.
Aug 2 2019, 7:42 PM · Restricted Project, Restricted Project

Jul 22 2019

hbae accepted D64442: [OMPT] Cleanup reset of exit_frame pointer.

Looks good to me.

Jul 22 2019, 11:16 AM · Restricted Project, Restricted Project

Jul 1 2019

hbae created D64025: Add OMPT support for teams construct.
Jul 1 2019, 11:39 AM · Restricted Project, Restricted Project

Jun 27 2019

hbae accepted D63891: Cleanup of unused code.

LGTM.

Jun 27 2019, 1:24 PM · Restricted Project, Restricted Project

Jun 26 2019

hbae accepted D63599: Fixed memory use-after-free problem..

LGTM.

Jun 26 2019, 7:20 AM · Restricted Project, Restricted Project

Jun 19 2019

hbae added a comment to D62485: New implementation of OpenMP 5.0 detached tasks..

Joachim, do you have any specific OMPT callbacks in mind?
I don't think we have any callbacks to insert in the new code.

Jun 19 2019, 6:54 AM · Restricted Project, Restricted Project

Jun 14 2019

hbae accepted D63010: [OpenMP] Add task alloc function.

LGTM.

Jun 14 2019, 12:02 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2019

hbae accepted D62332: Fixed build warning with -DLIBOMP_USE_HWLOC=1.

LGTM.

May 31 2019, 12:53 PM · Restricted Project, Restricted Project

May 30 2019

hbae committed rGec1b4d1f6fb0: Fix OMP_TARGET_OFFLOAD parsing (authored by hbae).
Fix OMP_TARGET_OFFLOAD parsing
May 30 2019, 11:34 AM
hbae committed rL362125: Fix OMP_TARGET_OFFLOAD parsing.
Fix OMP_TARGET_OFFLOAD parsing
May 30 2019, 11:32 AM
hbae committed rOMP362125: Fix OMP_TARGET_OFFLOAD parsing.
Fix OMP_TARGET_OFFLOAD parsing
May 30 2019, 11:32 AM
hbae closed D62431: Fix OMP_TARGET_OFFLOAD parsing.
May 30 2019, 11:32 AM · Restricted Project
hbae committed rG7c75ac0c60d6: Add checks before pointer dereferencing (authored by hbae).
Add checks before pointer dereferencing
May 30 2019, 11:12 AM
hbae committed rOMP362111: Add checks before pointer dereferencing.
Add checks before pointer dereferencing
May 30 2019, 11:12 AM
hbae committed rL362111: Add checks before pointer dereferencing.
Add checks before pointer dereferencing
May 30 2019, 11:12 AM
hbae closed D62224: Add checks before dereferencing pointers.
May 30 2019, 11:12 AM · Restricted Project

May 28 2019

hbae updated the diff for D62431: Fix OMP_TARGET_OFFLOAD parsing.

Added a test.

May 28 2019, 1:34 PM · Restricted Project
hbae added a comment to D62431: Fix OMP_TARGET_OFFLOAD parsing.

Yes, I agree that it is good to have tests for this -- I will be updating the patch with tests.

May 28 2019, 9:38 AM · Restricted Project

May 24 2019

hbae created D62431: Fix OMP_TARGET_OFFLOAD parsing.
May 24 2019, 3:34 PM · Restricted Project

May 22 2019

hbae accepted D62251: Fix for third case reported in https://bugs.llvm.org/show_bug.cgi?id=41584.

LGTM.

May 22 2019, 9:37 AM · Restricted Project, Restricted Project

May 21 2019

hbae created D62224: Add checks before dereferencing pointers.
May 21 2019, 3:36 PM · Restricted Project

May 16 2019

hbae accepted D61995: Fixed second problem reported in https://bugs.llvm.org/show_bug.cgi?id=41584.

LGTM.

May 16 2019, 10:36 AM · Restricted Project

May 14 2019

hbae accepted D61860: Introduce new OpenMP 5.0 depend object type..

LGTM.

May 14 2019, 6:16 PM · Restricted Project, Restricted Project

May 8 2019

hbae updated the diff for D61657: Add implementation to two OMPT API routines.

Added tests for the routines.

May 8 2019, 12:06 PM · Restricted Project

May 7 2019

hbae created D61657: Add implementation to two OMPT API routines.
May 7 2019, 2:34 PM · Restricted Project

Apr 30 2019

hbae accepted D60976: [OpenMP] Implement task modifier for reduction clause.

LGTM.

Apr 30 2019, 1:30 PM · Restricted Project, Restricted Project

Apr 24 2019

hbae added a comment to D60976: [OpenMP] Implement task modifier for reduction clause.

Just a few typos in the comment.

Apr 24 2019, 2:20 PM · Restricted Project, Restricted Project

Apr 11 2019

hbae accepted D60471: Fixed possible out of bound array access.

LGTM.

Apr 11 2019, 6:41 AM · Restricted Project, Restricted Project

Apr 3 2019

hbae accepted D59793: [OpenMP] Fix hang on Windows.

LGTM.

Apr 3 2019, 2:25 PM · Restricted Project, Restricted Project

Mar 15 2019

hbae accepted D59428: Fix pause check with version info.

LGTM.

Mar 15 2019, 1:21 PM · Restricted Project, Restricted Project

Mar 1 2019

hbae accepted D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end.

LGTM.

Mar 1 2019, 1:52 PM · Restricted Project, Restricted Project

Feb 28 2019

hbae added inline comments to D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end.
Feb 28 2019, 12:57 PM · Restricted Project, Restricted Project
hbae accepted D58408: [5.0] Deprecate nest-var and associated features.

LGTM.

Feb 28 2019, 12:36 PM · Restricted Project, Restricted Project

Feb 25 2019

hbae accepted D58506: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures (2).

The change looks good to me.

Feb 25 2019, 1:53 PM · Restricted Project, Restricted Project

Feb 20 2019

hbae accepted D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.

LGTM

Feb 20 2019, 1:11 PM · Restricted Project, Restricted Project

Feb 14 2019

hbae created D58247: [OMPT] Distinguish different barrier kinds.
Feb 14 2019, 12:44 PM · Restricted Project

Feb 13 2019

hbae accepted D58211: [5.0] Add omp_get_supported_active_levels().

LGTM

Feb 13 2019, 3:13 PM · Restricted Project, Restricted Project

Jan 15 2019

hbae added a comment to D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.

Can you also change ompt.h to omp-tools.h in runtime/cmake/LibompExports.cmake:61?
Then, I think it is good to go.

Jan 15 2019, 6:47 AM

Jan 9 2019

hbae added inline comments to D55579: [OMPT] Second chunk of final OMPT 5.0 interface updates.
Jan 9 2019, 2:49 PM

Dec 27 2018

hbae created D56103: Add lock function definitions to fix Bug 40042.
Dec 27 2018, 7:51 AM · Restricted Project

Dec 17 2018

hbae accepted D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.

LGTM.

Dec 17 2018, 9:22 AM

Dec 13 2018

hbae added inline comments to D55577: [OMPT] First chunk of final OMPT 5.0 interface updates.
Dec 13 2018, 11:57 AM

Nov 9 2018

hbae created D54347: Rename ompt_mutex_impl_unknown to ompt_mutex_impl_none.
Nov 9 2018, 12:41 PM · Restricted Project
hbae accepted D54305: Fix for bugzilla https://bugs.llvm.org/show_bug.cgi?id=39137..

LGTM.

Nov 9 2018, 8:51 AM · Restricted Project

Oct 1 2018

hbae accepted D52712: Fixed workaround made in https://reviews.llvm.org/D51694.

LGTM.

Oct 1 2018, 6:57 AM

Sep 27 2018

hbae created D52628: Shutdown library on Windows if possible for better OMPT behavior..
Sep 27 2018, 1:10 PM · Restricted Project

Sep 21 2018

hbae accepted D52380: [OpenMP] Add missing __kmpc_critical_with_hint to dllexports.

LGTM.

Sep 21 2018, 2:57 PM · Restricted Project
hbae accepted D52379: Fix balanced affinity so thread's private affinity mask is updated.

LGTM.

Sep 21 2018, 2:50 PM · Restricted Project
hbae accepted D52378: Update ittnotify sources.

LGTM.

Sep 21 2018, 2:47 PM · Restricted Project

Sep 13 2018

hbae created D52046: [OMPT] Fix unsafe initialization of ompt_data_t objects..
Sep 13 2018, 9:53 AM · Restricted Project

Sep 10 2018

hbae created D51889: Fix performance issue from 376.kdtree.
Sep 10 2018, 2:03 PM · Restricted Project
hbae accepted D50774: [OMPT] Update types according to TR7.

LGTM.

Sep 10 2018, 6:53 AM

Sep 4 2018

hbae accepted D51232: [OpenMP] Initial implementation of OMP 5.0 Memory Management routines.

LGTM.

Sep 4 2018, 2:28 PM · Restricted Project

Aug 24 2018

hbae accepted D51235: [OpenMP] Change hint parameter type for critical to uint32_t..

LGTM.

Aug 24 2018, 2:39 PM · Restricted Project
hbae accepted D51233: [OpenMP] Synchronization hint constants added to headers.

LGTM.

Aug 24 2018, 2:38 PM · Restricted Project

Aug 23 2018

hbae added inline comments to D50774: [OMPT] Update types according to TR7.
Aug 23 2018, 10:03 AM
hbae accepted D50651: [OpenMP] Fix tasking bug for decreasing hot team nthreads.

LGTM.

Aug 23 2018, 8:10 AM · Restricted Project
hbae accepted D50649: [OpenMP] Add check for hot_teams array.

LGTM.

Aug 23 2018, 8:09 AM · Restricted Project
hbae accepted D50584: Fix incorrect barrier imbalance reporting in ITTNOTIFY.

LGTM.

Aug 23 2018, 8:08 AM · Restricted Project

Aug 10 2018

hbae added a reviewer for D50565: [OMPT] Make omp_control_tool() compliant when called from Fortran programs: protze.joachim.
Aug 10 2018, 9:13 AM · Restricted Project
hbae created D50565: [OMPT] Make omp_control_tool() compliant when called from Fortran programs.
Aug 10 2018, 9:05 AM · Restricted Project

Aug 9 2018

hbae created D50538: [OMPT] A few improvements.
Aug 9 2018, 3:36 PM · Restricted Project

Jul 19 2018

hbae accepted D49373: [OMPT] Print two more addresses in print_fuzzy_address_block().

LGTM.

Jul 19 2018, 2:51 PM
hbae added inline comments to D49181: [OMPT] Adapt OMPT callback structure for tasks to handle untied tasks correctly (+ adapt testcase).
Jul 19 2018, 2:51 PM
hbae added inline comments to D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.
Jul 19 2018, 2:51 PM

Jul 17 2018

hbae created D49452: Block library shutdown until unreaped threads finish spin-waiting.
Jul 17 2018, 1:49 PM · Restricted Project

Jun 29 2018

hbae accepted D48282: [OMPT] Use alloca() to force availability of frame pointer .

LGTM

Jun 29 2018, 9:26 AM
hbae accepted D48362: [OMPT] Remove OMPT idle callback.

LGTM

Jun 29 2018, 8:57 AM

Jun 20 2018

hbae added inline comments to D48282: [OMPT] Use alloca() to force availability of frame pointer .
Jun 20 2018, 7:02 AM

Jun 15 2018

hbae accepted D47824: [OMPT] Add testcases for thread_begin and thread_end callbacks.

LGTM.

Jun 15 2018, 1:35 PM
hbae accepted D48124: [OMPT] Add tests for runtime entry points from non-OpenMP threads.

LGTM.

Jun 15 2018, 1:30 PM

May 1 2018

hbae added a comment to D46260: [OMPT] Fix thread_num for implicit_task_end callbacks in nested parallel regions.

The change looks good to me.

May 1 2018, 2:06 PM

Mar 27 2018

hbae created D44949: Minor cleanup in __kmp_atfork_child().
Mar 27 2018, 12:41 PM · Restricted Project

Mar 2 2018

hbae accepted D44019: Fix build of stubs library.

LGTM.

Mar 2 2018, 11:39 AM · Restricted Project

Feb 28 2018

hbae accepted D43897: [OMPT] Fix task-type test with GCC.

LGTM.

Feb 28 2018, 2:11 PM

Feb 23 2018

hbae added a comment to D42472: [OMPT] Fix ompt_get_task_info() and add tests for it.

LGTM.

Feb 23 2018, 1:47 PM

Feb 16 2018

hbae added inline comments to D42169: [OMPT] Formatting.
Feb 16 2018, 12:44 PM
hbae accepted D42162: [OMPT] Update api_calls testcase.

LGTM.

Feb 16 2018, 12:25 PM

Feb 14 2018

hbae accepted D41914: Improve threadprivate implementation.

LGTM.

Feb 14 2018, 2:56 PM

Feb 12 2018

hbae added inline comments to D41914: Improve threadprivate implementation.
Feb 12 2018, 9:56 AM

Feb 7 2018

hbae accepted D41942: [OMPT] Add interoperability testcase.

LGTM.

Feb 7 2018, 11:56 AM

Feb 6 2018

hbae accepted D42166: [OMPT] Add tool_available_search testcase.

LGTM.

Feb 6 2018, 11:24 AM
hbae accepted D41904: [OMPT] Add tool_not_available testcase.

LGTM.

Feb 6 2018, 11:09 AM

Jan 30 2018

hbae added a comment to D42709: [OMPT] Fix tool initialization returning 0.

LGTM.
Don't forget to do clang-formatting.

Jan 30 2018, 4:23 PM

Jan 11 2018

hbae accepted D41945: Fix for libomp static build.

LGTM

Jan 11 2018, 6:48 AM

Jan 8 2018

hbae accepted D41836: Simplify __kmp_expand_threads.

LGTM.

Jan 8 2018, 2:46 PM

Dec 20 2017

hbae created D41462: Improve stability of the runtime in parent/child processes.
Dec 20 2017, 1:14 PM · Restricted Project

Nov 27 2017

hbae accepted D40296: Fix aligned memory allocation in the stub library .

LGTM.

Nov 27 2017, 2:32 PM
hbae accepted D40356: Fix types of Fortran array elements.

LGTM

Nov 27 2017, 2:21 PM

Nov 20 2017

hbae accepted D40171: Fix for OMP doacross implementation on 32-bit platforms.

LGTM

Nov 20 2017, 7:41 AM

Nov 16 2017

hbae accepted D39853: [OMPT] Fix inaccuracies in worksharing tests.

LGTM

Nov 16 2017, 12:25 PM