Page MenuHomePhabricator

hbae (Hansang Bae)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2015, 12:00 PM (337 w, 8 h)

Recent Activity

Tue, May 3

hbae committed rG7e23b46ab8da: [OpenMP] Possible fix for sporadic test failure from loop_dispatch.c (authored by hbae).
[OpenMP] Possible fix for sporadic test failure from loop_dispatch.c
Tue, May 3, 12:47 PM · Restricted Project, Restricted Project
hbae closed D124812: [OpenMP] Possible fix for sporadic test failure from loop_dispatch.c.
Tue, May 3, 12:47 PM · Restricted Project, Restricted Project
hbae updated the diff for D124812: [OpenMP] Possible fix for sporadic test failure from loop_dispatch.c.

Applied suggested changes.

Tue, May 3, 7:02 AM · Restricted Project, Restricted Project

Mon, May 2

hbae requested review of D124812: [OpenMP] Possible fix for sporadic test failure from loop_dispatch.c.
Mon, May 2, 4:08 PM · Restricted Project, Restricted Project

Apr 8 2022

hbae added a comment to D122107: [OpenMP] Add support for ompt_callback_dispatch.

Is it possible for me to access the output of the failed test shown in the log?
/b/1/openmp-clang-x86_64-linux-debian/llvm.build/projects/openmp/runtime/test/ompt/worksharing/for/Output/loop_dispatch.c.tmp.out

Apr 8 2022, 9:35 AM · Restricted Project, Restricted Project

Apr 6 2022

hbae committed rG090309d31624: [OpenMP] Fix warnings (authored by hbae).
[OpenMP] Fix warnings
Apr 6 2022, 10:35 AM · Restricted Project, Restricted Project
hbae closed D123233: [OpenMP] Fix warnings.
Apr 6 2022, 10:35 AM · Restricted Project, Restricted Project
hbae requested review of D123233: [OpenMP] Fix warnings.
Apr 6 2022, 9:29 AM · Restricted Project, Restricted Project
hbae added inline comments to D122107: [OpenMP] Add support for ompt_callback_dispatch.
Apr 6 2022, 6:03 AM · Restricted Project, Restricted Project
hbae committed rGe4ac11beb736: [OpenMP] Add support for ompt_callback_dispatch (authored by hbae).
[OpenMP] Add support for ompt_callback_dispatch
Apr 6 2022, 6:01 AM · Restricted Project, Restricted Project
hbae closed D122107: [OpenMP] Add support for ompt_callback_dispatch.
Apr 6 2022, 6:01 AM · Restricted Project, Restricted Project

Apr 4 2022

hbae updated the diff for D122107: [OpenMP] Add support for ompt_callback_dispatch.

Added missing REQUIRES line.

Apr 4 2022, 2:34 PM · Restricted Project, Restricted Project

Mar 20 2022

hbae requested review of D122107: [OpenMP] Add support for ompt_callback_dispatch.
Mar 20 2022, 2:49 PM · Restricted Project, Restricted Project

Jan 28 2022

hbae added a comment to D100185: [OpenMP] [OMPD] [5/6] Implementation of OMPD debugging library - libompd. gdb-plugin: A Plugin code to gdb to leverage libompd to provide debugging support..

The change looks good in general.
I tested basic usage of the ompd plugin, and it seems to work fine as expected.
I encountered python-related build issues on some of my test systems (e.g., Ubuntu 18.04) which I cannot resolve by installing required python packages, so I wonder if we need to make this (ompd test infrastructure) an optional feature for those who are interested.

Jan 28 2022, 7:29 PM · Restricted Project, Restricted Project

Oct 26 2021

hbae accepted D100184: [OpenMP] [OMPD] [4/6] Implementation of OMPD debugging library - libompd. omp-icv: OMPD Internal control variable handlers..

LGTM

Oct 26 2021, 4:10 PM · Restricted Project

Oct 22 2021

hbae accepted D111788: [OpenMP] Add OMPT support for omp_all_memory task dependence.

LGTM

Oct 22 2021, 6:54 AM · Restricted Project

Oct 21 2021

hbae added inline comments to D100184: [OpenMP] [OMPD] [4/6] Implementation of OMPD debugging library - libompd. omp-icv: OMPD Internal control variable handlers..
Oct 21 2021, 4:58 PM · Restricted Project

Sep 17 2021

hbae accepted D100183: [OpenMP] [OMPD] [3/6] Implementation of OMPD debugging library - libompd. omp-debug: Implementation of OMPD APIs..

LGTM

Sep 17 2021, 8:56 AM · Restricted Project

Sep 16 2021

hbae accepted D109725: [OpenMP][host runtime] Fix indirect lock table race condition.

LGTM

Sep 16 2021, 4:47 PM · Restricted Project
hbae added inline comments to D100183: [OpenMP] [OMPD] [3/6] Implementation of OMPD debugging library - libompd. omp-debug: Implementation of OMPD APIs..
Sep 16 2021, 12:17 PM · Restricted Project

Sep 15 2021

hbae accepted D109333: [OpenMP] Update third-party sources of ittnotify client code.

LGTM

Sep 15 2021, 4:18 PM · Restricted Project
hbae committed rGae2a5facce96: [OpenMP][libomptarget] Minor fix in x86_64 plugin (authored by hbae).
[OpenMP][libomptarget] Minor fix in x86_64 plugin
Sep 15 2021, 1:57 PM
hbae closed D109846: [OpenMP][libomptarget] Minor fix in x86_64 plugin.
Sep 15 2021, 1:57 PM · Restricted Project
hbae requested review of D109846: [OpenMP][libomptarget] Minor fix in x86_64 plugin.
Sep 15 2021, 12:32 PM · Restricted Project
hbae accepted D106975: [openmp] Update OMPT declaration and implementation in the runtime.
Sep 15 2021, 7:41 AM · Restricted Project

Sep 9 2021

hbae committed rG3976035d68ac: [OpenMP] Fix line truncation in omp_lib.h (authored by hbae).
[OpenMP] Fix line truncation in omp_lib.h
Sep 9 2021, 7:34 AM
hbae closed D109469: [OpenMP] Fix line truncation in omp_lib.h.
Sep 9 2021, 7:34 AM · Restricted Project
hbae updated the diff for D109469: [OpenMP] Fix line truncation in omp_lib.h.

Applied suggested changes.

Sep 9 2021, 6:15 AM · Restricted Project

Sep 8 2021

hbae requested review of D109469: [OpenMP] Fix line truncation in omp_lib.h.
Sep 8 2021, 3:07 PM · Restricted Project

Sep 7 2021

hbae added inline comments to D106975: [openmp] Update OMPT declaration and implementation in the runtime.
Sep 7 2021, 3:24 PM · Restricted Project
hbae accepted D108574: [OpenMP] libomp: runtime part of omp_all_memory task dependence implementation..

LGTM

Sep 7 2021, 3:17 PM · Restricted Project
hbae committed rG224f51d879b5: [OpenMP] Add interface for 5.1 scope construct (authored by hbae).
[OpenMP] Add interface for 5.1 scope construct
Sep 7 2021, 9:23 AM
hbae closed D108062: [OpenMP] Add interface for 5.1 scope construct.
Sep 7 2021, 9:23 AM · Restricted Project

Aug 30 2021

hbae accepted D100182: [OpenMP] [OMPD] [2/6] Implementation of OMPD debugging library - libompd. TargetValue: Access OpenMP runtime state through callbacks provided by tool.

LGTM

Aug 30 2021, 5:46 AM · Restricted Project

Aug 26 2021

hbae added a comment to D100182: [OpenMP] [OMPD] [2/6] Implementation of OMPD debugging library - libompd. TargetValue: Access OpenMP runtime state through callbacks provided by tool.

Looks good to me except for a couple of typos.

Aug 26 2021, 4:47 PM · Restricted Project

Aug 13 2021

hbae requested review of D108062: [OpenMP] Add interface for 5.1 scope construct.
Aug 13 2021, 5:34 PM · Restricted Project
hbae accepted D107348: [OpenMP][NFC] Cleanup: minor fixes to silence static analyzer..

LGTM

Aug 13 2021, 1:19 PM · Restricted Project
hbae accepted D100366: [OpenMP] [OMPD] openmp/runtime code changes required for OMPD.

LGTM

Aug 13 2021, 1:17 PM · Restricted Project

Aug 4 2021

hbae accepted D99803: [openmp] Add OMPT initialization in libomptarget.

LGTM

Aug 4 2021, 8:58 AM · Restricted Project

Aug 2 2021

hbae accepted D106705: [OpenMP] libomp: taskwait depend implementation fixed.

LGTM

Aug 2 2021, 2:05 PM · Restricted Project
hbae accepted D99803: [openmp] Add OMPT initialization in libomptarget.
Aug 2 2021, 1:28 PM · Restricted Project

Jul 29 2021

hbae accepted D106608: [OpenMP][NFC] Cleanup: silence warnings on unused variables..

LGTM

Jul 29 2021, 1:03 PM · Restricted Project
hbae added inline comments to D99803: [openmp] Add OMPT initialization in libomptarget.
Jul 29 2021, 10:53 AM · Restricted Project

Jul 13 2021

hbae committed rGdb635a28e65f: [OpenMP] Minor improvement in task allocation (authored by hbae).
[OpenMP] Minor improvement in task allocation
Jul 13 2021, 7:08 AM
hbae closed D105715: [OpenMP] Minor improvement in task allocation.
Jul 13 2021, 7:08 AM · Restricted Project

Jul 12 2021

hbae updated the diff for D105715: [OpenMP] Minor improvement in task allocation.

Undo the change that introduce __kmp_task_alloc_impl since the outcome may vary depending on the build compiler.

Jul 12 2021, 9:41 AM · Restricted Project

Jul 9 2021

hbae requested review of D105715: [OpenMP] Minor improvement in task allocation.
Jul 9 2021, 10:27 AM · Restricted Project

Jul 1 2021

hbae committed rGf1b9ce2736d8: [OpenMP] Fix a few issues with hidden helper task (authored by hbae).
[OpenMP] Fix a few issues with hidden helper task
Jul 1 2021, 3:11 PM
hbae closed D105308: [OpenMP] Fix a few issues with hidden helper task.
Jul 1 2021, 3:11 PM · Restricted Project
hbae added inline comments to D105308: [OpenMP] Fix a few issues with hidden helper task.
Jul 1 2021, 1:18 PM · Restricted Project
hbae requested review of D105308: [OpenMP] Fix a few issues with hidden helper task.
Jul 1 2021, 12:25 PM · Restricted Project

Jun 24 2021

hbae accepted D104880: [OpenMP][NFC] Fix wrong debug assertion..

LGTM

Jun 24 2021, 3:55 PM · Restricted Project

Jun 4 2021

hbae accepted D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd..

LGTM

Jun 4 2021, 4:02 PM · Restricted Project

Jun 3 2021

hbae added inline comments to D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd..
Jun 3 2021, 6:04 AM · Restricted Project

Jun 2 2021

hbae added inline comments to D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd..
Jun 2 2021, 2:46 PM · Restricted Project
hbae committed rG7ba4e96ede0f: [OpenMP] Use new task type/flag for taskwait depend events. (authored by hbae).
[OpenMP] Use new task type/flag for taskwait depend events.
Jun 2 2021, 8:17 AM
hbae closed D103464: [OpenMP] Use new task type/flag for taskwait depend events.
Jun 2 2021, 8:16 AM · Restricted Project

Jun 1 2021

hbae committed rGcf5c94ef08f9: [OpenMP] Define named constants for interop's foreign runtime ID (authored by hbae).
[OpenMP] Define named constants for interop's foreign runtime ID
Jun 1 2021, 11:07 AM
hbae closed D102883: [OpenMP] Define named constants for interop's foreign runtime ID.
Jun 1 2021, 11:07 AM · Restricted Project
hbae requested review of D103464: [OpenMP] Use new task type/flag for taskwait depend events.
Jun 1 2021, 8:22 AM · Restricted Project
hbae updated the diff for D102883: [OpenMP] Define named constants for interop's foreign runtime ID.

Fixed incorrect parameter type.

Jun 1 2021, 8:13 AM · Restricted Project

May 24 2021

hbae committed rG95cefacfe1c1: [OpenMP] Fix crashing critical section with hint clause (authored by hbae).
[OpenMP] Fix crashing critical section with hint clause
May 24 2021, 3:26 PM
hbae closed D102955: [OpenMP] Fix crashing critical section with hint clause.
May 24 2021, 3:26 PM · Restricted Project

May 21 2021

hbae requested review of D102955: [OpenMP] Fix crashing critical section with hint clause.
May 21 2021, 4:22 PM · Restricted Project

May 20 2021

hbae requested review of D102883: [OpenMP] Define named constants for interop's foreign runtime ID.
May 20 2021, 4:09 PM · Restricted Project

May 5 2021

hbae added a comment to D101882: [OpenMP] Fix hidden helper + affinity assignment.

Ignore my last action (my mistake).

May 5 2021, 6:16 AM · Restricted Project
hbae removed a reviewer for D101882: [OpenMP] Fix hidden helper + affinity assignment: jlpeyton.
May 5 2021, 6:15 AM · Restricted Project
hbae added a reviewer for D101882: [OpenMP] Fix hidden helper + affinity assignment: jlpeyton.
May 5 2021, 6:14 AM · Restricted Project

Apr 27 2021

hbae added inline comments to D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd..
Apr 27 2021, 5:11 PM · Restricted Project

Apr 16 2021

hbae committed rG9b98497b4458: [OpenMP] Add omp_target_is_accessible() to header files (authored by hbae).
[OpenMP] Add omp_target_is_accessible() to header files
Apr 16 2021, 5:55 AM
hbae closed D100420: [OpenMP] Add omp_target_is_accessible() to header files.
Apr 16 2021, 5:54 AM · Restricted Project

Apr 14 2021

hbae committed rG77dc7b465313: [OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT (authored by hbae).
[OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT
Apr 14 2021, 5:56 AM
hbae closed D100414: [OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT.
Apr 14 2021, 5:56 AM · Restricted Project

Apr 13 2021

hbae requested review of D100420: [OpenMP] Add omp_target_is_accessible() to header files.
Apr 13 2021, 4:09 PM · Restricted Project
hbae requested review of D100414: [OpenMP] Fix printing routine for OMP_TOOL_VERBOSE_INIT.
Apr 13 2021, 3:20 PM · Restricted Project

Apr 6 2021

hbae committed rG3da61ddae7fe: [OpenMP] Define omp_is_initial_device() variants in omp.h (authored by hbae).
[OpenMP] Define omp_is_initial_device() variants in omp.h
Apr 6 2021, 2:58 PM
hbae closed D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.
Apr 6 2021, 2:58 PM · Restricted Project, Restricted Project

Apr 5 2021

hbae updated the diff for D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.

Added inline after static to avoid unused function warning.
Added a RUN line to the test to catch unused function warning.

Apr 5 2021, 3:43 PM · Restricted Project, Restricted Project

Apr 2 2021

hbae added inline comments to D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.
Apr 2 2021, 3:13 PM · Restricted Project, Restricted Project
hbae updated the diff for D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.

Removed omp_is_initial_device() from clang built-ins.
Added a new test under openmp/libomptarget.

Apr 2 2021, 3:11 PM · Restricted Project, Restricted Project

Mar 26 2021

hbae requested review of D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h.
Mar 26 2021, 3:34 PM · Restricted Project, Restricted Project

Mar 23 2021

hbae committed rG467f39249dbb: [OpenMP] Misc. changes that add or remove pointer/bound checks (authored by hbae).
[OpenMP] Misc. changes that add or remove pointer/bound checks
Mar 23 2021, 4:56 PM
hbae closed D98584: [OpenMP] Misc. changes that add or remove pointer/bound checks.
Mar 23 2021, 4:55 PM · Restricted Project

Mar 16 2021

hbae committed rGa6f9cb6adc59: [OpenMP] Add runtime interface for OpenMP 5.1 error directive (authored by hbae).
[OpenMP] Add runtime interface for OpenMP 5.1 error directive
Mar 16 2021, 6:56 AM
hbae closed D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.
Mar 16 2021, 6:56 AM · Restricted Project

Mar 15 2021

hbae updated the diff for D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.

Applied suggested changes and added a test.

Mar 15 2021, 5:58 PM · Restricted Project
hbae updated the diff for D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.

Added ident_t * parameter.

Mar 15 2021, 9:37 AM · Restricted Project
hbae added a comment to D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.

It is unclear what we should do with ident_t at the moment.
Is it going to be useful if we include the location info in the warning/error message?

Mar 15 2021, 8:13 AM · Restricted Project

Mar 13 2021

hbae requested review of D98584: [OpenMP] Misc. changes that add or remove pointer/bound checks.
Mar 13 2021, 9:20 AM · Restricted Project

Mar 11 2021

hbae requested review of D98448: [OpenMP] Add runtime interface for OpenMP 5.1 error directive.
Mar 11 2021, 12:39 PM · Restricted Project

Mar 2 2021

hbae committed rGb6c2f538b22b: [OpenMP] Add allocator support for target memory (authored by hbae).
[OpenMP] Add allocator support for target memory
Mar 2 2021, 2:46 PM
hbae closed D96669: [OpenMP] Add allocator support for target memory.
Mar 2 2021, 2:46 PM · Restricted Project

Feb 24 2021

hbae added a comment to D96669: [OpenMP] Add allocator support for target memory.

There will be a separate patch for libomptarget.

Feb 24 2021, 5:13 PM · Restricted Project
hbae updated the summary of D96669: [OpenMP] Add allocator support for target memory.
Feb 24 2021, 3:18 PM · Restricted Project
hbae updated the diff for D96669: [OpenMP] Add allocator support for target memory.

Changed prefix from preomp to llvm_omp.

Feb 24 2021, 3:16 PM · Restricted Project

Feb 22 2021

hbae accepted D96893: [OpenMP] libomp minor cleanup.

LGTM

Feb 22 2021, 11:06 AM · Restricted Project
hbae accepted D96749: [OpenMP] Limit number of dispatch buffers.

LGTM

Feb 22 2021, 8:21 AM · Restricted Project

Feb 21 2021

hbae accepted D96750: [OpenMP] Remove shutdown attempt on Windows process detach.

LGTM

Feb 21 2021, 11:45 AM · Restricted Project
hbae accepted D96748: [OpenMP] Update HWLOC topology detection for die level.

LGTM

Feb 21 2021, 11:35 AM · Restricted Project
hbae accepted D96562: [OpenMP] libomp: fix ittnotify stack stitching for teams construct.

LGTM

Feb 21 2021, 11:27 AM · Restricted Project