This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx11 EXECZ and VCCZ are no longer allowed to be used as
ClosedPublic

Authored by Joe_Nash on Jun 6 2022, 12:05 PM.

Details

Summary

sources to SALU and VALU instructions.

Contributors:
Baptiste Saleil <baptiste.saleil@amd.com>

Patch 20/N for upstreaming of AMDGPU gfx11 architecture

Depends on D126989

Diff Detail

Event Timeline

Joe_Nash created this revision.Jun 6 2022, 12:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 12:05 PM
Joe_Nash requested review of this revision.Jun 6 2022, 12:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 12:05 PM
Joe_Nash added reviewers: kzhuravl, rampitec, foad, bsaleil, Restricted Project.Jun 6 2022, 12:07 PM

Looks like 2 separate patches.

Joe_Nash updated this revision to Diff 434592.Jun 6 2022, 1:37 PM

reduced size of change

rampitec accepted this revision.Jun 6 2022, 1:55 PM

LGTM, but please change the description.

This revision is now accepted and ready to land.Jun 6 2022, 1:55 PM
Joe_Nash retitled this revision from [AMDGPU] gfx11 MC asm printer/parser tweaks to [AMDGPU] gfx11 EXECZ and VCCZ are no longer allowed to be used as.Jun 7 2022, 6:10 AM
Joe_Nash edited the summary of this revision. (Show Details)
foad accepted this revision.Jun 8 2022, 3:39 AM

LGTM modulo nits.

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
4502

Nit: & goes after the space. Doesn't clang-format fix this?

5619–5620

I would do this as a separate commit, but consider it pre-approved.

5643

I would do this plus the other comment tweak on line 5609 as a separate commit, no review required.

Joe_Nash updated this revision to Diff 435549.Jun 9 2022, 7:44 AM
Joe_Nash marked 3 inline comments as done.

removed src_pops change, removed comment change, clang-format

addressed foad's comments

foad accepted this revision.Jun 9 2022, 7:46 AM

Still LGTM!

This revision was landed with ongoing or failed builds.Jun 10 2022, 7:31 AM
This revision was automatically updated to reflect the committed changes.