Page MenuHomePhabricator
People bsaleil

bsaleil (Baptiste Saleil)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2019, 12:42 PM (67 w, 1 d)

Recent Activity
View All

Wed, Jan 20

bsaleil added a comment to D92405: [VirtRegRewriter] Insert missing killed flags when tracking subregister liveness.

Gentle ping :)

Wed, Jan 20, 7:26 AM · Restricted Project

Fri, Jan 15

bsaleil added inline comments to D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.
Fri, Jan 15, 2:42 PM · Restricted Project, Restricted Project
bsaleil updated the diff for D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.

Use isISA3_1 instead of hasP10Vector and add P9 run line in test case.

Fri, Jan 15, 2:41 PM · Restricted Project, Restricted Project
bsaleil accepted D94498: [PowerPC][NFC] Update atomics patterns to use the refactored load/store implementation.

LGTM

Fri, Jan 15, 1:45 PM · Restricted Project, Restricted Project

Tue, Jan 12

bsaleil added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Thanks a lot for working on that Amy ! I have some comments on the patch.

Tue, Jan 12, 1:55 PM · Restricted Project, Restricted Project

Mon, Jan 11

bsaleil added reviewers for D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10: nemanjai, stefanp.
Mon, Jan 11, 2:37 PM · Restricted Project, Restricted Project
bsaleil requested review of D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.
Mon, Jan 11, 2:36 PM · Restricted Project, Restricted Project

Tue, Jan 5

bsaleil added inline comments to D92405: [VirtRegRewriter] Insert missing killed flags when tracking subregister liveness.
Tue, Jan 5, 9:01 PM · Restricted Project
bsaleil updated the diff for D92405: [VirtRegRewriter] Insert missing killed flags when tracking subregister liveness.

Remove unrelated NFC change, simplify lane mask computation and MIR code

Tue, Jan 5, 8:56 PM · Restricted Project
bsaleil added inline comments to D94058: [PowerPC] Sign extend comparison operand for signed atomic comparisons.
Tue, Jan 5, 8:48 AM · Restricted Project

Dec 16 2020

bsaleil updated the diff for D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_.

Rebase and fix comment

Dec 16 2020, 9:27 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2020

bsaleil committed rG57d83c3a90c4: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled (authored by bsaleil).
[PowerPC] Enable paired vector type and intrinsics when MMA is disabled
Dec 15 2020, 1:15 PM
bsaleil closed D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled.
Dec 15 2020, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil added inline comments to D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled.
Dec 15 2020, 10:26 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2020

bsaleil accepted D92864: [PowerPC] Set SubRegIndex offset for sub_vsx1/sub_pair1.

Good catch, thanks for fixing that.

Dec 8 2020, 1:38 PM · Restricted Project

Dec 4 2020

bsaleil accepted D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.

LGTM, just a minor comment regarding the multiclass.

Dec 4 2020, 7:55 AM · Restricted Project

Dec 3 2020

bsaleil committed rG45ec3a37b0a5: [PowerPC] Fix for excessive ACC copies due to PHI nodes (authored by bsaleil).
[PowerPC] Fix for excessive ACC copies due to PHI nodes
Dec 3 2020, 7:52 AM
bsaleil closed D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.
Dec 3 2020, 7:52 AM · Restricted Project

Dec 2 2020

bsaleil updated the diff for D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.

Update patch so it applies to ToT

Dec 2 2020, 3:06 PM · Restricted Project
bsaleil updated the diff for D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.

Fix comments

Dec 2 2020, 2:46 PM · Restricted Project

Dec 1 2020

bsaleil added inline comments to D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.
Dec 1 2020, 1:28 PM · Restricted Project
bsaleil requested review of D92405: [VirtRegRewriter] Insert missing killed flags when tracking subregister liveness.
Dec 1 2020, 10:18 AM · Restricted Project

Nov 26 2020

bsaleil added a comment to D92139: [PowerPC] Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition .

Why do we need these flags for PLXVP and PSTXVP ? Please, add a test case showing why this is required.

Nov 26 2020, 1:10 PM · Restricted Project

Nov 24 2020

bsaleil accepted D91420: [PowerPC][PCRelative] Add new pseudo instructions for PCRel TLS to fix R2 clobber issue.

LGTM, thanks.

Nov 24 2020, 8:24 AM · Restricted Project

Nov 23 2020

bsaleil updated the summary of D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_.
Nov 23 2020, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
bsaleil retitled D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_ from [PowerPC] Rename the pair intrinsics and builtins to replace the _mma_ prefix by _vsx_ to [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_.
Nov 23 2020, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
bsaleil requested review of D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_.
Nov 23 2020, 9:23 AM · Restricted Project, Restricted Project, Restricted Project

Nov 19 2020

bsaleil added a reviewer for D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled: Restricted Project.
Nov 19 2020, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil requested review of D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled.
Nov 19 2020, 1:27 PM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2020

bsaleil committed rG18db29ea6fb6: [PowerPC] Add peephole to remove redundant accumulator prime/unprime… (authored by bsaleil).
[PowerPC] Add peephole to remove redundant accumulator prime/unprime…
Nov 18 2020, 1:01 PM
bsaleil closed D91386: [PowerPC] Add peephole to remove redundant accumulator prime/unprime instructions.
Nov 18 2020, 1:01 PM · Restricted Project, Restricted Project

Nov 16 2020

bsaleil updated the diff for D91386: [PowerPC] Add peephole to remove redundant accumulator prime/unprime instructions.

Update comments

Nov 16 2020, 7:57 AM · Restricted Project, Restricted Project

Nov 13 2020

bsaleil committed rG3f78605a8cb1: [PowerPC] Add paired vector load and store builtins and intrinsics (authored by bsaleil).
[PowerPC] Add paired vector load and store builtins and intrinsics
Nov 13 2020, 10:36 AM
bsaleil closed D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.
Nov 13 2020, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
bsaleil added inline comments to D91420: [PowerPC][PCRelative] Add new pseudo instructions for PCRel TLS to fix R2 clobber issue.
Nov 13 2020, 8:45 AM · Restricted Project

Nov 12 2020

bsaleil updated the diff for D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.

Remove test case metadata and attributes

Nov 12 2020, 5:18 PM · Restricted Project
bsaleil updated the diff for D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.

Remove metadata from test files and fix comment

Nov 12 2020, 5:04 PM · Restricted Project
bsaleil accepted D90498: Fix the compilation assertion due to unreachable BB pruning not deleting the associated BB from the jump tables.

LGTM

Nov 12 2020, 2:32 PM · Restricted Project
bsaleil requested review of D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.
Nov 12 2020, 2:03 PM · Restricted Project
bsaleil requested review of D91386: [PowerPC] Add peephole to remove redundant accumulator prime/unprime instructions.
Nov 12 2020, 1:25 PM · Restricted Project, Restricted Project
bsaleil committed rG170e45ae186b: [PowerPC] Prevent the use of MMA with P9 and earlier (authored by bsaleil).
[PowerPC] Prevent the use of MMA with P9 and earlier
Nov 12 2020, 8:37 AM
bsaleil closed D91200: [PowerPC] Prevent the use of MMA with P9 and earlier.
Nov 12 2020, 8:37 AM · Restricted Project, Restricted Project

Nov 11 2020

bsaleil updated the diff for D91200: [PowerPC] Prevent the use of MMA with P9 and earlier.

clang-format

Nov 11 2020, 2:46 PM · Restricted Project, Restricted Project

Nov 10 2020

bsaleil requested review of D91200: [PowerPC] Prevent the use of MMA with P9 and earlier.
Nov 10 2020, 12:12 PM · Restricted Project, Restricted Project

Nov 9 2020

bsaleil updated the diff for D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.

Simplify control flow and improve test cases

Nov 9 2020, 1:25 PM · Restricted Project, Restricted Project, Restricted Project

Nov 6 2020

bsaleil updated the diff for D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.

Fix unaligned load/store select

Nov 6 2020, 1:48 PM · Restricted Project, Restricted Project, Restricted Project

Nov 5 2020

bsaleil updated the diff for D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.

Rebase patch and add Sema check test case for the builtins

Nov 5 2020, 10:00 AM · Restricted Project, Restricted Project, Restricted Project
bsaleil added a reviewer for D90799: [PowerPC] Add paired vector load and store builtins and intrinsics: shchenz.
Nov 5 2020, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
bsaleil updated the diff for D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.

Add support for the paired load/store intrinsics in PPCLoopInstrFormPrep

Nov 5 2020, 8:42 AM · Restricted Project, Restricted Project, Restricted Project

Nov 4 2020

bsaleil added inline comments to D82035: [PowerPC] Add Sema checks for MMA types.
Nov 4 2020, 3:34 PM · Restricted Project, Restricted Project
bsaleil updated the diff for D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.

Add builtin tests

Nov 4 2020, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil committed rGf976ba613958: [PowerPC] Add Sema checks for MMA types (authored by bsaleil).
[PowerPC] Add Sema checks for MMA types
Nov 4 2020, 3:02 PM
bsaleil closed D82035: [PowerPC] Add Sema checks for MMA types.
Nov 4 2020, 3:02 PM · Restricted Project, Restricted Project
bsaleil updated the summary of D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.
Nov 4 2020, 2:10 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil requested review of D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.
Nov 4 2020, 2:08 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil updated the diff for D82035: [PowerPC] Add Sema checks for MMA types.

Change function name and improve comment

Nov 4 2020, 11:16 AM · Restricted Project, Restricted Project

Nov 3 2020

bsaleil committed rGdaa127d77eab: [PowerPC] Add MMA builtin decoding and definitions (authored by bsaleil).
[PowerPC] Add MMA builtin decoding and definitions
Nov 3 2020, 1:09 PM
bsaleil closed D81748: [PowerPC] Add MMA builtin decoding and definitions.
Nov 3 2020, 1:09 PM · Restricted Project, Restricted Project
bsaleil accepted D90616: [PowerPC] Accumulator/Unprimed Accumulator register copy, spill and restore.

LGTM, Thanks

Nov 3 2020, 12:39 PM · Restricted Project

Oct 28 2020

bsaleil updated the diff for D81748: [PowerPC] Add MMA builtin decoding and definitions.

Fix typo and add comment to explain why we add the ASTContext::DecodeTypeStr function.

Oct 28 2020, 2:22 PM · Restricted Project, Restricted Project
bsaleil committed rG40dd4d5233d9: [Clang][PowerPC] Add __vector_pair and __vector_quad types (authored by bsaleil).
[Clang][PowerPC] Add __vector_pair and __vector_quad types
Oct 28 2020, 11:19 AM
bsaleil closed D81508: [PowerPC] Add __vector_pair and __vector_quad types.
Oct 28 2020, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2020

bsaleil abandoned D74087: [Sema] Fix Sema checkArgCount function.
Oct 27 2020, 8:54 AM · Restricted Project
bsaleil abandoned D81744: [PowerPC] Add MMA intrinsic definitions.

Duplicate of D89345

Oct 27 2020, 8:53 AM · Restricted Project, Restricted Project
bsaleil updated the summary of D82035: [PowerPC] Add Sema checks for MMA types.
Oct 27 2020, 8:49 AM · Restricted Project, Restricted Project
bsaleil updated the summary of D81748: [PowerPC] Add MMA builtin decoding and definitions.
Oct 27 2020, 8:48 AM · Restricted Project, Restricted Project
bsaleil updated the diff for D82035: [PowerPC] Add Sema checks for MMA types.

Rebasing patch

Oct 27 2020, 8:47 AM · Restricted Project, Restricted Project

Oct 26 2020

bsaleil updated the summary of D81748: [PowerPC] Add MMA builtin decoding and definitions.
Oct 26 2020, 3:36 PM · Restricted Project, Restricted Project
bsaleil added reviewers for D81748: [PowerPC] Add MMA builtin decoding and definitions: rsmith, amyk, saghir, lei, nemanjai.
Oct 26 2020, 3:29 PM · Restricted Project, Restricted Project
bsaleil updated the diff for D81748: [PowerPC] Add MMA builtin decoding and definitions.

Rebase patch

Oct 26 2020, 3:24 PM · Restricted Project, Restricted Project

Oct 23 2020

bsaleil updated the summary of D81508: [PowerPC] Add __vector_pair and __vector_quad types.
Oct 23 2020, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil updated the summary of D81508: [PowerPC] Add __vector_pair and __vector_quad types.
Oct 23 2020, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil updated the diff for D81508: [PowerPC] Add __vector_pair and __vector_quad types.

Rebasing the patch

Oct 23 2020, 2:13 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil accepted D89345: [PowerPC] Add intrinsics for MMA.

LGTM

Oct 23 2020, 9:51 AM · Restricted Project, Restricted Project

Oct 5 2020

bsaleil accepted D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.

LGTM, please fix the unrelated change when committing.

Oct 5 2020, 2:59 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil accepted D88739: [PowerPC] Add assemble disassemble intrinsics for MMA.

LGTM

Oct 5 2020, 2:07 PM · Restricted Project

Sep 29 2020

bsaleil accepted D88043: [PowerPC] Add outer product instructions for MMA.

LGTM, thanks. I think the patch can be committed once the typos are fixed.

Sep 29 2020, 11:14 AM · Restricted Project

Sep 28 2020

bsaleil committed rG0156914275be: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types (authored by bsaleil).
[PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types
Sep 28 2020, 12:40 PM
bsaleil closed D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Sep 28 2020, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil updated the diff for D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.

Use early exit in lowering functions and extend test case

Sep 28 2020, 12:07 PM · Restricted Project, Restricted Project, Restricted Project

Sep 25 2020

bsaleil committed rG9b86b7009430: [PowerPC] Add accumulator register class and instructions (authored by bsaleil).
[PowerPC] Add accumulator register class and instructions
Sep 25 2020, 10:25 AM
bsaleil closed D84847: [PowerPC] Add accumulator register class and instructions.
Sep 25 2020, 10:25 AM · Restricted Project, Restricted Project
bsaleil updated the diff for D84847: [PowerPC] Add accumulator register class and instructions.

Rebase & simplify if condition

Sep 25 2020, 8:43 AM · Restricted Project, Restricted Project

Sep 23 2020

bsaleil added inline comments to D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.
Sep 23 2020, 11:37 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

bsaleil committed rGbb821355387f: [PowerPC] Remove unnecessary patterns and types (authored by bsaleil).
[PowerPC] Remove unnecessary patterns and types
Sep 21 2020, 2:09 PM
bsaleil committed rG1372e23c7d4b: [PowerPC] Add vector pair load/store instructions and vector pair register class (authored by bsaleil).
[PowerPC] Add vector pair load/store instructions and vector pair register class
Sep 21 2020, 8:28 AM
bsaleil closed D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.
Sep 21 2020, 8:28 AM · Restricted Project, Restricted Project

Sep 18 2020

bsaleil updated the diff for D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

Directly use printOperand to print VSRp registers.

Sep 18 2020, 12:25 PM · Restricted Project, Restricted Project
bsaleil updated the diff for D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

Remove unnecessary empty line and use the printOperand function to print VSRp regs

Sep 18 2020, 11:35 AM · Restricted Project, Restricted Project

Sep 9 2020

bsaleil updated the summary of D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Sep 9 2020, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
bsaleil updated the diff for D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.

Rebase so the patch can be applied on top of master. Also change the datalayout string on all ppc64 platforms to improve compatibility between object files.

Sep 9 2020, 12:47 PM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2020

bsaleil updated the diff for D84847: [PowerPC] Add accumulator register class and instructions.

Rebase so the patch can be applied to latest master

Sep 8 2020, 12:43 PM · Restricted Project, Restricted Project
bsaleil added inline comments to D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.
Sep 8 2020, 11:46 AM · Restricted Project, Restricted Project, Restricted Project
bsaleil updated the diff for D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

Move class definitions above predicates

Sep 8 2020, 10:58 AM · Restricted Project, Restricted Project

Sep 1 2020

bsaleil accepted D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn.

LGTM, thanks for adding that.

Sep 1 2020, 7:38 AM · Restricted Project, Restricted Project, Restricted Project
bsaleil accepted D86794: [PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and xvcvbf16spn.

LGTM

Sep 1 2020, 7:34 AM · Restricted Project, Restricted Project

Aug 24 2020

bsaleil committed rG512e256c0d8c: [PowerPC] Add clang options to control MMA support (authored by bsaleil).
[PowerPC] Add clang options to control MMA support
Aug 24 2020, 7:37 AM
bsaleil closed D81442: [PowerPC] Add clang options to control MMA support.
Aug 24 2020, 7:37 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2020

bsaleil accepted D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.

LGTM

Aug 4 2020, 11:58 AM · Restricted Project, Restricted Project, Restricted Project

Jul 30 2020

bsaleil updated the summary of D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Jul 30 2020, 11:51 AM · Restricted Project, Restricted Project, Restricted Project