Page MenuHomePhabricator

bsaleil (Baptiste Saleil)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2019, 12:42 PM (49 w, 15 h)

Recent Activity

Wed, Sep 9

bsaleil updated the summary of D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Wed, Sep 9, 12:48 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil updated the diff for D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.

Rebase so the patch can be applied on top of master. Also change the datalayout string on all ppc64 platforms to improve compatibility between object files.

Wed, Sep 9, 12:47 PM · Restricted Project, Unknown Object (Project), Restricted Project

Tue, Sep 8

bsaleil updated the diff for D84847: [PowerPC] Add accumulator register class and instructions.

Rebase so the patch can be applied to latest master

Tue, Sep 8, 12:43 PM · Unknown Object (Project), Restricted Project
bsaleil added inline comments to D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI.
Tue, Sep 8, 11:46 AM · Unknown Object (Project), Restricted Project, Restricted Project
bsaleil updated the diff for D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

Move class definitions above predicates

Tue, Sep 8, 10:58 AM · Unknown Object (Project), Restricted Project

Tue, Sep 1

bsaleil accepted D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn.

LGTM, thanks for adding that.

Tue, Sep 1, 7:38 AM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil accepted D86794: [PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and xvcvbf16spn.

LGTM

Tue, Sep 1, 7:34 AM · Unknown Object (Project), Restricted Project

Mon, Aug 24

bsaleil committed rG512e256c0d8c: [PowerPC] Add clang options to control MMA support (authored by bsaleil).
[PowerPC] Add clang options to control MMA support
Mon, Aug 24, 7:37 AM
bsaleil closed D81442: [PowerPC] Add clang options to control MMA support.
Mon, Aug 24, 7:37 AM · Restricted Project, Unknown Object (Project), Restricted Project

Aug 4 2020

bsaleil accepted D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.

LGTM

Aug 4 2020, 11:58 AM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 30 2020

bsaleil updated the summary of D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Jul 30 2020, 11:51 AM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil requested review of D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Jul 30 2020, 11:50 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jul 29 2020

bsaleil updated the diff for D84847: [PowerPC] Add accumulator register class and instructions.

Fix missing break in switch case

Jul 29 2020, 10:53 AM · Unknown Object (Project), Restricted Project
bsaleil updated the summary of D84847: [PowerPC] Add accumulator register class and instructions.
Jul 29 2020, 7:17 AM · Unknown Object (Project), Restricted Project
bsaleil added a reviewer for D84847: [PowerPC] Add accumulator register class and instructions: Restricted Project.
Jul 29 2020, 7:17 AM · Unknown Object (Project), Restricted Project
bsaleil requested review of D84847: [PowerPC] Add accumulator register class and instructions.
Jul 29 2020, 7:17 AM · Unknown Object (Project), Restricted Project

Jul 28 2020

bsaleil updated the diff for D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

Rebased patch

Jul 28 2020, 3:37 PM · Unknown Object (Project), Restricted Project
bsaleil updated the diff for D81442: [PowerPC] Add clang options to control MMA support.

Update diff so it can be applied to master.

Jul 28 2020, 3:33 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil updated the diff for D83722: [PowerPC] Add options to control paired vector memops support.

Update diff so it can be applied to master

Jul 28 2020, 1:20 PM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 22 2020

bsaleil updated the summary of D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.
Jul 22 2020, 1:42 PM · Unknown Object (Project), Restricted Project
bsaleil created D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.
Jul 22 2020, 1:41 PM · Unknown Object (Project), Restricted Project
bsaleil added inline comments to D83722: [PowerPC] Add options to control paired vector memops support.
Jul 22 2020, 1:17 PM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 20 2020

bsaleil updated the diff for D83722: [PowerPC] Add options to control paired vector memops support.

Add PairedVectorMemops to the list of unsupported features in a comment

Jul 20 2020, 9:16 PM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 16 2020

bsaleil accepted D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests.

Thanks for the explanation. LGTM.

Jul 16 2020, 9:09 AM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 15 2020

bsaleil added inline comments to D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests.
Jul 15 2020, 12:31 PM · Unknown Object (Project), Restricted Project, Restricted Project
bsaleil accepted D83724: [PowerPC][Power10] Add Vector Extract/Expand/Count with Mask, Move to VSR Mask Instruction Definitions and MC Tests.

LGTM

Jul 15 2020, 12:21 PM · Unknown Object (Project), Restricted Project

Jul 14 2020

bsaleil updated the diff for D81442: [PowerPC] Add clang options to control MMA support.

Add test to check that the mma option is supported by the targets.

Jul 14 2020, 9:05 AM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil updated the diff for D83722: [PowerPC] Add options to control paired vector memops support.

Add test to check paired-vector-memops is supported by the targets.

Jul 14 2020, 8:47 AM · Unknown Object (Project), Restricted Project, Restricted Project
bsaleil updated the diff for D83722: [PowerPC] Add options to control paired vector memops support.

Re-upload with surrounding context

Jul 14 2020, 8:18 AM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 13 2020

bsaleil accepted D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..

LGTM

Jul 13 2020, 3:13 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil updated the diff for D81442: [PowerPC] Add clang options to control MMA support.

Also add target options with this patch

Jul 13 2020, 3:00 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil added a project to D81442: [PowerPC] Add clang options to control MMA support: Restricted Project.
Jul 13 2020, 2:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil created D83722: [PowerPC] Add options to control paired vector memops support.
Jul 13 2020, 2:44 PM · Unknown Object (Project), Restricted Project, Restricted Project
bsaleil added reviewers for D81508: [PowerPC] Add __vector_pair and __vector_quad types: ABataev, kkwli0, power-llvm-team.
Jul 13 2020, 9:54 AM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil added reviewers for D81442: [PowerPC] Add clang options to control MMA support: power-llvm-team, lei, nemanjai, saghir, amyk.
Jul 13 2020, 9:44 AM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil updated the diff for D81442: [PowerPC] Add clang options to control MMA support.
Jul 13 2020, 9:43 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jul 9 2020

bsaleil added a comment to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Shouldn't we have test cases to test vec_sl, vec_sr and vec_sra ?

Jul 9 2020, 12:14 PM · Unknown Object (Project), Restricted Project, Restricted Project
bsaleil added inline comments to D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend.
Jul 9 2020, 12:05 PM · Unknown Object (Project), Restricted Project, Restricted Project

Jun 19 2020

bsaleil edited reviewers for D81442: [PowerPC] Add clang options to control MMA support, added: Restricted Project; removed: power-llvm-team.
Jun 19 2020, 6:28 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil added a project to D82035: [PowerPC] Add Sema checks for MMA types: Unknown Object (Project).
Jun 19 2020, 6:28 PM · Unknown Object (Project), Restricted Project
bsaleil added a project to D81748: [PowerPC] Add MMA builtin decoding and definitions: Unknown Object (Project).
Jun 19 2020, 6:28 PM · Unknown Object (Project), Restricted Project
bsaleil added a project to D81744: [PowerPC] Add MMA intrinsic definitions: Unknown Object (Project).
Jun 19 2020, 6:28 PM · Unknown Object (Project), Restricted Project
bsaleil added a reviewer for D82035: [PowerPC] Add Sema checks for MMA types: Restricted Project.
Jun 19 2020, 6:28 PM · Unknown Object (Project), Restricted Project
bsaleil added a reviewer for D81748: [PowerPC] Add MMA builtin decoding and definitions: Restricted Project.
Jun 19 2020, 6:28 PM · Unknown Object (Project), Restricted Project
bsaleil added a reviewer for D81744: [PowerPC] Add MMA intrinsic definitions: Restricted Project.
Jun 19 2020, 6:28 PM · Unknown Object (Project), Restricted Project
bsaleil updated the summary of D81508: [PowerPC] Add __vector_pair and __vector_quad types.
Jun 19 2020, 6:28 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil updated the summary of D81442: [PowerPC] Add clang options to control MMA support.
Jun 19 2020, 6:28 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil added a reviewer for D81442: [PowerPC] Add clang options to control MMA support: power-llvm-team.
Jun 19 2020, 6:28 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil added a reviewer for D81508: [PowerPC] Add __vector_pair and __vector_quad types: Restricted Project.
Jun 19 2020, 6:28 PM · Restricted Project, Unknown Object (Project), Restricted Project
bsaleil updated the summary of D81508: [PowerPC] Add __vector_pair and __vector_quad types.
Jun 19 2020, 6:28 PM · Restricted Project, Unknown Object (Project), Restricted Project

Jun 17 2020

bsaleil created D82035: [PowerPC] Add Sema checks for MMA types.
Jun 17 2020, 11:50 AM · Unknown Object (Project), Restricted Project

Jun 16 2020

bsaleil added a comment to D76802: [InstrProfiling] Use !associated metadata for counters, data and values.
Jun 16 2020, 12:05 PM · Restricted Project, Restricted Project

Jun 12 2020

bsaleil retitled D81744: [PowerPC] Add MMA intrinsic definitions from [PowerPC] Add MMA intrinsic definition to [PowerPC] Add MMA intrinsic definitions.
Jun 12 2020, 9:48 AM · Unknown Object (Project), Restricted Project
bsaleil created D81748: [PowerPC] Add MMA builtin decoding and definitions.
Jun 12 2020, 9:48 AM · Unknown Object (Project), Restricted Project
bsaleil created D81744: [PowerPC] Add MMA intrinsic definitions.
Jun 12 2020, 8:38 AM · Unknown Object (Project), Restricted Project

Jun 9 2020

bsaleil added a comment to D76802: [InstrProfiling] Use !associated metadata for counters, data and values.

Hello,
This patch also broke some of our PowerPC buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/4263).
Can you please push a fix or revert ?
Thanks.

Jun 9 2020, 3:28 PM · Restricted Project, Restricted Project
bsaleil created D81508: [PowerPC] Add __vector_pair and __vector_quad types.
Jun 9 2020, 2:54 PM · Restricted Project, Unknown Object (Project), Restricted Project

Jun 8 2020

bsaleil created D81442: [PowerPC] Add clang options to control MMA support.
Jun 8 2020, 6:50 PM · Restricted Project, Unknown Object (Project), Restricted Project

Jun 5 2020

bsaleil added a comment to D80984: [CostModel] Unify getMemoryOpCost.

It seems that commit is breaking some of our PPC buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/4118)
Could you please fix it asap or revert ?

Jun 5 2020, 12:54 PM · Restricted Project

Feb 6 2020

bsaleil updated the summary of D74087: [Sema] Fix Sema checkArgCount function.
Feb 6 2020, 11:35 AM · Restricted Project
bsaleil updated the summary of D74087: [Sema] Fix Sema checkArgCount function.
Feb 6 2020, 11:35 AM · Restricted Project
bsaleil updated the diff for D74087: [Sema] Fix Sema checkArgCount function.

Adding test case

Feb 6 2020, 11:26 AM · Restricted Project

Feb 5 2020

bsaleil created D74087: [Sema] Fix Sema checkArgCount function.
Feb 5 2020, 1:40 PM · Restricted Project

Dec 11 2019

bsaleil added a comment to rGeb3e81f43f01: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h.

The issue is solved now and the buildbot is back to green. Thank you.

Dec 11 2019, 11:38 AM

Dec 10 2019

bsaleil added a comment to rGeb3e81f43f01: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h.

Hello Johannes,

Dec 10 2019, 10:52 PM

Nov 18 2019

bsaleil added a comment to D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.

Fixed comment style mismatch

Nov 18 2019, 7:42 AM · Restricted Project, Restricted Project
bsaleil updated the diff for D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.

Make comment style uniform

Nov 18 2019, 7:42 AM · Restricted Project, Restricted Project

Nov 6 2019

bsaleil updated the diff for D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.

Improved test case by testing conversion of the biggest negative int128.

Nov 6 2019, 12:12 PM · Restricted Project, Restricted Project

Nov 1 2019

bsaleil created D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.
Nov 1 2019, 12:32 PM · Restricted Project, Restricted Project

Oct 18 2019

bsaleil created D69193: [compiler-rt][builtins][PowerPC] Fix __fixunstfti builtin on PowerPC.
Oct 18 2019, 1:46 PM · Restricted Project, Restricted Project