Revert changes improving the pass implementation, these changes will be addressed in another patch.

In D101939#2741529, @foad wrote:

In D101939#2740008, @arsenm wrote:

Can we address it being slow instead of just turning of everything that is? There's no reason it should be slow, but the way it uses liveness information is horrible

On small functions I think the run time of this pass is dominated by the two calls to TRI->getAllocatableSet, which means two identical calls to SIRegisterInfo::getReservedRegs, which has a very large fixed cost. Is there some way the Reserved register set can be cached (in the SIMachineFunctionInfo object?)?

Add the TargetRegisterInfo::getAllocatableSets method to avoid calling getReservedRegs multiple times when we want allocatable sets for multiple register classes.

In D101939#2740008, @arsenm wrote:

Can we address it being slow instead of just turning of everything that is? There's no reason it should be slow, but the way it uses liveness information is horrible

In D101414#2738462, @foad wrote:

In D101414#2738443, @critson wrote:

llc-pipeline.ll has problems with -DLLVM_ENABLE_EXPENSIVE_CHECKS=1 as instruction verification seems to still take place.

test/CodeGen/X86/opt-pipeline.ll uses grep -v to filter these lines out.

In D101414#2737354, @thakis wrote:

This breaks incremental builders: http://45.33.8.238/linux/45830/step_12.txt

Ptal. You'll need a -o /dev/null and an rm -f for the temp file to clean up bots (can remove the latter after a bit)

Enable the passes only from -O2 or when explicitly enabled with flags. Also update the test case to ensure the passes are run for -O1 when explicitly enabled.

Remove checks for the "Pass Arguments:" lines in the test case.

In D101414#2721285, @arsenm wrote:

Needs a testcase. I think we have some pass pipeline tests already to show what's run (maybe not for -O1, I didn't know anyone actually used it)

Add test case

Update patch so it applies upstream.

Specialize DenseMapInfo directly with the PPC TOC key type instead of VariantKind.

Generate uninitialized external TLS data with the .csect directive instead of .comm

I forgot to link the commit with this differential, but the patch has been committed: https://github.com/llvm/llvm-zorg/commit/45c4f238dc6fd9855b8578aa3ca3b8db336efb7e

Add support for variables with internal linkage.

Rebase and reduce PPC test case.

LGTM, I only have a minor comment.

Thanks for addressing the comments, LGTM now.

LGTM

Gentle ping :)

Use isISA3_1 instead of hasP10Vector and add P9 run line in test case.

LGTM

Thanks a lot for working on that Amy ! I have some comments on the patch.

Remove unrelated NFC change, simplify lane mask computation and MIR code

Rebase and fix comment

Good catch, thanks for fixing that.

LGTM, just a minor comment regarding the multiclass.

Update patch so it applies to ToT

Fix comments

Why do we need these flags for PLXVP and PSTXVP ? Please, add a test case showing why this is required.

LGTM, thanks.

Update comments

Remove test case metadata and attributes

Remove metadata from test files and fix comment

LGTM

clang-format

Simplify control flow and improve test cases

Fix unaligned load/store select

Rebase patch and add Sema check test case for the builtins

Add support for the paired load/store intrinsics in PPCLoopInstrFormPrep

Add builtin tests

Change function name and improve comment