This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Make PseudoReadVL have the vtypes of the corresponding VLEFF/VLSEGFF.
ClosedPublic

Authored by fakepaper56 on May 8 2022, 7:54 PM.

Details

Summary

The patch make PseudoReadVL have the vtypes of the corresponding VLEFF/VLSEGFF.
It's useful to get the vtypes of locations of PseudoReadVL without finding the
corresponding VLEFF/VLSEGFF.
It could simplify optimizations in RISCVInsertVSETVLI like D123581.

Diff Detail

Event Timeline

fakepaper56 created this revision.May 8 2022, 7:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2022, 7:54 PM
fakepaper56 requested review of this revision.May 8 2022, 7:54 PM
craig.topper added inline comments.May 9 2022, 1:46 PM
llvm/test/CodeGen/RISCV/rvv/vleff-rv32-readvl.ll
46

Can you support this in RISCVInstrInfo::createMIROperandComment so that we add a comment to show 64 as a human readable vsetvli vtype operand?

kito-cheng added inline comments.May 9 2022, 7:27 PM
llvm/test/CodeGen/RISCV/rvv/vleff-rv32-readvl.ll
46

Add human readable comment for vtypes of PseudoReadVL MIs.

Refine the comments of createMIROperandComment.

fakepaper56 marked 2 inline comments as done.May 9 2022, 8:16 PM
fakepaper56 added inline comments.
llvm/test/CodeGen/RISCV/rvv/vleff-rv32-readvl.ll
46

Thank you. I thank decoding vtype by human brain is too hard. But I don't remember the comments of Vtype in vsetvli :(.

fakepaper56 marked an inline comment as not done.May 10 2022, 12:51 AM
This revision is now accepted and ready to land.May 10 2022, 4:29 PM
This revision was landed with ongoing or failed builds.May 10 2022, 11:08 PM
This revision was automatically updated to reflect the committed changes.