This is an archive of the discontinued LLVM Phabricator instance.

[mlir][NFC] Shift a bunch of dialect includes from the .h to the .cpp
ClosedPublic

Authored by rriddle on Apr 22 2022, 2:17 PM.

Details

Summary

Now that dialect constructors are generated in the .cpp file, we can
drop all of the dependent dialect includes from the .h file.

Diff Detail

Event Timeline

rriddle created this revision.Apr 22 2022, 2:17 PM
Herald added a reviewer: jpienaar. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: sjarus. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Apr 22 2022, 2:17 PM
rriddle added a reviewer: mehdi_amini.
rriddle updated this revision to Diff 424610.Apr 22 2022, 2:24 PM
rriddle edited the summary of this revision. (Show Details)
lattner accepted this revision.Apr 22 2022, 3:04 PM

nice, this is super exciting!

mehdi_amini accepted this revision.Apr 22 2022, 5:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2022, 1:33 AM
This revision was automatically updated to reflect the committed changes.