This is an archive of the discontinued LLVM Phabricator instance.

[Clang][CodeGen]Remove anonymous tag locations
ClosedPublic

Authored by yihanaa on Mar 29 2022, 10:44 AM.

Details

Summary

Remove anonymous tag locations, powered by 'PrintingPolicy', @aaron.ballman once suggested removing this extra information in https://reviews.llvm.org/D122248
struct:

struct S {
  int a;
  struct /* Anonymous*/ {
    int x;
  } b;
  int c;
};

Before:

struct S {
int a = 0
struct S::(unnamed at ./builtin_dump_struct.c:20:3) {
    int x = 0
    }
int c = 0
}

After:

struct S {
    int a = 0
    struct S::(unnamed) {
        int x = 0
    }
    int c = 0
}

Diff Detail

Event Timeline

yihanaa created this revision.Mar 29 2022, 10:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2022, 10:44 AM
yihanaa requested review of this revision.Mar 29 2022, 10:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2022, 10:44 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
erichkeane accepted this revision.Mar 29 2022, 10:47 AM

I think Aaron wants release notes for just about everything :) Mind tossing one on this patch? I'll commit for you after that.

This revision is now accepted and ready to land.Mar 29 2022, 10:47 AM

I think Aaron wants release notes for just about everything :) Mind tossing one on this patch? I'll commit for you after that.

Thanks @erichkeane ,i try to add this change into ReleaseNotes.😁

yihanaa updated this revision to Diff 418929.Mar 29 2022, 10:55 AM

Add this change into ReleaseNotes.

erichkeane accepted this revision.Mar 29 2022, 10:58 AM

Still LGTM.

yihanaa added a comment.EditedMar 29 2022, 10:59 AM

Still LGTM.

Thank you! @erichkeane, I still need you to help me commit.😁