This is an archive of the discontinued LLVM Phabricator instance.

Differential D122523

[lldb] Fix building standalone LLDB on Windows.
ClosedPublic

Authored by MehdiChinoune on Mar 25 2022, 11:20 PM.

Details

Reviewers
thakis
JDevlieghere
Group Reviewers
Restricted Project
Commits
rG3031fa88f01e: [lldb] Fix building standalone LLDB on Windows.
Summary

It was broken since https://reviews.llvm.org/D110172

Diff Detail

Event Timeline

MehdiChinoune created this revision.Mar 25 2022, 11:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 11:20 PM
Herald added subscribers: JDevlieghere, mgorny. · View Herald Transcript
MehdiChinoune requested review of this revision.Mar 25 2022, 11:20 PM
Herald added subscribers: llvm-commits, lldb-commits. · View Herald TranscriptMar 25 2022, 11:20 PM
jeremyd2019 added a subscriber: jeremyd2019.Mar 26 2022, 7:27 AM
Harbormaster completed remote builds in B156402: Diff 418380.Mar 26 2022, 4:02 PM
mati865 added a subscriber: mati865.Mar 27 2022, 10:09 AM
JDevlieghere accepted this revision as: JDevlieghere.Mar 31 2022, 7:44 PM

LGTM

This revision is now accepted and ready to land.Mar 31 2022, 7:44 PM
MehdiChinoune added a comment.Apr 3 2022, 8:50 PM

Could someone push it for me, Please.

MehdiChinoune added a subscriber: mstorsjo.Apr 6 2022, 10:19 AM
mstorsjo added a comment.Apr 6 2022, 10:26 AM

@MehdiChinoune can you provide your preferred form of the git author line, Real Name <email@address>?

MehdiChinoune added a comment.Apr 7 2022, 12:59 AM
In D122523#3433643, @mstorsjo wrote:

@MehdiChinoune can you provide your preferred form of the git author line, Real Name <email@address>?

Mehdi Chinoune <mehdi.chinoune@hotmail.com>
Thanks!

Closed by commit rG3031fa88f01e: [lldb] Fix building standalone LLDB on Windows. (authored by MehdiChinoune, committed by mstorsjo). · Explain WhyApr 7 2022, 2:31 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG3031fa88f01e: [lldb] Fix building standalone LLDB on Windows..

Revision Contents

PathSize
lldb/
source/
Plugins/
SymbolFile/
PDB/
2 lines
llvm/
include/
llvm/
Config/
3 lines
3 lines

Diff 418380

lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

Context not available.
#include "Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h" #include "Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h"
#if defined(_WIN32) #if defined(_WIN32)
#include "llvm/Config/config.h" #include "llvm/Config/llvm-config.h"
#endif #endif
using namespace lldb; using namespace lldb;
Context not available.

llvm/include/llvm/Config/config.h.cmake

Context not available.
don't. */ don't. */
#cmakedefine01 HAVE_DECL_STRERROR_S #cmakedefine01 HAVE_DECL_STRERROR_S
/* Define to 1 if you have the DIA SDK installed, and to 0 if you don't. */
#cmakedefine01 LLVM_ENABLE_DIA_SDK
/* Define to 1 if you have the <dlfcn.h> header file. */ /* Define to 1 if you have the <dlfcn.h> header file. */
#cmakedefine HAVE_DLFCN_H ${HAVE_DLFCN_H} #cmakedefine HAVE_DLFCN_H ${HAVE_DLFCN_H}
Context not available.

llvm/include/llvm/Config/llvm-config.h.cmake

Context not available.
* in non assert builds */ * in non assert builds */
#cmakedefine01 LLVM_UNREACHABLE_OPTIMIZE #cmakedefine01 LLVM_UNREACHABLE_OPTIMIZE
/* Define to 1 if you have the DIA SDK installed, and to 0 if you don't. */
#cmakedefine01 LLVM_ENABLE_DIA_SDK
#endif #endif
Context not available.