Page MenuHomePhabricator

[lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO
ClosedPublic

Authored by thakis on Sep 21 2021, 6:57 AM.

Details

Summary

Trying to use the DIA SDK reader only to fail with "DIA SDK wasn't enabled"
isn't very useful. The native PDB reader is missing some stuff, but it's
still better than nothing.

Reduces number of lldb-check-shell test failures with LLVM_ENABLE_DIA_SDK=NO from
27 to 15.

Diff Detail

Event Timeline

thakis created this revision.Sep 21 2021, 6:57 AM
thakis updated this revision to Diff 373909.Sep 21 2021, 7:00 AM

slightly simpler preprocessor goop

thakis updated this revision to Diff 373910.Sep 21 2021, 7:02 AM

slightly nicer preprocessor goop in more correct

This revision is now accepted and ready to land.Sep 21 2021, 8:54 AM
labath added inline comments.Sep 22 2021, 1:49 AM
lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
89–90

What's the value of LLVM_ENABLE_DIA_SDK on non-windows platforms? It seems to be zero on my (linux) system. Could this be just #if LLVM_ENABLE_DIA_SDK ?

This commit make building standalone LLDB impossible on Windows. llvm/Config/config.h file is only generated at build-time and not get installed with llvm.
Please Fix it.

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 10:59 PM