[lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO
ClosedPublic
Actions

Authored by thakis on Sep 21 2021, 6:57 AM.

Details

Reviewers

labath
amccarth

Commits

rG908c11544212: [lldb/win] Default to native PDB reader when LLVM_ENABLE_DIA_SDK=NO

Summary

Trying to use the DIA SDK reader only to fail with "DIA SDK wasn't enabled"
isn't very useful. The native PDB reader is missing some stuff, but it's
still better than nothing.

Reduces number of lldb-check-shell test failures with LLVM_ENABLE_DIA_SDK=NO from
27 to 15.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

thakis created this revision.Sep 21 2021, 6:57 AM

Herald added a subscriber: JDevlieghere. · View Herald TranscriptSep 21 2021, 6:57 AM

thakis requested review of this revision.Sep 21 2021, 6:57 AM

thakis mentioned this in D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO.

Harbormaster completed remote builds in B124901: Diff 373906.Sep 21 2021, 7:00 AM

slightly simpler preprocessor goop

slightly nicer preprocessor goop in more correct

Harbormaster completed remote builds in B124904: Diff 373910.Sep 21 2021, 7:04 AM

LGTM

This revision is now accepted and ready to land.Sep 21 2021, 8:54 AM

Closed by commit rG908c11544212: [lldb/win] Default to native PDB reader when LLVM_ENABLE_DIA_SDK=NO (authored by thakis). · Explain WhySep 21 2021, 10:03 AM

This revision was automatically updated to reflect the committed changes.

thakis added a commit: rG908c11544212: [lldb/win] Default to native PDB reader when LLVM_ENABLE_DIA_SDK=NO.

labath added inline comments.Sep 22 2021, 1:49 AM

lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
89–90	What's the value of LLVM_ENABLE_DIA_SDK on non-windows platforms? It seems to be zero on my (linux) system. Could this be just `#if LLVM_ENABLE_DIA_SDK` ?

This commit make building standalone LLDB impossible on Windows. llvm/Config/config.h file is only generated at build-time and not get installed with llvm.
Please Fix it.

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 10:59 PM

MehdiChinoune mentioned this in D122523: [lldb] Fix building standalone LLDB on Windows..Mar 25 2022, 11:20 PM

mstorsjo mentioned this in rG3031fa88f01e: [lldb] Fix building standalone LLDB on Windows..Apr 7 2022, 2:31 AM