Page MenuHomePhabricator

mati865 (Mateusz Mikuła)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2016, 5:55 AM (195 w, 5 d)

Recent Activity

Tue, Aug 4

mati865 added a comment to D85210: [OpenMP] Don't use MSVC workaround with MinGW.

Thank you!

Tue, Aug 4, 9:05 AM · Restricted Project
mati865 added a comment to D85210: [OpenMP] Don't use MSVC workaround with MinGW.

At MSYS2 we are using older revision of this patch: https://github.com/msys2/MINGW-packages/commit/e071f276d31a8d214c2f30530eb9ac3ed44fffc7#diff-7f8e056c3dca04423132b5e4e1d36813

Tue, Aug 4, 8:18 AM · Restricted Project
mati865 added a comment to D85210: [OpenMP] Don't use MSVC workaround with MinGW.

Little background:
Recent CMake versions changed behaviour on MinGW and treat .a as static libs only. Currently CMake creates omp.a as the import library and new CMake doesn't like that.

Tue, Aug 4, 7:58 AM · Restricted Project
mati865 added a reviewer for D81776: [OpenMP] support build on msys2/mingw with clang or gcc: mstorsjo.
Tue, Aug 4, 7:19 AM · Restricted Project, Restricted Project
mati865 requested review of D85210: [OpenMP] Don't use MSVC workaround with MinGW.
Tue, Aug 4, 7:12 AM · Restricted Project
mati865 requested review of D85195: Add Z3 to system libraries list if enabled.
Tue, Aug 4, 5:19 AM · Restricted Project

Jun 23 2020

mati865 abandoned D79999: [lldb] [Windows] Provide vasprintf only for MSVC.
Jun 23 2020, 10:10 AM · Restricted Project

Jun 3 2020

mati865 added a comment to D80876: [clang] Default to windows response files when running on windows.

I don't have strong opinion here as I don't know this topic well (things just worked so far).
That said if Clang stops working as a drop-in replacement for GCC with commonly used build systems, MSYS2 will have to carry one more patch to bring back old behaviour.

Jun 3 2020, 3:48 AM · Restricted Project

Jun 1 2020

mati865 added a comment to D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt.

Thanks, sounds good.

Jun 1 2020, 6:55 AM · Restricted Project
mati865 accepted D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt.

I don't know why AddLibGCC has to be called twice but that doesn't really matter for this diff.

Jun 1 2020, 5:51 AM · Restricted Project
mati865 added a comment to D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt.

Wouldn't it better fit in AddLibGCC?

Jun 1 2020, 4:46 AM · Restricted Project

May 28 2020

mati865 added a comment to D79995: [clang] [MinGW] Fix libunwind extension.

No worries.
Mateusz Mikuła <mati865@gmail.com>

May 28 2020, 3:25 PM · Restricted Project
mati865 updated the diff for D79995: [clang] [MinGW] Fix libunwind extension.
May 28 2020, 2:19 PM · Restricted Project
mati865 updated the diff for D79995: [clang] [MinGW] Fix libunwind extension.

Added test.

May 28 2020, 2:18 PM · Restricted Project

May 26 2020

mati865 added a comment to D79995: [clang] [MinGW] Fix libunwind extension.

@mstorsjo @rnk will be away since June

May 26 2020, 3:11 AM · Restricted Project

May 24 2020

mati865 accepted D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.
May 24 2020, 2:24 PM · Restricted Project
mati865 added inline comments to D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.
May 24 2020, 12:16 PM · Restricted Project

May 23 2020

mati865 added inline comments to D80425: Fix LLVM/Clang builds with mingw toolchain.
May 23 2020, 2:19 PM · Restricted Project, Restricted Project
mati865 added inline comments to D80425: Fix LLVM/Clang builds with mingw toolchain.
May 23 2020, 5:15 AM · Restricted Project, Restricted Project

May 22 2020

mati865 added inline comments to D80425: Fix LLVM/Clang builds with mingw toolchain.
May 22 2020, 8:34 AM · Restricted Project, Restricted Project

May 15 2020

mati865 updated the diff for D79999: [lldb] [Windows] Provide vasprintf only for MSVC.

With _GNU_SOURCE removed I was able to successfully build everything without this diff.
I cannot test it today but I believe this updated diff would have fixed the error.

May 15 2020, 2:10 PM · Restricted Project
mati865 added a comment to D79999: [lldb] [Windows] Provide vasprintf only for MSVC.

Indeed, I'll see if I can build all LLVM related packages without _GNU_SOURCE. Otherwise I'll guard it with #ifndef _GNU_SOURCE instead.

May 15 2020, 11:57 AM · Restricted Project
mati865 added a comment to D79999: [lldb] [Windows] Provide vasprintf only for MSVC.

Perhaps you are building with Clang?
I don't remember the message but GCC emits error about incompatible definition and declaration of vasprintf. I can build it without the patch and paste the error if you want.

May 15 2020, 11:24 AM · Restricted Project
mati865 updated the diff for D79995: [clang] [MinGW] Fix libunwind extension.

Applied review comment and formatted.

May 15 2020, 11:24 AM · Restricted Project
mati865 created D79999: [lldb] [Windows] Provide vasprintf only for MSVC.
May 15 2020, 5:53 AM · Restricted Project
mati865 changed the repository for D79995: [clang] [MinGW] Fix libunwind extension from rC Clang to rG LLVM Github Monorepo.
May 15 2020, 5:53 AM · Restricted Project
mati865 created D79995: [clang] [MinGW] Fix libunwind extension.
May 15 2020, 5:13 AM · Restricted Project

May 8 2020

mati865 added a comment to D79619: [LLD] [COFF] Fix def file exporting of symbols containing periods.

Confirming that this patch fixes linking MinGW Rust with LLD.

May 8 2020, 6:23 AM · Restricted Project

Apr 2 2020

mati865 added a comment to D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON .

MSYS2 provides LLVM built with LLVM_BUILD_LLVM_DYLIB=TRUE and hits the same issue. So far it was using this hack: https://github.com/msys2/MINGW-packages/blob/f31bc199ade4d1025cda9bb5aed4427f80d3c584/mingw-w64-clang/0012-fix-testplugin-linking.patch
Applying set(LLVM_LINK_COMPONENTS Core) from this diff also fixes the build.

Apr 2 2020, 10:17 AM · Restricted Project

Apr 8 2019

Herald added a project to D51963: [Polly] Really fix Windows builds.: Restricted Project.
Apr 8 2019, 3:14 AM · Restricted Project
Herald added a project to D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.: Restricted Project.
Apr 8 2019, 3:14 AM · Restricted Project

Mar 3 2019

Herald added a project to D26739: [MemCpyOpt] Port to MemorySSA. Disabled by default.: Restricted Project.
Mar 3 2019, 6:03 AM · Restricted Project

Feb 22 2019

mati865 abandoned D29950: Provide DESTDIR on all platforms.
Feb 22 2019, 2:40 AM

Jan 3 2019

mati865 added a comment to D53631: Fix libcxx build with MinGW winpthreads.

Can somebody land it before LLVM 8 is branched? Patch author does not have commit access.

Jan 3 2019, 7:03 AM

Oct 25 2018

mati865 added a comment to D53480: remove duplicate omp_control_tool export to fix windows build.

@jlpeyton OP doesn't have commit access.

Oct 25 2018, 3:51 AM

Nov 17 2017

mati865 added inline comments to D39710: Simplify unlinkAsync.
Nov 17 2017, 1:26 PM

Sep 9 2017

mati865 added inline comments to D33601: libunwind: fix building on mingw-w64.
Sep 9 2017, 2:24 AM

Jun 29 2017

mati865 abandoned D34606: [libcxx] Link MinGW libs for shared build.
Jun 29 2017, 3:50 PM
mati865 added a comment to D34606: [libcxx] Link MinGW libs for shared build.

Sorry @martell I totally forgot about it.
I'll test D33638 later today.

Jun 29 2017, 3:46 PM
mati865 updated subscribers of D34606: [libcxx] Link MinGW libs for shared build.
Jun 29 2017, 3:24 PM

Jun 25 2017

mati865 updated subscribers of D34599: [builtins] Flag __builtin_cl* functions as `static`.
Jun 25 2017, 8:00 AM
mati865 created D34606: [libcxx] Link MinGW libs for shared build.
Jun 25 2017, 7:49 AM

May 26 2017

mati865 added a comment to rL304012: Enable __float128 for mingw for GCC compatibility and define….

Some time ago I both enabled __float128 and defined macro but using it (__float128) cased segfaults. So I reduced it to HasFloat128 and haven't upstreamed it due to broken tests. It's good to see things improved.

May 26 2017, 12:17 PM

May 25 2017

mati865 added a comment to D33388: [libcxx] fixup bootstrapping for mingw-w64.

@EricWF I think basic usage should be fine as soon as libc++abi gets linked properly. I suppose it haven't changed much since https://reviews.llvm.org/P7981
Back then replacing libc++abi with libsupc++ with few more hacks created almost-working libc++.

May 25 2017, 4:40 PM

May 14 2017

mati865 accepted D33082: Fix Libc++ build with MinGW64.

I don't know if it is MSYS2 specific or general MinGW issue but liblibc++.a is created. Could you check your build?
Here is line to blame: https://github.com/llvm-mirror/libcxx/blob/master/lib/CMakeLists.txt#L246

May 14 2017, 3:12 AM

Apr 15 2017

mati865 accepted D15006: Driver: Better detection of mingw-gcc.

Looks fine for MinGW on Windows.

Apr 15 2017, 7:33 AM

Apr 7 2017

mati865 removed a reviewer for D29950: Provide DESTDIR on all platforms: chandlerc.

Ping

Apr 7 2017, 1:07 PM

Apr 3 2017

mati865 created P7983 libc++abi mingw clang.
Apr 3 2017, 6:17 AM
mati865 created P7982 libc++abi mingw gcc.
Apr 3 2017, 6:14 AM

Apr 1 2017

mati865 edited P7981 libc++ mingw shared.
Apr 1 2017, 5:20 PM

Mar 31 2017

mati865 created P7981 libc++ mingw shared.
Mar 31 2017, 5:35 PM
mati865 activated P7980 libc++ mingw.
Mar 31 2017, 12:32 PM
mati865 edited P7980 libc++ mingw.
Mar 31 2017, 12:26 PM
mati865 awarded D29892: ar: add llvm-dlltool support a Like token.
Mar 31 2017, 11:08 AM
mati865 archived P7980 libc++ mingw.
Mar 31 2017, 11:07 AM
mati865 created P7980 libc++ mingw.
Mar 31 2017, 11:00 AM

Mar 17 2017

mati865 created P7976 libc++ with mingw-w64 clang.
Mar 17 2017, 3:02 PM
mati865 created P7975 libc++ with mingw-w64 gcc.
Mar 17 2017, 3:01 PM

Mar 16 2017

mati865 added a comment to D29952: Create msbuild only when using MSVC.

Thank you @rnk
Could you check https://reviews.llvm.org/D29772 ? Looks like there was problem with commit

Mar 16 2017, 2:08 PM
mati865 added a comment to D29952: Create msbuild only when using MSVC.

Ping

Mar 16 2017, 12:22 PM
mati865 added a comment to D29950: Provide DESTDIR on all platforms.

Ping

Mar 16 2017, 12:21 PM

Mar 11 2017

mati865 updated subscribers of D29772: Create msbuild only when using MSVC.

@asl it is still not commited.
Something went wrong?

Mar 11 2017, 1:41 PM · Restricted Project

Mar 6 2017

mati865 set the repository for D29772: Create msbuild only when using MSVC to rL LLVM.
Mar 6 2017, 2:39 AM · Restricted Project
mati865 added a comment to D29772: Create msbuild only when using MSVC.

Thank you.

Mar 6 2017, 1:49 AM · Restricted Project
mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

Thank you.

Mar 6 2017, 1:48 AM · Restricted Project

Mar 1 2017

mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

Ping.

Mar 1 2017, 3:02 PM · Restricted Project

Feb 17 2017

mati865 added a comment to D29772: Create msbuild only when using MSVC.

Commit it please when you aren't busy.
Thanks in advance.

Feb 17 2017, 3:48 PM · Restricted Project
mati865 added a reviewer for D29772: Create msbuild only when using MSVC: rnk.

https://reviews.llvm.org/D29952 depends on this.

Feb 17 2017, 2:31 PM · Restricted Project

Feb 15 2017

mati865 added a comment to D29952: Create msbuild only when using MSVC.

I suppose those 4 lines were your concern: https://github.com/llvm-mirror/llvm/blob/3ca564103abdd0c70f28f270873a2e535c245a6f/CMakeLists.txt#L231

Feb 15 2017, 2:33 AM

Feb 14 2017

mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

If there are no further objections it can be committed by somebody.

Feb 14 2017, 3:08 PM · Restricted Project
mati865 added a comment to rL289609: [llvm-config] Fixing one check where shared libs implied dylib.

It might be not relevant but it broke llvm-config --libs --link-shared when LLVM is built with:

-DLLVM_BUILD_LLVM_DYLIB=ON \
-DLLVM_LINK_LLVM_DYLIB=OFF \
Feb 14 2017, 12:19 PM
mati865 added a comment to D29952: Create msbuild only when using MSVC.

That's valid concern, I'll try tomorrow to find out how it works.

Feb 14 2017, 11:50 AM
mati865 created D29952: Create msbuild only when using MSVC.
Feb 14 2017, 11:29 AM
mati865 updated the diff for D29950: Provide DESTDIR on all platforms.

Fixed intend

Feb 14 2017, 11:03 AM
mati865 created D29950: Provide DESTDIR on all platforms.
Feb 14 2017, 11:01 AM
mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

Final decision is left for @rnk and @asl but I'm still against using GCC "internal" headers in the way they aren't supposed to be used. And have MinGW Clang behaving like Linux Clang.

Feb 14 2017, 5:56 AM · Restricted Project
mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

@yaron.keren, @rnk I would like to see OpenMP support by MinGW Clang but using GCC "internal" headers is just wrong.

Feb 14 2017, 4:45 AM · Restricted Project

Feb 13 2017

mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

My GPU has died in the meantime but openmp project doesn't seem buildable with mingw-w64 based compilers.
So the case is still open.

Feb 13 2017, 1:07 PM · Restricted Project

Feb 9 2017

mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

omp.h on Linux is supported by OpenMP package https://www.archlinux.org/packages/extra/x86_64/openmp/files/
I haven't tried to build it on win32 yet but since my examination session at college is over I'll try it in following days.

Feb 9 2017, 12:45 PM · Restricted Project
mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

@yaron.keren those includes are not available in native Linux Clang:

float128_ex.cc:2:10: fatal error: 'quadmath.h' file not found
#include <quadmath.h>
         ^

And at least 2 of GCC includes clash with Clang includes:

Feb 9 2017, 11:47 AM · Restricted Project
mati865 created D29772: Create msbuild only when using MSVC.
Feb 9 2017, 10:02 AM · Restricted Project
mati865 updated the diff for D29464: [MinGWToolChain] Don't use GCC headers on Win32.

Removed adding GCC includes for all mingw hosts.

Feb 9 2017, 9:58 AM · Restricted Project

Feb 3 2017

mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

I know why mingw-w64 limits.h weren't used (check first comment).
At first I was using this hack:

diff -urN clang.orig/3.9.0/include/limits.h clang/3.9.0/include/limits.h
--- clang.orig/3.9.0/include/limits.h	2016-09-26 22:29:13.496441000 +0200
+++ clang/3.9.0/include/limits.h	2016-09-26 22:29:34.189625100 +0200
@@ -28,7 +28,7 @@
 /* The system's limits.h may, in turn, try to #include_next GCC's limits.h.
    Avert this #include_next madness. */
 #if defined __GNUC__ && !defined _GCC_LIMITS_H_
-#define _GCC_LIMITS_H_
+#define _LIMITS_H___
 #endif
Feb 3 2017, 8:28 AM · Restricted Project
mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.
// c:\mingw32\lib\gcc\i686-w64-mingw32\4.9.1\include
// c:\mingw32\lib\gcc\i686-w64-mingw32\4.9.1\include-fixed

for Clang is wrong on Windows because including limits.h will not show an error and won't really include mingw-w64 limits.h
Output of code from my earlier comment without patch:

error: use of undeclared identifier 'PATH_MAX'
int main() { char buf[PATH_MAX]; }

I haven't used cross compiled Clang on Linux so I added #ifndef LLVM_ON_WIN32 guard for this code.
With this guard Clang on Windows uses include paths like native Clang on Linux

Feb 3 2017, 5:57 AM · Restricted Project
mati865 created P7968 Include directories.
Feb 3 2017, 5:56 AM

Feb 2 2017

mati865 added a comment to D29464: [MinGWToolChain] Don't use GCC headers on Win32.

I don't know about Linux but on Windows this code was causing issue:

Feb 2 2017, 10:55 AM · Restricted Project
mati865 created D29464: [MinGWToolChain] Don't use GCC headers on Win32.
Feb 2 2017, 10:47 AM · Restricted Project