Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

mati865 (Mateusz Mikuła)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2016, 5:55 AM (358 w, 2 d)

Recent Activity

Tue, Sep 12

mati865 added a comment to D158011: Make _LIBUNWIND_SUPPORT_FRAME_APIS not conditional on target architecure..

If you use windows-gnu triples Rust will link libgcc_s or libgcc_eh directly unless you modify it's source not to do it: https://github.com/rust-lang/rust/blob/e5fedceabf4e0564231db592b6d1f35e1ca27908/compiler/rustc_target/src/spec/windows_gnu_base.rs#L64

Tue, Sep 12, 2:39 PM · Restricted Project, Restricted Project, Restricted Project
mati865 added a comment to D158011: Make _LIBUNWIND_SUPPORT_FRAME_APIS not conditional on target architecure..

Rust doesn't use LLVM's libunwind for mingw-w64, it relies on libgcc.

Tue, Sep 12, 2:06 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 1

mati865 accepted D159085: [lli] Make sure the exported __chkstk functions are included when exporting them.
Fri, Sep 1, 9:13 AM · Restricted Project, Restricted Project
mati865 added a comment to D159223: [llvm-windres] Implement the windres flag --use-temp-file.

So no regression, but for this usecase we placed that particular user of the tool in a tricky spot

Fri, Sep 1, 9:09 AM · Restricted Project, Restricted Project
mati865 added inline comments to D159085: [lli] Make sure the exported __chkstk functions are included when exporting them.
Fri, Sep 1, 8:41 AM · Restricted Project, Restricted Project
mati865 accepted D159223: [llvm-windres] Implement the windres flag --use-temp-file.

I don't have any experience with --use-temp-file so I'll trust your judgement.
Let's get this regression fixed but I'm also curious about the plan for future `--preprocessor changes.

Fri, Sep 1, 8:32 AM · Restricted Project, Restricted Project

Tue, Aug 29

mati865 added inline comments to D159085: [lli] Make sure the exported __chkstk functions are included when exporting them.
Tue, Aug 29, 8:59 AM · Restricted Project, Restricted Project

Aug 24 2023

mati865 accepted D158411: [clang] [MinGW] Pass LTO options to the linker.

LGTM

Aug 24 2023, 7:12 AM · Restricted Project, Restricted Project

Aug 22 2023

mati865 added a comment to D158412: [LLD] [MinGW] Pass LLVM specific LTO options through to lld-link.

LGTM

Aug 22 2023, 8:41 AM · Restricted Project, Restricted Project

Jul 23 2023

mati865 added a comment to D61670: [clang] [MinGW] Add the option -fno-auto-import.

If we make the flag imply linker options, then it becomes much clearer to spot the error, if you enabled this but the code base still would need autoimports somewhere. (This has happened - see https://code.videolan.org/videolan/dav1d/-/merge_requests/1303#note_301859, https://code.videolan.org/videolan/dav1d/-/merge_requests/1349 and https://code.videolan.org/videolan/dav1d/-/merge_requests/1361.) If we make the flag only affect code generation, it becomes a more clear match for projects using -mcmodel=small with GCC today.

Jul 23 2023, 8:59 AM · Restricted Project, Restricted Project

Jul 10 2023

mati865 accepted D154777: [LLD] [COFF] Warn about pseudo relocations that are too narrow.

I'm in favor of the warning. I don't know LLVM process for adding new errors for code that was previously accepted (even if wrongly) but IMO new errors should be introduced in a way that doesn't surprisingly break downstreams.
So I'd be okay if this becomes a warning in next release (N) and an error/hard error (don't think LLD threats them differently though) in release N+1 or N+2.

Jul 10 2023, 1:56 PM · Restricted Project, Restricted Project

Jun 7 2023

mati865 added inline comments to D152363: [llvm-dlltool] Implement the --no-leading-underscore option.
Jun 7 2023, 7:32 AM · Restricted Project, Restricted Project
mati865 accepted D152361: [llvm-dlltool] Ignore the --temp-prefix option.

LGTM

Jun 7 2023, 7:28 AM · Restricted Project, Restricted Project
mati865 accepted D152359: [COFF] Remove misleading and unclear comments. NFC..

LGTM

Jun 7 2023, 7:28 AM · Restricted Project, Restricted Project
mati865 accepted D152360: [llvm-dlltool] Clarify parameters, simplify ArgList usage. NFC..

LGTM

Jun 7 2023, 7:26 AM · Restricted Project, Restricted Project

May 6 2023

mati865 accepted D149998: [test] [llvm-config] Assume unix style lib names on mingw targets.

LGTM

May 6 2023, 12:53 AM · Restricted Project, Restricted Project

Apr 24 2023

mati865 added a comment to D144084: [LLD] [COFF] Don't try to detect MSVC installations in mingw mode.

I'm not sure what would be best here - add a more specific -tolerate-duplicate-weak-sybols option or something like that? Or add a more specific flag, always passed by default by the mingw driver frontend, e.g. -detect-msvc:no?

Apr 24 2023, 3:43 PM · Restricted Project, Restricted Project

Mar 25 2023

mati865 accepted D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes.
Mar 25 2023, 1:54 AM · Restricted Project, Restricted Project
mati865 added a comment to D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes.

Oh, that's unfortunate.
Maybe llvm-windres should generate a warning in such case?

Mar 25 2023, 1:54 AM · Restricted Project, Restricted Project

Feb 20 2023

mati865 added a comment to D144084: [LLD] [COFF] Don't try to detect MSVC installations in mingw mode.

Should that even be considered as supported?

Feb 20 2023, 4:44 PM · Restricted Project, Restricted Project

Feb 16 2023

mati865 accepted D144084: [LLD] [COFF] Don't try to detect MSVC installations in mingw mode.

LGTM

Feb 16 2023, 1:21 PM · Restricted Project, Restricted Project

Jan 13 2023

mati865 accepted D141206: [clang] [MinGW] Avoid adding <base>/include and <base>/lib when cross compiling.
Jan 13 2023, 11:25 AM · Restricted Project, Restricted Project
mati865 added a comment to D141206: [clang] [MinGW] Avoid adding <base>/include and <base>/lib when cross compiling.

I cannot speak much about LLVM tests but the code looks good for me.

Jan 13 2023, 11:24 AM · Restricted Project, Restricted Project

Jan 12 2023

mati865 added a comment to D141206: [clang] [MinGW] Avoid adding <base>/include and <base>/lib when cross compiling.

Updated with some testcases. This does test that the include directory is omitted when cross compiling, but those kinds of tests, which set up a simulated toolchain environment with symlinks, don't run on actual Windows - so it's not quite as easy to test the case that we actually do keep the unprefixed include directory on Windows. As this matches the current testing coverage status quo, I hope this is ok...

Jan 12 2023, 7:51 AM · Restricted Project, Restricted Project

Jan 8 2023

mati865 added a comment to D141206: [clang] [MinGW] Avoid adding <base>/include and <base>/lib when cross compiling.

I had thought we do that already so this change looks reasonable for me.
Just one thought, do we support multilib toolchains? I think in that case Clang would have to add <base>/include despite different triple.

This patch actually does that already, see the parameter RequireArchMatch which is set to true for the <base>/lib case and false for <base>/include.

Jan 8 2023, 2:38 PM · Restricted Project, Restricted Project
mati865 added a comment to D141206: [clang] [MinGW] Avoid adding <base>/include and <base>/lib when cross compiling.

I had thought we do that already so this change looks reasonable for me.
Just one thought, do we support multilib toolchains? I think in that case Clang would have to add <base>/include despite different triple.

Jan 8 2023, 5:39 AM · Restricted Project, Restricted Project

Nov 25 2022

mati865 accepted D138693: [clang] [MinGW] Improve detection of libstdc++ headers on Fedora.

LGTM

Nov 25 2022, 3:58 PM · Restricted Project, Restricted Project
mati865 accepted D138692: [clang] [MinGW] Improve/extend the gcc/sysroot detection logic.

LGTM

Nov 25 2022, 3:54 PM · Restricted Project, Restricted Project

Oct 27 2022

mati865 accepted D136879: [LLD] [COFF] Include "rust_eh_personality" among the known personality functions.

Thanks, appears to fix unwinding. There are other issues preventing successful compilation but they are seem unrelated.

Oct 27 2022, 5:16 PM · Restricted Project, Restricted Project

Oct 11 2022

mati865 accepted D135651: [LLD] [MinGW] Look for libs named "<libname>.lib" even with -static.

It's unfortunate that MSVC doesn't distinguish static from import libs by extension but we have to adjust.

Oct 11 2022, 11:03 AM · Restricted Project, Restricted Project

Sep 20 2022

mati865 added a comment to D134134: Mark memrchr as unavailable on Windows.

Thank you.

Sep 20 2022, 12:27 PM · Restricted Project, Restricted Project

Sep 19 2022

mati865 added a reviewer for D134134: Mark memrchr as unavailable on Windows: llvm-commits.
Sep 19 2022, 3:09 PM · Restricted Project, Restricted Project

Sep 18 2022

mati865 accepted D134148: [llvm-rc] [test] Fix the windres-preproc test with other mingw triple forms. NFC..

LGTM

Sep 18 2022, 4:02 PM · Restricted Project, Restricted Project
mati865 requested review of D134134: Mark memrchr as unavailable on Windows.
Sep 18 2022, 5:52 AM · Restricted Project, Restricted Project

Aug 25 2022

mati865 accepted D132361: [LLD] [COFF] Fix export directives in object files from -includeoptional.

LGTM

Aug 25 2022, 12:49 AM · Restricted Project, Restricted Project

Aug 22 2022

mati865 added a comment to D132361: [LLD] [COFF] Fix export directives in object files from -includeoptional.

Unfortunately I lack a lot of context here so cannot tell if there are alternative solutions.
How expensive (in terms of performance) is calling updateLinkLoop that many times?

Aug 22 2022, 12:43 PM · Restricted Project, Restricted Project

Aug 19 2022

Herald added a project to D111382: Support _Float128 and F128 literal in C mode: Restricted Project.
Aug 19 2022, 2:51 AM · Restricted Project, Restricted Project

Aug 11 2022

mati865 accepted D131661: [llvm] Use hidden visibility when building for MinGW with Clang.

Thanks, confirmed the built compiler still works (bootstrapped it twice with itself) and with all architectures enabled we are at 35289 exported symbols.

Aug 11 2022, 1:17 PM · Restricted Project, Restricted Project

Aug 10 2022

mati865 added a comment to D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW.

I don't know about LLVM policy for such potentially disruptive change but regardless of what is decided here MSYS2 will almost surely backport this change, otherwise there is no way to provide shared libraries.
On the other hand even if it landed earlier it probably wouldn't have received a lot of testing anyway.

Aug 10 2022, 4:08 PM · Restricted Project, Restricted Project

Aug 9 2022

mati865 accepted D130120: [2/3] [LLD] [COFF] Add support for a new, mingw specific embedded directive -exclude-symbols:.
Aug 9 2022, 11:07 AM · Restricted Project, Restricted Project

Jul 28 2022

mati865 added a comment to D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW.

As the patches to LLD would be landed before, that's probably fine as long as a user doesn't update Clang without updating LLD.

Jul 28 2022, 5:44 AM · Restricted Project, Restricted Project
mati865 accepted D130118: [1/3] [LLD] [MinGW] Implement the --exclude-symbols option.

Sorry, haven't noticed the approval was reset.

Jul 28 2022, 5:18 AM · Restricted Project, Restricted Project

Jul 21 2022

mati865 accepted D130200: [MinGW] Don't currently set visibility=hidden when building for MinGW.

LGTM

Jul 21 2022, 11:38 AM · Restricted Project, Restricted Project

Jul 20 2022

mati865 added a comment to D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW.

I'm a little bit concerned this could break some projects in the wild but for projects that use it properly this sounds like huge win (as your LLVM results show).

Jul 20 2022, 9:29 AM · Restricted Project, Restricted Project
mati865 accepted D130120: [2/3] [LLD] [COFF] Add support for a new, mingw specific embedded directive -exclude-symbols:.

Even though the changes are small I not sure if approval from an outsider (me) should suffice here.

Jul 20 2022, 8:43 AM · Restricted Project, Restricted Project
mati865 added a comment to D130118: [1/3] [LLD] [MinGW] Implement the --exclude-symbols option.

LGTM with minor question.

Jul 20 2022, 8:15 AM · Restricted Project, Restricted Project

Jun 10 2022

mati865 accepted D127478: [LLD] [MinGW] Implement --disable-reloc-section, mapped to /fixed.

lgtm

Jun 10 2022, 10:27 AM · Restricted Project, Restricted Project

May 30 2022

mati865 accepted D126675: [Windows] Don't try to wildcard expand paths starting with \\?\.

Confirmed today it solves the problem.

May 30 2022, 1:39 PM · Restricted Project, Restricted Project

May 18 2022

mati865 accepted D125924: [libcxx] Omit dllimport in public headers in MinGW mode.

Thank you! It will surely make building easier.

May 18 2022, 3:04 PM · Restricted Project, Restricted Project

Mar 2 2022

mati865 accepted D120805: [LLD] [COFF] Order .debug_* sections at the end, to avoid leaving gaps if stripped.

Rebuilt Rust with this patch applied to host LLVM and it still works after stripping binaries and libraries.

Mar 2 2022, 4:11 PM · Restricted Project, Restricted Project

Feb 10 2022

mati865 accepted D119326: [clang] [MinGW] Default to DWARF 4.

LGTM

Feb 10 2022, 12:12 AM · Restricted Project

Jan 27 2022

mati865 added a comment to D118134: [libc++] Fix TOCTOU issue with std::filesystem::remove_all.

Looking at Rust's fix over https://github.com/rust-lang/rust/commit/4f0ad1c92ca08da6e8dc17838070975762f59714 seems like there is API added in Windows 10 to solve it (I don't know how effective though).
I'm not going to work on this myself but leaving the link in case somebody else wants to give it a try.

Jan 27 2022, 3:15 PM · Restricted Project
mati865 requested review of D118405: [LLD][MinGW] Add --heap argument support.
Jan 27 2022, 1:22 PM · lld, Restricted Project

Jan 3 2022

mati865 added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

I will argue that breaking this ABI on Windows is not a big deal since nobody's vending libc++ on Windows. Or at least if they do, they are completely invisible to us ("us" being the people who develop libc++).

Would you be willing to open a patch showing what changes are necessary for each of those? I think we can totally break the ABI on Windows since nobody's shipping it.

I would like to add some nuance to these statements here.

I do ship shared linked libc++ on Windows (as part of the llvm-mingw toolchain distribution), but without any strong ABI guarantees. Ideally ABI wouldn't break between releases, but if it does (especially in a fringe area) it's probably tolerable.

MSYS2 also ships an environment where libc++ is the standard system C++ library, linked shared. That environment is considered somewhat experimental afaik (CC @mati865), so if it breaks some package (which can be fixed by rebuilding), I think they'd consider it tolerable. If none of their packages actually have ended up using and depending on the aspects that may change (I haven't followed closely exactly how widespread it is), the ABI break should be totally transparent though.

Jan 3 2022, 5:22 PM · Restricted Project, Restricted Project

Jan 2 2022

mati865 added a comment to D116358: Make lld to support win-xp.

There was similar differential recently: https://reviews.llvm.org/D112093

Jan 2 2022, 5:16 AM · Restricted Project, lld
mati865 accepted D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker.
Jan 2 2022, 4:59 AM · Restricted Project

Oct 20 2021

mati865 added a comment to D112093: Fixes majorOSVersion and majorSubsystemVersion being set into too large values.

I never had to dig into subsystem versions and what do the mean but looking at subsystem docs 4.0 stands for kernel mode drivers which looks wrong to me. They also specify 5.01 as 32-bit, 5.02 as 64-bit and 6.0 as being either 32-bit or 64-bit.

Oct 20 2021, 10:06 AM · Restricted Project, Restricted Project

Oct 2 2021

mati865 accepted D110975: [libcxx] Don't autodetect pthreads on MinGW.

Agree, we should promote using working and tested configuration.
Even if pthread build works it's probably affected by threading issues when built with GCC.

Oct 2 2021, 2:18 AM · Restricted Project

Aug 4 2021

mati865 accepted D107263: [llvm-rc] Allow specifying language with a leading 0x prefix.

LGTM

Aug 4 2021, 3:47 PM · Restricted Project

Aug 2 2021

mati865 accepted D107261: [clang] [MinGW] Let the last of -mconsole/-mwindows have effect.

LGTM

Aug 2 2021, 4:03 PM · Restricted Project
mati865 accepted D107253: [LLD] [MinGW] Support both "--opt value" and "--opt=value" for more options.

LGTM

Aug 2 2021, 4:01 PM · Restricted Project

Aug 1 2021

mati865 added a comment to D107237: [LLD][MinGW] Accept joined format for --stack.

From a quick look at the options listing, I presume most other cases of S<> and J<…=> should be changed into Eq<> too.

Aug 1 2021, 7:26 AM · Restricted Project, lld
mati865 requested review of D107237: [LLD][MinGW] Accept joined format for --stack.
Aug 1 2021, 4:47 AM · Restricted Project, lld

Jul 23 2021

mati865 updated the diff for D89009: Add version to libLLVM also on non-UNIX.

Building only X86 target did the trick and it looks good:

$ ls bin/ | rg libLLVM.*dll
libLLVM-13git.dll
Jul 23 2021, 9:20 AM · Restricted Project

Jul 21 2021

mati865 added a comment to D89009: Add version to libLLVM also on non-UNIX.

I had no internet during the weekend (massive storms over here) but so I returned to it yesterday.
I'm unable to build clean main branch at the moment:

`
[2972/3064] Linking CXX shared library bin\libLLVM.dll
FAILED: bin/libLLVM.dll lib/libLLVM.dll.a
cmd.exe /C "cd . && D:\msys64\clang64\bin\c++.exe -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,--gc-sections -shared -o bin\libLLVM.dll -Wl,--out-implib,lib\libLLVM.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles\LLVM.rsp  && cd ."
lld-link: error: too many exported symbols (max 65535)
`

It's simple change though, should I update diff without testing?

Jul 21 2021, 4:38 PM · Restricted Project
mati865 accepted D106245: [LLD] [COFF] Make -export-all-symbols work as intended for EXEs.

LGTM sorry for the delay.

Jul 21 2021, 3:43 PM · Restricted Project

Jul 16 2021

mati865 added a comment to D89009: Add version to libLLVM also on non-UNIX.

Yep. I guess the question mainly is if we'd want to make this an upstream thing, adding an if(UNIX) around the symlinks on lines 608-613 here, if windows packaging cases would want to omit them anyway?

I have no idea about guidelines for Windows but it'd make sense for me.

@mati865 - Do you want to update the patch with an if(UNIX) around the symlink lines? I think we've got agreement that we can move forward with this, and it'd be nice to have it in before the 13.x branch in a couple weeks.

Jul 16 2021, 4:44 AM · Restricted Project

Jul 4 2021

mati865 added a comment to D89009: Add version to libLLVM also on non-UNIX.

Yep. I guess the question mainly is if we'd want to make this an upstream thing, adding an if(UNIX) around the symlinks on lines 608-613 here, if windows packaging cases would want to omit them anyway?

Jul 4 2021, 4:23 PM · Restricted Project
mati865 added a comment to D89009: Add version to libLLVM also on non-UNIX.

The import libraries do seem to use the right name as far as I can see, but there's another aspect I remembered now: This does create unversioned symlinks too (not while building but once you do ninja install). This probably is neat to have, but for cases when things are packaged up in e.g. zip files or something else that doesn't handle symlinks, one might want not to have them. Within llvm-mingw I guess I can have them stripped out before packaging though.

Jul 4 2021, 1:23 PM · Restricted Project

Jul 3 2021

mati865 added a comment to D89009: Add version to libLLVM also on non-UNIX.

Thank you for returning to this.
I'd love to get confirmation from @hans who suggested it in https://reviews.llvm.org/D87521 that this still seems like the best approach.

Jul 3 2021, 5:03 PM · Restricted Project

Jun 26 2021

mati865 accepted D104531: [LLD] [MinGW] Allow linking to DLLs directly.

LGTM once D104530 is merged.

Jun 26 2021, 6:46 AM · Restricted Project

Jun 14 2021

mati865 accepted D104214: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj. NFC..

LGTM

Jun 14 2021, 2:53 PM · Restricted Project
mati865 accepted D104215: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC..

LGTM

Jun 14 2021, 2:52 PM · Restricted Project
mati865 accepted D104213: [llvm-dlltool] [test] Test both short and long forms of options. NFC..

LGTM

Jun 14 2021, 2:45 PM · Restricted Project
mati865 accepted D104212: [llvm-dlltool] Imply the target arch from a tool triple prefix.

Feels a bit like approving myself (which is only partially true) but I don't see any issues with the patch itself.

Jun 14 2021, 2:43 PM · Restricted Project

May 28 2021

mati865 added a comment to D102873: [clang] [MinGW] Fix gcc version detection/picking.

Ah, so that explains why everyone sends LGTM text.
I'll try to remember it next time.

May 28 2021, 1:23 AM · Restricted Project

May 27 2021

mati865 accepted D102873: [clang] [MinGW] Fix gcc version detection/picking.
May 27 2021, 4:04 PM · Restricted Project

May 22 2021

mati865 accepted D102970: [clang] [MinGW] Don't mark emutls variables as DSO local.

Wow, I haven't expected that.

May 22 2021, 4:56 PM · Restricted Project

May 21 2021

mati865 accepted D102946: [MinGW] Mark a number of library functions unavailable for mingw targets.
May 21 2021, 5:09 PM · Restricted Project
mati865 accepted D102944: [Windows] Use TerminateProcess to exit without running destructors.

Feels like a heavy hammer to me but guess there is no better option.

May 21 2021, 4:25 PM · Restricted Project
mati865 added a comment to D102684: [LLD] Allow disabling the early exit codepath as a build configuration.

FWIW at MSYS2 we build LLVM with both GNU and LLVM toolchains for different "subsystems".
GNU's LLD was deadlocking a lot so we have patched it to use TerminateProcess and it worked around all deadlocks except when running tests (the patch probably needs more work on it), we don't apply it for LLVM's LLD because I thought it's a bit overkill.

May 21 2021, 10:25 AM · Restricted Project

May 18 2021

mati865 added a comment to D102684: [LLD] Allow disabling the early exit codepath as a build configuration.

Funny but I've hit this deadlock (LLVM_LINK_LLVM_DYLIB, LLD_DEFAULT_LD_LLD_IS_MINGW and shared libc++) last week in single LLD unit test. It never reproduced despite dozen of LLD testsuite runs.

May 18 2021, 9:10 AM · Restricted Project
mati865 added inline comments to D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang.
May 18 2021, 8:54 AM · Restricted Project

May 14 2021

mati865 added a comment to D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang.

When building with ninja, the output is buffered so the warnings appear directly after the specific build target that cause them.

May 14 2021, 4:30 PM · Restricted Project
mati865 added a comment to D102516: [LLD][MinGW] Ignore --no-undefined flag.

But I don't know if ld.bfd actually implements the -z options for PE targets?

May 14 2021, 4:27 PM · Restricted Project, lld
mati865 added inline comments to D102514: [LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags.
May 14 2021, 4:22 PM · Restricted Project, lld
mati865 updated the diff for D102514: [LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags.

Fix typo and the test

May 14 2021, 4:21 PM · Restricted Project, lld
mati865 requested review of D102516: [LLD][MinGW] Ignore --no-undefined flag.
May 14 2021, 10:53 AM · Restricted Project, lld
mati865 requested review of D102514: [LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags.
May 14 2021, 10:49 AM · Restricted Project, lld
mati865 updated the summary of D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang.
May 14 2021, 9:52 AM · Restricted Project
mati865 added a comment to D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang.

I don't know when they exactly appear but look at my building log: https://reviews.llvm.org/P8263
The build was done with 16 threads so it's hard to tell which objects made it appear.

May 14 2021, 9:49 AM · Restricted Project

May 13 2021

mati865 added a comment to D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang.

Sorry I thought it's simple enough on it's own.

May 13 2021, 4:29 PM · Restricted Project
mati865 requested review of D102425: [OpenMP] Use more compatible flags format.
May 13 2021, 10:52 AM · Restricted Project
mati865 requested review of D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang.
May 13 2021, 10:05 AM · Restricted Project

May 11 2021

mati865 added inline comments to D102138: [LLD] [COFF] Fix including the personality function for DWARF EH when linking with --gc-sections.
May 11 2021, 4:32 PM · Restricted Project

Apr 30 2021

mati865 accepted D101615: [LLD] [COFF] Actually include the exported comdat symbols.

The change itself looks correct but cannot speak for the test.

Apr 30 2021, 5:08 PM · Restricted Project

Apr 29 2021

mati865 accepted D101568: [cmake] Use -ffunction-sections and -Wl,--gc-sections on MinGW targets.

If compiling with GCC or linking with ld.bfd, these options have little

effect

Apr 29 2021, 4:37 PM · Restricted Project

Apr 6 2021

mati865 added a comment to D99406: RFC [lit] Detect if processes to execute are MSys based, apply custom quoting logic.

I saw https://github.com/msys2/msys2-runtime/issues/36 but I have never worked with MSYS2 runtime internals so you probably know more than I do at this point.
https://github.com/dscho who maintains Git for Windows might have some insights.

Apr 6 2021, 10:25 AM · Restricted Project

Mar 5 2021

mati865 accepted D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver.
Mar 5 2021, 2:48 PM · Restricted Project
mati865 added a comment to D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver.

It's clear overlook from D79995, that part is perfectly reasonable to me.

Mar 5 2021, 8:58 AM · Restricted Project