Added implementation to support DWARF5 in monolithic mode.
Next step DWARF5 split dwarf support.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
bolt/include/bolt/Core/DebugData.h | ||
---|---|---|
187 | nit | |
214 | The comment is out of sync. | |
217 | Why do you need to redefine getKind()? | |
231 | Is uint32_t enough to support DWARF-64 in the future? | |
285–286 | Update the comment. | |
489 | Could this be constexpr and defined here? | |
490 | Likewise. | |
1096 | nit | |
bolt/lib/Core/BinaryContext.cpp | ||
1535 | nit | |
bolt/lib/Core/DebugData.cpp | ||
168 | nit | |
186 | ||
209 | ||
226 | ||
404 | ||
414 | nit | |
446 | ||
458 | ||
490 | Expand auto. | |
574 | ||
604 | ||
650 | ||
1522–1523 | ||
bolt/lib/Rewrite/DWARFRewriter.cpp | ||
83–87 | ||
493 | No need to introduce the new scope unless you need it. | |
561–562 | ||
1584 |
bolt/include/bolt/Core/DebugData.h | ||
---|---|---|
231 | no, but then rest of the code either. |
bolt/lib/Core/BinaryContext.cpp | ||
---|---|---|
1465 | Add a warning if it's dwar5 and legacy | |
1503–1505 | remove | |
1504 | rename BinaryLineTable | |
bolt/lib/Core/DebugData.cpp | ||
412 | add const to this and AddrSize | |
419 | add type | |
431 | remove curly brases | |
454 | lower case | |
1522 | remove . | |
1555 | const | |
bolt/lib/Rewrite/DWARFRewriter.cpp | ||
375–376 | remove space | |
577 | use braces for rest | |
588 | Unit.getVersion()== 5 | |
603 | const | |
610 | const here and Index | |
660 | rewrite to make sense | |
665 | const | |
960 | use curly | |
971 | use curly | |
972 | llvm_unreachable |
lldb/test/Shell/SymbolFile/DWARF/x86/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s | ||
---|---|---|
17 ↗ | (On Diff #423761) | Was this test just using whatever DWARF %clang_host defaulted to? (since I don't see any changes outside of bolt other than this) |
lldb/test/Shell/SymbolFile/DWARF/x86/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s | ||
---|---|---|
17 ↗ | (On Diff #423761) | Yes. |
Hi,
The test started to fail on Ubuntu buildbot: https://lab.llvm.org/buildbot/#/builders/215/builds/6376
# PRECHECK: include_directories[ 0] = .debug_line_str[0x00000000] ^ <stdin>:8:12: note: scanning from here version: 5 ^ <stdin>:30:1: note: possible intended match here include_directories[ 0] = .debug_line_str[0x00000009] = "."
Can you please take a look?
nit