Added implementation to support DWARF5 in monolithic mode.
Next step DWARF5 split dwarf support.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| bolt/include/bolt/Core/DebugData.h | ||
|---|---|---|
| 187 | nit | |
| 214 | The comment is out of sync. | |
| 217 | Why do you need to redefine getKind()? | |
| 231 | Is uint32_t enough to support DWARF-64 in the future? | |
| 290 | Update the comment. | |
| 492 | Could this be constexpr and defined here? | |
| 493 | Likewise. | |
| 1099 | nit | |
| bolt/lib/Core/BinaryContext.cpp | ||
| 1530 | nit | |
| bolt/lib/Core/DebugData.cpp | ||
| 168 | nit | |
| 186 | ||
| 209 | ||
| 226 | ||
| 404 | ||
| 414 | nit | |
| 446 | ||
| 458 | ||
| 481 | Expand auto. | |
| 577 | ||
| 607 | ||
| 653 | ||
| 1525–1526 | ||
| bolt/lib/Rewrite/DWARFRewriter.cpp | ||
| 83–87 | ||
| 495 | No need to introduce the new scope unless you need it. | |
| 565–566 | ||
| 1588 | ||
| bolt/include/bolt/Core/DebugData.h | ||
|---|---|---|
| 231 | no, but then rest of the code either. | |
| bolt/lib/Core/BinaryContext.cpp | ||
|---|---|---|
| 1460 | Add a warning if it's dwar5 and legacy | |
| 1498–1500 | remove | |
| 1499 | rename BinaryLineTable | |
| bolt/lib/Core/DebugData.cpp | ||
| 412 | add const to this and AddrSize | |
| 419 | add type | |
| 431 | remove curly brases | |
| 454 | lower case | |
| 1525 | remove . | |
| 1559 | const | |
| bolt/lib/Rewrite/DWARFRewriter.cpp | ||
| 377–378 | remove space | |
| 581 | use braces for rest | |
| 592 | Unit.getVersion()== 5 | |
| 607 | const | |
| 614 | const here and Index | |
| 664 | rewrite to make sense | |
| 669 | const | |
| 959 | use curly | |
| 970 | use curly | |
| 971 | llvm_unreachable | |
| lldb/test/Shell/SymbolFile/DWARF/x86/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s | ||
|---|---|---|
| 17 ↗ | (On Diff #423761) | Was this test just using whatever DWARF %clang_host defaulted to? (since I don't see any changes outside of bolt other than this) |
| lldb/test/Shell/SymbolFile/DWARF/x86/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s | ||
|---|---|---|
| 17 ↗ | (On Diff #423761) | Yes. |
Hi,
The test started to fail on Ubuntu buildbot: https://lab.llvm.org/buildbot/#/builders/215/builds/6376
# PRECHECK: include_directories[ 0] = .debug_line_str[0x00000000]
^
<stdin>:8:12: note: scanning from here
version: 5
^
<stdin>:30:1: note: possible intended match here
include_directories[ 0] = .debug_line_str[0x00000009] = "."Can you please take a look?
nit