This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Fix dwarf5-debug-line test
ClosedPublic

Authored by ayermolo on May 31 2022, 4:59 PM.

Details

Summary

After D126484, order in .debug-line-str and .debug-line is different. Changed
test accordingly.

Diff Detail

Event Timeline

ayermolo created this revision.May 31 2022, 4:59 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.May 31 2022, 4:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 4:59 PM

Can the check be done without relying on string offsets?

The test failed in pre-merge checks.

ayermolo updated this revision to Diff 433245.May 31 2022, 5:31 PM

Changed so that it doesn't rely on offset.

maksfb accepted this revision.May 31 2022, 5:57 PM

LGTM

This revision is now accepted and ready to land.May 31 2022, 5:57 PM
This revision was automatically updated to reflect the committed changes.