Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D121779

[RISCV] Add zihintntl compressed instructions
ClosedPublic
Actions

Authored by alextsao1999 on Mar 16 2022, 1:36 AM.

Details

Reviewers
• s
craig.topper
asb
jrtc27
kito-cheng
Commits
rG07a700f814bf: [RISCV] Add zihintntl compressed instructions
Summary

Add zihintntl compressed instructions and some files related to zihintntl.
This patch is base on D121670: [RISCV] Add zihintntl instructions.

Diff Detail

Event Timeline

alextsao1999 created this revision.Mar 16 2022, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 1:36 AM
Herald added subscribers: VincentWu, luke957, vkmr and 28 others. · View Herald Transcript
alextsao1999 requested review of this revision.Mar 16 2022, 1:36 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 16 2022, 1:36 AM
Herald added subscribers: llvm-commits, cfe-commits, • pcwang-thead and 2 others. · View Herald Transcript
alextsao1999 added a parent revision: D121670: [RISCV] Add zihintntl instructions.Mar 16 2022, 1:37 AM
alextsao1999 retitled this revision from [RISCV] Add zihintntl instructions to [RISCV] Add zihintntl compressed instructions.Mar 16 2022, 1:39 AM
alextsao1999 edited the summary of this revision. (Show Details)
alextsao1999 added reviewers: craig.topper, asb, jrtc27.
alextsao1999 updated this revision to Diff 415737.Mar 16 2022, 1:58 AM

Update

Harbormaster completed remote builds in B154542: Diff 415737.Mar 16 2022, 1:59 AM
kito-cheng added inline comments.Aug 21 2022, 7:53 PM
llvm/test/MC/RISCV/rv32zihintntlc-valid.s
42

Could you add an invalid check for c.ntl instruction to make sure they can't use without C?
e.g. -mattr=+experimental-zihintntl but no +c.

Herald added subscribers: sunshaoce, StephenFan, shiva0217. · View Herald TranscriptAug 21 2022, 7:53 PM
alextsao1999 updated this revision to Diff 454433.Aug 22 2022, 3:01 AM

Fix check no c

alextsao1999 marked an inline comment as done.Aug 22 2022, 3:01 AM
alextsao1999 added inline comments.
llvm/test/MC/RISCV/rv32zihintntlc-valid.s
42

Done

Harbormaster completed remote builds in B182541: Diff 454433.Aug 22 2022, 3:45 AM
kito-cheng accepted this revision.Aug 23 2022, 12:02 AM
This revision is now accepted and ready to land.Aug 23 2022, 12:02 AM
This revision was landed with ongoing or failed builds.Aug 23 2022, 11:29 PM
Closed by commit rG07a700f814bf: [RISCV] Add zihintntl compressed instructions (authored by alextsao1999). · Explain Why
This revision was automatically updated to reflect the committed changes.
alextsao1999 marked an inline comment as done.
alextsao1999 added a commit: rG07a700f814bf: [RISCV] Add zihintntl compressed instructions.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
7 lines
test/
MC/
RISCV/
6 lines
13 lines
13 lines
42 lines

Diff 415737

View Options

llvm/lib/Target/RISCV/RISCVInstrInfoC.td

Loading...
View Options

llvm/test/MC/RISCV/attribute-arch.s

Loading...
View Options

llvm/test/MC/RISCV/rv32zihintntl-invalid.s

Loading...
View Options

llvm/test/MC/RISCV/rv32zihintntlc-invalid.s

Loading...
View Options

llvm/test/MC/RISCV/rv32zihintntlc-valid.s

Loading...