accumulated preprocessed size:
before: 1065515095
after: 1065629059
Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanup
| Paths 
 |  Differential  D120195  
Cleanup llvm/DebugInfo/PDB headers ClosedPublic Authored by serge-sans-paille on Feb 19 2022, 3:05 PM. 
Details 
 Summary accumulated preprocessed size: Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanup 
Diff Detail 
 
Unit TestsFailed 
 Event TimelineHerald added projects: Restricted Project, Restricted Project.  ·  View Herald TranscriptFeb 19 2022, 3:05 PM Comment Actions It'd be good to test -DLLVM_ENABLE_MODULES=on build. Some files get pure new headers. I still think it is good thing to do it separately. There is a risk that someone may revert the change if it breaks some build modes. This revision is now accepted and ready to land.Feb 19 2022, 11:11 PM Comment Actions 
 Ooopsie, a typo :-) Comment Actions 
 Sure, I'll add that to my local test setup. 
 That's expected. It happens a lot when some headers gets a forward declaration instead of a header include when referencing a type. 
 I fear I don't have the energy to go at that grain of detail :-/ I'm currently testing with all projects enabled, in release mode. I'll add a setup with ENABLE_MODULE and DEBUG mode to increase the coverage of my pre-commit test This revision was landed with ongoing or failed builds.Feb 23 2022, 1:32 AM Closed by commit rGeb4c8608115c: Cleanup llvm/DebugInfo/PDB headers (authored by serge-sans-paille).  ·  Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions Breaks building on win: http://45.33.8.238/win/53749/step_4.txt Please take a look and revert for now if it takes a while to fix. serge-sans-paille mentioned this in rG57c6012213b5: Add missing <ctime> include.Feb 23 2022, 5:30 AM Comment Actions @thakis should be fixed by 57c6012213b50804ed78530b89bae30c0ee4fe82 , the new failure (seems) unrelated to this change. Comment Actions 
 OK, that should be fine. Thanks for the efforts :) 
Revision Contents 
 
 
Diff 410110 lld/COFF/PDB.cpp
 lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
 lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
 llvm/include/llvm/DebugInfo/MSF/MSFBuilder.h
 llvm/include/llvm/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.h
 llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
 llvm/include/llvm/DebugInfo/PDB/Native/GSIStreamBuilder.h
 llvm/include/llvm/DebugInfo/PDB/Native/InfoStreamBuilder.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumGlobals.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumLineNumbers.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumSymbols.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumTypes.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeExeSymbol.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeFunctionSymbol.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeInlineSiteSymbol.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeLineNumber.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativePublicSymbol.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeSourceFile.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeSymbolEnumerator.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeEnum.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeFunctionSig.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeTypePointer.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeTypedef.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeUDT.h
 llvm/include/llvm/DebugInfo/PDB/Native/NativeTypeVTShape.h
 llvm/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h
 llvm/include/llvm/DebugInfo/PDB/Native/SymbolCache.h
 llvm/include/llvm/DebugInfo/PDB/Native/TpiStreamBuilder.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbol.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolAnnotation.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolBlock.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolCompilandDetails.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolCompilandEnv.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolCustom.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolData.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolFunc.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolFuncDebugEnd.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolFuncDebugStart.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolLabel.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolPublicSymbol.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolThunk.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeArray.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeBaseClass.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeBuiltin.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeCustom.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeDimension.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeEnum.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeFriend.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeFunctionArg.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeManaged.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypePointer.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeTypedef.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeUDT.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeVTable.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolTypeVTableShape.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolUnknown.h
 llvm/include/llvm/DebugInfo/PDB/PDBSymbolUsingNamespace.h
 llvm/include/llvm/DebugInfo/PDB/UDTLayout.h
 llvm/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp
 llvm/lib/DebugInfo/MSF/MappedBlockStream.cpp
 llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp
 llvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp
 llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
 llvm/lib/DebugInfo/PDB/Native/InfoStreamBuilder.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeEnumGlobals.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeEnumLineNumbers.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeEnumModules.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeEnumSymbols.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeEnumTypes.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeExeSymbol.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeInlineSiteSymbol.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeLineNumber.cpp
 llvm/lib/DebugInfo/PDB/Native/NativePublicSymbol.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeRawSymbol.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeSourceFile.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeSymbolEnumerator.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeTypeArray.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeTypeEnum.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeTypeFunctionSig.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeTypePointer.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeTypeUDT.cpp
 llvm/lib/DebugInfo/PDB/Native/NativeTypeVTShape.cpp
 llvm/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp
 llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
 llvm/lib/DebugInfo/PDB/Native/TpiStreamBuilder.cpp
 llvm/lib/DebugInfo/PDB/PDB.cpp
 llvm/lib/DebugInfo/PDB/PDBContext.cpp
 llvm/lib/DebugInfo/PDB/PDBExtras.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbol.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolAnnotation.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolBlock.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolCompiland.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolCompilandDetails.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolCompilandEnv.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolCustom.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolData.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolExe.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolFunc.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolFuncDebugEnd.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolFuncDebugStart.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolLabel.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolPublicSymbol.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolThunk.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeArray.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeBaseClass.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeBuiltin.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeCustom.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeDimension.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeEnum.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeFriend.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeFunctionArg.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeManaged.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypePointer.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeTypedef.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeUDT.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeVTable.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolTypeVTableShape.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolUnknown.cpp
 llvm/lib/DebugInfo/PDB/PDBSymbolUsingNamespace.cpp
 llvm/lib/DebugInfo/PDB/UDTLayout.cpp
 llvm/tools/llvm-pdbutil/LinePrinter.cpp
 llvm/tools/llvm-pdbutil/PrettyClassDefinitionDumper.cpp
 llvm/tools/llvm-pdbutil/PrettyClassLayoutGraphicalDumper.cpp
 llvm/tools/llvm-pdbutil/PrettyEnumDumper.cpp
 llvm/tools/llvm-pdbutil/PrettyExternalSymbolDumper.cpp
 llvm/tools/llvm-pdbutil/PrettyFunctionDumper.cpp
 llvm/tools/llvm-pdbutil/PrettyTypeDumper.cpp
 llvm/tools/llvm-pdbutil/PrettyTypedefDumper.cpp
 llvm/tools/llvm-pdbutil/PrettyVariableDumper.cpp
 llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp
 llvm/unittests/DebugInfo/PDB/NativeSessionTest.cpp
 llvm/unittests/DebugInfo/PDB/NativeSymbolReuseTest.cpp
 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||