[mlir][ods] Optional Attribute or Type Parameters

[Mogball]

Summary

Implements optional attribute or type parameters, including support for such parameters in the assembly format struct directive. Also implements optional groups.

Depends on D117971

[mehdi_amini]

mlir/docs/Tutorials/DefiningAttributesAndTypes.md

1

Seeing this file path again, that reminds me: wasn't it supposed to be converted to a doc like the other instead of being under "tutorial"?

[rriddle]

mlir/docs/Tutorials/DefiningAttributesAndTypes.md

1

Oooh, never pushed that for review. Let me send that out tomorrow.

[rriddle]

mlir/docs/Tutorials/DefiningAttributesAndTypes.md

537

?

mlir/include/mlir/IR/OpBase.td

3133–3136

mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp

257–261

326–330

Avoid floating statements.

372

This seems quadratic, why not cache this computation off somewhere.

409

nit: Why not use ods as prefix instead of _?

588

Is the *_result_{0} here presenting a parse failure?

608–609

743–744

[Mogball]

mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp

588

This condition guards on "no value". E.g. FailureOr<Attribute> = failure() is parse failure but FailureOr<Attribute> = nullptr is no error but no value either.

[Mogball]

review comments

[Mogball]

review comments

[Mogball]

@rriddle ping .-.

[rriddle]

The windows build is failing BTW, might want to look into that.

[Mogball]

fix windows build

[Mogball]

another one