Implements optional attribute or type parameters, including support for such parameters in the assembly format struct directive. Also implements optional groups.
Depends on D117971
Paths
| Differential D118208
[mlir][ods] Optional Attribute or Type Parameters ClosedPublic Authored by Mogball on Jan 25 2022, 6:28 PM.
Details Summary Implements optional attribute or type parameters, including support for such parameters in the assembly format struct directive. Also implements optional groups. Depends on D117971
Diff Detail
Event TimelineMogball added a child revision: D118210: [mlir][ods] Attribute and type formats: support whitespaces.Jan 25 2022, 6:48 PM
This revision is now accepted and ready to land.Feb 7 2022, 11:26 AM Closed by commit rG07486395d2d0: [mlir][ods] Optional Attribute or Type Parameters (authored by Mogball). · Explain WhyFeb 8 2022, 12:09 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 406923 mlir/docs/Tutorials/DefiningAttributesAndTypes.md
mlir/include/mlir/IR/OpBase.td
mlir/include/mlir/TableGen/AttrOrTypeDef.h
mlir/lib/TableGen/AttrOrTypeDef.cpp
mlir/test/lib/Dialect/Test/TestTypeDefs.td
mlir/test/lib/Dialect/Test/TestTypes.h
mlir/test/mlir-tblgen/attr-or-type-format-invalid.td
mlir/test/mlir-tblgen/attr-or-type-format-roundtrip.mlir
mlir/test/mlir-tblgen/attr-or-type-format.td
mlir/test/mlir-tblgen/attrdefs.td
mlir/test/mlir-tblgen/typedefs.td
mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
|
Seeing this file path again, that reminds me: wasn't it supposed to be converted to a doc like the other instead of being under "tutorial"?