Page MenuHomePhabricator
Differential D118548

[mlir][ods] Default-valued/optional parameters have default arguments
AbandonedPublic
Actions

Authored by Mogball on Jan 29 2022, 5:38 PM.

Details

Reviewers
rriddle
mehdi_amini
Summary

Gives attribute and type C++ getters default-valued arguments for
optional ({}) and default-valued parameters.

Depends on D118544

Diff Detail

Event Timeline

Mogball created this revision.Jan 29 2022, 5:38 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 18 others. · View Herald TranscriptJan 29 2022, 5:38 PM
Mogball requested review of this revision.Jan 29 2022, 5:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2022, 5:38 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Mogball edited the summary of this revision. (Show Details)Jan 29 2022, 5:39 PM
Mogball added a parent revision: D118544: [mlir][ods] Default-valued parameters in attribute or type defs.
Harbormaster completed remote builds in B146491: Diff 404316.Jan 29 2022, 5:50 PM
Mogball abandoned this revision.Mar 3 2022, 12:07 PM

this on longer works because of the inclusion of $_ctx in the default value format

Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 12:07 PM

Revision Contents
Changeset List

PathSize
mlir/
test/
mlir-tblgen/
10 lines
tools/
mlir-tblgen/
16 lines

Diff 404316

View Options

mlir/test/mlir-tblgen/attrdefs.td

Loading...
View Options

mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

Loading...