Optional parameters with defaultValue set will be populated with that value if they aren't encountered during parsing. Moreover, parameters equal to their default values are elided when printing.
Depends on D118210
Paths
| Differential D118544
[mlir][ods] Default-valued parameters in attribute or type defs ClosedPublic Authored by Mogball on Jan 29 2022, 3:38 PM.
Details Summary Optional parameters with defaultValue set will be populated with that value if they aren't encountered during parsing. Moreover, parameters equal to their default values are elided when printing. Depends on D118210
Diff Detail
Event Timeline
Mogball marked 6 inline comments as done. Comment Actionsreview comments + new test case for APFloat with comparator
Mogball added inline comments.
This revision is now accepted and ready to land.Feb 14 2022, 10:49 AM This revision was landed with ongoing or failed builds.Feb 15 2022, 11:02 AM Closed by commit rG761bc83af4ee: [mlir][ods] Default-valued parameters in attribute or type defs (authored by Mogball). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 408969 mlir/docs/Tutorials/DefiningAttributesAndTypes.md
mlir/include/mlir/IR/OpBase.td
mlir/include/mlir/TableGen/AttrOrTypeDef.h
mlir/lib/TableGen/AttrOrTypeDef.cpp
mlir/test/lib/Dialect/Test/TestTypeDefs.td
mlir/test/mlir-tblgen/attr-or-type-format-roundtrip.mlir
mlir/test/mlir-tblgen/attr-or-type-format.td
mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
|