Page MenuHomePhabricator

[VPlan] Add VPWidenIntOrFpInductionRecipe::isCanonical, use it.
ClosedPublic

Authored by fhahn on Jan 18 2022, 2:41 AM.

Details

Summary

This patch adds VPWidenIntOrFpInductionRecipe::isCanonical to check if
an induction recipe is canonical. The code is also updated to use it
instead of isCanonicalID.

Diff Detail

Unit TestsFailed

TimeTest
1,080 msx64 debian > Clang.utils/update_cc_test_checks::check-globals.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp
520 msx64 debian > Clang.utils/update_cc_test_checks::global-hex-value-regex.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-hex-value-regex.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-hex-value-regex.test.tmp
520 msx64 debian > Clang.utils/update_cc_test_checks::global-value-regex.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-value-regex.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-value-regex.test.tmp
320 msx64 debian > HWAddressSanitizer-x86_64.TestCases/Linux::decorate-proc-maps.c
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -fsanitize-hwaddress-experimental-aliasing -mllvm -hwasan-generate-tags-with-calls=1 -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions -mllvm -hwasan-globals=0 -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/hwasan/TestCases/Linux/decorate-proc-maps.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Linux/Output/decorate-proc-maps.c.tmp
40,830 msx64 debian > MLIR.Examples/standalone::test.toy
Script: -- : 'RUN: at line 1'; /usr/bin/cmake /var/lib/buildkite-agent/builds/llvm-project/mlir/examples/standalone -G "Ninja" -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/var/lib/buildkite-agent/builds/llvm-project/build/lib/cmake/mlir ; /usr/bin/cmake --build . --target check-standalone | tee /var/lib/buildkite-agent/builds/llvm-project/build/tools/mlir/test/Examples/standalone/Output/test.toy.tmp | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Examples/standalone/test.toy
View Full Test Results (409 Failed)

Event Timeline

fhahn created this revision.Jan 18 2022, 2:41 AM
fhahn requested review of this revision.Jan 18 2022, 2:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 2:41 AM
Herald added a subscriber: vkmr. · View Herald Transcript
Ayal accepted this revision.Jan 18 2022, 8:29 AM

This looks fine, thanks, should be (NFC)?

This revision is now accepted and ready to land.Jan 18 2022, 8:29 AM
This revision was landed with ongoing or failed builds.Jan 21 2022, 1:35 AM
This revision was automatically updated to reflect the committed changes.

If LLVM_ENABLE_ASSERTIONS=OFF then isCanonical is not defined.

See line 1077 of llvm/lib/Transforms/Vectorize/VPlan.cpp:

#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)

Edit: (Thanks Florian for fixing already!)

fhahn added a comment.Jan 21 2022, 2:42 AM

If LLVM_ENABLE_ASSERTIONS=OFF then isCanonical is not defined.

See line 1077 of llvm/lib/Transforms/Vectorize/VPlan.cpp:

#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)

Edit: (Thanks Florian for fixing already!)

Yep thanks for the heads up, should already be fixed by 55689904d2e5