Page MenuHomePhabricator

michaelplatings (Michael Platings)
User

Projects

User does not belong to any projects.

User Details

User Since
May 11 2018, 1:45 AM (71 w, 3 d)

Recent Activity

Thu, Sep 5

michaelplatings committed rL371062: Request commit access for mplatings.
Request commit access for mplatings
Thu, Sep 5, 5:57 AM

Aug 22 2019

michaelplatings accepted D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined..

I can see that this patch doesn't make much sense in isolation. This patch plus D66480 make an alternative to D66301. Hopefully the explanation in D66301 makes it clear that we're merely restoring previous behaviour.

Aug 22 2019, 1:18 AM · Restricted Project, Restricted Project

Aug 21 2019

michaelplatings requested changes to D66518: [libcxx] Only declare contents of threading API when _LIBCPP_HAS_THREAD_API_EXTERNAL is not defined..

It looks like if _LIBCPP_HAS_THREAD_API_PTHREAD is defined then with this change you'll be missing everything between lines 115 and 210.

Aug 21 2019, 6:55 AM · Restricted Project, Restricted Project

Aug 20 2019

michaelplatings added a comment to D66301: [libcxx] __thread_id should be available when an external threading API is used..

Isn't that the intent? It looks like it's just conditionally adding an #include.

Aug 20 2019, 1:52 AM

Jul 11 2019

michaelplatings accepted D64129: [clang-scan-view] Force utf-8 when handling report (python2 only).
Jul 11 2019, 5:21 AM · Restricted Project, Restricted Project

Jul 5 2019

michaelplatings added a comment to D64123: Add clang-llvm-rename tool..

Hi @ruiu,
Can you comment on how this compares to clang-tidy? I had assumed that the readability-identifier-naming clang-tidy rule would largely do the trick.

Jul 5 2019, 1:15 AM · Restricted Project

May 22 2019

michaelplatings resigned from D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`.
May 22 2019, 1:19 AM · Restricted Project, Restricted Project

Apr 25 2019

michaelplatings added a comment to D61119: Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF.

@EricWF this change seems to have broken some a test somehow. I'm well out of my depth here so can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/25356/steps/test/logs/stdio

Apr 25 2019, 4:11 AM · Restricted Project
michaelplatings committed rCXXA359175: Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF.
Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF
Apr 25 2019, 2:29 AM
michaelplatings committed rGd144572dac23: Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF (authored by michaelplatings).
Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF
Apr 25 2019, 2:29 AM
michaelplatings closed D61119: Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF.

https://github.com/llvm/llvm-project/commit/d144572dac23c3af6a1ea5efbdffd8813138e216

Apr 25 2019, 2:29 AM · Restricted Project
michaelplatings committed rL359175: Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF.
Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF
Apr 25 2019, 2:25 AM
michaelplatings updated the summary of D61119: Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF.
Apr 25 2019, 2:03 AM · Restricted Project
michaelplatings created D61119: Fix compilation error with -DLIBCXXABI_ENABLE_THREADS=OFF.
Apr 25 2019, 2:02 AM · Restricted Project

Mar 28 2019

michaelplatings committed rG7aecb64cf6b5: [Documentation] Proposal to change variable names (authored by michaelplatings).
[Documentation] Proposal to change variable names
Mar 28 2019, 7:42 AM
michaelplatings committed rL357174: [Documentation] Proposal to change variable names.
[Documentation] Proposal to change variable names
Mar 28 2019, 7:41 AM
michaelplatings closed D59251: [Documentation] Proposal for plan to change variable names.
Mar 28 2019, 7:41 AM · Restricted Project
michaelplatings added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Mar 28 2019, 7:36 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Mar 28 2019, 7:28 AM · Restricted Project

Mar 19 2019

michaelplatings accepted D59538: Python 2/3 compatibility.

LGTM

Mar 19 2019, 8:28 AM · Restricted Project

Mar 13 2019

michaelplatings added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Mar 13 2019, 7:50 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Mar 13 2019, 7:38 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Mar 13 2019, 7:34 AM · Restricted Project

Mar 12 2019

michaelplatings added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Mar 12 2019, 8:07 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Mar 12 2019, 8:03 AM · Restricted Project
michaelplatings added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Mar 12 2019, 7:32 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Mar 12 2019, 7:32 AM · Restricted Project
michaelplatings created D59251: [Documentation] Proposal for plan to change variable names.
Mar 12 2019, 6:27 AM · Restricted Project

Mar 8 2019

michaelplatings accepted rL355616: Rollback of rL355585..

@hctim thanks for taking the time to point out the problems, sorry I missed them. I've looked again very carefully at all the buildbot output and came across another memory leak at ConstantsTest.cpp:482. Fingers crossed I've caught all the issues this time: rL355685

Mar 8 2019, 2:52 AM
michaelplatings committed rG308e82ecebee: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings).
[IR][ARM] Add function pointer alignment to datalayout
Mar 8 2019, 2:44 AM
michaelplatings committed rL355685: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Mar 8 2019, 2:43 AM
michaelplatings committed rC355685: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Mar 8 2019, 2:43 AM

Mar 7 2019

michaelplatings abandoned D57337: [Targets] Adjust ARM data layout.
Mar 7 2019, 4:12 AM · Restricted Project
michaelplatings committed rGcfd32552513d: Fix & re-enable test that intermittently failed in debug mode. (authored by michaelplatings).
Fix & re-enable test that intermittently failed in debug mode.
Mar 7 2019, 3:56 AM
michaelplatings committed rL355590: Fix & re-enable test that intermittently failed in debug mode..
Fix & re-enable test that intermittently failed in debug mode.
Mar 7 2019, 3:56 AM
michaelplatings committed rGffab84c7df30: Temporarily disable newly added test that fails in debug mode. (authored by michaelplatings).
Temporarily disable newly added test that fails in debug mode.
Mar 7 2019, 2:28 AM
michaelplatings committed rL355588: Temporarily disable newly added test that fails in debug mode..
Temporarily disable newly added test that fails in debug mode.
Mar 7 2019, 2:28 AM
michaelplatings committed rGfd4156ed4d30: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings).
[IR][ARM] Add function pointer alignment to datalayout
Mar 7 2019, 1:15 AM
michaelplatings committed rL355585: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Mar 7 2019, 1:14 AM
michaelplatings committed rC355585: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Mar 7 2019, 1:14 AM

Mar 6 2019

michaelplatings committed rG2391bfca9729: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings).
[IR][ARM] Add function pointer alignment to datalayout
Mar 6 2019, 9:24 AM
michaelplatings committed rC355522: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Mar 6 2019, 9:24 AM
michaelplatings committed rL355522: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Mar 6 2019, 9:24 AM
michaelplatings closed D57335: [IR] Don't assume all functions are 4 byte aligned.
Mar 6 2019, 9:24 AM · Restricted Project, Restricted Project

Feb 26 2019

michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.
Feb 26 2019, 2:15 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.
Feb 26 2019, 2:10 AM · Restricted Project, Restricted Project

Feb 25 2019

michaelplatings added inline comments to D57335: [IR] Don't assume all functions are 4 byte aligned.
Feb 25 2019, 9:34 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.

Hi @efriedma, sorry for the delayed response.
I've added the features you asked for to DataLayout.
It is intended that this patch preserves the existing behaviour if no function pointer alignment is specified.* Therefore I hope you'll agree that it isn't necessary for me to provide code to use the new feature on all platforms.
I did also look into using a target hook but doing so would require modifying a lot of functions to take a TargetTransformInfo argument. Given that we're in agreement that the DataLayout is an appropriate choice, it seemed like the best option.

Feb 25 2019, 8:17 AM · Restricted Project, Restricted Project

Feb 19 2019

michaelplatings added a comment to D57896: Variable names rule.

Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC.

I haven't been following the discussion closely - why is this the preferred direction? I don't think that things like "Basicblock *bb" or "MachineInstr *mi" will be confusing, and going towards a consistently leading lower case letter seems simple and preferable.

Feb 19 2019, 5:19 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57896: Variable names rule.
Feb 19 2019, 4:07 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57896: Variable names rule.

Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC.

Feb 19 2019, 3:25 AM · Restricted Project, Restricted Project

Feb 18 2019

michaelplatings added inline comments to D57896: Variable names rule.
Feb 18 2019, 8:51 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57896: Variable names rule.

Update .clang-tidy files to use aNy_CasE until camelBackOrCase is available.
Add more guidance around acronyms.
Add more guidance around consistency with existing CamelCase variable names.
Change other code examples to camelBack.

Feb 18 2019, 8:45 AM · Restricted Project, Restricted Project

Feb 11 2019

michaelplatings added a comment to D54975: [analyzer] Generalised the SMT state constraints .

@michaelplatings, thanks for the report.

That's weird, did you try to run the tests? You can do it with ninja check-clang-analyzer-z3

Feb 11 2019, 1:46 AM · Restricted Project
michaelplatings added a comment to D57896: Variable names rule.

Should we come up with a new style? say UpperOrLowerCamelCase, I don't mind going and doing that in the readability-identifier-naming check, given that I just wrote up all the Options for that check https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html in D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

Feb 11 2019, 1:30 AM · Restricted Project, Restricted Project

Feb 8 2019

michaelplatings added inline comments to D54975: [analyzer] Generalised the SMT state constraints .
Feb 8 2019, 7:00 AM · Restricted Project
michaelplatings added a comment to D57896: Variable names rule.
  1. Does clang-tidy warn on every single existing variable now?
  2. It might be best to give this more visibility, by submitting a mail to llvm-dev, with a noticeable subject, like "RFC: changing variable naming rules in LLVM codebase"
Feb 8 2019, 2:05 AM · Restricted Project, Restricted Project

Feb 7 2019

michaelplatings added a comment to D57896: Variable names rule.

Pretty sure this patch should have gone to llvm-commits, not cfe-commits.

Feb 7 2019, 9:22 AM · Restricted Project, Restricted Project
michaelplatings updated subscribers of D57896: Variable names rule.
Feb 7 2019, 9:21 AM · Restricted Project, Restricted Project
michaelplatings created D57896: Variable names rule.
Feb 7 2019, 7:51 AM · Restricted Project, Restricted Project

Feb 5 2019

michaelplatings accepted D57744: Python3 support: print-statement.
Feb 5 2019, 5:10 AM · Restricted Project
michaelplatings added inline comments to D57744: Python3 support: print-statement.
Feb 5 2019, 4:15 AM · Restricted Project

Jan 28 2019

michaelplatings updated the diff for D57337: [Targets] Adjust ARM data layout.

Diff with -U99999

Jan 28 2019, 9:31 AM · Restricted Project
michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.

Diff with -U99999

Jan 28 2019, 9:30 AM · Restricted Project, Restricted Project
michaelplatings changed the repository for D57337: [Targets] Adjust ARM data layout from rL LLVM to rC Clang.
Jan 28 2019, 9:16 AM · Restricted Project
michaelplatings added a parent revision for D57337: [Targets] Adjust ARM data layout: D57335: [IR] Don't assume all functions are 4 byte aligned.
Jan 28 2019, 9:14 AM · Restricted Project
michaelplatings created D57337: [Targets] Adjust ARM data layout.
Jan 28 2019, 9:14 AM · Restricted Project
michaelplatings created D57335: [IR] Don't assume all functions are 4 byte aligned.
Jan 28 2019, 9:12 AM · Restricted Project, Restricted Project

Jan 24 2019

michaelplatings committed rL352052: [Docs] Add information about unit tests to the testing guide.
[Docs] Add information about unit tests to the testing guide
Jan 24 2019, 7:12 AM
michaelplatings closed D57088: Add information about unit tests to the testing guide.
Jan 24 2019, 7:11 AM
michaelplatings added a reviewer for D57088: Add information about unit tests to the testing guide: carwil.
Jan 24 2019, 3:26 AM

Jan 23 2019

michaelplatings updated the diff for D57088: Add information about unit tests to the testing guide.

Addressed @carwil's comments

Jan 23 2019, 3:53 AM
michaelplatings created D57088: Add information about unit tests to the testing guide.
Jan 23 2019, 1:32 AM

Jan 18 2019

michaelplatings added inline comments to D56819: Document toolchain update policy.
Jan 18 2019, 1:34 AM

Jan 3 2019

michaelplatings accepted D56250: python compat - iterator protocol.

LGTM

Jan 3 2019, 7:44 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 7:24 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 7:00 AM
michaelplatings accepted D56258: python compat - encode/decode.

LGTM

Jan 3 2019, 6:29 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 6:29 AM
michaelplatings accepted D56249: python compat - print statement.

LGTM

Jan 3 2019, 6:04 AM
michaelplatings accepted D56251: python compat - assertraisesregex.

LGTM

Jan 3 2019, 6:01 AM
michaelplatings added inline comments to D56251: python compat - assertraisesregex.
Jan 3 2019, 5:52 AM
michaelplatings requested changes to D56249: python compat - print statement.
Jan 3 2019, 5:23 AM
michaelplatings accepted D56253: Python compat - range.

LGTM

Jan 3 2019, 5:15 AM
michaelplatings accepted D56252: python compat - no explicit reference to python version.

LGTM

Jan 3 2019, 5:14 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 5:12 AM
michaelplatings requested changes to D56251: python compat - assertraisesregex.
Jan 3 2019, 5:06 AM
michaelplatings accepted D56254: remove unused python import.

LGTM

Jan 3 2019, 4:59 AM
michaelplatings accepted D56256: Python compat - exception.

LGTM

Jan 3 2019, 4:59 AM
michaelplatings accepted D56257: Python compat - iteritems.

LGTM

Jan 3 2019, 4:58 AM
michaelplatings requested changes to D56258: python compat - encode/decode.
Jan 3 2019, 4:57 AM
michaelplatings accepted D55196: Python2/3 compatibility - StringIO.

LGTM

Jan 3 2019, 4:56 AM
michaelplatings accepted D56259: python compat - map/filter.

LGTM

Jan 3 2019, 4:53 AM
michaelplatings accepted D56260: python compat - has_key.

LGTM

Jan 3 2019, 4:50 AM
michaelplatings accepted D56261: Python compat - urllib.

LGTM

Jan 3 2019, 4:49 AM
michaelplatings accepted D56262: Python compat - isinstance(x, long).

LGTM

Jan 3 2019, 4:48 AM
michaelplatings accepted D55989: Modernize Python script.

LGTM

Jan 3 2019, 4:42 AM

Jan 2 2019

michaelplatings requested changes to D55196: Python2/3 compatibility - StringIO.
Jan 2 2019, 9:50 AM
michaelplatings accepted D55829: LLVM Test suite Python 2/3 compatibility.

LGTM

Jan 2 2019, 9:26 AM
michaelplatings requested changes to D55989: Modernize Python script.
Jan 2 2019, 9:25 AM