User Details
- User Since
- May 11 2018, 1:45 AM (36 w, 3 d)
Fri, Jan 18
Thu, Jan 3
LGTM
Wed, Jan 2
Dec 19 2018
Dec 18 2018
From looking briefly it seems that these are sensible changes, but many of them aren't necessary for Python 3 compatility. I suggest separating the Python 3 compatibility changes and other cleanups into different patches.
Dec 13 2018
Dec 12 2018
Dec 3 2018
LGTM
Can you comment on whether the differences between StringIO and io.StringIO might be significant? https://stackoverflow.com/a/49795277
Nov 30 2018
In general LGTM, as someone who's done a 2-3 conversion of similar scale before.
Nov 29 2018
Out of interest, how are you disabling tools?
"LLVM_EXPORT" seems like an overly generic name. Maybe a variation on "LLVM_LIBRARY_VISIBILITY" would be more fitting?
Nov 28 2018
Nov 27 2018
@marsupial if you can show me an instance where this patch significantly changes the build's behaviour then I can change the patch to mitigate that.
Nov 26 2018
(moved closing parenthesis to new line)
Nov 23 2018
@marsupial that's odd. I'm using ninja also and libDynamicLibraryLib.a ends up in lib for me. Reproducer:
svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm mkdir build && cd build cmake -G Ninja ../llvm ninja DynamicLibraryLib ls lib/libDynamicLibraryLib.a
Nov 22 2018
@marsupial ping?
Nov 20 2018
Thanks for the review Frederich.
Nov 19 2018
Thanks very much Reid for the speedy review. Unfortunately, due the the use of absolute paths, this patch causes long command lines to be generated which Visual Studio 2015 can't handle. So I have to abandon this patch.