Page MenuHomePhabricator

michaelplatings (Michael Platings)
User

Projects

User does not belong to any projects.

User Details

User Since
May 11 2018, 1:45 AM (44 w, 3 d)

Recent Activity

Wed, Mar 13

michaelplatings added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Wed, Mar 13, 7:50 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Wed, Mar 13, 7:38 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Wed, Mar 13, 7:34 AM · Restricted Project

Tue, Mar 12

michaelplatings added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Tue, Mar 12, 8:07 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Tue, Mar 12, 8:03 AM · Restricted Project
michaelplatings added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Tue, Mar 12, 7:32 AM · Restricted Project
michaelplatings updated the diff for D59251: [Documentation] Proposal for plan to change variable names.
Tue, Mar 12, 7:32 AM · Restricted Project
michaelplatings created D59251: [Documentation] Proposal for plan to change variable names.
Tue, Mar 12, 6:27 AM · Restricted Project

Fri, Mar 8

michaelplatings accepted rL355616: Rollback of rL355585..

@hctim thanks for taking the time to point out the problems, sorry I missed them. I've looked again very carefully at all the buildbot output and came across another memory leak at ConstantsTest.cpp:482. Fingers crossed I've caught all the issues this time: rL355685

Fri, Mar 8, 2:52 AM
michaelplatings committed rG308e82ecebee: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings).
[IR][ARM] Add function pointer alignment to datalayout
Fri, Mar 8, 2:44 AM
michaelplatings committed rL355685: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Fri, Mar 8, 2:43 AM
michaelplatings committed rC355685: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Fri, Mar 8, 2:43 AM

Thu, Mar 7

michaelplatings abandoned D57337: [Targets] Adjust ARM data layout.
Thu, Mar 7, 4:12 AM · Restricted Project
michaelplatings committed rGcfd32552513d: Fix & re-enable test that intermittently failed in debug mode. (authored by michaelplatings).
Fix & re-enable test that intermittently failed in debug mode.
Thu, Mar 7, 3:56 AM
michaelplatings committed rL355590: Fix & re-enable test that intermittently failed in debug mode..
Fix & re-enable test that intermittently failed in debug mode.
Thu, Mar 7, 3:56 AM
michaelplatings committed rGffab84c7df30: Temporarily disable newly added test that fails in debug mode. (authored by michaelplatings).
Temporarily disable newly added test that fails in debug mode.
Thu, Mar 7, 2:28 AM
michaelplatings committed rL355588: Temporarily disable newly added test that fails in debug mode..
Temporarily disable newly added test that fails in debug mode.
Thu, Mar 7, 2:28 AM
michaelplatings committed rGfd4156ed4d30: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings).
[IR][ARM] Add function pointer alignment to datalayout
Thu, Mar 7, 1:15 AM
michaelplatings committed rL355585: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Thu, Mar 7, 1:14 AM
michaelplatings committed rC355585: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Thu, Mar 7, 1:14 AM

Wed, Mar 6

michaelplatings committed rG2391bfca9729: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings).
[IR][ARM] Add function pointer alignment to datalayout
Wed, Mar 6, 9:24 AM
michaelplatings committed rC355522: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Wed, Mar 6, 9:24 AM
michaelplatings committed rL355522: [IR][ARM] Add function pointer alignment to datalayout.
[IR][ARM] Add function pointer alignment to datalayout
Wed, Mar 6, 9:24 AM
michaelplatings closed D57335: [IR] Don't assume all functions are 4 byte aligned.
Wed, Mar 6, 9:24 AM · Restricted Project, Restricted Project

Tue, Feb 26

michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.
Tue, Feb 26, 2:15 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.
Tue, Feb 26, 2:10 AM · Restricted Project, Restricted Project

Mon, Feb 25

michaelplatings added inline comments to D57335: [IR] Don't assume all functions are 4 byte aligned.
Mon, Feb 25, 9:34 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.

Hi @efriedma, sorry for the delayed response.
I've added the features you asked for to DataLayout.
It is intended that this patch preserves the existing behaviour if no function pointer alignment is specified.* Therefore I hope you'll agree that it isn't necessary for me to provide code to use the new feature on all platforms.
I did also look into using a target hook but doing so would require modifying a lot of functions to take a TargetTransformInfo argument. Given that we're in agreement that the DataLayout is an appropriate choice, it seemed like the best option.

Mon, Feb 25, 8:17 AM · Restricted Project, Restricted Project

Tue, Feb 19

michaelplatings added a comment to D57896: Variable names rule.

Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC.

I haven't been following the discussion closely - why is this the preferred direction? I don't think that things like "Basicblock *bb" or "MachineInstr *mi" will be confusing, and going towards a consistently leading lower case letter seems simple and preferable.

Tue, Feb 19, 5:19 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57896: Variable names rule.
Tue, Feb 19, 4:07 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57896: Variable names rule.

Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC.

Tue, Feb 19, 3:25 AM · Restricted Project, Restricted Project

Mon, Feb 18

michaelplatings added inline comments to D57896: Variable names rule.
Mon, Feb 18, 8:51 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D57896: Variable names rule.

Update .clang-tidy files to use aNy_CasE until camelBackOrCase is available.
Add more guidance around acronyms.
Add more guidance around consistency with existing CamelCase variable names.
Change other code examples to camelBack.

Mon, Feb 18, 8:45 AM · Restricted Project, Restricted Project

Feb 11 2019

michaelplatings added a comment to D54975: [analyzer] Generalised the SMT state constraints .

@michaelplatings, thanks for the report.

That's weird, did you try to run the tests? You can do it with ninja check-clang-analyzer-z3

Feb 11 2019, 1:46 AM · Restricted Project
michaelplatings added a comment to D57896: Variable names rule.

Should we come up with a new style? say UpperOrLowerCamelCase, I don't mind going and doing that in the readability-identifier-naming check, given that I just wrote up all the Options for that check https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html in D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

Feb 11 2019, 1:30 AM · Restricted Project, Restricted Project

Feb 8 2019

michaelplatings added inline comments to D54975: [analyzer] Generalised the SMT state constraints .
Feb 8 2019, 7:00 AM · Restricted Project
michaelplatings added a comment to D57896: Variable names rule.
  1. Does clang-tidy warn on every single existing variable now?
  2. It might be best to give this more visibility, by submitting a mail to llvm-dev, with a noticeable subject, like "RFC: changing variable naming rules in LLVM codebase"
Feb 8 2019, 2:05 AM · Restricted Project, Restricted Project

Feb 7 2019

michaelplatings added a comment to D57896: Variable names rule.

Pretty sure this patch should have gone to llvm-commits, not cfe-commits.

Feb 7 2019, 9:22 AM · Restricted Project, Restricted Project
michaelplatings updated subscribers of D57896: Variable names rule.
Feb 7 2019, 9:21 AM · Restricted Project, Restricted Project
michaelplatings created D57896: Variable names rule.
Feb 7 2019, 7:51 AM · Restricted Project, Restricted Project

Feb 5 2019

michaelplatings accepted D57744: Python3 support: print-statement.
Feb 5 2019, 5:10 AM · Restricted Project
michaelplatings added inline comments to D57744: Python3 support: print-statement.
Feb 5 2019, 4:15 AM · Restricted Project

Jan 28 2019

michaelplatings updated the diff for D57337: [Targets] Adjust ARM data layout.

Diff with -U99999

Jan 28 2019, 9:31 AM · Restricted Project
michaelplatings updated the diff for D57335: [IR] Don't assume all functions are 4 byte aligned.

Diff with -U99999

Jan 28 2019, 9:30 AM · Restricted Project, Restricted Project
michaelplatings changed the repository for D57337: [Targets] Adjust ARM data layout from rL LLVM to rC Clang.
Jan 28 2019, 9:16 AM · Restricted Project
michaelplatings added a parent revision for D57337: [Targets] Adjust ARM data layout: D57335: [IR] Don't assume all functions are 4 byte aligned.
Jan 28 2019, 9:14 AM · Restricted Project
michaelplatings created D57337: [Targets] Adjust ARM data layout.
Jan 28 2019, 9:14 AM · Restricted Project
michaelplatings created D57335: [IR] Don't assume all functions are 4 byte aligned.
Jan 28 2019, 9:12 AM · Restricted Project, Restricted Project

Jan 24 2019

michaelplatings committed rL352052: [Docs] Add information about unit tests to the testing guide.
[Docs] Add information about unit tests to the testing guide
Jan 24 2019, 7:12 AM
michaelplatings closed D57088: Add information about unit tests to the testing guide.
Jan 24 2019, 7:11 AM
michaelplatings added a reviewer for D57088: Add information about unit tests to the testing guide: carwil.
Jan 24 2019, 3:26 AM

Jan 23 2019

michaelplatings updated the diff for D57088: Add information about unit tests to the testing guide.

Addressed @carwil's comments

Jan 23 2019, 3:53 AM
michaelplatings created D57088: Add information about unit tests to the testing guide.
Jan 23 2019, 1:32 AM

Jan 18 2019

michaelplatings added inline comments to D56819: Document toolchain update policy.
Jan 18 2019, 1:34 AM

Jan 3 2019

michaelplatings accepted D56250: python compat - iterator protocol.

LGTM

Jan 3 2019, 7:44 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 7:24 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 7:00 AM
michaelplatings accepted D56258: python compat - encode/decode.

LGTM

Jan 3 2019, 6:29 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 6:29 AM
michaelplatings accepted D56249: python compat - print statement.

LGTM

Jan 3 2019, 6:04 AM
michaelplatings accepted D56251: python compat - assertraisesregex.

LGTM

Jan 3 2019, 6:01 AM
michaelplatings added inline comments to D56251: python compat - assertraisesregex.
Jan 3 2019, 5:52 AM
michaelplatings requested changes to D56249: python compat - print statement.
Jan 3 2019, 5:23 AM
michaelplatings accepted D56253: Python compat - range.

LGTM

Jan 3 2019, 5:15 AM
michaelplatings accepted D56252: python compat - no explicit reference to python version.

LGTM

Jan 3 2019, 5:14 AM
michaelplatings requested changes to D56250: python compat - iterator protocol.
Jan 3 2019, 5:12 AM
michaelplatings requested changes to D56251: python compat - assertraisesregex.
Jan 3 2019, 5:06 AM
michaelplatings accepted D56254: remove unused python import.

LGTM

Jan 3 2019, 4:59 AM
michaelplatings accepted D56256: Python compat - exception.

LGTM

Jan 3 2019, 4:59 AM
michaelplatings accepted D56257: Python compat - iteritems.

LGTM

Jan 3 2019, 4:58 AM
michaelplatings requested changes to D56258: python compat - encode/decode.
Jan 3 2019, 4:57 AM
michaelplatings accepted D55196: Python2/3 compatibility - StringIO.

LGTM

Jan 3 2019, 4:56 AM
michaelplatings accepted D56259: python compat - map/filter.

LGTM

Jan 3 2019, 4:53 AM
michaelplatings accepted D56260: python compat - has_key.

LGTM

Jan 3 2019, 4:50 AM
michaelplatings accepted D56261: Python compat - urllib.

LGTM

Jan 3 2019, 4:49 AM
michaelplatings accepted D56262: Python compat - isinstance(x, long).

LGTM

Jan 3 2019, 4:48 AM
michaelplatings accepted D55989: Modernize Python script.

LGTM

Jan 3 2019, 4:42 AM

Jan 2 2019

michaelplatings requested changes to D55196: Python2/3 compatibility - StringIO.
Jan 2 2019, 9:50 AM
michaelplatings accepted D55829: LLVM Test suite Python 2/3 compatibility.

LGTM

Jan 2 2019, 9:26 AM
michaelplatings requested changes to D55989: Modernize Python script.
Jan 2 2019, 9:25 AM

Dec 19 2018

michaelplatings accepted D55199: Python2/3 compat - urllib.

LGTM

Dec 19 2018, 1:20 AM

Dec 18 2018

michaelplatings requested changes to D55196: Python2/3 compatibility - StringIO.
Dec 18 2018, 9:32 AM
michaelplatings requested changes to D55829: LLVM Test suite Python 2/3 compatibility.

From looking briefly it seems that these are sensible changes, but many of them aren't necessary for Python 3 compatility. I suggest separating the Python 3 compatibility changes and other cleanups into different patches.

Dec 18 2018, 9:31 AM
michaelplatings requested changes to D55199: Python2/3 compat - urllib.
Dec 18 2018, 9:28 AM
michaelplatings accepted D55197: Python 2/3 compatibility - iterable.

LGTM

Dec 18 2018, 2:22 AM
michaelplatings accepted D55208: Python 2/3 compat - import __future__.

LGTM

Dec 18 2018, 2:12 AM
michaelplatings added inline comments to D55199: Python2/3 compat - urllib.
Dec 18 2018, 2:12 AM
michaelplatings accepted D55205: Python 2/3 compat - commands.

LGTM

Dec 18 2018, 2:04 AM

Dec 13 2018

michaelplatings added inline comments to D55196: Python2/3 compatibility - StringIO.
Dec 13 2018, 2:42 AM
michaelplatings accepted D55200: Python 2/3 compat - config parser.

LGTM

Dec 13 2018, 2:36 AM
michaelplatings accepted D55193: Python2/3 compatibility - ranges.

LGTM

Dec 13 2018, 2:35 AM
michaelplatings added inline comments to D55197: Python 2/3 compatibility - iterable.
Dec 13 2018, 2:33 AM
michaelplatings accepted D55213: Python2/3 compat - print.

LGTM

Dec 13 2018, 2:24 AM
michaelplatings accepted D55194: Python2/3 compatiility - has_key.

LGTM

Dec 13 2018, 2:13 AM
michaelplatings added inline comments to D55199: Python2/3 compat - urllib.
Dec 13 2018, 2:13 AM
michaelplatings accepted D55204: Python 2/3 compat - div.

LGTM

Dec 13 2018, 2:04 AM
michaelplatings added inline comments to D55205: Python 2/3 compat - commands.
Dec 13 2018, 2:02 AM

Dec 12 2018

michaelplatings added inline comments to D55200: Python 2/3 compat - config parser.
Dec 12 2018, 9:38 AM
michaelplatings accepted D55259: Python 2/3 compat - threading.

LGTM

Dec 12 2018, 9:38 AM
michaelplatings accepted D55202: Python 2/3 compat - Queue.

LGTM

Dec 12 2018, 9:33 AM