Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

michaelplatings (Michael Platings)
User

Projects

User does not belong to any projects.

User Details

User Since
May 11 2018, 1:45 AM (281 w, 1 d)

Recent Activity

Yesterday

michaelplatings updated the diff for D155521: Run picolibc tests with qemu.

Rebase

Fri, Sep 29, 6:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Fri, Sep 29, 4:22 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Make changes requested by @ldionne and rebase.

Fri, Sep 29, 4:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Sep 28

michaelplatings added a comment to D155521: Run picolibc tests with qemu.

Ping

Thu, Sep 28, 11:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added a comment to D154246: [libc++] Add check for building with picolibc.

Ping

Thu, Sep 28, 11:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Sep 20

michaelplatings added a comment to D154246: [libc++] Add check for building with picolibc.

Is this ready for review?

Wed, Sep 20, 1:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Sep 19

michaelplatings updated the diff for D155521: Run picolibc tests with qemu.

Rebase

Tue, Sep 19, 3:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Rebase

Tue, Sep 19, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Sep 11

michaelplatings resigned from D144638: [lit] Detect Inconsistent File Access Times.
Mon, Sep 11, 8:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 16 2023

michaelplatings abandoned D57896: Variable names rule.
Aug 16 2023, 5:45 AM · Restricted Project, Restricted Project, Restricted Project
michaelplatings resigned from D70591: [ARM] Allow Usage of R4-R5 as Global Register Variables for ARM.
Aug 16 2023, 5:40 AM · Restricted Project, Restricted Project, Restricted Project

Aug 11 2023

michaelplatings committed rGd13f1cb569ca: [libc++][test] Fix max_size test for Arm big endian (authored by michaelplatings).
[libc++][test] Fix max_size test for Arm big endian
Aug 11 2023, 8:25 AM · Restricted Project, Restricted Project
michaelplatings closed D157699: [libc++][test] Fix max_size test for Arm big endian.
Aug 11 2023, 8:25 AM · Restricted Project, Restricted Project
michaelplatings retitled D157699: [libc++][test] Fix max_size test for Arm big endian from [libc++][test] Fix max_size for Arm big endian to [libc++][test] Fix max_size test for Arm big endian.
Aug 11 2023, 3:15 AM · Restricted Project, Restricted Project
michaelplatings retitled D157699: [libc++][test] Fix max_size test for Arm big endian from [libc++][test] Fix max_test for Arm big endian to [libc++][test] Fix max_size for Arm big endian.
Aug 11 2023, 3:13 AM · Restricted Project, Restricted Project
michaelplatings requested review of D157699: [libc++][test] Fix max_size test for Arm big endian.
Aug 11 2023, 3:11 AM · Restricted Project, Restricted Project

Aug 9 2023

michaelplatings committed rG872d22c735b8: [NFC][Clang][Test] Fix warning-as-error (authored by michaelplatings).
[NFC][Clang][Test] Fix warning-as-error
Aug 9 2023, 1:31 PM · Restricted Project, Restricted Project

Aug 3 2023

michaelplatings committed rGab5ebe4b2088: [NFC][Clang][Test] Fix warning-as-error (authored by michaelplatings).
[NFC][Clang][Test] Fix warning-as-error
Aug 3 2023, 12:31 AM · Restricted Project, Restricted Project

Aug 2 2023

michaelplatings added a comment to D57896: Variable names rule.

Hi Sam, I won't be able to take this forward but you have my encouragement. To facilitate this change I got as far as changing Git [1], and GitHub has been updated accordingly [2], but I ran out of steam before getting to the change itself.
I'd be happy to let someone else (you?) take the lead and commandeer the change.

Aug 2 2023, 7:16 AM · Restricted Project, Restricted Project, Restricted Project
michaelplatings resigned from D138849: MC/DC in LLVM Source-Based Code Coverage: clang.
Aug 2 2023, 12:05 AM · Restricted Project

Jul 27 2023

michaelplatings accepted D156427: [clang] Improve hermeticity of clang header tests..

LGTM

Jul 27 2023, 11:50 PM · Restricted Project, Restricted Project

Jul 24 2023

michaelplatings abandoned D154708: Fix buffer overflow.
Jul 24 2023, 10:49 PM · Restricted Project, Restricted Project
michaelplatings added inline comments to D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options.
Jul 24 2023, 8:42 AM · Restricted Project, Restricted Project
michaelplatings added a comment to D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain.

some nasty and repetitive regexes

Jul 24 2023, 3:05 AM · Restricted Project, Restricted Project
michaelplatings added a comment to D155776: [NFC] Add checks for self-assignment..
Jul 24 2023, 1:37 AM · Restricted Project, Restricted Project
michaelplatings added a reverting change for rG8ac137acefc0: [NFC] Add checks for self-assignment.: rGfa39c0a58e87: Revert "[NFC] Add checks for self-assignment.".
Jul 24 2023, 1:37 AM · Restricted Project, Restricted Project
michaelplatings committed rGfa39c0a58e87: Revert "[NFC] Add checks for self-assignment." (authored by michaelplatings).
Revert "[NFC] Add checks for self-assignment."
Jul 24 2023, 1:37 AM · Restricted Project, Restricted Project
michaelplatings added a reverting change for D155776: [NFC] Add checks for self-assignment.: rGfa39c0a58e87: Revert "[NFC] Add checks for self-assignment.".
Jul 24 2023, 1:36 AM · Restricted Project, Restricted Project

Jul 20 2023

michaelplatings added inline comments to D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options.
Jul 20 2023, 5:35 AM · Restricted Project, Restricted Project

Jul 19 2023

michaelplatings added a comment to D155521: Run picolibc tests with qemu.

OK if I get any more review comments I'll do that. The new "Armv7-M picolibc" configuration is passing in BuildKite now and the failures in other configurations look unrelated so I have no changes planned at this point.

Jul 19 2023, 9:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D155521: Run picolibc tests with qemu.

Rebase after -Wcast-qual error was fixed

Jul 19 2023, 2:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Rebase after -Wcast-qual error was fixed

Jul 19 2023, 2:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings accepted D155685: [libunwind] Fix build error on 32 bit Arm after -Wcast-qual was added.

LGTM and fixes the issue for me. I agree there doesn't seem to be a good reason to have the const there in the first place.

Jul 19 2023, 4:43 AM · Restricted Project, Restricted Project, Restricted Project
michaelplatings added inline comments to D155521: Run picolibc tests with qemu.
Jul 19 2023, 4:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D155521: Run picolibc tests with qemu.

Handle command line arguments

Jul 19 2023, 4:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

atomics -> has-64-bit-atomics

Jul 19 2023, 2:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 18 2023

michaelplatings accepted D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm..

LGTM but please allow a day for others to comment.

Jul 18 2023, 8:11 AM · Restricted Project, Restricted Project
michaelplatings added a comment to D155521: Run picolibc tests with qemu.

QEMU has been installed.

buildkite-linaro-aarch64-libcxx-02:/# qemu-system-arm --version
QEMU emulator version 4.2.1 (Debian 1:4.2-3ubuntu6.27)
Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers

And it's on PATH, no /usr/local... stuff needed this time.

Jul 18 2023, 6:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D155521: Run picolibc tests with qemu.

Use 16MB area of RAM to enable running bigger tests

Jul 18 2023, 5:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Use 16MB area of RAM to enable running bigger tests

Jul 18 2023, 5:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added a comment to D155521: Run picolibc tests with qemu.

Surprised to not see bootcode here, but it is qemu and one can get away without it a lot of the time. Is that the case?

I will add qemu-system-arm to our containers. Focal's apt version is 4.2.1 and I checked it has the board and cpu options needed, so I expect it'll work fine.

Jul 18 2023, 3:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D155521: Run picolibc tests with qemu.

Move code to find qemu-system-arm program

Jul 18 2023, 3:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Change how atomics feature is detected and change atomic REQUIRES back to negated XFAIL

Jul 18 2023, 3:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 18 2023, 2:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added inline comments to D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm..
Jul 18 2023, 2:17 AM · Restricted Project, Restricted Project

Jul 17 2023

michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 17 2023, 11:56 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

XFAIL: !atomics -> REQUIRES: atomics

Jul 17 2023, 11:56 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings requested review of D155521: Run picolibc tests with qemu.
Jul 17 2023, 3:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 17 2023, 3:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Add "atomics" feature, run git-clang-format, and other minor tweaks

Jul 17 2023, 3:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added a comment to D154708: Fix buffer overflow.

@lhames ping

Jul 17 2023, 2:03 PM · Restricted Project, Restricted Project

Jul 14 2023

michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 14 2023, 3:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated subscribers of D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain.
Jul 14 2023, 2:47 PM · Restricted Project, Restricted Project
michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 14 2023, 2:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added a comment to D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain.

Hi Joe, it's nice to see multilib.yaml getting some adoption :)

Jul 14 2023, 2:15 PM · Restricted Project, Restricted Project
michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 14 2023, 10:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Compile and link tests

Jul 14 2023, 10:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 13 2023

michaelplatings added inline comments to D155201: [Clang][AArch64] Introduce CLANG_AARCH64_DEFAULT_CPU.
Jul 13 2023, 9:05 AM · Restricted Project

Jul 12 2023

michaelplatings added inline comments to D154665: [Object] fixed invalid symbol handling in ELFObjectFile::getSymbolName.
Jul 12 2023, 3:23 AM · Restricted Project, Restricted Project

Jul 11 2023

michaelplatings abandoned D153327: [libc++] Enable <fstream> without <filesystem>.
Jul 11 2023, 1:03 AM · Restricted Project, Restricted Project

Jul 10 2023

michaelplatings accepted D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain.

Hi @MaskRay, thanks for the add. Yes, we've been deleting a lot of eabi recently, but that's specific to AArch64. I have no particular insight into PowerPC but from @jroelofs' link, I agree eabi seems correct here.

Jul 10 2023, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 10 2023, 1:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Add summary comment to build-picolibc.sh

Jul 10 2023, 1:03 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings committed rG36a1e998030d: [ARM][Driver] Partial revert of D154578 (authored by michaelplatings).
[ARM][Driver] Partial revert of D154578
Jul 10 2023, 2:11 AM · Restricted Project, Restricted Project
michaelplatings accepted D154736: [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as.

LGTM

Jul 10 2023, 1:06 AM · Restricted Project, Restricted Project

Jul 7 2023

michaelplatings resigned from D153418: Adding iconv support to CharSetConverter class.
Jul 7 2023, 9:14 AM · Restricted Project, Restricted Project
michaelplatings requested review of D154708: Fix buffer overflow.
Jul 7 2023, 5:32 AM · Restricted Project, Restricted Project
michaelplatings committed rG79165735e11e: [ARM][Driver] Change float-abi warning (authored by michaelplatings).
[ARM][Driver] Change float-abi warning
Jul 7 2023, 1:42 AM · Restricted Project, Restricted Project
michaelplatings closed D154578: [ARM][Driver] Change float-abi warning.
Jul 7 2023, 1:41 AM · Restricted Project, Restricted Project

Jul 6 2023

michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 6 2023, 10:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Default to compiling picolibc with cc

Jul 6 2023, 10:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

clang -> $CC

Jul 6 2023, 5:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings accepted D154582: [libcxx] Only add -GR- option to MSVC or clang-cl builds.

Thanks for this, LGTM.

Jul 6 2023, 5:26 AM · Restricted Project, Restricted Project
michaelplatings updated the diff for D154578: [ARM][Driver] Change float-abi warning.

Fix duplicate implicit group warning

Jul 6 2023, 5:22 AM · Restricted Project, Restricted Project
michaelplatings requested review of D154578: [ARM][Driver] Change float-abi warning.
Jul 6 2023, 1:35 AM · Restricted Project, Restricted Project

Jul 4 2023

michaelplatings added a comment to D154390: [libc++] Avoid including things that require a filesystem in filesytem_clock.cpp.

Ok, thanks a lot. But just to be sure, this wasn't working previously with picolibc, was it? Or did it start failing only when I split up the source files?

Jul 4 2023, 12:16 PM · Restricted Project, Restricted Project
michaelplatings accepted D154457: [libc++] Synchronize clock selection between chrono.cpp and filesystem_clock.cpp.

The fixes building with picolibc, thanks!

Jul 4 2023, 12:16 PM · Restricted Project, Restricted Project
michaelplatings added a comment to D154390: [libc++] Avoid including things that require a filesystem in filesytem_clock.cpp.

With these changes, copied from chrono.cpp, this patch fixes building with picolibc.

Jul 4 2023, 10:50 AM · Restricted Project, Restricted Project
michaelplatings added a comment to D152382: [libc++] Expand the contents of LIBCXX_ENABLE_FILESYSTEM.

Does that mean the platform doesn't provide a way to check the time, or is it that the API it provides is just different? How is e.g. std::system_clock implemented on that platform?

Jul 4 2023, 8:39 AM · Restricted Project, Restricted Project
michaelplatings added inline comments to D154246: [libc++] Add check for building with picolibc.
Jul 4 2023, 3:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Apply @ldionne's suggestions

Jul 4 2023, 3:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added a comment to D152382: [libc++] Expand the contents of LIBCXX_ENABLE_FILESYSTEM.

Anyway, I'm trying something out in D154390

Jul 4 2023, 2:57 AM · Restricted Project, Restricted Project

Jul 3 2023

michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

send error messages to stderr

Jul 3 2023, 5:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings added a comment to D154246: [libc++] Add check for building with picolibc.

Let me know when it makes sense for me to try this locally and I'll get that done. Once the containers are updated you'll be able to get a green build here before landing.

Jul 3 2023, 3:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D154246: [libc++] Add check for building with picolibc.

Apply review suggestions

Jul 3 2023, 3:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 30 2023

michaelplatings requested review of D154246: [libc++] Add check for building with picolibc.
Jun 30 2023, 11:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 29 2023

michaelplatings committed rGdc8cbbd55f80: [Clang][Driver] Change missing multilib error to warning (authored by michaelplatings).
[Clang][Driver] Change missing multilib error to warning
Jun 29 2023, 1:08 AM · Restricted Project, Restricted Project
michaelplatings closed D153885: [Clang][Driver] Change missing multilib error to warning.
Jun 29 2023, 1:08 AM · Restricted Project, Restricted Project
michaelplatings committed rG54c79fa53c17: [test] Replace aarch64-*-eabi with aarch64 (authored by michaelplatings).
[test] Replace aarch64-*-eabi with aarch64
Jun 29 2023, 1:06 AM · Restricted Project, Restricted Project, Restricted Project
michaelplatings closed D153943: [test] Replace aarch64-*-eabi with aarch64.
Jun 29 2023, 1:06 AM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2023

michaelplatings added a comment to D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple.

Thank you for implementing this warning. Side note: it would be better to (a) fix the tests separately from (b) implementing the warning and (c) adding tests to demonstrate the warning.
This way the patch is more focused.

Jun 28 2023, 12:47 AM · Restricted Project, Restricted Project, Restricted Project
michaelplatings requested review of D153943: [test] Replace aarch64-*-eabi with aarch64.
Jun 28 2023, 12:46 AM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2023

michaelplatings updated the diff for D153885: [Clang][Driver] Change missing multilib error to warning.

Rename variable

Jun 27 2023, 12:55 PM · Restricted Project, Restricted Project
michaelplatings requested review of D153885: [Clang][Driver] Change missing multilib error to warning.
Jun 27 2023, 8:32 AM · Restricted Project, Restricted Project

Jun 26 2023

michaelplatings accepted D153691: [Driver][ARM] Warn about -mabi= for assembler input.

LGTM

Jun 26 2023, 12:04 PM · Restricted Project, Restricted Project
michaelplatings added a comment to D153691: [Driver][ARM] Warn about -mabi= for assembler input.

The change seems OK to me in principle, but I'd appreciate the code being more self-descriptive. Thanks.

Jun 26 2023, 2:17 AM · Restricted Project, Restricted Project

Jun 23 2023

michaelplatings committed rG041ffc155fd7: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple (authored by michaelplatings).
[Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple
Jun 23 2023, 3:55 AM · Restricted Project, Restricted Project, Restricted Project
michaelplatings closed D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple.
Jun 23 2023, 3:54 AM · Restricted Project, Restricted Project, Restricted Project
michaelplatings updated the diff for D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple.

Tweak warning message

Jun 23 2023, 2:18 AM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2023

michaelplatings added a comment to D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple.
<input triple> selects the fallback GCC toolchain driver; did you mean <proposed triple>

This is a correct description of the current behaviour, but I want to keep the freedom to change the behaviour in future. Therefore I'd like to avoid defining what behaviour an invalid target triple will cause.

Jun 22 2023, 9:17 AM · Restricted Project, Restricted Project, Restricted Project