This is an archive of the discontinued LLVM Phabricator instance.

Differential D117382

[NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.
AbandonedPublic

Authored by clayborg on Jan 14 2022, 6:58 PM.

Details

Reviewers
jingham
labath
JDevlieghere
wallace
shafik
Summary

Long ago we first stated with only one log channel: the LLDB log channel. Then we slowly added more log channels and all those new log channels used the lldb_private::Log class and all call sites would access methods in each log class except the LLDB log channel.

After this change:

  • Log.h contains the Log class definition and no longer inlcudes the old "Logging.h" file which contained the LLDB log channel bits and functions
  • the log mask is now expanded to 64 bits which allows for more categories within a log channel (we were out of available category bits in the LLDB log channel)
  • Logging.h has been renamed to LLDBLog.h
  • Logging.cpp has been renamed to LLDBLog.cpp
  • all call sites that were using the old top level functions GetLogIfAllCategoriesSet and GetLogIfAnyCategoriesSet now call LLDBLog::GetLogIfAllCategoriesSet and LLDBLog::GetLogIfAnyCategoryIsSetrespectively.

This cleans up our logging implementation and caught a few cases where we were getting the wrong log from the wrong channel (ThreadGDBRemote for instance) and makes it harder to use the wrong log. This also allows us to add more log channels to LLDB's main logging categories now.

Diff Detail

Event Timeline

clayborg created this revision.Jan 14 2022, 6:58 PM
Herald added a reviewer: shafik. · View Herald TranscriptJan 14 2022, 6:58 PM
Herald added a reviewer: shafik. · View Herald Transcript
Herald added subscribers: atanasyan, jrtc27, kbarton and 5 others. · View Herald Transcript
clayborg requested review of this revision.Jan 14 2022, 6:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2022, 6:58 PM
Herald added subscribers: lldb-commits, MaskRay, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B143554: Diff 400228.Jan 14 2022, 7:00 PM
JDevlieghere added a comment.Jan 14 2022, 7:02 PM

Nice improvement!

lldb/include/lldb/Utility/LLDBLog.h
1

LLDBLog.h

58

Even if it's a NOOP, should we add a Terminate for consistency?

lldb/source/Core/ValueObject.cpp
45–46

Dupe

labath added a comment.Jan 17 2022, 1:26 AM

It is definitely an improvement, but I can't help but wonder, since we're going to be touching every GetLog line with this, if we couldn't go even further.

The various LLDB_LOG have helped a lot, but one of the things that still bothers me is the verbosity of the GetLog statements. GetLogIfAllCategoriesSet(LIBLLDB_LOG_WHATEVER) is long enough as it is, and this prepends LLDBLog:: on top of that.

Here's a straw-man proposal to make that shorter (and safer). Instead of macros, we use (scoped) enums for denoting log categories. enums are not a preprocessor construct, so we can keep the identifiers relatively short. E.g. LLDBLog::API instead of LLDB_LOG_API. They also have types, which means we can use the compiler to check that the values are used appropriately. And thanks to that, we also don't need to have a long name for the log getter function. The logging could be as simple as

Log *log = LogIfAny(LLDBLog::API); // Uses template magic to find the appropriate log class based on the type

If the name sounds too cryptic, we can also choose something longer like GetLogIfAnySet or variation thereof.

If you (all) think something like that would be useful, but don't have the time to do that, I can try to whip something up.

labath added a comment.Jan 17 2022, 7:04 AM

D117490 is pretty much what I had in mind. It needs a bit of a cleanup, and doesn't actually change any interface (that'd be better done as a separate patch anyway), but all the major functionality is already there.

labath mentioned this in D117490: [lldb] Make logging machinery type-safe.Jan 24 2022, 1:03 PM
clayborg abandoned this revision.Jan 24 2022, 4:20 PM

Abandoning after discussing on the mailing list in lieu of Pavel's patch: https://reviews.llvm.org/D117490

JDevlieghere mentioned this in D134245: [lldb] Actually support more than 32 logging categories.Sep 19 2022, 5:07 PM
JDevlieghere mentioned this in rG3b4db10f3492: [lldb] Actually support more than 32 logging categories.Sep 19 2022, 10:31 PM

Large Diff

This large diff affects 304 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
lldb/
include/
lldb/
Interpreter/
2 lines
5 lines
Utility/
71 lines
27 lines
3 lines
source/
API/
15 lines
32 lines
2 lines
4 lines
4 lines
Breakpoint/
18 lines
8 lines
16 lines
4 lines
5 lines
4 lines
2 lines
6 lines
6 lines
4 lines
Commands/
2 lines
2 lines
Core/
5 lines
28 lines
12 lines
6 lines
2 lines
10 lines
12 lines
12 lines
6 lines
7 lines
6 lines
6 lines
6 lines
4 lines
10 lines
DataFormatters/
6 lines
5 lines
2 lines
Expression/
6 lines
2 lines
4 lines
12 lines
26 lines
11 lines
10 lines
9 lines
24 lines
4 lines
2 lines
Host/
common/
2 lines
12 lines
18 lines
4 lines
4 lines
22 lines
6 lines
2 lines
8 lines
12 lines
6 lines
2 lines
4 lines
freebsd/
2 lines
linux/
8 lines
5 lines
8 lines
macosx/
objcxx/
12 lines
10 lines
netbsd/
4 lines
openbsd/
2 lines
posix/
24 lines
2 lines
2 lines
windows/
10 lines
2 lines
Initialization/
4 lines
Interpreter/
6 lines
Plugins/
ABI/
AArch64/
4 lines
4 lines
Hexagon/
2 lines
Mips/
4 lines
4 lines
PowerPC/
4 lines
10 lines
SystemZ/
4 lines
X86/
2 lines
4 lines
4 lines
Architecture/
Mips/
4 lines
Disassembler/
LLVMC/
4 lines
DynamicLoader/
Darwin-Kernel/
14 lines
Hexagon-DYLD/
14 lines
2 lines
MacOSX-DYLD/
24 lines
6 lines
8 lines
POSIX-DYLD/
8 lines
28 lines
Windows-DYLD/
50 lines
wasm-DYLD/
4 lines
ExpressionParser/
Clang/
16 lines
2 lines
26 lines
34 lines
34 lines
10 lines
4 lines
8 lines
6 lines
2 lines
14 lines
2 lines
4 lines
8 lines
52 lines
2 lines
Instruction/
PPC64/
2 lines
10 lines
JITLoader/
GDB/
8 lines
Language/
CPlusPlus/
4 lines
4 lines
ObjC/
2 lines
2 lines
LanguageRuntime/
CPlusPlus/
ItaniumABI/
6 lines
ObjC/
AppleObjCRuntime/
4 lines
12 lines
4 lines
4 lines
26 lines
24 lines
46 lines
4 lines
RenderScript/
RenderScriptRuntime/
6 lines
99 lines
2 lines
4 lines
ObjectFile/
ELF/
14 lines
JIT/
2 lines
Mach-O/
18 lines
PECOFF/
8 lines
wasm/
4 lines
OperatingSystem/
Python/
8 lines
Platform/
Android/
10 lines
10 lines
FreeBSD/
4 lines
Linux/
5 lines
MacOSX/
5 lines
22 lines
12 lines
2 lines
4 lines
4 lines
4 lines
12 lines
4 lines
4 lines
NetBSD/
4 lines
OpenBSD/
4 lines
POSIX/
94 lines
QemuUser/
4 lines
gdb-server/
20 lines
Process/
FreeBSD/
2 lines
FreeBSDKernel/
2 lines
Linux/
8 lines
2 lines
2 lines
2 lines
2 lines
2 lines
12 lines
MacOSX-Kernel/
48 lines
4 lines
30 lines
NetBSD/
2 lines
POSIX/
18 lines
Utility/
2 lines
6 lines
28 lines
4 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
Windows/
Common/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
6 lines
2 lines
7 lines
elf-core/
12 lines
4 lines
gdb-remote/
2 lines
6 lines
3 lines
6 lines
112 lines
6 lines
14 lines
36 lines
8 lines
mach-core/
6 lines
minidump/
22 lines
6 lines
2 lines
scripted/
6 lines
3 lines
ScriptInterpreter/
Python/
4 lines
14 lines
3 lines
3 lines
3 lines
StructuredData/
DarwinLog/
16 lines
SymbolFile/
Breakpad/
18 lines
DWARF/
2 lines
2 lines
2 lines
16 lines
12 lines
NativePDB/
5 lines
4 lines
PDB/
4 lines
24 lines
SystemRuntime/
MacOSX/
6 lines
6 lines
6 lines
6 lines
4 lines
TypeSystem/
Clang/
10 lines
10 lines
UnwindAssembly/
InstEmulation/
12 lines
Symbol/
4 lines
6 lines
6 lines
10 lines
4 lines
8 lines
10 lines
4 lines
2 lines
4 lines
10 lines
Target/
4 lines
9 lines
4 lines
14 lines
4 lines
20 lines
94 lines
20 lines
8 lines
8 lines
12 lines
14 lines
74 lines
38 lines
16 lines
18 lines
8 lines
16 lines
2 lines
4 lines
16 lines
4 lines
8 lines
2 lines
14 lines
9 lines
10 lines
16 lines
10 lines
22 lines
10 lines
4 lines
11 lines
8 lines
Utility/
16 lines
14 lines
2 lines
2 lines
78 lines
24 lines
31 lines
2 lines
2 lines
tools/
lldb-server/
2 lines
2 lines
unittests/
Utility/
4 lines

Diff 400228

lldb/include/lldb/Interpreter/CommandInterpreter.h

lldb/include/lldb/Interpreter/ScriptedInterface.h

lldb/include/lldb/Utility/LLDBLog.h

  • This file was added.
//===-- Logging.h -----------------------------------------------*- C++ -*-===//
JDevlieghereUnsubmitted
Not Done
ReplyInline Actions

LLDBLog.h

JDevlieghere: LLDBLog.h
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLDB_UTILITY_LOGGING_H
#define LLDB_UTILITY_LOGGING_H
#include "lldb/Utility/Log.h"
// Log Bits specific to logging in lldb
#define LIBLLDB_LOG_PROCESS LLDB_LOG_BIT(1)
#define LIBLLDB_LOG_THREAD LLDB_LOG_BIT(2)
#define LIBLLDB_LOG_DYNAMIC_LOADER LLDB_LOG_BIT(3)
#define LIBLLDB_LOG_EVENTS LLDB_LOG_BIT(4)
#define LIBLLDB_LOG_BREAKPOINTS LLDB_LOG_BIT(5)
#define LIBLLDB_LOG_WATCHPOINTS LLDB_LOG_BIT(6)
#define LIBLLDB_LOG_STEP LLDB_LOG_BIT(7)
#define LIBLLDB_LOG_EXPRESSIONS LLDB_LOG_BIT(8)
#define LIBLLDB_LOG_TEMPORARY LLDB_LOG_BIT(9)
#define LIBLLDB_LOG_STATE LLDB_LOG_BIT(10)
#define LIBLLDB_LOG_OBJECT LLDB_LOG_BIT(11)
#define LIBLLDB_LOG_COMMUNICATION LLDB_LOG_BIT(12)
#define LIBLLDB_LOG_CONNECTION LLDB_LOG_BIT(13)
#define LIBLLDB_LOG_HOST LLDB_LOG_BIT(14)
#define LIBLLDB_LOG_UNWIND LLDB_LOG_BIT(15)
#define LIBLLDB_LOG_API LLDB_LOG_BIT(16)
#define LIBLLDB_LOG_SCRIPT LLDB_LOG_BIT(17)
#define LIBLLDB_LOG_COMMANDS LLDB_LOG_BIT(18)
#define LIBLLDB_LOG_TYPES LLDB_LOG_BIT(19)
#define LIBLLDB_LOG_SYMBOLS LLDB_LOG_BIT(20)
#define LIBLLDB_LOG_MODULES LLDB_LOG_BIT(21)
#define LIBLLDB_LOG_TARGET LLDB_LOG_BIT(22)
#define LIBLLDB_LOG_MMAP LLDB_LOG_BIT(23)
#define LIBLLDB_LOG_OS LLDB_LOG_BIT(24)
#define LIBLLDB_LOG_PLATFORM LLDB_LOG_BIT(25)
#define LIBLLDB_LOG_SYSTEM_RUNTIME LLDB_LOG_BIT(26)
#define LIBLLDB_LOG_JIT_LOADER LLDB_LOG_BIT(27)
#define LIBLLDB_LOG_LANGUAGE LLDB_LOG_BIT(28)
#define LIBLLDB_LOG_DATAFORMATTERS LLDB_LOG_BIT(29)
#define LIBLLDB_LOG_DEMANGLE LLDB_LOG_BIT(30)
#define LIBLLDB_LOG_AST LLDB_LOG_BIT(31)
#define LIBLLDB_LOG_ALL LLDB_LOG_ALL_BITS
#define LIBLLDB_LOG_DEFAULT \
(LIBLLDB_LOG_PROCESS | LIBLLDB_LOG_THREAD | LIBLLDB_LOG_DYNAMIC_LOADER | \
LIBLLDB_LOG_BREAKPOINTS | LIBLLDB_LOG_WATCHPOINTS | LIBLLDB_LOG_STEP | \
LIBLLDB_LOG_STATE | LIBLLDB_LOG_SYMBOLS | LIBLLDB_LOG_TARGET | \
LIBLLDB_LOG_COMMANDS)
namespace lldb_private {
class LLDBLog {
static Log::Channel g_channel;
public:
static void Initialize();
JDevlieghereUnsubmitted
Not Done
ReplyInline Actions

Even if it's a NOOP, should we add a Terminate for consistency?

JDevlieghere: Even if it's a NOOP, should we add a `Terminate` for consistency?
static Log *GetLogIfAllCategoriesSet(LogMask mask) {
return g_channel.GetLogIfAll(mask);
}
static Log *GetLogIfAnyCategoryIsSet(LogMask mask) {
return g_channel.GetLogIfAny(mask);
}
};
} // namespace lldb_private
#endif // LLDB_UTILITY_LOGGING_H

lldb/include/lldb/Utility/Log.h

lldb/include/lldb/Utility/Logging.h

lldb/include/lldb/Utility/ReproducerInstrumentation.h

lldb/source/API/SBBreakpointOptionCommon.cpp

lldb/source/API/SBDebugger.cpp

lldb/source/API/SBFrame.cpp

lldb/source/API/SBStream.cpp

lldb/source/API/SBTarget.cpp

lldb/source/Breakpoint/Breakpoint.cpp

lldb/source/Breakpoint/BreakpointLocation.cpp

lldb/source/Breakpoint/BreakpointName.cpp

lldb/source/Breakpoint/BreakpointResolver.cpp

lldb/source/Breakpoint/BreakpointResolverAddress.cpp

lldb/source/Breakpoint/BreakpointResolverFileLine.cpp

lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp

lldb/source/Breakpoint/BreakpointResolverName.cpp

lldb/source/Breakpoint/BreakpointResolverScripted.cpp

lldb/source/Breakpoint/Watchpoint.cpp

lldb/source/Commands/CommandObjectLog.cpp

lldb/source/Commands/CommandObjectTarget.cpp

lldb/source/Core/AddressResolverFileLine.cpp

lldb/source/Core/Communication.cpp

lldb/source/Core/DataFileCache.cpp

lldb/source/Core/Debugger.cpp

lldb/source/Core/DumpDataExtractor.cpp

lldb/source/Core/FormatEntity.cpp

lldb/source/Core/Mangled.cpp

lldb/source/Core/Module.cpp

lldb/source/Core/ModuleList.cpp

lldb/source/Core/RichManglingContext.cpp

lldb/source/Core/StreamFile.cpp

lldb/source/Core/ValueObject.cpp

Show All 36 Lines
#include "lldb/Target/Process.h" #include "lldb/Target/Process.h"
#include "lldb/Target/StackFrame.h" #include "lldb/Target/StackFrame.h"
#include "lldb/Target/Target.h" #include "lldb/Target/Target.h"
#include "lldb/Target/Thread.h" #include "lldb/Target/Thread.h"
#include "lldb/Target/ThreadList.h" #include "lldb/Target/ThreadList.h"
#include "lldb/Utility/DataBuffer.h" #include "lldb/Utility/DataBuffer.h"
#include "lldb/Utility/DataBufferHeap.h" #include "lldb/Utility/DataBufferHeap.h"
#include "lldb/Utility/Flags.h" #include "lldb/Utility/Flags.h"
#include "lldb/Utility/Log.h" #include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Logging.h" #include "lldb/Utility/LLDBLog.h"
JDevlieghereUnsubmitted
Not Done
ReplyInline Actions

Dupe

JDevlieghere: Dupe
#include "lldb/Utility/Scalar.h" #include "lldb/Utility/Scalar.h"
#include "lldb/Utility/Stream.h" #include "lldb/Utility/Stream.h"
#include "lldb/Utility/StreamString.h" #include "lldb/Utility/StreamString.h"
#include "lldb/lldb-private-types.h" #include "lldb/lldb-private-types.h"
#include "llvm/Support/Compiler.h" #include "llvm/Support/Compiler.h"
#include <algorithm> #include <algorithm>
▲ Show 20 Lines • Show All 140 Lines • ▼ Show 20 Lines if (NeedsUpdating()) {
} else { } else {
m_error.SetErrorString("out of scope"); m_error.SetErrorString("out of scope");
} }
} }
return m_error.Success(); return m_error.Success();
} }
bool ValueObject::UpdateFormatsIfNeeded() { bool ValueObject::UpdateFormatsIfNeeded() {
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_DATAFORMATTERS)); Log *log(LLDBLog::GetLogIfAllCategoriesSet(LIBLLDB_LOG_DATAFORMATTERS));
LLDB_LOGF(log, LLDB_LOGF(log,
"[%s %p] checking for FormatManager revisions. ValueObject " "[%s %p] checking for FormatManager revisions. ValueObject "
"rev: %d - Global rev: %d", "rev: %d - Global rev: %d",
GetName().GetCString(), static_cast<void *>(this), GetName().GetCString(), static_cast<void *>(this),
m_last_format_mgr_revision, m_last_format_mgr_revision,
DataVisualization::GetCurrentRevision()); DataVisualization::GetCurrentRevision());
bool any_change = false; bool any_change = false;
▲ Show 20 Lines • Show All 2,928 Lines • Show Last 20 Lines

lldb/source/Core/ValueObjectDynamicValue.cpp

lldb/source/Core/ValueObjectRegister.cpp

lldb/source/Core/ValueObjectSyntheticFilter.cpp

lldb/source/DataFormatters/FormatManager.cpp

lldb/source/DataFormatters/TypeCategoryMap.cpp

lldb/source/DataFormatters/VectorType.cpp

lldb/source/Expression/DWARFExpression.cpp

lldb/source/Expression/DiagnosticManager.cpp

lldb/source/Expression/ExpressionVariable.cpp

lldb/source/Expression/FunctionCaller.cpp

lldb/source/Expression/IRExecutionUnit.cpp

lldb/source/Expression/IRInterpreter.cpp

lldb/source/Expression/IRMemoryMap.cpp

lldb/source/Expression/LLVMUserExpression.cpp

lldb/source/Expression/Materializer.cpp

lldb/source/Expression/UserExpression.cpp

lldb/source/Expression/UtilityFunction.cpp

lldb/source/Host/common/File.cpp

lldb/source/Host/common/Host.cpp

lldb/source/Host/common/HostInfoBase.cpp

lldb/source/Host/common/HostNativeThreadBase.cpp

lldb/source/Host/common/MonitoringProcessLauncher.cpp

lldb/source/Host/common/NativeProcessProtocol.cpp

lldb/source/Host/common/NativeRegisterContext.cpp

lldb/source/Host/common/NativeWatchpointList.cpp

lldb/source/Host/common/ProcessLaunchInfo.cpp

lldb/source/Host/common/Socket.cpp

lldb/source/Host/common/TCPSocket.cpp

lldb/source/Host/common/ThreadLauncher.cpp

lldb/source/Host/common/UDPSocket.cpp

lldb/source/Host/freebsd/Host.cpp

lldb/source/Host/linux/Host.cpp

lldb/source/Host/linux/HostInfoLinux.cpp

lldb/source/Host/linux/Support.cpp

lldb/source/Host/macosx/objcxx/Host.mm

lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

lldb/source/Host/netbsd/HostNetBSD.cpp

lldb/source/Host/openbsd/Host.cpp

lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp

lldb/source/Host/posix/HostInfoPosix.cpp

lldb/source/Host/posix/ProcessLauncherPosixFork.cpp

lldb/source/Host/windows/ConnectionGenericFileWindows.cpp

lldb/source/Host/windows/Host.cpp

lldb/source/Initialization/SystemInitializerCommon.cpp

lldb/source/Interpreter/CommandInterpreter.cpp

lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp

lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp

lldb/source/Plugins/ABI/Hexagon/ABISysV_hexagon.cpp

lldb/source/Plugins/ABI/Mips/ABISysV_mips.cpp

lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp

lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp

lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.cpp

lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.cpp

lldb/source/Plugins/ABI/X86/ABISysV_i386.cpp

lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp

lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp

lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp

lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp

lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp

lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.cpp

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp

lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp

lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp

lldb/source/Plugins/DynamicLoader/wasm-DYLD/DynamicLoaderWasmDYLD.cpp

lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp

lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangHost.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp

lldb/source/Plugins/ExpressionParser/Clang/CxxModuleHandler.cpp

lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.cpp

lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

lldb/source/Plugins/ExpressionParser/Clang/NameSearchContext.cpp

lldb/source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.h

lldb/source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.cpp

lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp

lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

lldb/source/Plugins/Language/ObjC/Cocoa.cpp

lldb/source/Plugins/Language/ObjC/CoreMedia.cpp

lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCDeclVendor.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.cpp

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptScriptGroup.cpp

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp

lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp

lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp

lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleBridge.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformRemoteMacOSX.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.cpp

lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp

lldb/source/Plugins/Platform/OpenBSD/PlatformOpenBSD.cpp

lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp

lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp

lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_x86_64.cpp

lldb/source/Plugins/Process/FreeBSDKernel/ThreadFreeBSDKernel.cpp

lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp

lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.h

lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

lldb/source/Plugins/Process/POSIX/ProcessPOSIXLog.h

lldb/source/Plugins/Process/Utility/AuxVector.h

lldb/source/Plugins/Process/Utility/HistoryThread.cpp

lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp

lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_x86.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_i386.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDummy.cpp

lldb/source/Plugins/Process/Utility/RegisterContextHistory.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm.h

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.h

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.h

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.h

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.h

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.h

lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp

lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp

lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp

lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp

lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp

lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp

lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp

lldb/source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp

lldb/source/Plugins/Process/Windows/Common/ProcessWindowsLog.h

lldb/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp

lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationHistory.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.h

lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp

lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp

lldb/source/Plugins/Process/minidump/MinidumpParser.cpp

lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp

lldb/source/Plugins/Process/minidump/ThreadMinidump.cpp

lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp

lldb/source/Plugins/Process/scripted/ScriptedThread.cpp

lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp

lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp

lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.cpp

lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp

lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp

lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.h

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp

lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp

lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp

lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp

lldb/source/Symbol/Block.cpp

lldb/source/Symbol/CompactUnwindInfo.cpp

lldb/source/Symbol/DWARFCallFrameInfo.cpp

lldb/source/Symbol/Function.cpp

lldb/source/Symbol/LocateSymbolFile.cpp

lldb/source/Symbol/LocateSymbolFileMacOSX.cpp

lldb/source/Symbol/ObjectFile.cpp

lldb/source/Symbol/SymbolContext.cpp

lldb/source/Symbol/SymbolFile.cpp

lldb/source/Symbol/Type.cpp

lldb/source/Symbol/UnwindPlan.cpp

lldb/source/Target/ABI.cpp

lldb/source/Target/AssertFrameRecognizer.cpp

lldb/source/Target/DynamicRegisterInfo.cpp

lldb/source/Target/Memory.cpp

lldb/source/Target/ModuleCache.cpp

lldb/source/Target/Platform.cpp

lldb/source/Target/Process.cpp

lldb/source/Target/RegisterContextUnwind.cpp

lldb/source/Target/SectionLoadList.cpp

lldb/source/Target/StackFrame.cpp

lldb/source/Target/StackFrameList.cpp

lldb/source/Target/StopInfo.cpp

lldb/source/Target/Target.cpp

lldb/source/Target/Thread.cpp

lldb/source/Target/ThreadList.cpp

lldb/source/Target/ThreadPlan.cpp

lldb/source/Target/ThreadPlanBase.cpp

lldb/source/Target/ThreadPlanCallFunction.cpp

lldb/source/Target/ThreadPlanCallFunctionUsingABI.cpp

lldb/source/Target/ThreadPlanCallUserExpression.cpp

lldb/source/Target/ThreadPlanPython.cpp

lldb/source/Target/ThreadPlanRunToAddress.cpp

lldb/source/Target/ThreadPlanShouldStopHere.cpp

lldb/source/Target/ThreadPlanStack.cpp

lldb/source/Target/ThreadPlanStepInRange.cpp

lldb/source/Target/ThreadPlanStepInstruction.cpp

lldb/source/Target/ThreadPlanStepOut.cpp

lldb/source/Target/ThreadPlanStepOverBreakpoint.cpp

lldb/source/Target/ThreadPlanStepOverRange.cpp

lldb/source/Target/ThreadPlanStepRange.cpp

lldb/source/Target/ThreadPlanStepThrough.cpp

lldb/source/Target/ThreadPlanStepUntil.cpp

lldb/source/Target/ThreadPlanTracer.cpp

lldb/source/Target/UnwindLLDB.cpp

lldb/source/Utility/ArchSpec.cpp

lldb/source/Utility/Broadcaster.cpp

lldb/source/Utility/CMakeLists.txt

lldb/source/Utility/DataExtractor.cpp

lldb/source/Utility/LLDBLog.cpp

lldb/source/Utility/Listener.cpp

lldb/source/Utility/Log.cpp

lldb/source/Utility/Logging.cpp

lldb/source/Utility/ReproducerInstrumentation.cpp

lldb/source/Utility/StringList.cpp

lldb/tools/lldb-server/LLDBServerUtilities.cpp

lldb/tools/lldb-server/lldb-gdbserver.cpp

lldb/unittests/Utility/LogTest.cpp