Page MenuHomePhabricator
People wallace

wallace (walter erquinigo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 10:57 AM (314 w, 5 d)

Recent Activity
View All

Thu, May 19

wallace updated the diff for D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save.

nit

Thu, May 19, 1:46 PM · Restricted Project, Restricted Project, Restricted Project
wallace requested review of D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save.
Thu, May 19, 1:34 PM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

wallace updated the summary of D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.
Wed, May 18, 7:23 PM · Restricted Project, Restricted Project
wallace updated the summary of D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.
Wed, May 18, 7:22 PM · Restricted Project, Restricted Project
wallace requested review of D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.
Wed, May 18, 7:22 PM · Restricted Project, Restricted Project
wallace requested review of D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server..
Wed, May 18, 3:29 PM · Restricted Project, Restricted Project
wallace updated the diff for D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces.

nit

Wed, May 18, 1:28 PM · Restricted Project, Restricted Project
wallace requested review of D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces.
Wed, May 18, 8:49 AM · Restricted Project, Restricted Project

Tue, May 17

wallace retitled D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration from [trace][intelpt] Support system-wide tracing [7] - Improve the single buffer perf_event configuration to [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration.
Tue, May 17, 9:50 PM · Restricted Project, Restricted Project
wallace requested review of D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration.
Tue, May 17, 9:49 PM · Restricted Project, Restricted Project
wallace updated the diff for D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class.

rebase

Tue, May 17, 1:57 PM · Restricted Project, Restricted Project
wallace added a comment to D125073: [lldb-vscode] Fix data race in lldb-vscode when running with ThreadSanitizer.

Hi! I'll push it for you :)

Tue, May 17, 8:43 AM · Restricted Project, Restricted Project

Thu, May 12

wallace abandoned D122859: [trace] Show ideas for the main interfaces for new HTR.
Thu, May 12, 2:41 PM · Restricted Project, Restricted Project
wallace added inline comments to D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class.
Thu, May 12, 2:34 PM · Restricted Project, Restricted Project
wallace requested review of D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class.
Thu, May 12, 2:28 PM · Restricted Project, Restricted Project
wallace added a comment to D125347: Add "indexedVariables" to variables with lots of children..

lgtm

Thu, May 12, 11:17 AM · Restricted Project, Restricted Project
wallace updated the diff for D125322: [llvm][json] Fix UINT64 json parsing.

address comments

Thu, May 12, 10:18 AM · Restricted Project, Restricted Project

Wed, May 11

wallace added a reviewer for D125322: [llvm][json] Fix UINT64 json parsing: clayborg.
Wed, May 11, 4:39 PM · Restricted Project, Restricted Project
wallace updated the diff for D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor.

rebase

Wed, May 11, 9:49 AM · Restricted Project, Restricted Project
wallace added inline comments to D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor.
Wed, May 11, 9:34 AM · Restricted Project, Restricted Project
wallace updated the diff for D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state.
  • remove the flush parameter
  • use perf_event_attr.disabled to set the initial state of the collection
Wed, May 11, 9:29 AM · Restricted Project, Restricted Project
wallace added inline comments to D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state.
Wed, May 11, 9:17 AM · Restricted Project, Restricted Project
wallace updated the diff for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

address comments

Wed, May 11, 9:08 AM · Restricted Project, Restricted Project
wallace added inline comments to D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.
Wed, May 11, 9:01 AM · Restricted Project, Restricted Project

Tue, May 10

wallace added inline comments to D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.
Tue, May 10, 3:19 PM · Restricted Project, Restricted Project
wallace updated the diff for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

Now the tracedThreads field returned by the GetState request must have the list of all the threads of the process if per-core mode is enabled. This will avoid having to make that field optional.

Tue, May 10, 3:08 PM · Restricted Project, Restricted Project
wallace updated the diff for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

address comments

Tue, May 10, 2:12 PM · Restricted Project, Restricted Project
wallace added reviewers for D125322: [llvm][json] Fix UINT64 json parsing: djtodoro, jj10306, StephenTozer, akhuang, dblaikie.
Tue, May 10, 9:00 AM · Restricted Project, Restricted Project
wallace updated the diff for D125322: [llvm][json] Fix UINT64 json parsing.

add additional test

Tue, May 10, 8:59 AM · Restricted Project, Restricted Project
wallace requested review of D125322: [llvm][json] Fix UINT64 json parsing.
Tue, May 10, 8:58 AM · Restricted Project, Restricted Project

Mon, May 9

wallace added inline comments to D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.
Mon, May 9, 10:11 PM · Restricted Project, Restricted Project
wallace added inline comments to D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace.
Mon, May 9, 3:50 PM · Restricted Project, Restricted Project
wallace accepted D125253: Add the ability to debug through an exec into ld.

nice!

Mon, May 9, 3:47 PM · Restricted Project, Restricted Project
wallace accepted D125073: [lldb-vscode] Fix data race in lldb-vscode when running with ThreadSanitizer.

Thanks for doing this fix. I hope tsan doesn't report this anymore

Mon, May 9, 3:43 PM · Restricted Project, Restricted Project

Thu, May 5

wallace requested review of D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor.
Thu, May 5, 3:10 PM · Restricted Project, Restricted Project
wallace updated the diff for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

nits

Thu, May 5, 2:21 PM · Restricted Project, Restricted Project
wallace updated the diff for D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state.

add better error handling

Thu, May 5, 2:21 PM · Restricted Project, Restricted Project
wallace requested review of D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option.
Thu, May 5, 10:33 AM · Restricted Project, Restricted Project

Wed, May 4

wallace requested review of D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state.
Wed, May 4, 1:48 PM · Restricted Project, Restricted Project

Tue, May 3

wallace added inline comments to D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.
Tue, May 3, 11:04 AM · Restricted Project, Restricted Project
wallace updated the diff for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

improve error message

Tue, May 3, 9:24 AM · Restricted Project, Restricted Project
wallace updated the diff for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

add one test

Tue, May 3, 9:18 AM · Restricted Project, Restricted Project
wallace updated the diff for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.

nits

Tue, May 3, 9:04 AM · Restricted Project, Restricted Project
wallace added a reviewer for D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server: jj10306.
Tue, May 3, 8:41 AM · Restricted Project, Restricted Project
wallace requested review of D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server.
Tue, May 3, 8:40 AM · Restricted Project, Restricted Project

Mon, May 2

wallace updated the diff for D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace.

update test

Mon, May 2, 5:14 PM · Restricted Project, Restricted Project
wallace added inline comments to D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace.
Mon, May 2, 10:00 AM · Restricted Project, Restricted Project
wallace added inline comments to D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace.
Mon, May 2, 9:40 AM · Restricted Project, Restricted Project
wallace added inline comments to D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option.
Mon, May 2, 9:00 AM · Restricted Project, Restricted Project
wallace added a comment to D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids.

thanks for your review :)

Mon, May 2, 8:53 AM · Restricted Project, Restricted Project
wallace added inline comments to D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option.
Mon, May 2, 8:52 AM · Restricted Project, Restricted Project
wallace updated the diff for D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids.

final nits

Mon, May 2, 8:47 AM · Restricted Project, Restricted Project
wallace updated the diff for D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids.

move procfs functions to Procfs.h

Mon, May 2, 8:42 AM · Restricted Project, Restricted Project
wallace added inline comments to D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids.
Mon, May 2, 7:36 AM · Restricted Project, Restricted Project

Thu, Apr 28

wallace updated the diff for D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids.

I made a mistake and I included the second of two commits. This update contains all the code.

Thu, Apr 28, 5:30 PM · Restricted Project, Restricted Project
wallace updated the summary of D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace.
Thu, Apr 28, 5:21 PM · Restricted Project, Restricted Project
wallace requested review of D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace.
Thu, Apr 28, 5:20 PM · Restricted Project, Restricted Project
wallace updated the diff for D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option.

nit

Thu, Apr 28, 3:43 PM · Restricted Project, Restricted Project
wallace updated the summary of D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option.
Thu, Apr 28, 3:15 PM · Restricted Project, Restricted Project
wallace requested review of D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option.
Thu, Apr 28, 3:13 PM · Restricted Project, Restricted Project
wallace added inline comments to D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids.
Thu, Apr 28, 11:35 AM · Restricted Project, Restricted Project

Wed, Apr 27

wallace requested review of D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids.
Wed, Apr 27, 5:00 PM · Restricted Project, Restricted Project

Mon, Apr 25

wallace updated the diff for D124064: [NFC][trace] simplify the instruction dumper.

address comments

Mon, Apr 25, 8:02 PM · Restricted Project, Restricted Project
wallace added inline comments to D124064: [NFC][trace] simplify the instruction dumper.
Mon, Apr 25, 8:01 PM · Restricted Project, Restricted Project

Apr 22 2022

wallace updated the diff for D123982: [trace][intel pt] Support events.

address comments

Apr 22 2022, 4:31 PM · Restricted Project, Restricted Project
wallace added inline comments to D123982: [trace][intel pt] Support events.
Apr 22 2022, 4:28 PM · Restricted Project, Restricted Project

Apr 19 2022

wallace requested review of D124064: [NFC][trace] simplify the instruction dumper.
Apr 19 2022, 10:00 PM · Restricted Project, Restricted Project
wallace updated the diff for D123982: [trace][intel pt] Support events.

address comments. Still pending response about the iff word.

Apr 19 2022, 9:28 AM · Restricted Project, Restricted Project
wallace abandoned D123984: [trace][intel pt] Add a memory usage test.

I think I can do better than this

Apr 19 2022, 8:46 AM · Restricted Project, Restricted Project
wallace added a comment to D123984: [trace][intel pt] Add a memory usage test.

To catch changes that may increase the memory by a lot?

Apr 19 2022, 8:05 AM · Restricted Project, Restricted Project
wallace added inline comments to D123982: [trace][intel pt] Support events.
Apr 19 2022, 7:54 AM · Restricted Project, Restricted Project

Apr 18 2022

wallace added reviewers for D123984: [trace][intel pt] Add a memory usage test: jj10306, zrthxn.
Apr 18 2022, 11:12 PM · Restricted Project, Restricted Project
wallace requested review of D123984: [trace][intel pt] Add a memory usage test.
Apr 18 2022, 11:11 PM · Restricted Project, Restricted Project
wallace added a comment to D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions.

let me think about it :)

Apr 18 2022, 10:38 PM · Restricted Project, Restricted Project
wallace updated the diff for D123982: [trace][intel pt] Support events.

formatting

Apr 18 2022, 10:35 PM · Restricted Project, Restricted Project
wallace requested review of D123982: [trace][intel pt] Support events.
Apr 18 2022, 10:25 PM · Restricted Project, Restricted Project

Apr 13 2022

wallace abandoned D123356: add task timer.
Apr 13 2022, 10:27 AM · Restricted Project, Restricted Project
wallace closed D123357: [trace][intelpt] Add task timer classes.

Committed as bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9

Apr 13 2022, 10:27 AM · Restricted Project, Restricted Project
wallace closed D123358: [trace][intelpt] Remove code smell when printing the raw trace size.

Committed as 44103c96fa6b00e7824319de1b10ce26781e3852

Apr 13 2022, 10:26 AM · Restricted Project, Restricted Project

Apr 12 2022

wallace added inline comments to D123357: [trace][intelpt] Add task timer classes.
Apr 12 2022, 12:41 PM · Restricted Project, Restricted Project

Apr 11 2022

wallace added a comment to D123358: [trace][intelpt] Remove code smell when printing the raw trace size.

Well, not all theoretical trace plugins might have raw trace sizes.

Apr 11 2022, 5:19 PM · Restricted Project, Restricted Project
wallace requested changes to D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions.

I did a first pass on this diff. I'm asking to refactor a bit the InstructionBlock classes so that they are smarter. Besides that, if you use IDs more ubiquitously and stop using instruction indices everywhere, everything becomes much simpler.

Apr 11 2022, 5:11 PM · Restricted Project, Restricted Project

Apr 7 2022

wallace requested review of D123358: [trace][intelpt] Remove code smell when printing the raw trace size.
Apr 7 2022, 9:00 PM · Restricted Project, Restricted Project
wallace added reviewers for D123357: [trace][intelpt] Add task timer classes: jj10306, zrthxn.
Apr 7 2022, 8:43 PM · Restricted Project, Restricted Project
wallace requested review of D123357: [trace][intelpt] Add task timer classes.
Apr 7 2022, 8:43 PM · Restricted Project, Restricted Project
wallace requested review of D123356: add task timer.
Apr 7 2022, 8:35 PM · Restricted Project, Restricted Project
wallace added inline comments to D123281: [trace][intel pt] Create a common accessor for live and postmortem data.
Apr 7 2022, 3:57 PM · Restricted Project, Restricted Project
wallace updated the diff for D123281: [trace][intel pt] Create a common accessor for live and postmortem data.

address comments

Apr 7 2022, 11:11 AM · Restricted Project, Restricted Project
wallace updated the diff for D123106: [trace][intel pt] Create a class for the libipt decoder wrapper.

address comments

Apr 7 2022, 10:48 AM · Restricted Project, Restricted Project
wallace added a comment to D123106: [trace][intel pt] Create a class for the libipt decoder wrapper.

thanks for the gotchas

Apr 7 2022, 10:40 AM · Restricted Project, Restricted Project
wallace added inline comments to D123281: [trace][intel pt] Create a common accessor for live and postmortem data.
Apr 7 2022, 10:34 AM · Restricted Project, Restricted Project

Apr 6 2022

wallace updated the diff for D123281: [trace][intel pt] Create a common accessor for live and postmortem data.

nits

Apr 6 2022, 10:53 PM · Restricted Project, Restricted Project
wallace requested review of D123281: [trace][intel pt] Create a common accessor for live and postmortem data.
Apr 6 2022, 10:31 PM · Restricted Project, Restricted Project

Apr 5 2022

wallace added a comment to D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode.

ok! I'll commit it for you

Apr 5 2022, 10:52 AM · Restricted Project, Restricted Project
wallace added a comment to D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode.

Let me know if you need help upstreaming this patch.

Apr 5 2022, 9:28 AM · Restricted Project, Restricted Project
wallace accepted D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode.

thank you!

Apr 5 2022, 9:27 AM · Restricted Project, Restricted Project
wallace accepted D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`.

great job!

Apr 5 2022, 9:25 AM · Restricted Project, Restricted Project
wallace requested changes to D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`.

just remove a small comment and good to go!

Apr 5 2022, 9:16 AM · Restricted Project, Restricted Project

Apr 4 2022

wallace updated the diff for D123106: [trace][intel pt] Create a class for the libipt decoder wrapper.

nits

Apr 4 2022, 11:39 PM · Restricted Project, Restricted Project
wallace requested review of D123106: [trace][intel pt] Create a class for the libipt decoder wrapper.
Apr 4 2022, 11:22 PM · Restricted Project, Restricted Project