Page MenuHomePhabricator

wallace (walter erquinigo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 10:57 AM (258 w, 13 h)

Recent Activity

Yesterday

wallace updated the diff for D100740: json.

ready for review

Tue, Apr 20, 4:32 PM · Restricted Project
wallace retitled D100740: json from json to [trace] Dedup different source lines when dumping instructions + refactor.
Tue, Apr 20, 4:32 PM · Restricted Project

Sun, Apr 18

wallace planned changes to D100740: json.
Sun, Apr 18, 11:51 PM · Restricted Project
wallace updated the diff for D100740: json.
Sun, Apr 18, 11:51 PM · Restricted Project
wallace planned changes to D100740: json.
Sun, Apr 18, 11:09 PM · Restricted Project
wallace requested review of D100740: json.
Sun, Apr 18, 11:09 PM · Restricted Project

Wed, Apr 14

wallace committed rGcc88d301a0bc: [lldb-vscode] Reduce chattiness of progress events (authored by wallace).
[lldb-vscode] Reduce chattiness of progress events
Wed, Apr 14, 1:00 PM
wallace closed D100443: [lldb-vscode] Reduce chattiness of progress events.
Wed, Apr 14, 1:00 PM · Restricted Project

Tue, Apr 13

wallace added inline comments to D100443: [lldb-vscode] Reduce chattiness of progress events.
Tue, Apr 13, 10:01 PM · Restricted Project
wallace updated the summary of D100443: [lldb-vscode] Reduce chattiness of progress events.
Tue, Apr 13, 9:52 PM · Restricted Project
wallace requested review of D100443: [lldb-vscode] Reduce chattiness of progress events.
Tue, Apr 13, 9:50 PM · Restricted Project

Mon, Apr 12

wallace updated the diff for D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.

updated minor python detail

Mon, Apr 12, 1:29 PM
wallace updated the diff for D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.

Address comments

Mon, Apr 12, 1:26 PM
wallace added a reviewer for D100340: [lldb-vscode] Add postRunCommands: kusmour.
Mon, Apr 12, 1:09 PM · Restricted Project
wallace requested review of D100340: [lldb-vscode] Add postRunCommands.
Mon, Apr 12, 1:05 PM · Restricted Project

Wed, Apr 7

wallace updated the summary of D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Wed, Apr 7, 11:36 AM
wallace updated the diff for D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.

Some changes:

Wed, Apr 7, 11:35 AM
wallace updated the diff for D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.

Address comments

Wed, Apr 7, 10:00 AM

Tue, Apr 6

wallace updated the summary of D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Tue, Apr 6, 1:32 PM
wallace requested review of D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Tue, Apr 6, 1:30 PM
wallace updated the summary of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:49 AM
wallace updated the summary of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:49 AM
wallace updated the summary of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:42 AM
wallace requested review of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:29 AM

Wed, Mar 31

wallace accepted D99701: [lldb-vscode] Consistently use return EXIT_SUCCESS and EXIT_FAILURE (NFC).
Wed, Mar 31, 9:33 PM · Restricted Project
wallace accepted D99702: [lldb-vscode] Use LLVM's ScopeExit to ensure we always terminate the debugger.
Wed, Mar 31, 9:32 PM · Restricted Project

Tue, Mar 30

wallace committed rGa4ee79c8ae5c: Fix errors in 0b69756110db444282c40ea16929186b2910c3b1 (authored by wallace).
Fix errors in 0b69756110db444282c40ea16929186b2910c3b1
Tue, Mar 30, 6:03 PM
wallace committed rG0b69756110db: [trace][intel-pt] Implement trace start and trace stop (authored by wallace).
[trace][intel-pt] Implement trace start and trace stop
Tue, Mar 30, 5:32 PM
wallace closed D91679: [trace][intel-pt] Implement trace start and trace stop.
Tue, Mar 30, 5:31 PM · Restricted Project
wallace added a comment to D91679: [trace][intel-pt] Implement trace start and trace stop.

I like that idea, but i'd rather do it in a different patch once we have a second stop event, so that I make sure the entire thing makes sense.

Tue, Mar 30, 5:06 PM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

Addresses all issues, following our offline discussion.

Tue, Mar 30, 2:50 PM · Restricted Project

Mon, Mar 29

wallace accepted D99535: [lldb] Print stack trace when lldb-vscode crashes.
Mon, Mar 29, 2:18 PM · Restricted Project

Thu, Mar 25

wallace updated the summary of D91679: [trace][intel-pt] Implement trace start and trace stop.
Thu, Mar 25, 9:57 PM · Restricted Project
wallace updated the summary of D91679: [trace][intel-pt] Implement trace start and trace stop.
Thu, Mar 25, 9:55 PM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

Updates in the diff description

Thu, Mar 25, 9:53 PM · Restricted Project

Mar 18 2021

wallace reclaimed D91679: [trace][intel-pt] Implement trace start and trace stop.

Changed my mind :)

Mar 18 2021, 12:21 PM · Restricted Project
wallace abandoned D91679: [trace][intel-pt] Implement trace start and trace stop.

I'll redo this diff in smaller diffs

Mar 18 2021, 11:17 AM · Restricted Project

Mar 15 2021

wallace updated the diff for D98656: [lldb-vscode] Handle request_evaluate's context attribute.

address comment

Mar 15 2021, 3:05 PM · Restricted Project
wallace requested review of D98656: [lldb-vscode] Handle request_evaluate's context attribute.
Mar 15 2021, 1:08 PM · Restricted Project

Mar 5 2021

wallace added a comment to D97739: Add a progress class that can track and report long running operations that happen in LLDB..

I think that the mechanism used to show progress should be lock-free and mostly unblocked, as it's merely an observer without side effects within LLDB. So from the last thing you said it seems that SBEvent doesn't like a good solution.

Mar 5 2021, 3:07 PM · Restricted Project
wallace added a comment to D97739: Add a progress class that can track and report long running operations that happen in LLDB..

I'm quite happy with it besides the multiple callback thing.

Mar 5 2021, 11:01 AM · Restricted Project

Mar 4 2021

wallace added a comment to D97739: Add a progress class that can track and report long running operations that happen in LLDB..

This looks really nice. The only thought I have is that you should accept multiple callbacks instead of only one, as the current implementation discards any existing callback if SetProgressCallback is called twice. I know that it'd be rare that two or more callbacks are registered simultaneously, but it might happen in the future and you could save someone's time by making this a little bit more flexible.

Mar 4 2021, 1:43 PM · Restricted Project

Feb 4 2021

wallace updated subscribers of D96060: [lldb-vscode] correctly use Windows macros.

I don't feel knowledgeable enough to backport the commit, so if you can do
it, it would be great :)

Feb 4 2021, 4:11 PM · Restricted Project
wallace committed rG36496cc2992d: [lldb-vscode] correctly use Windows macros (authored by wallace).
[lldb-vscode] correctly use Windows macros
Feb 4 2021, 11:04 AM
wallace closed D96060: [lldb-vscode] correctly use Windows macros.
Feb 4 2021, 11:03 AM · Restricted Project
wallace requested review of D96060: [lldb-vscode] correctly use Windows macros.
Feb 4 2021, 10:09 AM · Restricted Project

Jan 28 2021

wallace committed rG0bca9a7ce2ee: Fix lldb-vscode builds on Windows targeting POSIX (authored by wallace).
Fix lldb-vscode builds on Windows targeting POSIX
Jan 28 2021, 9:36 AM

Jan 27 2021

wallace added a comment to rGab5591e1d8f5: Fix runInTerminal failures on Windows.

Damn, I gotta fix that

Jan 27 2021, 3:29 PM
wallace added a comment to rGab5591e1d8f5: Fix runInTerminal failures on Windows.

I think that's because I'm not running all the tests for Debug builds, as they would timeout. I've noticed that an error is due to the use of capture_output when doing Popen, but I use subprocess in other places as well for this feature, so I want to first set up my environment for using python3.6 and making sure everything works well.

Jan 27 2021, 1:29 PM
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

@stella.stamenova , I've just pushed a fix. Let me know if it actually works.

Jan 27 2021, 1:17 PM · Restricted Project
wallace committed rGab5591e1d8f5: Fix runInTerminal failures on Windows (authored by wallace).
Fix runInTerminal failures on Windows
Jan 27 2021, 1:17 PM
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

Good to know. I'll work on that right now. Thanks!

Jan 27 2021, 11:49 AM · Restricted Project

Jan 26 2021

wallace added inline comments to D91679: [trace][intel-pt] Implement trace start and trace stop.
Jan 26 2021, 6:33 PM · Restricted Project
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

I'll send a diff tomorrow morning

Jan 26 2021, 3:30 PM · Restricted Project
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

@stella.stamenova , is that build a Debug or Release build? I think that will help me determine why it's failing

Jan 26 2021, 2:38 PM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

clang-format

Jan 26 2021, 9:46 AM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

rebase and fix compile error on Darwin

Jan 26 2021, 9:34 AM · Restricted Project

Jan 25 2021

wallace committed rG50337fb933e0: Fix runInTerminal errors on ARM (authored by wallace).
Fix runInTerminal errors on ARM
Jan 25 2021, 2:55 PM
wallace updated subscribers of D93951: [vscode] Improve runInTerminal and support linux.

I've already submitted a fix, let's see if the buildbot gets fixed

Jan 25 2021, 2:30 PM · Restricted Project
wallace closed D93874: [process] fix exec support on Linux.
Jan 25 2021, 2:10 PM · Restricted Project
wallace committed rG1ac36b34db81: Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6 (authored by wallace).
Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6
Jan 25 2021, 2:06 PM
wallace committed rG12049d888595: Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6 (authored by wallace).
Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6
Jan 25 2021, 1:25 PM
wallace committed rG0f0462cacf34: [vscode] Improve runInTerminal and support linux (authored by wallace).
[vscode] Improve runInTerminal and support linux
Jan 25 2021, 12:30 PM
wallace closed D93951: [vscode] Improve runInTerminal and support linux.
Jan 25 2021, 12:30 PM · Restricted Project
wallace committed rG4bb6244871c6: [ThreadPlan] fix exec on Linux (authored by wallace).
[ThreadPlan] fix exec on Linux
Jan 25 2021, 11:31 AM
wallace updated the diff for D93874: [process] fix exec support on Linux.

apply suggestion

Jan 25 2021, 11:18 AM · Restricted Project
wallace added inline comments to D93874: [process] fix exec support on Linux.
Jan 25 2021, 11:17 AM · Restricted Project

Jan 22 2021

wallace updated the diff for D93874: [process] fix exec support on Linux.

Updated based on @jingham's idea, and added an independent test for this.

Jan 22 2021, 1:35 PM · Restricted Project
wallace added a comment to D93874: [process] fix exec support on Linux.

Jim, thanks for the pointers! I think we are getting close to the issue. After doing what you asked, I found out the following:

Jan 22 2021, 8:53 AM · Restricted Project

Jan 21 2021

wallace updated subscribers of D93874: [process] fix exec support on Linux.

I've tried to find a way to move the calls the way you mentioned, but it
doesn't seem trivial.

Jan 21 2021, 4:28 PM · Restricted Project
wallace committed rG39239f9b5666: [lldb-vscode] improve modules request (authored by wallace).
[lldb-vscode] improve modules request
Jan 21 2021, 1:19 PM
wallace closed D94033: [lldb-vscode] improve modules request.
Jan 21 2021, 1:19 PM · Restricted Project
wallace added a comment to D93874: [process] fix exec support on Linux.

Sorry for returning late to this diff, but I have some additional information. This is what's happening:

Jan 21 2021, 12:51 PM · Restricted Project

Jan 11 2021

wallace added a comment to D93874: [process] fix exec support on Linux.

I've done a lightweight test and it seems that the BaseThreadPlan is being asked for the stop reason when the exec happens, but it holds a reference to the thread whose destructor has been called, which causes the crash. On Darwin, as Greg said, the BaseThreadPlan is deleted when the thread changes, so this doesn't happen.
Later this week I'll spend more time gathering logs and I'll share them here in a nice format.

Jan 11 2021, 10:01 PM · Restricted Project
wallace added a comment to D93874: [process] fix exec support on Linux.

@jingham, friendly ping :)

Jan 11 2021, 10:34 AM · Restricted Project

Jan 9 2021

wallace updated the diff for D93951: [vscode] Improve runInTerminal and support linux.

improve tests

Jan 9 2021, 11:19 PM · Restricted Project
wallace updated the diff for D93951: [vscode] Improve runInTerminal and support linux.

Addressed all comments:

Jan 9 2021, 10:29 PM · Restricted Project

Jan 8 2021

wallace updated the diff for D93951: [vscode] Improve runInTerminal and support linux.

Followed all the suggestions:

Jan 8 2021, 3:08 PM · Restricted Project

Jan 7 2021

wallace added inline comments to D93951: [vscode] Improve runInTerminal and support linux.
Jan 7 2021, 10:18 AM · Restricted Project
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

I'll think about just writing this as tcp sockets. That would for sure be cross platform

Jan 7 2021, 10:00 AM · Restricted Project
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

I'll follow your recommendations.

Jan 7 2021, 9:43 AM · Restricted Project

Jan 6 2021

wallace updated the diff for D93951: [vscode] Improve runInTerminal and support linux.

Address all comments.

Jan 6 2021, 4:03 PM · Restricted Project

Jan 4 2021

wallace added inline comments to D93874: [process] fix exec support on Linux.
Jan 4 2021, 2:40 PM · Restricted Project
wallace updated the summary of D94033: [lldb-vscode] improve modules request.
Jan 4 2021, 2:24 PM · Restricted Project
wallace requested review of D94033: [lldb-vscode] improve modules request.
Jan 4 2021, 2:13 PM · Restricted Project
wallace added inline comments to D93874: [process] fix exec support on Linux.
Jan 4 2021, 11:04 AM · Restricted Project

Dec 30 2020

wallace updated the summary of D93951: [vscode] Improve runInTerminal and support linux.
Dec 30 2020, 3:08 PM · Restricted Project
wallace updated the diff for D93951: [vscode] Improve runInTerminal and support linux.

nit

Dec 30 2020, 3:07 PM · Restricted Project
wallace requested review of D93951: [vscode] Improve runInTerminal and support linux.
Dec 30 2020, 3:03 PM · Restricted Project
wallace abandoned D93744: [lldb-vscode] Support processId returned by the IDE in the runInTerminal request.
Dec 30 2020, 2:43 PM · Restricted Project

Dec 29 2020

wallace updated the diff for D93874: [process] fix exec support on Linux.

nit

Dec 29 2020, 3:53 PM · Restricted Project
wallace updated the summary of D93874: [process] fix exec support on Linux.
Dec 29 2020, 12:07 PM · Restricted Project
wallace updated the diff for D93874: [process] fix exec support on Linux.

Updated the description of the diff. It was actually very easy to find a deterministic reproduction of the failure. And the diff is actually minimal now.

Dec 29 2020, 11:59 AM · Restricted Project
wallace planned changes to D93874: [process] fix exec support on Linux.
Dec 29 2020, 11:27 AM · Restricted Project

Dec 28 2020

wallace updated the diff for D93874: [process] fix exec support on Linux.

improve test

Dec 28 2020, 2:45 PM · Restricted Project
wallace updated the summary of D93874: [process] fix exec support on Linux.
Dec 28 2020, 2:13 PM · Restricted Project
wallace requested review of D93874: [process] fix exec support on Linux.
Dec 28 2020, 2:09 PM · Restricted Project

Dec 22 2020

wallace planned changes to D93744: [lldb-vscode] Support processId returned by the IDE in the runInTerminal request.
Dec 22 2020, 10:39 PM · Restricted Project
wallace requested review of D93744: [lldb-vscode] Support processId returned by the IDE in the runInTerminal request.
Dec 22 2020, 10:34 PM · Restricted Project
wallace planned changes to D93744: [lldb-vscode] Support processId returned by the IDE in the runInTerminal request.
Dec 22 2020, 10:18 PM · Restricted Project