Page MenuHomePhabricator

wallace (walter erquinigo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 10:57 AM (187 w, 3 d)

Recent Activity

Nov 12 2019

wallace updated the diff for D69873: [lldb-vscode] support the completion request.

set a return list limit of 50

Nov 12 2019, 12:10 PM · Restricted Project

Nov 6 2019

wallace updated the diff for D69873: [lldb-vscode] support the completion request.

nit

Nov 6 2019, 9:13 AM · Restricted Project
wallace updated the diff for D69873: [lldb-vscode] support the completion request.

removed the results limit of 20 because it didn't work and I verified that returning a long list is displayed well on vscode. There's no need for this limit at this point.
I also tested the cases that @teemperor mentioned and all of them work on vscode. I also added them as test cases.

Nov 6 2019, 8:54 AM · Restricted Project

Nov 5 2019

wallace updated the summary of D69873: [lldb-vscode] support the completion request.
Nov 5 2019, 5:53 PM · Restricted Project
wallace updated the summary of D69873: [lldb-vscode] support the completion request.
Nov 5 2019, 5:43 PM · Restricted Project
wallace created D69873: [lldb-vscode] support the completion request.
Nov 5 2019, 5:43 PM · Restricted Project

Nov 4 2019

wallace added inline comments to D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands.
Nov 4 2019, 9:41 AM · Restricted Project, Restricted Project
wallace closed D68968: [android/process info] Introduce display_name.
Nov 4 2019, 9:41 AM · Restricted Project

Oct 28 2019

wallace updated the diff for D68968: [android/process info] Introduce display_name.

now reading from comm

Oct 28 2019, 1:33 PM · Restricted Project
wallace added inline comments to D68968: [android/process info] Introduce display_name.
Oct 28 2019, 11:35 AM · Restricted Project

Oct 24 2019

wallace accepted D69400: [lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'.

cool! thanks!!

Oct 24 2019, 12:36 PM · Restricted Project
wallace added a comment to D69400: [lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'.

Supposedly Arguments shouldn't contain Arg0 (https://reviews.llvm.org/source/llvm-github/browse/master/lldb/include/lldb/Utility/ProcessInfo.h$96)
I think you just need to change the dump method that prints to platform process list.

Oct 24 2019, 11:32 AM · Restricted Project

Oct 21 2019

wallace updated the diff for D68968: [android/process info] Introduce display_name.

now using display_name instead of bundle_id. I've also changed the diff title and description

Oct 21 2019, 1:36 PM · Restricted Project

Oct 18 2019

wallace added a comment to D68968: [android/process info] Introduce display_name.

man, thanks for your feedback!
Indeed, i was trying to solve some problems that don't exist yet. Later when I add apk debugging support, I'll figure out what's the best way to retrieve apk specific information, but for now display_name is more than enough

Oct 18 2019, 9:25 AM · Restricted Project

Oct 17 2019

wallace added a comment to D68968: [android/process info] Introduce display_name.

Thanks for your feedback and to @clayborg for an offline discussion we had.

Oct 17 2019, 3:34 PM · Restricted Project
wallace committed rGe19dfa6745f6: Disable TestProcessList on windows (authored by wallace).
Disable TestProcessList on windows
Oct 17 2019, 10:52 AM
wallace closed D69114: Disable TestProcessList on windows.
Oct 17 2019, 10:52 AM · Restricted Project
wallace committed rL375144: Disable TestProcessList on windows.
Disable TestProcessList on windows
Oct 17 2019, 10:52 AM
wallace updated the diff for D69114: Disable TestProcessList on windows.

added bug link in the comment

Oct 17 2019, 10:52 AM · Restricted Project
wallace added a comment to D69114: Disable TestProcessList on windows.

oh girl, i need to get a bugzilla account. I hope i can get it soon. If it takes too long I can send another patch with the updated comment

Oct 17 2019, 10:04 AM · Restricted Project
wallace updated the summary of D69114: Disable TestProcessList on windows.
Oct 17 2019, 9:37 AM · Restricted Project
wallace created D69114: Disable TestProcessList on windows.
Oct 17 2019, 9:37 AM · Restricted Project

Oct 16 2019

wallace committed rG48a50ee0344d: [android/process list] support showing process arguments (authored by wallace).
[android/process list] support showing process arguments
Oct 16 2019, 11:53 AM
wallace closed D68293: [android/process list] support showing process arguments.
Oct 16 2019, 11:53 AM · Restricted Project
wallace committed rL375029: [android/process list] support showing process arguments.
[android/process list] support showing process arguments
Oct 16 2019, 11:52 AM
wallace planned changes to D68968: [android/process info] Introduce display_name.
Oct 16 2019, 11:24 AM · Restricted Project
wallace added inline comments to D68968: [android/process info] Introduce display_name.
Oct 16 2019, 11:24 AM · Restricted Project
wallace updated the diff for D68293: [android/process list] support showing process arguments.

addressed comments

Oct 16 2019, 11:05 AM · Restricted Project
wallace added inline comments to D68293: [android/process list] support showing process arguments.
Oct 16 2019, 10:37 AM · Restricted Project

Oct 15 2019

wallace resigned from D44042: Ensure that trailing characters aren't included in PECOFF section names.
Oct 15 2019, 2:41 PM
wallace updated the diff for D68968: [android/process info] Introduce display_name.

.

Oct 15 2019, 1:46 PM · Restricted Project
wallace retitled D68968: [android/process info] Introduce display_name from [android/process list] use arg0 as fallback for process name to [android/process info] Introduce bundle id.
Oct 15 2019, 1:46 PM · Restricted Project
wallace updated the diff for D68968: [android/process info] Introduce display_name.

nit

Oct 15 2019, 1:46 PM · Restricted Project
wallace updated the diff for D68968: [android/process info] Introduce display_name.

now using bundle_id

Oct 15 2019, 1:46 PM · Restricted Project
wallace updated the diff for D68293: [android/process list] support showing process arguments.

Addressed comments. It turns out from the definition of ProcessInfo that Arguments shuoldn't contain arg0, so I updated the code accordingly.
I ran the test suite locally and I didn't see any failure caused due to that, so it should be okay.

Oct 15 2019, 12:13 PM · Restricted Project
wallace added inline comments to D68293: [android/process list] support showing process arguments.
Oct 15 2019, 12:04 PM · Restricted Project
wallace added inline comments to D68293: [android/process list] support showing process arguments.
Oct 15 2019, 11:26 AM · Restricted Project
wallace updated the diff for D68293: [android/process list] support showing process arguments.

Add end to end test

Oct 15 2019, 10:58 AM · Restricted Project

Oct 14 2019

wallace planned changes to D68968: [android/process info] Introduce display_name.
Oct 14 2019, 11:20 PM · Restricted Project
wallace created D68968: [android/process info] Introduce display_name.
Oct 14 2019, 7:45 PM · Restricted Project
wallace updated the diff for D68293: [android/process list] support showing process arguments.

address comments

Oct 14 2019, 7:18 PM · Restricted Project
wallace committed rGd04855f820c5: [lldb-server/android] Show more processes by relaxing some checks (authored by wallace).
[lldb-server/android] Show more processes by relaxing some checks
Oct 14 2019, 5:01 PM
wallace committed rL374853: [lldb-server/android] Show more processes by relaxing some checks.
[lldb-server/android] Show more processes by relaxing some checks
Oct 14 2019, 5:00 PM
wallace committed rG1473b9f2052e: Revert "fix" (authored by wallace).
Revert "fix"
Oct 14 2019, 5:00 PM
wallace closed D68289: [lldb-server/android] Show more processes by relaxing some checks.
Oct 14 2019, 5:00 PM · Restricted Project, Restricted Project
wallace committed rL374852: Revert "fix".
Revert "fix"
Oct 14 2019, 5:00 PM
wallace committed rGed57fb7665e5: fix (authored by wallace).
fix
Oct 14 2019, 4:33 PM
wallace closed D68354: [platform process list] add a flag for showing the processes of all users.
Oct 14 2019, 4:32 PM · Restricted Project
wallace committed rL374846: fix.
fix
Oct 14 2019, 4:30 PM
wallace updated the diff for D68289: [lldb-server/android] Show more processes by relaxing some checks.

rebase

Oct 14 2019, 4:29 PM · Restricted Project, Restricted Project

Oct 11 2019

wallace committed rGaf1d27e3011a: [platform process list] add a flag for showing the processes of all users (authored by wallace).
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 7:37 PM
wallace committed rG0f2295589987: Revert "[platform process list] add a flag for showing the processes of all… (authored by wallace).
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 7:37 PM
wallace committed rL374631: [platform process list] add a flag for showing the processes of all users.
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 7:37 PM
wallace committed rL374630: Revert "[platform process list] add a flag for showing the processes of all….
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 7:36 PM
wallace updated the diff for D68354: [platform process list] add a flag for showing the processes of all users.

i think i finally wrote something that works python 2 and 3

Oct 11 2019, 7:36 PM · Restricted Project
wallace committed rGd334b78f25cd: [platform process list] add a flag for showing the processes of all users (authored by wallace).
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 7:09 PM
wallace committed rG892482eb9cb3: Revert "[platform process list] add a flag for showing the processes of all… (authored by wallace).
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 7:09 PM
wallace committed rL374626: [platform process list] add a flag for showing the processes of all users.
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 7:09 PM
wallace updated the diff for D68354: [platform process list] add a flag for showing the processes of all users.

after the logging finally found the bug, it's was an encoding issue due to a different python version

Oct 11 2019, 7:09 PM · Restricted Project
wallace committed rL374625: Revert "[platform process list] add a flag for showing the processes of all….
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 7:00 PM
wallace committed rGe031bdfefad0: [platform process list] add a flag for showing the processes of all users (authored by wallace).
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 6:32 PM
wallace committed rL374622: [platform process list] add a flag for showing the processes of all users.
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 6:32 PM
wallace updated the diff for D68354: [platform process list] add a flag for showing the processes of all users.

adding some logging for exceptions in the mock server

Oct 11 2019, 6:32 PM · Restricted Project
wallace committed rG16194bf8bff9: Revert "[platform process list] add a flag for showing the processes of all… (authored by wallace).
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 6:14 PM
wallace committed rL374621: Revert "[platform process list] add a flag for showing the processes of all….
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 6:14 PM
wallace committed rG914f38295e12: [platform process list] add a flag for showing the processes of all users (authored by wallace).
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 5:47 PM
wallace committed rL374620: [platform process list] add a flag for showing the processes of all users.
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 5:47 PM
wallace updated the diff for D68354: [platform process list] add a flag for showing the processes of all users.

another try

Oct 11 2019, 5:47 PM · Restricted Project
wallace committed rG696d3cf8ad6f: [platform process list] add a flag for showing the processes of all users (authored by wallace).
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 4:15 PM
wallace committed rL374609: [platform process list] add a flag for showing the processes of all users.
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 4:15 PM
wallace updated the diff for D68354: [platform process list] add a flag for showing the processes of all users.
  • update
Oct 11 2019, 4:14 PM · Restricted Project
wallace committed rG6fcf0681609f: Revert "[platform process list] add a flag for showing the processes of all… (authored by wallace).
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 3:01 PM
wallace committed rL374603: Revert "[platform process list] add a flag for showing the processes of all….
Revert "[platform process list] add a flag for showing the processes of all…
Oct 11 2019, 3:01 PM
wallace abandoned D68883: Revert "[platform process list] add a flag for showing the processes of all users".
Oct 11 2019, 2:59 PM · Restricted Project
wallace added a comment to D68293: [android/process list] support showing process arguments.

i'm reverting it, thanks!

Oct 11 2019, 2:59 PM · Restricted Project
wallace created D68883: Revert "[platform process list] add a flag for showing the processes of all users".
Oct 11 2019, 1:09 PM · Restricted Project
wallace committed rG089a334c39d0: [platform process list] add a flag for showing the processes of all users (authored by wallace).
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 12:42 PM
wallace committed rL374584: [platform process list] add a flag for showing the processes of all users.
[platform process list] add a flag for showing the processes of all users
Oct 11 2019, 12:42 PM
wallace reopened D68289: [lldb-server/android] Show more processes by relaxing some checks.
Oct 11 2019, 12:42 PM · Restricted Project, Restricted Project
wallace updated the diff for D68354: [platform process list] add a flag for showing the processes of all users.

now it should work, the test pass

Oct 11 2019, 12:36 PM · Restricted Project
wallace reopened D68354: [platform process list] add a flag for showing the processes of all users.
Oct 11 2019, 12:36 PM · Restricted Project
wallace closed D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users.

will update the previous diff

Oct 11 2019, 11:46 AM · Restricted Project
wallace added a comment to D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users.

Good suggestion! I'll do that next time

Oct 11 2019, 11:11 AM · Restricted Project

Oct 8 2019

wallace closed D68354: [platform process list] add a flag for showing the processes of all users.

this was reverted

Oct 8 2019, 1:14 PM · Restricted Project
wallace created D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users.
Oct 8 2019, 1:14 PM · Restricted Project
wallace added a comment to D68289: [lldb-server/android] Show more processes by relaxing some checks.

thanks, @labath !

Oct 8 2019, 10:28 AM · Restricted Project, Restricted Project
wallace closed D68312: [gdb-remote] process properly effective uid.

already committed

Oct 8 2019, 10:26 AM · Restricted Project

Oct 7 2019

wallace committed rG8b6dcc1d8ce6: [gdb-remote] process properly effective uid (authored by wallace).
[gdb-remote] process properly effective uid
Oct 7 2019, 10:19 PM
wallace committed rL373953: [gdb-remote] process properly effective uid.
[gdb-remote] process properly effective uid
Oct 7 2019, 10:19 PM
wallace committed rG6e1a0cf46bae: [platform process list] add a flag for showing the processes of all users (authored by wallace).
[platform process list] add a flag for showing the processes of all users
Oct 7 2019, 10:16 PM
wallace committed rL373931: [platform process list] add a flag for showing the processes of all users.
[platform process list] add a flag for showing the processes of all users
Oct 7 2019, 10:16 PM
wallace added a comment to D68354: [platform process list] add a flag for showing the processes of all users.

damn, i'll rebase and try to fix it

Oct 7 2019, 2:57 PM · Restricted Project
wallace added inline comments to D68354: [platform process list] add a flag for showing the processes of all users.
Oct 7 2019, 10:46 AM · Restricted Project

Oct 5 2019

wallace updated the diff for D68293: [android/process list] support showing process arguments.

added a test

Oct 5 2019, 10:18 AM · Restricted Project

Oct 4 2019

wallace updated the diff for D68312: [gdb-remote] process properly effective uid.

added a test

Oct 4 2019, 7:16 PM · Restricted Project
wallace updated the diff for D68354: [platform process list] add a flag for showing the processes of all users.

added a basic python test

Oct 4 2019, 6:57 PM · Restricted Project
wallace added a comment to D68293: [android/process list] support showing process arguments.

damn, i overwrote this patch lol

Oct 4 2019, 6:53 PM · Restricted Project
wallace updated the diff for D68293: [android/process list] support showing process arguments.

added a basic python test

Oct 4 2019, 6:49 PM · Restricted Project
wallace closed D68314: [process info] Remove assert in DoGetGroupName.

This has been committed

Oct 4 2019, 10:26 AM · Restricted Project
wallace committed rG9819b9d35fad: [process info] Remove assert in DoGetGroupName (authored by wallace).
[process info] Remove assert in DoGetGroupName
Oct 4 2019, 9:58 AM