I'll take a look at this later tonight or tomorrow

yep, there's no need for the realpath
Thanks!

nit

Thanks!

thanks. Your explanation of why the verbose error is useful was good :)

address issues and comments

pretty good! I just left cosmetic requests

.

nice. I expected something as simple as that

• address all comments
• turn all the structs into classes with safe accessors

nit

nits

Thanks!!

Lgtm!

update

improve documentation

nit

That's important to know. At least in this case this code only runs on Linux, so hopefully we are good with the atomic static initialization.

simplify this diff following @labath's advice

nice job! Now you just need to connect it with the collector :)

almost there!

use an idea similar to labath's to simplify this code while still using call_once

yaay

just some minor cosmetic changes :)

great!

qq: Do we plan to add this kernel tracing support for live tracing as well?

pretty nice!! Just some few minor changes and good to go

great! that will make all the bindings very easy to handle

Are the files in lldb/test/API/commands/trace/intelpt-kernel-trace/cores/ actual kernel traces? If not, just use some trace files that are already present in the repo. You can use relative paths of the form ../../trace_sample/cores/... to refer to them.

thanks!

just remove that comment. I've just pushed Sujin's diff as well, so you can rebase

Just one more change and good to go

great! thank you. I'll land this

fix a bug that happens when the initial trace items don't have timing information

fix test

final version

.

..

fix nits

I'll remove the unwanted formatting changes

format

I'll commit this for you

almost there! I like the tests btw :)

improve tests

rename 'process trace save' to 'trace save' because it can actually dump the information of multiple processes.

fix tests

improve command handling

make relative all paths being returned in the description file

minor improvements for autocompletion in the CLI

let's try to have tests soon. It seems that the code can be simplified and tests will be very handy

much better! Thanks for doing this.

i can do it right now

thanks!

what happens is that the specific failures are triggered by tests that require the cmake flag LIBIPT_INCLUDE_PATH to be configured, but all good