User Details
- User Since
- May 10 2016, 10:57 AM (358 w, 5 d)
Dec 13 2022
I'll take a look at this later tonight or tomorrow
Nov 18 2022
yep, there's no need for the realpath
Thanks!
Nov 8 2022
Nov 7 2022
nit
Nov 6 2022
Oct 26 2022
Thanks!
Oct 25 2022
thanks. Your explanation of why the verbose error is useful was good :)
Oct 24 2022
address issues and comments
pretty good! I just left cosmetic requests
Oct 23 2022
.
Oct 20 2022
nice. I expected something as simple as that
Oct 15 2022
Oct 14 2022
- address all comments
- turn all the structs into classes with safe accessors
Oct 13 2022
nit
Oct 8 2022
nits
Sep 13 2022
Thanks!!
Lgtm!
Aug 12 2022
update
Aug 10 2022
improve documentation
nit
Aug 8 2022
That's important to know. At least in this case this code only runs on Linux, so hopefully we are good with the atomic static initialization.
Aug 4 2022
simplify this diff following @labath's advice
nice job! Now you just need to connect it with the collector :)
almost there!
Aug 3 2022
use an idea similar to labath's to simplify this code while still using call_once
Aug 2 2022
yaay
just some minor cosmetic changes :)
great!
qq: Do we plan to add this kernel tracing support for live tracing as well?
Aug 1 2022
pretty nice!! Just some few minor changes and good to go
great! that will make all the bindings very easy to handle
Are the files in lldb/test/API/commands/trace/intelpt-kernel-trace/cores/ actual kernel traces? If not, just use some trace files that are already present in the repo. You can use relative paths of the form ../../trace_sample/cores/... to refer to them.
thanks!
Jul 30 2022
Jul 26 2022
just remove that comment. I've just pushed Sujin's diff as well, so you can rebase
Jul 22 2022
Just one more change and good to go
great! thank you. I'll land this
Jul 21 2022
fix a bug that happens when the initial trace items don't have timing information
Jul 20 2022
fix test
final version
.
Jul 19 2022
..
Jul 18 2022
fix nits
Jul 13 2022
I'll remove the unwanted formatting changes
Jul 12 2022
format
I'll commit this for you
Jul 8 2022
almost there! I like the tests btw :)
Jul 7 2022
improve tests
Jul 6 2022
rename 'process trace save' to 'trace save' because it can actually dump the information of multiple processes.
fix tests
improve command handling
make relative all paths being returned in the description file
minor improvements for autocompletion in the CLI
Jul 5 2022
let's try to have tests soon. It seems that the code can be simplified and tests will be very handy
much better! Thanks for doing this.
Jun 29 2022
i can do it right now
thanks!
what happens is that the specific failures are triggered by tests that require the cmake flag LIBIPT_INCLUDE_PATH to be configured, but all good