Page MenuHomePhabricator

wallace (walter erquinigo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 10:57 AM (358 w, 5 d)

Recent Activity

Dec 13 2022

wallace added a comment to D139969: Add a json dumper for call graph reconstructor.

I'll take a look at this later tonight or tomorrow

Dec 13 2022, 2:00 PM · Restricted Project, Restricted Project

Nov 18 2022

wallace accepted D138345: [test][lldb-vscode] Un-realpath coreFile test..

yep, there's no need for the realpath
Thanks!

Nov 18 2022, 8:17 PM · Restricted Project, Restricted Project

Nov 8 2022

wallace accepted D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API.
Nov 8 2022, 10:20 PM · Restricted Project, Restricted Project
wallace added inline comments to D137614: [trace] Add a new call graph reconstructor.
Nov 8 2022, 10:38 AM · Restricted Project, Restricted Project
wallace requested changes to D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API.
Nov 8 2022, 10:13 AM · Restricted Project, Restricted Project

Nov 7 2022

wallace updated the diff for D137614: [trace] Add a new call graph reconstructor.

nit

Nov 7 2022, 11:54 PM · Restricted Project, Restricted Project
wallace requested review of D137614: [trace] Add a new call graph reconstructor.
Nov 7 2022, 11:44 PM · Restricted Project, Restricted Project
wallace accepted D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation.
Nov 7 2022, 9:52 AM · Restricted Project, Restricted Project

Nov 6 2022

wallace added inline comments to D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation.
Nov 6 2022, 3:45 PM · Restricted Project, Restricted Project
wallace added inline comments to D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation.
Nov 6 2022, 2:59 PM · Restricted Project, Restricted Project

Oct 26 2022

wallace accepted D136801: [intelpt] Update Python tests to account for new errrors.

Thanks!

Oct 26 2022, 9:33 PM · Restricted Project, Restricted Project

Oct 25 2022

wallace accepted D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error.

thanks. Your explanation of why the verbose error is useful was good :)

Oct 25 2022, 10:20 AM · Restricted Project, Restricted Project

Oct 24 2022

wallace updated the diff for D136557: [trace][intel pt] Simple detection of infinite decoding loops.

address issues and comments

Oct 24 2022, 5:58 PM · Restricted Project, Restricted Project
wallace added inline comments to D136557: [trace][intel pt] Simple detection of infinite decoding loops.
Oct 24 2022, 5:30 PM · Restricted Project, Restricted Project
wallace requested changes to D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error.

pretty good! I just left cosmetic requests

Oct 24 2022, 10:28 AM · Restricted Project, Restricted Project

Oct 23 2022

wallace updated the diff for D136557: [trace][intel pt] Simple detection of infinite decoding loops.

.

Oct 23 2022, 10:00 PM · Restricted Project, Restricted Project
wallace requested review of D136557: [trace][intel pt] Simple detection of infinite decoding loops.
Oct 23 2022, 10:44 AM · Restricted Project, Restricted Project

Oct 20 2022

wallace accepted D136371: [trace][intel pt] Correctly treat kernel CPUs as individual threads.

nice. I expected something as simple as that

Oct 20 2022, 12:50 PM · Restricted Project, Restricted Project

Oct 15 2022

wallace requested review of D136034: [lldb][trace] Add a basic function call dump [3] - Add a JSON dumper.
Oct 15 2022, 10:53 PM · Restricted Project, Restricted Project

Oct 14 2022

wallace updated the diff for D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm.
  • address all comments
  • turn all the structs into classes with safe accessors
Oct 14 2022, 2:18 PM · Restricted Project, Restricted Project
wallace added inline comments to D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm.
Oct 14 2022, 2:18 PM · Restricted Project, Restricted Project

Oct 13 2022

wallace updated the diff for D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm.

nit

Oct 13 2022, 2:19 PM · Restricted Project, Restricted Project
wallace updated the summary of D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm.
Oct 13 2022, 2:17 PM · Restricted Project, Restricted Project
wallace requested review of D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm.
Oct 13 2022, 2:15 PM · Restricted Project, Restricted Project

Oct 8 2022

wallace updated the diff for D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding.

nits

Oct 8 2022, 4:48 PM · Restricted Project, Restricted Project
wallace retitled D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding from [lldb][trace] Add a basic function call dumpdump [1] - Add the command scaffolding to [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding.
Oct 8 2022, 4:47 PM · Restricted Project, Restricted Project
wallace requested review of D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding.
Oct 8 2022, 2:18 PM · Restricted Project, Restricted Project

Sep 13 2022

wallace added a comment to D133778: Fix LLDB build on old Linux kernels (pre-4.1).

Thanks!!

Sep 13 2022, 9:14 AM · Restricted Project, Restricted Project
wallace accepted D133778: Fix LLDB build on old Linux kernels (pre-4.1).

Lgtm!

Sep 13 2022, 9:14 AM · Restricted Project, Restricted Project

Aug 12 2022

wallace updated the diff for D131630: [trace][intel pt] Fix per-psb packet decoding.

update

Aug 12 2022, 3:13 PM · Restricted Project, Restricted Project
wallace added inline comments to D131630: [trace][intel pt] Fix per-psb packet decoding.
Aug 12 2022, 1:21 PM · Restricted Project, Restricted Project

Aug 10 2022

wallace updated the diff for D131630: [trace][intel pt] Fix per-psb packet decoding.

improve documentation

Aug 10 2022, 5:02 PM · Restricted Project, Restricted Project
wallace updated the diff for D131630: [trace][intel pt] Fix per-psb packet decoding.

nit

Aug 10 2022, 4:21 PM · Restricted Project, Restricted Project
wallace requested review of D131630: [trace][intel pt] Fix per-psb packet decoding.
Aug 10 2022, 4:15 PM · Restricted Project, Restricted Project

Aug 8 2022

wallace added a comment to D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo.

That's important to know. At least in this case this code only runs on Linux, so hopefully we are good with the atomic static initialization.

Aug 8 2022, 1:59 PM · Restricted Project, Restricted Project

Aug 4 2022

wallace updated the diff for D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo.

simplify this diff following @labath's advice

Aug 4 2022, 10:08 PM · Restricted Project, Restricted Project
wallace accepted D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.

nice job! Now you just need to connect it with the collector :)

Aug 4 2022, 3:03 PM · Restricted Project, Restricted Project
wallace added inline comments to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.
Aug 4 2022, 2:53 PM · Restricted Project, Restricted Project
wallace requested changes to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.

almost there!

Aug 4 2022, 2:12 PM · Restricted Project, Restricted Project
wallace added inline comments to D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo.
Aug 4 2022, 10:40 AM · Restricted Project, Restricted Project

Aug 3 2022

wallace updated the diff for D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo.

use an idea similar to labath's to simplify this code while still using call_once

Aug 3 2022, 11:09 AM · Restricted Project, Restricted Project
wallace requested review of D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo.
Aug 3 2022, 10:01 AM · Restricted Project, Restricted Project

Aug 2 2022

wallace added inline comments to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.
Aug 2 2022, 4:38 PM · Restricted Project, Restricted Project
wallace accepted D130930: [trace] Add SBTraceCursor bindings.

yaay

Aug 2 2022, 4:37 PM · Restricted Project, Restricted Project
wallace requested changes to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.

just some minor cosmetic changes :)

Aug 2 2022, 4:36 PM · Restricted Project, Restricted Project
wallace accepted D131005: [LLDB] Add SBInstruction::GetControlFlowKind().

great!

Aug 2 2022, 12:36 PM · Restricted Project, Restricted Project
wallace added inline comments to D130930: [trace] Add SBTraceCursor bindings.
Aug 2 2022, 12:30 PM · Restricted Project, Restricted Project
wallace added inline comments to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.
Aug 2 2022, 12:23 PM · Restricted Project, Restricted Project
wallace added a comment to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.

qq: Do we plan to add this kernel tracing support for live tracing as well?

Aug 2 2022, 12:03 PM · Restricted Project, Restricted Project

Aug 1 2022

wallace requested changes to D130930: [trace] Add SBTraceCursor bindings.

pretty nice!! Just some few minor changes and good to go

Aug 1 2022, 1:12 PM · Restricted Project, Restricted Project
wallace accepted D130925: [trace] Replace TraceCursorUP with TraceCursorSP.

great! that will make all the bindings very easy to handle

Aug 1 2022, 12:10 PM · Restricted Project, Restricted Project
wallace requested changes to D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.

Are the files in lldb/test/API/commands/trace/intelpt-kernel-trace/cores/ actual kernel traces? If not, just use some trace files that are already present in the repo. You can use relative paths of the form ../../trace_sample/cores/... to refer to them.

Aug 1 2022, 12:04 PM · Restricted Project, Restricted Project
wallace accepted D130924: [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes.

thanks!

Aug 1 2022, 11:48 AM · Restricted Project, Restricted Project

Jul 30 2022

wallace retitled D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema from Support a new kernel section in LLDB’s trace bundle schema to [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema.
Jul 30 2022, 4:07 PM · Restricted Project, Restricted Project

Jul 26 2022

wallace accepted D130607: [trace] Add instruction control flow kind to JSON trace dumper's output.
Jul 26 2022, 5:26 PM · Restricted Project, Restricted Project
wallace accepted D130580: Refactor string conversion for InstructionControlFlowKind enum.

just remove that comment. I've just pushed Sujin's diff as well, so you can rebase

Jul 26 2022, 11:51 AM · Restricted Project, Restricted Project

Jul 22 2022

wallace added a comment to D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp.

Just one more change and good to go

Jul 22 2022, 9:52 PM · Restricted Project, Restricted Project
wallace accepted D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp.

great! thank you. I'll land this

Jul 22 2022, 8:42 AM · Restricted Project, Restricted Project

Jul 21 2022

wallace updated the diff for D130054: [trace][intel pt] Introduce wall clock time for each trace item.

fix a bug that happens when the initial trace items don't have timing information

Jul 21 2022, 9:40 AM · Restricted Project, Restricted Project

Jul 20 2022

wallace updated the summary of D130054: [trace][intel pt] Introduce wall clock time for each trace item.
Jul 20 2022, 5:33 PM · Restricted Project, Restricted Project
wallace added inline comments to D130054: [trace][intel pt] Introduce wall clock time for each trace item.
Jul 20 2022, 5:32 PM · Restricted Project, Restricted Project
wallace updated the diff for D130054: [trace][intel pt] Introduce wall clock time for each trace item.

fix test

Jul 20 2022, 5:28 PM · Restricted Project, Restricted Project
wallace updated the diff for D130054: [trace][intel pt] Introduce wall clock time for each trace item.

final version

Jul 20 2022, 5:14 PM · Restricted Project, Restricted Project
wallace updated the diff for D130054: [trace][intel pt] Introduce wall clock time for each trace item.

.

Jul 20 2022, 3:31 PM · Restricted Project, Restricted Project
wallace planned changes to D130054: [trace][intel pt] Introduce wall clock time for each trace item.
Jul 20 2022, 12:20 AM · Restricted Project, Restricted Project

Jul 19 2022

wallace updated the diff for D130054: [trace][intel pt] Introduce wall clock time for each trace item.

..

Jul 19 2022, 4:38 PM · Restricted Project, Restricted Project

Jul 18 2022

wallace added reviewers for D130054: [trace][intel pt] Introduce wall clock time for each trace item: jj10306, persona0220.
Jul 18 2022, 5:36 PM · Restricted Project, Restricted Project
wallace updated the diff for D130054: [trace][intel pt] Introduce wall clock time for each trace item.

fix nits

Jul 18 2022, 5:36 PM · Restricted Project, Restricted Project
wallace requested review of D130054: [trace][intel pt] Introduce wall clock time for each trace item.
Jul 18 2022, 5:29 PM · Restricted Project, Restricted Project

Jul 13 2022

wallace requested review of D129257: [trace][intel pt] Add a cgroup filter.
Jul 13 2022, 12:00 PM · Restricted Project, Restricted Project
wallace added inline comments to D129257: [trace][intel pt] Add a cgroup filter.
Jul 13 2022, 12:00 PM · Restricted Project, Restricted Project
wallace requested review of D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper.
Jul 13 2022, 11:53 AM · Restricted Project, Restricted Project
wallace added inline comments to D129239: [trace] Add an option to save a compact trace bundle.
Jul 13 2022, 11:36 AM · Restricted Project, Restricted Project
wallace added a comment to D129239: [trace] Add an option to save a compact trace bundle.

I'll remove the unwanted formatting changes

Jul 13 2022, 11:33 AM · Restricted Project, Restricted Project

Jul 12 2022

wallace updated the summary of D129613: [trace][intel pt] Add a nice parser for the trace size.
Jul 12 2022, 6:32 PM · Restricted Project, Restricted Project
wallace updated the diff for D129613: [trace][intel pt] Add a nice parser for the trace size.

format

Jul 12 2022, 6:30 PM · Restricted Project, Restricted Project
wallace requested review of D129613: [trace][intel pt] Add a nice parser for the trace size.
Jul 12 2022, 6:19 PM · Restricted Project, Restricted Project
wallace requested review of D129588: [trace] Avoid a crash in the dumper when disassembling fails.
Jul 12 2022, 1:14 PM · Restricted Project, Restricted Project
wallace accepted D128477: [trace] Add a flag to the decoder to output the instruction type.

I'll commit this for you

Jul 12 2022, 12:30 PM · Restricted Project, Restricted Project

Jul 8 2022

wallace requested changes to D128477: [trace] Add a flag to the decoder to output the instruction type.

almost there! I like the tests btw :)

Jul 8 2022, 12:56 PM · Restricted Project, Restricted Project

Jul 7 2022

wallace updated the summary of D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper.
Jul 7 2022, 6:45 PM · Restricted Project, Restricted Project
wallace requested review of D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper.
Jul 7 2022, 6:45 PM · Restricted Project, Restricted Project
wallace updated the diff for D129332: [trace][intel pt] Support dumping the trace info in json.

improve tests

Jul 7 2022, 5:46 PM · Restricted Project, Restricted Project
wallace requested review of D129332: [trace][intel pt] Support dumping the trace info in json.
Jul 7 2022, 2:56 PM · Restricted Project, Restricted Project
wallace updated the summary of D129257: [trace][intel pt] Add a cgroup filter.
Jul 7 2022, 12:52 AM · Restricted Project, Restricted Project
wallace updated the summary of D129257: [trace][intel pt] Add a cgroup filter.
Jul 7 2022, 12:50 AM · Restricted Project, Restricted Project
wallace requested review of D129257: [trace][intel pt] Add a cgroup filter.
Jul 7 2022, 12:50 AM · Restricted Project, Restricted Project

Jul 6 2022

wallace requested review of D129249: [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode.
Jul 6 2022, 11:05 PM · Restricted Project, Restricted Project
wallace updated the diff for D129239: [trace] Add an option to save a compact trace bundle.

rename 'process trace save' to 'trace save' because it can actually dump the information of multiple processes.

Jul 6 2022, 10:32 PM · Restricted Project, Restricted Project
wallace updated the diff for D129239: [trace] Add an option to save a compact trace bundle.

fix tests

Jul 6 2022, 8:44 PM · Restricted Project, Restricted Project
wallace updated the diff for D129239: [trace] Add an option to save a compact trace bundle.

improve command handling

Jul 6 2022, 8:41 PM · Restricted Project, Restricted Project
wallace updated the diff for D129239: [trace] Add an option to save a compact trace bundle.

make relative all paths being returned in the description file

Jul 6 2022, 8:22 PM · Restricted Project, Restricted Project
wallace updated the diff for D129239: [trace] Add an option to save a compact trace bundle.

minor improvements for autocompletion in the CLI

Jul 6 2022, 7:56 PM · Restricted Project, Restricted Project
wallace added inline comments to D129239: [trace] Add an option to save a compact trace bundle.
Jul 6 2022, 4:56 PM · Restricted Project, Restricted Project
wallace requested review of D129239: [trace] Add an option to save a compact trace bundle.
Jul 6 2022, 4:53 PM · Restricted Project, Restricted Project

Jul 5 2022

wallace requested changes to D128477: [trace] Add a flag to the decoder to output the instruction type.

let's try to have tests soon. It seems that the code can be simplified and tests will be very handy

Jul 5 2022, 9:03 PM · Restricted Project, Restricted Project
wallace requested changes to D128477: [trace] Add a flag to the decoder to output the instruction type.

much better! Thanks for doing this.

Jul 5 2022, 12:15 AM · Restricted Project, Restricted Project

Jun 29 2022

wallace added a comment to D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).

i can do it right now

Jun 29 2022, 9:27 PM · Restricted Project, Restricted Project
wallace accepted D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).

thanks!

Jun 29 2022, 9:20 PM · Restricted Project, Restricted Project
wallace added a comment to D128775: [trace] Fix errors when handling command arguments.

what happens is that the specific failures are triggered by tests that require the cmake flag LIBIPT_INCLUDE_PATH to be configured, but all good

Jun 29 2022, 10:01 AM · Restricted Project, Restricted Project