Page MenuHomePhabricator

wallace (walter erquinigo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 10:57 AM (203 w, 6 d)

Recent Activity

Today

wallace updated the diff for D77582: [CommandInterpreter] Implement UserCommandExists.

.

Mon, Apr 6, 1:04 PM · Restricted Project
wallace created D77582: [CommandInterpreter] Implement UserCommandExists.
Mon, Apr 6, 1:04 PM · Restricted Project
wallace updated the diff for D77582: [CommandInterpreter] Implement UserCommandExists.

Improve some names

Mon, Apr 6, 1:04 PM · Restricted Project
wallace updated the diff for D77452: [intel-pt] Improve the way the test determines whether to run.

See the new description of the diff for the updates

Mon, Apr 6, 1:04 PM · Restricted Project
wallace updated the diff for D77444: [commands] Support autorepeat in SBCommands.

nits

Mon, Apr 6, 11:59 AM · Restricted Project
wallace updated the diff for D77444: [commands] Support autorepeat in SBCommands.
  • Moved the test to gtest. It's much better this way and I learned gtest
  • Changed the API. Some notes:
Mon, Apr 6, 11:57 AM · Restricted Project

Fri, Apr 3

wallace planned changes to D77444: [commands] Support autorepeat in SBCommands.

Very good idea!

Fri, Apr 3, 9:06 PM · Restricted Project
wallace updated the diff for D77452: [intel-pt] Improve the way the test determines whether to run.

improve description

Fri, Apr 3, 8:02 PM · Restricted Project
wallace created D77452: [intel-pt] Improve the way the test determines whether to run.
Fri, Apr 3, 8:02 PM · Restricted Project
wallace updated the diff for D77324: [source maps] Fix remove, insert-after and replace.

address comments`

Fri, Apr 3, 7:30 PM · Restricted Project
wallace created D77450: Fix LLDB debug builds.
Fri, Apr 3, 6:58 PM · Restricted Project
wallace created D77444: [commands] Support autorepeat in SBCommands.
Fri, Apr 3, 5:21 PM · Restricted Project

Thu, Apr 2

wallace added inline comments to D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request..
Thu, Apr 2, 5:22 PM · Restricted Project
wallace accepted D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request..

I agree with the implementation.
I also find no way notify the IDE that the user has switched to a different thread or frame in the console, and I actually think it's better this way.

Thu, Apr 2, 4:50 PM · Restricted Project
wallace created D77328: [intel-mpx] Delete an unnecessary license header.
Thu, Apr 2, 12:28 PM · Restricted Project
wallace updated the diff for D77324: [source maps] Fix remove, insert-after and replace.

fix typos

Thu, Apr 2, 11:55 AM · Restricted Project
wallace created D77324: [source maps] Fix remove, insert-after and replace.
Thu, Apr 2, 11:55 AM · Restricted Project

Wed, Apr 1

wallace added a comment to D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one.

Thanks for the heads up. I think I got a false impression of how comments after accept vs requesting changes work in this repo.

Wed, Apr 1, 2:04 PM · Restricted Project
wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

address comments

Wed, Apr 1, 12:57 PM · Restricted Project
wallace updated the diff for D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one.

address comments

Wed, Apr 1, 12:22 PM · Restricted Project
wallace added inline comments to D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one.
Wed, Apr 1, 10:41 AM · Restricted Project
wallace added inline comments to D77107: [intel-pt] Implement a basic test case.
Wed, Apr 1, 10:26 AM · Restricted Project

Tue, Mar 31

wallace updated the diff for D77107: [intel-pt] Implement a basic test case.

clang-format

Tue, Mar 31, 6:12 PM · Restricted Project
wallace updated the diff for D77107: [intel-pt] Implement a basic test case.

Noise, for some reason I can't run clang-format as part of arc lint on this device.
I'm running it manually anyway

Tue, Mar 31, 6:12 PM · Restricted Project
wallace updated the diff for D77107: [intel-pt] Implement a basic test case.

Addressed comments

Tue, Mar 31, 6:12 PM · Restricted Project
wallace added inline comments to D77107: [intel-pt] Implement a basic test case.
Tue, Mar 31, 5:39 PM · Restricted Project
wallace created D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one.
Tue, Mar 31, 5:39 PM · Restricted Project
wallace added a comment to D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

Some included changes:

  • Removed the "source" element if the "breakpoint" object returned in breakpoint events
  • CreateBreakpoint now accepts an optional line number, which is used as fallback if no location is valid
  • Added a test that asserts breakpoints in dynamically loaded libraries
Tue, Mar 31, 4:35 PM · Restricted Project
wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

cleanup

Tue, Mar 31, 4:33 PM · Restricted Project
wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

Account for dynamically loaded libraries and update the logic for breakpoint events

Tue, Mar 31, 4:33 PM · Restricted Project

Mon, Mar 30

wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

address comments

Mon, Mar 30, 9:50 PM · Restricted Project
wallace added inline comments to D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.
Mon, Mar 30, 9:18 PM · Restricted Project
wallace updated the diff for D77107: [intel-pt] Implement a basic test case.

Added a stop command invocation in the test

Mon, Mar 30, 6:02 PM · Restricted Project
wallace added a child revision for D76872: [intel-pt] Fix existing support in LLDB: D77107: [intel-pt] Implement a basic test case.
Mon, Mar 30, 6:02 PM · Restricted Project
wallace created D77107: [intel-pt] Implement a basic test case.
Mon, Mar 30, 6:02 PM · Restricted Project
wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

nit

Mon, Mar 30, 2:11 PM · Restricted Project
wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

address comments

Mon, Mar 30, 2:11 PM · Restricted Project
wallace updated the diff for D76872: [intel-pt] Fix existing support in LLDB.

merge the commits of this diff

Mon, Mar 30, 1:37 PM · Restricted Project
wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

address comments

Mon, Mar 30, 11:56 AM · Restricted Project
wallace added inline comments to D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.
Mon, Mar 30, 10:49 AM · Restricted Project

Fri, Mar 27

wallace added a reviewer for D76872: [intel-pt] Fix existing support in LLDB: labath.
Fri, Mar 27, 10:32 PM · Restricted Project
wallace updated the diff for D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

cleanup

Fri, Mar 27, 7:51 PM · Restricted Project
wallace created D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.
Fri, Mar 27, 7:51 PM · Restricted Project

Thu, Mar 26

wallace updated the summary of D76891: [lldb-vscode] fix breakpoint result ordering.
Thu, Mar 26, 4:20 PM · Restricted Project
wallace created D76891: [lldb-vscode] fix breakpoint result ordering.
Thu, Mar 26, 3:47 PM · Restricted Project
wallace added a comment to D76872: [intel-pt] Fix existing support in LLDB.

His last activity was in Jun 2017. I hope he's still around.

Thu, Mar 26, 12:29 PM · Restricted Project
wallace updated the diff for D76872: [intel-pt] Fix existing support in LLDB.

update commit message

Thu, Mar 26, 12:29 PM · Restricted Project
wallace added a reviewer for D76872: [intel-pt] Fix existing support in LLDB: abhishek.aggarwal.
Thu, Mar 26, 12:29 PM · Restricted Project
wallace retitled D76872: [intel-pt] Fix existing support in LLDB from [intel-pt] fix python building to [intel-pt] Fix existing support in LLDB.
Thu, Mar 26, 11:55 AM · Restricted Project
wallace created D76872: [intel-pt] Fix existing support in LLDB.
Thu, Mar 26, 11:22 AM · Restricted Project

Tue, Mar 24

wallace abandoned D74636: [lldb-vscode] Add inheritEnvironment option.

With https://reviews.llvm.org/D76470, targets created by lldb-vscode by default are inheriting the debugger's environment. I don't need this change anymore.
We can work on providing a flag that disables that default behavior, but that can also be set by an initCommand if someone really needs it.

Tue, Mar 24, 2:00 PM · Restricted Project
wallace closed D76529: [lldb-vscode] Add missing launchCommands entry in the package.json.
Tue, Mar 24, 12:21 PM · Restricted Project

Mon, Mar 23

wallace added a comment to D76111: Create basic SBEnvironment class.

Thanks for the notice. I apologize for not doing everything correctly. I'm still trying to understand how all the different piece of the system works and I end up learning from the things that fail...

Mon, Mar 23, 11:21 PM · Restricted Project
wallace updated the diff for D76529: [lldb-vscode] Add missing launchCommands entry in the package.json.

Use clayborg's wording. Thanks, milord.

Mon, Mar 23, 3:16 PM · Restricted Project
wallace added a comment to D74636: [lldb-vscode] Add inheritEnvironment option.

TBH I'd prefer to have consistency across all these options regardless of how the target is launched. That means modifying the defaults of the target settings that can be specified via launch.json arguments.

Mon, Mar 23, 2:11 PM · Restricted Project

Fri, Mar 20

wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

fix test failing with python3

Fri, Mar 20, 8:35 PM · Restricted Project
wallace reopened D76529: [lldb-vscode] Add missing launchCommands entry in the package.json.

I pushed this by mistake, but I've just reverted the commit.

Fri, Mar 20, 7:31 PM · Restricted Project
wallace reopened D74636: [lldb-vscode] Add inheritEnvironment option.

I pushed this by mistake, but I've just reverted the commit.

Fri, Mar 20, 7:31 PM · Restricted Project
wallace created D76529: [lldb-vscode] Add missing launchCommands entry in the package.json.
Fri, Mar 20, 2:40 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

further simplify code. Sorry for the noise

Fri, Mar 20, 2:40 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

simplify code

Fri, Mar 20, 2:39 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

test pass now

Fri, Mar 20, 2:39 PM · Restricted Project
wallace planned changes to D74636: [lldb-vscode] Add inheritEnvironment option.
Fri, Mar 20, 2:39 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

improve comment

Fri, Mar 20, 2:07 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

I added some tests cases to show why I used "settings set target.inherit-env".

Fri, Mar 20, 2:07 PM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.

apply last suggestions

Fri, Mar 20, 1:34 PM · Restricted Project
wallace added a comment to D76111: Create basic SBEnvironment class.

Thanks a lot, guys. I learned a lot from you doing this patch :)

Fri, Mar 20, 1:34 PM · Restricted Project

Thu, Mar 19

wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

Now using the latest SBEnvironment API

Thu, Mar 19, 7:12 PM · Restricted Project
wallace added a reviewer for D76111: Create basic SBEnvironment class: kusmour.
Thu, Mar 19, 2:49 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

rebase

Thu, Mar 19, 2:49 PM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.

fix grammar

Thu, Mar 19, 2:15 PM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.
  • Added both kinds of APIs we were discussing. It will come handy for all different kind of usages
  • Added an SBEnvironment API for SBLaunchInfo, which will be used in https://reviews.llvm.org/D74636
  • Address all sorts of comments
Thu, Mar 19, 2:14 PM · Restricted Project
wallace added inline comments to D76111: Create basic SBEnvironment class.
Thu, Mar 19, 1:42 PM · Restricted Project
wallace added a comment to D76111: Create basic SBEnvironment class.

Well, I think I'll implement both kind of accessors in the API to account for all possible cases

Thu, Mar 19, 11:59 AM · Restricted Project
wallace updated the diff for D76314: [lldb-vscode] stop read loop after termination.

support python2.7

Thu, Mar 19, 11:59 AM · Restricted Project
wallace updated the diff for D76314: [lldb-vscode] stop read loop after termination.

address comments

Thu, Mar 19, 11:59 AM · Restricted Project

Wed, Mar 18

wallace added a reviewer for D74636: [lldb-vscode] Add inheritEnvironment option: kusmour.
Wed, Mar 18, 6:28 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

improve a comment

Wed, Mar 18, 6:28 PM · Restricted Project
wallace updated the diff for D74636: [lldb-vscode] Add inheritEnvironment option.

Using the new SBEnvironment class

Wed, Mar 18, 6:28 PM · Restricted Project
wallace commandeered D74636: [lldb-vscode] Add inheritEnvironment option.
Wed, Mar 18, 5:57 PM · Restricted Project
wallace updated the diff for D76314: [lldb-vscode] stop read loop after termination.

address comments

Wed, Mar 18, 4:19 PM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.
Wed, Mar 18, 3:46 PM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.

Addressed Greg's comments.

Wed, Mar 18, 3:46 PM · Restricted Project
wallace updated the diff for D76314: [lldb-vscode] stop read loop after termination.

nit

Wed, Mar 18, 1:01 PM · Restricted Project
wallace updated the diff for D76314: [lldb-vscode] stop read loop after termination.

add a test

Wed, Mar 18, 1:01 PM · Restricted Project
wallace added a comment to D76111: Create basic SBEnvironment class.

Thanks for the review!

Wed, Mar 18, 11:57 AM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.

address comments

Wed, Mar 18, 11:57 AM · Restricted Project

Tue, Mar 17

wallace added a comment to D76314: [lldb-vscode] stop read loop after termination.

As we discussed privately, some remote connections use a mutiplexor socket that doesn't die when the debug session ends.

Tue, Mar 17, 6:23 PM · Restricted Project
wallace created D76314: [lldb-vscode] stop read loop after termination.
Tue, Mar 17, 1:29 PM · Restricted Project

Mon, Mar 16

wallace updated the diff for D76111: Create basic SBEnvironment class.

format

Mon, Mar 16, 4:57 PM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.

.

Mon, Mar 16, 4:57 PM · Restricted Project
wallace updated the diff for D76111: Create basic SBEnvironment class.

address comments≈

Mon, Mar 16, 4:57 PM · Restricted Project

Fri, Mar 13

wallace added a comment to D76111: Create basic SBEnvironment class.

Thanks a lot for the feedback! I was thinking about adding features to this class as needed, but definitely I should make this API be more like a map

Fri, Mar 13, 10:44 AM · Restricted Project

Thu, Mar 12

wallace updated the diff for D76111: Create basic SBEnvironment class.

format

Thu, Mar 12, 5:43 PM · Restricted Project
wallace updated the summary of D76111: Create basic SBEnvironment class.
Thu, Mar 12, 5:42 PM · Restricted Project
wallace created D76111: Create basic SBEnvironment class.
Thu, Mar 12, 5:23 PM · Restricted Project
wallace added a comment to D74636: [lldb-vscode] Add inheritEnvironment option.

The original intention of this is to have any working environment, as quite often complex programs require many environment variables that are common to most processes. Having the user specify each of those is a bit too much to ask for, and they are complaining because of this. That said, just using the platform's environment would be enough to have something working. And it the extreme case when other specific env vars are needed, then the user can specify them by hand.

Thu, Mar 12, 11:23 AM · Restricted Project

Wed, Mar 11

wallace added a comment to D74636: [lldb-vscode] Add inheritEnvironment option.

Regarding implementation:

Wed, Mar 11, 9:50 PM · Restricted Project

Tue, Mar 10

wallace requested changes to D74636: [lldb-vscode] Add inheritEnvironment option.
Tue, Mar 10, 6:37 PM · Restricted Project

Feb 25 2020

wallace accepted D74883: Add a llvm-gsymutil tool that can convert object files to GSYM and perform lookups..
Feb 25 2020, 8:26 AM · Restricted Project