This is an archive of the discontinued LLVM Phabricator instance.

[benchmark] Pull latest; disable -Werror
ClosedPublic

Authored by mtrofin on Dec 13 2021, 4:11 PM.

Details

Summary

Pulled the latest (b000672), which adds an option to disable -Werror,
which caused issues previously (see for instance
https://reviews.llvm.org/D112012)

Applied https://github.com/google/benchmark/pull/1305 to unblock, as
this issue is causing downstream buildbot failures.

The only change is in llvm/CMakeLists.txt, where we set
BENCHMARK_ENABLE_WERROR to have the same value as LLVM_ENABLE_WERROR.

This patch also introduces a convenience script to pull benchmark from
upstream.

Diff Detail

Event Timeline

mtrofin created this revision.Dec 13 2021, 4:11 PM
mtrofin requested review of this revision.Dec 13 2021, 4:11 PM
Herald added a project: Restricted Project. · View Herald Transcript
mtrofin updated this revision to Diff 394082.Dec 13 2021, 4:26 PM

spurious change in cmakelists

thakis accepted this revision.Dec 13 2021, 4:31 PM
thakis added a subscriber: thakis.

stamp

This revision is now accepted and ready to land.Dec 13 2021, 4:31 PM
This revision was landed with ongoing or failed builds.Dec 13 2021, 5:13 PM
This revision was automatically updated to reflect the committed changes.