This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Remove FCSR from RISCVRegisterInfo.
ClosedPublic

Authored by craig.topper on Dec 9 2021, 10:19 AM.

Details

Summary

We only used this to mark it as a reserved register. But that's not
important if we don't do anything else with it.

I think if we were ever to do anything with it, we would need to
model it as a super register of FRM and FFLAGS. But it might be
easier to reference both FRM and FFLAGS in implicit defs/uses
for anything we were to do with "fcsr".

Diff Detail

Event Timeline

craig.topper created this revision.Dec 9 2021, 10:19 AM
craig.topper requested review of this revision.Dec 9 2021, 10:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2021, 10:19 AM
Herald added a subscriber: MaskRay. · View Herald Transcript
sepavloff accepted this revision.Dec 10 2021, 12:59 AM

Using fflags and frm separately is almost always more convenient than fcsr. The exception is probably the implementation of functions fegetenv and fesetenv, but in that case using both fflags and frm also works.

LGTM

This revision is now accepted and ready to land.Dec 10 2021, 12:59 AM
This revision was automatically updated to reflect the committed changes.