This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args
ClosedPublic

Authored by foad on Dec 3 2021, 1:57 AM.

Details

Summary

The ray_origin, ray_dir and ray_inv_dir arguments should all be vec3 to
match how the hardware instruction works.

Don't change the API of the corresponding OpenCL builtins.

Diff Detail

Event Timeline

foad created this revision.Dec 3 2021, 1:57 AM
foad requested review of this revision.Dec 3 2021, 1:57 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 3 2021, 1:57 AM
foad added a comment.Dec 3 2021, 1:58 AM

This is an alternative to D114957 that does not update the API of the OpenCL builtins.

rampitec accepted this revision.Dec 3 2021, 9:51 AM

LGTM

This revision is now accepted and ready to land.Dec 3 2021, 9:51 AM
yaxunl accepted this revision.Dec 3 2021, 10:03 AM

Ideally, we could let the builtins accept both vec3 and vec4. But I am OK with this for now. I think the overhead may be minimal.

This revision was landed with ongoing or failed builds.Dec 4 2021, 3:00 AM
This revision was automatically updated to reflect the committed changes.