Page MenuHomePhabricator

critson (Carl Ritson)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2018, 4:49 AM (49 w, 6 d)

Recent Activity

Fri, Jul 26

critson committed rG0b2835705322: [AMDGPU] Move WQM/WWM intrinsic instruction selection to AMDGPUISelDAGToDAG (authored by critson).
[AMDGPU] Move WQM/WWM intrinsic instruction selection to AMDGPUISelDAGToDAG
Fri, Jul 26, 6:15 AM
critson committed rL367105: [AMDGPU] Move WQM/WWM intrinsic instruction selection to AMDGPUISelDAGToDAG.
[AMDGPU] Move WQM/WWM intrinsic instruction selection to AMDGPUISelDAGToDAG
Fri, Jul 26, 6:15 AM
critson closed D65328: [AMDGPU] Move WQM/WWM intrinsic instruction selection to AMDGPUISelDAGToDAG.
Fri, Jul 26, 6:15 AM · Restricted Project
critson created D65328: [AMDGPU] Move WQM/WWM intrinsic instruction selection to AMDGPUISelDAGToDAG.
Fri, Jul 26, 4:57 AM · Restricted Project
critson committed rG00e89b428b99: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic (authored by critson).
[AMDGPU] Add llvm.amdgcn.softwqm intrinsic
Fri, Jul 26, 2:56 AM
critson committed rL367097: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.
[AMDGPU] Add llvm.amdgcn.softwqm intrinsic
Fri, Jul 26, 2:56 AM
critson closed D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.
Fri, Jul 26, 2:56 AM · Restricted Project

Mon, Jul 22

critson added a comment to D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.

I've moved the selection to AMDGPUISelDAGToDAG.
If this code is appropriate I will submit a follow change to move the selection for llvm.amdgcn.wqm and llvm.amdgcn.wwm as well.

Mon, Jul 22, 7:45 AM · Restricted Project
critson updated the diff for D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.

Move opcode selection to AMDGPUISelDAGToDAG.
Fix typo in comment.

Mon, Jul 22, 7:45 AM · Restricted Project

Jul 19 2019

critson added a comment to D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.

Have you checked that this actually fixes the reported CTS failure?

Jul 19 2019, 11:19 AM · Restricted Project
critson updated the diff for D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.

Add missing code in SI Fix SGPR copies.

Jul 19 2019, 11:06 AM · Restricted Project
critson added inline comments to D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.
Jul 19 2019, 3:27 AM · Restricted Project

Jul 18 2019

critson created D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.
Jul 18 2019, 10:07 AM · Restricted Project

Jun 6 2019

critson added a comment to D60772: [AMDGPU] Add optional bounds checking for scratch accesses.

Ping.
I was wondering if I can get a second reading on this?
I believe I've addressed everything except the introduction of a new address space, as this seems somewhat heavyweight to me.
If the address space is considered absolutely necessary then I'll work on that next.

Jun 6 2019, 2:00 AM · Restricted Project

May 29 2019

critson added inline comments to D60772: [AMDGPU] Add optional bounds checking for scratch accesses.
May 29 2019, 8:38 AM · Restricted Project
critson updated the diff for D60772: [AMDGPU] Add optional bounds checking for scratch accesses.
  • Remove worklist usage.
  • Move from global to subtarget option.
  • Add second pass to resolve scratch size later in backend.
  • Add missing lit tests.
May 29 2019, 8:33 AM · Restricted Project

May 20 2019

critson committed rG34e95ce2595f: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values (authored by critson).
[AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values
May 20 2019, 12:21 AM
critson committed rL361124: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.
[AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values
May 20 2019, 12:17 AM
critson closed D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.
May 20 2019, 12:17 AM · Restricted Project

May 18 2019

critson added inline comments to D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.
May 18 2019, 3:48 AM · Restricted Project
critson updated the diff for D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.

Integrate all cases into switch statement.

May 18 2019, 3:43 AM · Restricted Project

May 17 2019

critson created D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.
May 17 2019, 2:55 AM · Restricted Project

May 7 2019

critson added inline comments to D60772: [AMDGPU] Add optional bounds checking for scratch accesses.
May 7 2019, 7:55 AM · Restricted Project

Apr 16 2019

critson created D60772: [AMDGPU] Add optional bounds checking for scratch accesses.
Apr 16 2019, 6:18 AM · Restricted Project

Mar 8 2019

critson committed rG1a98dc184044: [AMDGPU] V_CVT_F32_UBYTE{0,1,2,3} are full rate instructions (authored by critson).
[AMDGPU] V_CVT_F32_UBYTE{0,1,2,3} are full rate instructions
Mar 8 2019, 1:05 AM
critson committed rL355671: [AMDGPU] V_CVT_F32_UBYTE{0,1,2,3} are full rate instructions.
[AMDGPU] V_CVT_F32_UBYTE{0,1,2,3} are full rate instructions
Mar 8 2019, 1:02 AM
critson closed D59091: [AMDGPU] V_CVT_F32_UBYTE{0,1,2,3} are full rate instructions.
Mar 8 2019, 1:02 AM · Restricted Project

Mar 7 2019

critson created D59091: [AMDGPU] V_CVT_F32_UBYTE{0,1,2,3} are full rate instructions.
Mar 7 2019, 5:29 AM · Restricted Project

Mar 5 2019

critson committed rG9e3f7d8ad00c: [AMDGPU] Fix DPP operand order in atomic optimizer (authored by critson).
[AMDGPU] Fix DPP operand order in atomic optimizer
Mar 5 2019, 4:21 AM
critson committed rL355394: [AMDGPU] Fix DPP operand order in atomic optimizer.
[AMDGPU] Fix DPP operand order in atomic optimizer
Mar 5 2019, 4:20 AM
critson closed D58900: [AMDGPU] Fix DPP operand order in atomic optimizer.
Mar 5 2019, 4:20 AM · Restricted Project

Mar 4 2019

critson created D58900: [AMDGPU] Fix DPP operand order in atomic optimizer.
Mar 4 2019, 7:08 AM · Restricted Project

Feb 8 2019

critson committed rG494b8ac95a79: [AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs (authored by critson).
[AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs
Feb 8 2019, 7:41 AM
critson committed rL353530: [AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs.
[AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs
Feb 8 2019, 7:41 AM
critson closed D56496: [AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs.
Feb 8 2019, 7:41 AM · Restricted Project

Jan 21 2019

critson added a comment to D56496: [AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs.

Ping

Jan 21 2019, 2:26 AM · Restricted Project

Jan 9 2019

critson created D56496: [AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs.
Jan 9 2019, 8:37 AM · Restricted Project

Dec 19 2018

critson committed rL349611: AMDGPU/InsertWaitcnts: Update VGPR/SGPR bounds when brackets are merged.
AMDGPU/InsertWaitcnts: Update VGPR/SGPR bounds when brackets are merged
Dec 19 2018, 2:22 AM
critson closed D55602: AMDGPU/InsertWaitcnts: Update VGPR/SGPR bounds when brackets are merged.
Dec 19 2018, 2:22 AM

Dec 12 2018

critson added a comment to D54231: AMDGPU/InsertWaitcnts: Remove the dependence on MachineLoopInfo.

This change introduced a regression in The Witcher 3, see https://bugs.freedesktop.org/show_bug.cgi?id=108935

Dec 12 2018, 7:54 AM
critson created D55602: AMDGPU/InsertWaitcnts: Update VGPR/SGPR bounds when brackets are merged.
Dec 12 2018, 7:46 AM

Sep 19 2018

critson committed rL342558: [AMDGPU] Add instruction selection for i1 to f16 conversion.
[AMDGPU] Add instruction selection for i1 to f16 conversion
Sep 19 2018, 9:33 AM
critson closed D52018: [AMDGPU] Add instruction selection for i1 to f16 conversion.
Sep 19 2018, 9:33 AM

Sep 14 2018

critson added a comment to D52018: [AMDGPU] Add instruction selection for i1 to f16 conversion.

Why the detour via V_CVT_F16_F32 instead of selecting an fp16 1.0 constant directly?

Sep 14 2018, 8:34 AM
critson updated the diff for D52018: [AMDGPU] Add instruction selection for i1 to f16 conversion.

Add support and test for sint_to_fp.

Sep 14 2018, 8:07 AM

Sep 13 2018

critson created D52018: [AMDGPU] Add instruction selection for i1 to f16 conversion.
Sep 13 2018, 1:05 AM

Sep 10 2018

critson committed rL341798: [AMDGPU] Prevent sequences of non-instructions disrupting GCNHazardRecognizer….
[AMDGPU] Prevent sequences of non-instructions disrupting GCNHazardRecognizer…
Sep 10 2018, 3:17 AM
critson closed D51726: [AMDGPU] Remove non-instructions from GCNHazardRecognizer buffer.
Sep 10 2018, 3:17 AM
critson added inline comments to D51726: [AMDGPU] Remove non-instructions from GCNHazardRecognizer buffer.
Sep 10 2018, 2:49 AM

Sep 7 2018

critson updated the diff for D51726: [AMDGPU] Remove non-instructions from GCNHazardRecognizer buffer.

Use isDebugInstr instead of DEBUG_VALUE.
Merge tests into existing hazard.mir.
Add test for DEBUG_LABEL.

Sep 7 2018, 4:15 AM

Sep 6 2018

critson created D51726: [AMDGPU] Remove non-instructions from GCNHazardRecognizer buffer.
Sep 6 2018, 4:00 AM