[clang][PR52088]Fix assertion failure when passing bool as the type of next parameter

[Lucas]

Summary

$cat bad.cpp

void fn1(__builtin_va_list args)
{
  __builtin_va_arg(args, bool);
}

Command output(stderr):
Unexpected unsigned integer or fixed point type
UNREACHABLE executed at /mnt/c/Users/zhaohui/workspace/llvm-project/clang/lib/AST/ASTContext.cpp:10396!
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0. Program arguments: ./bin/clang-14 -c bad.cpp

1. bad.c:6:32: current parser token ';'
2. bad.c:5:1: parsing function body 'main'
3. bad.c:5:1: in compound statement ('{}')
   
   #0 0x00007f3b7e7bce08 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /mnt/c/Users/zhaohui/workspace/llvm-project/llvm/lib/Support/Unix/Signals.inc:565:0 #1 0x00007f3b7e7bcebf PrintStackTraceSignalHandler(void*) /mnt/c/Users/zhaohui/workspace/llvm-project/llvm/lib/Support/Unix/Signals.inc:632:0 #2 0x00007f3b7e7ba919 llvm::sys::RunSignalHandlers() /mnt/c/Users/zhaohui/workspace/llvm-project/llvm/lib/Support/Signals.cpp:97:0 #3 0x00007f3b7e7bc602 llvm::sys::CleanupOnSignal(unsigned long) /mnt/c/Users/zhaohui/workspace/llvm-project/llvm/lib/Support/Unix/Signals.inc:361:0 #4 0x00007f3b7e6d569a (anonymous namespace)::CrashRecoveryContextImpl::HandleCrash(int, unsigned long) /mnt/c/Users/zhaohui/workspace/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:76:0 #5 0x00007f3b7e6d5bb5 CrashRecoverySignalHandler(int) /mnt/c/Users/zhaohui/workspace/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:390:0 #6 0x00007f3b77bf2980 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x12980) #7 0x00007f3b76cbefb7 raise (/lib/x86_64-linux-gnu/libc.so.6+0x3efb7) #8 0x00007f3b76cc0921 abort (/lib/x86_64-linux-gnu/libc.so.6+0x40921) #9 0x00007f3b7e6df5bb bindingsErrorHandler(void*, char const*, bool) /mnt/c/Users/zhaohui/workspace/llvm-project/llvm/lib/Support/ErrorHandling.cpp:218:0

#10 0x00007f3b8315a914 clang::ASTContext::getCorrespondingSignedType(clang::QualType) const /mnt/c/Users/zhaohui/workspace/llvm-project/clang/lib/AST/ASTContext.cpp:10398:0
#11 0x00007f3b822bc270 clang::Sema::BuildVAArgExpr(clang::SourceLocation, clang::Expr*, clang::TypeSourceInfo*, clang::SourceLocation) /mnt/c/Users/zhaohui/workspace/llvm-project/clang/lib/Sema/SemaExpr.cpp:15911:0
#12 0x00007f3b822bb812 clang::Sema::ActOnVAArg(clang::SourceLocation, clang::Expr*, clang::OpaquePtr<clang::QualType>, clang::SourceLocation) /mnt/c/Users/zhaohui/workspace/llvm-project/clang/lib/Sema/SemaExpr.cpp:15779:0
clang-14: error: clang frontend command failed with exit code 134 (use -v to see invocation)
clang version 14.0.0 (https://github.com/llvm/llvm-project.git d32a43d2c13d22f27d7381f8aff9f39e129ee03b)

https://bugs.llvm.org/show_bug.cgi?id=52088

[Lucas]

Checking with clang-format.

[Lucas]

Include all local changes.

[Lucas]

This issue has already been fixed by https://reviews.llvm.org/D116272.

clang/lib/Sema/SemaExpr.cpp

if (TInfo->getType()->isPromotableIntegerType()) {
       if (const auto *ET = UnderlyingType->getAs<EnumType>())
         UnderlyingType = ET->getDecl()->getIntegerType();
       if (Context.typesAreCompatible(PromoteType, UnderlyingType,
                                      /*CompareUnqualified*/ true))
         PromoteType = QualType();
 
       // If the types are still not compatible, we need to test whether the
       // promoted type and the underlying type are the same except for
-      // signedness. Ask the AST for the correctly corresponding type and see
-      // if that's compatible.
-      if (!PromoteType.isNull() &&
+      // signedness except for boolean. Ask the AST for the correctly
+      // corresponding type and see if that's compatible.
+      if (!PromoteType.isNull() && !UnderlyingType->isBooleanType() &&
           PromoteType->isUnsignedIntegerType() !=
               UnderlyingType->isUnsignedIntegerType()) {
         UnderlyingType =
             UnderlyingType->isUnsignedIntegerType()
                 ? Context.getCorrespondingSignedType(UnderlyingType)
                 : Context.getCorrespondingUnsignedType(UnderlyingType);
         if (Context.typesAreCompatible(PromoteType, UnderlyingType,
                                        /*CompareUnqualified*/ true))

clang/test/SemaCXX/varargs.cpp

void promotable(int a, ...) {
   enum FixedLarge : long long { Six };
   (void)__builtin_va_arg(ap, FixedLarge); // ok
 
   // Ensure that qualifiers are ignored.
   (void)__builtin_va_arg(ap, const volatile int);  // ok
 
   // Ensure that signed vs unsigned doesn't matter either.
   (void)__builtin_va_arg(ap, unsigned int);
+
+  (void)__builtin_va_arg(ap, bool); // expected-warning {{second argument to 'va_arg' is of promotable type 'bool'; this va_arg has undefined behavior because arguments will be promoted to 'int'}}
 }
 
 #if __cplusplus >= 201103L
 // We used to have bugs identifying the correct enclosing function scope in a
 // lambda.
 
 void fixed_lambda_varargs_function(int a, ...) {
   [](int b) {