This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add scheduling resources for Vector pseudo instructions.
ClosedPublic

Authored by HsiangKai on Nov 6 2021, 4:21 PM.

Details

Summary

Add the scheduling resources for the V extension pseudo instructions.

Authored-by: Evandro Menezes <evandro.menezes@sifive.com>

Diff Detail

Event Timeline

HsiangKai created this revision.Nov 6 2021, 4:21 PM
HsiangKai requested review of this revision.Nov 6 2021, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2021, 4:21 PM
HsiangKai updated this revision to Diff 387571.Nov 16 2021, 4:00 AM

Fix failed test.

Generally looks good to me, thanks @HsiangKai

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
2038

nit: MINMAX?

2059

nit: VFMUL? I know VF helps disambiguate it but I think people are generally more opcode focused.

2066

nit: VFDIV?

2073

VFRDIV

2224

nit: can probably get rid of this extra space

craig.topper added inline comments.Nov 24 2021, 11:27 AM
llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
2158–2162

Based on Fraser's FMUL and FDIV comments, this should be VFWALU

2165–2171

Same here

2448

VWFRED -> VFWRED to match the scheduler class name and instruction names

HsiangKai updated this revision to Diff 390160.Nov 27 2021, 6:32 AM

Address comments.

frasercrmck accepted this revision.Dec 6 2021, 2:12 AM

LGTM from what I can see. Thanks!

This revision is now accepted and ready to land.Dec 6 2021, 2:12 AM
This comment was removed by tstellar.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2023, 7:37 PM
luke957 removed a subscriber: luke957.Feb 5 2023, 7:55 PM