Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D109253

[AArch64] Emit some .cfi_* for non-SVE cases in emitEpilogue
AbandonedPublic
Actions

Authored by MaskRay on Sep 3 2021, 12:30 PM.

Tags

Subscribers

Details

Reviewers: None

Summary

WIP.

Ideally .cfi_def_offset should be used instead. .cfi_adjust_cfa_offset is used for now.

There are many epilogue code paths where .cfi_* directives are missing.
They need separate fixes.

Something is not correct yet (e.g. addsub-constant-folding.ll)

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60 ms	x64 debian > LLVM.CodeGen/AArch64::aarch64-dynamic-stack-layout.ll
	40 ms	x64 debian > LLVM.CodeGen/AArch64::alloca.ll
	60 ms	x64 debian > LLVM.CodeGen/AArch64::argument-blocks-array-of-struct.ll
	40 ms	x64 debian > LLVM.CodeGen/AArch64::call-rv-marker.ll
	40 ms	x64 debian > LLVM.CodeGen/AArch64::fastcc-reserved.ll
		View Full Test Results (44 Failed)

Event Timeline

MaskRay created this revision.Sep 3 2021, 12:30 PM

Herald added subscribers: asbirlea, hiraditya, kristof.beyls, tschuett. · View Herald TranscriptSep 3 2021, 12:30 PM

MaskRay requested review of this revision.Sep 3 2021, 12:30 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2021, 12:30 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

MaskRay retitled this revision from [AArch64] Emit some .cfi_* for non-SVE cases in emitEpilogue WIP to [AArch64] Emit some .cfi_* for non-SVE cases in emitEpilogue.Sep 3 2021, 12:33 PM

MaskRay edited the summary of this revision. (Show Details)

MaskRay added inline comments.Sep 3 2021, 12:37 PM

llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
1688	SVE callee save stack seems very difficult, so not in the scope of this patch.
llvm/test/CodeGen/AArch64/fptosi-sat-vector.ll
279	This is incorrect.
1490	This is apparently incorrect.

Harbormaster completed remote builds in B122568: Diff 370649.Sep 3 2021, 1:02 PM

fix some issues

Harbormaster completed remote builds in B122636: Diff 370748.Sep 4 2021, 12:01 PM

• hafixo added a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:44 AM

• hafixo added a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:47 AM

thopre removed a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:47 AM

thopre removed a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:51 AM

Matt added a subscriber: Matt.Sep 7 2021, 5:25 AM

MaskRay mentioned this in D111780: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions..Oct 14 2021, 10:18 AM

danielkiss added a subscriber: danielkiss.Oct 14 2021, 11:03 AM

MaskRay abandoned this revision.Mar 25 2022, 11:21 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 11:21 PM

Herald added a subscriber: StephenFan. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

AArch64/

AArch64FrameLowering.cpp

47 lines

test/

CodeGen/

AArch64/

GlobalISel/

1 line

addsub-constant-folding.ll

18 lines

arm64-atomic-128.ll

4 lines

11 lines

cmp-select-sign.ll

1 line

combine-comparisons-by-cse.ll

6 lines

cond-br-tuning.ll

1 line

5 lines

fptosi-sat-vector.ll

44 lines

fptoui-sat-vector.ll

29 lines

ldst-paired-aliasing.ll

1 line

2 lines

logical_shifted_reg.ll

2 lines

machine-licm-sink-instr.ll

3 lines

machine-outliner-thunk.ll

12 lines

merge-store-dependency.ll

1 line

optimize-cond-branch.ll

2 lines

ragreedy-local-interval-cost.ll

1 line

shift_minsize.ll

69 lines

statepoint-call-lowering.ll

1 line

sve-insert-element.ll

3 lines

sve-insert-vector.ll

6 lines

sve-split-extract-elt.ll

21 lines

sve-split-insert-elt.ll

15 lines

1 line

Diff 370649

llvm/lib/Target/AArch64/AArch64FrameLowering.cpp

Loading...

llvm/test/CodeGen/AArch64/GlobalISel/byval-call.ll

Loading...

llvm/test/CodeGen/AArch64/addsub-constant-folding.ll

Loading...

llvm/test/CodeGen/AArch64/arm64-atomic-128.ll

Loading...

llvm/test/CodeGen/AArch64/arm64-fp128.ll

Loading...

llvm/test/CodeGen/AArch64/cmp-select-sign.ll

Loading...

llvm/test/CodeGen/AArch64/combine-comparisons-by-cse.ll

Loading...

llvm/test/CodeGen/AArch64/cond-br-tuning.ll

Loading...

llvm/test/CodeGen/AArch64/csr-split.ll

Loading...

llvm/test/CodeGen/AArch64/fptosi-sat-vector.ll

Loading...

llvm/test/CodeGen/AArch64/fptoui-sat-vector.ll

Loading...

llvm/test/CodeGen/AArch64/ldst-paired-aliasing.ll

Loading...

llvm/test/CodeGen/AArch64/local_vars.ll

Loading...

llvm/test/CodeGen/AArch64/logical_shifted_reg.ll

Loading...

llvm/test/CodeGen/AArch64/machine-licm-sink-instr.ll

Loading...

llvm/test/CodeGen/AArch64/machine-outliner-thunk.ll

Loading...

llvm/test/CodeGen/AArch64/merge-store-dependency.ll

Loading...

llvm/test/CodeGen/AArch64/optimize-cond-branch.ll

Loading...

llvm/test/CodeGen/AArch64/ragreedy-local-interval-cost.ll

Loading...

llvm/test/CodeGen/AArch64/shift_minsize.ll

Loading...

llvm/test/CodeGen/AArch64/statepoint-call-lowering.ll

Loading...

llvm/test/CodeGen/AArch64/sve-insert-element.ll

Loading...

llvm/test/CodeGen/AArch64/sve-insert-vector.ll

Loading...

llvm/test/CodeGen/AArch64/sve-split-extract-elt.ll

Loading...

llvm/test/CodeGen/AArch64/sve-split-insert-elt.ll

Loading...

llvm/test/CodeGen/AArch64/sve-varargs.ll

Loading...