Replace default bodies of special member functions with = default;
$ run-clang-tidy.py -header-filter='lldb' -checks='-*,modernize-use-equals-default' -fix ,
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html
Paths
| Differential D104041
[lldb] Replace default bodies of special member functions with = default; ClosedPublic Authored by JDevlieghere on Jun 10 2021, 9:19 AM.
Details
Summary Replace default bodies of special member functions with = default; $ run-clang-tidy.py -header-filter='lldb' -checks='-*,modernize-use-equals-default' -fix , https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html
Diff Detail Event Timeline
Comment Actions LGTM beside some minor formatting bugs that got exacerbated by the clang-tidy run. I got bored of writing 'format' everywhere so I translated every comment into a different language via Google translate. I'll already accept this as this is easy to fix.
JDevlieghere marked 12 inline comments as done. Comment ActionsMi traktis la komentojn
This revision is now accepted and ready to land.Jun 14 2021, 3:14 AM Comment Actions I am sure I could find a bunch of other ends and odds but perhaps you have other checks that will cover these coming up.
This revision was landed with ongoing or failed builds.Jul 2 2021, 11:31 AM Closed by commit rGfd2433e139f7: [lldb] Replace default bodies of special member functions with = default; (authored by JDevlieghere). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 351215 lldb/.clang-tidy
lldb/include/lldb/Core/EmulateInstruction.h
lldb/include/lldb/Core/Opcode.h
lldb/include/lldb/Core/StreamBuffer.h
lldb/include/lldb/Core/ThreadSafeValue.h
lldb/include/lldb/Core/UserSettingsController.h
lldb/include/lldb/DataFormatters/DumpValueObjectOptions.h
lldb/include/lldb/DataFormatters/TypeFormat.h
lldb/include/lldb/DataFormatters/TypeSummary.h
lldb/include/lldb/DataFormatters/TypeSynthetic.h
lldb/include/lldb/DataFormatters/ValueObjectPrinter.h
lldb/include/lldb/Expression/Expression.h
lldb/include/lldb/Expression/ExpressionParser.h
lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h
lldb/include/lldb/Expression/Materializer.h
lldb/include/lldb/Host/FileCache.h
lldb/include/lldb/Host/HostInfoBase.h
lldb/include/lldb/Host/HostNativeProcessBase.h
lldb/include/lldb/Host/HostNativeThreadBase.h
lldb/include/lldb/Host/MainLoopBase.h
lldb/include/lldb/Host/ProcessLauncher.h
lldb/include/lldb/Host/ProcessRunLock.h
lldb/include/lldb/Host/Terminal.h
lldb/include/lldb/Host/common/NativeProcessProtocol.h
lldb/include/lldb/Host/common/NativeThreadProtocol.h
lldb/include/lldb/Interpreter/CommandInterpreter.h
lldb/include/lldb/Interpreter/OptionValue.h
lldb/include/lldb/Interpreter/Options.h
lldb/include/lldb/Interpreter/ScriptInterpreter.h
lldb/include/lldb/Symbol/CompactUnwindInfo.h
lldb/include/lldb/Symbol/DeclVendor.h
lldb/include/lldb/Symbol/Function.h
lldb/include/lldb/Symbol/ObjectFile.h
lldb/include/lldb/Symbol/SymbolFile.h
lldb/include/lldb/Symbol/TaggedASTType.h
lldb/include/lldb/Symbol/Type.h
lldb/include/lldb/Target/ExecutionContextScope.h
lldb/include/lldb/Target/InstrumentationRuntimeStopInfo.h
lldb/include/lldb/Target/Process.h
lldb/include/lldb/Target/RegisterCheckpoint.h
lldb/include/lldb/Target/StackFrameRecognizer.h
lldb/include/lldb/Target/StopInfo.h
lldb/include/lldb/Target/ThreadCollection.h
lldb/include/lldb/Target/ThreadPlanStack.h
lldb/include/lldb/Target/UnixSignals.h
lldb/include/lldb/Target/Unwind.h
lldb/include/lldb/Utility/Baton.h
lldb/include/lldb/Utility/DataBuffer.h
lldb/include/lldb/Utility/Event.h
lldb/include/lldb/Utility/ReproducerInstrumentation.h
lldb/include/lldb/Utility/StreamTee.h
lldb/include/lldb/Utility/TraceGDBRemotePackets.h
lldb/include/lldb/Utility/UserID.h
lldb/include/lldb/Utility/VMRange.h
lldb/include/lldb/lldb-private-types.h
lldb/source/Breakpoint/BreakpointList.cpp
lldb/source/Breakpoint/BreakpointLocationCollection.cpp
lldb/source/Breakpoint/BreakpointResolver.cpp
lldb/source/Breakpoint/BreakpointSiteList.cpp
lldb/source/Breakpoint/Stoppoint.cpp
lldb/source/Breakpoint/WatchpointList.cpp
lldb/source/Commands/CommandObjectGUI.cpp
lldb/source/Commands/CommandObjectHelp.h
lldb/source/Commands/CommandObjectLanguage.cpp
lldb/source/Commands/CommandObjectPlatform.cpp
lldb/source/Commands/CommandObjectQuit.cpp
lldb/source/Commands/CommandObjectRegexCommand.cpp
lldb/source/Commands/CommandObjectScript.cpp
lldb/source/Commands/CommandObjectTarget.cpp
lldb/source/Commands/CommandObjectVersion.cpp
lldb/source/Core/AddressRange.cpp
lldb/source/Core/AddressResolver.cpp
lldb/source/Core/AddressResolverFileLine.cpp
lldb/source/Core/FileLineResolver.cpp
lldb/source/Core/ModuleChild.cpp
lldb/source/Core/PluginManager.cpp
lldb/source/Core/SourceManager.cpp
lldb/source/Core/StreamFile.cpp
lldb/source/Core/ValueObject.cpp
lldb/source/Core/ValueObjectCast.cpp
lldb/source/Core/ValueObjectChild.cpp
lldb/source/Core/ValueObjectConstResult.cpp
lldb/source/Core/ValueObjectConstResultCast.cpp
lldb/source/Core/ValueObjectConstResultChild.cpp
lldb/source/Core/ValueObjectMemory.cpp
lldb/source/Core/ValueObjectRegister.cpp
lldb/source/Core/ValueObjectVariable.cpp
lldb/source/DataFormatters/TypeFormat.cpp
lldb/source/DataFormatters/TypeSummary.cpp
lldb/source/DataFormatters/TypeSynthetic.cpp
lldb/source/Expression/DWARFExpression.cpp
lldb/source/Expression/ExpressionVariable.cpp
lldb/source/Expression/IRExecutionUnit.cpp
lldb/source/Expression/IRInterpreter.cpp
lldb/source/Expression/UserExpression.cpp
lldb/source/Host/common/HostProcess.cpp
lldb/source/Host/common/NativeRegisterContext.cpp
lldb/source/Host/common/PseudoTerminal.cpp
lldb/source/Host/common/SocketAddress.cpp
lldb/source/Host/common/Terminal.cpp
lldb/source/Host/common/XML.cpp
lldb/source/Host/macosx/cfcpp/CFCBundle.cpp
lldb/source/Host/macosx/cfcpp/CFCData.cpp
lldb/source/Host/macosx/cfcpp/CFCMutableArray.cpp
lldb/source/Host/macosx/cfcpp/CFCMutableDictionary.cpp
lldb/source/Host/macosx/cfcpp/CFCMutableSet.cpp
lldb/source/Host/macosx/cfcpp/CFCString.cpp
lldb/source/Host/posix/HostProcessPosix.cpp
lldb/source/Host/posix/HostThreadPosix.cpp
lldb/source/Initialization/SystemInitializer.cpp
lldb/source/Initialization/SystemInitializerCommon.cpp
lldb/source/Interpreter/OptionGroupFile.cpp
lldb/source/Interpreter/OptionValueFileColonLine.cpp
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.h
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.h
lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp
lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp
lldb/source/Plugins/ExpressionParser/Clang/ASTUtils.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.h
lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionHelper.h
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionVariable.h
lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.h
lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp
lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.h
lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.h
lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp
lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.h
lldb/source/Plugins/Language/ObjC/NSIndexPath.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.h
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.h
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.h
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.cpp
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp
lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h
lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
lldb/source/Plugins/Platform/Android/AdbClient.cpp
lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm64.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_i386.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_x86_64.cpp
lldb/source/Plugins/Process/Utility/HistoryUnwind.cpp
lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp
lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp
lldb/source/Plugins/Process/Utility/RegisterContextDarwin_i386.cpp
lldb/source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp
lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.cpp
lldb/source/Plugins/Process/Utility/RegisterContextMach_arm.cpp
lldb/source/Plugins/Process/Utility/RegisterContextMach_i386.cpp
lldb/source/Plugins/Process/Utility/RegisterContextMach_x86_64.cpp
lldb/source/Plugins/Process/Utility/RegisterContextMemory.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.cpp
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp
lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.cpp
lldb/source/Plugins/Process/Utility/RegisterInfoInterface.h
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm.cpp
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_mips64.cpp
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_powerpc.cpp
lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_s390x.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationHistory.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
lldb/source/Plugins/Process/minidump/ThreadMinidump.cpp
lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp
lldb/source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.cpp
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h
lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h
lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h
lldb/source/Plugins/SymbolFile/DWARF/NameToDIE.h
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
lldb/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.h
lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.h
lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.h
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.h
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp
lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h
lldb/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.h
lldb/source/Symbol/ArmUnwindInfo.cpp
lldb/source/Symbol/Block.cpp
lldb/source/Symbol/CompactUnwindInfo.cpp
lldb/source/Symbol/FuncUnwinders.cpp
lldb/source/Symbol/Function.cpp
lldb/source/Symbol/LineTable.cpp
lldb/source/Symbol/SymbolContext.cpp
lldb/source/Symbol/Symtab.cpp
lldb/source/Symbol/TypeList.cpp
lldb/source/Symbol/TypeMap.cpp
lldb/source/Symbol/TypeSystem.cpp
lldb/source/Symbol/UnwindTable.cpp
lldb/source/Symbol/Variable.cpp
lldb/source/Symbol/VariableList.cpp
lldb/source/Target/JITLoaderList.cpp
lldb/source/Target/Language.cpp
lldb/source/Target/Memory.cpp
lldb/source/Target/QueueItem.cpp
lldb/source/Target/StructuredDataPlugin.cpp
lldb/source/Target/ThreadPlanBase.cpp
lldb/source/Target/ThreadPlanCallUserExpression.cpp
lldb/source/Target/ThreadPlanStepOverBreakpoint.cpp
lldb/source/Utility/ArchSpec.cpp
lldb/source/Utility/Args.cpp
lldb/source/Utility/DataBufferLLVM.cpp
lldb/source/Utility/Event.cpp
lldb/source/Utility/GDBRemote.cpp
lldb/source/Utility/Stream.cpp
lldb/source/Utility/StreamString.cpp
lldb/source/Utility/StringExtractor.cpp
lldb/source/Utility/StringList.cpp
lldb/source/Utility/TildeExpressionResolver.cpp
|
We can also default this as well, we can use member initializers for these values.