Page MenuHomePhabricator

[SYCL] Enable `opencl_global_[host,device]` attributes for SYCL
Needs ReviewPublic

Authored by bader on Tue, Apr 13, 10:14 AM.

Details

Diff Detail

Event Timeline

bader created this revision.Tue, Apr 13, 10:14 AM
bader requested review of this revision.Tue, Apr 13, 10:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Apr 13, 10:14 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Ok, this looks like a straightforward addition. I will finalize this review once the parent review is completed though.

bader updated this revision to Diff 340528.Mon, Apr 26, 7:58 AM

Rebase on ToT

Anastasia added inline comments.Fri, Apr 30, 6:37 AM
clang/include/clang/AST/Type.h
489

Ok, so you want to allow converting implicitly to global but not to device/host?

Let's update the doc straight away!

clang/test/SemaSYCL/address-space-conversions.cpp
74

Let's add explicit casts too.

aaron.ballman added inline comments.Fri, Apr 30, 6:40 AM
clang/lib/AST/ItaniumMangle.cpp
2495

Can you also update this comment?