Page MenuHomePhabricator

ldrumm (Luke Drummond)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2015, 7:42 AM (261 w, 2 d)

Recent Activity

Tue, Nov 17

ldrumm committed rG537cbd90c43d: Escape command line arguments in backtraces (authored by ldrumm).
Escape command line arguments in backtraces
Tue, Nov 17, 4:16 AM
ldrumm closed D90759: Escape command line arguments in backtraces.
Tue, Nov 17, 4:16 AM · Restricted Project

Mon, Nov 16

ldrumm updated the diff for D90759: Escape command line arguments in backtraces.

Patch updated to not insert trailing blank

Mon, Nov 16, 10:30 AM · Restricted Project

Fri, Nov 13

ldrumm added a comment to D90759: Escape command line arguments in backtraces.

I absent mindedly responded to this review via email, without actually checking whether Phabricator supports this. Apologies for the delay

Fri, Nov 13, 9:38 AM · Restricted Project

Wed, Nov 4

ldrumm updated the diff for D90759: Escape command line arguments in backtraces.

included full diff context

Wed, Nov 4, 5:45 AM · Restricted Project
ldrumm added a comment to D90759: Escape command line arguments in backtraces.

An example of the output:

Wed, Nov 4, 4:51 AM · Restricted Project
ldrumm requested review of D90759: Escape command line arguments in backtraces.
Wed, Nov 4, 4:51 AM · Restricted Project

Aug 25 2020

ldrumm added inline comments to D84877: Support for soft fp16 to fp64 IEEE conversions.
Aug 25 2020, 7:06 AM · Restricted Project, Restricted Project

Aug 21 2020

ldrumm updated the diff for D84877: Support for soft fp16 to fp64 IEEE conversions.
Aug 21 2020, 5:36 AM · Restricted Project, Restricted Project
ldrumm added inline comments to D84877: Support for soft fp16 to fp64 IEEE conversions.
Aug 21 2020, 4:56 AM · Restricted Project, Restricted Project

Aug 20 2020

ldrumm updated the diff for D84877: Support for soft fp16 to fp64 IEEE conversions.
Aug 20 2020, 10:14 AM · Restricted Project, Restricted Project
ldrumm added inline comments to D84877: Support for soft fp16 to fp64 IEEE conversions.
Aug 20 2020, 9:38 AM · Restricted Project, Restricted Project

Jul 29 2020

ldrumm requested review of D84877: Support for soft fp16 to fp64 IEEE conversions.
Jul 29 2020, 11:07 AM · Restricted Project, Restricted Project

Mar 12 2020

ldrumm committed rG0fa3320931e9: [lldb] reject `.debug_arange` sections with nonzero segment size (authored by ldrumm).
[lldb] reject `.debug_arange` sections with nonzero segment size
Mar 12 2020, 5:54 AM
ldrumm closed D75925: [lldb] reject `.debug_arange` sections with nonzero segment size.
Mar 12 2020, 5:54 AM · Restricted Project

Mar 11 2020

ldrumm updated the diff for D75925: [lldb] reject `.debug_arange` sections with nonzero segment size.

I found similar unittests for other DWARF entries which allow me to check more about the parser state, so I went with Pavel's suggestion for the testcase

Mar 11 2020, 10:09 AM · Restricted Project

Mar 10 2020

ldrumm created D75925: [lldb] reject `.debug_arange` sections with nonzero segment size.
Mar 10 2020, 8:39 AM · Restricted Project

Jan 27 2020

ldrumm committed rG482e890d1f94: [tablegen] Emit string literals instead of char arrays (authored by ldrumm).
[tablegen] Emit string literals instead of char arrays
Jan 27 2020, 10:29 AM
ldrumm closed D73044: {tablegen] Emit string literals instead of char arrays.
Jan 27 2020, 10:28 AM · Restricted Project
ldrumm reopened D73044: {tablegen] Emit string literals instead of char arrays.
Jan 27 2020, 7:43 AM · Restricted Project
ldrumm updated the diff for D73044: {tablegen] Emit string literals instead of char arrays.

Now emit long-string disabling GCC diagnostic pragmas around string definitions to silence gcc's -Woverlength-strings on a case-by-case basis

Jan 27 2020, 7:43 AM · Restricted Project

Jan 24 2020

ldrumm added inline comments to D73044: {tablegen] Emit string literals instead of char arrays.
Jan 24 2020, 4:08 AM · Restricted Project
ldrumm added inline comments to D73044: {tablegen] Emit string literals instead of char arrays.
Jan 24 2020, 4:08 AM · Restricted Project

Jan 23 2020

ldrumm updated the diff for D73044: {tablegen] Emit string literals instead of char arrays.
  • only pass the --long-string-literals flags to *LLVM* tablegen (fixes clang-tablegen problem)
  • suppress overlenth-string-literals warning seen in the wild: this behaviour is intended and shouldn't be warned against
Jan 23 2020, 9:40 AM · Restricted Project
ldrumm added a comment to D73044: {tablegen] Emit string literals instead of char arrays.

Hello @ldrumm,

Sorry, I had to revert this commit in e464b31c1565204e3be114d043bcbf4de61fe2e9, because it broke some Windows builds:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13870

Jan 23 2020, 7:52 AM · Restricted Project
ldrumm committed rGce23515f5ab0: [tablegen] Emit string literals instead of char arrays (authored by ldrumm).
[tablegen] Emit string literals instead of char arrays
Jan 23 2020, 6:03 AM
ldrumm closed D73044: {tablegen] Emit string literals instead of char arrays.
Jan 23 2020, 6:03 AM · Restricted Project

Jan 21 2020

ldrumm updated the diff for D73044: {tablegen] Emit string literals instead of char arrays.

Remove compile-time detection. Make this a runtime only flag

Jan 21 2020, 11:37 AM · Restricted Project
ldrumm added a comment to D73044: {tablegen] Emit string literals instead of char arrays.

First char of the title: { -> [.

Thanks. Phabricator doesn't seem to track the git commit message, but I've fixed this is on my tree

Jan 21 2020, 8:36 AM · Restricted Project
mstojanovic awarded D73044: {tablegen] Emit string literals instead of char arrays a Love token.
Jan 21 2020, 3:46 AM · Restricted Project
ldrumm updated the diff for D73044: {tablegen] Emit string literals instead of char arrays.

Change the cmake flag check to if(MSVC) rather than if(CMAKE_GENERATOR MATCHES "Visual Studio"). CMAKE_GENERATOR is not the compiler

Jan 21 2020, 3:41 AM · Restricted Project

Jan 20 2020

ldrumm updated the diff for D73044: {tablegen] Emit string literals instead of char arrays.
Jan 20 2020, 10:07 AM · Restricted Project
ldrumm updated the diff for D73044: {tablegen] Emit string literals instead of char arrays.

Ensure elaborate cross-compilation setups are supported

Jan 20 2020, 10:07 AM · Restricted Project
ldrumm created D73044: {tablegen] Emit string literals instead of char arrays.
Jan 20 2020, 7:03 AM · Restricted Project

Jan 15 2020

ldrumm abandoned D22060: [expression evaluation] Prevent invalid function declarations ending up in clang AST.
Jan 15 2020, 6:48 AM

Jan 4 2017

ldrumm committed rL290957: Add a debuginfo version check for RenderScript modules.
Add a debuginfo version check for RenderScript modules
Jan 4 2017, 4:21 AM

Dec 22 2016

ldrumm committed rL290359: Fix a couple of incorrect format string warnings.
Fix a couple of incorrect format string warnings
Dec 22 2016, 11:25 AM
ldrumm closed D28028: Fix a couple of incorrect format strings by committing rL290359: Fix a couple of incorrect format string warnings.
Dec 22 2016, 11:25 AM
ldrumm updated the diff for D28028: Fix a couple of incorrect format strings.

switched to the new llvm::Format API

Dec 22 2016, 5:22 AM

Dec 21 2016

ldrumm retitled D28028: Fix a couple of incorrect format strings from to Fix a couple of incorrect format strings.
Dec 21 2016, 12:30 PM
ldrumm updated the diff for D17719: Track expression language from one place in ClangExpressionParser.

This patch was committed back in March https://reviews.llvm.org/rL263099 and then reverted 2 hours later in https://reviews.llvm.org/rL263107 due to a testing failure on greendragon related to ObjC. Unfortunately, I no longer have access to Apple hardware (and at the time the testsuite passed on my local mac), so I'm unable to find out exactly what went wrong.

Dec 21 2016, 11:50 AM · Restricted Project
ldrumm reopened D17719: Track expression language from one place in ClangExpressionParser.

This patch was committed back in March https://reviews.llvm.org/rL263099 and then reverted 2 hours later in https://reviews.llvm.org/rL263107 due to a testing failure on greendragon related to ObjC. Unfortunately, I no longer have access to Apple hardware (and at the time the testsuite passed on my local mac), so I'm unable to find out exactly what went wrong.

Dec 21 2016, 11:49 AM · Restricted Project

Dec 19 2016

ldrumm abandoned D20825: Don't force Python2.7.
Dec 19 2016, 10:37 AM
ldrumm abandoned D22370: Respect LLVM_HOST_TRIPLE when manually specified.
Dec 19 2016, 10:36 AM
ldrumm committed rL290117: Expression evaluation for overloaded C functions (redux).
Expression evaluation for overloaded C functions (redux)
Dec 19 2016, 9:33 AM
ldrumm closed D27223: Expression evaluation for overloaded C functions (redux) by committing rL290117: Expression evaluation for overloaded C functions (redux).
Dec 19 2016, 9:33 AM

Dec 16 2016

ldrumm committed rL289956: Fix broken escaping of commands in the build.
Fix broken escaping of commands in the build
Dec 16 2016, 8:49 AM
ldrumm closed D26757: Fix broken escaping of commands in the build by committing rL289956: Fix broken escaping of commands in the build.
Dec 16 2016, 8:49 AM
ldrumm added inline comments to D27223: Expression evaluation for overloaded C functions (redux).
Dec 16 2016, 7:06 AM
ldrumm updated the diff for D27223: Expression evaluation for overloaded C functions (redux).

updated to use StringRef-based parser rather than char pointers

Dec 16 2016, 7:06 AM

Dec 15 2016

ldrumm added a comment to D26757: Fix broken escaping of commands in the build.

ping

Dec 15 2016, 9:46 AM

Nov 29 2016

ldrumm added a comment to D17957: Expression evaluation for overloaded C functions.

New candidate is here

Nov 29 2016, 12:18 PM
ldrumm retitled D27223: Expression evaluation for overloaded C functions (redux) from to Expression evaluation for overloaded C functions (redux).
Nov 29 2016, 12:16 PM
ldrumm updated the diff for D26757: Fix broken escaping of commands in the build.

Addressed some unwanted whitespace changes as suggested by @bryant; use os.dir.curdir as instead of .

Nov 29 2016, 8:24 AM

Nov 18 2016

ldrumm added a comment to D20825: Don't force Python2.7.

@chandlerc any more thoughts on this?

Nov 18 2016, 8:22 AM

Nov 16 2016

ldrumm added inline comments to D26757: Fix broken escaping of commands in the build.
Nov 16 2016, 12:31 PM
ldrumm added inline comments to D26757: Fix broken escaping of commands in the build.
Nov 16 2016, 12:11 PM
ldrumm added inline comments to D26757: Fix broken escaping of commands in the build.
Nov 16 2016, 12:09 PM
ldrumm added inline comments to D26757: Fix broken escaping of commands in the build.
Nov 16 2016, 12:06 PM
ldrumm added inline comments to D26757: Fix broken escaping of commands in the build.
Nov 16 2016, 12:04 PM
ldrumm added inline comments to D26757: Fix broken escaping of commands in the build.
Nov 16 2016, 11:43 AM
ldrumm retitled D26757: Fix broken escaping of commands in the build from to Fix broken escaping of commands in the build.
Nov 16 2016, 11:37 AM

Nov 9 2016

ldrumm committed rL286387: [RenderScript] Fix reduction argument printing.
[RenderScript] Fix reduction argument printing
Nov 9 2016, 11:30 AM

Oct 13 2016

ldrumm added inline comments to D25396: Fix Python binding generation build step on Windows.
Oct 13 2016, 7:30 AM · Restricted Project

Oct 5 2016

ldrumm committed rL283362: Add the ability to set breakpoints on named RenderScript reductions.
Add the ability to set breakpoints on named RenderScript reductions
Oct 5 2016, 12:19 PM
ldrumm committed rL283335: [RenderScript] reflow/reword some comments and normalize names.
[RenderScript] reflow/reword some comments and normalize names
Oct 5 2016, 9:36 AM
ldrumm committed rL283320: cleanup RSCoordinate handling and factor out coordinate parser.
cleanup RSCoordinate handling and factor out coordinate parser
Oct 5 2016, 7:43 AM
ldrumm committed rL283313: Delete unused global in ClangExpressionVariable.cpp.
Delete unused global in ClangExpressionVariable.cpp
Oct 5 2016, 5:50 AM
ldrumm closed D24793: Delete an (apparently unused) global in ClangExpressionVaraible.cpp by committing rL283313: Delete unused global in ClangExpressionVariable.cpp.
Oct 5 2016, 5:49 AM · Restricted Project

Sep 21 2016

ldrumm committed rL282066: Remove an invalid doxygen `@return` docstring on a void function.
Remove an invalid doxygen `@return` docstring on a void function
Sep 21 2016, 4:21 AM
ldrumm retitled D24793: Delete an (apparently unused) global in ClangExpressionVaraible.cpp from to Delete an (apparently unused) global in ClangExpressionVaraible.cpp.
Sep 21 2016, 4:06 AM · Restricted Project

Sep 16 2016

ldrumm committed rL281717: [RenderScript] Support tracking and dumping reduction kernels.
[RenderScript] Support tracking and dumping reduction kernels
Sep 16 2016, 4:37 AM

Aug 31 2016

ldrumm committed rL280240: [clang-format-vim] Support vim linked against py3.
[clang-format-vim] Support vim linked against py3
Aug 31 2016, 6:45 AM
ldrumm closed D23319: [vim clang-format.py] python3 support by committing rL280240: [clang-format-vim] Support vim linked against py3.
Aug 31 2016, 6:44 AM · Restricted Project

Aug 22 2016

ldrumm added a comment to D23319: [vim clang-format.py] python3 support.

@djasper, I don't seem to have commit access to cfe so awould you be willing to commit this on my behalf?

Aug 22 2016, 7:54 AM · Restricted Project

Aug 9 2016

ldrumm updated the diff for D23319: [vim clang-format.py] python3 support.

Make print output the same 2-3

Aug 9 2016, 7:46 AM · Restricted Project
ldrumm retitled D23319: [vim clang-format.py] python3 support from to [vim clang-format.py] python3 support.
Aug 9 2016, 7:31 AM · Restricted Project

Aug 3 2016

ldrumm committed rL277613: [RenderScript] Always create a new allocation ID in CaptureAllocationInit hook.
[RenderScript] Always create a new allocation ID in CaptureAllocationInit hook
Aug 3 2016, 10:39 AM
ldrumm committed rL277608: Fix an unused variable warning in release builds..
Fix an unused variable warning in release builds.
Aug 3 2016, 9:37 AM

Jul 28 2016

ldrumm committed rL277016: Cleanup some format string warnings.
Cleanup some format string warnings
Jul 28 2016, 11:27 AM
ldrumm closed D22923: cleanup some format string warnings by committing rL277016: Cleanup some format string warnings.
Jul 28 2016, 11:27 AM · Restricted Project
ldrumm added a comment to D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend.

I've got a fix to make this work in Xcode, but I'm currently stuck behind the missing Condition.cpp from r277011 to verify.

Thanks Todd. I don't really deal with XCode, so that's a real help.

My pleasure! We expect to need to do this on the Xcode side since we aren't using cmake like everyone else.

Regarding r277012, I'm a little confused about the message "Also, fixed up typos in RenderScript code that could not possibly compile." Is this code broken somehow? It build for us with GCC, and green dragon seems fine with it. Is there some particular compiler for which this is broken because everything "Works for Me"?

Nope nope you're fine. I tried to quickly fix my comment in follow ups to my commit message emails. I looked too quickly at the filenames and figured the error was introduced from the RenderScript change. It was in fact from Saleem's change. It was in files that he couldn't compile unless he was on Xcode, so the typos came in there.

Jul 28 2016, 11:20 AM
ldrumm added a comment to D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend.

I've got a fix to make this work in Xcode, but I'm currently stuck behind the missing Condition.cpp from r277011 to verify.

Jul 28 2016, 11:15 AM
ldrumm retitled D22923: cleanup some format string warnings from to cleanup some format string warnings.
Jul 28 2016, 9:18 AM · Restricted Project
ldrumm committed rL276976: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86….
Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86…
Jul 28 2016, 7:29 AM
ldrumm closed D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend by committing rL276976: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86….
Jul 28 2016, 7:28 AM
ldrumm updated the diff for D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend.
Jul 28 2016, 7:14 AM

Jul 18 2016

ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

Sorry Chris, I didn't see this one. It appeared while I was posting my last message

Jul 18 2016, 7:58 AM
ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

LLVM_HOST_TRIPLE is not intended to match the target, and it shouldn't be used in situations where it must match the target. I'm not familiar with how lldb builds the remote server in CMake, but using LLVM_HOST_TRIPLE is not the right answer.

Jul 18 2016, 6:48 AM
ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

Supporting specifying the triple manually is a completely separate issue from the bug you encountered. I'd prefer to make target detection for windows work correctly and reliably so that we don't need to support setting LLVM_HOST_TRIPLE manually. Other than the bugs in get_host_triple, is there a reason you feel the need to set the host triple manually?

Jul 18 2016, 3:39 AM

Jul 15 2016

ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

I very much believe you are doing something wrong.

Your description of the problem doesn't match the error message, and I can tell you that the solution *isn't* to make get_host_triple return anything that isn't actually the host triple.

Jul 15 2016, 9:27 AM
ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

Can you explain why this is necessary when cross-targeting? I kinda feel that the problem is more likely that the LLVM_HOST_TRIPLE is being used in places where a *target* triple should be used.

Jul 15 2016, 5:18 AM

Jul 14 2016

ldrumm added a reviewer for D22370: Respect LLVM_HOST_TRIPLE when manually specified: clayborg.
Jul 14 2016, 10:50 AM
ldrumm retitled D22370: Respect LLVM_HOST_TRIPLE when manually specified from to Respect LLVM_HOST_TRIPLE when manually specified.
Jul 14 2016, 10:49 AM

Jul 7 2016

ldrumm committed rL274776: Respect ANDROID_SERIAL environment variable used by ADB.
Respect ANDROID_SERIAL environment variable used by ADB
Jul 7 2016, 11:10 AM
ldrumm closed D22052: Respect `ANDROID_SERIAL` environment variable used by ADB by committing rL274776: Respect ANDROID_SERIAL environment variable used by ADB.
Jul 7 2016, 11:09 AM
ldrumm added inline comments to D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file.
Jul 7 2016, 7:59 AM
ldrumm updated the diff for D22052: Respect `ANDROID_SERIAL` environment variable used by ADB.
  • Ensure if ANDROID_SERIAL is set, it exists in the list of connected devices (Address feedback from @ovyalov)
  • Also add a hint in the error message in case multiple devices are attached and no serial number is available.
Jul 7 2016, 5:24 AM

Jul 6 2016

ldrumm retitled D22060: [expression evaluation] Prevent invalid function declarations ending up in clang AST from to [expression evaluation] Prevent invalid function declarations ending up in clang AST.
Jul 6 2016, 11:29 AM
ldrumm retitled D22052: Respect `ANDROID_SERIAL` environment variable used by ADB from to Respect `ANDROID_SERIAL` environment variable used by ADB.
Jul 6 2016, 9:51 AM