This is an archive of the discontinued LLVM Phabricator instance.

Differential D98705

[OpenCL] Prefer CodeGenFunction::EmitRuntimeCall
ClosedPublic

Authored by ldrumm on Mar 16 2021, 6:34 AM.

Details

Reviewers
Anastasia
bader
Commits
rG440f6bdf34f4: [OpenCL][NFCI] Prefer CodeGenFunction::EmitRuntimeCall
Summary

CodeGenFunction::EmitRuntimeCall automatically sets the right calling │
convention for the callee so we can avoid setting it ourselves

Diff Detail

Unit TestsFailed

TimeTest
1,160 msx64 windows > lit.lit::reorder.py

Event Timeline

ldrumm created this revision.Mar 16 2021, 6:34 AM
Herald added a subscriber: yaxunl. · View Herald TranscriptMar 16 2021, 6:34 AM
ldrumm requested review of this revision.Mar 16 2021, 6:34 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptMar 16 2021, 6:34 AM
Harbormaster completed remote builds in B94038: Diff 330965.Mar 16 2021, 7:20 AM
Anastasia accepted this revision.Mar 16 2021, 9:10 AM

LGTM! Thanks!

This revision is now accepted and ready to land.Mar 16 2021, 9:10 AM
This revision was landed with ongoing or failed builds.Mar 16 2021, 9:23 AM
Closed by commit rG440f6bdf34f4: [OpenCL][NFCI] Prefer CodeGenFunction::EmitRuntimeCall (authored by ldrumm). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldrumm added a commit: rG440f6bdf34f4: [OpenCL][NFCI] Prefer CodeGenFunction::EmitRuntimeCall.

Revision Contents

PathSize
clang/
lib/
CodeGen/
3 lines

Diff 330965

clang/lib/CodeGen/CodeGenModule.cpp

Show First 20 Lines • Show All 6,259 Lines • ▼ Show 20 Lines
} }
llvm::Value * llvm::Value *
CodeGenModule::createOpenCLIntToSamplerConversion(const Expr *E, CodeGenModule::createOpenCLIntToSamplerConversion(const Expr *E,
CodeGenFunction &CGF) { CodeGenFunction &CGF) {
llvm::Constant *C = ConstantEmitter(CGF).emitAbstract(E, E->getType()); llvm::Constant *C = ConstantEmitter(CGF).emitAbstract(E, E->getType());
auto *SamplerT = getOpenCLRuntime().getSamplerType(E->getType().getTypePtr()); auto *SamplerT = getOpenCLRuntime().getSamplerType(E->getType().getTypePtr());
auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false); auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false);
auto *Call = CGF.Builder.CreateCall( auto *Call = CGF.EmitRuntimeCall(
CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C}); CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C});
Call->setCallingConv(Call->getCalledFunction()->getCallingConv());
return Call; return Call;
} }
CharUnits CodeGenModule::getNaturalPointeeTypeAlignment( CharUnits CodeGenModule::getNaturalPointeeTypeAlignment(
QualType T, LValueBaseInfo *BaseInfo, TBAAAccessInfo *TBAAInfo) { QualType T, LValueBaseInfo *BaseInfo, TBAAAccessInfo *TBAAInfo) {
return getNaturalTypeAlignment(T->getPointeeType(), BaseInfo, TBAAInfo, return getNaturalTypeAlignment(T->getPointeeType(), BaseInfo, TBAAInfo,
/* forPointeeType= */ true); /* forPointeeType= */ true);
} }
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines