Differential D98574
[Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+ Authored by glaubitz on Mar 13 2021, 12:52 AM.
Details Currently, clang defines the three macros sparcv9, sparcv9__ Since neither gcc nor SolarisStudio define sparcv9 and sparcv9__ Fixes PR49562.
Diff Detail
Event TimelineComment Actions I do not immediately see why the other tests are failing, but at a bare minimum the following test from clang/test/Preprocessor/predefined-arch-macros.c will have to be updated.. // RUN: %clang -mcpu=v9 -E -dM %s -o - 2>&1 \ // RUN: -target sparc-unknown-linux \ // RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_SPARC-V9 // CHECK_SPARC-V9-NOT: #define __sparcv8 1 // CHECK_SPARC-V9-NOT: #define __sparcv8__ 1 // CHECK_SPARC-V9: #define __sparc_v9__ 1 // CHECK_SPARC-V9: #define __sparcv9 1 // CHECK_SPARC-V9: #define __sparcv9__ 1
Comment Actions For reference, here is what GCC defines on Linux with regards to SPARC: glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep arch glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep LP glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep v9 #define __sparc_v9__ 1 glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m64 - |grep arch #define __arch64__ 1 glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m64 - |grep LP #define __LP64__ 1 #define _LP64 1 glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m64 - |grep v9 #define __sparc_v9__ 1 glaubitz@gcc202:~$ And here is what it defines on OpenBSD: openbsd# echo | gcc -E -dM -mcpu=v9 -m64 - |grep arch #define __arch64__ 1 openbsd# echo | gcc -E -dM -mcpu=v9 -m64 - |grep LP #define __LP64__ 1 #define _LP64 1 openbsd# echo | gcc -E -dM -mcpu=v9 -m64 - |grep sparc #define sparc 1 #define __sparc__ 1 #define __sparc 1 #define __sparc64__ 1 #define __sparcv9__ 1 #define __sparc_v9__ 1 openbsd# -m32 is not supported on OpenBSD at all: openbsd# echo | gcc -E -dM -m32 - :0: error: -m32 is not supported by this configuration openbsd# For NetBSD, we have: $ echo | gcc -E -dM -mcpu=v9 -m32 - |grep sparc #define sparc 1 #define __sparc__ 1 #define __sparc 1 #define __sparc_v9__ 1 $ echo | gcc -E -dM -mcpu=v9 -m64 - |grep sparc #define sparc 1 #define __sparc__ 1 #define __sparcv9 1 #define __sparc 1 #define __sparc64__ 1 #define __sparc_v9__ 1 $ echo | gcc -E -dM -mcpu=v9 -m32 - |grep LP $ echo | gcc -E -dM -mcpu=v9 -m64 - | grep LP #define __LP64__ 1 #define _LP64 1 $ echo | gcc -E -dM -mcpu=v9 -m32 - | grep arch $ echo | gcc -E -dM -mcpu=v9 -m64 - | grep arch #define __arch64__ 1 And with the native 32-bit compiler on NetBSD, we get: $ echo | gcc -E -dM -mcpu=v9 - | grep sparc #define sparc 1 #define __sparc__ 1 #define __sparc 1 #define __sparc_v9__ 1 $ echo | gcc -E -dM -mcpu=v9 - | grep LP $ echo | gcc -E -dM -mcpu=v9 - | grep arch So, I think clang behaves correctly with the changes in this diff - although it does not account for the difference between OpenBSD and NetBSD. Comment Actions I have updated the patch now with the result that clang should behave as GCC now on Linux, NetBSD and OpenBSD.
Comment Actions The NetBSD part looks ok, but also lacks proper testing. I'm not sure anyone but Linux cares at all otherwise as they lack 32bit SPARC support. Comment Actions Well, there were no tests for NetBSD before, so I didn't change anything in this regard. I only changed clang to behave as gcc on SPARC and I
Comment Actions Made changes according to review and dropped every change except removing sparcv9 and sparcv9__. Comment Actions Updated the patch as requested and dropped all changes except the removal of sparcv9 and sparcv9__. | |||||||||||||||||||||||||||||||||||||||||||||