User Details
- User Since
- Jul 1 2016, 4:12 AM (237 w, 6 d)
Nov 25 2020
Nov 24 2020
Nov 23 2020
- Move declarations to new sanitizer_solaris.h.
- Augment check_linker_flag do reject unknown -z options that GNU ld noisily accepts.
Nov 20 2020
getpass.cpp changed to UNSUPPORTED.
- Switch disablement to SKIP_ON_* form.
- Add FIXME comment.
Only disable actually failing tests using the SKIP_ON_* form.
Nov 19 2020
Nov 18 2020
Nov 17 2020
Nov 13 2020
Superceded by D90524.
Nov 9 2020
As I'd mentioned in D90524, I believe both patches should be merged into one. Otherwise, no matter in which order you commit them, the buildbots might show failures otherwise.
As it happens, I'd arrived at exactly the same patch when I tried a build on a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582.
Oct 14 2020
Oct 13 2020
Align the last affected instance.
Oct 9 2020
Oct 8 2020
Oct 7 2020
Oct 6 2020
Use alignas.
Oct 5 2020
Add assertion.
Run clang-format.
Sep 30 2020
Ping? It's been almost a week.
This patch broke builds with gcc, e.g. Builder clang-solaris11-amd64 Build #6724:
[23/122] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o FAILED: tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o /usr/gcc/9/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/clangd/tool -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool -Itools/clang/tools/extra/clangd/../clang-tidy -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include -Itools/clang/include -Iinclude -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include/llvm/Support/Solaris -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/.. -Itools/clang/tools/extra/clangd/tool/.. -Itools/clang/tools/extra/clangd -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o -MF tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o.d -o tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o -c /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp:9: /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdLSPServer.h:47:36: error: declaration of ‘llvm::Optional<clang::clangd::OffsetEncoding> clang::clangd::ClangdLSPServer::Options::OffsetEncoding’ changes meaning of ‘OffsetEncoding’ [-fpermissive] 47 | llvm::Optional<OffsetEncoding> OffsetEncoding; | ^~~~~~~~~~~~~~ In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../Headers.h:12, from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../CodeComplete.h:19, from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdServer.h:13, from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdLSPServer.h:12, from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp:9: /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../Protocol.h:370:12: note: ‘OffsetEncoding’ declared here as ‘enum class clang::clangd::OffsetEncoding’ 370 | enum class OffsetEncoding { | ^~~~~~~~~~~~~~
Sep 29 2020
Sep 28 2020
Sep 24 2020
Sep 20 2020
Sep 18 2020
Wrap whole file in if(LLVM_ENABLE_PIC).
Sep 17 2020
Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd.
As described in D87825, this patch broke Debug builds on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11.
Sep 16 2020
- Rely on stackAlignment default for 32-bit Solaris/x86
- Handle Solaris in llvm/test/CodeGen/X86/stack-align2.ll
Sep 15 2020
Allow for whitespace differences in vptr.cpp.
Tested on amd64-pc-solaris2.11. However, compared to the -mstackrealign version
there's one regression that I still need to investigate:
UBSan-Standalone-i386 :: TestCases/TypeCheck/vptr.cpp
That claim of 16-byte alignment on Solaris is half-wrong: it's definitely wrong on Solaris, but seems to be true on Illumos.
Sep 14 2020
Sep 11 2020
Sep 10 2020
Ping? It's been a week and AFAICT there's nothing left for me to do.
Sep 4 2020
Is there anything left to do to get approval? Thanks.
Sep 3 2020
Add FIXME for SparcV8 MaxAtomicInlineWidth.