Page MenuHomePhabricator

ro (Rainer Orth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2016, 4:12 AM (155 w, 4 d)

Recent Activity

Today

ro added a reviewer for D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc: samsonov.
Tue, Jun 25, 5:52 AM · Restricted Project, Restricted Project
ro created D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc.
Tue, Jun 25, 5:45 AM · Restricted Project, Restricted Project
ro updated the diff for D63761: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris.

Sorry, wrong patch.

Tue, Jun 25, 4:49 AM · Restricted Project, Restricted Project
ro created D63761: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris.
Tue, Jun 25, 4:36 AM · Restricted Project, Restricted Project
ro created D63757: [zorg] Fixes for solaris11-amd64, solaris11-sparcv9 builders.
Tue, Jun 25, 1:26 AM · Restricted Project, Restricted Project

Fri, Jun 21

ro added a comment to D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris.
In D63678#1554508, @rnk wrote:

I would almost prefer to XFAIL this on Solaris, I feel like the intent is clearer with echo.

Fri, Jun 21, 4:32 PM · Restricted Project, Restricted Project

Thu, Jun 20

ro committed rGd5f16d6cfccc: [test][Driver] Fix Clang :: Driver/cl-response-file.c (authored by ro).
[test][Driver] Fix Clang :: Driver/cl-response-file.c
Thu, Jun 20, 2:32 PM
ro committed rL363985: [test][Driver] Fix Clang :: Driver/cl-response-file.c.
[test][Driver] Fix Clang :: Driver/cl-response-file.c
Thu, Jun 20, 2:29 PM
ro closed D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c.
Thu, Jun 20, 2:29 PM · Restricted Project, Restricted Project
ro committed rG6fde832b82da: [profile] Solaris ld supports __start___llvm_prof_data etc. labels (authored by ro).
[profile] Solaris ld supports __start___llvm_prof_data etc. labels
Thu, Jun 20, 2:26 PM
ro committed rL363984: [profile] Solaris ld supports __start___llvm_prof_data etc. labels.
[profile] Solaris ld supports __start___llvm_prof_data etc. labels
Thu, Jun 20, 2:25 PM
ro closed D41111: [profile] Solaris ld supports __start___llvm_prof_data etc. labels.
Thu, Jun 20, 2:25 PM · Restricted Project
ro created D63602: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.
Thu, Jun 20, 7:23 AM · Restricted Project
ro created D63601: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris.
Thu, Jun 20, 7:19 AM · Restricted Project, Restricted Project
ro updated the diff for D41111: [profile] Solaris ld supports __start___llvm_prof_data etc. labels.

Rebased an slightly fixed version. Without it, man profiling tests on Solaris FAIL like

Command Output (stderr):
--
Undefined                       first referenced
 symbol                             in file
__llvm_profile_register_names_function /tmp/lit_tmp_Nqu4eh/infinite_loop-9dc638.o
__llvm_profile_register_function    /tmp/lit_tmp_Nqu4eh/infinite_loop-9dc638.o

I don't think we need to worry about older versions of Solaris ld that don't support
__start_SECNAME and stop_SECNAME labels any longer: that feature is in
Solaris 11.4 and we already use Solaris 11.4-only features like ld -z gnu-version-script-compat
and fully working .preinit_array suport in compiler-rt.

Thu, Jun 20, 7:03 AM · Restricted Project
ro created D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c.
Thu, Jun 20, 6:35 AM · Restricted Project, Restricted Project
ro created D63598: [unittests][Support] Fix LLVM-Unit :: Support/./SupportTests/FileSystemTest.permissions on Solaris.
Thu, Jun 20, 6:25 AM · Restricted Project

Wed, Jun 19

ro committed rL363785: [zorg] Add solaris11-amd64, solaris11-sparcv9 builders.
[zorg] Add solaris11-amd64, solaris11-sparcv9 builders
Wed, Jun 19, 3:26 AM
ro closed D63495: [zorg] Add solaris11-amd64, solaris11-sparcv9 builders.
Wed, Jun 19, 3:26 AM · Restricted Project, Restricted Project
ro updated the diff for D63495: [zorg] Add solaris11-amd64, solaris11-sparcv9 builders.

Further testing in the exact buildbot user environment revealed that I'd forgotten one
crucial option: clang calls the linker with Solaris ld-only options. If GNU ld happens to
be earlier in PATH at link time, this breaks the build.

Wed, Jun 19, 2:01 AM · Restricted Project, Restricted Project
ro committed rGcd31e7868b3e: [Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5 (authored by ro).
[Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5
Wed, Jun 19, 1:57 AM
ro committed rL363778: [Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5.
[Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5
Wed, Jun 19, 1:56 AM
ro closed D62892: [Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5.
Wed, Jun 19, 1:56 AM · Restricted Project, Restricted Project
ro added a comment to D62892: [Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5.

Ping^2. It's been two weeks now for a trivial patch fixing the build...

Wed, Jun 19, 1:01 AM · Restricted Project, Restricted Project

Tue, Jun 18

ro created D63495: [zorg] Add solaris11-amd64, solaris11-sparcv9 builders.
Tue, Jun 18, 7:55 AM · Restricted Project, Restricted Project

Mon, Jun 17

ro committed rGabccb1ad896f: Clang :: Sema/wchar.c has long been failing on Solaris: (authored by ro).
Clang :: Sema/wchar.c has long been failing on Solaris:
Mon, Jun 17, 1:21 PM
ro committed rL363612: Clang :: Sema/wchar.c has long been failing on Solaris:.
Clang :: Sema/wchar.c has long been failing on Solaris:
Mon, Jun 17, 1:18 PM
ro closed D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris.
Mon, Jun 17, 1:18 PM · Restricted Project, Restricted Project
ro added a comment to D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris.

For format-strings.c, I'm not really happy suggesting #if defined(__sun) && !defined(__LP64__), but I don't think the alternative is better. We could restrict the test so it doesn't run using a Solaris target triple, but we actually want coverage here: the difference in wint_t affects the semantics of "%lc", so we want some coverage of that path.

Mon, Jun 17, 4:52 AM · Restricted Project, Restricted Project
ro updated the diff for D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris.

Adapt Sema/format-strings.c.

Mon, Jun 17, 3:45 AM · Restricted Project, Restricted Project

Thu, Jun 13

ro added a comment to D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris.

Ping? This has been a week, too. According to gcc/config headers, there are quite a number of targets with long int for wchar_t/wint_t,
so there should be some generic way to handle the Clang :: Sema/format-strings.c failure. Suggestions?

Thu, Jun 13, 2:16 AM · Restricted Project, Restricted Project

Wed, Jun 12

ro added a comment to D62892: [Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5.

Ping? It's been a week and the patch is close to obvious.

Wed, Jun 12, 4:35 AM · Restricted Project, Restricted Project

Thu, Jun 6

ro created D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris.
Thu, Jun 6, 3:13 AM · Restricted Project, Restricted Project

Wed, Jun 5

ro created D62892: [Sanitizers] Fix sanitizer_posix_libcdep.cc compilation on Solaris 11.5.
Wed, Jun 5, 1:19 AM · Restricted Project, Restricted Project

Apr 8 2019

ro committed rG04ee339adadd: [python, tests] Disable Clang Python tests on SPARC (authored by ro).
[python, tests] Disable Clang Python tests on SPARC
Apr 8 2019, 8:00 AM
ro committed rL357917: [python, tests] Disable Clang Python tests on SPARC.
[python, tests] Disable Clang Python tests on SPARC
Apr 8 2019, 8:00 AM
ro committed rC357917: [python, tests] Disable Clang Python tests on SPARC.
[python, tests] Disable Clang Python tests on SPARC
Apr 8 2019, 8:00 AM
ro closed D60046: [python, tests] Disable Clang Python tests on SPARC.
Apr 8 2019, 8:00 AM · Restricted Project
ro added a comment to D60046: [python, tests] Disable Clang Python tests on SPARC.

Thanks, looks good. Do you have commit access or do you need me to commit it for you?

Apr 8 2019, 7:52 AM · Restricted Project
ro added a comment to D60046: [python, tests] Disable Clang Python tests on SPARC.

Just add it to the regex above.

Apr 8 2019, 7:28 AM · Restricted Project
ro retitled D60046: [python, tests] Disable Clang Python tests on SPARC from [python, tests] Disable Clang Python tests on Solaris/SPARC to [python, tests] Disable Clang Python tests on SPARC.
Apr 8 2019, 7:25 AM · Restricted Project
ro updated the diff for D60046: [python, tests] Disable Clang Python tests on SPARC.

Skip SPARC like other targets.

Apr 8 2019, 7:24 AM · Restricted Project

Apr 5 2019

ro added a reviewer for D60046: [python, tests] Disable Clang Python tests on SPARC: mgorny.

Ping? Who's an appropriate reviewer here? CODE_OWNERS.TXT doesn't list anyone.

Apr 5 2019, 2:48 AM · Restricted Project
ro committed rG92db30fc004b: [Sanitizers] Provide __internal_dup on Solaris (authored by ro).
[Sanitizers] Provide __internal_dup on Solaris
Apr 5 2019, 1:43 AM
ro committed rCRT357753: [Sanitizers] Provide __internal_dup on Solaris.
[Sanitizers] Provide __internal_dup on Solaris
Apr 5 2019, 1:42 AM
ro committed rL357753: [Sanitizers] Provide __internal_dup on Solaris.
[Sanitizers] Provide __internal_dup on Solaris
Apr 5 2019, 1:42 AM
ro closed D60045: [Sanitizers] Provide __internal_dup on Solaris.
Apr 5 2019, 1:42 AM · Restricted Project, Restricted Project
ro committed rGa0524521eafe: [Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris (authored by ro).
[Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris
Apr 5 2019, 1:39 AM
ro committed rCRT357751: [Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris.
[Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris
Apr 5 2019, 1:39 AM
ro committed rL357751: [Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris.
[Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris
Apr 5 2019, 1:39 AM
ro closed D60044: [Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris.
Apr 5 2019, 1:39 AM · Restricted Project, Restricted Project

Apr 4 2019

ro added a reviewer for D60044: [Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris: fedor.sergeev.

Ping. Another Solaris-specific patch which might be considered obvious?

Apr 4 2019, 2:29 AM · Restricted Project, Restricted Project
ro added a reviewer for D60045: [Sanitizers] Provide __internal_dup on Solaris: fedor.sergeev.

Ping. Given that this patch is Solaris-only, I guess it could go in as obvious?

Apr 4 2019, 2:28 AM · Restricted Project, Restricted Project

Apr 2 2019

ro committed rG010982f75087: [FileCheck] Fix FileCheck.cpp compilation on Solaris (authored by ro).
[FileCheck] Fix FileCheck.cpp compilation on Solaris
Apr 2 2019, 11:37 AM
ro committed rL357509: [FileCheck] Fix FileCheck.cpp compilation on Solaris.
[FileCheck] Fix FileCheck.cpp compilation on Solaris
Apr 2 2019, 11:36 AM
ro closed D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.
Apr 2 2019, 11:36 AM · Restricted Project
ro added a comment to D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.

FileCheck.h needs those other non-LLVM headers. This header is different.

Apr 2 2019, 6:25 AM · Restricted Project
ro updated the diff for D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.

Move <cmath> include to FileCheck.cpp.

Apr 2 2019, 6:25 AM · Restricted Project
ro added inline comments to D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.
Apr 2 2019, 6:05 AM · Restricted Project
ro added a comment to D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.
Apr 2 2019, 2:00 AM · Restricted Project
ro updated the diff for D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.

Revised patch.

Apr 2 2019, 1:56 AM · Restricted Project

Apr 1 2019

ro added a comment to D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.
Apr 1 2019, 8:28 AM · Restricted Project

Mar 31 2019

ro created D60046: [python, tests] Disable Clang Python tests on SPARC.
Mar 31 2019, 3:14 AM · Restricted Project
ro created D60045: [Sanitizers] Provide __internal_dup on Solaris.
Mar 31 2019, 3:02 AM · Restricted Project, Restricted Project
ro created D60044: [Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris.
Mar 31 2019, 2:53 AM · Restricted Project, Restricted Project
ro added reviewers for D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris: thopre, jdenny.
Mar 31 2019, 2:47 AM · Restricted Project
ro created D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.
Mar 31 2019, 2:46 AM · Restricted Project

Feb 21 2019

ro added inline comments to D58433: AddressSanitizer: fix for SPARC with GCC.
Feb 21 2019, 7:02 AM · Restricted Project, Restricted Project

Jan 2 2019

ro added a comment to D55596: Reimplement Thread Static Data ASan routines with TLS.

@ro could you please test this patch for Solaris? I need to know whether it works with TLS destructor on SunOS.

Jan 2 2019, 5:48 AM · Restricted Project

Nov 13 2018

ro added a comment to D54099: [Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets.

There is also sparc and sparc64 support in sanitizers on NetBSD... but I cannot say for now how well it works. For sure we run UBSan and ASan for both of them.

Nov 13 2018, 6:23 AM · Restricted Project
ro updated the diff for D40943: [Sanitizers] Enable sanitizers on SPARC (PR 33274).

Refreshed.

Nov 13 2018, 4:45 AM · Restricted Project

Nov 5 2018

ro committed rCRT346155: [Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets.
[Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets
Nov 5 2018, 11:25 AM
ro committed rL346155: [Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets.
[Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets
Nov 5 2018, 11:25 AM
ro closed D54099: [Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets.
Nov 5 2018, 11:25 AM · Restricted Project
ro committed rCRT346153: [Sanitizers] Solaris largefile fixes.
[Sanitizers] Solaris largefile fixes
Nov 5 2018, 11:22 AM
ro committed rL346153: [Sanitizers] Solaris largefile fixes.
[Sanitizers] Solaris largefile fixes
Nov 5 2018, 11:22 AM
ro closed D54101: [Sanitizers] Solaris largefile fixes.
Nov 5 2018, 11:21 AM · Restricted Project
ro created D54101: [Sanitizers] Solaris largefile fixes.
Nov 5 2018, 5:35 AM · Restricted Project
ro created D54099: [Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets.
Nov 5 2018, 4:26 AM · Restricted Project
ro accepted D54030: Fix build on sparc64-linux-gnu..

I just built GCC on gcc202 machine of Compile farm. Even though the target is not supported, the libsanitizer runtime library is still built in GCC.

Nov 5 2018, 1:21 AM

Nov 4 2018

ro added a comment to D54030: Fix build on sparc64-linux-gnu..

Overall, this looks good to me, with the nits noted.

Nov 4 2018, 11:53 AM

Jun 21 2018

ro committed rL335234: [liblang] Remove DOS line endings in libclang.exports.
[liblang] Remove DOS line endings in libclang.exports
Jun 21 2018, 6:45 AM
ro committed rC335234: [liblang] Remove DOS line endings in libclang.exports.
[liblang] Remove DOS line endings in libclang.exports
Jun 21 2018, 6:45 AM
ro closed D48423: [liblang] Remove DOS line endings in libclang.exports.
Jun 21 2018, 6:45 AM
ro created D48423: [liblang] Remove DOS line endings in libclang.exports.
Jun 21 2018, 5:33 AM

May 15 2018

ro committed rL332343: [Solaris] Only define _REENTRANT if -pthread.
[Solaris] Only define _REENTRANT if -pthread
May 15 2018, 4:39 AM
ro committed rC332343: [Solaris] Only define _REENTRANT if -pthread.
[Solaris] Only define _REENTRANT if -pthread
May 15 2018, 4:39 AM
ro closed D41241: [Solaris] Only define _REENTRANT if -pthread.
May 15 2018, 4:39 AM

Apr 25 2018

ro added a comment to D46006: [Sanitizers] Fix Solaris build.

What are the SunOS results? For NetBSD ASan broke badly and results for other sanitizers (UBSan, TSan, MSan) are deteriorated...

Apr 25 2018, 7:54 AM · Restricted Project
ro added a comment to D46006: [Sanitizers] Fix Solaris build.

Can you run tests on SunOS? check-asan, check-ubsan etc.

Apr 25 2018, 5:01 AM · Restricted Project

Apr 24 2018

ro committed rL330712: The OpenBSD UBsan port introduced two typos that broke the Solaris sanitizer….
The OpenBSD UBsan port introduced two typos that broke the Solaris sanitizer…
Apr 24 2018, 6:03 AM
ro committed rCRT330712: The OpenBSD UBsan port introduced two typos that broke the Solaris sanitizer….
The OpenBSD UBsan port introduced two typos that broke the Solaris sanitizer…
Apr 24 2018, 6:03 AM
ro closed D46006: [Sanitizers] Fix Solaris build.
Apr 24 2018, 6:03 AM · Restricted Project
ro created D46006: [Sanitizers] Fix Solaris build.
Apr 24 2018, 5:57 AM · Restricted Project
ro added a reviewer for D41241: [Solaris] Only define _REENTRANT if -pthread: fedor.sergeev.

ping^5

Apr 24 2018, 1:40 AM

Apr 23 2018

ro committed rC330572: [Solaris] __float128 is supported on Solaris/x86.
[Solaris] __float128 is supported on Solaris/x86
Apr 23 2018, 2:32 AM
ro committed rL330572: [Solaris] __float128 is supported on Solaris/x86.
[Solaris] __float128 is supported on Solaris/x86
Apr 23 2018, 2:32 AM
ro closed D41240: [Solaris] __float128 is supported on Solaris/x86.
Apr 23 2018, 2:32 AM

Mar 21 2018

ro added a comment to D41240: [Solaris] __float128 is supported on Solaris/x86.

ping^3

Mar 21 2018, 4:19 PM

Feb 7 2018

ro added a comment to D43021: Recognize all NetBSD architectures in UBSan.

TBH, I've always disliked it that way: my preference would be to go for the SANITIZE_<PLATFORM> forms as far as possible.

Feb 7 2018, 8:43 AM · Restricted Project