Page MenuHomePhabricator

ro (Rainer Orth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2016, 4:12 AM (164 w, 1 d)

Recent Activity

Mon, Aug 5

ro committed rG91a658b09452: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris (authored by ro).
[Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris
Mon, Aug 5, 7:07 AM
ro committed rG6ca1707b2372: [lldb][clang] Reflect LangStandard.h move to clang/Basic (authored by ro).
[lldb][clang] Reflect LangStandard.h move to clang/Basic
Mon, Aug 5, 7:07 AM
ro committed rL367866: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.
[Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris
Mon, Aug 5, 7:07 AM
ro closed D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.
Mon, Aug 5, 7:07 AM · Restricted Project, Restricted Project
ro committed rL367865: [lldb][clang] Reflect LangStandard.h move to clang/Basic.
[lldb][clang] Reflect LangStandard.h move to clang/Basic
Mon, Aug 5, 7:07 AM
ro committed rG09d890d728e6: Move LangStandard*, InputKind::Language to Basic (authored by ro).
Move LangStandard*, InputKind::Language to Basic
Mon, Aug 5, 7:07 AM
ro closed D65717: [lldb][clang] Reflect LangStandard.h move to clang/Basic.
Mon, Aug 5, 7:07 AM · Restricted Project, Restricted Project
ro committed rL367864: Move LangStandard*, InputKind::Language to Basic.
Move LangStandard*, InputKind::Language to Basic
Mon, Aug 5, 6:59 AM
ro closed D65562: Move LangStandard*, InputKind::Language to Basic.
Mon, Aug 5, 6:58 AM · Restricted Project, Restricted Project

Sun, Aug 4

ro added a comment to D65562: Move LangStandard*, InputKind::Language to Basic.

I've now submitted the lldb patch to reflect the LangStandard.h move.

Sun, Aug 4, 6:37 AM · Restricted Project, Restricted Project
ro added inline comments to D65562: Move LangStandard*, InputKind::Language to Basic.
Sun, Aug 4, 6:31 AM · Restricted Project, Restricted Project
ro updated the diff for D65562: Move LangStandard*, InputKind::Language to Basic.
  • Restrict enum class Languge to uint8_t to save space.
  • Filter patch through clang-format-diff.py
Sun, Aug 4, 6:31 AM · Restricted Project, Restricted Project
ro added a comment to D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.
In D64793#1613063, @rnk wrote:

lgtm

If I interpret @jyknight correctly, having failed to dissuade you, he doesn't feel strongly enough about this to block it, he just wants to reduce legacy when feasible.

Sun, Aug 4, 6:27 AM · Restricted Project, Restricted Project
ro created D65717: [lldb][clang] Reflect LangStandard.h move to clang/Basic.
Sun, Aug 4, 3:27 AM · Restricted Project, Restricted Project

Fri, Aug 2

ro committed rGf98a153c8dcb: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*… (authored by ro).
[sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*…
Fri, Aug 2, 11:56 AM
ro committed rL367705: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*….
[sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*…
Fri, Aug 2, 11:55 AM
ro closed D65055: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/SanitizerCommon.PthreadDestructorIterations on Solaris.
Fri, Aug 2, 11:55 AM · Restricted Project, Restricted Project
ro updated the diff for D65055: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/SanitizerCommon.PthreadDestructorIterations on Solaris.

Rebased after .cc -> .cpp mass renamings.

Fri, Aug 2, 2:05 AM · Restricted Project, Restricted Project
ro updated the diff for D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

Account for enum class Language change in D65562.

Fri, Aug 2, 1:58 AM · Restricted Project, Restricted Project
ro updated the diff for D65562: Move LangStandard*, InputKind::Language to Basic.

Change Language to enum class.

Fri, Aug 2, 1:56 AM · Restricted Project, Restricted Project
ro added inline comments to D65562: Move LangStandard*, InputKind::Language to Basic.
Fri, Aug 2, 1:56 AM · Restricted Project, Restricted Project
ro added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.
In D64483#1606208, @ro wrote:
Fri, Aug 2, 1:52 AM · Restricted Project

Thu, Aug 1

ro updated the diff for D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

Updated patch to make use of the move to
Basic.

Thu, Aug 1, 2:34 AM · Restricted Project, Restricted Project
ro added a comment to D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

I fear it is necessary: at least it matches documented behaviour of both the Sun/Oracle Studio compilers and gcc.

I will defer to your opinion here. But -- one last attempt at dissuading you. :)

Is this really doing something _important_, or is it just legacy cruft which can be safely ignored by now? With your "logb" example, it seems to me that it is probably preferable to always use the new correct "xpg6" implementation, and just ignore the legacy/incorrect version. Similarly, the example given in https://gcc.gnu.org/PR40411 of freopen -- again, seems like it'd be better to just use the new xpg6 behavior, always.

Thu, Aug 1, 2:34 AM · Restricted Project, Restricted Project
ro created D65562: Move LangStandard*, InputKind::Language to Basic.
Thu, Aug 1, 2:05 AM · Restricted Project, Restricted Project

Tue, Jul 30

ro added reviewers for D65055: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/SanitizerCommon.PthreadDestructorIterations on Solaris: krytarowski, vitalybuka.
Tue, Jul 30, 11:52 PM · Restricted Project, Restricted Project
ro committed rGbb669c25ba57: [Driver] Support -fsanitize=function on Solaris/x86 (authored by ro).
[Driver] Support -fsanitize=function on Solaris/x86
Tue, Jul 30, 1:07 PM
ro committed rL367351: [Driver] Support -fsanitize=function on Solaris/x86.
[Driver] Support -fsanitize=function on Solaris/x86
Tue, Jul 30, 1:07 PM
ro closed D64488: [Driver] Support -fsanitize=function on Solaris/x86.
Tue, Jul 30, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
ro updated the diff for D64488: [Driver] Support -fsanitize=function on Solaris/x86.

Test i386--solaris instead of x86_64--solaris twice.

Tue, Jul 30, 12:21 PM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D64488: [Driver] Support -fsanitize=function on Solaris/x86.

Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.

Tue, Jul 30, 11:16 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.
In D64483#1605989, @ro wrote:

Thanks. Would this and its companion D64482 be appropriate for the 9.x branch, too? If so, what's the procedure to get it there?

Probably. They need to land on trunk first, then let me know and I'll merge them.

Both patches are in now. However, there's a buildbot failure
that claims to be related, though I cannot see yet how this can possibly happen.

Tue, Jul 30, 6:43 AM · Restricted Project
ro added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.

Thanks. Would this and its companion D64482 be appropriate for the 9.x branch, too? If so, what's the procedure to get it there?

Probably. They need to land on trunk first, then let me know and I'll merge them.

Tue, Jul 30, 4:41 AM · Restricted Project
ro added inline comments to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.
Tue, Jul 30, 4:39 AM · Restricted Project
ro committed rGb9f8ab2c7eb2: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris (authored by ro).
[Driver] Define _FILE_OFFSET_BITS=64 on Solaris
Tue, Jul 30, 3:39 AM
ro committed rL367305: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.
[Driver] Define _FILE_OFFSET_BITS=64 on Solaris
Tue, Jul 30, 3:39 AM
ro closed D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.
Tue, Jul 30, 3:38 AM · Restricted Project, Restricted Project
ro committed rG8d3c740f26b1: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris (authored by ro).
[CMake] Define _FILE_OFFSET_BITS=64 on Solaris
Tue, Jul 30, 3:38 AM
ro committed rL367304: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.
[CMake] Define _FILE_OFFSET_BITS=64 on Solaris
Tue, Jul 30, 3:33 AM
ro closed D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.
Tue, Jul 30, 3:33 AM · Restricted Project
ro added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.

Seems fine I guess, since this matches what's already there for AIX.

Tue, Jul 30, 2:23 AM · Restricted Project
ro committed rG63d960509127: [builtins][test] XFAIL two SPARC tests (authored by ro).
[builtins][test] XFAIL two SPARC tests
Tue, Jul 30, 1:07 AM
ro committed rL367295: [builtins][test] XFAIL two SPARC tests.
[builtins][test] XFAIL two SPARC tests
Tue, Jul 30, 1:07 AM
ro closed D64796: [builtins][test] XFAIL two SPARC tests.
Tue, Jul 30, 1:06 AM · Restricted Project, Restricted Project
ro added a comment to D64796: [builtins][test] XFAIL two SPARC tests.

Given the reference to the bug, seems fine to me to commit an xfail here since nobody is actively working to fix this right now.

Tue, Jul 30, 1:06 AM · Restricted Project, Restricted Project
ro committed rG58aa6a87a619: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow… (authored by ro).
[ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow…
Tue, Jul 30, 1:01 AM
ro committed rL367293: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow….
[ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow…
Tue, Jul 30, 12:59 AM
ro closed D65056: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc on Solaris.
Tue, Jul 30, 12:59 AM · Restricted Project, Restricted Project
ro added a comment to D65056: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc on Solaris.
In D65056#1603902, @ro wrote:

Ping? It's been a week now. Is there some policy not to xfail the test which as documented in the bug cannot pass on Solaris?

If the test fails consistently on the platform and there is a chance to make it pass some day, I would prefer to have XFAIL.

Tue, Jul 30, 12:57 AM · Restricted Project, Restricted Project

Mon, Jul 29

ro added a comment to D64796: [builtins][test] XFAIL two SPARC tests.

Ping^2? Is it ok to xfail those tests given a fix is far from trivial for me?

Mon, Jul 29, 7:36 AM · Restricted Project, Restricted Project
ro added a comment to D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

Ping^2? It's been two weeks now. Who can decide if the LangStandards code can be used from lib/Frontend as is or needs to be moved
elsewhere (lib/Basic?) for use by driver code?

Mon, Jul 29, 7:36 AM · Restricted Project, Restricted Project
ro added a comment to D64488: [Driver] Support -fsanitize=function on Solaris/x86.

Ping^3? Three weeks and counting...

Mon, Jul 29, 7:36 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.

Ping^2? It's been two weeks now and I'd like to know how to proceed with this patch.

Mon, Jul 29, 7:36 AM · Restricted Project
ro added a comment to D65055: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/SanitizerCommon.PthreadDestructorIterations on Solaris.

Ping? It's been a week and the behaviour of Solaris pthread_key_create is allowed by the spec.

Mon, Jul 29, 7:36 AM · Restricted Project, Restricted Project

Sun, Jul 28

ro added a comment to D65056: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc on Solaris.
Sun, Jul 28, 7:56 AM · Restricted Project, Restricted Project

Jul 23 2019

ro added a comment to D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

Is this really necessary? Users don't typically pass -std= to the driver for linking anyways (what do you even pass if you've compiled both C and C++ code?) so this seems a rather odd way to control behavior.

Jul 23 2019, 10:58 AM · Restricted Project, Restricted Project
ro committed rG569f92f1e101: [compiler-rt][builtins] Provide __clear_cache for SPARC (authored by ro).
[compiler-rt][builtins] Provide __clear_cache for SPARC
Jul 23 2019, 9:34 AM
ro committed rL366822: [compiler-rt][builtins] Provide __clear_cache for SPARC.
[compiler-rt][builtins] Provide __clear_cache for SPARC
Jul 23 2019, 9:34 AM
ro closed D64496: [compiler-rt][builtins] Provide __clear_cache for SPARC.
Jul 23 2019, 9:34 AM · Restricted Project, Restricted Project
ro committed rG2b7f3a2b3352: [CMake] Add -z defs on Solaris (authored by ro).
[CMake] Add -z defs on Solaris
Jul 23 2019, 9:30 AM
ro added a comment to D64496: [compiler-rt][builtins] Provide __clear_cache for SPARC.

The code you reference in GCC is only for trampolines, while this function is used to implement builtin_clear_cache. AFAICT GCC is just wrong to implement this as a no-op.

Jul 23 2019, 9:30 AM · Restricted Project, Restricted Project
ro committed rL366821: [CMake] Add -z defs on Solaris.
[CMake] Add -z defs on Solaris
Jul 23 2019, 9:27 AM
ro closed D64484: [CMake] Add -z defs on Solaris.
Jul 23 2019, 9:27 AM · Restricted Project
ro committed rG2da6eea07cde: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC (authored by ro).
[clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC
Jul 23 2019, 9:26 AM
ro committed rL366820: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC.
[clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC
Jul 23 2019, 9:26 AM
ro closed D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC.
Jul 23 2019, 9:26 AM · Restricted Project
ro added a comment to D64796: [builtins][test] XFAIL two SPARC tests.

Is rL189780 related? If you can simply fix the issue, you probably don't have to XFAIL the tests...

Jul 23 2019, 5:18 AM · Restricted Project, Restricted Project
ro added a comment to D64796: [builtins][test] XFAIL two SPARC tests.

Ping? It's been a week now. I don't really know abouth LLVM's testcase xfail policy. Someone to enlighten me?

Jul 23 2019, 4:25 AM · Restricted Project, Restricted Project
ro added a comment to D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

Ping? It's been a week now and this is a correctness issue on Solaris, not just a single failing test.

Jul 23 2019, 4:25 AM · Restricted Project, Restricted Project
ro added a comment to D64496: [compiler-rt][builtins] Provide __clear_cache for SPARC.

Ping^2? Two weeks now; anyone else who could review this?

Jul 23 2019, 4:21 AM · Restricted Project, Restricted Project
ro added a comment to D64488: [Driver] Support -fsanitize=function on Solaris/x86.

Ping^2? Two weeks now.

Jul 23 2019, 4:21 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D64484: [CMake] Add -z defs on Solaris.

Ping^2? Two weeks now for a pretty obvious patch.

Jul 23 2019, 4:21 AM · Restricted Project
ro added a comment to D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC.

Ping^2? It's been two weeks now.

Jul 23 2019, 4:21 AM · Restricted Project
ro added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.

How should we procede here, given the proposed alternative doesn't work? It would be good to get this and the already approved
companion patch into trunk and, if possible, into the 9.x branch.

Jul 23 2019, 4:17 AM · Restricted Project

Jul 21 2019

ro created D65056: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc on Solaris.
Jul 21 2019, 8:52 AM · Restricted Project, Restricted Project
ro created D65055: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/SanitizerCommon.PthreadDestructorIterations on Solaris.
Jul 21 2019, 8:30 AM · Restricted Project, Restricted Project

Jul 18 2019

ro added a comment to D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris.
In D64483#1590120, @rnk wrote:

I would place this macro setting with the other code that sets this macro, in cmake/modules/HandleLLVMOptions.cmake.

Jul 18 2019, 6:45 AM · Restricted Project

Jul 17 2019

ro added a comment to D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.
Jul 17 2019, 4:38 AM · Restricted Project, Restricted Project
ro added a comment to D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris.
In D64482#1588154, @rnk wrote:

To avoid a similar inconsistence with host compilers that don't predefine _FILE_OFFSET_BITS=64
(e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted shortly.

I'm curious, what's the plan for that? I suppose the user can always take things into their own hands with -D and -U.

Jul 17 2019, 3:34 AM · Restricted Project, Restricted Project
ro committed rG966272157290: [Driver] Enable __cxa_atexit on Solaris (authored by ro).
[Driver] Enable __cxa_atexit on Solaris
Jul 17 2019, 1:38 AM
ro committed rL366305: [Driver] Enable __cxa_atexit on Solaris.
[Driver] Enable __cxa_atexit on Solaris
Jul 17 2019, 1:36 AM
ro closed D64491: [Driver] Enable __cxa_atexit on Solaris.
Jul 17 2019, 1:36 AM · Restricted Project, Restricted Project

Jul 16 2019

ro created D64796: [builtins][test] XFAIL two SPARC tests.
Jul 16 2019, 6:27 AM · Restricted Project, Restricted Project
ro created D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.
Jul 16 2019, 5:49 AM · Restricted Project, Restricted Project
ro added inline comments to rL366204: Document the LLVM_ENABLE_BINDINGS option.
Jul 16 2019, 5:07 AM
ro committed rGa5dc9c98352c: [Driver] Don't pass --dynamic-linker to ld on Solaris (authored by ro).
[Driver] Don't pass --dynamic-linker to ld on Solaris
Jul 16 2019, 4:07 AM
ro committed rL366202: [Driver] Don't pass --dynamic-linker to ld on Solaris.
[Driver] Don't pass --dynamic-linker to ld on Solaris
Jul 16 2019, 4:06 AM
ro closed D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris.
Jul 16 2019, 4:06 AM · Restricted Project, Restricted Project
ro added reviewers for D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris: hubert.reinterpretcast, jasonliu.

Ping? It's been a week and together with it's clang companion this patch is needed to unbreak make check-all with gcc 9. So it would
be good to get this into LLVM 9.

Jul 16 2019, 1:38 AM · Restricted Project
ro added reviewers for D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris: mehdi_amini, rnk.

Ping? It's been a week and it would be good to get this patch and its companion into LLVM 9: it unbreaks make check-all with gcc 9
and restores g++ compatibility.

Jul 16 2019, 1:38 AM · Restricted Project, Restricted Project
ro added reviewers for D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris: mehdi_amini, rnk.

Ping? It's been a ween and unless someone comes up with a good explanation why the default interpreter must be specified instead
of letting ld figure it out, this seems pretty obvious.

Jul 16 2019, 1:33 AM · Restricted Project, Restricted Project
ro added reviewers for D64491: [Driver] Enable __cxa_atexit on Solaris: mehdi_amini, rnk.

Ping? It's been a week and the patch seems completely in line with other ELF targets.

Jul 16 2019, 1:30 AM · Restricted Project, Restricted Project
ro added reviewers for D64484: [CMake] Add -z defs on Solaris: hubert.reinterpretcast, jasonliu.

Ping? It's been a week and this seems pretty obvious, bringing Solaris in line with other ELF targets.

Jul 16 2019, 1:25 AM · Restricted Project
ro added a reviewer for D64488: [Driver] Support -fsanitize=function on Solaris/x86: krytarowski.

Ping? It's been a week.

Jul 16 2019, 1:23 AM · Restricted Project, Restricted Project, Restricted Project
ro added a reviewer for D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC: jyknight.

Ping? It's been a week.

Jul 16 2019, 1:13 AM · Restricted Project
ro added a reviewer for D64496: [compiler-rt][builtins] Provide __clear_cache for SPARC: jyknight.

Ping? It's been a week.

Jul 16 2019, 1:10 AM · Restricted Project, Restricted Project

Jul 12 2019

ro committed rG4a9a772f44bf: Enable compiler-rt on SPARC (authored by ro).
Enable compiler-rt on SPARC
Jul 12 2019, 1:32 AM
ro committed rL365880: Enable compiler-rt on SPARC.
Enable compiler-rt on SPARC
Jul 12 2019, 1:32 AM
ro closed D40943: Enable compiler-rt on SPARC.
Jul 12 2019, 1:32 AM · Restricted Project, Restricted Project
ro committed rG56f2f1cdb36a: [Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout. (authored by ro).
[Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout.
Jul 12 2019, 1:32 AM