- User Since
- Jul 1 2016, 4:12 AM (155 w, 4 d)
Sorry, wrong patch.
Fri, Jun 21
Thu, Jun 20
Rebased an slightly fixed version. Without it, man profiling tests on Solaris FAIL like
Command Output (stderr): -- Undefined first referenced symbol in file __llvm_profile_register_names_function /tmp/lit_tmp_Nqu4eh/infinite_loop-9dc638.o __llvm_profile_register_function /tmp/lit_tmp_Nqu4eh/infinite_loop-9dc638.o
I don't think we need to worry about older versions of Solaris ld that don't support
__start_SECNAME and stop_SECNAME labels any longer: that feature is in
Solaris 11.4 and we already use Solaris 11.4-only features like ld -z gnu-version-script-compat
and fully working .preinit_array suport in compiler-rt.
Wed, Jun 19
Further testing in the exact buildbot user environment revealed that I'd forgotten one
crucial option: clang calls the linker with Solaris ld-only options. If GNU ld happens to
be earlier in PATH at link time, this breaks the build.
Ping^2. It's been two weeks now for a trivial patch fixing the build...
Tue, Jun 18
Mon, Jun 17
Thu, Jun 13
Ping? This has been a week, too. According to gcc/config headers, there are quite a number of targets with long int for wchar_t/wint_t,
so there should be some generic way to handle the Clang :: Sema/format-strings.c failure. Suggestions?
Wed, Jun 12
Ping? It's been a week and the patch is close to obvious.
Thu, Jun 6
Wed, Jun 5
Apr 8 2019
Skip SPARC like other targets.
Apr 5 2019
Ping? Who's an appropriate reviewer here? CODE_OWNERS.TXT doesn't list anyone.
Apr 4 2019
Ping. Another Solaris-specific patch which might be considered obvious?
Ping. Given that this patch is Solaris-only, I guess it could go in as obvious?
Apr 2 2019
Move <cmath> include to FileCheck.cpp.
Apr 1 2019
Mar 31 2019
Feb 21 2019
Jan 2 2019
Nov 13 2018
Nov 5 2018
Nov 4 2018
Overall, this looks good to me, with the nits noted.
Jun 21 2018
May 15 2018
Apr 25 2018
Apr 24 2018
Apr 23 2018
Mar 21 2018
Feb 7 2018
TBH, I've always disliked it that way: my preference would be to go for the SANITIZE_<PLATFORM> forms as far as possible.