Page MenuHomePhabricator

ro (Rainer Orth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2016, 4:12 AM (352 w, 1 d)

Recent Activity

Mon, Mar 27

ro added a comment to D146851: [support] Revise ScopedPrinter formatting tests for floats.

LGTM, but should get the AIX/Solaris people have verified the fix.

Mon, Mar 27, 5:35 AM · Restricted Project, Restricted Project

Fri, Mar 24

ro committed rG65c4aceb735b: [flang][Driver] Fix lto-flags.f90 on Solaris (authored by ro).
[flang][Driver] Fix lto-flags.f90 on Solaris
Fri, Mar 24, 6:25 AM · Restricted Project, Restricted Project
ro closed D146807: [flang][Driver] Fix lto-flags.f90 on Solaris.
Fri, Mar 24, 6:25 AM · Restricted Project, Restricted Project
ro added a comment to D146739: [support] Fix PrintNumber Test on AIX.

Even with this patch, the ScopedPrinterTest.PrintNumber test still FAILs on Solaris:

/vol/llvm/src/llvm-project/dist/llvm/unittests/Support/ScopedPrinterTest.cpp:91: Failure
Expected equality of these values:
[...]
With diff:
@@ -23,5 +23,5 @@
   \"float-max\": 3.4028234663852886e+38,
   \"float-min\": 1.1754943508222875e-38,
-  \"float-inf\": inf,
+  \"float-inf\": infinity,
   \"float-nan\": nan,
   \"float-42.0\": 42,
@@ -29,5 +29,5 @@
   \"double-max\": 1.7976931348623157e+308,
   \"double-min\": 2.2250738585072014e-308,
-  \"double-inf\": inf,
+  \"double-inf\": infinity,
   \"double-nan\": nan,
   \"double-42.0\": 42,
Fri, Mar 24, 6:21 AM · Restricted Project, Restricted Project
ro requested review of D146807: [flang][Driver] Fix lto-flags.f90 on Solaris.
Fri, Mar 24, 5:47 AM · Restricted Project, Restricted Project

Wed, Mar 22

ro accepted D146521: [solaris] Explicitly opt out of the runtimes build.

LGTM, thanks.

Wed, Mar 22, 7:14 AM · Restricted Project

Feb 22 2023

ro added a comment to D144514: Undef _TIME_BITS along with _FILE_OFFSET_BITS in sanitizers.
  • You still haven't mentioned which target is affected.
  • There needs to be a comment explaining why _TIME_BITS is #undefed.
  • Please pass the patch through clang-format-diff.py: there's a TAB before !defined which should just be a blank.
Feb 22 2023, 5:04 AM · Restricted Project, Restricted Project

Feb 21 2023

ro added a comment to D144514: Undef _TIME_BITS along with _FILE_OFFSET_BITS in sanitizers.

Please state what target the problem occurs on and how/where the patch was tested. _TIME_BITS doesn't exist on Solaris 11.4 and, AFAICS, neither on Illumos.

Feb 21 2023, 1:17 PM · Restricted Project, Restricted Project

Feb 6 2023

ro added a comment to D143249: [Release] Increase test-release.sh verbosity.

LGTM, Thanks, can you open the backport request for release/16.x ?

Feb 6 2023, 12:35 AM · Restricted Project, Restricted Project
ro committed rG8d2d8e022e3c: [Release] Increase test-release.sh verbosity (authored by ro).
[Release] Increase test-release.sh verbosity
Feb 6 2023, 12:31 AM · Restricted Project, Restricted Project
ro closed D143249: [Release] Increase test-release.sh verbosity.
Feb 6 2023, 12:31 AM · Restricted Project, Restricted Project

Feb 3 2023

ro added a comment to D143249: [Release] Increase test-release.sh verbosity.

I forgot: this is certainly something that should go onto the release/16.x branch ASAP.

Feb 3 2023, 1:56 AM · Restricted Project, Restricted Project
ro requested review of D143249: [Release] Increase test-release.sh verbosity.
Feb 3 2023, 1:55 AM · Restricted Project, Restricted Project

Jan 17 2023

ro committed rG951cf656b2fa: [sanitizer_common] Don't intercept __tls_get_addr on Solaris (authored by ro).
[sanitizer_common] Don't intercept __tls_get_addr on Solaris
Jan 17 2023, 12:42 AM · Restricted Project, Restricted Project
ro closed D141385: [sanitizer_common] Don't intercept __tls_get_addr on Solaris.
Jan 17 2023, 12:41 AM · Restricted Project, Restricted Project
ro added inline comments to D141385: [sanitizer_common] Don't intercept __tls_get_addr on Solaris.
Jan 17 2023, 12:39 AM · Restricted Project, Restricted Project
ro added a comment to D141385: [sanitizer_common] Don't intercept __tls_get_addr on Solaris.

Ping? It's been a week. Thanks.

Jan 17 2023, 12:17 AM · Restricted Project, Restricted Project

Jan 13 2023

ro abandoned D115342: [benchmarks] Unbreak third-party/benchmark build on Solaris.

The patch is no longer crucial: since third-party/benchmark doesn't build with -Werror anymore, so there are just warnings left. Besides, the patch is now upstream, so whenever someone imports the current version into LLVM, even those will be gone.

Jan 13 2023, 1:15 AM · Restricted Project, Restricted Project
ro committed rG7c4a70f8f6f3: [Driver] Add crtfastmath.o on Solaris if appropriate (authored by ro).
[Driver] Add crtfastmath.o on Solaris if appropriate
Jan 13 2023, 1:09 AM · Restricted Project, Restricted Project
ro closed D141596: [Driver] Add crtfastmath.o on Solaris if appropriate.
Jan 13 2023, 1:09 AM · Restricted Project, Restricted Project

Jan 12 2023

ro requested review of D141596: [Driver] Add crtfastmath.o on Solaris if appropriate.
Jan 12 2023, 3:59 AM · Restricted Project, Restricted Project

Jan 10 2023

ro requested review of D141385: [sanitizer_common] Don't intercept __tls_get_addr on Solaris.
Jan 10 2023, 7:02 AM · Restricted Project, Restricted Project

Dec 22 2022

ro added a comment to D140515: [SPARC] Fix SELECT_REG emission for f128s.

I just ran 2-stage builds on sparcv9-sun-solaris2.11 (with both gcc 12.2.0 and clang 15.0.0 in stage 1) : the builds completed successfully and
test results are back to what they were about a month ago (with two unrelated issues). Thanks.

Dec 22 2022, 5:17 AM · Restricted Project, Restricted Project

Dec 21 2022

ro added a comment to D138922: [SPARC] Lower SELECT_CC to MOVr on 64-bit target whenever possible.

This patch broke Solaris/sparcv9 bootstrap. Details in Issue #59646.

Dec 21 2022, 1:36 PM · Restricted Project, Restricted Project

Dec 13 2022

ro added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

We are seeing following test failures on Fuchsia's Clang Linux x64 builders after this change (255c3e3dcb06299aa2365f70817322a8a381c351) landed:

MemorySanitizer-Unit :: ./Msan-x86_64-Test/34/38
MemorySanitizer-Unit :: ./Msan-x86_64-Test/MemorySanitizer/SelectPartial
MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/34/38
MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial
MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial
Dec 13 2022, 1:05 PM · Restricted Project, Restricted Project
ro committed rG255c3e3dcb06: Reland "[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests" (authored by ro).
Reland "[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests"
Dec 13 2022, 1:59 AM · Restricted Project, Restricted Project
ro closed D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Dec 13 2022, 1:59 AM · Restricted Project, Restricted Project
ro added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

I got distracted after returning from vacation, but I'll reland the patch shortly after retesting on x86_64-pc-linux-gnu.

Dec 13 2022, 1:56 AM · Restricted Project, Restricted Project

Dec 7 2022

ro accepted D139001: Do not include <alloca.h> unconditionally.

For good measure tested on sparcv9-sun-solaris2.11, amd64-pc-solaris2.11, and x86_64-pc-linux-gnu.

Dec 7 2022, 6:31 AM · Restricted Project

Dec 6 2022

ro updated subscribers of D138680: [libc++] Remove Solaris related code.

As usual, it's complicated ;-)

Dec 6 2022, 7:08 AM · Restricted Project, Restricted Project

Nov 30 2022

ro added inline comments to D133579: Fix Solaris compilation.
Nov 30 2022, 3:47 AM · Restricted Project

Nov 24 2022

ro committed rGdfa7f4ca8b60: [flang][test] Adjust Driver/pass-plugin-not-found.f90 error message (authored by ro).
[flang][test] Adjust Driver/pass-plugin-not-found.f90 error message
Nov 24 2022, 7:21 AM · Restricted Project, Restricted Project
ro closed D138663: [flang][test] Adjust Driver/pass-plugin-not-found.f90 error message.
Nov 24 2022, 7:21 AM · Restricted Project, Restricted Project
ro added a comment to D129156: Add -fpass-plugin option to Flang.
Nov 24 2022, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
ro requested review of D138663: [flang][test] Adjust Driver/pass-plugin-not-found.f90 error message.
Nov 24 2022, 5:51 AM · Restricted Project, Restricted Project
ro added a comment to D129156: Add -fpass-plugin option to Flang.

This introduced a new failure on Solaris:

FAIL: Flang :: Driver/pass-plugin-not-found.f90

Running the failing command manually shows:

error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'

while the test currently expects

error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': X.Y: cannot open shared object file: No such file or directory'

This expectation is unjustified, I believe: the message is produced by PassPlugin::Load -> sys::DynamicLibrary::getPermanentLibrary -> HandleSet::DLOpen -> ::dlerror. Obviously the output of the last is system-dependent; I don't think we can put any requirements on it (maybe not even the exact wording of the No such file or directory part.

Nov 24 2022, 5:04 AM · Restricted Project, Restricted Project, Restricted Project

Oct 31 2022

ro committed rTc4c6c75c1ff8: Fix Solaris compilation (authored by ro).
Fix Solaris compilation
Oct 31 2022, 2:11 AM · Restricted Project
ro closed D133579: Fix Solaris compilation.
Oct 31 2022, 2:11 AM · Restricted Project

Oct 24 2022

ro added a comment to D133579: Fix Solaris compilation.

Ping? It's been 2 1/2 weeks...

Oct 24 2022, 2:17 PM · Restricted Project

Oct 14 2022

ro added inline comments to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Oct 14 2022, 1:16 PM · Restricted Project, Restricted Project
ro updated the diff for D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

Disable subtests of tsan/tests/unit/tsan_trace_test.cpp that deadlock with SANITIZER_DEBUG.

Oct 14 2022, 5:36 AM · Restricted Project, Restricted Project
ro added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

Please disregard this. It was something wrong with my setup.

So I applied the patch on the actual bot and still see tsan go timeouts.

Oct 14 2022, 5:34 AM · Restricted Project, Restricted Project

Oct 6 2022

ro added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

I'd be grateful if the owners of the affected builders could retest the patch before relanding, preferably in Release and Debug/COMPILER_RT_DEBUG builds. Thanks a lot.

Oct 6 2022, 4:52 AM · Restricted Project, Restricted Project
ro updated the diff for D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
  • Use string(APPEND) for COMPILER_RT_TEST_COMPILER_CFLAGS.
  • Omit -O3 from COMPILER_RT_TEST_COMPILER_CFLAGS in non-debug builds for now.
  • Provide __sanitizer::integral_constant<bool, true>::value instantiation.
  • XFAIL tsan/Linux/check_memcpy.c in debug builds.
Oct 6 2022, 4:51 AM · Restricted Project, Restricted Project
ro added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

I think I've figured out what's wrong. AFAICS there are three separate issues:

Oct 6 2022, 4:45 AM · Restricted Project, Restricted Project
ro added inline comments to D133579: Fix Solaris compilation.
Oct 6 2022, 2:50 AM · Restricted Project

Oct 5 2022

ro added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

[...]

The -O3;-g on the link line seems to come from compiler-rt/test/lit.common.configured. I suspect that can be traced down to code in compiler-rt/CMakeLists.txt which replaces " " by ";" in COMPILER_RT_TEST_COMPILER_CFLAGS. I don't really understand this and it seems terribly fragile to me, but I believe this can be avoided by prepending the new instances of setting COMPILER_RT_TEST_COMPILER_CFLAGS in compiler-rt/CMakeLists.txt with a blank. I have a patch for that and am trying to test it, but as mentioned the issue hasn't affected me. @uweigand may be able to help.

I don't see anything particularly special to s390x here, with the only exception of -mbackchain. This flag is added to sanitizer tests on s390x, where we need it for the same reason other platforms tend to need -fno-omit-frame-pointer. It's unclear how that would be related to this ";" issue.

Oct 5 2022, 7:38 AM · Restricted Project, Restricted Project
ro updated subscribers of D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

This seems to cause another regression, apparently only visible in cross builds: clang-s390x-linux buildbot: a link failure like this:

******************** TEST 'AddressSanitizer-s390x-linux ::
TestCases/Linux/init-order-dlopen.cpp' FAILED ********************
Script:
[...]
Oct 5 2022, 7:09 AM · Restricted Project, Restricted Project
ro added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

This patch caused a regression on the sanitizer-x86_64-linux-autoconf buildbot running a debug build:

ThreadSanitizer-x86_64 :: Linux/check_memcpy.c

The executable now contains calls to memset. AFAICS this is a consequence of changing debug builds from -O1 to -O0 and thus is expected. Therefore I suggest to just add

XFAIL: !compiler-rt-optimized

Unfortunately I missed this in my local builds: I had run Debug builds on x86_64-pc-linux-gnu both with a vanilla tree and my patch, but already the vanilla results were insanely bad (309 FAILs), so I didn't notice the regression.

Oct 5 2022, 2:02 AM · Restricted Project, Restricted Project
ro committed rG93b1256e38f6: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests (authored by ro).
[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests
Oct 5 2022, 12:54 AM · Restricted Project, Restricted Project
ro closed D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Oct 5 2022, 12:53 AM · Restricted Project, Restricted Project

Oct 4 2022

ro updated the diff for D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
  • Update COMPILER_RT_UNITTEST_CFLAGS as requested.
  • Change SANITIZER_COMMON_CFLAGS to -O0 for COMPILER_RT_DEBUG, cannot reliably debug with optimization.
  • compiler-rt/lib/sanitizer_common/tests/sanitizer_type_traits_test.cpp tests SanitizerCommon.IsTriviallyDestructible and SanitizerCommon.IsTriviallyCopyable fail to link with debug build:
FAILED: projects/compiler-rt/lib/sanitizer_common/tests/Sanitizer-i386-Test
[...]
Undefined                       first referenced
 symbol                             in file
_ZN11__sanitizer17integral_constantIbLb1EE5valueE SANITIZER_TEST_OBJECTS.sanitizer_type_traits_test.cpp.i386.o
ld: fatal: symbol referencing errors
Maybe one can provide a definition of `__sanitizer::integral_constant<bool, true>::value`?
Oct 4 2022, 4:50 AM · Restricted Project, Restricted Project

Oct 3 2022

ro added a comment to D133561: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp.

Given that there were no comments from the SPARC reviewers in more than a week, I've now committed the patch as is.

Oct 3 2022, 5:05 AM · Restricted Project, Restricted Project
ro committed rG1774a8a7639a: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp (authored by ro).
[flang] Add Sparc support to Optimizer/CodeGen/Target.cpp
Oct 3 2022, 5:04 AM · Restricted Project, Restricted Project
ro closed D133561: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp.
Oct 3 2022, 5:04 AM · Restricted Project, Restricted Project

Sep 27 2022

ro updated the diff for D133579: Fix Solaris compilation.

Never use RLIMIT_RSS on Apple systems.

Sep 27 2022, 5:38 AM · Restricted Project
ro added inline comments to D133579: Fix Solaris compilation.
Sep 27 2022, 5:36 AM · Restricted Project
ro updated the diff for D133561: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp.

Run test on Linux/sparc64, too.

Sep 27 2022, 5:33 AM · Restricted Project, Restricted Project
ro added a comment to D133561: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp.
In D133561#3808337, @ro wrote:

This doesn't have any tests, could you please add some? If memory holds, you should be able to add some RUN/CHECK lines here: https://github.com/llvm/llvm-project/blob/main/flang/test/Fir/target-rewrite-complex.fir

The new testcase PASSes on sparcv9-sun-solaris2.11 and sparc64-unknown-linux-gnu. However, for 32-bit sparc it runs into an assertion failure

[...]

Not sure what the issue is there. I'm actually a bit surprised that it works for i386. When I tried to enable flang for armv7, MLIR didn't have very good support for 32-bit platforms, so I left it at that. If you know that users of 32-bit sparc really have a great need for a Fortran compiler, then feel free to investigate further, but I'm not sure how many other 32-bit platforms have an interest in flang/mlir, so maintaining it might turn out to be a non-trivial amount of work.

Sep 27 2022, 5:24 AM · Restricted Project, Restricted Project

Sep 23 2022

ro added a comment to D133556: [sanitizer_common] Restore sanitizer_procmaps_solaris.cpp compilation on Solaris 11.3.

No worries: I could easily keep the patch local to gcc for a while, and LLVM isn't affected anyway (apart from the staging buildmaster being down for more than a week).

Sep 23 2022, 6:51 AM · Restricted Project, Restricted Project
ro committed rG1cd4d63fb9ab: [sanitizer_common] Restore sanitizer_procmaps_solaris.cpp compilation on… (authored by ro).
[sanitizer_common] Restore sanitizer_procmaps_solaris.cpp compilation on…
Sep 23 2022, 6:50 AM · Restricted Project, Restricted Project
ro closed D133556: [sanitizer_common] Restore sanitizer_procmaps_solaris.cpp compilation on Solaris 11.3.
Sep 23 2022, 6:50 AM · Restricted Project, Restricted Project

Sep 22 2022

ro added a comment to D133561: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp.

This doesn't have any tests, could you please add some? If memory holds, you should be able to add some RUN/CHECK lines here: https://github.com/llvm/llvm-project/blob/main/flang/test/Fir/target-rewrite-complex.fir

Sep 22 2022, 5:38 AM · Restricted Project, Restricted Project
ro updated the diff for D133561: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp.

Add testcase.

Sep 22 2022, 5:36 AM · Restricted Project, Restricted Project

Sep 20 2022

ro added a comment to D133556: [sanitizer_common] Restore sanitizer_procmaps_solaris.cpp compilation on Solaris 11.3.

Ping? It's been a weed and a half.

Sep 20 2022, 7:29 AM · Restricted Project, Restricted Project

Sep 13 2022

ro added a comment to D133579: Fix Solaris compilation.

The mentioned issue talks about Flang (https://github.com/llvm/llvm-project/issues/57642), but the changes seem to all be in C/C++ files?

Sep 13 2022, 2:01 AM · Restricted Project

Sep 12 2022

ro committed rTb6c432bc951b: Disable MultiSource/UnitTests/C++11/frame_layout on SPARC (authored by ro).
Disable MultiSource/UnitTests/C++11/frame_layout on SPARC
Sep 12 2022, 11:08 AM · Restricted Project

Sep 11 2022

ro committed rGcadc9cdedfef: [compiler-rt] Handle non-canonical triples with new runtime lib layout (authored by ro).
[compiler-rt] Handle non-canonical triples with new runtime lib layout
Sep 11 2022, 2:26 AM · Restricted Project, Restricted Project
ro closed D133406: [compiler-rt] Handle non-canonical triples with new runtime lib layout.
Sep 11 2022, 2:26 AM · Restricted Project, Restricted Project
ro added a comment to D133406: [compiler-rt] Handle non-canonical triples with new runtime lib layout.
Sep 11 2022, 2:23 AM · Restricted Project, Restricted Project

Sep 10 2022

ro committed rG1e56821bac02: [Linux] Hack around Linux/sparc <bits/stdio-ldbl.h> (authored by ro).
[Linux] Hack around Linux/sparc <bits/stdio-ldbl.h>
Sep 10 2022, 12:38 AM · Restricted Project, Restricted Project
ro closed D133405: [Linux] Hack around Linux/sparc <bits/stdio-ldbl.h>.
Sep 10 2022, 12:38 AM · Restricted Project, Restricted Project

Sep 9 2022

ro requested review of D133579: Fix Solaris compilation.
Sep 9 2022, 7:30 AM · Restricted Project
ro updated the diff for D133405: [Linux] Hack around Linux/sparc <bits/stdio-ldbl.h>.

Add comment, tests.

Sep 9 2022, 5:16 AM · Restricted Project, Restricted Project
ro added a comment to D133405: [Linux] Hack around Linux/sparc <bits/stdio-ldbl.h>.

So, sparc64 gcc does seem to define the macro by default. (I am using Debian testing and can't tell whether it's distro setting or upstream default) ¯\_(ツ)_/¯

% sparc64-linux-gnu-gcc -E -dM -xc /dev/null -nostdinc | grep NO_INLINE
#define __NO_INLINE__ 1
Sep 9 2022, 5:15 AM · Restricted Project, Restricted Project
ro requested review of D133561: [flang] Add Sparc support to Optimizer/CodeGen/Target.cpp.
Sep 9 2022, 1:41 AM · Restricted Project, Restricted Project
ro requested review of D133556: [sanitizer_common] Restore sanitizer_procmaps_solaris.cpp compilation on Solaris 11.3.
Sep 9 2022, 1:17 AM · Restricted Project, Restricted Project

Sep 8 2022

ro added a comment to D133493: Disable MultiSource/UnitTests/C++11/frame_layout on SPARC.

If you filed a bug for the issue, it might be good to refer to it in CMakeLists.txt:)

Sep 8 2022, 10:46 AM · Restricted Project
ro committed rT83de0f31e66f: Disable MultiSource/UnitTests/C++11/frame_layout on SPARC (authored by ro).
Disable MultiSource/UnitTests/C++11/frame_layout on SPARC
Sep 8 2022, 8:48 AM · Restricted Project
ro closed D133493: Disable MultiSource/UnitTests/C++11/frame_layout on SPARC.
Sep 8 2022, 8:48 AM · Restricted Project
ro added a comment to D133493: Disable MultiSource/UnitTests/C++11/frame_layout on SPARC.
Sep 8 2022, 8:02 AM · Restricted Project
ro added a comment to D133493: Disable MultiSource/UnitTests/C++11/frame_layout on SPARC.

Sure, done: Issue #57626.

Sep 8 2022, 7:38 AM · Restricted Project
ro requested review of D133493: Disable MultiSource/UnitTests/C++11/frame_layout on SPARC.
Sep 8 2022, 7:30 AM · Restricted Project
ro added a comment to D133405: [Linux] Hack around Linux/sparc <bits/stdio-ldbl.h>.

It's not a compiler's job to define this workaround...

Sep 8 2022, 4:30 AM · Restricted Project, Restricted Project

Sep 7 2022

ro requested review of D133407: [Driver] Support non-canonical triples with new runtime lib layout.
Sep 7 2022, 2:13 AM · Restricted Project, Restricted Project
ro requested review of D133406: [compiler-rt] Handle non-canonical triples with new runtime lib layout.
Sep 7 2022, 2:02 AM · Restricted Project, Restricted Project
ro requested review of D133405: [Linux] Hack around Linux/sparc <bits/stdio-ldbl.h>.
Sep 7 2022, 1:53 AM · Restricted Project, Restricted Project

Aug 26 2022

ro committed rGa31426dc87ae: [asan][test] Fix typo in Unit/lit.site.cfg.py.in (authored by ro).
[asan][test] Fix typo in Unit/lit.site.cfg.py.in
Aug 26 2022, 10:51 PM · Restricted Project, Restricted Project
ro closed D132736: [asan][test] Fix typo in Unit/lit.site.cfg.py.in.
Aug 26 2022, 10:51 PM · Restricted Project, Restricted Project
ro added inline comments to D132736: [asan][test] Fix typo in Unit/lit.site.cfg.py.in.
Aug 26 2022, 10:48 PM · Restricted Project, Restricted Project
ro requested review of D132736: [asan][test] Fix typo in Unit/lit.site.cfg.py.in.
Aug 26 2022, 6:07 AM · Restricted Project, Restricted Project

Aug 22 2022

ro added a comment to D127964: [DCE] Eliminate no-op atan and atan2 calls.

Are tests passing on Solaris after 2981a9490277a7920936d287c?

Aug 22 2022, 1:37 PM · Restricted Project, Restricted Project

Aug 19 2022

ro added a comment to D127964: [DCE] Eliminate no-op atan and atan2 calls.
Aug 19 2022, 2:04 PM · Restricted Project, Restricted Project
ro committed rG8847d9a2424c: Reland "[mlir][test] Fix IR/AttributeTest.cpp compilation on Solaris" (authored by ro).
Reland "[mlir][test] Fix IR/AttributeTest.cpp compilation on Solaris"
Aug 19 2022, 1:00 PM · Restricted Project, Restricted Project
ro added a comment to D127964: [DCE] Eliminate no-op atan and atan2 calls.

I've looked around some more and it seems the Solaris libm acts within the C standard: all of C99, p.219, C11, p.239, and C17, p.147 state

A domain error may occur if both arguments are zero.

I've also found the atan2 docs on cppreference.com which says the same, adding

If the implementation supports IEEE floating-point arithmetic (IEC 60559),
Aug 19 2022, 7:55 AM · Restricted Project, Restricted Project
ro updated the diff for D131148: [mlir][test] Fix IR/AttributeTest.cpp compilation on Solaris.

Retested on amd64-pc-solaris2.11, sparcv9-sun-solaris2.11, and x86_64-pc-linux-gnu.

Aug 19 2022, 4:23 AM · Restricted Project, Restricted Project
ro added a comment to D131148: [mlir][test] Fix IR/AttributeTest.cpp compilation on Solaris.
Aug 19 2022, 4:15 AM · Restricted Project, Restricted Project

Aug 18 2022

ro added a comment to D127964: [DCE] Eliminate no-op atan and atan2 calls.
Aug 18 2022, 1:34 PM · Restricted Project, Restricted Project
ro added a comment to D127964: [DCE] Eliminate no-op atan and atan2 calls.

The llvm/test/Transforms/EarlyCSE/atan.ll test FAILs on Solaris (both sparcv9 and amd64):

/vol/llvm/src/llvm-project/local/llvm/test/Transforms/EarlyCSE/atan.ll:55:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: ret float -0.000000e+00
              ^

Comparing to the Linux/x86_64 version of the output, the only difference is

--- /homes/ro/atan.ll.x86_64	2022-08-18 12:38:48.313115000 +0200
+++ /homes/ro/atan.ll.sparcv9	2022-08-18 11:50:22.976866000 +0200
@@ -25,7 +25,8 @@
 }
Aug 18 2022, 3:41 AM · Restricted Project, Restricted Project
ro added a comment to D131148: [mlir][test] Fix IR/AttributeTest.cpp compilation on Solaris.

Actually that makes sense, this patch does not seem right.

Aug 18 2022, 3:37 AM · Restricted Project, Restricted Project