Page MenuHomePhabricator

ro (Rainer Orth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2016, 4:12 AM (258 w, 6 d)

Recent Activity

Apr 27 2021

ro added a comment to D91827: EXPERIMENTAL sign-extend addresses in CompactRingBuffer.

I have no idea. However, I've stopped LLVM development at least for a time, so I'm not going to pursue this at the moment.

Apr 27 2021, 12:20 AM · Restricted Project

Mar 25 2021

ro added inline comments to D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs.
Mar 25 2021, 3:15 AM · Restricted Project
ro added a comment to D98369: [sanitizer] Implement MapDynamicShadowAndAliases..

Indeed. However, the misleading filenames are just the tip of the iceberg. Hardcoding every feature check with platform macros instead of feature tests (preferably detected at build time) feels so 90ies...

Mar 25 2021, 2:44 AM · Restricted Project

Mar 24 2021

ro added a comment to D98369: [sanitizer] Implement MapDynamicShadowAndAliases..

This patch broke the Solaris buildbots (Solaris/sparcv9 and Solaris/amd64:

FAILED: projects/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.i386.dir/sanitizer_linux_libcdep.cpp.o
[...]
/vol/llvm/src/llvm-project/dist/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp: In function ‘__sanitizer::uptr __sanitizer::MremapCreateAlias(__sanitizer::uptr, __sanitizer::uptr, __sanitizer::uptr)’:
/vol/llvm/src/llvm-project/dist/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:928:26: error: ‘MREMAP_MAYMOVE’ was not declared in this scope
  928 |                          MREMAP_MAYMOVE | MREMAP_FIXED,
      |                          ^~~~~~~~~~~~~~
/vol/llvm/src/llvm-project/dist/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:928:43: error: ‘MREMAP_FIXED’ was not declared in this scope; did you mean ‘MAP_FIXED’?
  928 |                          MREMAP_MAYMOVE | MREMAP_FIXED,
      |                                           ^~~~~~~~~~~~
      |                                           MAP_FIXED

Despite its name, sanitizer_linux_libcdep.cpp is shared between FreeBSD, Linux, NetBSD, and Solaris, while according to the Linux manpage, mremap is Linux-only.

Mar 24 2021, 5:21 AM · Restricted Project

Mar 17 2021

ro requested changes to D98575: [compiler-rt] Link against libatomic on 32-bit Linux SPARC.

Sorry to chime in so late, but I believe this patch has several problems:

Mar 17 2021, 1:56 PM · Restricted Project
ro committed rG3b8b5d1f22f2: [sanitizer_common][test] Handle missing REG_STARTEND in Posix/regex_startend.cpp (authored by ro).
[sanitizer_common][test] Handle missing REG_STARTEND in Posix/regex_startend.cpp
Mar 17 2021, 1:57 AM
ro closed D98425: [sanitizer_common][test] Handle missing REG_STARTEND in Posix/regex_startend.cpp.
Mar 17 2021, 1:56 AM · Restricted Project

Mar 11 2021

ro added a comment to D96348: [sanitizers] Fix interception of GLibc regexec.
In D96348#2613450, @ro wrote:

It is a common extension that is present on all BSDs, macOS, Linux and possibly other operating systems. It think the best solution would be to add UNSUPPORTED: solaris or wrap the entire test in #ifdef REG_STARTEND and add a dummy main method?

It may be common, but it's nonstandard and certainly not univeral: I've just checked AIX 7.2 which doesn't have it either. I believe wrapping in #ifdef REG_STARTEND is better than repeatedly adjusting UNSUPPORTED clauses, provided the test can work on every target that has REG_STARTEND.

Mar 11 2021, 7:05 AM · Restricted Project
ro requested review of D98425: [sanitizer_common][test] Handle missing REG_STARTEND in Posix/regex_startend.cpp.
Mar 11 2021, 7:03 AM · Restricted Project

Mar 9 2021

ro added a comment to D96348: [sanitizers] Fix interception of GLibc regexec.
Mar 9 2021, 2:52 AM · Restricted Project
ro added a comment to D96348: [sanitizers] Fix interception of GLibc regexec.

The new test FAILs on Solaris:

SanitizerCommon-asan-i386-SunOS :: Posix/regex_startend.cpp
SanitizerCommon-ubsan-i386-SunOS :: Posix/regex_startend.cpp
SanitizerCommon-ubsan-x86_64-SunOS :: Posix/regex_startend.cpp

with

/vol/llvm/src/llvm-project/dist/compiler-rt/test/sanitizer_common/TestCases/Posix/regex_startend.cpp:22:44: error: use of undeclared identifier 'REG_STARTEND'
  int rv = regexec(preg, string, 1, match, REG_STARTEND);

This is no wonder given Linux regex(3) states

REG_STARTEND
       Use   pmatch[0]   on   the   input   string,  starting  at  byte
       pmatch[0].rm_so and ending before  byte  pmatch[0].rm_eo.   This
       allows  matching  embedded  NUL  bytes and avoids a strlen(3) on
       large strings.  It does not use nmatch on input,  and  does  not
       change REG_NOTBOL or REG_NEWLINE processing.  This flag is a BSD
       extension, not present in POSIX.

If the test requires glibc targets, it should be restricted to such.

Mar 9 2021, 2:45 AM · Restricted Project

Mar 5 2021

ro committed rGab8a46024157: [asan][test] Handle Solaris in large_func_test.cpp etc. (authored by ro).
[asan][test] Handle Solaris in large_func_test.cpp etc.
Mar 5 2021, 4:31 PM
ro closed D97931: [asan][test] Handle Solaris in large_func_test.cpp etc..
Mar 5 2021, 4:31 PM · Restricted Project
ro committed rG579fd0259788: [asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris (authored by ro).
[asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris
Mar 5 2021, 12:44 AM
ro closed D97933: [asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris.
Mar 5 2021, 12:44 AM · Restricted Project
ro committed rG1d0dee51daaf: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris (authored by ro).
[asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris
Mar 5 2021, 12:43 AM
ro closed D97932: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris.
Mar 5 2021, 12:43 AM · Restricted Project

Mar 4 2021

ro requested review of D97933: [asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris.
Mar 4 2021, 4:23 AM · Restricted Project
ro requested review of D97932: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris.
Mar 4 2021, 4:16 AM · Restricted Project
ro requested review of D97931: [asan][test] Handle Solaris in large_func_test.cpp etc..
Mar 4 2021, 4:09 AM · Restricted Project

Nov 25 2020

ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Nov 25 2020, 2:48 AM · Restricted Project, Restricted Project, Restricted Project

Nov 24 2020

ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Nov 24 2020, 6:00 AM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2020

ro updated the diff for D91605: [sanitizers] Implement GetTls on Solaris.
  • Move declarations to new sanitizer_solaris.h.
  • Augment check_linker_flag do reject unknown -z options that GNU ld noisily accepts.
Nov 23 2020, 6:42 AM · Restricted Project, Restricted Project, Restricted Project
ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Nov 23 2020, 6:39 AM · Restricted Project, Restricted Project, Restricted Project

Nov 20 2020

ro committed rG03d593dd7e6d: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris (authored by ro).
[sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris
Nov 20 2020, 5:07 AM
ro closed D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Nov 20 2020, 5:07 AM · Restricted Project
ro updated the diff for D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.

getpass.cpp changed to UNSUPPORTED.

Nov 20 2020, 5:03 AM · Restricted Project
ro added inline comments to D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Nov 20 2020, 5:02 AM · Restricted Project
ro committed rG0f69cbe2694a: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on… (authored by ro).
[sanitizer_common][test] Disable CombinedAllocator32Compact etc. on…
Nov 20 2020, 4:03 AM
ro closed D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.
Nov 20 2020, 4:02 AM · Restricted Project
ro updated the diff for D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.
  • Switch disablement to SKIP_ON_* form.
  • Add FIXME comment.
Nov 20 2020, 3:59 AM · Restricted Project
ro committed rGce6524d127d4: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC (authored by ro).
[sanitizer_common][test] Disable FastUnwindTest.* on SPARC
Nov 20 2020, 3:53 AM
ro closed D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Nov 20 2020, 3:52 AM · Restricted Project
ro updated the diff for D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.

Only disable actually failing tests using the SKIP_ON_* form.

Nov 20 2020, 2:46 AM · Restricted Project
ro added inline comments to D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Nov 20 2020, 2:42 AM · Restricted Project
ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Nov 20 2020, 1:52 AM · Restricted Project, Restricted Project, Restricted Project

Nov 19 2020

ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Nov 19 2020, 2:26 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D91617: [sanitizer_common][test] Disable CompactRingBuffer.int64 on Solaris/sparcv9.

Very interesting, thank you for the explanation.
It looks like this can be fixed by applying sign extension to the masked address?

Nov 19 2020, 2:07 AM · Restricted Project

Nov 18 2020

ro added inline comments to D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Nov 18 2020, 7:15 AM · Restricted Project
ro added a comment to D91617: [sanitizer_common][test] Disable CompactRingBuffer.int64 on Solaris/sparcv9.

Does it mean CompactRingBuffer is broken, or just the test?

Nov 18 2020, 6:58 AM · Restricted Project
ro added inline comments to D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Nov 18 2020, 6:38 AM · Restricted Project
ro added inline comments to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Nov 18 2020, 6:04 AM · Restricted Project
ro added a comment to D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.

Have you tried to change kAddressSpaceSize above?

Nov 18 2020, 5:37 AM · Restricted Project
ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Nov 18 2020, 12:40 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2020

ro requested review of D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.
Nov 17 2020, 5:12 AM · Restricted Project
ro requested review of D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Nov 17 2020, 4:57 AM · Restricted Project
ro requested review of D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Nov 17 2020, 4:49 AM · Restricted Project
ro requested review of D91617: [sanitizer_common][test] Disable CompactRingBuffer.int64 on Solaris/sparcv9.
Nov 17 2020, 4:42 AM · Restricted Project
ro requested review of D91615: [sanitizer_common] Don't try to unmap unaligned memory.
Nov 17 2020, 4:35 AM · Restricted Project
ro requested review of D91608: [sanitizer_common][test] Enable tests on SPARC.
Nov 17 2020, 3:23 AM · Restricted Project
ro requested review of D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc..
Nov 17 2020, 3:12 AM · Restricted Project
ro requested review of D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Nov 17 2020, 2:58 AM · Restricted Project
ro requested review of D91605: [sanitizers] Implement GetTls on Solaris.
Nov 17 2020, 2:28 AM · Restricted Project, Restricted Project, Restricted Project

Nov 13 2020

ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
Nov 13 2020, 5:48 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
Nov 13 2020, 5:42 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
In D90524#2393320, @ro wrote:

Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker.

Please be a little more patient: one ping a week is considered appropriate, but after only two days is a bit over the top.

The problem is that LLVM is a very fast moving target and when waiting long for changes to be merged, one constantly runs
into the risk of having to rebase patches.

Nov 13 2020, 4:39 AM · Restricted Project
ro abandoned D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32.

Superceded by D90524.

Nov 13 2020, 4:37 AM · Restricted Project
ro resigned from D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
In D90524#2393319, @ro wrote:

I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though.

Quite the contrary: the comment you cited

// FIXME: This is a bit of a hack. We should really unify this code for
// reasoning about oslibdir spellings with the lib dir spellings in the
// GCCInstallationDetector, but that is a more significant refactoring.

pretty clearly is about how/where support for that layout is implemented in the clang Driver code, not about the layout itself.

I don't understand that argument. I call it "workaround", the source comment calls it "hack". It's clearly not to stay forever as it's an ugly
workaround, but until a proper fix comes around, I would like to add "sparc" here as well so the testsuite failures drop from over
400 to just below 70.

Nov 13 2020, 4:36 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker.

Nov 13 2020, 1:51 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though.

Nov 13 2020, 1:50 AM · Restricted Project

Nov 9 2020

ro added a comment to D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

As I'd mentioned in D90524, I believe both patches should be merged into one. Otherwise, no matter in which order you commit them, the buildbots might show failures otherwise.

Nov 9 2020, 5:39 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

As it happens, I'd arrived at exactly the same patch when I tried a build on a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582.

Nov 9 2020, 5:36 AM · Restricted Project

Oct 14 2020

ro committed rG3b956a58f3c5: Reland "[Support][unittests] Enforce alignment in ConvertUTFTest" (authored by ro).
Reland "[Support][unittests] Enforce alignment in ConvertUTFTest"
Oct 14 2020, 3:03 AM
ro closed D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 14 2020, 3:03 AM · Restricted Project

Oct 13 2020

ro updated the diff for D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Align the last affected instance.

Oct 13 2020, 2:21 AM · Restricted Project
ro added a comment to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
In D88824#2325457, @rnk wrote:

I may have been the one that picked ArrayRef<char> as the parameter type here, and I think what I was thinking is: "files are full of bytes, the caller is most likely to have a bag of bytes that they want to hand to the re-encoding routine, so it should accept bytes, and I'll pick some arbitrary byte-like character type here". For example, MemoryBuffer gives you back a StringRef for the file contents, and you should be able to just plug that in here. MemoryBuffer probably happens to return aligned file contents in practice, but it doesn't advertise any alignment guarantee. So maybe the best fix is to underalign the UTF16 typedef, if that's possible. This is a serialization routine, after all: it should be really generous about what it accepts.

Oct 13 2020, 2:20 AM · Restricted Project

Oct 9 2020

ro requested review of D89130: [WIP][Sparc] Fix long double on 32-bit Solaris/SPARC.
Oct 9 2020, 7:03 AM · Restricted Project, Restricted Project, Restricted Project

Oct 8 2020

ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

What about reverting this now that you have found this is an issue with the Sun linker?

Oct 8 2020, 1:44 AM · Restricted Project
ro added a comment to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Why are we trying to enforce alignment like this in the first place? Writing an API that expects an overaligned ArrayRef<char> is just asking for trouble. There should be two possibilities:

Oct 8 2020, 1:39 AM · Restricted Project
ro added a comment to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

This breaks tests on Windows: http://45.33.8.238/win/25377/step_11.txt

PTAL, and if it takes a while to fix please revert while you investigate.

Oct 8 2020, 1:36 AM · Restricted Project

Oct 7 2020

ro committed rG53b3873cf428: [Support][unittests] Enforce alignment in ConvertUTFTest (authored by ro).
[Support][unittests] Enforce alignment in ConvertUTFTest
Oct 7 2020, 12:09 AM
ro closed D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 7 2020, 12:09 AM · Restricted Project

Oct 6 2020

ro updated the diff for D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Use alignas.

Oct 6 2020, 1:29 PM · Restricted Project
ro added inline comments to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 6 2020, 1:28 PM · Restricted Project

Oct 5 2020

ro added inline comments to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 5 2020, 6:43 AM · Restricted Project
ro updated the diff for D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Add assertion.
Run clang-format.

Oct 5 2020, 6:07 AM · Restricted Project
ro requested review of D88826: [builtins] Work around long double return bug on Solaris/sparcv9.
Oct 5 2020, 5:06 AM · Restricted Project
ro requested review of D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 5 2020, 4:25 AM · Restricted Project

Sep 30 2020

ro committed rG8a1084a94863: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris (authored by ro).
[asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris
Sep 30 2020, 1:59 PM
ro closed D88218: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris.
Sep 30 2020, 1:59 PM · Restricted Project
ro added a comment to D88218: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris.

Ping? It's been almost a week.

Sep 30 2020, 11:00 AM · Restricted Project
ro committed rG73fb9698c057: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes (authored by ro).
[asan][test] Several Posix/unpoison-alternate-stack.cpp fixes
Sep 30 2020, 9:57 AM
ro closed D88501: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes.
Sep 30 2020, 9:57 AM · Restricted Project
ro committed rGdc261d23d07c: [sanitizers] Fix internal__exit on Solaris (authored by ro).
[sanitizers] Fix internal__exit on Solaris
Sep 30 2020, 7:31 AM
ro closed D88404: [sanitizers] Fix internal__exit on Solaris.
Sep 30 2020, 7:31 AM · Restricted Project
ro added inline comments to D88501: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes.
Sep 30 2020, 7:03 AM · Restricted Project
ro added a comment to D88470: [clangd] Extract options struct for ClangdLSPServer. NFC.

This patch broke builds with gcc, e.g. Builder clang-solaris11-amd64 Build #6724:

[23/122] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o
FAILED: tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o 
/usr/gcc/9/bin/c++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/clangd/tool -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool -Itools/clang/tools/extra/clangd/../clang-tidy -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include -Itools/clang/include -Iinclude -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include/llvm/Support/Solaris -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/.. -Itools/clang/tools/extra/clangd/tool/.. -Itools/clang/tools/extra/clangd -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3     -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o -MF tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o.d -o tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o -c /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp
In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp:9:
/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdLSPServer.h:47:36: error: declaration of ‘llvm::Optional<clang::clangd::OffsetEncoding> clang::clangd::ClangdLSPServer::Options::OffsetEncoding’ changes meaning of ‘OffsetEncoding’ [-fpermissive]
   47 |     llvm::Optional<OffsetEncoding> OffsetEncoding;
      |                                    ^~~~~~~~~~~~~~
In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../Headers.h:12,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../CodeComplete.h:19,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdServer.h:13,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdLSPServer.h:12,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp:9:
/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../Protocol.h:370:12: note: ‘OffsetEncoding’ declared here as ‘enum class clang::clangd::OffsetEncoding’
  370 | enum class OffsetEncoding {
      |            ^~~~~~~~~~~~~~
Sep 30 2020, 2:12 AM · Restricted Project

Sep 29 2020

ro requested review of D88501: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes.
Sep 29 2020, 10:10 AM · Restricted Project

Sep 28 2020

ro requested review of D88404: [sanitizers] Fix internal__exit on Solaris.
Sep 28 2020, 4:58 AM · Restricted Project

Sep 24 2020

ro requested review of D88218: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris.
Sep 24 2020, 4:59 AM · Restricted Project
ro committed rG15c9af5618c8: [asan][test] Disable malloc-no-intercept.c on Solaris (authored by ro).
[asan][test] Disable malloc-no-intercept.c on Solaris
Sep 24 2020, 3:00 AM
ro closed D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Sep 24 2020, 2:59 AM · Restricted Project
ro added inline comments to D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Sep 24 2020, 2:57 AM · Restricted Project

Sep 20 2020

ro committed rG26947d7b6380: [tools][remarks-shlib] Don't build libRemarks.so without PIC (authored by ro).
[tools][remarks-shlib] Don't build libRemarks.so without PIC
Sep 20 2020, 3:41 AM
ro closed D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sep 20 2020, 3:41 AM · Restricted Project
ro added inline comments to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sep 20 2020, 3:39 AM · Restricted Project

Sep 18 2020

ro added inline comments to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sep 18 2020, 7:17 AM · Restricted Project
ro updated the diff for D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.

Wrap whole file in if(LLVM_ENABLE_PIC).

Sep 18 2020, 7:08 AM · Restricted Project
ro requested review of D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Sep 18 2020, 5:21 AM · Restricted Project

Sep 17 2020

ro abandoned D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl.

Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd.

Sep 17 2020, 4:31 AM · Restricted Project