Page MenuHomePhabricator

ro (Rainer Orth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2016, 4:12 AM (221 w, 2 d)

Recent Activity

Thu, Sep 24

ro requested review of D88218: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris.
Thu, Sep 24, 4:59 AM · Restricted Project
ro committed rG15c9af5618c8: [asan][test] Disable malloc-no-intercept.c on Solaris (authored by ro).
[asan][test] Disable malloc-no-intercept.c on Solaris
Thu, Sep 24, 3:00 AM
ro closed D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Thu, Sep 24, 2:59 AM · Restricted Project
ro added inline comments to D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Thu, Sep 24, 2:57 AM · Restricted Project

Sun, Sep 20

ro committed rG26947d7b6380: [tools][remarks-shlib] Don't build libRemarks.so without PIC (authored by ro).
[tools][remarks-shlib] Don't build libRemarks.so without PIC
Sun, Sep 20, 3:41 AM
ro closed D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sun, Sep 20, 3:41 AM · Restricted Project
ro added inline comments to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sun, Sep 20, 3:39 AM · Restricted Project

Fri, Sep 18

ro added inline comments to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Fri, Sep 18, 7:17 AM · Restricted Project
ro updated the diff for D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.

Wrap whole file in if(LLVM_ENABLE_PIC).

Fri, Sep 18, 7:08 AM · Restricted Project
ro requested review of D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Fri, Sep 18, 5:21 AM · Restricted Project

Thu, Sep 17

ro abandoned D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl.

Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd.

Thu, Sep 17, 4:31 AM · Restricted Project
ro added a comment to D87588: [ASTMatchers] extract public matchers from const-analysis into own patch.

As described in D87825, this patch broke Debug builds on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11.

Thu, Sep 17, 4:08 AM · Restricted Project
ro requested review of D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl.
Thu, Sep 17, 4:07 AM · Restricted Project
ro committed rGa9cbe5cf30e3: [X86] Fix stack alignment on 32-bit Solaris/x86 (authored by ro).
[X86] Fix stack alignment on 32-bit Solaris/x86
Thu, Sep 17, 2:18 AM
ro closed D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
Thu, Sep 17, 2:18 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

This patch avoid the issue by defaulting to -mstackrealign, just like gcc.

This sentence from the description should be removed.

Thu, Sep 17, 2:10 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

I'm still curious about the source of the vptr diff, but that's a minor question, otherwise. LGTM

Thu, Sep 17, 2:08 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 16

ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Also, it would be nice to have some regression test coverage; add a Solaris RUN line to llvm/test/CodeGen/X86/stack-align2.ll ?

Wed, Sep 16, 4:02 AM · Restricted Project, Restricted Project, Restricted Project
ro updated the diff for D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
  • Rely on stackAlignment default for 32-bit Solaris/x86
  • Handle Solaris in llvm/test/CodeGen/X86/stack-align2.ll
Wed, Sep 16, 4:00 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 15

ro updated the diff for D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Allow for whitespace differences in vptr.cpp.

Tue, Sep 15, 2:31 AM · Restricted Project, Restricted Project, Restricted Project
ro updated subscribers of D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
In D87615#2273427, @ro wrote:
Tue, Sep 15, 2:28 AM · Restricted Project, Restricted Project, Restricted Project
ro updated the diff for D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Tested on amd64-pc-solaris2.11. However, compared to the -mstackrealign version
there's one regression that I still need to investigate:

UBSan-Standalone-i386 :: TestCases/TypeCheck/vptr.cpp
Tue, Sep 15, 1:42 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

That claim of 16-byte alignment on Solaris is half-wrong: it's definitely wrong on Solaris, but seems to be true on Illumos.

Tue, Sep 15, 1:35 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
Tue, Sep 15, 1:27 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 14

ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Would it be possible to add some tests?

Mon, Sep 14, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
ro requested review of D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
Mon, Sep 14, 7:55 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 11

ro committed rG76e85ae268f8: [clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris (authored by ro).
[clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris
Fri, Sep 11, 12:54 AM
ro closed D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Fri, Sep 11, 12:54 AM · Restricted Project, Restricted Project

Thu, Sep 10

ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Ping? It's been a week and AFAICT there's nothing left for me to do.

Thu, Sep 10, 4:25 PM · Restricted Project, Restricted Project

Fri, Sep 4

ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Is there anything left to do to get approval? Thanks.

Fri, Sep 4, 2:06 AM · Restricted Project, Restricted Project

Thu, Sep 3

ro updated the diff for D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Add FIXME for SparcV8 MaxAtomicInlineWidth.

Thu, Sep 3, 1:45 AM · Restricted Project, Restricted Project

Wed, Sep 2

ro added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Wed, Sep 2, 12:00 PM · Restricted Project, Restricted Project
ro added a comment to D85415: [Sparc] Don't use SunStyleELFSectionSwitchSyntax.

I've now discovered that not only the sparc assembler output requires GNU as, but the same is true for x86:

  • as is invoked without -m64/-m32, thus chokes on amd64 insns since it default to 32-bit mode
  • Even if adding -Wa,-m64, assembly fails:
Assembler: main.c
	"/var/tmp/main-faae1e.s", line 24 : Syntax error
	Near line: "	.section	".note.GNU-stack","",@progbits"
  • There must be no double quotes around the section name.
  • Without the quotes, the section name is no valid identifier: - isn't allowed.
  • On top of that, Solaris doesn't care about those .note sections: to achieve non-executable stacks, you need e.g. ld -z sx=nxstack (Solaris 11.4) or ld -z nxstack (Solaris 11.3).
Wed, Sep 2, 4:00 AM · Restricted Project
ro added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Wed, Sep 2, 2:55 AM · Restricted Project, Restricted Project

Tue, Sep 1

ro added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Tue, Sep 1, 3:18 PM · Restricted Project, Restricted Project
ro added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Tue, Sep 1, 2:53 PM · Restricted Project, Restricted Project
ro added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Tue, Sep 1, 1:51 PM · Restricted Project, Restricted Project
ro added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Tue, Sep 1, 1:46 PM · Restricted Project, Restricted Project
ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Actually, __sparcv8 is only for V8; if you have 32-bit V9 on Solaris it defines __sparcv8plus _instead_:

jrtc27@gcc-solaris11:~$ /opt/solarisstudio12.4/bin/cc -E - -xarch=v9 -m32 -xdumpmacros </dev/null 2>&1 | grep sparc
#define __sparcv8plus 1
#define __sparc 1
#define sparc 1
Tue, Sep 1, 5:37 AM · Restricted Project, Restricted Project
ro updated the diff for D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Define __sparcv8 only on 32-bit Solaris/SPARC.
Update testcase.
Remove XFAILs that only apply to clang/2-stage builds.

Tue, Sep 1, 4:46 AM · Restricted Project, Restricted Project
ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

GCC on Linux defines __sparc_v9__ even with -m32. I don't know what Solaris does but please don't break other operating systems just because Solaris has broken headers that conflate the CPU and the ABI.

Tue, Sep 1, 2:43 AM · Restricted Project, Restricted Project
ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Tue, Sep 1, 2:33 AM · Restricted Project, Restricted Project

Mon, Aug 31

ro added reviewers for D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris: venkatra, efriedma.

Ping? It's been a week.

Mon, Aug 31, 1:22 AM · Restricted Project, Restricted Project

Sat, Aug 29

ro committed rG672d7836bbf0: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp (authored by ro).
[Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp
Sat, Aug 29, 1:02 AM
ro closed D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.
Sat, Aug 29, 1:01 AM · Restricted Project

Fri, Aug 28

ro added a comment to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

ro: In this case, I would say to defer to Paul, although I wish that he would change his mind.

Fri, Aug 28, 4:24 PM · Restricted Project
ro updated the diff for D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

Actual Option 1 variant.

Fri, Aug 28, 4:23 PM · Restricted Project
ro added a comment to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

My vote hasn't changed, I mean I already accepted the tweaked Option1 so you could have been done and dusted by now :) I just don't see what's gained from Option3's refactoring. It does the same as Option1 but in a less type safe/flexible/c++ way. Furthermore, the new interface is needlessly different to the other functions that handle SVE immediate values when the vector element type plays a role.

Fri, Aug 28, 3:24 PM · Restricted Project

Aug 28 2020

ro added a comment to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

We've got 3 alternative versions now:

  • my original one as simplified by Paul's suggestion (hadn't uploaded that, but certainly could recreate/retest if that's the selected candidate) Diff 1 in the History
  • the sizeof version, Diff 3 in the History
  • the (partial) non-template version, Diff 4 in the history
Aug 28 2020, 8:54 AM · Restricted Project
ro updated the diff for D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

Non-template version, passing ImmBytes around.

Aug 28 2020, 8:50 AM · Restricted Project
ro committed rG15c66b10114d: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9 (authored by ro).
[cmake] Don't build with -O3 -fPIC on Solaris/sparcv9
Aug 28 2020, 2:41 AM
ro closed D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.
Aug 28 2020, 2:41 AM · Restricted Project

Aug 27 2020

ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Feels like a hack, but I'm not strongly opposed either.

Aug 27 2020, 8:43 AM · Restricted Project
ro updated the diff for D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Handle both Release and RelWithDebInfo builds, downgrade from both -O3 and -O2 to
-O.

Aug 27 2020, 8:40 AM · Restricted Project
ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

While doing 2-stage builds, the 2 XFAILs due to Bug 42493 were required. However, I've since also done a 1-stage build with gcc 10, which shows

Unexpectedly Passed Tests (2):
  UBSan-Standalone-sparc :: TestCases/Float/cast-overflow.cpp
  UBSan-Standalone-sparc :: TestCases/Misc/log-path_test.cpp

which is no wonder since the underlying bug only exists in clang long double handling.

Aug 27 2020, 2:17 AM · Restricted Project, Restricted Project
ro added a comment to D85627: [polly][cmake] Don't build LLVMPolly.so without PIC.
In D85627#2226214, @ro wrote:

What do you mean by intended solution? My intent was to avoid breaking the build with PIC code turned off. Just as Windows doesn't support loadable modules and thus creation of LLVMPolly.so is disabled, it's just not possible to build a loadable module/shared object without PIC code, so there's no choice but to disable it.

I had a warning in mind, but you are right, there is no warning for Windows either. I didn't see the similarity. I could still be improved.

Aug 27 2020, 2:06 AM · Restricted Project, Restricted Project
ro committed rG26d659bbe080: [polly][cmake] Don't build LLVMPolly.so without PIC (authored by ro).
[polly][cmake] Don't build LLVMPolly.so without PIC
Aug 27 2020, 2:01 AM
ro closed D85627: [polly][cmake] Don't build LLVMPolly.so without PIC.
Aug 27 2020, 2:01 AM · Restricted Project, Restricted Project

Aug 26 2020

ro requested review of D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Aug 26 2020, 7:03 AM · Restricted Project, Restricted Project
ro added a comment to D86601: [LegalizeTypes] Add ROTL/ROTR to ScalarizeVectorResult..

I've just completed a sparcv9-sun-solaris2.11 2-stage RelWithDebInfo build with your patch applied: worked fine. Thanks a lot for the quick fix.

Aug 26 2020, 4:17 AM · Restricted Project

Aug 25 2020

ro added a comment to D77152: [SelectionDAG] Better legalization for FSHL and FSHR.

This patch broke sparcv9-sun-solaris2.11 RelWithDebInfo build: cf. Bug 47303.

Aug 25 2020, 9:05 AM · Restricted Project
ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.
In D85630#2223304, @ro wrote:
In D85630#2220694, @ro wrote:

Ping? It's been a week, the patch fixes ca. 250 testsuite failures and is this a candidate for LLVM 11.0.0 rc2.

You should file a bug and put 'release-11.0.0' in the blocker field to ensure this gets cherry-picked into the release/11.x branch.

Will do. However, by the time I posted the patch it wasn't (and still fully isn't) clear that the patch is ok/acceptable even for master.

Aug 25 2020, 1:08 AM · Restricted Project
ro committed rGe3585ff7af17: [compiler-rt][asan][test] Set LD_LIBRARY_PATH_{32,64} on Solaris (authored by ro).
[compiler-rt][asan][test] Set LD_LIBRARY_PATH_{32,64} on Solaris
Aug 25 2020, 12:37 AM
ro closed D86333: [compiler-rt][asan][test] Set LD_LIBRARY_PATH_{32,64} on Solaris.
Aug 25 2020, 12:37 AM · Restricted Project
ro added a comment to D86333: [compiler-rt][asan][test] Set LD_LIBRARY_PATH_{32,64} on Solaris.

LGTM if it works. I don't have SunOS to test.

Aug 25 2020, 12:33 AM · Restricted Project

Aug 24 2020

ro added a comment to D85116: [compiler-rt][profile] Fix various InstrProf tests on Solaris.

First, how did you verify that this patch is the culprit? While it seems plausible, I've seen too many cases where a likely candidate turned out to be innocent, wasting everyone's time.

When chromium folks were rolling clang, it was the only suspect in code coverage changes - llvmorg-12-init-1771-g1bd7046e : llvmorg-12-init-3492-ga1caa302 [like git hash, these are tags, git checkout to them work ]

Aug 24 2020, 11:29 AM · Restricted Project
ro added a comment to D85116: [compiler-rt][profile] Fix various InstrProf tests on Solaris.

We are seeing regressions on Linux, from this. See https://github.com/google/oss-fuzz/issues/4348. Can you please revert as it breaks coverage on several linux binaries.

Aug 24 2020, 2:51 AM · Restricted Project

Aug 21 2020

ro requested review of D86333: [compiler-rt][asan][test] Set LD_LIBRARY_PATH_{32,64} on Solaris.
Aug 21 2020, 12:48 AM · Restricted Project

Aug 20 2020

ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.
In D85630#2228328, @ro wrote:
Aug 20 2020, 7:59 AM · Restricted Project
ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.
In D85630#2223313, @ro wrote:

I agree with James.

Also, since you're applying this work-around for gcc, I assume the tests pass in the bootstrapped build, i.e. when compiling with clang?

I'd initially restricted the workaround to gcc because the reduced testcase attached to the GCC PR works when compiled with clang++ instead of g++. However, a bootstrap build is still nightmarishly bad on Solaris/sparcv9: the 11.0.0-rc1 one had 4817 failures, a fresh one on master with the workaround applied to both gcc and clang is down to 1365.

So there's at least some improvement, but still a long way to go.

Aug 20 2020, 6:15 AM · Restricted Project
ro updated the diff for D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Update comment.
Use -O with clang, too.

Aug 20 2020, 6:03 AM · Restricted Project

Aug 19 2020

ro added a comment to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

I have no real objections to this patch other than I prefer:

bool IsByte = std::is_same<int8_t, std::make_signed_t<T>>::value ||
              std::is_same<int8_t, T>::value;

if that works for your use case, if not then I'm happy with your current solution. Please can you give others a day or so longer to intervene in case they have a better suggestion.

Aug 19 2020, 8:44 AM · Restricted Project
ro added a comment to D85627: [polly][cmake] Don't build LLVMPolly.so without PIC.

Could you outline your intended solution? If I read correctly, with LLVM_ENABLE_PIC=OFF, no Polly module will be built, making Polly useless unless Polly is built in-tree and LLVM_POLLY_LINK_INTO_TOOLS is used.

Aug 19 2020, 7:54 AM · Restricted Project, Restricted Project
ro updated the diff for D85627: [polly][cmake] Don't build LLVMPolly.so without PIC.

Improve comments.

Aug 19 2020, 7:51 AM · Restricted Project, Restricted Project
ro accepted D86166: sanitizer_common: Use void* for madvise first argument on Solaris..

Tested on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11 (both Solaris 11.4 and OpenIndiana).

Aug 19 2020, 6:57 AM · Restricted Project
ro added a comment to D85415: [Sparc] Don't use SunStyleELFSectionSwitchSyntax.
In D85415#2223611, @ro wrote:

Instead of adapting the affected tests, this patch changes that default. The internal assembler still accepts both forms as input, only the output syntax is affected.

There's a check in the parser for usesSunStyleELFSectionSwitchSyntax(); what effect does that have?

It now rejects the Sun-style syntax on input. That's certainly not what I wanted to happen: instead my intent was to produce common ELF syntax on output, but accept both on input as the current/unpatched clang does. I must have been dreaming when I tested this!

Aug 19 2020, 6:03 AM · Restricted Project
ro added a comment to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

The problem boils down to the fact that int8_t is plain char on Solaris: both the sparc and i386 psABIs have char as signed. However, with ...

So, is -funsigned-char unsupported on Solaris?

Aug 19 2020, 2:26 AM · Restricted Project
ro added inline comments to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.
Aug 19 2020, 2:14 AM · Restricted Project
ro updated the diff for D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

Use sizeof(T) == 2 check, too.
Update variable name.

Aug 19 2020, 2:10 AM · Restricted Project

Aug 18 2020

ro added inline comments to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.
Aug 18 2020, 2:09 PM · Restricted Project
ro updated the diff for D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

Just check sizeof(T) == 1.

Aug 18 2020, 2:07 PM · Restricted Project
ro added inline comments to D85870: sanitizer_common: Introduce internal_madvise and start using it..
Aug 18 2020, 1:41 PM · Restricted Project
ro added a comment to D86166: sanitizer_common: Use void* for madvise first argument on Solaris..
In D86166#2224690, @pcc wrote:

@ro On D85870 you mentioned that the declaration has been changed in Solaris 11.4 to use void * which causes a build break on 11.4 due to the incompatible declaration. I checked illumos and it looks like their declaration still has caddr_t, although the comment above this declaration implies that that shouldn't matter because the system's declaration isn't visible. But what about older versions of Solaris? Presumably they still have a declaration with caddr_t so I imagine the build would break with an incompatible declaration error there. Or do we not care about older versions?

Aug 18 2020, 1:33 PM · Restricted Project
ro added inline comments to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.
Aug 18 2020, 7:11 AM · Restricted Project
ro added a comment to D85415: [Sparc] Don't use SunStyleELFSectionSwitchSyntax.

Instead of adapting the affected tests, this patch changes that default. The internal assembler still accepts both forms as input, only the output syntax is affected.

There's a check in the parser for usesSunStyleELFSectionSwitchSyntax(); what effect does that have?

Aug 18 2020, 5:58 AM · Restricted Project
ro added reviewers for D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp: efriedma, david-arm, paulwalker-arm.

Ping^2? Two weeks now.

Aug 18 2020, 5:23 AM · Restricted Project
ro added inline comments to D85870: sanitizer_common: Introduce internal_madvise and start using it..
Aug 18 2020, 5:03 AM · Restricted Project
ro added a comment to D85346: [compiler-rt][test] XFAIL two tests on 32-bit sparc.

At least 3 of selected reviewer are not active recently.

Aug 18 2020, 2:36 AM · Restricted Project
ro committed rG13080ca1f082: [compiler-rt][test] XFAIL two tests on 32-bit sparc (authored by ro).
[compiler-rt][test] XFAIL two tests on 32-bit sparc
Aug 18 2020, 2:33 AM
ro closed D85346: [compiler-rt][test] XFAIL two tests on 32-bit sparc.
Aug 18 2020, 2:33 AM · Restricted Project
ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

I agree with James.

Also, since you're applying this work-around for gcc, I assume the tests pass in the bootstrapped build, i.e. when compiling with clang?

Aug 18 2020, 2:29 AM · Restricted Project
ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.
In D85630#2220694, @ro wrote:

Ping? It's been a week, the patch fixes ca. 250 testsuite failures and is this a candidate for LLVM 11.0.0 rc2.

You should file a bug and put 'release-11.0.0' in the blocker field to ensure this gets cherry-picked into the release/11.x branch.

Aug 18 2020, 2:22 AM · Restricted Project
ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Presumably this is a bug in something -- either the solaris linker, in g++, or in the llvm code being mis-compiled? It seems unfortunate to put in place a hacky workaround like this, without a bug reference to the responsible component.

Aug 18 2020, 2:21 AM · Restricted Project
ro added a comment to D85346: [compiler-rt][test] XFAIL two tests on 32-bit sparc.

Ping? Two weeks now.

Aug 18 2020, 1:02 AM · Restricted Project

Aug 17 2020

ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Ping? It's been a week, the patch fixes ca. 250 testsuite failures and is this a candidate for LLVM 11.0.0 rc2.

Aug 17 2020, 1:19 AM · Restricted Project

Aug 13 2020

ro committed rZORGcc31e521f3ca: Solaris buildbot updates (authored by ro).
Solaris buildbot updates
Aug 13 2020, 2:00 PM
ro closed D85462: [zorg] Solaris buildbot updates.
Aug 13 2020, 2:00 PM · Restricted Project
ro added inline comments to D85870: sanitizer_common: Introduce internal_madvise and start using it..
Aug 13 2020, 1:49 PM · Restricted Project
ro committed rGf59bec7acb82: [clang][Driver] Default to /usr/bin/ld on Solaris (authored by ro).
[clang][Driver] Default to /usr/bin/ld on Solaris
Aug 13 2020, 1:44 PM
ro closed D84029: [clang][Driver] Default to /usr/bin/ld on Solaris.
Aug 13 2020, 1:44 PM · Restricted Project, Restricted Project