- User Since
- Jan 30 2018, 2:05 AM (42 w, 2 d)
Thu, Nov 1
Oct 2 2018
Sep 18 2018
Can someone commit this, please?
Sep 17 2018
How do we move forward now?
Sep 16 2018
I was so much looking forward to this getting merged :-(.
Sep 14 2018
Great, thanks a lot! I'm also just learning how to contribute to LLVM as their setup is a bit unusual ;-).
@JDevlieghere Can you commit this fix on behalf of jrtc27? He's currently on vacation.
@LionNatsu Could you push your commit yourself or do you need someone else to push it?
Not sure how this is supposed to be tested as this requires a proper Debian powerpcspe chroot.
I don't have commit access, btw. So it would be nice if someone else could commit this for me.
Sep 13 2018
I'd be very happy to support Artyom as a co-maintainer. I assume Artyom wants to be the code owner since he already stated, he wants to develop the code at LLVM upstream.
No worries. Very glad it got finally picked up for review.
or ask someone to commit for you -- I can do so if you like.
I have pushed a rebase revision here: https://reviews.llvm.org/D52050
I don't think that "test/Driver/linux-header-search.cpp" needs to be updated. x32 is actually supported in both an x86_64-linux-gnu environment and x86_64-linux-gnux32 environment. In order to update test/Driver/linux-header-search.cpp, we would have to add a debian-10-x32 chroot to the LLVM test environment. However, the patch by @jrtc27 actually doesn't break the previous tests as his patch just allows the native header and library paths as altnernative search paths.
I have just rebased the patch and I am looking at the tests now.
@m4yers I think you need to add reviewers here as well, no?
Has this been merged now? I don't see it in the github mirror yet.
Sep 11 2018
Ok, thanks for the explanation. I wasn't sure how it's handled in LLVM. I'm in the OpenJDK upstream project and we always require two reviewers for changes to Hotspot!
Does this still need a review from cuviper?
Aug 30 2018
Aug 27 2018
This patch fixes a problem with Rust emitting code with causing unaligned access: https://github.com/rust-lang/rust/issues/53181
May 13 2018
Is there any chance this PR can get completed?
Feb 28 2018
As a heads-up, powerpcspe needs a similar treatment as it suffers from the same problem:
Feb 20 2018
Cool, thank you! \o/