Page MenuHomePhabricator

glaubitz (John Paul Adrian Glaubitz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2018, 2:05 AM (89 w, 4 d)

Recent Activity

Mar 31 2019

glaubitz added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Well, I don't really know what to add here. The GCCDIST path on 32-bit PowerPC SUSE distributions has always been "powerpc64-suse-linux" according to SUSE's gcc maintainer Richard Biener and my patch just fixes that.

Mar 31 2019, 6:08 AM · Restricted Project

Dec 29 2018

glaubitz added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

A couple of questions since I am not all that familiar with clang and am certainly not familiar with this unusual SUSE 32-bit situation:

  • We seem to be changing the set of aliases here, but what happens if someone actually explicitly specifies --target=powerpc-suse-linux?
Dec 29 2018, 2:39 PM · Restricted Project
glaubitz added a comment to D54409: PowerPC/SPE: Fix load/store handling for SPE.

Other than the minor nit about the test case, LGTM.

Dec 29 2018, 1:46 PM · Restricted Project

Dec 21 2018

glaubitz added a comment to D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang.

Ok, I found the fix for the first crash that landed in 8.0 trunk. It works fine for me if backported to 7.0.1:
https://reviews.llvm.org/D50461

Dec 21 2018, 8:33 AM · Restricted Project, Restricted Project

Dec 8 2018

glaubitz added a comment to D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang.

Might the first crash from https://reviews.llvm.org/D49754#1183753 reproduce for you or perhaps you have already bisected to trunk to figure out the changest that fixes it?

Dec 8 2018, 2:18 AM · Restricted Project, Restricted Project

Dec 6 2018

glaubitz added a comment to D54583: PowerPC: Optimize SPE double parameter calling setup.

I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D49754 and https://reviews.llvm.org/D54409 saw no regressions on x86_64 and 32-bit PowerPC.

Dec 6 2018, 1:31 AM · Restricted Project
glaubitz added a comment to D54409: PowerPC/SPE: Fix load/store handling for SPE.

I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D49754 and https://reviews.llvm.org/D54583 saw no regressions on x86_64 and 32-bit PowerPC.

Dec 6 2018, 1:31 AM · Restricted Project
glaubitz added a comment to D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang.

I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D54409 and https://reviews.llvm.org/D54583 saw no regressions on x86_64 and 32-bit PowerPC.

Dec 6 2018, 1:28 AM · Restricted Project, Restricted Project

Dec 5 2018

glaubitz updated the diff for D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Added a comment explaining the unusual triplet name.

Dec 5 2018, 7:55 AM · Restricted Project
glaubitz added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Well, I agree on the comment to clarify why it has to be powerpc64-suse-linux, but I'm not sure whether anyone will ever start a SUSE derivative for 32-bit PowerPC, then fix the path in SUSE's gcc and then do a mass-rebuild. I think the probability is pretty low.

Dec 5 2018, 7:50 AM · Restricted Project
glaubitz created D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.
Dec 5 2018, 7:26 AM · Restricted Project

Nov 1 2018

Herald updated subscribers of D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang.
Nov 1 2018, 3:19 PM · Restricted Project, Restricted Project

Oct 2 2018

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Oct 2 2018, 4:54 AM

Sep 18 2018

glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Can someone commit this, please?

Sep 18 2018, 11:31 AM

Sep 17 2018

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

How do we move forward now?

Sep 17 2018, 5:42 AM

Sep 16 2018

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

I was so much looking forward to this getting merged :-(.

Sep 16 2018, 11:29 AM

Sep 14 2018

glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Great, thanks a lot! I'm also just learning how to contribute to LLVM as their setup is a bit unusual ;-).

Sep 14 2018, 2:40 PM
glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

@JDevlieghere Can you commit this fix on behalf of jrtc27? He's currently on vacation.

Sep 14 2018, 2:23 PM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

@LionNatsu Could you push your commit yourself or do you need someone else to push it?

Sep 14 2018, 2:20 PM
glaubitz added a comment to D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.

Not sure how this is supposed to be tested as this requires a proper Debian powerpcspe chroot.

Sep 14 2018, 6:09 AM
glaubitz added a comment to D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.

I don't have commit access, btw. So it would be nice if someone else could commit this for me.

Sep 14 2018, 3:26 AM

Sep 13 2018

glaubitz created D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.
Sep 13 2018, 6:20 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Chandler!

Sep 13 2018, 5:46 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

I'd be very happy to support Artyom as a co-maintainer. I assume Artyom wants to be the code owner since he already stated, he wants to develop the code at LLVM upstream.

Sep 13 2018, 5:20 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

No worries. Very glad it got finally picked up for review.

Sep 13 2018, 5:13 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Sep 13 2018, 5:00 PM
glaubitz updated subscribers of D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Sep 13 2018, 12:38 PM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

or ask someone to commit for you -- I can do so if you like.

Sep 13 2018, 12:05 PM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I have pushed a rebase revision here: https://reviews.llvm.org/D52050

Sep 13 2018, 12:02 PM
glaubitz created D52050: [Driver] Fix search paths on x32.
Sep 13 2018, 12:01 PM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I don't think that "test/Driver/linux-header-search.cpp" needs to be updated. x32 is actually supported in both an x86_64-linux-gnu environment and x86_64-linux-gnux32 environment. In order to update test/Driver/linux-header-search.cpp, we would have to add a debian-10-x32 chroot to the LLVM test environment. However, the patch by @jrtc27 actually doesn't break the previous tests as his patch just allows the native header and library paths as altnernative search paths.

Sep 13 2018, 11:59 AM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I have just rebased the patch and I am looking at the tests now.

Sep 13 2018, 11:42 AM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

@m4yers I think you need to add reviewers here as well, no?

Sep 13 2018, 11:22 AM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Has this been merged now? I don't see it in the github mirror yet.

Sep 13 2018, 11:18 AM

Sep 11 2018

glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Ok, thanks for the explanation. I wasn't sure how it's handled in LLVM. I'm in the OpenJDK upstream project and we always require two reviewers for changes to Hotspot!

Sep 11 2018, 9:28 AM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Does this still need a review from cuviper?

Sep 11 2018, 8:49 AM

Aug 30 2018

glaubitz added inline comments to D50858: [M680x0] Add ELF and Triple info.
Aug 30 2018, 1:57 PM

Aug 27 2018

glaubitz added a comment to D51335: [SROA] Fix alignment for uses of PHI nodes..

This patch fixes a problem with Rust emitting code with causing unaligned access: https://github.com/rust-lang/rust/issues/53181

Aug 27 2018, 11:47 PM

May 13 2018

glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Is there any chance this PR can get completed?

May 13 2018, 5:28 AM

Feb 28 2018

glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

As a heads-up, powerpcspe needs a similar treatment as it suffers from the same problem:

Feb 28 2018, 2:15 AM

Feb 20 2018

glaubitz added a comment to D43271: [Sparc] Include __tls_get_addr in symbol table for TLS calls to it.

Cool, thank you! \o/

Feb 20 2018, 2:14 AM