glaubitz (John Paul Adrian Glaubitz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2018, 2:05 AM (33 w, 3 d)

Recent Activity

Tue, Sep 18

glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Can someone commit this, please?

Tue, Sep 18, 11:31 AM

Mon, Sep 17

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

How do we move forward now?

Mon, Sep 17, 5:42 AM

Sun, Sep 16

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

I was so much looking forward to this getting merged :-(.

Sun, Sep 16, 11:29 AM

Fri, Sep 14

glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Great, thanks a lot! I'm also just learning how to contribute to LLVM as their setup is a bit unusual ;-).

Fri, Sep 14, 2:40 PM
glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

@JDevlieghere Can you commit this fix on behalf of jrtc27? He's currently on vacation.

Fri, Sep 14, 2:23 PM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

@LionNatsu Could you push your commit yourself or do you need someone else to push it?

Fri, Sep 14, 2:20 PM
glaubitz added a comment to D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.

Not sure how this is supposed to be tested as this requires a proper Debian powerpcspe chroot.

Fri, Sep 14, 6:09 AM
glaubitz added a comment to D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.

I don't have commit access, btw. So it would be nice if someone else could commit this for me.

Fri, Sep 14, 3:26 AM

Thu, Sep 13

glaubitz created D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.
Thu, Sep 13, 6:20 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Chandler!

Thu, Sep 13, 5:46 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

I'd be very happy to support Artyom as a co-maintainer. I assume Artyom wants to be the code owner since he already stated, he wants to develop the code at LLVM upstream.

Thu, Sep 13, 5:20 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

No worries. Very glad it got finally picked up for review.

Thu, Sep 13, 5:13 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Thu, Sep 13, 5:00 PM
glaubitz updated subscribers of D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Thu, Sep 13, 12:38 PM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

or ask someone to commit for you -- I can do so if you like.

Thu, Sep 13, 12:05 PM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I have pushed a rebase revision here: https://reviews.llvm.org/D52050

Thu, Sep 13, 12:02 PM
glaubitz created D52050: [Driver] Fix search paths on x32.
Thu, Sep 13, 12:01 PM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I don't think that "test/Driver/linux-header-search.cpp" needs to be updated. x32 is actually supported in both an x86_64-linux-gnu environment and x86_64-linux-gnux32 environment. In order to update test/Driver/linux-header-search.cpp, we would have to add a debian-10-x32 chroot to the LLVM test environment. However, the patch by @jrtc27 actually doesn't break the previous tests as his patch just allows the native header and library paths as altnernative search paths.

Thu, Sep 13, 11:59 AM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I have just rebased the patch and I am looking at the tests now.

Thu, Sep 13, 11:42 AM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

@m4yers I think you need to add reviewers here as well, no?

Thu, Sep 13, 11:22 AM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Has this been merged now? I don't see it in the github mirror yet.

Thu, Sep 13, 11:18 AM

Tue, Sep 11

glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Ok, thanks for the explanation. I wasn't sure how it's handled in LLVM. I'm in the OpenJDK upstream project and we always require two reviewers for changes to Hotspot!

Tue, Sep 11, 9:28 AM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Does this still need a review from cuviper?

Tue, Sep 11, 8:49 AM

Thu, Aug 30

glaubitz added inline comments to D50858: [M680x0] Add ELF and Triple info.
Thu, Aug 30, 1:57 PM

Mon, Aug 27

glaubitz added a comment to D51335: [SROA] Fix alignment for uses of PHI nodes..

This patch fixes a problem with Rust emitting code with causing unaligned access: https://github.com/rust-lang/rust/issues/53181

Mon, Aug 27, 11:47 PM

May 13 2018

glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Is there any chance this PR can get completed?

May 13 2018, 5:28 AM

Feb 28 2018

glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

As a heads-up, powerpcspe needs a similar treatment as it suffers from the same problem:

Feb 28 2018, 2:15 AM

Feb 20 2018

glaubitz added a comment to D43271: [Sparc] Include __tls_get_addr in symbol table for TLS calls to it.

Cool, thank you! \o/

Feb 20 2018, 2:14 AM