User Details
- User Since
- Aug 13 2019, 4:58 AM (151 w, 1 d)
Tue, Jun 28
Sun, Jun 12
Thanks, I am seeing improvements with this new version. I'll try to go over the changes in more detail later, some initial superficial comments now.
Tue, Jun 7
Comparing the changes to the tests in this diff to those in D127073, I am seeing a number of tests where we have more shufflevectors, and none where we have fewer. Are there improvements that are not as obvious to see?
Mon, Jun 6
Jun 5 2022
Jun 4 2022
Jun 3 2022
The updates to the tests suggest that this doesn't just fix the broken cases, it generates worse code where the previously generated code was already correct: I'm seeing insertelements into a vector immediately followed by a shufflevector that discards the inserted element, where previously those elements were not set. Is there some way that we can avoid that?
Jun 2 2022
The value coming from an unreachable block from entry is uninitialized
May 3 2022
May 2 2022
Apr 26 2022
Add a comment explaining why we do not use address size overrides here.
Apr 25 2022
Clean up test slightly to load consecutive i32 values like the i64 version did
Apr 24 2022
Apr 20 2022
Fixed release notes to use correct RST syntax.
Apr 19 2022
Apr 18 2022
Extend test, add assert.
Add to release notes.
Allow the old mangling with suitable -fclang-abi-compat= value
ping. Apologies, I don't know who to add as a reviewer, there is no one specifically listed as code owner and it does not seem to be handled by anyone in particular. @urnathan, @erichkeane, you two appear to be the most recent people who pushed commits specifically for mangling issues, would either of you be able to review this?
Apr 12 2022
I've pushed D122540, would you like me to push this as well or would you rather do that yourself?
Apr 11 2022
I mentioned that I'd prefer to get another person to review this as well but in the interest of just getting the bug fixed, I'll merge this tomorrow if there is no more feedback.
Apr 6 2022
Apr 1 2022
Mar 31 2022
Mar 29 2022
Question: does this need to be covered by -fclang-abi-compat= when the prior mangling resulted in names that even llvm-cxxfilt agreed made no sense? (If it is needed, it should be an easy change.)
Mar 28 2022
Mar 26 2022
Mar 22 2022
Mar 17 2022
Hi, what is the rationale here? This reuses the logic that was written for OpenCL mode, but in OpenCL mode, it was made an error with the idea that a new keyword addrspace_cast could be used in those cases where the user actually wants an address space cast. Here, in SYCL mode, it's just made an error with no way out for the user that I can see if they actually want this. Is this really correct?
Feb 24 2022
Simplify ProfiledCallGraphNode's types by reusing earlier types.
Feb 14 2022
Jan 21 2022
Jan 12 2022
Jan 6 2022
Nov 30 2021
Apologies, forgot about this, and thanks. I personally think it might have been slightly simpler to check whether dot -Tpdf </dev/null (or an equivalent that avoids the shell) exits successfully, instead of having to parse dot's output, but since you already have it working this way, I'm also okay if you want to leave it as it is.
Nov 26 2021
@tstellar Apologies, but I had very intentionally not reviewed this. This patch was misleadingly presented as doing what you had asked when it does the opposite (note the edit history on https://reviews.llvm.org/D96914#3141049, the author is perfectly aware that this is opt-out, not opt-in, but presents it as opt-in anyway), and was accompanied by an insult. I don't think there's actually any point in trying to engaging constructively here, the author is engaging in malicious behaviour and as long as that continues the technical aspects are irrelevant.