Page MenuHomePhabricator

joerg (Joerg Sonnenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2012, 10:16 AM (326 w, 20 h)

Recent Activity

Tue, Feb 19

joerg added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

Actually, since it used to be part of XSI, I would include it unconditionally and only conditionalize it if a system starts to actually drop it.

Tue, Feb 19, 9:09 AM · Restricted Project, Restricted Project

Tue, Feb 5

joerg added a comment to D57749: [LLD][ELF] - Set DF_STATIC_TLS flag for i386 target..

The description is certainly not right. IE can be used from dlopen'd objects without problems as long as there is still reserved space around and the data is not initialized non-trivially or the dynamic linker is willing to fix up all threads. The point of the flag is to allow the dynamic linker to make a quick decision without having to scan the relocation table first. A classic user of this was libGL. It also applies to many platforms, not just i386. As such, please update the description before any commit.

Tue, Feb 5, 11:05 AM · Restricted Project

Wed, Jan 30

joerg added a comment to D57385: [ELF] Support --{,no-}allow-shlib-undefined.

Neither GNU ld nor gold implement really useful behavior here. Ideally, every library would be linked with -z defs, but that normally doesn't work because on many systems certain symbols are imported from the main program by default. A good example are the entry points of the dynamic linker. A bad example historically speaking is libwrap. From a user perspective it would be desirable to have a way to say "This symbol will be supplied by someone else" when linking a shared library or potentially even the main binary. That would allow whitelisting intentionally undefined symbols and allow avoiding any symbol resolution dance for shared libraries. A single pass over the symbol tables is still necessary for the sake of knowing the defined symbols and for potential copy relocations, but no further work should be needed.

Wed, Jan 30, 6:05 AM · Restricted Project

Fri, Jan 25

joerg added a comment to D57143: [builtins] Rounding mode support for addxf3/subxf3.

This seems to imply hard-float support though? Accessing floating point registers when using soft-float is not going to get very far.

Fri, Jan 25, 4:27 PM · Restricted Project, Restricted Project

Jan 21 2019

joerg added a comment to D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

I'd really prefer to keep the argv[0] code as is. I'm not sure what that test case is supposed to do, but it seems quite questionable as "check" is not a valid language frontend nor a version suffix. It should not work.

Jan 21 2019, 1:26 AM

Jan 15 2019

joerg added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

For the clang side, I don't understand why Driver::GetFilePath is not good enough. This shouldn't need all toolchain changes at all.

Jan 15 2019, 8:16 AM · Restricted Project, Restricted Project
joerg added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

As discussed with dankm on IRC, I still would like to see the correct behavior going into 8.0, i.e. not change it later. Since this also matters for potential faster implementations later, it seems like a good idea to do it now. The changes are well-localized.

Jan 15 2019, 4:41 AM · Restricted Project

Jan 14 2019

joerg added a comment to D56647: [WIP] [ELF] Implement --copy-dt-needed-entries.

As first step, it goes into the right direction. I would explicitly set --as-needed for all those indirectly loaded objects. If people want to retain the questionable behavior of newer GNU tools, it could be a separate flag so that a final round can warn if an indirectly pulled library is necessary, but that behavior doesn't IMO make much sense. Full version has to look at DT_RUNPATH/DT_RPATH and also --rpath-link.

Jan 14 2019, 1:10 PM

Jan 11 2019

joerg added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Right, I'm not aware of anyone but FreeBSD really using the OSABI field. For FreeBSD it was a long standing hack around limitations in the ELF kernel loader. I'm not even sure if FreeBSD use(d) to set the OSABI field for the intermediate object files.

Jan 11 2019, 1:24 PM · lld
joerg added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

That's the other reason why I find the GCC specification as string prefix confusing. I still say we should just go with mapping of path names and then the order question mostly goes away.

Jan 11 2019, 6:55 AM · Restricted Project
joerg added inline comments to D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Jan 11 2019, 5:57 AM · lld

Jan 8 2019

joerg added inline comments to D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Jan 8 2019, 1:48 PM · lld
joerg added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

@ruiu: No, it is exactly what you want, since it allows you to point lld into the normal sysroot. Cross-compiling is the default case for the NetBSD toolchain.

Jan 8 2019, 1:40 PM · lld
joerg added inline comments to D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Jan 8 2019, 12:59 PM · lld
joerg added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Thanks, this looks like a good starting point.

Jan 8 2019, 12:59 PM · lld

Jan 4 2019

joerg added a comment to D56325: Sort symbols in .bss by size..

It can certainly make it worse, e.g. if you have one input section with half page size and page alignment followed by another input section with half page size. Depending on the precise size and order, it will fit into one page or two. It's a bit constructured, but gives the general idea.

Jan 4 2019, 2:28 PM
joerg added a comment to D56325: Sort symbols in .bss by size..

I think this should factor in any larger-than-normal alignment, otherwise it could easily result in a significant increase in size?

Jan 4 2019, 1:27 PM

Jan 3 2019

joerg added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Talking from the perspective of having had to deal with thousands of packages in pkgsrc over the years: it is naive to believe that there isn't a lot of software that calls the linker directly for various reasons. As such, it is very important to have a useful configuration in the linker by default. Such a configuration is by its very nature target specific. This doesn't mean it can't be done in a cross-compiler friendly way, on the contrary. Over the years NetBSD has been pushing its toolchain to be as similar for the native build and a cross-target as reasonable possible. Modulo the build time choices in the config.h sense, the only difference between the native and cross tools is the built-in default of the former.

Jan 3 2019, 11:16 AM · lld

Jan 2 2019

joerg added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

This doesn't seem a reasonable approach at all:

(1) It breaks cross-linking.
(2) It is not correct for any target architecture, e.g. /usr/local/lib certainly doesn't belong on this list and /lib doesn't either.
(3) The correct list depends not only on the target architecture, but also the active emulation.

Is it acceptable to pass all the paths through configure/build phase of lld? It's done this way in GNU ld in the NetBSD distribution. If we need or want to hardcode all the specific paths it will be harder to maintain the proper list and behavior inside lld.

Jan 2 2019, 3:26 PM · lld
joerg added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

This doesn't seem a reasonable approach at all:

Jan 2 2019, 1:34 PM · lld

Dec 27 2018

joerg added a comment to D55998: ELF: create "container" sections from PT_LOAD segments.

I foundamentally don't understand what you are trying to do. You can either look at the executable from a segment perspective or from a section perspective. But trying to mix the views is bound to give bogus results.

Dec 27 2018, 8:11 AM

Dec 24 2018

joerg added a comment to D55998: ELF: create "container" sections from PT_LOAD segments.

it is in theory possible to create an elf file where only a part of a section would belong to some segment (and another part to a different one).

ELF standard: "An object file segment contains one or more sections.", "An object file segment comprises one or more sections"

Dec 24 2018, 4:37 PM

Dec 11 2018

joerg added a comment to D43871: [modules] No longer include stdlib.h from mm_malloc.h..

This header is used on systems without glibc. So please don't argue about behavior based only on that. Granted, most other libc implementation are less annoying when it comes to free and malloc, but still.

Dec 11 2018, 1:16 PM
joerg added inline comments to D55542: [llvm-xray] Support for PIE.
Dec 11 2018, 12:55 PM

Dec 10 2018

joerg added a comment to D55167: Add a new interceptors for cdbr(3) and cdbw(3) API from NetBSD.

I don't see why this interceptor needs to know about the internals of struct cdbr or struct cdbw at all. They are fully opaque. All memory accessed by users is explicitly sized as argument to the functions or returned with the size.

Then we give up on TSAN check of fieds, or msan check if caller will try to read particular fields

Dec 10 2018, 2:49 PM · Restricted Project

Dec 9 2018

joerg added a comment to D55167: Add a new interceptors for cdbr(3) and cdbw(3) API from NetBSD.

I don't see why this interceptor needs to know about the internals of struct cdbr or struct cdbw at all. They are fully opaque. All memory accessed by users is explicitly sized as argument to the functions or returned with the size.

Dec 9 2018, 11:31 AM · Restricted Project

Dec 3 2018

joerg added a comment to D55213: Python2/3 compat - print.

I'd recomment another pass to reduce the now fully redundant () pairs around % string substitutions, but in principle LGTM.

Dec 3 2018, 5:07 AM
joerg accepted D55207: Python 2/3 compat - shebang.

LGTM

Dec 3 2018, 4:17 AM
joerg requested changes to D55199: Python2/3 compat - urllib.
Dec 3 2018, 4:16 AM
joerg accepted D55198: Python 2/3 compat - type destructuring.

LGTM

Dec 3 2018, 4:14 AM
joerg added inline comments to D55196: Python2/3 compatibility - StringIO.
Dec 3 2018, 4:10 AM
joerg accepted D55195: Python2/3 compat - exceptions.

LGTM

Dec 3 2018, 4:06 AM
joerg added a comment to D55194: Python2/3 compatiility - has_key.

LGTM

Dec 3 2018, 4:04 AM

Dec 2 2018

joerg added a comment to D55121: Make several Python scripts portable across Python2 and Python 3.

Can you split off the pure modernisation changes like new exception or print ? Those are completely non-contentious changes after all. I generally do not like the range and list related changes as many instances are clear regressions for the 2.x case. filter to list comprehension should IMO be a separate change as well, but those are much less problematic and often an improvement in terms of both performance and readability.

Dec 2 2018, 11:29 AM

Nov 19 2018

joerg added a comment to D54657: [clang] Do not dump compilation-database entries for -E..

I'm sorry, but it still sounds to me like you want to address badly written build rules by making the driver more complicated. I don't see that is a reasonable goal forward.

Nov 19 2018, 12:12 PM

Nov 17 2018

joerg added a comment to D54657: [clang] Do not dump compilation-database entries for -E..

I don't understand the point here. Why would you want to include pre-processing-only commands in the compilation database?

Nov 17 2018, 7:09 AM

Nov 16 2018

joerg added a comment to D54605: [lld][ELF] Add negative test coverage for unknown "-z" flags..

Well, I do like the general idea. I would go with a sorted static array and a binary search though. This is not really time critical, but the array version would be smaller in terms of code without involving run-time allocations.

Nov 16 2018, 6:32 AM

Nov 13 2018

joerg added a comment to D54328: Added 'cd -' built in to lit.

I would actually rule out subshells as well. I see no reason why a test case should have to use them, i.e. compared to just change the working directory back afterwards. As I said, I want to be able to repeat a problematic command manually and interactively as easy as possible. Using non-portable shell features is a problem for that. Depending on state between commands is also annoying. Let's really try to keep it minimal and where necessary, adjust test case guidelines and test cases to simplify things.

Nov 13 2018, 3:36 PM
joerg added a comment to D54328: Added 'cd -' built in to lit.

As I said: because it makes it harder to rerun parts of the test interactively. Which is a good enough reason to forbid cd - as well as any directory stack operations, IMO.

Nov 13 2018, 2:24 PM

Nov 12 2018

joerg added a comment to D54328: Added 'cd -' built in to lit.

Personally, I would strongly prefer if the test cases are as explicit as possible. That makes debugging based on the llvm-lit output a lot easier. Ignoring anything else, this feature would make it a lot more tricky to figure out what exactly is going on.

Nov 12 2018, 5:53 PM

Nov 11 2018

joerg requested changes to D54328: Added 'cd -' built in to lit.

I'm quite against this. "cd -" is a non-portable extension to shell and should never be used in first place.

Nov 11 2018, 2:07 PM

Nov 9 2018

joerg added a comment to D54338: Fix threads build on GNU/Hurd.

I think I would enumerate the BSDs here (and Apple) explicitly and not depend on BSD.

Nov 9 2018, 2:14 PM

Nov 5 2018

joerg added a comment to D34018: Support __float128 on NetBSD libstdc++ x86/x86_64.

Nothing changed. I don't see how catering to the broken libstdc++ self-configuration helps. So no, I still object to this change.

Nov 5 2018, 4:44 AM

Nov 4 2018

joerg added inline comments to D33878: Handle NetBSD specific _Unwind_Ptr.
Nov 4 2018, 2:40 PM

Oct 30 2018

joerg added a comment to D53838: [builtins] Re-enable x86-only long double tests.

__m68k__ and __ia64__ too, just for completeness.

Oct 30 2018, 5:58 AM

Oct 24 2018

joerg added a comment to D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .

To summarize the discussion on IRC, from my perspective this change is wrong. PPC as architecture is strongly geared towards PIC code. We used to create quite bad position dependent code and I generally don't see the advantage. I can understand wanting to default to PIE (i.e. position independent code with main binary assumption as far as interception is considered). In other words, the middle end generally tended to create better results for position independent codegen. The default behavior of GCC is ephemeral here, IMO.

Oct 24 2018, 1:35 PM

Oct 19 2018

joerg added a comment to D34796: upporting -f(no)-reorder-functions flag, clang side change.

Excuse me for bring this up so late, but why do we want to make any such promises? As in: fundamentally, LLVM IR doesn't have any order property on the module level. I have yet so seen reasonable code where the order of functions matters for anything but performance. I've seen a few things that required -funit-at-a-time, most noticable GCC's CRT implementation. But those are all major hacks. So under what premise is it useful to have to even pretend to honor source code order?

Oct 19 2018, 4:34 AM

Oct 1 2018

joerg added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Oct 1 2018, 11:38 AM · Restricted Project

Sep 30 2018

joerg added a comment to D52696: Update ifunc attribute support documentation.

Yeah, I would restrict it to just mention that it depends on the target, link time editor and runtime linker. Even the concrete feature set on Linux changes with glibc versions.

Sep 30 2018, 6:21 PM
joerg added a comment to D52696: Update ifunc attribute support documentation.

I think this is still too optimistic. Full support for ifunc seems to be generally limited to x86. Most other architectures lack even definitions for anonymous ifunc relocations or support proper relaxation only in limited forms. That's especially annoying when looking at static linking.

Sep 30 2018, 11:00 AM

Sep 16 2018

joerg added a comment to D52137: Added warning for unary minus used with unsigned type.

I find this warning confusing. I find a4 to be perfectly expected. IMO this warning should be applied only, if the effective value of the expression is not the same as in the modulo-n arithmetic. This means that if (-x) is explicitly or implicitly cast to a less wide unsigned type, it should not warn. It would consider a warning for the case of using (-x) if integer promotion rules makes it negative though. The question is, how to best patch around the warning though. What options does MSVC have for that? I.e. what equivalent expressions do not trigger this warning?

Sep 16 2018, 11:25 AM

Sep 6 2018

joerg added a comment to D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89.

Correct. The protected name is double underscore as both suffix and prefix.

Sep 6 2018, 12:53 PM

Sep 5 2018

joerg added inline comments to D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89.
Sep 5 2018, 8:28 AM

Sep 4 2018

joerg added a comment to D43871: [modules] No longer include stdlib.h from mm_malloc.h..

Please check the history of the file for some of the problems with the redefinition. I'm quite against this change.

Sep 4 2018, 4:42 AM

Aug 31 2018

joerg added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

Every system call has a public and internal variant. The former might be replaced by libpthread etc for thread cancellation support, but that's a different topic.

Aug 31 2018, 5:59 AM · Restricted Project

Aug 29 2018

joerg added a comment to D50969: [Sparc] Improve the builtin setjmp/longjmp.

Yes, it is optional, but on most architectures, the builtin variant is much cheaper. That said, I'm not sure what the situation is on SPARC with the necessary register window flush.

Aug 29 2018, 3:44 PM
joerg added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

I don't understand why most of this symbols don't reference the plain system call directly, i.e. _sys_read etc.

Aug 29 2018, 3:25 PM · Restricted Project
joerg added a comment to D50969: [Sparc] Improve the builtin setjmp/longjmp.

There is one user of builtin_setjmp/builtin_longjmp that should be kept in mind: Ruby.

Aug 29 2018, 2:42 PM

Aug 20 2018

joerg accepted D47814: Teach libc++ to use native NetBSD's max_align_t.
Aug 20 2018, 1:11 PM
joerg requested changes to D47814: Teach libc++ to use native NetBSD's max_align_t.
Aug 20 2018, 1:10 PM
joerg added a comment to D50413: [libunwind][include] Add some missing definitions to <unwind.h>..

Is there a reason for defining them? As in: does anything outside libunwind use them? I haven't seen such software yet.

Aug 20 2018, 12:04 PM
joerg added a comment to D50966: Fix an undefined behavior when storing an empty StringRef..

Why do we need to allocate memory in this case at all? I.e. why can't this just be:

if (S.empty())
  return StringRef("", 0);
...
Aug 20 2018, 6:28 AM

Aug 16 2018

joerg added inline comments to D50839: [llvm] Make YAML serialization up to 2.5 times faster.
Aug 16 2018, 9:37 AM
joerg added inline comments to D50839: [llvm] Make YAML serialization up to 2.5 times faster.
Aug 16 2018, 6:52 AM
joerg added a comment to D50243: [libunwind][mips] Include gcc_s for linkage.

If a build against compiler-rt works, that's ok. It wasn't clear from the diff.

Aug 16 2018, 4:50 AM

Aug 15 2018

joerg added a comment to D50477: WIP: Ensure that the type of size_t is represended as one of the fixed width types.

I don't understand the desire for this logic. Why can't wasm override the rest of the types if it wants to have something special?

Aug 15 2018, 2:53 PM
joerg added a comment to D50243: [libunwind][mips] Include gcc_s for linkage.

This hard-coding seems to be counter-productive, it could be compiler-rt just as well.

Aug 15 2018, 6:14 AM

Aug 1 2018

joerg added a comment to D49771: CodeGen: use non-zero memset when possible for automatic variables.

There are two different considerations here:
(1) Create less target code
(2) Create less IR

Aug 1 2018, 10:19 AM

Jul 24 2018

joerg added a comment to D49763: [CUDA] Call atexit() for CUDA destructor early on..

Depends a bit on the platform, __cxa_atexit on most modern ELF systems, fallback to atexit. If the global dtor is run too late, it smells like a missing library dependency. They are executed in topological order after all.

Jul 24 2018, 4:24 PM
joerg added a comment to D49763: [CUDA] Call atexit() for CUDA destructor early on..

Can this ever end up in a shared library? If yes, please use the normal logic for creating a global destructor. atexit is not very friendly to dlopen...

Jul 24 2018, 3:52 PM

Jul 18 2018

joerg added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jul 18 2018, 1:44 PM · Restricted Project
joerg requested changes to D49481: Haiku: Enable thread-local storage and disable PIE by default.

Both needs a test case :)

Jul 18 2018, 8:27 AM
joerg added a comment to D49482: Haiku: add a test for haiku driver.

It seems to miss most of the interesting checks, i.e. crt files. Compare with any of the entries on netbsd.c for example.

Jul 18 2018, 7:35 AM
joerg requested changes to D49480: Haiku: support for secondary arch.

This is absolutely not how the clang driver is supposed to work. No conditional compilation.

Jul 18 2018, 7:34 AM

Jul 17 2018

joerg committed rUNW337312: The semantics of DW_CFA_GNU_args_size have changed subtile over the.
The semantics of DW_CFA_GNU_args_size have changed subtile over the
Jul 17 2018, 12:38 PM
joerg committed rL337312: The semantics of DW_CFA_GNU_args_size have changed subtile over the.
The semantics of DW_CFA_GNU_args_size have changed subtile over the
Jul 17 2018, 12:06 PM
joerg closed D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.
Jul 17 2018, 12:06 PM
joerg committed rC337277: Always use __mcount on NetBSD. Some platforms don't provide _mcount..
Always use __mcount on NetBSD. Some platforms don't provide _mcount.
Jul 17 2018, 6:19 AM
joerg committed rL337277: Always use __mcount on NetBSD. Some platforms don't provide _mcount..
Always use __mcount on NetBSD. Some platforms don't provide _mcount.
Jul 17 2018, 6:18 AM
joerg committed rL337274: For NetBSD, unwind data is emitted by default, so also enable frame.
For NetBSD, unwind data is emitted by default, so also enable frame
Jul 17 2018, 5:44 AM
joerg committed rC337274: For NetBSD, unwind data is emitted by default, so also enable frame.
For NetBSD, unwind data is emitted by default, so also enable frame
Jul 17 2018, 5:44 AM
joerg committed rL337271: By popular demand, switch in64_t on NetBSD/AArch64 and NetBSD/PowerPC64.
By popular demand, switch in64_t on NetBSD/AArch64 and NetBSD/PowerPC64
Jul 17 2018, 5:38 AM
joerg committed rC337271: By popular demand, switch in64_t on NetBSD/AArch64 and NetBSD/PowerPC64.
By popular demand, switch in64_t on NetBSD/AArch64 and NetBSD/PowerPC64
Jul 17 2018, 5:38 AM
joerg committed rL337269: Don't assert that a size_t fits into 64bit..
Don't assert that a size_t fits into 64bit.
Jul 17 2018, 5:35 AM

Jul 15 2018

joerg committed rL337139: Prune empty directory..
Prune empty directory.
Jul 15 2018, 4:57 PM

Jul 12 2018

joerg committed rC336947: Support linking static PIE binaries on NetBSD.
Support linking static PIE binaries on NetBSD
Jul 12 2018, 2:26 PM
joerg committed rL336947: Support linking static PIE binaries on NetBSD.
Support linking static PIE binaries on NetBSD
Jul 12 2018, 2:26 PM

Jul 9 2018

joerg added a comment to D48915: [Sparc] Use the names .rem and .urem instead of __modsi3 and __umodsi3.

Looking further, at least on NetBSD libgcc seems to always include both the "normal" and the .rem/.urem routines. While we currently don't replace __umodsi3 and friends, that looks more like an oversight on our part.
I asked the Sparc folks and they can't remember any special reason for why .urem should be used. I.e. it follows the normal Sparc ABI.
As such, I'm mostly ambivalent on this change and the rest of the block.

Jul 9 2018, 7:33 AM

Jul 5 2018

joerg added a comment to D48915: [Sparc] Use the names .rem and .urem instead of __modsi3 and __umodsi3.

Not what I mean. Certain platforms like Sparc and SH link a copy of certain routines into every DSO. This is the so-called milli code. They sometimes use special calling conventions as well. That's different from the "normal" helper routines in libgcc, which are shared by all libraries.

Jul 5 2018, 4:21 AM

Jul 4 2018

joerg added a comment to D48915: [Sparc] Use the names .rem and .urem instead of __modsi3 and __umodsi3.

That would be the milli code version, wouldn't it?

Jul 4 2018, 3:43 PM

Jun 18 2018

joerg added a comment to D48244: hfghgfhfgh.

Please update the summary / title

Jun 18 2018, 11:12 AM

Jun 5 2018

joerg updated the diff for D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.

After a careful review of newer GCC / libgcc and the assembler annotations from LLVM, I have come to the following conclusions:

Jun 5 2018, 3:12 PM
joerg commandeered D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.
Jun 5 2018, 3:03 PM

May 22 2018

joerg added a comment to D47138: [Sparc] Use the leon arch for Leon3's when using an external assembler.

This still needs a test case?

May 22 2018, 4:19 PM

May 9 2018

joerg added a comment to D46585: Align ClearShadowForThreadStackAndTLS for NetBSD/i386.

This looks sensible, but I don't know what PoisonShadow will do for the rest of the memory block.

May 9 2018, 6:32 AM · Restricted Project

May 8 2018

joerg added a comment to D46544: Set DF_TEXTREL only if text relocations are really needed..

"-z textrel" can also be used in build instructions if some platforms will need it, even if not all of them do.

May 8 2018, 3:12 PM

Apr 27 2018

joerg added a comment to D46082: [LowerTypeTests] Mark .cfi.jumptable nounwind..

Yes, if that option is enabled explicitly or implicitly in the frontend, the expectation is that all compiler-generated functions have uwtable as well.

Apr 27 2018, 12:58 PM
joerg added a comment to D46082: [LowerTypeTests] Mark .cfi.jumptable nounwind..

Given that .eh_frame sections can be used to create backtraces i.e. from signal handlers, this seems to be undesirable in the generality. Shouldn't this attribute be conditional on whether functions are normally supposed to have unwind data?

Apr 27 2018, 6:58 AM

Apr 24 2018

joerg added a comment to D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.

I'm back to the point where I can't reproduce the problem :( Can we start providing an actual failing test case? It's annoying to debug a problem when you can't reproduce it.

Apr 24 2018, 12:57 PM

Apr 23 2018

joerg added a comment to D41240: [Solaris] __float128 is supported on Solaris/x86.

Things are different for a libgcc-based toolchain and a compiler-rt based toolchain.

Apr 23 2018, 11:50 AM