This patch adds DWARF support for XCOFF when clang generates object output. For now, it only works for 32-bit XCOFF.
D95518 adds DWARF support for XCOFF when clang generates assembly output.
Paths
| Differential D97184
[XCOFF] support DWARF for 32-bit XCOFF for object output ClosedPublic Authored by shchenz on Feb 22 2021, 12:48 AM.
Details
Summary This patch adds DWARF support for XCOFF when clang generates object output. For now, it only works for 32-bit XCOFF. D95518 adds DWARF support for XCOFF when clang generates assembly output.
Diff Detail
Event Timelineshchenz mentioned this in D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.Feb 22 2021, 12:55 AM shchenz added parent revisions: D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF, D97117: [XCOFF] add C_FILE symbol at index 0, D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer. shchenz retitled this revision from [XCOFF] support DWARF of XCOFF object output to [XCOFF] support DWARF for XCOFF for object output. shchenz added a parent revision: D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.Feb 22 2021, 1:03 AM Comment Actions FYI, I decide to review this patch before D97049 because I wouldn't know if the NFC make sense without the context of this patch.
Comment Actions @jasonliu Thanks for your comments. Please see my inline reply.
Comment Actions thanks for your review @jasonliu
shchenz added a parent revision: D99257: [XCOFF] dynamically allocating the section and csect group .Mar 24 2021, 6:05 AM
jsji retitled this revision from [XCOFF] support DWARF for XCOFF for object output to [XCOFF] support DWARF for 32-bit XCOFF for object output. Comment ActionsLGTM as the first prototype, let us get this in first, we can always refactor later if needed. This revision is now accepted and ready to land.Oct 6 2021, 8:26 AM This revision was landed with ongoing or failed builds.Oct 7 2021, 7:41 PM Closed by commit rG5f4c91583ee7: [XCOFF] support DWARF for 32-bit XCOFF for object output (authored by shchenz). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions Looks like this breaks tests on windows: http://45.33.8.238/win/46579/step_11.txt Please take a look and revert for now if it takes a while to fix. Comment Actions
Thanks. 7c1171a0f36ac244d687cd9d3d456f8e5de58b5c is committed
Revision Contents
Diff 332963 llvm/lib/MC/MCSectionXCOFF.cpp
llvm/lib/MC/XCOFFObjectWriter.cpp
llvm/test/CodeGen/PowerPC/aix-dwarf.ll
llvm/test/DebugInfo/XCOFF/empty.ll
|
Retain the assert after returning for the DWARF section case.